All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd: Limit seamless boot by default to APUs
@ 2023-09-26  1:44 Mario Limonciello
  2023-09-26 15:07 ` Deucher, Alexander
  0 siblings, 1 reply; 2+ messages in thread
From: Mario Limonciello @ 2023-09-26  1:44 UTC (permalink / raw)
  To: amd-gfx; +Cc: Alexander.Deucher, feifei.xu, Mario Limonciello

A hang is reported on DCN 3.2 with seamless boot enabled.
As the benefits come from an eDP setup, limit it to only enabled
by default with APUs.

Suggested-by: Alexander.Deucher@amd.com
Reported-by: feifei.xu@amd.com
Closes: https://lore.kernel.org/amd-gfx/85b427f6-11ec-4249-bf6f-eadf9c375f88@amd.com/T/#m2887e919d7c01b2a4860d2261b366d22e070f309
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 22c0e035de81..5436d7a34014 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1380,6 +1380,9 @@ bool amdgpu_device_seamless_boot_supported(struct amdgpu_device *adev)
 		return false;
 	}
 
+	if (!(adev->flags & AMD_IS_APU))
+		return false;
+
 	if (adev->mman.keep_stolen_vga_memory)
 		return false;
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/amd: Limit seamless boot by default to APUs
  2023-09-26  1:44 [PATCH] drm/amd: Limit seamless boot by default to APUs Mario Limonciello
@ 2023-09-26 15:07 ` Deucher, Alexander
  0 siblings, 0 replies; 2+ messages in thread
From: Deucher, Alexander @ 2023-09-26 15:07 UTC (permalink / raw)
  To: Limonciello, Mario, amd-gfx; +Cc: Xu, Feifei

[-- Attachment #1: Type: text/plain, Size: 1555 bytes --]

[AMD Official Use Only - General]

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
________________________________
From: Limonciello, Mario <Mario.Limonciello@amd.com>
Sent: Monday, September 25, 2023 9:44 PM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Limonciello, Mario <Mario.Limonciello@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Xu, Feifei <Feifei.Xu@amd.com>
Subject: [PATCH] drm/amd: Limit seamless boot by default to APUs

A hang is reported on DCN 3.2 with seamless boot enabled.
As the benefits come from an eDP setup, limit it to only enabled
by default with APUs.

Suggested-by: Alexander.Deucher@amd.com
Reported-by: feifei.xu@amd.com
Closes: https://lore.kernel.org/amd-gfx/85b427f6-11ec-4249-bf6f-eadf9c375f88@amd.com/T/#m2887e919d7c01b2a4860d2261b366d22e070f309
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 22c0e035de81..5436d7a34014 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1380,6 +1380,9 @@ bool amdgpu_device_seamless_boot_supported(struct amdgpu_device *adev)
                 return false;
         }

+       if (!(adev->flags & AMD_IS_APU))
+               return false;
+
         if (adev->mman.keep_stolen_vga_memory)
                 return false;

--
2.34.1


[-- Attachment #2: Type: text/html, Size: 3171 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-26 15:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-26  1:44 [PATCH] drm/amd: Limit seamless boot by default to APUs Mario Limonciello
2023-09-26 15:07 ` Deucher, Alexander

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.