* [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()
@ 2022-09-01 14:15 ` Hamza Mahfooz
0 siblings, 0 replies; 8+ messages in thread
From: Hamza Mahfooz @ 2022-09-01 14:15 UTC (permalink / raw)
To: linux-kernel
Cc: Hamza Mahfooz, Harry Wentland, Leo Li, Rodrigo Siqueira,
Alex Deucher, Christian König, Pan, Xinhui, David Airlie,
Daniel Vetter, Nicholas Kazlauskas, Jun Lei,
Meenakshikumar Somasundaram, Alvin Lee, Martin Leung, Samson Tam,
Alex Hung, Wenjing Liu, Joshua Aberback, amd-gfx, dri-devel
Address the following warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
3508 | if (update_type != UPDATE_TYPE_FAST)
| ^~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
3510 | if (update_type != UPDATE_TYPE_FAST)
| ^~
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
v2: implement feedback from Alvin
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index b49237390cce..9860bf38c547 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc,
if (update_type != UPDATE_TYPE_FAST)
dc->hwss.post_unlock_program_front_end(dc, context);
- if (update_type != UPDATE_TYPE_FAST)
- if (dc->hwss.commit_subvp_config)
- dc->hwss.commit_subvp_config(dc, context);
+
+ if (update_type != UPDATE_TYPE_FAST)
+ if (dc->hwss.commit_subvp_config)
+ dc->hwss.commit_subvp_config(dc, context);
/* Since phantom pipe programming is moved to post_unlock_program_front_end,
* move the SubVP lock to after the phantom pipes have been setup
--
2.37.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()
@ 2022-09-01 14:15 ` Hamza Mahfooz
0 siblings, 0 replies; 8+ messages in thread
From: Hamza Mahfooz @ 2022-09-01 14:15 UTC (permalink / raw)
To: linux-kernel
Cc: Joshua Aberback, amd-gfx, Leo Li, Wenjing Liu, dri-devel, Pan,
Xinhui, Rodrigo Siqueira, Samson Tam, Nicholas Kazlauskas,
Meenakshikumar Somasundaram, David Airlie, Alex Hung,
Hamza Mahfooz, Daniel Vetter, Martin Leung, Alex Deucher,
Jun Lei, Harry Wentland, Christian König, Alvin Lee
Address the following warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
3508 | if (update_type != UPDATE_TYPE_FAST)
| ^~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
3510 | if (update_type != UPDATE_TYPE_FAST)
| ^~
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
v2: implement feedback from Alvin
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index b49237390cce..9860bf38c547 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc,
if (update_type != UPDATE_TYPE_FAST)
dc->hwss.post_unlock_program_front_end(dc, context);
- if (update_type != UPDATE_TYPE_FAST)
- if (dc->hwss.commit_subvp_config)
- dc->hwss.commit_subvp_config(dc, context);
+
+ if (update_type != UPDATE_TYPE_FAST)
+ if (dc->hwss.commit_subvp_config)
+ dc->hwss.commit_subvp_config(dc, context);
/* Since phantom pipe programming is moved to post_unlock_program_front_end,
* move the SubVP lock to after the phantom pipes have been setup
--
2.37.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()
2022-09-01 14:15 ` Hamza Mahfooz
@ 2022-09-01 14:38 ` Deucher, Alexander
-1 siblings, 0 replies; 8+ messages in thread
From: Deucher, Alexander @ 2022-09-01 14:38 UTC (permalink / raw)
To: Mahfooz, Hamza, linux-kernel
Cc: Aberback, Joshua, amd-gfx, Li, Sun peng (Leo),
Liu, Wenjing, dri-devel, Pan, Xinhui, Siqueira, Rodrigo, Tam,
Samson, Kazlauskas, Nicholas, Somasundaram, Meenakshikumar,
David Airlie, Hung, Alex, Lee, Alvin, Daniel Vetter, Leung,
Martin, Lei, Jun, Wentland, Harry, Koenig, Christian
[-- Attachment #1: Type: text/plain, Size: 2863 bytes --]
[Public]
Acked-by: Alex Deucher <alexander.deucher@amd.com>
________________________________
From: Mahfooz, Hamza <Hamza.Mahfooz@amd.com>
Sent: Thursday, September 1, 2022 10:15 AM
To: linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
Cc: Mahfooz, Hamza <Hamza.Mahfooz@amd.com>; Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; David Airlie <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>; Lei, Jun <Jun.Lei@amd.com>; Somasundaram, Meenakshikumar <Meenakshikumar.Somasundaram@amd.com>; Lee, Alvin <Alvin.Lee2@amd.com>; Leung, Martin <Martin.Leung@amd.com>; Tam, Samson <Samson.Tam@amd.com>; Hung, Alex <Alex.Hung@amd.com>; Liu, Wenjing <Wenjing.Liu@amd.com>; Aberback, Joshua <Joshua.Aberback@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>
Subject: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()
Address the following warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
3508 | if (update_type != UPDATE_TYPE_FAST)
| ^~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
3510 | if (update_type != UPDATE_TYPE_FAST)
| ^~
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
v2: implement feedback from Alvin
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index b49237390cce..9860bf38c547 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc,
if (update_type != UPDATE_TYPE_FAST)
dc->hwss.post_unlock_program_front_end(dc, context);
- if (update_type != UPDATE_TYPE_FAST)
- if (dc->hwss.commit_subvp_config)
- dc->hwss.commit_subvp_config(dc, context);
+
+ if (update_type != UPDATE_TYPE_FAST)
+ if (dc->hwss.commit_subvp_config)
+ dc->hwss.commit_subvp_config(dc, context);
/* Since phantom pipe programming is moved to post_unlock_program_front_end,
* move the SubVP lock to after the phantom pipes have been setup
--
2.37.2
[-- Attachment #2: Type: text/html, Size: 5093 bytes --]
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()
@ 2022-09-01 14:38 ` Deucher, Alexander
0 siblings, 0 replies; 8+ messages in thread
From: Deucher, Alexander @ 2022-09-01 14:38 UTC (permalink / raw)
To: Mahfooz, Hamza, linux-kernel
Cc: Aberback, Joshua, amd-gfx, Li, Sun peng (Leo),
Liu, Wenjing, dri-devel, Pan, Xinhui, Siqueira, Rodrigo, Tam,
Samson, Kazlauskas, Nicholas, Somasundaram, Meenakshikumar,
David Airlie, Hung, Alex, Lee, Alvin, Leung, Martin, Lei, Jun,
Koenig, Christian
[-- Attachment #1: Type: text/plain, Size: 2863 bytes --]
[Public]
Acked-by: Alex Deucher <alexander.deucher@amd.com>
________________________________
From: Mahfooz, Hamza <Hamza.Mahfooz@amd.com>
Sent: Thursday, September 1, 2022 10:15 AM
To: linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
Cc: Mahfooz, Hamza <Hamza.Mahfooz@amd.com>; Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; David Airlie <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>; Lei, Jun <Jun.Lei@amd.com>; Somasundaram, Meenakshikumar <Meenakshikumar.Somasundaram@amd.com>; Lee, Alvin <Alvin.Lee2@amd.com>; Leung, Martin <Martin.Leung@amd.com>; Tam, Samson <Samson.Tam@amd.com>; Hung, Alex <Alex.Hung@amd.com>; Liu, Wenjing <Wenjing.Liu@amd.com>; Aberback, Joshua <Joshua.Aberback@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>
Subject: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()
Address the following warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
3508 | if (update_type != UPDATE_TYPE_FAST)
| ^~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
3510 | if (update_type != UPDATE_TYPE_FAST)
| ^~
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
v2: implement feedback from Alvin
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index b49237390cce..9860bf38c547 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc,
if (update_type != UPDATE_TYPE_FAST)
dc->hwss.post_unlock_program_front_end(dc, context);
- if (update_type != UPDATE_TYPE_FAST)
- if (dc->hwss.commit_subvp_config)
- dc->hwss.commit_subvp_config(dc, context);
+
+ if (update_type != UPDATE_TYPE_FAST)
+ if (dc->hwss.commit_subvp_config)
+ dc->hwss.commit_subvp_config(dc, context);
/* Since phantom pipe programming is moved to post_unlock_program_front_end,
* move the SubVP lock to after the phantom pipes have been setup
--
2.37.2
[-- Attachment #2: Type: text/html, Size: 5093 bytes --]
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()
2022-09-01 14:15 ` Hamza Mahfooz
(?)
@ 2022-09-01 15:47 ` Rodrigo Siqueira Jordao
-1 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Siqueira Jordao @ 2022-09-01 15:47 UTC (permalink / raw)
To: Hamza Mahfooz, linux-kernel
Cc: Harry Wentland, Leo Li, Alex Deucher, Christian König, Pan,
Xinhui, David Airlie, Daniel Vetter, Nicholas Kazlauskas,
Jun Lei, Meenakshikumar Somasundaram, Alvin Lee, Martin Leung,
Samson Tam, Alex Hung, Wenjing Liu, Joshua Aberback, amd-gfx,
dri-devel
On 2022-09-01 10:15, Hamza Mahfooz wrote:
> Address the following warning:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
> 3508 | if (update_type != UPDATE_TYPE_FAST)
> | ^~
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
> 3510 | if (update_type != UPDATE_TYPE_FAST)
> | ^~
>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> v2: implement feedback from Alvin
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index b49237390cce..9860bf38c547 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc,
>
> if (update_type != UPDATE_TYPE_FAST)
> dc->hwss.post_unlock_program_front_end(dc, context);
> - if (update_type != UPDATE_TYPE_FAST)
> - if (dc->hwss.commit_subvp_config)
> - dc->hwss.commit_subvp_config(dc, context);
> +
> + if (update_type != UPDATE_TYPE_FAST)
> + if (dc->hwss.commit_subvp_config)
> + dc->hwss.commit_subvp_config(dc, context);
>
> /* Since phantom pipe programming is moved to post_unlock_program_front_end,
> * move the SubVP lock to after the phantom pipes have been setup
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
and applied to amd-staging-drm-next.
Thanks
Siqueira
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()
@ 2022-09-01 15:47 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Siqueira Jordao @ 2022-09-01 15:47 UTC (permalink / raw)
To: Hamza Mahfooz, linux-kernel
Cc: Joshua Aberback, amd-gfx, Leo Li, dri-devel, Pan, Xinhui,
Wenjing Liu, Samson Tam, Nicholas Kazlauskas,
Meenakshikumar Somasundaram, David Airlie, Alex Hung, Alvin Lee,
Daniel Vetter, Martin Leung, Alex Deucher, Jun Lei,
Harry Wentland, Christian König
On 2022-09-01 10:15, Hamza Mahfooz wrote:
> Address the following warning:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
> 3508 | if (update_type != UPDATE_TYPE_FAST)
> | ^~
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
> 3510 | if (update_type != UPDATE_TYPE_FAST)
> | ^~
>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> v2: implement feedback from Alvin
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index b49237390cce..9860bf38c547 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc,
>
> if (update_type != UPDATE_TYPE_FAST)
> dc->hwss.post_unlock_program_front_end(dc, context);
> - if (update_type != UPDATE_TYPE_FAST)
> - if (dc->hwss.commit_subvp_config)
> - dc->hwss.commit_subvp_config(dc, context);
> +
> + if (update_type != UPDATE_TYPE_FAST)
> + if (dc->hwss.commit_subvp_config)
> + dc->hwss.commit_subvp_config(dc, context);
>
> /* Since phantom pipe programming is moved to post_unlock_program_front_end,
> * move the SubVP lock to after the phantom pipes have been setup
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
and applied to amd-staging-drm-next.
Thanks
Siqueira
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()
@ 2022-09-01 15:47 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Siqueira Jordao @ 2022-09-01 15:47 UTC (permalink / raw)
To: Hamza Mahfooz, linux-kernel
Cc: Joshua Aberback, amd-gfx, Leo Li, dri-devel, Pan, Xinhui,
Wenjing Liu, Samson Tam, Nicholas Kazlauskas,
Meenakshikumar Somasundaram, David Airlie, Alex Hung, Alvin Lee,
Martin Leung, Alex Deucher, Jun Lei, Christian König
On 2022-09-01 10:15, Hamza Mahfooz wrote:
> Address the following warning:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
> 3508 | if (update_type != UPDATE_TYPE_FAST)
> | ^~
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
> 3510 | if (update_type != UPDATE_TYPE_FAST)
> | ^~
>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> v2: implement feedback from Alvin
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index b49237390cce..9860bf38c547 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc,
>
> if (update_type != UPDATE_TYPE_FAST)
> dc->hwss.post_unlock_program_front_end(dc, context);
> - if (update_type != UPDATE_TYPE_FAST)
> - if (dc->hwss.commit_subvp_config)
> - dc->hwss.commit_subvp_config(dc, context);
> +
> + if (update_type != UPDATE_TYPE_FAST)
> + if (dc->hwss.commit_subvp_config)
> + dc->hwss.commit_subvp_config(dc, context);
>
> /* Since phantom pipe programming is moved to post_unlock_program_front_end,
> * move the SubVP lock to after the phantom pipes have been setup
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
and applied to amd-staging-drm-next.
Thanks
Siqueira
^ permalink raw reply [flat|nested] 8+ messages in thread