All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: drop flood print in rlcg reg access function
@ 2022-01-28 15:19 Guchun Chen
  2022-01-28 15:36 ` Deucher, Alexander
  0 siblings, 1 reply; 2+ messages in thread
From: Guchun Chen @ 2022-01-28 15:19 UTC (permalink / raw)
  To: amd-gfx, alexander.deucher, christian.koenig, xinhui.pan, hawking.zhang
  Cc: Guchun Chen

A lot of below message are outputed in SRIOV case.
amdgpu: indirect registers access through rlcg is not supported

Also drop redundant ret set, as it's initialized to be false already.

Fixes: d4cd09ca9bce("drm/amdgpu: add helper to query rlcg reg access flag")
Signed-off-by: Guchun Chen <guchun.chen@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 80c25176c993..b56cafb26f4a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -849,9 +849,6 @@ static bool amdgpu_virt_get_rlcg_reg_access_flag(struct amdgpu_device *adev,
 		}
 		break;
 	default:
-		dev_err(adev->dev,
-			"indirect registers access through rlcg is not supported\n");
-		ret = false;
 		break;
 	}
 	return ret;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/amdgpu: drop flood print in rlcg reg access function
  2022-01-28 15:19 [PATCH] drm/amdgpu: drop flood print in rlcg reg access function Guchun Chen
@ 2022-01-28 15:36 ` Deucher, Alexander
  0 siblings, 0 replies; 2+ messages in thread
From: Deucher, Alexander @ 2022-01-28 15:36 UTC (permalink / raw)
  To: Chen, Guchun, amd-gfx, Koenig, Christian, Pan, Xinhui, Zhang, Hawking

[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]

[Public]

Acked-by: Alex Deucher <alexander.deucher@amd.com>
________________________________
From: Chen, Guchun <Guchun.Chen@amd.com>
Sent: Friday, January 28, 2022 10:19 AM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>
Cc: Chen, Guchun <Guchun.Chen@amd.com>
Subject: [PATCH] drm/amdgpu: drop flood print in rlcg reg access function

A lot of below message are outputed in SRIOV case.
amdgpu: indirect registers access through rlcg is not supported

Also drop redundant ret set, as it's initialized to be false already.

Fixes: d4cd09ca9bce("drm/amdgpu: add helper to query rlcg reg access flag")
Signed-off-by: Guchun Chen <guchun.chen@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 80c25176c993..b56cafb26f4a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -849,9 +849,6 @@ static bool amdgpu_virt_get_rlcg_reg_access_flag(struct amdgpu_device *adev,
                 }
                 break;
         default:
-               dev_err(adev->dev,
-                       "indirect registers access through rlcg is not supported\n");
-               ret = false;
                 break;
         }
         return ret;
--
2.17.1


[-- Attachment #2: Type: text/html, Size: 3202 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-28 15:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-28 15:19 [PATCH] drm/amdgpu: drop flood print in rlcg reg access function Guchun Chen
2022-01-28 15:36 ` Deucher, Alexander

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.