* [PATCH] drm/amd/display: Fix white screen page fault for gpuvm
@ 2021-09-13 19:11 Nicholas Kazlauskas
2021-09-13 19:13 ` Alex Deucher
2021-09-14 15:03 ` Harry Wentland
0 siblings, 2 replies; 5+ messages in thread
From: Nicholas Kazlauskas @ 2021-09-13 19:11 UTC (permalink / raw)
To: amd-gfx; +Cc: Nicholas Kazlauskas, Aaron Liu
[Why]
The "base_addr_is_mc_addr" field was added for dcn3.1 support but
pa_config was never updated to set it to false.
Uninitialized memory causes it to be set to true which results in
address mistranslation and white screen.
[How]
Use memset to ensure all fields are initialized to 0 by default.
Cc: Aaron Liu <aaron.liu@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 53363728dbb..b0426bb3f2e 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -1125,6 +1125,8 @@ static void mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_
uint32_t agp_base, agp_bot, agp_top;
PHYSICAL_ADDRESS_LOC page_table_start, page_table_end, page_table_base;
+ memset(pa_config, 0, sizeof(*pa_config));
+
logical_addr_low = min(adev->gmc.fb_start, adev->gmc.agp_start) >> 18;
pt_base = amdgpu_gmc_pd_addr(adev->gart.bo);
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/display: Fix white screen page fault for gpuvm
2021-09-13 19:11 [PATCH] drm/amd/display: Fix white screen page fault for gpuvm Nicholas Kazlauskas
@ 2021-09-13 19:13 ` Alex Deucher
2021-09-13 19:25 ` Kazlauskas, Nicholas
2021-09-14 15:03 ` Harry Wentland
1 sibling, 1 reply; 5+ messages in thread
From: Alex Deucher @ 2021-09-13 19:13 UTC (permalink / raw)
To: Nicholas Kazlauskas; +Cc: amd-gfx list, Aaron Liu
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Can you add a fixes: tag?
Alex
On Mon, Sep 13, 2021 at 3:11 PM Nicholas Kazlauskas
<nicholas.kazlauskas@amd.com> wrote:
>
> [Why]
> The "base_addr_is_mc_addr" field was added for dcn3.1 support but
> pa_config was never updated to set it to false.
>
> Uninitialized memory causes it to be set to true which results in
> address mistranslation and white screen.
>
> [How]
> Use memset to ensure all fields are initialized to 0 by default.
>
> Cc: Aaron Liu <aaron.liu@amd.com>
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 53363728dbb..b0426bb3f2e 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1125,6 +1125,8 @@ static void mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_
> uint32_t agp_base, agp_bot, agp_top;
> PHYSICAL_ADDRESS_LOC page_table_start, page_table_end, page_table_base;
>
> + memset(pa_config, 0, sizeof(*pa_config));
> +
> logical_addr_low = min(adev->gmc.fb_start, adev->gmc.agp_start) >> 18;
> pt_base = amdgpu_gmc_pd_addr(adev->gart.bo);
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/display: Fix white screen page fault for gpuvm
2021-09-13 19:13 ` Alex Deucher
@ 2021-09-13 19:25 ` Kazlauskas, Nicholas
2021-09-14 3:37 ` Liu, Aaron
0 siblings, 1 reply; 5+ messages in thread
From: Kazlauskas, Nicholas @ 2021-09-13 19:25 UTC (permalink / raw)
To: Alex Deucher; +Cc: amd-gfx list, Aaron Liu
On 2021-09-13 3:13 p.m., Alex Deucher wrote:
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
>
> Can you add a fixes: tag?
>
> Alex
Sure, I think the relevant patch is:
Fixes: 64b1d0e8d50 ("drm/amd/display: Add DCN3.1 HWSEQ")
Regards,
Nicholas Kazlauskas
>
> On Mon, Sep 13, 2021 at 3:11 PM Nicholas Kazlauskas
> <nicholas.kazlauskas@amd.com> wrote:
>>
>> [Why]
>> The "base_addr_is_mc_addr" field was added for dcn3.1 support but
>> pa_config was never updated to set it to false.
>>
>> Uninitialized memory causes it to be set to true which results in
>> address mistranslation and white screen.
>>
>> [How]
>> Use memset to ensure all fields are initialized to 0 by default.
>>
>> Cc: Aaron Liu <aaron.liu@amd.com>
>> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>> ---
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index 53363728dbb..b0426bb3f2e 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -1125,6 +1125,8 @@ static void mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_
>> uint32_t agp_base, agp_bot, agp_top;
>> PHYSICAL_ADDRESS_LOC page_table_start, page_table_end, page_table_base;
>>
>> + memset(pa_config, 0, sizeof(*pa_config));
>> +
>> logical_addr_low = min(adev->gmc.fb_start, adev->gmc.agp_start) >> 18;
>> pt_base = amdgpu_gmc_pd_addr(adev->gart.bo);
>>
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amd/display: Fix white screen page fault for gpuvm
2021-09-13 19:25 ` Kazlauskas, Nicholas
@ 2021-09-14 3:37 ` Liu, Aaron
0 siblings, 0 replies; 5+ messages in thread
From: Liu, Aaron @ 2021-09-14 3:37 UTC (permalink / raw)
To: Kazlauskas, Nicholas, Alex Deucher; +Cc: amd-gfx list
[AMD Official Use Only]
Verified on Yellow Carp.
Acked-by: Aaron Liu <aaron.liu@amd.com>
--
Best Regards
Aaron Liu
> -----Original Message-----
> From: Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>
> Sent: Tuesday, September 14, 2021 3:26 AM
> To: Alex Deucher <alexdeucher@gmail.com>
> Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>; Liu, Aaron
> <Aaron.Liu@amd.com>
> Subject: Re: [PATCH] drm/amd/display: Fix white screen page fault for
> gpuvm
>
> On 2021-09-13 3:13 p.m., Alex Deucher wrote:
> > Acked-by: Alex Deucher <alexander.deucher@amd.com>
> >
> > Can you add a fixes: tag?
> >
> > Alex
>
> Sure, I think the relevant patch is:
>
> Fixes: 64b1d0e8d50 ("drm/amd/display: Add DCN3.1 HWSEQ")
>
> Regards,
> Nicholas Kazlauskas
>
> >
> > On Mon, Sep 13, 2021 at 3:11 PM Nicholas Kazlauskas
> > <nicholas.kazlauskas@amd.com> wrote:
> >>
> >> [Why]
> >> The "base_addr_is_mc_addr" field was added for dcn3.1 support but
> >> pa_config was never updated to set it to false.
> >>
> >> Uninitialized memory causes it to be set to true which results in
> >> address mistranslation and white screen.
> >>
> >> [How]
> >> Use memset to ensure all fields are initialized to 0 by default.
> >>
> >> Cc: Aaron Liu <aaron.liu@amd.com>
> >> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> >> ---
> >> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> >> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> >> index 53363728dbb..b0426bb3f2e 100644
> >> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> >> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> >> @@ -1125,6 +1125,8 @@ static void
> mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_
> >> uint32_t agp_base, agp_bot, agp_top;
> >> PHYSICAL_ADDRESS_LOC page_table_start, page_table_end,
> >> page_table_base;
> >>
> >> + memset(pa_config, 0, sizeof(*pa_config));
> >> +
> >> logical_addr_low = min(adev->gmc.fb_start, adev->gmc.agp_start) >>
> 18;
> >> pt_base = amdgpu_gmc_pd_addr(adev->gart.bo);
> >>
> >> --
> >> 2.25.1
> >>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/display: Fix white screen page fault for gpuvm
2021-09-13 19:11 [PATCH] drm/amd/display: Fix white screen page fault for gpuvm Nicholas Kazlauskas
2021-09-13 19:13 ` Alex Deucher
@ 2021-09-14 15:03 ` Harry Wentland
1 sibling, 0 replies; 5+ messages in thread
From: Harry Wentland @ 2021-09-14 15:03 UTC (permalink / raw)
To: Nicholas Kazlauskas, amd-gfx; +Cc: Aaron Liu
On 2021-09-13 15:11, Nicholas Kazlauskas wrote:
> [Why]
> The "base_addr_is_mc_addr" field was added for dcn3.1 support but
> pa_config was never updated to set it to false.
>
> Uninitialized memory causes it to be set to true which results in
> address mistranslation and white screen.
>
> [How]
> Use memset to ensure all fields are initialized to 0 by default.
>
> Cc: Aaron Liu <aaron.liu@amd.com>
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 53363728dbb..b0426bb3f2e 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1125,6 +1125,8 @@ static void mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_
> uint32_t agp_base, agp_bot, agp_top;
> PHYSICAL_ADDRESS_LOC page_table_start, page_table_end, page_table_base;
>
> + memset(pa_config, 0, sizeof(*pa_config));
> +
> logical_addr_low = min(adev->gmc.fb_start, adev->gmc.agp_start) >> 18;
> pt_base = amdgpu_gmc_pd_addr(adev->gart.bo);
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-14 15:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 19:11 [PATCH] drm/amd/display: Fix white screen page fault for gpuvm Nicholas Kazlauskas
2021-09-13 19:13 ` Alex Deucher
2021-09-13 19:25 ` Kazlauskas, Nicholas
2021-09-14 3:37 ` Liu, Aaron
2021-09-14 15:03 ` Harry Wentland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.