* [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed
@ 2021-12-05 10:01 Stanley.Yang
2021-12-06 1:43 ` Quan, Evan
0 siblings, 1 reply; 4+ messages in thread
From: Stanley.Yang @ 2021-12-05 10:01 UTC (permalink / raw)
To: amd-gfx, Hawking.Zhang, John.Clements, tao.zhou1, candice.li,
yipeng.chai, evan.quan
Cc: Stanley.Yang
Signed-off-by: Stanley.Yang <Stanley.Yang@amd.com>
---
drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
index 6e781cee8bb6..e0a8224e466f 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
@@ -1815,7 +1815,7 @@ static ssize_t aldebaran_get_ecc_info(struct smu_context *smu,
smu_table->ecc_table,
false);
if (ret) {
- dev_info(smu->adev->dev, "Failed to export SMU ecc table!\n");
+ dev_info(smu->adev->dev, "Failed to export SMU ecc table! ret %d.\n", ret);
return ret;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed
2021-12-05 10:01 [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed Stanley.Yang
@ 2021-12-06 1:43 ` Quan, Evan
2021-12-06 12:36 ` 答复: " Yang, Stanley
0 siblings, 1 reply; 4+ messages in thread
From: Quan, Evan @ 2021-12-06 1:43 UTC (permalink / raw)
To: Yang, Stanley, amd-gfx, Zhang, Hawking, Clements, John, Zhou1,
Tao, Li, Candice, Chai, Thomas
Cc: Yang, Stanley
[AMD Official Use Only]
Hi Stanley,
There is already error prompts in the smu_cmn_send_smc_msg_with_param() used by the API mentioned below.
Can that cover your use case?
BR
Evan
> -----Original Message-----
> From: Stanley.Yang <Stanley.Yang@amd.com>
> Sent: Sunday, December 5, 2021 6:02 PM
> To: amd-gfx@lists.freedesktop.org; Zhang, Hawking
> <Hawking.Zhang@amd.com>; Clements, John <John.Clements@amd.com>;
> Zhou1, Tao <Tao.Zhou1@amd.com>; Li, Candice <Candice.Li@amd.com>;
> Chai, Thomas <YiPeng.Chai@amd.com>; Quan, Evan <Evan.Quan@amd.com>
> Cc: Yang, Stanley <Stanley.Yang@amd.com>
> Subject: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed
>
> Signed-off-by: Stanley.Yang <Stanley.Yang@amd.com>
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> index 6e781cee8bb6..e0a8224e466f 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> @@ -1815,7 +1815,7 @@ static ssize_t aldebaran_get_ecc_info(struct
> smu_context *smu,
> smu_table->ecc_table,
> false);
> if (ret) {
> - dev_info(smu->adev->dev, "Failed to export SMU ecc
> table!\n");
> + dev_info(smu->adev->dev, "Failed to export SMU ecc table!
> ret %d.\n", ret);
> return ret;
> }
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* 答复: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed
2021-12-06 1:43 ` Quan, Evan
@ 2021-12-06 12:36 ` Yang, Stanley
2021-12-07 7:43 ` Quan, Evan
0 siblings, 1 reply; 4+ messages in thread
From: Yang, Stanley @ 2021-12-06 12:36 UTC (permalink / raw)
To: Quan, Evan, amd-gfx, Zhang, Hawking, Clements, John, Zhou1, Tao,
Li, Candice, Chai, Thomas
[-- Attachment #1: Type: text/plain, Size: 2401 bytes --]
Hi Evan,
The error prompts in function smu_cmn_send_smc_msg_with_param do not cover all failed cases since it only prints reg stat SMU_RESP_NONE,
SMU_RESP_BUSY_OTHER or response -EREMOTEIO. I think it is better update reg error stat judgment conditions to print more error msg.
Regards,
Stanley
发件人: Quan, Evan <Evan.Quan@amd.com>
日期: 星期一, 2021年12月6日 上午9:43
收件人: Yang, Stanley <Stanley.Yang@amd.com>, amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>, Zhang, Hawking <Hawking.Zhang@amd.com>, Clements, John <John.Clements@amd.com>, Zhou1, Tao <Tao.Zhou1@amd.com>, Li, Candice <Candice.Li@amd.com>, Chai, Thomas <YiPeng.Chai@amd.com>
抄送: Yang, Stanley <Stanley.Yang@amd.com>
主题: RE: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed
[AMD Official Use Only]
Hi Stanley,
There is already error prompts in the smu_cmn_send_smc_msg_with_param() used by the API mentioned below.
Can that cover your use case?
BR
Evan
> -----Original Message-----
> From: Stanley.Yang <Stanley.Yang@amd.com>
> Sent: Sunday, December 5, 2021 6:02 PM
> To: amd-gfx@lists.freedesktop.org; Zhang, Hawking
> <Hawking.Zhang@amd.com>; Clements, John <John.Clements@amd.com>;
> Zhou1, Tao <Tao.Zhou1@amd.com>; Li, Candice <Candice.Li@amd.com>;
> Chai, Thomas <YiPeng.Chai@amd.com>; Quan, Evan <Evan.Quan@amd.com>
> Cc: Yang, Stanley <Stanley.Yang@amd.com>
> Subject: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed
>
> Signed-off-by: Stanley.Yang <Stanley.Yang@amd.com>
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> index 6e781cee8bb6..e0a8224e466f 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> @@ -1815,7 +1815,7 @@ static ssize_t aldebaran_get_ecc_info(struct
> smu_context *smu,
> smu_table->ecc_table,
> false);
> if (ret) {
> - dev_info(smu->adev->dev, "Failed to export SMU ecc
> table!\n");
> + dev_info(smu->adev->dev, "Failed to export SMU ecc table!
> ret %d.\n", ret);
> return ret;
> }
>
> --
> 2.17.1
[-- Attachment #2: Type: text/html, Size: 7551 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed
2021-12-06 12:36 ` 答复: " Yang, Stanley
@ 2021-12-07 7:43 ` Quan, Evan
0 siblings, 0 replies; 4+ messages in thread
From: Quan, Evan @ 2021-12-07 7:43 UTC (permalink / raw)
To: Yang, Stanley, amd-gfx, Zhang, Hawking, Clements, John, Zhou1,
Tao, Li, Candice, Chai, Thomas
[-- Attachment #1: Type: text/plain, Size: 3595 bytes --]
[AMD Official Use Only]
OK. If that can help the debugging for RAS development, I’m fine with it.
Reviewed-by: Evan Quan <evan.quan@amd.com>
BR
Evan
From: Yang, Stanley <Stanley.Yang@amd.com>
Sent: Monday, December 6, 2021 8:37 PM
To: Quan, Evan <Evan.Quan@amd.com>; amd-gfx@lists.freedesktop.org; Zhang, Hawking <Hawking.Zhang@amd.com>; Clements, John <John.Clements@amd.com>; Zhou1, Tao <Tao.Zhou1@amd.com>; Li, Candice <Candice.Li@amd.com>; Chai, Thomas <YiPeng.Chai@amd.com>
Subject: 答复: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed
Hi Evan,
The error prompts in function smu_cmn_send_smc_msg_with_param do not cover all failed cases since it only prints reg stat SMU_RESP_NONE,
SMU_RESP_BUSY_OTHER or response -EREMOTEIO. I think it is better update reg error stat judgment conditions to print more error msg.
Regards,
Stanley
发件人: Quan, Evan <Evan.Quan@amd.com<mailto:Evan.Quan@amd.com>>
日期: 星期一, 2021年12月6日 上午9:43
收件人: Yang, Stanley <Stanley.Yang@amd.com<mailto:Stanley.Yang@amd.com>>, amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> <amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>>, Zhang, Hawking <Hawking.Zhang@amd.com<mailto:Hawking.Zhang@amd.com>>, Clements, John <John.Clements@amd.com<mailto:John.Clements@amd.com>>, Zhou1, Tao <Tao.Zhou1@amd.com<mailto:Tao.Zhou1@amd.com>>, Li, Candice <Candice.Li@amd.com<mailto:Candice.Li@amd.com>>, Chai, Thomas <YiPeng.Chai@amd.com<mailto:YiPeng.Chai@amd.com>>
抄送: Yang, Stanley <Stanley.Yang@amd.com<mailto:Stanley.Yang@amd.com>>
主题: RE: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed
[AMD Official Use Only]
Hi Stanley,
There is already error prompts in the smu_cmn_send_smc_msg_with_param() used by the API mentioned below.
Can that cover your use case?
BR
Evan
> -----Original Message-----
> From: Stanley.Yang <Stanley.Yang@amd.com<mailto:Stanley.Yang@amd.com>>
> Sent: Sunday, December 5, 2021 6:02 PM
> To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>; Zhang, Hawking
> <Hawking.Zhang@amd.com<mailto:Hawking.Zhang@amd.com>>; Clements, John <John.Clements@amd.com<mailto:John.Clements@amd.com>>;
> Zhou1, Tao <Tao.Zhou1@amd.com<mailto:Tao.Zhou1@amd.com>>; Li, Candice <Candice.Li@amd.com<mailto:Candice.Li@amd.com>>;
> Chai, Thomas <YiPeng.Chai@amd.com<mailto:YiPeng.Chai@amd.com>>; Quan, Evan <Evan.Quan@amd.com<mailto:Evan.Quan@amd.com>>
> Cc: Yang, Stanley <Stanley.Yang@amd.com<mailto:Stanley.Yang@amd.com>>
> Subject: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed
>
> Signed-off-by: Stanley.Yang <Stanley.Yang@amd.com<mailto:Stanley.Yang@amd.com>>
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> index 6e781cee8bb6..e0a8224e466f 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> @@ -1815,7 +1815,7 @@ static ssize_t aldebaran_get_ecc_info(struct
> smu_context *smu,
> smu_table->ecc_table,
> false);
> if (ret) {
> - dev_info(smu->adev->dev, "Failed to export SMU ecc
> table!\n");
> + dev_info(smu->adev->dev, "Failed to export SMU ecc table!
> ret %d.\n", ret);
> return ret;
> }
>
> --
> 2.17.1
[-- Attachment #2: Type: text/html, Size: 11022 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-07 7:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-05 10:01 [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed Stanley.Yang
2021-12-06 1:43 ` Quan, Evan
2021-12-06 12:36 ` 答复: " Yang, Stanley
2021-12-07 7:43 ` Quan, Evan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.