[oe-core][PATCH] import libadwaita from meta-gnome

[oe-core][PATCH] import libadwaita from meta-gnome

[Markus Volk]

Signed-off-by: Markus Volk <f_l_k@t-online.de>
---
 meta/conf/distro/include/maintainers.inc      |  1 +
 .../libadwaita/libadwaita_1.3.1.bb            | 24 +++++++++++++++++++
 2 files changed, 25 insertions(+)
 create mode 100644 meta/recipes-gnome/libadwaita/libadwaita_1.3.1.bb

diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index 1fec9bc6f4..62272cd1bd 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -303,6 +303,7 @@ RECIPE_MAINTAINER:pn-ldconfig-native = "Khem Raj <raj.khem@gmail.com>"
 RECIPE_MAINTAINER:pn-less = "Yi Zhao <yi.zhao@windriver.com>"
 RECIPE_MAINTAINER:pn-liba52 = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-libacpi = "Anuj Mittal <anuj.mittal@intel.com>"
+RECIPE_MAINTAINER:pn-libadwaita = "Markus Volk <f_l_k@t-online.de>"
 RECIPE_MAINTAINER:pn-libaio = "Alexander Kanavin <alex.kanavin@gmail.com>"
 RECIPE_MAINTAINER:pn-libarchive = "Otavio Salvador <otavio.salvador@ossystems.com.br>"
 RECIPE_MAINTAINER:pn-libassuan = "Unassigned <unassigned@yoctoproject.org>"
diff --git a/meta/recipes-gnome/libadwaita/libadwaita_1.3.1.bb b/meta/recipes-gnome/libadwaita/libadwaita_1.3.1.bb
new file mode 100644
index 0000000000..8f927e3f7e
--- /dev/null
+++ b/meta/recipes-gnome/libadwaita/libadwaita_1.3.1.bb
@@ -0,0 +1,24 @@
+SUMMARY = "Building blocks for modern GNOME applications"
+LICENSE="LGPL-2.1-or-later"
+LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
+
+GNOMEBASEBUILDCLASS = "meson"
+
+DEPENDS = " \
+    gtk4 \
+"
+
+inherit gnomebase gobject-introspection gtk-doc vala features_check
+
+SRC_URI[archive.sha256sum] = "6b8bbf413c501b46c8616a0e5b836d7a34091140941412520bbd9ddda6df8cbd"
+
+ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
+REQUIRED_DISTRO_FEATURES = "opengl"
+
+GIR_MESON_ENABLE_FLAG = 'enabled'
+GIR_MESON_DISABLE_FLAG = 'disabled'
+GTKDOC_MESON_OPTION = 'gtk_doc'
+
+PACKAGECONFIG[examples] = "-Dexamples=true,-Dexamples=false"
+
+FILES:${PN} += "${datadir}/metainfo"
-- 
2.34.1

Re: [oe-core][PATCH] import libadwaita from meta-gnome

[Alexandre Belloni]

Please take the time to send proper series that are versioned. The
changelog then goes in the cover letter when adding or removing patches.
For individual patches, the changelog goes after the --- marker and
before the diffstat.

You can't expect maintainers to cherry pick patches from different
series. As you underlined, a build takes 5 to 10 hours, every build
failure is also delaying work from others.

On 28/03/2023 10:01:56+0200, Markus Volk wrote:
> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> ---
>  meta/conf/distro/include/maintainers.inc      |  1 +
>  .../libadwaita/libadwaita_1.3.1.bb            | 24 +++++++++++++++++++
>  2 files changed, 25 insertions(+)
>  create mode 100644 meta/recipes-gnome/libadwaita/libadwaita_1.3.1.bb
> 
> diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
> index 1fec9bc6f4..62272cd1bd 100644
> --- a/meta/conf/distro/include/maintainers.inc
> +++ b/meta/conf/distro/include/maintainers.inc
> @@ -303,6 +303,7 @@ RECIPE_MAINTAINER:pn-ldconfig-native = "Khem Raj <raj.khem@gmail.com>"
>  RECIPE_MAINTAINER:pn-less = "Yi Zhao <yi.zhao@windriver.com>"
>  RECIPE_MAINTAINER:pn-liba52 = "Unassigned <unassigned@yoctoproject.org>"
>  RECIPE_MAINTAINER:pn-libacpi = "Anuj Mittal <anuj.mittal@intel.com>"
> +RECIPE_MAINTAINER:pn-libadwaita = "Markus Volk <f_l_k@t-online.de>"
>  RECIPE_MAINTAINER:pn-libaio = "Alexander Kanavin <alex.kanavin@gmail.com>"
>  RECIPE_MAINTAINER:pn-libarchive = "Otavio Salvador <otavio.salvador@ossystems.com.br>"
>  RECIPE_MAINTAINER:pn-libassuan = "Unassigned <unassigned@yoctoproject.org>"
> diff --git a/meta/recipes-gnome/libadwaita/libadwaita_1.3.1.bb b/meta/recipes-gnome/libadwaita/libadwaita_1.3.1.bb
> new file mode 100644
> index 0000000000..8f927e3f7e
> --- /dev/null
> +++ b/meta/recipes-gnome/libadwaita/libadwaita_1.3.1.bb
> @@ -0,0 +1,24 @@
> +SUMMARY = "Building blocks for modern GNOME applications"
> +LICENSE="LGPL-2.1-or-later"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
> +
> +GNOMEBASEBUILDCLASS = "meson"
> +
> +DEPENDS = " \
> +    gtk4 \
> +"
> +
> +inherit gnomebase gobject-introspection gtk-doc vala features_check
> +
> +SRC_URI[archive.sha256sum] = "6b8bbf413c501b46c8616a0e5b836d7a34091140941412520bbd9ddda6df8cbd"
> +
> +ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
> +REQUIRED_DISTRO_FEATURES = "opengl"
> +
> +GIR_MESON_ENABLE_FLAG = 'enabled'
> +GIR_MESON_DISABLE_FLAG = 'disabled'
> +GTKDOC_MESON_OPTION = 'gtk_doc'
> +
> +PACKAGECONFIG[examples] = "-Dexamples=true,-Dexamples=false"
> +
> +FILES:${PN} += "${datadir}/metainfo"
> -- 
> 2.34.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#179208): https://lists.openembedded.org/g/openembedded-core/message/179208
> Mute This Topic: https://lists.openembedded.org/mt/97900769/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [oe-core][PATCH] import libadwaita from meta-gnome

[f_l_k]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

On Tue, Mar 28 2023 at 11:18:36 AM +0200, Alexandre Belloni 
<alexandre.belloni@bootlin.com> wrote:
> As you underlined, a build takes 5 to 10 hours, every build
> failure is also delaying work from others

Now thats true. I didn`t send ot unchanged patches so far, because I 
wanted to avoid mail flood but if it will make things easier I'll send 
the complete serie again


[-- Attachment #2: Type: text/html, Size: 623 bytes --]

Re: [oe-core][PATCH] import libadwaita from meta-gnome

[Alexander Kanavin]

It can also help if you publish the complete current set in a branch
somewhere and refer to that in the cover letter.

Alex

On Tue, 28 Mar 2023 at 11:41, Markus Volk <f_l_k@t-online.de> wrote:
>
> On Tue, Mar 28 2023 at 11:18:36 AM +0200, Alexandre Belloni <alexandre.belloni@bootlin.com> wrote:
>
> As you underlined, a build takes 5 to 10 hours, every build failure is also delaying work from others
>
>
> Now thats true. I didn`t send ot unchanged patches so far, because I wanted to avoid mail flood but if it will make things easier I'll send the complete serie again
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#179217): https://lists.openembedded.org/g/openembedded-core/message/179217
> Mute This Topic: https://lists.openembedded.org/mt/97900769/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [oe-core][PATCH] import libadwaita from meta-gnome

[Markus Volk]

Too late this time to refer in the cover letter this time but I created 
a branch with that patchset here:

https://github.com/MarkusVolk/openembedded-core/commits/gnome-44

Am 28.03.23 um 11:42 schrieb Alexander Kanavin:
> It can also help if you publish the complete current set in a branch
> somewhere and refer to that in the cover letter.
>
> Alex
>
> On Tue, 28 Mar 2023 at 11:41, Markus Volk <f_l_k@t-online.de> wrote:
>> On Tue, Mar 28 2023 at 11:18:36 AM +0200, Alexandre Belloni <alexandre.belloni@bootlin.com> wrote:
>>
>> As you underlined, a build takes 5 to 10 hours, every build failure is also delaying work from others
>>
>>
>> Now thats true. I didn`t send ot unchanged patches so far, because I wanted to avoid mail flood but if it will make things easier I'll send the complete serie again
>>
>>
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#179218): https://lists.openembedded.org/g/openembedded-core/message/179218
>> Mute This Topic: https://lists.openembedded.org/mt/97900769/3618223
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [f_l_k@t-online.de]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>