* [PATCH] mm: include linux/pfn.h for PHYS_PFN definition
@ 2015-11-19 12:41 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2015-11-19 12:41 UTC (permalink / raw)
To: linux-mm; +Cc: linux-kernel, linux-arm-kernel, akpm, Chen Gang, Oleg Nesterov
A change to asm-generic/memory_model.h caused a new build error
in some configurations:
mach-clps711x/common.c:39:10: error: implicit declaration of function 'PHYS_PFN'
.pfn = __phys_to_pfn(CLPS711X_PHYS_BASE),
This includes the linux/pfn.h header from the same file to avoid the
error.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: bf1c6c9895de ("mm: add PHYS_PFN, use it in __phys_to_pfn()")
---
I was listed as 'Cc' on the original patch, but don't see it in my inbox.
I can queue up the fixed version in the asm-generic tree if you like that,
otherwise please fold this fixup into the patch, or drop it if we want to
avoid the extra #include.
diff --git a/include/asm-generic/memory_model.h b/include/asm-generic/memory_model.h
index c785a79d9385..5148150cc80b 100644
--- a/include/asm-generic/memory_model.h
+++ b/include/asm-generic/memory_model.h
@@ -1,6 +1,8 @@
#ifndef __ASM_MEMORY_MODEL_H
#define __ASM_MEMORY_MODEL_H
+#include <linux/pfn.h>
+
#ifndef __ASSEMBLY__
#if defined(CONFIG_FLATMEM)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] mm: include linux/pfn.h for PHYS_PFN definition
@ 2015-11-19 12:41 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2015-11-19 12:41 UTC (permalink / raw)
To: linux-mm; +Cc: linux-kernel, linux-arm-kernel, akpm, Chen Gang, Oleg Nesterov
A change to asm-generic/memory_model.h caused a new build error
in some configurations:
mach-clps711x/common.c:39:10: error: implicit declaration of function 'PHYS_PFN'
.pfn = __phys_to_pfn(CLPS711X_PHYS_BASE),
This includes the linux/pfn.h header from the same file to avoid the
error.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: bf1c6c9895de ("mm: add PHYS_PFN, use it in __phys_to_pfn()")
---
I was listed as 'Cc' on the original patch, but don't see it in my inbox.
I can queue up the fixed version in the asm-generic tree if you like that,
otherwise please fold this fixup into the patch, or drop it if we want to
avoid the extra #include.
diff --git a/include/asm-generic/memory_model.h b/include/asm-generic/memory_model.h
index c785a79d9385..5148150cc80b 100644
--- a/include/asm-generic/memory_model.h
+++ b/include/asm-generic/memory_model.h
@@ -1,6 +1,8 @@
#ifndef __ASM_MEMORY_MODEL_H
#define __ASM_MEMORY_MODEL_H
+#include <linux/pfn.h>
+
#ifndef __ASSEMBLY__
#if defined(CONFIG_FLATMEM)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] mm: include linux/pfn.h for PHYS_PFN definition
@ 2015-11-19 12:41 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2015-11-19 12:41 UTC (permalink / raw)
To: linux-arm-kernel
A change to asm-generic/memory_model.h caused a new build error
in some configurations:
mach-clps711x/common.c:39:10: error: implicit declaration of function 'PHYS_PFN'
.pfn = __phys_to_pfn(CLPS711X_PHYS_BASE),
This includes the linux/pfn.h header from the same file to avoid the
error.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: bf1c6c9895de ("mm: add PHYS_PFN, use it in __phys_to_pfn()")
---
I was listed as 'Cc' on the original patch, but don't see it in my inbox.
I can queue up the fixed version in the asm-generic tree if you like that,
otherwise please fold this fixup into the patch, or drop it if we want to
avoid the extra #include.
diff --git a/include/asm-generic/memory_model.h b/include/asm-generic/memory_model.h
index c785a79d9385..5148150cc80b 100644
--- a/include/asm-generic/memory_model.h
+++ b/include/asm-generic/memory_model.h
@@ -1,6 +1,8 @@
#ifndef __ASM_MEMORY_MODEL_H
#define __ASM_MEMORY_MODEL_H
+#include <linux/pfn.h>
+
#ifndef __ASSEMBLY__
#if defined(CONFIG_FLATMEM)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: include linux/pfn.h for PHYS_PFN definition
2015-11-19 12:41 ` Arnd Bergmann
@ 2015-11-19 19:13 ` Chen Gang
-1 siblings, 0 replies; 5+ messages in thread
From: Chen Gang @ 2015-11-19 19:13 UTC (permalink / raw)
To: Arnd Bergmann, linux-mm
Cc: linux-kernel, linux-arm-kernel, akpm, Chen Gang, Oleg Nesterov
On 11/19/15 20:41, Arnd Bergmann wrote:
> A change to asm-generic/memory_model.h caused a new build error
> in some configurations:
>
> mach-clps711x/common.c:39:10: error: implicit declaration of function 'PHYS_PFN'
> .pfn = __phys_to_pfn(CLPS711X_PHYS_BASE),
>
> This includes the linux/pfn.h header from the same file to avoid the
> error.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: bf1c6c9895de ("mm: add PHYS_PFN, use it in __phys_to_pfn()")
> ---
> I was listed as 'Cc' on the original patch, but don't see it in my inbox.
>
> I can queue up the fixed version in the asm-generic tree if you like that,
> otherwise please fold this fixup into the patch, or drop it if we want to
> avoid the extra #include.
>
> diff --git a/include/asm-generic/memory_model.h b/include/asm-generic/memory_model.h
> index c785a79d9385..5148150cc80b 100644
> --- a/include/asm-generic/memory_model.h
> +++ b/include/asm-generic/memory_model.h
> @@ -1,6 +1,8 @@
> #ifndef __ASM_MEMORY_MODEL_H
> #define __ASM_MEMORY_MODEL_H
>
> +#include <linux/pfn.h>
> +
For me, it is OK, thanks.
> #ifndef __ASSEMBLY__
>
> #if defined(CONFIG_FLATMEM)
>
--
Chen Gang (陈刚)
Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] mm: include linux/pfn.h for PHYS_PFN definition
@ 2015-11-19 19:13 ` Chen Gang
0 siblings, 0 replies; 5+ messages in thread
From: Chen Gang @ 2015-11-19 19:13 UTC (permalink / raw)
To: linux-arm-kernel
On 11/19/15 20:41, Arnd Bergmann wrote:
> A change to asm-generic/memory_model.h caused a new build error
> in some configurations:
>
> mach-clps711x/common.c:39:10: error: implicit declaration of function 'PHYS_PFN'
> .pfn = __phys_to_pfn(CLPS711X_PHYS_BASE),
>
> This includes the linux/pfn.h header from the same file to avoid the
> error.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: bf1c6c9895de ("mm: add PHYS_PFN, use it in __phys_to_pfn()")
> ---
> I was listed as 'Cc' on the original patch, but don't see it in my inbox.
>
> I can queue up the fixed version in the asm-generic tree if you like that,
> otherwise please fold this fixup into the patch, or drop it if we want to
> avoid the extra #include.
>
> diff --git a/include/asm-generic/memory_model.h b/include/asm-generic/memory_model.h
> index c785a79d9385..5148150cc80b 100644
> --- a/include/asm-generic/memory_model.h
> +++ b/include/asm-generic/memory_model.h
> @@ -1,6 +1,8 @@
> #ifndef __ASM_MEMORY_MODEL_H
> #define __ASM_MEMORY_MODEL_H
>
> +#include <linux/pfn.h>
> +
For me, it is OK, thanks.
> #ifndef __ASSEMBLY__
>
> #if defined(CONFIG_FLATMEM)
>
--
Chen Gang (??)
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-11-19 19:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-19 12:41 [PATCH] mm: include linux/pfn.h for PHYS_PFN definition Arnd Bergmann
2015-11-19 12:41 ` Arnd Bergmann
2015-11-19 12:41 ` Arnd Bergmann
2015-11-19 19:13 ` Chen Gang
2015-11-19 19:13 ` Chen Gang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.