Re: [Qemu-devel] [PATCH 1/6 v7] target-tilegx: Firstly add TILE-Gx with minimized features

From: Chen Gang <xili_gchen_5257@hotmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Chris Metcalf" <cmetcalf@ezchip.com>,
	"walt@tilera.com" <walt@tilera.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"rth@twiddle.net" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 1/6 v7] target-tilegx: Firstly add TILE-Gx with minimized features
Date: Sun, 22 Mar 2015 06:57:03 +0800	[thread overview]
Message-ID: <BLU436-SMTP511CEF40D9A60A2D7E6BABB90F0@phx.gbl> (raw)
In-Reply-To: <CAFEAcA-_oBKMCeDRBq3QwZyn2PCp3r6BTjEfSKD9oS-Z17+ZTw@mail.gmail.com>

On 3/22/15 01:33, Peter Maydell wrote:
> On 20 March 2015 at 23:57, Chen Gang <xili_gchen_5257@hotmail.com> wrote:
>> For 'opcode_tilegx.h', it comes from Linux kernel which is already more
>> than 1000 lines. For me, I still suggest to let it within one patch.
> 
> Right, for that sort of special case you should put it in
> a single patch which is just "Import copy of whatever.h from Linux
> kernel", and which has nothing else in it except for the imported
> file or files, and which makes no QEMU specific changes to those
> files. Then people can skim through that patch quickly knowing
> they don't have to look for any changes or extras that do need
> review. (If there is some tweak that needs to be made for QEMU's
> purposes that can go in a subsequent patch.)
> 

OK, thanks (at present, opcode_tilegx.h has no any changes, it is only a
copy from Linux kernel).

>> For 'translate.c', I try to split it into 3 patches:
>>
>>  - parsing bundle and decode to the first level of pipe,
>>
>>  - parsing 2nd level of pipe.
>>
>>  - generate tcg code.
>>
>> For the left files:
>>
>>  - 'configure', 'Makefile.obj', 'tilegx-linux-user.mak' are in a patch.
>>
>>  - 'cpu*' are in a patch
>>
>>  - 'help.*' are in a patch.
> 
> I would suggest that rather than having "cpu* in one patch
> and help* in another" (ie a split by file), you split things
> functionally, so you might have a patch adding "support for
> instruction group foo" which includes everything needed
> for those instructions including the translate.c changes
> and the helper functions that get called by the generated
> code.
> 

OK, thanks. But I have sent patches v8, please help check them, if they
are really not suitable (about splitting patch), please let me know.

> Remember to make sure that everything still compiles at every
> step in the patch series.
> 

For translate.c, it has three patches, each patch can pass compiling
(but the other patches in patch v8 can not). Please help check patches
v8 for more details, if they are really not suitable, please let me know.

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed