From: Peter Maydell <peter.maydell@linaro.org>
To: Chen Gang <xili_gchen_5257@hotmail.com>
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
qemu-devel <qemu-devel@nongnu.org>,
"Chris Metcalf" <cmetcalf@ezchip.com>,
"walt@tilera.com" <walt@tilera.com>,
"Andreas Färber" <afaerber@suse.de>,
"rth@twiddle.net" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 1/6 v7] target-tilegx: Firstly add TILE-Gx with minimized features
Date: Fri, 20 Mar 2015 23:30:55 +0000 [thread overview]
Message-ID: <CAFEAcA9Uu+BuxAF9n8DPocD3q81MSSL_7EuNFs_mmSO+pxpmUg@mail.gmail.com> (raw)
In-Reply-To: <BLU437-SMTP50AE816DFFDC721DE892B0B90E0@phx.gbl>
On 20 March 2015 at 22:52, Chen Gang <xili_gchen_5257@hotmail.com> wrote:
> On 3/21/15 01:48, Peter Maydell wrote:
>> On 20 March 2015 at 15:25, Chen Gang <xili_gchen_5257@hotmail.com> wrote:
>>> 10 files changed, 3523 insertions(+)
>>
>> If you have any patch which has a diffstat like this then
>> you *must* split it up into separate patches. Even
>> 1000 lines is really too long to be easily
>> reviewable, and this patch is now over three times
>> that size! Most patches should be 250 lines or
>> less, really, unless they're very mechanical.
>>
>
> OK, thanks. I shall try to split it into 3 patches in patch v8.
Even 3 would still leave at least one of them more than 1000
lines. I would suggest that you should be thinking more like
turning this one into 7 or 8 patches.
-- PMM
next prev parent reply other threads:[~2015-03-20 23:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <550C3B78.3050802@hotmail.com>
2015-03-20 15:25 ` [Qemu-devel] [PATCH 1/6 v7] target-tilegx: Firstly add TILE-Gx with minimized features Chen Gang
2015-03-20 17:45 ` Richard Henderson
2015-03-20 23:32 ` Chen Gang
2015-03-20 17:48 ` Peter Maydell
2015-03-20 22:52 ` Chen Gang
2015-03-20 23:30 ` Peter Maydell [this message]
2015-03-20 23:57 ` Chen Gang
2015-03-21 17:33 ` Peter Maydell
2015-03-21 22:57 ` Chen Gang
2015-03-20 15:26 ` [Qemu-devel] [PATCH 2/6 v7] linux-user: tilegx: Firstly add architecture related features Chen Gang
2015-03-20 15:26 ` [Qemu-devel] [PATCH 3/6 v7] linux-user: tilegx: Add target features support within qemu Chen Gang
2015-03-20 15:27 ` [Qemu-devel] [PATCH 4/6 v7] linux-user: Support tilegx architecture in syscall Chen Gang
2015-03-20 15:28 ` [Qemu-devel] [PATCH 5/6 v7] linux-user: Support tilegx architecture in linux-user Chen Gang
2015-03-20 15:29 ` [Qemu-devel] [PATCH 6/6 v7] linux-user/syscall.c: conditionalize syscalls which are not defined in tilegx Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9Uu+BuxAF9n8DPocD3q81MSSL_7EuNFs_mmSO+pxpmUg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=cmetcalf@ezchip.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=walt@tilera.com \
--cc=xili_gchen_5257@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.