From: Rasesh Mody <rasesh.mody@qlogic.com>
To: Remy Horton <remy.horton@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: xstats performance
Date: Tue, 5 Jul 2016 18:10:06 +0000 [thread overview]
Message-ID: <BLUPR11MB0370FD4F5FAF642A42CFB9E285390@BLUPR11MB0370.namprd11.prod.outlook.com> (raw)
In-Reply-To: <99e03d76-b896-2146-274c-2f3d83eee899@intel.com>
Hi Remy,
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Remy Horton
> Sent: Friday, July 01, 2016 2:15 AM
>
>
> On 29/06/2016 17:40, Thomas Monjalon wrote:
> [..]
> > I don't think it is possible to standardize stats ids, for two reasons:
> > - it is hard to maintain and avoid conflicts between drivers
> > - the drivers would have to lookup the names which degrades
> > performance
>
> I designed it that way to keep flexibility down the line rather than specifically
> for the above use-case.
>
>
> > I think the idea of Olivier would improve the performance of stats retrieval,
> > which was the idea of this rework :)
> > Unfortunately we need someone available to fix it quickly for RC2.
>
> For all the current drivers xstats_names[idx].id==idx so it would just
> involve removing the references to the id field and updating the
> documentation. Complication is coordinating with QLogic for the bnx2x &
> qede xstats patches.
We could incorporate this change in our re-submission.
> ..Remy
next prev parent reply other threads:[~2016-07-05 18:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 15:38 xstats performance Olivier MATZ
2016-06-29 16:03 ` Remy Horton
2016-06-29 16:40 ` Thomas Monjalon
2016-07-01 9:15 ` Remy Horton
2016-07-05 18:10 ` Rasesh Mody [this message]
2016-07-06 7:43 ` Remy Horton
2016-07-07 22:59 ` Rasesh Mody
2016-07-08 11:15 ` Remy Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLUPR11MB0370FD4F5FAF642A42CFB9E285390@BLUPR11MB0370.namprd11.prod.outlook.com \
--to=rasesh.mody@qlogic.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=remy.horton@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.