From: "Wang, Annie" <Annie.Wang@amd.com>
To: Russell King <linux@arm.linux.org.uk>, Borislav Petkov <bp@alien8.de>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Vinod Koul <vinod.koul@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Huang, Ray" <Ray.Huang@amd.com>,
"Wan, Vincent" <Vincent.Wan@amd.com>,
"Xue, Ken" <Ken.Xue@amd.com>, Robin Murphy <robin.murphy@arm.com>,
Graeme Gregory <gg@slimlogic.co.uk>, "Li, Tony" <Tony.Li@amd.com>,
"Yu, Xiangliang" <Xiangliang.Yu@amd.com>
Subject: RE: [PATCH 1/6] 8250/Kconfig: add config option CONFIG_SERIAL_8250_AMD
Date: Mon, 11 Jan 2016 07:26:39 +0000 [thread overview]
Message-ID: <BLUPR12MB043368006316A2FB11A0DE8B81C90@BLUPR12MB0433.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20160106104602.GA19507@pd.tnic>
>-----Original Message-----
>From: Borislav Petkov [mailto:bp@alien8.de]
>Sent: Wednesday, January 06, 2016 6:46 PM
>To: Wang, Annie
>Cc: Andy Shevchenko; Vinod Koul; Mika Westerberg; Greg Kroah-Hartman; Rafael
>J. Wysocki; linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
>serial@vger.kernel.org; dmaengine@vger.kernel.org; Huang, Ray; Wan, Vincent;
>Xue, Ken; Robin Murphy; Graeme Gregory; Li, Tony; Yu, Xiangliang
>Subject: Re: [PATCH 1/6] 8250/Kconfig: add config option
>CONFIG_SERIAL_8250_AMD
>
>On Wed, Jan 06, 2016 at 02:08:18AM +0000, Wang, Annie wrote:
>> How about I add select ARM_AMBA and SERIAL_8250 in arch/x86/Kconfig?
>
>Yeah, select sounds good in that case, except in that particular case ...
>
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index
>> db3622f..0fe6657 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -537,11 +537,15 @@ config X86_AMD_PLATFORM_DEVICE
>> depends on ACPI
>> select COMMON_CLK
>> select PINCTRL
>> + select SERIAL_8250
>> + select ARM_AMBA
>
>... that's a X86_AMD_PLATFORM_DEVICE which selects ARM thing? i.e.,
>ARM_AMBA. Can that even work?
>
>[ Rant on the side: And that ARM_AMBA thing has, of course, no effing
> help text. Dammit, people need to start explaining those cryptic
> abbreviations. Somewhere in the code I found "Advanced Microcontroller
> Bus Architecture". This is clearly suboptimal. ]
>
>So why does the X86 platform device need to select the AMBA crap?
Russell,
The AMBA bus is already leveraged in AMD X86 arch hardware design for UART
controller and UART DMA. And may will be used in other arch as well, however,
it is rather confusing if we select ARM_AMBA in other arch, such as X86.
How about rename CONFIG_ARM_AMBA to CONFIG_AMBA? So different arch
can select it without causing misunderstanding.
Thank you very much.
Regards,
Hongcheng(Annie)
WARNING: multiple messages have this Message-ID (diff)
From: Annie.Wang@amd.com (Wang, Annie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] 8250/Kconfig: add config option CONFIG_SERIAL_8250_AMD
Date: Mon, 11 Jan 2016 07:26:39 +0000 [thread overview]
Message-ID: <BLUPR12MB043368006316A2FB11A0DE8B81C90@BLUPR12MB0433.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20160106104602.GA19507@pd.tnic>
>-----Original Message-----
>From: Borislav Petkov [mailto:bp at alien8.de]
>Sent: Wednesday, January 06, 2016 6:46 PM
>To: Wang, Annie
>Cc: Andy Shevchenko; Vinod Koul; Mika Westerberg; Greg Kroah-Hartman; Rafael
>J. Wysocki; linux-acpi at vger.kernel.org; linux-kernel at vger.kernel.org; linux-
>serial at vger.kernel.org; dmaengine at vger.kernel.org; Huang, Ray; Wan, Vincent;
>Xue, Ken; Robin Murphy; Graeme Gregory; Li, Tony; Yu, Xiangliang
>Subject: Re: [PATCH 1/6] 8250/Kconfig: add config option
>CONFIG_SERIAL_8250_AMD
>
>On Wed, Jan 06, 2016 at 02:08:18AM +0000, Wang, Annie wrote:
>> How about I add select ARM_AMBA and SERIAL_8250 in arch/x86/Kconfig?
>
>Yeah, select sounds good in that case, except in that particular case ...
>
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index
>> db3622f..0fe6657 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -537,11 +537,15 @@ config X86_AMD_PLATFORM_DEVICE
>> depends on ACPI
>> select COMMON_CLK
>> select PINCTRL
>> + select SERIAL_8250
>> + select ARM_AMBA
>
>... that's a X86_AMD_PLATFORM_DEVICE which selects ARM thing? i.e.,
>ARM_AMBA. Can that even work?
>
>[ Rant on the side: And that ARM_AMBA thing has, of course, no effing
> help text. Dammit, people need to start explaining those cryptic
> abbreviations. Somewhere in the code I found "Advanced Microcontroller
> Bus Architecture". This is clearly suboptimal. ]
>
>So why does the X86 platform device need to select the AMBA crap?
Russell,
The AMBA bus is already leveraged in AMD X86 arch hardware design for UART
controller and UART DMA. And may will be used in other arch as well, however,
it is rather confusing if we select ARM_AMBA in other arch, such as X86.
How about rename CONFIG_ARM_AMBA to CONFIG_AMBA? So different arch
can select it without causing misunderstanding.
Thank you very much.
Regards,
Hongcheng(Annie)
next prev parent reply other threads:[~2016-01-11 7:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 5:31 [PATCH 0/6] 8250: AMD Carrizo UART PL300 DMA enablement Wang Hongcheng
2016-01-04 5:31 ` Wang Hongcheng
2016-01-04 5:31 ` [PATCH 1/6] 8250/Kconfig: add config option CONFIG_SERIAL_8250_AMD Wang Hongcheng
2016-01-04 5:31 ` Wang Hongcheng
2016-01-04 14:41 ` Borislav Petkov
2016-01-06 2:08 ` Wang, Annie
2016-01-06 2:08 ` Wang, Annie
2016-01-06 10:46 ` Borislav Petkov
2016-01-11 7:26 ` Wang, Annie [this message]
2016-01-11 7:26 ` Wang, Annie
2016-01-11 7:26 ` Wang, Annie
2016-01-04 5:31 ` [PATCH 2/6] ACPI: create setup_quirk in acpi_apd Wang Hongcheng
2016-01-04 5:31 ` Wang Hongcheng
2016-01-04 14:21 ` Andy Shevchenko
2016-01-04 5:31 ` [PATCH 3/6] ACPI: add 2 parameters to function acpi dma controller register Wang Hongcheng
2016-01-04 5:31 ` Wang Hongcheng
2016-01-04 14:36 ` Andy Shevchenko
2016-01-04 14:45 ` Mika Westerberg
2016-01-06 6:46 ` Wang, Annie
2016-01-07 9:52 ` Mika Westerberg
2016-01-07 10:08 ` Andy Shevchenko
2016-01-04 5:31 ` [PATCH 4/6] dmaengine: pl330: add new items for pl330 private data Wang Hongcheng
2016-01-04 5:31 ` Wang Hongcheng
2016-01-04 5:43 ` kbuild test robot
2016-01-04 5:43 ` kbuild test robot
2016-01-04 14:38 ` Andy Shevchenko
2016-01-04 5:31 ` [PATCH 5/6] dmaengine: pl330: provide ACPI dmaengine interface Wang Hongcheng
2016-01-04 5:31 ` Wang Hongcheng
2016-01-04 14:46 ` Andy Shevchenko
2016-01-04 5:31 ` [PATCH 6/6] Serial:8250: New Port Type PORT_AMD_8250 Wang Hongcheng
2016-01-04 5:31 ` Wang Hongcheng
2016-01-04 5:47 ` kbuild test robot
2016-01-04 5:47 ` kbuild test robot
2016-01-05 12:01 ` Heikki Krogerus
2016-01-14 6:23 ` Wang, Annie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLUPR12MB043368006316A2FB11A0DE8B81C90@BLUPR12MB0433.namprd12.prod.outlook.com \
--to=annie.wang@amd.com \
--cc=Ken.Xue@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Tony.Li@amd.com \
--cc=Vincent.Wan@amd.com \
--cc=Xiangliang.Yu@amd.com \
--cc=andy.shevchenko@gmail.com \
--cc=bp@alien8.de \
--cc=dmaengine@vger.kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=robin.murphy@arm.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.