All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/ttm:fix missing inc bo_count
@ 2017-08-14  3:43 Monk Liu
       [not found] ` <1502682217-8920-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Monk Liu @ 2017-08-14  3:43 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Monk Liu

From: Monk Liu <monk.liu@amd.com>

Change-Id: I32ed928e59db5478e429189ac8b010e336e45a94
Signe-off-by: Jack Xiao <jack.xiao@amd.com>
---
 drivers/gpu/drm/ttm/ttm_bo_util.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
index d0459b3..c934ad5 100644
--- a/drivers/gpu/drm/ttm/ttm_bo_util.c
+++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
@@ -469,6 +469,7 @@ static int ttm_buffer_object_transfer(struct ttm_buffer_object *bo,
 	 * TODO: Explicit member copy would probably be better here.
 	 */
 
+	atomic_inc(&bo->glob->bo_count);
 	INIT_LIST_HEAD(&fbo->ddestroy);
 	INIT_LIST_HEAD(&fbo->lru);
 	INIT_LIST_HEAD(&fbo->swap);
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/ttm:fix missing inc bo_count
       [not found] ` <1502682217-8920-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
@ 2017-08-14  8:07   ` Christian König
  2017-08-23 13:33   ` Deucher, Alexander
  1 sibling, 0 replies; 4+ messages in thread
From: Christian König @ 2017-08-14  8:07 UTC (permalink / raw)
  To: Monk Liu, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Am 14.08.2017 um 05:43 schrieb Monk Liu:
> From: Monk Liu <monk.liu@amd.com>
>
> Change-Id: I32ed928e59db5478e429189ac8b010e336e45a94
> Signe-off-by: Jack Xiao <jack.xiao@amd.com>

Nice catch, patch is Reviewed-by: Christian König <christian.koenig@amd.com>

Please ping me if those TTM patches need a whitelisting in our internal 
git server.

Christian.

> ---
>   drivers/gpu/drm/ttm/ttm_bo_util.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
> index d0459b3..c934ad5 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
> @@ -469,6 +469,7 @@ static int ttm_buffer_object_transfer(struct ttm_buffer_object *bo,
>   	 * TODO: Explicit member copy would probably be better here.
>   	 */
>   
> +	atomic_inc(&bo->glob->bo_count);
>   	INIT_LIST_HEAD(&fbo->ddestroy);
>   	INIT_LIST_HEAD(&fbo->lru);
>   	INIT_LIST_HEAD(&fbo->swap);


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH] drm/ttm:fix missing inc bo_count
       [not found] ` <1502682217-8920-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
  2017-08-14  8:07   ` Christian König
@ 2017-08-23 13:33   ` Deucher, Alexander
       [not found]     ` <CY4PR12MB165398961A33FDBE93B32992F7850-rpdhrqHFk06apTa93KjAaQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
  1 sibling, 1 reply; 4+ messages in thread
From: Deucher, Alexander @ 2017-08-23 13:33 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Liu, Monk

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Sunday, August 13, 2017 11:44 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH] drm/ttm:fix missing inc bo_count
> 
> From: Monk Liu <monk.liu@amd.com>
> 
> Change-Id: I32ed928e59db5478e429189ac8b010e336e45a94
> Signe-off-by: Jack Xiao <jack.xiao@amd.com>

Did these ever land?  I don't remember seeing them in the 4.12 branch.

Alex


> ---
>  drivers/gpu/drm/ttm/ttm_bo_util.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c
> b/drivers/gpu/drm/ttm/ttm_bo_util.c
> index d0459b3..c934ad5 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
> @@ -469,6 +469,7 @@ static int ttm_buffer_object_transfer(struct
> ttm_buffer_object *bo,
>  	 * TODO: Explicit member copy would probably be better here.
>  	 */
> 
> +	atomic_inc(&bo->glob->bo_count);
>  	INIT_LIST_HEAD(&fbo->ddestroy);
>  	INIT_LIST_HEAD(&fbo->lru);
>  	INIT_LIST_HEAD(&fbo->swap);
> --
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH] drm/ttm:fix missing inc bo_count
       [not found]     ` <CY4PR12MB165398961A33FDBE93B32992F7850-rpdhrqHFk06apTa93KjAaQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
@ 2017-08-24  2:25       ` Liu, Monk
  0 siblings, 0 replies; 4+ messages in thread
From: Liu, Monk @ 2017-08-24  2:25 UTC (permalink / raw)
  To: Deucher, Alexander, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Thanks，that one is somehow missed !
Just pushed



-----Original Message-----
From: Deucher, Alexander 
Sent: Wednesday, August 23, 2017 9:34 PM
To: Liu, Monk <Monk.Liu@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Liu, Monk <Monk.Liu@amd.com>
Subject: RE: [PATCH] drm/ttm:fix missing inc bo_count

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf 
> Of Monk Liu
> Sent: Sunday, August 13, 2017 11:44 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH] drm/ttm:fix missing inc bo_count
> 
> From: Monk Liu <monk.liu@amd.com>
> 
> Change-Id: I32ed928e59db5478e429189ac8b010e336e45a94
> Signe-off-by: Jack Xiao <jack.xiao@amd.com>

Did these ever land?  I don't remember seeing them in the 4.12 branch.

Alex


> ---
>  drivers/gpu/drm/ttm/ttm_bo_util.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c
> b/drivers/gpu/drm/ttm/ttm_bo_util.c
> index d0459b3..c934ad5 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
> @@ -469,6 +469,7 @@ static int ttm_buffer_object_transfer(struct 
> ttm_buffer_object *bo,
>  	 * TODO: Explicit member copy would probably be better here.
>  	 */
> 
> +	atomic_inc(&bo->glob->bo_count);
>  	INIT_LIST_HEAD(&fbo->ddestroy);
>  	INIT_LIST_HEAD(&fbo->lru);
>  	INIT_LIST_HEAD(&fbo->swap);
> --
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-24  2:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-14  3:43 [PATCH] drm/ttm:fix missing inc bo_count Monk Liu
     [not found] ` <1502682217-8920-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-08-14  8:07   ` Christian König
2017-08-23 13:33   ` Deucher, Alexander
     [not found]     ` <CY4PR12MB165398961A33FDBE93B32992F7850-rpdhrqHFk06apTa93KjAaQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-08-24  2:25       ` Liu, Monk

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.