* [Qemu-devel] First contribution - Interested in Outreachy @ 2017-04-10 19:21 Prerna Garg 2017-04-10 19:59 ` Prerna Garg 0 siblings, 1 reply; 6+ messages in thread From: Prerna Garg @ 2017-04-10 19:21 UTC (permalink / raw) To: qemu-devel; +Cc: stefanha, kwolf, Alberto Garcia Hello, This is my first patch submission. I am interested in the block filter project for this round of Outreachy. diff --git a/backends/hostmem.c b/backends/hostmem.c index 89feb9e..f056a25 100644 --- a/backends/hostmem.c +++ b/backends/hostmem.c @@ -263,7 +263,7 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp) uint64_t sz; if (bc->alloc) { - bc->alloc(backend, &local_err); + bc->g_alloc(backend, &local_err); if (local_err) { goto out; } ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] First contribution - Interested in Outreachy 2017-04-10 19:21 [Qemu-devel] First contribution - Interested in Outreachy Prerna Garg @ 2017-04-10 19:59 ` Prerna Garg 2017-04-11 7:53 ` Kevin Wolf 0 siblings, 1 reply; 6+ messages in thread From: Prerna Garg @ 2017-04-10 19:59 UTC (permalink / raw) To: qemu-devel; +Cc: stefanha, kwolf, Alberto Garcia Hello, The previous patch was incorrect. Sorry for the inconvenience. Please consider this as my first contribution. diff --git a/block/iscsi.c b/block/iscsi.c index 716e74a..b926ed4 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1034,7 +1034,7 @@ static BlockAIOCB *iscsi_aio_ioctl(BlockDriverState *bs, return NULL; } - acb->task = malloc(sizeof(struct scsi_task)); + acb->task = g_malloc(sizeof(struct scsi_task)); if (acb->task == NULL) { error_report("iSCSI: Failed to allocate task for scsi command. %s", iscsi_get_error(iscsi)); ________________________________ From: Prerna Garg Sent: Tuesday, April 11, 2017 12:51 AM To: qemu-devel@nongnu.org Cc: stefanha@redhat.com; kwolf@redhat.com; Alberto Garcia Subject: First contribution - Interested in Outreachy Hello, This is my first patch submission. I am interested in the block filter project for this round of Outreachy. diff --git a/backends/hostmem.c b/backends/hostmem.c index 89feb9e..f056a25 100644 --- a/backends/hostmem.c +++ b/backends/hostmem.c @@ -263,7 +263,7 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp) uint64_t sz; if (bc->alloc) { - bc->alloc(backend, &local_err); + bc->g_alloc(backend, &local_err); if (local_err) { goto out; } ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] First contribution - Interested in Outreachy 2017-04-10 19:59 ` Prerna Garg @ 2017-04-11 7:53 ` Kevin Wolf [not found] ` <BM1PR01MB0722AC7132DBFA648D3732A084000@BM1PR01MB0722.INDPRD01.PROD.OUTLOOK.COM> 0 siblings, 1 reply; 6+ messages in thread From: Kevin Wolf @ 2017-04-11 7:53 UTC (permalink / raw) To: Prerna Garg; +Cc: qemu-devel, stefanha, Alberto Garcia Hi Prerna, Am 10.04.2017 um 21:59 hat Prerna Garg geschrieben: > The previous patch was incorrect. Sorry for the inconvenience. Please consider > this as my first contribution. Please read this wiki page about how to submit patches to QEMU: http://wiki.qemu-project.org/Contribute/SubmitAPatch The most important point that is missing from your patch is the Signed-off-by line, without which a patch cannot be accepted. You should also try to have a commit message (including the subject line) that describes the change that your patch is making, and include [PATCH] in your subject line. If you use 'git format-patch' to create the email, the [PATCH] is added automatically. Kevin ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <BM1PR01MB0722AC7132DBFA648D3732A084000@BM1PR01MB0722.INDPRD01.PROD.OUTLOOK.COM>]
* [Qemu-devel] Fw: First contribution - Interested in Outreachy [not found] ` <BM1PR01MB0722AC7132DBFA648D3732A084000@BM1PR01MB0722.INDPRD01.PROD.OUTLOOK.COM> @ 2017-04-11 16:44 ` Prerna Garg 2017-04-12 9:41 ` Alberto Garcia 2017-04-13 0:32 ` Fam Zheng 0 siblings, 2 replies; 6+ messages in thread From: Prerna Garg @ 2017-04-11 16:44 UTC (permalink / raw) To: qemu-devel, Stefan Hajnoczi, Alberto Garcia [-- Attachment #1: Type: text/plain, Size: 1572 bytes --] ________________________________ From: Prerna Garg Sent: Tuesday, April 11, 2017 9:57 PM To: Kevin Wolf Subject: Re: First contribution - Interested in Outreachy Hello, I am having difficulties sending the email through command line. So as a last resort I am sending the patch as an attachment. Prerna ________________________________ From: Kevin Wolf <kwolf@redhat.com> Sent: Tuesday, April 11, 2017 1:23 PM To: Prerna Garg Cc: qemu-devel@nongnu.org; stefanha@redhat.com; Alberto Garcia Subject: Re: First contribution - Interested in Outreachy Hi Prerna, Am 10.04.2017 um 21:59 hat Prerna Garg geschrieben: > The previous patch was incorrect. Sorry for the inconvenience. Please consider > this as my first contribution. Please read this wiki page about how to submit patches to QEMU: http://wiki.qemu-project.org/Contribute/SubmitAPatch Contribute/SubmitAPatch - QEMU<http://wiki.qemu-project.org/Contribute/SubmitAPatch> wiki.qemu-project.org QEMU welcomes contributions of code (either fixing bugs or adding new functionality). However, we get a lot of patches, and so we have some guidelines about ... The most important point that is missing from your patch is the Signed-off-by line, without which a patch cannot be accepted. You should also try to have a commit message (including the subject line) that describes the change that your patch is making, and include [PATCH] in your subject line. If you use 'git format-patch' to create the email, the [PATCH] is added automatically. Kevin [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0001-Changed-malloc-to-g_malloc-in-block-iscsi.c-file.patch --] [-- Type: text/x-patch; name="0001-Changed-malloc-to-g_malloc-in-block-iscsi.c-file.patch", Size: 1175 bytes --] From d7aa9e1659cedff36e7bed148fd0a3ebae63e255 Mon Sep 17 00:00:00 2001 From: Prerna Garg <prerna.garg@live.com> Date: Tue, 11 Apr 2017 21:50:29 +0530 Subject: [PATCH] Changed malloc to g_malloc in block/iscsi.c file Signed-off-by: Prerna Garg <prerna.garg@live.com> --- block/iscsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 716e74a..b926ed4 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1034,7 +1034,7 @@ static BlockAIOCB *iscsi_aio_ioctl(BlockDriverState *bs, return NULL; } - acb->task = malloc(sizeof(struct scsi_task)); + acb->task = g_malloc(sizeof(struct scsi_task)); if (acb->task == NULL) { error_report("iSCSI: Failed to allocate task for scsi command. %s", iscsi_get_error(iscsi)); @@ -1398,7 +1398,7 @@ static void iscsi_readcapacity_sync(IscsiLun *iscsilun, Error **errp) struct scsi_task *task = NULL; struct scsi_readcapacity10 *rc10 = NULL; struct scsi_readcapacity16 *rc16 = NULL; - int retries = ISCSI_CMD_RETRIES; + int retries = ISCSI_CMD_RETRIES; do { if (task != NULL) { -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] Fw: First contribution - Interested in Outreachy 2017-04-11 16:44 ` [Qemu-devel] Fw: " Prerna Garg @ 2017-04-12 9:41 ` Alberto Garcia 2017-04-13 0:32 ` Fam Zheng 1 sibling, 0 replies; 6+ messages in thread From: Alberto Garcia @ 2017-04-12 9:41 UTC (permalink / raw) To: Prerna Garg, qemu-devel, Stefan Hajnoczi On Tue 11 Apr 2017 06:44:33 PM CEST, Prerna Garg wrote: > I am having difficulties sending the email through command line. So as > a last resort I am sending the patch as an attachment. Hi! what is the exact problem? Once you commit your patch, can you export it correctly to a file using "git format-patch" ? After that you can simply write something like git send-email --to="qemu-devel@nongnu.org" --cc="Alberto Garcia <berto@igalia.com>" patch-file.patch Berto ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] Fw: First contribution - Interested in Outreachy 2017-04-11 16:44 ` [Qemu-devel] Fw: " Prerna Garg 2017-04-12 9:41 ` Alberto Garcia @ 2017-04-13 0:32 ` Fam Zheng 1 sibling, 0 replies; 6+ messages in thread From: Fam Zheng @ 2017-04-13 0:32 UTC (permalink / raw) To: Prerna Garg; +Cc: qemu-devel, Stefan Hajnoczi, Alberto Garcia On Tue, 04/11 16:44, Prerna Garg wrote: > > > > ________________________________ > From: Prerna Garg > Sent: Tuesday, April 11, 2017 9:57 PM > To: Kevin Wolf > Subject: Re: First contribution - Interested in Outreachy > > > Hello, > > > I am having difficulties sending the email through command line. So as a last > resort I am sending the patch as an attachment. Hi Prerna, If it is git-send-email that doesn't work, probably it's because you haven't configured the email server info correctly. Follow the instructions of git-send-email to point to the used SMTP server in you $HOME/.gitconfig: https://git-scm.com/docs/git-send-email Let us know if you have any more difficulties. Fam ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-13 0:32 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-04-10 19:21 [Qemu-devel] First contribution - Interested in Outreachy Prerna Garg 2017-04-10 19:59 ` Prerna Garg 2017-04-11 7:53 ` Kevin Wolf [not found] ` <BM1PR01MB0722AC7132DBFA648D3732A084000@BM1PR01MB0722.INDPRD01.PROD.OUTLOOK.COM> 2017-04-11 16:44 ` [Qemu-devel] Fw: " Prerna Garg 2017-04-12 9:41 ` Alberto Garcia 2017-04-13 0:32 ` Fam Zheng
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.