All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iommu/fsl: Fix the dependency check for PAMU driver.
@ 2015-05-14 17:41 ` Varun Sethi
  0 siblings, 0 replies; 6+ messages in thread
From: Varun Sethi @ 2015-05-14 17:41 UTC (permalink / raw)
  To: linuxppc-dev, jroedel, joro, iommu, scottwood; +Cc: Varun Sethi

Fix the build dependency for the PAMU driver. PPC32 build dependecy is incorrect.
Add the CORENET_GENERIC build dependency for PAMU driver.

Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
---
 drivers/iommu/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index 1ae4e54..4ace8db 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -50,7 +50,7 @@ config OF_IOMMU
 
 config FSL_PAMU
 	bool "Freescale IOMMU support"
-	depends on PPC32
+	depends on CORENET_GENERIC
 	depends on PPC_E500MC || COMPILE_TEST
 	select IOMMU_API
 	select GENERIC_ALLOCATOR
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] iommu/fsl: Fix the dependency check for PAMU driver.
@ 2015-05-14 17:41 ` Varun Sethi
  0 siblings, 0 replies; 6+ messages in thread
From: Varun Sethi @ 2015-05-14 17:41 UTC (permalink / raw)
  To: linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ, jroedel-l3A5Bk7waGM,
	joro-zLv9SwRftAIdnm+yROfE0A,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
	scottwood-KZfg59tc24xl57MIdRCFDg
  Cc: Varun Sethi

Fix the build dependency for the PAMU driver. PPC32 build dependecy is incorrect.
Add the CORENET_GENERIC build dependency for PAMU driver.

Signed-off-by: Varun Sethi <Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
 drivers/iommu/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index 1ae4e54..4ace8db 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -50,7 +50,7 @@ config OF_IOMMU
 
 config FSL_PAMU
 	bool "Freescale IOMMU support"
-	depends on PPC32
+	depends on CORENET_GENERIC
 	depends on PPC_E500MC || COMPILE_TEST
 	select IOMMU_API
 	select GENERIC_ALLOCATOR
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] iommu/fsl: Fix the dependency check for PAMU driver.
@ 2015-05-14 18:13   ` Scott Wood
  0 siblings, 0 replies; 6+ messages in thread
From: Scott Wood @ 2015-05-14 18:13 UTC (permalink / raw)
  To: Varun Sethi; +Cc: joro, jroedel, linuxppc-dev, iommu

On Thu, 2015-05-14 at 23:11 +0530, Varun Sethi wrote:
> Fix the build dependency for the PAMU driver. PPC32 build dependecy is incorrect.
> Add the CORENET_GENERIC build dependency for PAMU driver.
> 
> Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
> ---
>  drivers/iommu/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index 1ae4e54..4ace8db 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -50,7 +50,7 @@ config OF_IOMMU
>  
>  config FSL_PAMU
>  	bool "Freescale IOMMU support"
> -	depends on PPC32
> +	depends on CORENET_GENERIC
>  	depends on PPC_E500MC || COMPILE_TEST
>  	select IOMMU_API
>  	select GENERIC_ALLOCATOR

CORENET_GENERIC is for board support.  There is no guarantee that all
corenet boards will use it.  You already depend on PPC_E500MC; why do
you need anything else (besides probably getting rid of "||
COMPILE_TEST" which is useless if you do add CORENET_GENERIC, because
CORENET_GENERIC implies PPC_E500MC)?

-Scott

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] iommu/fsl: Fix the dependency check for PAMU driver.
@ 2015-05-14 18:13   ` Scott Wood
  0 siblings, 0 replies; 6+ messages in thread
From: Scott Wood @ 2015-05-14 18:13 UTC (permalink / raw)
  To: Varun Sethi
  Cc: jroedel-l3A5Bk7waGM, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA

On Thu, 2015-05-14 at 23:11 +0530, Varun Sethi wrote:
> Fix the build dependency for the PAMU driver. PPC32 build dependecy is incorrect.
> Add the CORENET_GENERIC build dependency for PAMU driver.
> 
> Signed-off-by: Varun Sethi <Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
>  drivers/iommu/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index 1ae4e54..4ace8db 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -50,7 +50,7 @@ config OF_IOMMU
>  
>  config FSL_PAMU
>  	bool "Freescale IOMMU support"
> -	depends on PPC32
> +	depends on CORENET_GENERIC
>  	depends on PPC_E500MC || COMPILE_TEST
>  	select IOMMU_API
>  	select GENERIC_ALLOCATOR

CORENET_GENERIC is for board support.  There is no guarantee that all
corenet boards will use it.  You already depend on PPC_E500MC; why do
you need anything else (besides probably getting rid of "||
COMPILE_TEST" which is useless if you do add CORENET_GENERIC, because
CORENET_GENERIC implies PPC_E500MC)?

-Scott

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] iommu/fsl: Fix the dependency check for PAMU driver.
@ 2015-05-14 18:17     ` Varun Sethi
  0 siblings, 0 replies; 6+ messages in thread
From: Varun Sethi @ 2015-05-14 18:17 UTC (permalink / raw)
  To: Scott Wood; +Cc: joro, jroedel, linuxppc-dev, iommu

SGkgU2NvdHQsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBT
Y290dC1CMDc0MjENCj4gU2VudDogVGh1cnNkYXksIE1heSAxNCwgMjAxNSAxMTo0MyBQTQ0KPiBU
bzogU2V0aGkgVmFydW4tQjE2Mzk1DQo+IENjOiBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9y
ZzsganJvZWRlbEBzdXNlLmRlOyBqb3JvQDhieXRlcy5vcmc7DQo+IGlvbW11QGxpc3RzLmxpbnV4
LWZvdW5kYXRpb24ub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGlvbW11L2ZzbDogRml4IHRo
ZSBkZXBlbmRlbmN5IGNoZWNrIGZvciBQQU1VIGRyaXZlci4NCj4gDQo+IE9uIFRodSwgMjAxNS0w
NS0xNCBhdCAyMzoxMSArMDUzMCwgVmFydW4gU2V0aGkgd3JvdGU6DQo+ID4gRml4IHRoZSBidWls
ZCBkZXBlbmRlbmN5IGZvciB0aGUgUEFNVSBkcml2ZXIuIFBQQzMyIGJ1aWxkIGRlcGVuZGVjeSBp
cw0KPiBpbmNvcnJlY3QuDQo+ID4gQWRkIHRoZSBDT1JFTkVUX0dFTkVSSUMgYnVpbGQgZGVwZW5k
ZW5jeSBmb3IgUEFNVSBkcml2ZXIuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBWYXJ1biBTZXRo
aSA8VmFydW4uU2V0aGlAZnJlZXNjYWxlLmNvbT4NCj4gPiAtLS0NCj4gPiAgZHJpdmVycy9pb21t
dS9LY29uZmlnIHwgICAgMiArLQ0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyks
IDEgZGVsZXRpb24oLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2lvbW11L0tjb25m
aWcgYi9kcml2ZXJzL2lvbW11L0tjb25maWcgaW5kZXgNCj4gPiAxYWU0ZTU0Li40YWNlOGRiIDEw
MDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvaW9tbXUvS2NvbmZpZw0KPiA+ICsrKyBiL2RyaXZlcnMv
aW9tbXUvS2NvbmZpZw0KPiA+IEBAIC01MCw3ICs1MCw3IEBAIGNvbmZpZyBPRl9JT01NVQ0KPiA+
DQo+ID4gIGNvbmZpZyBGU0xfUEFNVQ0KPiA+ICAJYm9vbCAiRnJlZXNjYWxlIElPTU1VIHN1cHBv
cnQiDQo+ID4gLQlkZXBlbmRzIG9uIFBQQzMyDQo+ID4gKwlkZXBlbmRzIG9uIENPUkVORVRfR0VO
RVJJQw0KPiA+ICAJZGVwZW5kcyBvbiBQUENfRTUwME1DIHx8IENPTVBJTEVfVEVTVA0KPiA+ICAJ
c2VsZWN0IElPTU1VX0FQSQ0KPiA+ICAJc2VsZWN0IEdFTkVSSUNfQUxMT0NBVE9SDQo+IA0KPiBD
T1JFTkVUX0dFTkVSSUMgaXMgZm9yIGJvYXJkIHN1cHBvcnQuICBUaGVyZSBpcyBubyBndWFyYW50
ZWUgdGhhdCBhbGwNCj4gY29yZW5ldCBib2FyZHMgd2lsbCB1c2UgaXQuICBZb3UgYWxyZWFkeSBk
ZXBlbmQgb24gUFBDX0U1MDBNQzsgd2h5IGRvIHlvdQ0KPiBuZWVkIGFueXRoaW5nIGVsc2UgKGJl
c2lkZXMgcHJvYmFibHkgZ2V0dGluZyByaWQgb2YgInx8IENPTVBJTEVfVEVTVCINCj4gd2hpY2gg
aXMgdXNlbGVzcyBpZiB5b3UgZG8gYWRkIENPUkVORVRfR0VORVJJQywgYmVjYXVzZQ0KPiBDT1JF
TkVUX0dFTkVSSUMgaW1wbGllcyBQUENfRTUwME1DKT8NClllcyB0aGlzIGlzIHJlcXVpcmVkIHRv
IGNvdW50ZXIgInx8Q09NUElMRV9URVNULg0KDQotVmFydW4NCg0K

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] iommu/fsl: Fix the dependency check for PAMU driver.
@ 2015-05-14 18:17     ` Varun Sethi
  0 siblings, 0 replies; 6+ messages in thread
From: Varun Sethi @ 2015-05-14 18:17 UTC (permalink / raw)
  To: Scott Wood
  Cc: jroedel-l3A5Bk7waGM, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA

Hi Scott,

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, May 14, 2015 11:43 PM
> To: Sethi Varun-B16395
> Cc: linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; jroedel-l3A5Bk7waGM@public.gmane.org; joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org;
> iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
> Subject: Re: [PATCH] iommu/fsl: Fix the dependency check for PAMU driver.
> 
> On Thu, 2015-05-14 at 23:11 +0530, Varun Sethi wrote:
> > Fix the build dependency for the PAMU driver. PPC32 build dependecy is
> incorrect.
> > Add the CORENET_GENERIC build dependency for PAMU driver.
> >
> > Signed-off-by: Varun Sethi <Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > ---
> >  drivers/iommu/Kconfig |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index
> > 1ae4e54..4ace8db 100644
> > --- a/drivers/iommu/Kconfig
> > +++ b/drivers/iommu/Kconfig
> > @@ -50,7 +50,7 @@ config OF_IOMMU
> >
> >  config FSL_PAMU
> >  	bool "Freescale IOMMU support"
> > -	depends on PPC32
> > +	depends on CORENET_GENERIC
> >  	depends on PPC_E500MC || COMPILE_TEST
> >  	select IOMMU_API
> >  	select GENERIC_ALLOCATOR
> 
> CORENET_GENERIC is for board support.  There is no guarantee that all
> corenet boards will use it.  You already depend on PPC_E500MC; why do you
> need anything else (besides probably getting rid of "|| COMPILE_TEST"
> which is useless if you do add CORENET_GENERIC, because
> CORENET_GENERIC implies PPC_E500MC)?
Yes this is required to counter "||COMPILE_TEST.

-Varun

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-05-14 18:41 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-14 17:41 [PATCH] iommu/fsl: Fix the dependency check for PAMU driver Varun Sethi
2015-05-14 17:41 ` Varun Sethi
2015-05-14 18:13 ` Scott Wood
2015-05-14 18:13   ` Scott Wood
2015-05-14 18:17   ` Varun Sethi
2015-05-14 18:17     ` Varun Sethi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.