[meta-fsl-demos][PATCH] packagegroup-fsl-tools-gpu-external: Make eglinfo inclusion i.MX6-only

[meta-fsl-demos][PATCH] packagegroup-fsl-tools-gpu-external: Make eglinfo inclusion i.MX6-only

[Otavio Salvador]

The eglinfo recipe does not support yet other i.MX SoC so it needs to
be included for i.MX6 SoCs only.

Change-Id: I1897afa1a51d24e3b2a6260ccf8da70d8932606d
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 .../packagegroups/packagegroup-fsl-tools-gpu-external.bb     | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
index c11422b..4a262f2 100644
--- a/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
+++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
@@ -1,4 +1,5 @@
 # Copyright (C) 2014 Freescale Semiconductor
+# Copyright (C) 2015 O.S. Systems Software LTDA.
 # Released under the MIT license (see COPYING.MIT for the terms)
 DESCRIPTION = "Package group used by FSL Community to provide graphic packages used \
 to test the several hardware accelerated graphics APIs including packages not \
@@ -10,17 +11,18 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
 
 inherit packagegroup
 
-X11_TOOLS = " \
+SOC_GPU_TOOLS_X11 = " \
     mesa-demos \
     glmark2 \
+"
+SOC_GPU_TOOLS_X11_append_mx6 = " \
     eglinfo-x11 \
 "
 
-FB_TOOLS = " \
-    eglinfo-fb \
-"
+SOC_GPU_TOOLS_FB = ""
+SOC_GPU_TOOLS_FB_mx6 = "eglinfo-fb"
 
 RDEPENDS_${PN} = " \
     ${@base_contains("LICENSE_FLAGS_WHITELIST", "commercial", "opencv-samples", "", d)} \
-    ${@base_contains("DISTRO_FEATURES", "x11", "${X11_TOOLS}", "${FB_TOOLS}", d)} \
+    ${@base_contains("DISTRO_FEATURES", "x11", "${SOC_GPU_TOOLS_X11}", "${SOC_GPU_TOOLS_FB}", d)} \
 "
-- 
2.1.4

Re: [meta-fsl-demos][PATCH] packagegroup-fsl-tools-gpu-external: Make eglinfo inclusion i.MX6-only

[Neena Busireddy]

Hi Otavio,

-----Original Message-----
From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-bounces@yoctoproject.org] On Behalf Of Otavio Salvador
Sent: Monday, April 27, 2015 3:39 PM
To: meta-freescale Mailing List
Cc: Otavio Salvador
Subject: [meta-freescale] [meta-fsl-demos][PATCH] packagegroup-fsl-tools-gpu-external: Make eglinfo inclusion i.MX6-only

The eglinfo recipe does not support yet other i.MX SoC so it needs to be included for i.MX6 SoCs only.

Change-Id: I1897afa1a51d24e3b2a6260ccf8da70d8932606d
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 .../packagegroups/packagegroup-fsl-tools-gpu-external.bb     | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
index c11422b..4a262f2 100644
--- a/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
+++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
@@ -1,4 +1,5 @@
 # Copyright (C) 2014 Freescale Semiconductor
+# Copyright (C) 2015 O.S. Systems Software LTDA.
 # Released under the MIT license (see COPYING.MIT for the terms)  DESCRIPTION = "Package group used by FSL Community to provide graphic packages used \  to test the several hardware accelerated graphics APIs including packages not \ @@ -10,17 +11,18 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
 
 inherit packagegroup
 
-X11_TOOLS = " \
+SOC_GPU_TOOLS_X11 = " \
     mesa-demos \
     glmark2 \
+"
+SOC_GPU_TOOLS_X11_append_mx6 = " \
     eglinfo-x11 \
 "
 
-FB_TOOLS = " \
-    eglinfo-fb \
-"
+SOC_GPU_TOOLS_FB = ""
+SOC_GPU_TOOLS_FB_mx6 = "eglinfo-fb"
 
 RDEPENDS_${PN} = " \
     ${@base_contains("LICENSE_FLAGS_WHITELIST", "commercial", "opencv-samples", "", d)} \
-    ${@base_contains("DISTRO_FEATURES", "x11", "${X11_TOOLS}", "${FB_TOOLS}", d)} \
+    ${@base_contains("DISTRO_FEATURES", "x11", "${SOC_GPU_TOOLS_X11}", 
+ "${SOC_GPU_TOOLS_FB}", d)} \
 "
Why are we adding eglinfo-fb to other backends ? 

Looks like your commit 697d68b050eb14643858c4e457c37a134f58b0c0 broke our builds.

--
2.1.4

--
_______________________________________________
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-fsl-demos][PATCH] packagegroup-fsl-tools-gpu-external: Make eglinfo inclusion i.MX6-only

[Otavio Salvador]

On Tue, Apr 28, 2015 at 5:28 PM, Neena Busireddy
<neena.busireddy@freescale.com> wrote:
> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-bounces@yoctoproject.org] On Behalf Of Otavio Salvador
> Sent: Monday, April 27, 2015 3:39 PM
> To: meta-freescale Mailing List
> Cc: Otavio Salvador
> Subject: [meta-freescale] [meta-fsl-demos][PATCH] packagegroup-fsl-tools-gpu-external: Make eglinfo inclusion i.MX6-only
>
> The eglinfo recipe does not support yet other i.MX SoC so it needs to be included for i.MX6 SoCs only.
>
> Change-Id: I1897afa1a51d24e3b2a6260ccf8da70d8932606d
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  .../packagegroups/packagegroup-fsl-tools-gpu-external.bb     | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
> index c11422b..4a262f2 100644
> --- a/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
> @@ -1,4 +1,5 @@
>  # Copyright (C) 2014 Freescale Semiconductor
> +# Copyright (C) 2015 O.S. Systems Software LTDA.
>  # Released under the MIT license (see COPYING.MIT for the terms)  DESCRIPTION = "Package group used by FSL Community to provide graphic packages used \  to test the several hardware accelerated graphics APIs including packages not \ @@ -10,17 +11,18 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
>
>  inherit packagegroup
>
> -X11_TOOLS = " \
> +SOC_GPU_TOOLS_X11 = " \
>      mesa-demos \
>      glmark2 \
> +"
> +SOC_GPU_TOOLS_X11_append_mx6 = " \
>      eglinfo-x11 \
>  "
>
> -FB_TOOLS = " \
> -    eglinfo-fb \
> -"
> +SOC_GPU_TOOLS_FB = ""
> +SOC_GPU_TOOLS_FB_mx6 = "eglinfo-fb"
>
>  RDEPENDS_${PN} = " \
>      ${@base_contains("LICENSE_FLAGS_WHITELIST", "commercial", "opencv-samples", "", d)} \
> -    ${@base_contains("DISTRO_FEATURES", "x11", "${X11_TOOLS}", "${FB_TOOLS}", d)} \
> +    ${@base_contains("DISTRO_FEATURES", "x11", "${SOC_GPU_TOOLS_X11}",
> + "${SOC_GPU_TOOLS_FB}", d)} \
>  "
> Why are we adding eglinfo-fb to other backends ?
>
> Looks like your commit 697d68b050eb14643858c4e457c37a134f58b0c0 broke our builds.

Do you have more info? Which backend it broke? Wayland?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-demos][PATCH] packagegroup-fsl-tools-gpu-external: Make eglinfo inclusion i.MX6-only

[Neena Busireddy]

On Tue, Apr 28, 2015 at 5:28 PM, Neena Busireddy <neena.busireddy@freescale.com> wrote:
> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org 
> [mailto:meta-freescale-bounces@yoctoproject.org] On Behalf Of Otavio 
> Salvador
> Sent: Monday, April 27, 2015 3:39 PM
> To: meta-freescale Mailing List
> Cc: Otavio Salvador
> Subject: [meta-freescale] [meta-fsl-demos][PATCH] 
> packagegroup-fsl-tools-gpu-external: Make eglinfo inclusion i.MX6-only
>
> The eglinfo recipe does not support yet other i.MX SoC so it needs to be included for i.MX6 SoCs only.
>
> Change-Id: I1897afa1a51d24e3b2a6260ccf8da70d8932606d
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  .../packagegroups/packagegroup-fsl-tools-gpu-external.bb     | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git 
> a/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb 
> b/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
> index c11422b..4a262f2 100644
> --- a/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
> @@ -1,4 +1,5 @@
>  # Copyright (C) 2014 Freescale Semiconductor
> +# Copyright (C) 2015 O.S. Systems Software LTDA.
>  # Released under the MIT license (see COPYING.MIT for the terms)  
> DESCRIPTION = "Package group used by FSL Community to provide graphic 
> packages used \  to test the several hardware accelerated graphics 
> APIs including packages not \ @@ -10,17 +11,18 @@ LIC_FILES_CHKSUM = 
> "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
>
>  inherit packagegroup
>
> -X11_TOOLS = " \
> +SOC_GPU_TOOLS_X11 = " \
>      mesa-demos \
>      glmark2 \
> +"
> +SOC_GPU_TOOLS_X11_append_mx6 = " \
>      eglinfo-x11 \
>  "
>
> -FB_TOOLS = " \
> -    eglinfo-fb \
> -"
> +SOC_GPU_TOOLS_FB = ""
> +SOC_GPU_TOOLS_FB_mx6 = "eglinfo-fb"
>
>  RDEPENDS_${PN} = " \
>      ${@base_contains("LICENSE_FLAGS_WHITELIST", "commercial", "opencv-samples", "", d)} \
> -    ${@base_contains("DISTRO_FEATURES", "x11", "${X11_TOOLS}", "${FB_TOOLS}", d)} \
> +    ${@base_contains("DISTRO_FEATURES", "x11", 
> + "${SOC_GPU_TOOLS_X11}", "${SOC_GPU_TOOLS_FB}", d)} \
>  "
> Why are we adding eglinfo-fb to other backends ?
>
> Looks like your commit 697d68b050eb14643858c4e457c37a134f58b0c0 broke our builds.

Do you have more info? Which backend it broke? Wayland?

I think it is directfb backend. Here is the error :

/var/lib/jenkins/jobs/fido-3.14.X-backend/workspace/temp_build_dir/build_qds/tmp/work/cortexa9hf-vfp-neon-mx6qdl-poky-linux-gnueabi/eglinfo-fb/1.0-r0/git/build/release/../../src/platform_fb_imx6.cpp:40: undefined reference to `fbCreateWindow'
| src/platform_fb_imx6.cpp.1.o: In function `eglinfo::native_display::native_display(char const*)':
| /var/lib/jenkins/jobs/fido-3.14.X-backend/workspace/temp_build_dir/build_qds/tmp/work/cortexa9hf-vfp-neon-mx6qdl-poky-linux-gnueabi/eglinfo-fb/1.0-r0/git/build/release/../../src/platform_fb_imx6.cpp:58: undefined reference to `fbGetDisplayByIndex'
| collect2: error: ld returned 1 exit status


-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-demos][PATCH] packagegroup-fsl-tools-gpu-external: Make eglinfo inclusion i.MX6-only

[Otavio Salvador]

On Tue, Apr 28, 2015 at 5:42 PM, Neena Busireddy
<neena.busireddy@freescale.com> wrote:
...
> I think it is directfb backend. Here is the error :
>
> /var/lib/jenkins/jobs/fido-3.14.X-backend/workspace/temp_build_dir/build_qds/tmp/work/cortexa9hf-vfp-neon-mx6qdl-poky-linux-gnueabi/eglinfo-fb/1.0-r0/git/build/release/../../src/platform_fb_imx6.cpp:40: undefined reference to `fbCreateWindow'
> | src/platform_fb_imx6.cpp.1.o: In function `eglinfo::native_display::native_display(char const*)':
> | /var/lib/jenkins/jobs/fido-3.14.X-backend/workspace/temp_build_dir/build_qds/tmp/work/cortexa9hf-vfp-neon-mx6qdl-poky-linux-gnueabi/eglinfo-fb/1.0-r0/git/build/release/../../src/platform_fb_imx6.cpp:58: undefined reference to `fbGetDisplayByIndex'
> | collect2: error: ld returned 1 exit status

Ok; this eglinfo dance is driving me crazy. It was suppose to be easy
but it is taking some iterations to cover all coner cases.

Wayland was also broken. I fixed both and am sending a patch for it.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750