* [PATCH] configs: socfpga: add CONFIG_BOOTCOMMAND for cyclone5
@ 2020-08-06 9:08 Ooi, Joyce
2020-08-06 9:55 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Ooi, Joyce @ 2020-08-06 9:08 UTC (permalink / raw)
To: u-boot
From: Joyce Ooi <joyce.ooi@intel.com>
Add CONFIG_BOOTCOMMAND in cyclone5 defconfig to run fatscript and enable
FPGA bridge
Signed-off-by: Joyce Ooi <joyce.ooi@intel.com>
---
configs/socfpga_cyclone5_defconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/configs/socfpga_cyclone5_defconfig b/configs/socfpga_cyclone5_defconfig
index 1633ca1deb5..132b7b7fa81 100644
--- a/configs/socfpga_cyclone5_defconfig
+++ b/configs/socfpga_cyclone5_defconfig
@@ -8,7 +8,8 @@ CONFIG_TARGET_SOCFPGA_CYCLONE5_SOCDK=y
CONFIG_SPL_TEXT_BASE=0xFFFF0000
CONFIG_DISTRO_DEFAULTS=y
CONFIG_FIT=y
-# CONFIG_USE_BOOTCOMMAND is not set
+CONFIG_USE_BOOTCOMMAND=y
+CONFIG_BOOTCOMMAND="run fatscript; bridge enable; run distro_bootcmd"
CONFIG_SYS_CONSOLE_IS_IN_ENV=y
CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y
CONFIG_SYS_CONSOLE_ENV_OVERWRITE=y
--
2.13.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] configs: socfpga: add CONFIG_BOOTCOMMAND for cyclone5
2020-08-06 9:08 [PATCH] configs: socfpga: add CONFIG_BOOTCOMMAND for cyclone5 Ooi, Joyce
@ 2020-08-06 9:55 ` Marek Vasut
2020-08-13 9:28 ` Ooi, Joyce
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2020-08-06 9:55 UTC (permalink / raw)
To: u-boot
On 8/6/20 11:08 AM, Ooi, Joyce wrote:
> From: Joyce Ooi <joyce.ooi@intel.com>
>
> Add CONFIG_BOOTCOMMAND in cyclone5 defconfig to run fatscript and enable
> FPGA bridge
>
> Signed-off-by: Joyce Ooi <joyce.ooi@intel.com>
> ---
> configs/socfpga_cyclone5_defconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configs/socfpga_cyclone5_defconfig b/configs/socfpga_cyclone5_defconfig
> index 1633ca1deb5..132b7b7fa81 100644
> --- a/configs/socfpga_cyclone5_defconfig
> +++ b/configs/socfpga_cyclone5_defconfig
> @@ -8,7 +8,8 @@ CONFIG_TARGET_SOCFPGA_CYCLONE5_SOCDK=y
> CONFIG_SPL_TEXT_BASE=0xFFFF0000
> CONFIG_DISTRO_DEFAULTS=y
> CONFIG_FIT=y
> -# CONFIG_USE_BOOTCOMMAND is not set
> +CONFIG_USE_BOOTCOMMAND=y
> +CONFIG_BOOTCOMMAND="run fatscript; bridge enable; run distro_bootcmd"
What is 'fatscript' ? Also, this breaks on systems where the FPGA isn't
loaded, as it enables bridges to nowhere.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] configs: socfpga: add CONFIG_BOOTCOMMAND for cyclone5
2020-08-06 9:55 ` Marek Vasut
@ 2020-08-13 9:28 ` Ooi, Joyce
0 siblings, 0 replies; 3+ messages in thread
From: Ooi, Joyce @ 2020-08-13 9:28 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Marek Vasut <marex@denx.de>
> Sent: Thursday, August 6, 2020 5:56 PM
> To: Ooi, Joyce <joyce.ooi@intel.com>; Simon Goldschmidt
> <simon.k.r.goldschmidt@gmail.com>; Tan, Ley Foon
> <ley.foon.tan@intel.com>; See, Chin Liang <chin.liang.see@intel.com>;
> Nguyen, Dinh <dinh.nguyen@intel.com>
> Cc: u-boot at lists.denx.de; Chang, Rebecca Swee Fun
> <rebecca.swee.fun.chang@intel.com>; Lim, Elly Siew Chin
> <elly.siew.chin.lim@intel.com>
> Subject: Re: [PATCH] configs: socfpga: add CONFIG_BOOTCOMMAND for
> cyclone5
>
> On 8/6/20 11:08 AM, Ooi, Joyce wrote:
> > From: Joyce Ooi <joyce.ooi@intel.com>
> >
> > Add CONFIG_BOOTCOMMAND in cyclone5 defconfig to run fatscript and
> > enable FPGA bridge
> >
> > Signed-off-by: Joyce Ooi <joyce.ooi@intel.com>
> > ---
> > configs/socfpga_cyclone5_defconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/configs/socfpga_cyclone5_defconfig
> > b/configs/socfpga_cyclone5_defconfig
> > index 1633ca1deb5..132b7b7fa81 100644
> > --- a/configs/socfpga_cyclone5_defconfig
> > +++ b/configs/socfpga_cyclone5_defconfig
> > @@ -8,7 +8,8 @@ CONFIG_TARGET_SOCFPGA_CYCLONE5_SOCDK=y
> > CONFIG_SPL_TEXT_BASE=0xFFFF0000
> > CONFIG_DISTRO_DEFAULTS=y
> > CONFIG_FIT=y
> > -# CONFIG_USE_BOOTCOMMAND is not set
> > +CONFIG_USE_BOOTCOMMAND=y
> > +CONFIG_BOOTCOMMAND="run fatscript; bridge enable; run
> distro_bootcmd"
>
> What is 'fatscript' ? Also, this breaks on systems where the FPGA isn't loaded,
> as it enables bridges to nowhere.
I missed out on adding the fatscript. I'll add in my next version.
For the bridge enabling, I'll add a checking to check if FPGA is in user mode before enabling the bridge.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-13 9:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06 9:08 [PATCH] configs: socfpga: add CONFIG_BOOTCOMMAND for cyclone5 Ooi, Joyce
2020-08-06 9:55 ` Marek Vasut
2020-08-13 9:28 ` Ooi, Joyce
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.