[LTP] Out-of-tree build missing some data files.

[LTP] Out-of-tree build missing some data files.

[Steve East]

When I do an out-of-tree build I am missing some of the files from the datafiles sub-directories. The ones that get installed in testcases/data are:

drwxr-xr-x 2 sge sdivmisc 1024 Mar 22 12:50 ext4-ffsb/
drwxr-xr-x 2 sge sdivmisc   80 Mar 22 12:48 file01/
drwxr-xr-x 2 sge sdivmisc 1024 Mar 22 12:50 ima_policy/
drwxr-xr-x 2 sge sdivmisc   80 Mar 22 12:48 ldd01/
drwxr-xr-x 2 sge sdivmisc 1024 Mar 22 12:49 mc_member/
drwxr-xr-x 2 sge sdivmisc 1024 Mar 22 12:48 nm01/
drwxr-xr-x 2 sge sdivmisc   80 Mar 22 12:49 rpc01/
drwxr-xr-x 3 sge sdivmisc   80 Mar 22 12:50 stress_floppy/
drwxr-xr-x 2 sge sdivmisc   80 Mar 22 12:48 unzip01/

but I don't see the datafiles for ld and ar. In the case of ld, the data files are *.c files which I believe are supposed to be installed uncompiled. For ar, the data files are *.in which also need to be installed as is.

This works for an in-tree build. Bug?

Thanks,
Steve.

[LTP] Out-of-tree build missing some data files.

[Cyril Hrubis]

Hi!
> drwxr-xr-x 2 sge sdivmisc 1024 Mar 22 12:50 ext4-ffsb/
> drwxr-xr-x 2 sge sdivmisc   80 Mar 22 12:48 file01/
> drwxr-xr-x 2 sge sdivmisc 1024 Mar 22 12:50 ima_policy/
> drwxr-xr-x 2 sge sdivmisc   80 Mar 22 12:48 ldd01/
> drwxr-xr-x 2 sge sdivmisc 1024 Mar 22 12:49 mc_member/
> drwxr-xr-x 2 sge sdivmisc 1024 Mar 22 12:48 nm01/
> drwxr-xr-x 2 sge sdivmisc   80 Mar 22 12:49 rpc01/
> drwxr-xr-x 3 sge sdivmisc   80 Mar 22 12:50 stress_floppy/
> drwxr-xr-x 2 sge sdivmisc   80 Mar 22 12:48 unzip01/
> 
> but I don't see the datafiles for ld and ar. In the case of ld, the data files are *.c files which I believe are supposed to be installed uncompiled. For ar, the data files are *.in which also need to be installed as is.
> 
> This works for an in-tree build. Bug?

Quite likely this is a problem with the $(wildcard *.c) and
$(wildcard *.in) expressions since these are missing $(abs_srcdir).

Does this work if you change these to $(wildcard $(abs_srcdir)/*.in) and
$(wildcard $(abs_srcdir)/*c) in the ld and ar datafiles/Makefile?

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] Out-of-tree build missing some data files.

[Steve East]

> -----Original Message-----
> From: Cyril Hrubis [mailto:chrubis@suse.cz]
> Sent: Tuesday, March 28, 2017 8:37 AM
> To: Steve East <sge@cray.com>
> Cc: ltp@lists.linux.it
> Subject: Re: [LTP] Out-of-tree build missing some data files.
> 
> Hi!
> > drwxr-xr-x 2 sge sdivmisc 1024 Mar 22 12:50 ext4-ffsb/
> > drwxr-xr-x 2 sge sdivmisc   80 Mar 22 12:48 file01/
> > drwxr-xr-x 2 sge sdivmisc 1024 Mar 22 12:50 ima_policy/
> > drwxr-xr-x 2 sge sdivmisc   80 Mar 22 12:48 ldd01/
> > drwxr-xr-x 2 sge sdivmisc 1024 Mar 22 12:49 mc_member/
> > drwxr-xr-x 2 sge sdivmisc 1024 Mar 22 12:48 nm01/
> > drwxr-xr-x 2 sge sdivmisc   80 Mar 22 12:49 rpc01/
> > drwxr-xr-x 3 sge sdivmisc   80 Mar 22 12:50 stress_floppy/
> > drwxr-xr-x 2 sge sdivmisc   80 Mar 22 12:48 unzip01/
> >
> > but I don't see the datafiles for ld and ar. In the case of ld, the data files are
> *.c files which I believe are supposed to be installed uncompiled. For ar, the
> data files are *.in which also need to be installed as is.
> >
> > This works for an in-tree build. Bug?
> 
> Quite likely this is a problem with the $(wildcard *.c) and
> $(wildcard *.in) expressions since these are missing $(abs_srcdir).
> 
> Does this work if you change these to $(wildcard $(abs_srcdir)/*.in) and
> $(wildcard $(abs_srcdir)/*c) in the ld and ar datafiles/Makefile?

Unfortunately, this doesn't seem to have had any effect. Changes were...

-INSTALL_TARGETS                := $(wildcard file*)
+INSTALL_TARGETS                := $(wildcard $(abs_srcdir)/*.in)

-INSTALL_TARGETS                := $(wildcard *.c)
+INSTALL_TARGETS                := $(wildcard $(abs_srcdir)/*.c)

Steve.



Steve.

[LTP] Out-of-tree build missing some data files.

[Cyril Hrubis]

Hi!
> Unfortunately, this doesn't seem to have had any effect. Changes were...
> 
> -INSTALL_TARGETS                := $(wildcard file*)
> +INSTALL_TARGETS                := $(wildcard $(abs_srcdir)/*.in)
> 
> -INSTALL_TARGETS                := $(wildcard *.c)
> +INSTALL_TARGETS                := $(wildcard $(abs_srcdir)/*.c)

Looking into the build system env_post.mk these are prefixed with
abs_srcdir automatically there so changing these to simply '*.c' or
'*.in' fixes the problem.

This patch fixes the installation for me:
(I will push it along with a few more out-of-tree build fixes)

diff --git a/testcases/commands/ar/datafiles/Makefile b/testcases/commands/ar/datafiles/Makefile
index 09dc029..ef99bca 100644
--- a/testcases/commands/ar/datafiles/Makefile
+++ b/testcases/commands/ar/datafiles/Makefile
@@ -15,5 +15,5 @@ top_srcdir		?= ../../../..
 
 include $(top_srcdir)/include/mk/env_pre.mk
 INSTALL_DIR		:= testcases/data/ar01
-INSTALL_TARGETS		:= $(wildcard file*)
+INSTALL_TARGETS		:= file*
 include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/commands/file/datafiles/Makefile b/testcases/commands/file/datafiles/Makefile
index 6769fc6..d3cb847 100644
--- a/testcases/commands/file/datafiles/Makefile
+++ b/testcases/commands/file/datafiles/Makefile
@@ -15,5 +15,5 @@ top_srcdir		?= ../../../..
 
 include $(top_srcdir)/include/mk/env_pre.mk
 INSTALL_DIR		:= testcases/data/file01
-INSTALL_TARGETS		:= $(wildcard in*)
+INSTALL_TARGETS		:= in*
 include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/commands/ld/datafiles/Makefile b/testcases/commands/ld/datafiles/Makefile
index 7b19207..4eb64ad 100644
--- a/testcases/commands/ld/datafiles/Makefile
+++ b/testcases/commands/ld/datafiles/Makefile
@@ -17,6 +17,6 @@ include $(top_srcdir)/include/mk/env_pre.mk
 
 INSTALL_DIR		:= testcases/data/ld01
 MAKE_TARGETS		:=
-INSTALL_TARGETS		:= $(wildcard *.c)
+INSTALL_TARGETS		:= *.c
 
 include $(top_srcdir)/include/mk/generic_leaf_target.mk

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] Out-of-tree build missing some data files.

[Steve East]

> -----Original Message-----
> From: Cyril Hrubis [mailto:chrubis@suse.cz]
> Sent: Wednesday, March 29, 2017 8:32 AM
> To: Steve East <sge@cray.com>
> Cc: ltp@lists.linux.it
> Subject: Re: [LTP] Out-of-tree build missing some data files.
> 
> Hi!
> > Unfortunately, this doesn't seem to have had any effect. Changes were...
> >
> > -INSTALL_TARGETS                := $(wildcard file*)
> > +INSTALL_TARGETS                := $(wildcard $(abs_srcdir)/*.in)
> >
> > -INSTALL_TARGETS                := $(wildcard *.c)
> > +INSTALL_TARGETS                := $(wildcard $(abs_srcdir)/*.c)
> 
> Looking into the build system env_post.mk these are prefixed with
> abs_srcdir automatically there so changing these to simply '*.c' or
> '*.in' fixes the problem.
> 
> This patch fixes the installation for me:

Pulled the latest version and it's building nicely.

Thanks,
Steve.

[LTP] Out-of-tree build missing some data files.

[Li Wang]

Hi,

I'm trying to build ltp out of tree but failed with errors like:

=========
make[2]: Leaving directory `/root/ltp-build/testcases/lib'
make[2]: Entering directory `/root/ltp-build/testcases/open_posix_testsuite'
/root/ltp/testcases/open_posix_testsuite/Makefile:38: Makefile.linux:
No such file or directory
make[2]: *** No rule to make target `Makefile.linux'.  Stop.
make[2]: Leaving directory `/root/ltp-build/testcases/open_posix_testsuite'
make[1]: *** [all] Error 2
=========

Two problems here:

1. The open_posix_testuite is also compiling in this time, but I
remember I didn't pass any parameter to config that.

2. It obviously could not build open_posix_testsuite out of tree
successfully, should we fix this for LTP?


my test script is:

$ cat build-ltp-out-of-tree.sh

#!/bin/bash

TOP=$PWD
TOP_SRCDIR=$TOP/ltp
SYSROOT=$TOP/ltp-install
TOP_BUILDDIR=$TOP/ltp-build
test -d "$TOP_BUILDDIR" || mkdir -p "$TOP_BUILDDIR"

if [ -f $TOP_SRCDIR/.git/config ]; then
    echo "LOG: ltp has been cloned in $TOP_SRCDIR"
    pushd $TOP_SRCDIR; git pull  > /dev/null 2>&1; make autotools; popd
else
    cd $TOP && git clone https://github.com/linux-test-project/ltp  --depth=1
    pushd $TOP_SRCDIR; make autotools; popd
fi

pushd "$TOP_BUILDDIR" && "$TOP_SRCDIR/configure"
OUT_OF_BUILD_TREE_DIR=$TOP_BUILDDIR
make \
    -C "$OUT_OF_BUILD_TREE_DIR" \
    -f "$TOP_SRCDIR/Makefile" \
    "top_srcdir=$TOP_SRCDIR" \
    "top_builddir=$OUT_OF_BUILD_TREE_DIR"

make \
    -C "$OUT_OF_BUILD_TREE_DIR" \
    -f "$TOP_SRCDIR/Makefile" \
    "top_srcdir=$TOP_SRCDIR" \
    "top_builddir=$OUT_OF_BUILD_TREE_DIR" \
    "DESTDIR=$SYSROOT" \
    SKIP_IDCHECK=1 install
popd



-- 
Regards,
Li Wang
Email: liwang@redhat.com

[LTP] Out-of-tree build missing some data files.

[Cyril Hrubis]

Hi!
> I'm trying to build ltp out of tree but failed with errors like:
> 
> =========
> make[2]: Leaving directory `/root/ltp-build/testcases/lib'
> make[2]: Entering directory `/root/ltp-build/testcases/open_posix_testsuite'
> /root/ltp/testcases/open_posix_testsuite/Makefile:38: Makefile.linux:
> No such file or directory
> make[2]: *** No rule to make target `Makefile.linux'.  Stop.
> make[2]: Leaving directory `/root/ltp-build/testcases/open_posix_testsuite'
> make[1]: *** [all] Error 2
> =========
> 
> Two problems here:
> 
> 1. The open_posix_testuite is also compiling in this time, but I
> remember I didn't pass any parameter to config that.

I noticed it as well, my guess is that this was broken by:

https://github.com/linux-test-project/ltp/issues/143

but I haven't had time to investigate yet.

> 2. It obviously could not build open_posix_testsuite out of tree
> successfully, should we fix this for LTP?

Looks like somebody is already working on that:

https://github.com/linux-test-project/ltp/pull/130

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] Out-of-tree build missing some data files.

[Petr Vorel]

Hi!
> > 1. The open_posix_testuite is also compiling in this time, but I
> > remember I didn't pass any parameter to config that.

> I noticed it as well, my guess is that this was broken by:
> https://github.com/linux-test-project/ltp/issues/143

I'm working on the fix of open_posix_testuite out-of-tree build. There are other issues
than gh#143.


Kind regards,
Petr