* [PATCH] x86/efi: Build our own page table structures
@ 2017-12-01 8:49 Ghannam, Yazen
2017-12-01 16:16 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Ghannam, Yazen @ 2017-12-01 8:49 UTC (permalink / raw)
To: stable
Upstream commit ID: 67a9108ed4313b85a9c53406d80dc1ae3f8c3e36
Prerequisite commit: "edc3b9129cec x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Prerequisite commit: "c9f2a9a65e48 x86/efi: Hoist page table switching code into efi_call_virt()"
Reason: Fixes the following call trace on AMD Fam17h systems.
[ +0.003800] ------------[ cut here ]------------
[ +0.003891] WARNING: CPU: 10 PID: 1 at /home/yghannam/linux-amd-yazen/arch/x86/mm/dump_pagetables.c:225 note_page+0x649/0x840()
[ +0.008552] x86/mm: Found insecure W+X mapping at address ffff88000003f000/0xffff88000003f000
[ +0.004743] Modules linked in:
[ +0.004946] CPU: 10 PID: 1 Comm: swapper/0 Not tainted 4.4.103-HEAD+ #3
...
[ +0.005573] 0000000000000286 cd31ced48608a4a4 ffff88085b92bd48 ffffffff813e0767
[ +0.005636] ffff88085b92bd90 ffffffff81c7b6f8 ffff88085b92bd80 ffffffff81080192
[ +0.005915] ffff88085b92be90 8000000000000163 0000000000000004 0000000000000000
[ +0.005895] Call Trace:
[ +0.006003] [<ffffffff813e0767>] dump_stack+0x63/0x8c
[ +0.006106] [<ffffffff81080192>] warn_slowpath_common+0x82/0xc0
[ +0.006308] [<ffffffff8108022c>] warn_slowpath_fmt+0x5c/0x80
[ +0.006220] [<ffffffff81071b99>] note_page+0x649/0x840
[ +0.006416] [<ffffffff81072089>] ptdump_walk_pgd_level_core+0x2f9/0x430
[ +0.006633] [<ffffffff810721f7>] ptdump_walk_pgd_level_checkwx+0x17/0x20
[ +0.006320] [<ffffffff81067d5c>] mark_rodata_ro+0xec/0x100
[ +0.006309] [<ffffffff817ecc90>] ? rest_init+0x80/0x80
[ +0.006160] [<ffffffff817eccad>] kernel_init+0x1d/0xe0
[ +0.005998] [<ffffffff817f984f>] ret_from_fork+0x3f/0x70
[ +0.005753] [<ffffffff817ecc90>] ? rest_init+0x80/0x80
[ +0.006187] ---[ end trace 6343b8dea3291aa5 ]---
[ +0.016398] x86/mm: Checked W+X mappings: FAILED, 21956 W+X pages found.
Stable version to apply to: 4.4.x
Thanks,
Yazen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/efi: Build our own page table structures
2017-12-01 8:49 [PATCH] x86/efi: Build our own page table structures Ghannam, Yazen
@ 2017-12-01 16:16 ` Greg KH
2017-12-01 16:27 ` Ghannam, Yazen
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2017-12-01 16:16 UTC (permalink / raw)
To: Ghannam, Yazen; +Cc: stable
On Fri, Dec 01, 2017 at 08:49:23AM +0000, Ghannam, Yazen wrote:
> Upstream commit ID: 67a9108ed4313b85a9c53406d80dc1ae3f8c3e36
> Prerequisite commit: "edc3b9129cec x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
> Prerequisite commit: "c9f2a9a65e48 x86/efi: Hoist page table switching code into efi_call_virt()"
Again, you want all 3 of these patches applied to 4.4-stable? In what
order?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] x86/efi: Build our own page table structures
2017-12-01 16:16 ` Greg KH
@ 2017-12-01 16:27 ` Ghannam, Yazen
2017-12-01 17:02 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Ghannam, Yazen @ 2017-12-01 16:27 UTC (permalink / raw)
To: Greg KH; +Cc: stable
> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Friday, December 1, 2017 11:16 AM
> To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> Cc: stable@vger.kernel.org
> Subject: Re: [PATCH] x86/efi: Build our own page table structures
>
> On Fri, Dec 01, 2017 at 08:49:23AM +0000, Ghannam, Yazen wrote:
> > Upstream commit ID: 67a9108ed4313b85a9c53406d80dc1ae3f8c3e36
> > Prerequisite commit: "edc3b9129cec x86/mm/pat: Ensure cpa->pfn only
> contains page frame numbers"
> > Prerequisite commit: "c9f2a9a65e48 x86/efi: Hoist page table switching
> code into efi_call_virt()"
>
> Again, you want all 3 of these patches applied to 4.4-stable? In what
> order?
>
Yes please, in this order.
1) edc3b9129cecd0f0857112136f5b8b1bc1d45918
2) c9f2a9a65e4855b74d92cdad688f6ee4a1a323ff
3) 67a9108ed4313b85a9c53406d80dc1ae3f8c3e36
Thanks,
Yazen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/efi: Build our own page table structures
2017-12-01 16:27 ` Ghannam, Yazen
@ 2017-12-01 17:02 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2017-12-01 17:02 UTC (permalink / raw)
To: Ghannam, Yazen; +Cc: stable
On Fri, Dec 01, 2017 at 04:27:09PM +0000, Ghannam, Yazen wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Friday, December 1, 2017 11:16 AM
> > To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> > Cc: stable@vger.kernel.org
> > Subject: Re: [PATCH] x86/efi: Build our own page table structures
> >
> > On Fri, Dec 01, 2017 at 08:49:23AM +0000, Ghannam, Yazen wrote:
> > > Upstream commit ID: 67a9108ed4313b85a9c53406d80dc1ae3f8c3e36
> > > Prerequisite commit: "edc3b9129cec x86/mm/pat: Ensure cpa->pfn only
> > contains page frame numbers"
> > > Prerequisite commit: "c9f2a9a65e48 x86/efi: Hoist page table switching
> > code into efi_call_virt()"
> >
> > Again, you want all 3 of these patches applied to 4.4-stable? In what
> > order?
> >
>
> Yes please, in this order.
>
> 1) edc3b9129cecd0f0857112136f5b8b1bc1d45918
> 2) c9f2a9a65e4855b74d92cdad688f6ee4a1a323ff
> 3) 67a9108ed4313b85a9c53406d80dc1ae3f8c3e36
Now all applied.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-01 17:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-01 8:49 [PATCH] x86/efi: Build our own page table structures Ghannam, Yazen
2017-12-01 16:16 ` Greg KH
2017-12-01 16:27 ` Ghannam, Yazen
2017-12-01 17:02 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.