[PATCH] drm/amdgpu: fix errors in comments.

[PATCH] drm/amdgpu: fix errors in comments.

[Alex Xie]

Signed-off-by: Alex Xie <AlexBin.Xie@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 66bb60e..aab3206 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -479,9 +479,8 @@ void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev,
 
 /*
  * amdgpu_wb_*()
- * Writeback is the the method by which the the GPU updates special pages
- * in memory with the status of certain GPU events (fences, ring pointers,
- * etc.).
+ * Writeback is the method by which GPU updates special pages in memory
+ * with the status of certain GPU events (fences, ring pointers,etc.).
  */
 
 /**
@@ -507,7 +506,7 @@ static void amdgpu_wb_fini(struct amdgpu_device *adev)
  *
  * @adev: amdgpu_device pointer
  *
- * Disables Writeback and frees the Writeback memory (all asics).
+ * Initialize writeback and allocates writeback memory (all asics).
  * Used at driver startup.
  * Returns 0 on success or an -error on failure.
  */
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: fix errors in comments.

[Deucher, Alexander]

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Alex Xie
> Sent: Monday, May 08, 2017 11:32 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Xie, AlexBin
> Subject: [PATCH] drm/amdgpu: fix errors in comments.
> 
> Signed-off-by: Alex Xie <AlexBin.Xie@amd.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 66bb60e..aab3206 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -479,9 +479,8 @@ void amdgpu_doorbell_get_kfd_info(struct
> amdgpu_device *adev,
> 
>  /*
>   * amdgpu_wb_*()
> - * Writeback is the the method by which the the GPU updates special pages
> - * in memory with the status of certain GPU events (fences, ring pointers,
> - * etc.).
> + * Writeback is the method by which GPU updates special pages in memory
> + * with the status of certain GPU events (fences, ring pointers,etc.).
>   */
> 
>  /**
> @@ -507,7 +506,7 @@ static void amdgpu_wb_fini(struct amdgpu_device
> *adev)
>   *
>   * @adev: amdgpu_device pointer
>   *
> - * Disables Writeback and frees the Writeback memory (all asics).
> + * Initialize writeback and allocates writeback memory (all asics).
>   * Used at driver startup.
>   * Returns 0 on success or an -error on failure.
>   */
> --
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: fix errors in comments.

[William Lewis]

On 05/08/2017 10:32 AM, Alex Xie wrote:
> Signed-off-by: Alex Xie <AlexBin.Xie@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 66bb60e..aab3206 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -479,9 +479,8 @@ void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev,
>   
>   /*
>    * amdgpu_wb_*()
> - * Writeback is the the method by which the the GPU updates special pages
> - * in memory with the status of certain GPU events (fences, ring pointers,
> - * etc.).
> + * Writeback is the method by which GPU updates special pages in memory
You took out three instances of "the" instead of just two.
* Writeback is the method by which the GPU updates special pages in memory.
> + * with the status of certain GPU events (fences, ring pointers,etc.).
And you took out a space that made it slightly more legible here.
* with the status of certain GPU events (fences, ring pointers, etc.).
>    */
>   
>   /**
> @@ -507,7 +506,7 @@ static void amdgpu_wb_fini(struct amdgpu_device *adev)
>    *
>    * @adev: amdgpu_device pointer
>    *
> - * Disables Writeback and frees the Writeback memory (all asics).
> + * Initialize writeback and allocates writeback memory (all asics).
Inconsistent.
* Initializes writeback and allocates writeback memory (all asics).
>    * Used at driver startup.
>    * Returns 0 on success or an -error on failure.
>    */

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: fix errors in comments.

[Michel Dänzer]

On 09/05/17 12:32 AM, Alex Xie wrote:
> Signed-off-by: Alex Xie <AlexBin.Xie@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 66bb60e..aab3206 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -479,9 +479,8 @@ void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev,
>  
>  /*
>   * amdgpu_wb_*()
> - * Writeback is the the method by which the the GPU updates special pages
> - * in memory with the status of certain GPU events (fences, ring pointers,
> - * etc.).
> + * Writeback is the method by which GPU updates special pages in memory

This should still say "the GPU".


> + * with the status of certain GPU events (fences, ring pointers,etc.).
>   */
>  
>  /**
> @@ -507,7 +506,7 @@ static void amdgpu_wb_fini(struct amdgpu_device *adev)
>   *
>   * @adev: amdgpu_device pointer
>   *
> - * Disables Writeback and frees the Writeback memory (all asics).
> + * Initialize writeback and allocates writeback memory (all asics).

For consistency, this should say either "Initialize writeback and
allocate writeback memory" or "Initializes writeback and allocates
writeback memory".


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: fix errors in comments.

[Xie, AlexBin]

[-- Attachment #1.1: Type: text/plain, Size: 2039 bytes --]

Hi Michel,


The code change has been submitted into our internal git server.

I have a follow up commit in another email thread.

The commit fixes more errors in comments.


Thanks,

Alex Bin

________________________________
From: Michel Dänzer <michel-otUistvHUpPR7s880joybQ@public.gmane.org>
Sent: Monday, May 8, 2017 9:13 PM
To: Xie, AlexBin
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: fix errors in comments.

On 09/05/17 12:32 AM, Alex Xie wrote:
> Signed-off-by: Alex Xie <AlexBin.Xie-5C7GfCeVMHo@public.gmane.org>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 66bb60e..aab3206 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -479,9 +479,8 @@ void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev,
>
>  /*
>   * amdgpu_wb_*()
> - * Writeback is the the method by which the the GPU updates special pages
> - * in memory with the status of certain GPU events (fences, ring pointers,
> - * etc.).
> + * Writeback is the method by which GPU updates special pages in memory

This should still say "the GPU".


> + * with the status of certain GPU events (fences, ring pointers,etc.).
>   */
>
>  /**
> @@ -507,7 +506,7 @@ static void amdgpu_wb_fini(struct amdgpu_device *adev)
>   *
>   * @adev: amdgpu_device pointer
>   *
> - * Disables Writeback and frees the Writeback memory (all asics).
> + * Initialize writeback and allocates writeback memory (all asics).

For consistency, this should say either "Initialize writeback and
allocate writeback memory" or "Initializes writeback and allocates
writeback memory".


--
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

[-- Attachment #1.2: Type: text/html, Size: 3611 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx