* [PATCH umr] Fix copy/paste error in error message
@ 2017-06-22 13:38 Tom St Denis
[not found] ` <20170622133819.3169-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Tom St Denis @ 2017-06-22 13:38 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Tom St Denis
Also fix a couple of error message style deviations.
Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
---
src/lib/mmio.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/lib/mmio.c b/src/lib/mmio.c
index f0737c43913a..987704cb9944 100644
--- a/src/lib/mmio.c
+++ b/src/lib/mmio.c
@@ -39,7 +39,7 @@ static uint32_t umr_smc_read(struct umr_asic *asic, uint64_t addr)
umr_write_reg_by_name(asic, "mmMP0PUB_IND_INDEX_1", addr);
return umr_read_reg_by_name(asic, "mmMP0PUB_IND_DATA_1");
default:
- fprintf(stderr, "[BUG] Unsupported family type in umr_smc_read()\n");
+ fprintf(stderr, "[BUG]: Unsupported family type in umr_smc_read()\n");
return 0;
}
} else {
@@ -66,7 +66,7 @@ static uint32_t umr_smc_write(struct umr_asic *asic, uint64_t addr, uint32_t val
umr_write_reg_by_name(asic, "mmMP0PUB_IND_INDEX_1", addr);
return umr_write_reg_by_name(asic, "mmMP0PUB_IND_DATA_1", value);
default:
- fprintf(stderr, "[BUG] Unsupported family type in umr_smc_read()\n");
+ fprintf(stderr, "[BUG]: Unsupported family type in umr_smc_write()\n");
return -1;
}
} else {
@@ -103,7 +103,7 @@ uint32_t umr_read_reg(struct umr_asic *asic, uint64_t addr, enum regclass type)
case REG_SMC:
return umr_smc_read(asic, addr);
default:
- fprintf(stderr, "[BUG] Unsupported register type in umr_read_reg().\n");
+ fprintf(stderr, "[BUG]: Unsupported register type in umr_read_reg().\n");
return 0;
}
}
@@ -131,7 +131,7 @@ int umr_write_reg(struct umr_asic *asic, uint64_t addr, uint32_t value, enum reg
case REG_SMC:
return umr_smc_write(asic, addr, value);
default:
- fprintf(stderr, "[BUG] Unsupported register type in umr_write_reg().\n");
+ fprintf(stderr, "[BUG]: Unsupported register type in umr_write_reg().\n");
return -1;
}
return 0;
--
2.12.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH umr] Fix copy/paste error in error message
[not found] ` <20170622133819.3169-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
@ 2017-06-22 14:07 ` Deucher, Alexander
0 siblings, 0 replies; 2+ messages in thread
From: Deucher, Alexander @ 2017-06-22 14:07 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: StDenis, Tom
> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Tom St Denis
> Sent: Thursday, June 22, 2017 9:38 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: StDenis, Tom
> Subject: [PATCH umr] Fix copy/paste error in error message
>
> Also fix a couple of error message style deviations.
>
> Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> src/lib/mmio.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/lib/mmio.c b/src/lib/mmio.c
> index f0737c43913a..987704cb9944 100644
> --- a/src/lib/mmio.c
> +++ b/src/lib/mmio.c
> @@ -39,7 +39,7 @@ static uint32_t umr_smc_read(struct umr_asic *asic,
> uint64_t addr)
> umr_write_reg_by_name(asic,
> "mmMP0PUB_IND_INDEX_1", addr);
> return umr_read_reg_by_name(asic,
> "mmMP0PUB_IND_DATA_1");
> default:
> - fprintf(stderr, "[BUG] Unsupported family
> type in umr_smc_read()\n");
> + fprintf(stderr, "[BUG]: Unsupported family
> type in umr_smc_read()\n");
> return 0;
> }
> } else {
> @@ -66,7 +66,7 @@ static uint32_t umr_smc_write(struct umr_asic *asic,
> uint64_t addr, uint32_t val
> umr_write_reg_by_name(asic,
> "mmMP0PUB_IND_INDEX_1", addr);
> return umr_write_reg_by_name(asic,
> "mmMP0PUB_IND_DATA_1", value);
> default:
> - fprintf(stderr, "[BUG] Unsupported family
> type in umr_smc_read()\n");
> + fprintf(stderr, "[BUG]: Unsupported family
> type in umr_smc_write()\n");
> return -1;
> }
> } else {
> @@ -103,7 +103,7 @@ uint32_t umr_read_reg(struct umr_asic *asic,
> uint64_t addr, enum regclass type)
> case REG_SMC:
> return umr_smc_read(asic, addr);
> default:
> - fprintf(stderr, "[BUG] Unsupported register type in
> umr_read_reg().\n");
> + fprintf(stderr, "[BUG]: Unsupported register type in
> umr_read_reg().\n");
> return 0;
> }
> }
> @@ -131,7 +131,7 @@ int umr_write_reg(struct umr_asic *asic, uint64_t
> addr, uint32_t value, enum reg
> case REG_SMC:
> return umr_smc_write(asic, addr, value);
> default:
> - fprintf(stderr, "[BUG] Unsupported register type in
> umr_write_reg().\n");
> + fprintf(stderr, "[BUG]: Unsupported register type in
> umr_write_reg().\n");
> return -1;
> }
> return 0;
> --
> 2.12.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-22 14:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-22 13:38 [PATCH umr] Fix copy/paste error in error message Tom St Denis
[not found] ` <20170622133819.3169-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
2017-06-22 14:07 ` Deucher, Alexander
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.