* [PATCH] drm/amdgpu: Don't save new cursor size before updating CUR_SIZE register.
@ 2016-12-16 19:11 Liviu Dudau
[not found] ` <20161216191118.2338-1-liviu-I3yL/QOVVjH10XsdtD+oqA@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Liviu Dudau @ 2016-12-16 19:11 UTC (permalink / raw)
To: Michel Dänzer, Alex Deucher
Cc: David Airlie, Liviu Dudau,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Christian König,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Commit 7c83d7abc999 ("drm/amdgpu: Only update the CUR_SIZE register when
necessary") did not cleanup correctly the old code for DCE v6 and v8.
As a consequence, cursor updates stopped working for my Radeon R9 1002:67b0
dual-monitor setup.
Fixes: 7c83d7abc999 ("drm/amdgpu: Only update the CUR_SIZE register when necessary")
Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
---
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 6 +-----
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 --
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
index e564442..b4e4ec6 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
@@ -1944,9 +1944,7 @@ static int dce_v6_0_crtc_cursor_set2(struct drm_crtc *crtc,
dce_v6_0_lock_cursor(crtc, true);
- if (width != amdgpu_crtc->cursor_width ||
- height != amdgpu_crtc->cursor_height ||
- hot_x != amdgpu_crtc->cursor_hot_x ||
+ if (hot_x != amdgpu_crtc->cursor_hot_x ||
hot_y != amdgpu_crtc->cursor_hot_y) {
int x, y;
@@ -1955,8 +1953,6 @@ static int dce_v6_0_crtc_cursor_set2(struct drm_crtc *crtc,
dce_v6_0_cursor_move_locked(crtc, x, y);
- amdgpu_crtc->cursor_width = width;
- amdgpu_crtc->cursor_height = height;
amdgpu_crtc->cursor_hot_x = hot_x;
amdgpu_crtc->cursor_hot_y = hot_y;
}
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
index 6ce7fb4..584abe8 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
@@ -2438,8 +2438,6 @@ static int dce_v8_0_crtc_cursor_set2(struct drm_crtc *crtc,
dce_v8_0_cursor_move_locked(crtc, x, y);
- amdgpu_crtc->cursor_width = width;
- amdgpu_crtc->cursor_height = height;
amdgpu_crtc->cursor_hot_x = hot_x;
amdgpu_crtc->cursor_hot_y = hot_y;
}
--
2.10.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amdgpu: Don't save new cursor size before updating CUR_SIZE register.
[not found] ` <20161216191118.2338-1-liviu-I3yL/QOVVjH10XsdtD+oqA@public.gmane.org>
@ 2016-12-16 19:16 ` Deucher, Alexander
[not found] ` <BN6PR12MB1652933B16CC5F67B00A60DDF79C0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Deucher, Alexander @ 2016-12-16 19:16 UTC (permalink / raw)
To: 'Liviu Dudau', Daenzer, Michel
Cc: David Airlie, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Koenig,
Christian, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
> -----Original Message-----
> From: Liviu Dudau [mailto:liviu@dudau.co.uk]
> Sent: Friday, December 16, 2016 2:11 PM
> To: Daenzer, Michel; Deucher, Alexander
> Cc: Koenig, Christian; David Airlie; dri-devel@lists.freedesktop.org; amd-
> gfx@lists.freedesktop.org; Liviu Dudau
> Subject: [PATCH] drm/amdgpu: Don't save new cursor size before updating
> CUR_SIZE register.
>
> Commit 7c83d7abc999 ("drm/amdgpu: Only update the CUR_SIZE register
> when
> necessary") did not cleanup correctly the old code for DCE v6 and v8.
> As a consequence, cursor updates stopped working for my Radeon R9
> 1002:67b0
> dual-monitor setup.
>
> Fixes: 7c83d7abc999 ("drm/amdgpu: Only update the CUR_SIZE register
> when necessary")
> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
Already fixed:
https://lists.freedesktop.org/archives/amd-gfx/2016-December/003985.html
and queued for fixes:
https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.10-wip&id=837b2d51a5847584fe64aebbc94ef8b7ae59fd87
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 6 +-----
> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 --
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> index e564442..b4e4ec6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> @@ -1944,9 +1944,7 @@ static int dce_v6_0_crtc_cursor_set2(struct
> drm_crtc *crtc,
>
> dce_v6_0_lock_cursor(crtc, true);
>
> - if (width != amdgpu_crtc->cursor_width ||
> - height != amdgpu_crtc->cursor_height ||
> - hot_x != amdgpu_crtc->cursor_hot_x ||
> + if (hot_x != amdgpu_crtc->cursor_hot_x ||
> hot_y != amdgpu_crtc->cursor_hot_y) {
> int x, y;
>
> @@ -1955,8 +1953,6 @@ static int dce_v6_0_crtc_cursor_set2(struct
> drm_crtc *crtc,
>
> dce_v6_0_cursor_move_locked(crtc, x, y);
>
> - amdgpu_crtc->cursor_width = width;
> - amdgpu_crtc->cursor_height = height;
> amdgpu_crtc->cursor_hot_x = hot_x;
> amdgpu_crtc->cursor_hot_y = hot_y;
> }
> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
> b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
> index 6ce7fb4..584abe8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
> @@ -2438,8 +2438,6 @@ static int dce_v8_0_crtc_cursor_set2(struct
> drm_crtc *crtc,
>
> dce_v8_0_cursor_move_locked(crtc, x, y);
>
> - amdgpu_crtc->cursor_width = width;
> - amdgpu_crtc->cursor_height = height;
> amdgpu_crtc->cursor_hot_x = hot_x;
> amdgpu_crtc->cursor_hot_y = hot_y;
> }
> --
> 2.10.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: Don't save new cursor size before updating CUR_SIZE register.
[not found] ` <BN6PR12MB1652933B16CC5F67B00A60DDF79C0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
@ 2016-12-17 16:35 ` 'Liviu Dudau'
[not found] ` <20161217163508.GA1013-hOhETlTuV5niMG9XS5x8Mg@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: 'Liviu Dudau' @ 2016-12-17 16:35 UTC (permalink / raw)
To: Deucher, Alexander
Cc: David Airlie, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Daenzer,
Michel, Koenig, Christian,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Fri, Dec 16, 2016 at 07:16:25PM +0000, Deucher, Alexander wrote:
> > -----Original Message-----
> > From: Liviu Dudau [mailto:liviu@dudau.co.uk]
> > Sent: Friday, December 16, 2016 2:11 PM
> > To: Daenzer, Michel; Deucher, Alexander
> > Cc: Koenig, Christian; David Airlie; dri-devel@lists.freedesktop.org; amd-
> > gfx@lists.freedesktop.org; Liviu Dudau
> > Subject: [PATCH] drm/amdgpu: Don't save new cursor size before updating
> > CUR_SIZE register.
> >
> > Commit 7c83d7abc999 ("drm/amdgpu: Only update the CUR_SIZE register
> > when
> > necessary") did not cleanup correctly the old code for DCE v6 and v8.
> > As a consequence, cursor updates stopped working for my Radeon R9
> > 1002:67b0
> > dual-monitor setup.
> >
> > Fixes: 7c83d7abc999 ("drm/amdgpu: Only update the CUR_SIZE register
> > when necessary")
> > Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
>
> Already fixed:
> https://lists.freedesktop.org/archives/amd-gfx/2016-December/003985.html
Sorry, I've only checked the dri-devel list, I've only noticed there is an
amd-gfx one while preparing the patch for sending.
> and queued for fixes:
> https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.10-wip&id=837b2d51a5847584fe64aebbc94ef8b7ae59fd87
Cool, thanks!
Best regards,
Liviu
>
> Alex
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 6 +-----
> > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 --
> > 2 files changed, 1 insertion(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> > b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> > index e564442..b4e4ec6 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> > @@ -1944,9 +1944,7 @@ static int dce_v6_0_crtc_cursor_set2(struct
> > drm_crtc *crtc,
> >
> > dce_v6_0_lock_cursor(crtc, true);
> >
> > - if (width != amdgpu_crtc->cursor_width ||
> > - height != amdgpu_crtc->cursor_height ||
> > - hot_x != amdgpu_crtc->cursor_hot_x ||
> > + if (hot_x != amdgpu_crtc->cursor_hot_x ||
> > hot_y != amdgpu_crtc->cursor_hot_y) {
> > int x, y;
> >
> > @@ -1955,8 +1953,6 @@ static int dce_v6_0_crtc_cursor_set2(struct
> > drm_crtc *crtc,
> >
> > dce_v6_0_cursor_move_locked(crtc, x, y);
> >
> > - amdgpu_crtc->cursor_width = width;
> > - amdgpu_crtc->cursor_height = height;
> > amdgpu_crtc->cursor_hot_x = hot_x;
> > amdgpu_crtc->cursor_hot_y = hot_y;
> > }
> > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
> > b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
> > index 6ce7fb4..584abe8 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
> > @@ -2438,8 +2438,6 @@ static int dce_v8_0_crtc_cursor_set2(struct
> > drm_crtc *crtc,
> >
> > dce_v8_0_cursor_move_locked(crtc, x, y);
> >
> > - amdgpu_crtc->cursor_width = width;
> > - amdgpu_crtc->cursor_height = height;
> > amdgpu_crtc->cursor_hot_x = hot_x;
> > amdgpu_crtc->cursor_hot_y = hot_y;
> > }
> > --
> > 2.10.2
>
--
-------------------
.oooO
( )
\ ( Oooo.
\_) ( )
) /
(_/
One small step
for me ...
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: Don't save new cursor size before updating CUR_SIZE register.
[not found] ` <20161217163508.GA1013-hOhETlTuV5niMG9XS5x8Mg@public.gmane.org>
@ 2016-12-18 13:46 ` Daniel Vetter
[not found] ` <20161218134600.267bktteitg4bsge-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2016-12-18 13:46 UTC (permalink / raw)
To: 'Liviu Dudau'
Cc: Deucher, Alexander, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
Daenzer, Michel, Koenig, Christian,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Sat, Dec 17, 2016 at 04:35:09PM +0000, 'Liviu Dudau' wrote:
> On Fri, Dec 16, 2016 at 07:16:25PM +0000, Deucher, Alexander wrote:
> > > -----Original Message-----
> > > From: Liviu Dudau [mailto:liviu@dudau.co.uk]
> > > Sent: Friday, December 16, 2016 2:11 PM
> > > To: Daenzer, Michel; Deucher, Alexander
> > > Cc: Koenig, Christian; David Airlie; dri-devel@lists.freedesktop.org; amd-
> > > gfx@lists.freedesktop.org; Liviu Dudau
> > > Subject: [PATCH] drm/amdgpu: Don't save new cursor size before updating
> > > CUR_SIZE register.
> > >
> > > Commit 7c83d7abc999 ("drm/amdgpu: Only update the CUR_SIZE register
> > > when
> > > necessary") did not cleanup correctly the old code for DCE v6 and v8.
> > > As a consequence, cursor updates stopped working for my Radeon R9
> > > 1002:67b0
> > > dual-monitor setup.
> > >
> > > Fixes: 7c83d7abc999 ("drm/amdgpu: Only update the CUR_SIZE register
> > > when necessary")
> > > Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
> >
> > Already fixed:
> > https://lists.freedesktop.org/archives/amd-gfx/2016-December/003985.html
>
> Sorry, I've only checked the dri-devel list, I've only noticed there is an
> amd-gfx one while preparing the patch for sending.
Hm yeah, MAINTAINERS is not updated to include the new list. Alex, can you
pls fix that?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: Don't save new cursor size before updating CUR_SIZE register.
[not found] ` <20161218134600.267bktteitg4bsge-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
@ 2016-12-19 18:31 ` Alex Deucher
0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2016-12-19 18:31 UTC (permalink / raw)
To: Daniel Vetter
Cc: Liviu Dudau, Daenzer, Michel,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Deucher, Alexander,
Koenig, Christian
On Sun, Dec 18, 2016 at 8:46 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Sat, Dec 17, 2016 at 04:35:09PM +0000, 'Liviu Dudau' wrote:
>> On Fri, Dec 16, 2016 at 07:16:25PM +0000, Deucher, Alexander wrote:
>> > > -----Original Message-----
>> > > From: Liviu Dudau [mailto:liviu@dudau.co.uk]
>> > > Sent: Friday, December 16, 2016 2:11 PM
>> > > To: Daenzer, Michel; Deucher, Alexander
>> > > Cc: Koenig, Christian; David Airlie; dri-devel@lists.freedesktop.org; amd-
>> > > gfx@lists.freedesktop.org; Liviu Dudau
>> > > Subject: [PATCH] drm/amdgpu: Don't save new cursor size before updating
>> > > CUR_SIZE register.
>> > >
>> > > Commit 7c83d7abc999 ("drm/amdgpu: Only update the CUR_SIZE register
>> > > when
>> > > necessary") did not cleanup correctly the old code for DCE v6 and v8.
>> > > As a consequence, cursor updates stopped working for my Radeon R9
>> > > 1002:67b0
>> > > dual-monitor setup.
>> > >
>> > > Fixes: 7c83d7abc999 ("drm/amdgpu: Only update the CUR_SIZE register
>> > > when necessary")
>> > > Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
>> >
>> > Already fixed:
>> > https://lists.freedesktop.org/archives/amd-gfx/2016-December/003985.html
>>
>> Sorry, I've only checked the dri-devel list, I've only noticed there is an
>> amd-gfx one while preparing the patch for sending.
>
> Hm yeah, MAINTAINERS is not updated to include the new list. Alex, can you
> pls fix that?
Patch on the way.
Alex
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-19 18:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-16 19:11 [PATCH] drm/amdgpu: Don't save new cursor size before updating CUR_SIZE register Liviu Dudau
[not found] ` <20161216191118.2338-1-liviu-I3yL/QOVVjH10XsdtD+oqA@public.gmane.org>
2016-12-16 19:16 ` Deucher, Alexander
[not found] ` <BN6PR12MB1652933B16CC5F67B00A60DDF79C0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-12-17 16:35 ` 'Liviu Dudau'
[not found] ` <20161217163508.GA1013-hOhETlTuV5niMG9XS5x8Mg@public.gmane.org>
2016-12-18 13:46 ` Daniel Vetter
[not found] ` <20161218134600.267bktteitg4bsge-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2016-12-19 18:31 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.