RE: [PATCH xf86-video-ati] Set correct DRM event context version

["Deucher, Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>]

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Michel Dänzer
> Sent: Monday, April 10, 2017 4:38 AM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH xf86-video-ati] Set correct DRM event context version
> 
> From: Daniel Stone <daniels@collabora.com>
> 
> DRM_EVENT_CONTEXT_VERSION is the latest context version supported by
> whatever version of libdrm is present. We were blindly asserting we
> supported whatever version that may be, even if we actually didn't.
> 
> With libdrm 2.4.78, setting a higher context version than 2 will attempt
> to call the page_flip_handler2 vfunc if it was non-NULL, which being a
> random chunk of stack memory, it might well have been.
> 
> Set the version as 2, which should be bumped only with the appropriate
> version checks.
> 
> Signed-off-by: Daniel Stone <daniels@collabora.com>
> (Ported from xserver commit
> 0c8e6ed85810e96d84173a52d628863802a78d82)
> 
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  src/drmmode_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/drmmode_display.c b/src/drmmode_display.c
> index ab11583a6..9911c0a6a 100644
> --- a/src/drmmode_display.c
> +++ b/src/drmmode_display.c
> @@ -2538,7 +2538,7 @@ Bool drmmode_pre_init(ScrnInfoPtr pScrn,
> drmmode_ptr drmmode, int cpp)
> 
>  	xf86InitialConfiguration(pScrn, TRUE);
> 
> -	drmmode->event_context.version =
> DRM_EVENT_CONTEXT_VERSION;
> +	drmmode->event_context.version = 2;
>  	drmmode->event_context.vblank_handler =
> radeon_drm_queue_handler;
>  	drmmode->event_context.page_flip_handler =
> radeon_drm_queue_handler;
> 
> --
> 2.11.0
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx