All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>
To: Emil Velikov <emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Daniel Stone <daniels-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
	amd-gfx mailing list
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH xf86-video-ati] Set correct DRM event context version
Date: Tue, 11 Apr 2017 14:58:31 +0900	[thread overview]
Message-ID: <c5212a12-8908-38ef-5e29-bdce48116817@daenzer.net> (raw)
In-Reply-To: <CACvgo503KR+UdfiXQBuy7753tDhOSaF4yXP5vUvbFsw5L1ma-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 10/04/17 06:42 PM, Emil Velikov wrote:
> On 10 April 2017 at 09:37, Michel Dänzer <michel@daenzer.net> wrote:
>> From: Daniel Stone <daniels@collabora.com>
>>
>> DRM_EVENT_CONTEXT_VERSION is the latest context version supported by
>> whatever version of libdrm is present. We were blindly asserting we
>> supported whatever version that may be, even if we actually didn't.
>>
>> With libdrm 2.4.78, setting a higher context version than 2 will attempt
>> to call the page_flip_handler2 vfunc if it was non-NULL, which being a
>> random chunk of stack memory, it might well have been.
>>
> Should be safe since we use xnfcalloc [in RADEONGetRec].

That's a good point, thanks (applies equally to the modesetting driver
AFAICT); I'll drop the second paragraph from the commit log.


> Regardless, the amdgpu and ati patches are
> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

Thanks!


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2017-04-11  5:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-10  8:37 [PATCH xf86-video-amdgpu] Set correct DRM event context version Michel Dänzer
     [not found] ` <20170410083751.19692-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-04-10  8:37   ` [PATCH xf86-video-ati] " Michel Dänzer
     [not found]     ` <20170410083751.19692-2-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-04-10  9:42       ` Emil Velikov
     [not found]         ` <CACvgo503KR+UdfiXQBuy7753tDhOSaF4yXP5vUvbFsw5L1ma-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-11  5:58           ` Michel Dänzer [this message]
2017-04-10 14:51       ` Deucher, Alexander
2017-04-10 14:51   ` [PATCH xf86-video-amdgpu] " Deucher, Alexander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5212a12-8908-38ef-5e29-bdce48116817@daenzer.net \
    --to=michel-otuistvhuppr7s880joybq@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=daniels-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
    --cc=emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.