[virtio-comment] [PATCH] virtio-net: Fix VIRTIO_NET_F_GUEST_HDRLEN feature definition.

* [virtio-comment] [PATCH] virtio-net: Fix VIRTIO_NET_F_GUEST_HDRLEN feature definition.
@ 2020-02-24  8:15 Vitaly Mireyno
  2020-03-03 15:13 ` [virtio-comment] " Vitaly Mireyno
  0 siblings, 1 reply; 2+ messages in thread
From: Vitaly Mireyno @ 2020-02-24  8:15 UTC (permalink / raw)
  To: virtio-comment; +Cc: Michael S. Tsirkin, Jason Wang

Fix driver and device requirements with regards to the VIRTIO_NET_F_GUEST_HDRLEN feature - 'hdr_len' must be accurate only for TSO/UFO packets.


Signed-off-by: Vitaly Mireyno <vmireyno@marvell.com>
---
 content.tex | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/content.tex b/content.tex
index b91a132..2f71f8f 100644
--- a/content.tex
+++ b/content.tex
@@ -3354,10 +3354,12 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
 been negotiated:
 \begin{itemize}
 \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated,
+	and \field{gso_type} differs from VIRTIO_NET_HDR_GSO_NONE,
 	the driver MUST set \field{hdr_len} to a value equal to the length
 	of the headers, including the transport header.
 
 \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated,
+	or \field{gso_type} is VIRTIO_NET_HDR_GSO_NONE,
 	the driver SHOULD set \field{hdr_len} to a value
 	not less than the length of the headers, including the transport
 	header.
@@ -3379,6 +3381,7 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
 been negotiated:
 \begin{itemize}
 \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated,
+	and \field{gso_type} differs from VIRTIO_NET_HDR_GSO_NONE,
 	the device MAY use \field{hdr_len} as the transport header size.
 
 	\begin{note}
@@ -3387,6 +3390,7 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
 	\end{note}
 
 \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated,
+	or \field{gso_type} is VIRTIO_NET_HDR_GSO_NONE,
 	the device MAY use \field{hdr_len} only as a hint about the
 	transport header size.
 	The device MUST NOT rely on \field{hdr_len} to be correct.
--

This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


^ permalink raw reply related	[flat|nested] 2+ messages in thread