[Qemu-devel] [PATCH for-3.1 00/25] MAINTAINERS: Add various missing entries

[Qemu-devel] [PATCH for-3.1 00/25] MAINTAINERS: Add various missing entries

[Philippe Mathieu-Daudé]

Hi,

This cleanup effort is inspired by Markus "Full list of unmaintained files"
from the "MAINTAINERS leaves too many files uncovered" thread:
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04270.html

Regards,

Phil.

Philippe Mathieu-Daudé (25):
  MAINTAINERS: Fix ACPI tests data files path
  MAINTAINERS: Add a missing entry to the SPARC CPU
  MAINTAINERS: Add missing entries to the X86 section (AMD SEV)
  MAINTAINERS: Add missing entries for the Xilinx ZynqMP machine
  MAINTAINERS: Add missing entries for the Jazz machine
  MAINTAINERS: Add a missing entry for the Xilinx S3A-DSP 1800 machine
  MAINTAINERS: Add a missing entry for the Fulong 2E machine
  MAINTAINERS: Add a missing entry for the Old World machines
  MAINTAINERS: Add a missing entry for the sun4m machines
  MAINTAINERS: Add missing entries for the sun4u machines
  MAINTAINERS: Add missing entries for the PC machines
  MAINTAINERS: Add missing entries to the PC Chipset section
  MAINTAINERS: Add missing entries to VFIO
  MAINTAINERS: Add missing entries to the vhost section
  MAINTAINERS: Add missing entries for the Canon DIGIC machine
  MAINTAINERS: Add missing entries for the MPS2 machine
  MAINTAINERS: Add a missing entry to SPICE
  MAINTAINERS: Add missing entries for the QObject section
  MAINTAINERS: Add a missing entry to the QMP section
  MAINTAINERS: Add missing test entries to the Cryptography section
  MAINTAINERS: Add a missing entry for the NVDIMM device
  MAINTAINERS: Add a missing entry to the New World machines
  MAINTAINERS: Add an entry for the Dino machine
  MAINTAINERS: Use my work email to review Build and test automation patches
  MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org

 MAINTAINERS | 69 ++++++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 52 insertions(+), 17 deletions(-)

-- 
2.17.2

[Qemu-devel] [PATCH for-3.1 01/25] MAINTAINERS: Fix ACPI tests data files path

[Philippe Mathieu-Daudé]

Missed while moving those files in 438c78dab75.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1032406c56..6c4f25fb05 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1216,8 +1216,7 @@ F: hw/i386/acpi-build.[hc]
 F: hw/arm/virt-acpi-build.c
 F: tests/bios-tables-test.c
 F: tests/acpi-utils.[hc]
-F: tests/acpi-test-data/*
-F: tests/acpi-test-data/*/*
+F: tests/data/acpi/
 
 ppc4xx
 M: David Gibson <david@gibson.dropbear.id.au>
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 01/25] MAINTAINERS: Fix ACPI tests data files path

[Thomas Huth]

On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
> Missed while moving those files in 438c78dab75.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  MAINTAINERS | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1032406c56..6c4f25fb05 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1216,8 +1216,7 @@ F: hw/i386/acpi-build.[hc]
>  F: hw/arm/virt-acpi-build.c
>  F: tests/bios-tables-test.c
>  F: tests/acpi-utils.[hc]
> -F: tests/acpi-test-data/*
> -F: tests/acpi-test-data/*/*
> +F: tests/data/acpi/
>  
>  ppc4xx
>  M: David Gibson <david@gibson.dropbear.id.au>
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 01/25] MAINTAINERS: Fix ACPI tests data files path

[Laurent Vivier]

On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> Missed while moving those files in 438c78dab75.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  MAINTAINERS | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1032406c56..6c4f25fb05 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1216,8 +1216,7 @@ F: hw/i386/acpi-build.[hc]
>  F: hw/arm/virt-acpi-build.c
>  F: tests/bios-tables-test.c
>  F: tests/acpi-utils.[hc]
> -F: tests/acpi-test-data/*
> -F: tests/acpi-test-data/*/*
> +F: tests/data/acpi/
>  
>  ppc4xx
>  M: David Gibson <david@gibson.dropbear.id.au>
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

[Qemu-devel] [PATCH for-3.1 02/25] MAINTAINERS: Add a missing entry to the SPARC CPU

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6c4f25fb05..ae12323647 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -281,6 +281,7 @@ S: Maintained
 F: target/sparc/
 F: hw/sparc/
 F: hw/sparc64/
+F: include/hw/sparc/sparc64.h
 F: disas/sparc.c
 
 UniCore32
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 02/25] MAINTAINERS: Add a missing entry to the SPARC CPU

[Mark Cave-Ayland]

On 25/11/2018 20:49, Philippe Mathieu-Daudé wrote:

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6c4f25fb05..ae12323647 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -281,6 +281,7 @@ S: Maintained
>  F: target/sparc/
>  F: hw/sparc/
>  F: hw/sparc64/
> +F: include/hw/sparc/sparc64.h
>  F: disas/sparc.c
>  
>  UniCore32

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 02/25] MAINTAINERS: Add a missing entry to the SPARC CPU

[Laurent Vivier]

On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6c4f25fb05..ae12323647 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -281,6 +281,7 @@ S: Maintained
>  F: target/sparc/
>  F: hw/sparc/
>  F: hw/sparc64/
> +F: include/hw/sparc/sparc64.h
>  F: disas/sparc.c
>  
>  UniCore32
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

[Qemu-devel] [PATCH for-3.1 03/25] MAINTAINERS: Add missing entries to the X86 section (AMD SEV)

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ae12323647..3b9996ab2c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -300,8 +300,10 @@ F: target/i386/
 F: tests/tcg/i386/
 F: tests/tcg/x86_64/
 F: hw/i386/
+F: include/sysemu/sev.h
 F: disas/i386.c
 F: docs/qemu-cpu-models.texi
+F: docs/amd-memory-encryption.txt
 T: git https://github.com/ehabkost/qemu.git x86-next
 
 Xtensa
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 03/25] MAINTAINERS: Add missing entries to the X86 section (AMD SEV)

[Thomas Huth]

On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ae12323647..3b9996ab2c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -300,8 +300,10 @@ F: target/i386/
>  F: tests/tcg/i386/
>  F: tests/tcg/x86_64/
>  F: hw/i386/
> +F: include/sysemu/sev.h
>  F: disas/i386.c
>  F: docs/qemu-cpu-models.texi
> +F: docs/amd-memory-encryption.txt
>  T: git https://github.com/ehabkost/qemu.git x86-next

Not sure, but I think this should rather be added to the KVM section,
not to the TCG section?

 Thomas

Re: [Qemu-devel] [PATCH for-3.1 03/25] MAINTAINERS: Add missing entries to the X86 section (AMD SEV)

[Paolo Bonzini]

On 27/11/18 11:00, Thomas Huth wrote:
> On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index ae12323647..3b9996ab2c 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -300,8 +300,10 @@ F: target/i386/
>>  F: tests/tcg/i386/
>>  F: tests/tcg/x86_64/
>>  F: hw/i386/
>> +F: include/sysemu/sev.h
>>  F: disas/i386.c
>>  F: docs/qemu-cpu-models.texi
>> +F: docs/amd-memory-encryption.txt
>>  T: git https://github.com/ehabkost/qemu.git x86-next
> 
> Not sure, but I think this should rather be added to the KVM section,
> not to the TCG section?

Yes, agreed.

Paolo

[Qemu-devel] [PATCH for-3.1 04/25] MAINTAINERS: Add missing entries for the Xilinx ZynqMP machine

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3b9996ab2c..007f89f126 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -711,6 +711,9 @@ L: qemu-arm@nongnu.org
 S: Maintained
 F: hw/*/xlnx*.c
 F: include/hw/*/xlnx*.h
+F: include/hw/ssi/xilinx_spips.h
+F: hw/display/dpcd.c
+F: include/hw/display/dpcd.h
 
 ARM ACPI Subsystem
 M: Shannon Zhao <shannon.zhaosl@gmail.com>
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 04/25] MAINTAINERS: Add missing entries for the Xilinx ZynqMP machine

[Alistair Francis]

On Sun, Nov 25, 2018 at 12:54 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  MAINTAINERS | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3b9996ab2c..007f89f126 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -711,6 +711,9 @@ L: qemu-arm@nongnu.org
>  S: Maintained
>  F: hw/*/xlnx*.c
>  F: include/hw/*/xlnx*.h
> +F: include/hw/ssi/xilinx_spips.h
> +F: hw/display/dpcd.c
> +F: include/hw/display/dpcd.h
>
>  ARM ACPI Subsystem
>  M: Shannon Zhao <shannon.zhaosl@gmail.com>
> --
> 2.17.2
>
>

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 04/25] MAINTAINERS: Add missing entries for the Xilinx ZynqMP machine

[Laurent Vivier]

On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3b9996ab2c..007f89f126 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -711,6 +711,9 @@ L: qemu-arm@nongnu.org
>  S: Maintained
>  F: hw/*/xlnx*.c
>  F: include/hw/*/xlnx*.h
> +F: include/hw/ssi/xilinx_spips.h
> +F: hw/display/dpcd.c
> +F: include/hw/display/dpcd.h
>  
>  ARM ACPI Subsystem
>  M: Shannon Zhao <shannon.zhaosl@gmail.com>
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

[Qemu-devel] [PATCH for-3.1 05/25] MAINTAINERS: Add missing entries for the Jazz machine

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 007f89f126..4e396cbe71 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -835,6 +835,8 @@ M: Hervé Poussineau <hpoussin@reactos.org>
 R: Stefan Markovic <smarkovic@wavecomp.com>
 S: Maintained
 F: hw/mips/mips_jazz.c
+F: hw/display/jazz_led.c
+F: hw/dma/rc4030.c
 
 Malta
 M: Aurelien Jarno <aurelien@aurel32.net>
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 05/25] MAINTAINERS: Add missing entries for the Jazz machine

[Stefan Markovic]

On 25.11.18. 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   MAINTAINERS | 2 ++
>   1 file changed, 2 insertions(+)


Reviewed-by: Stefan Markovic <smarkovic@wavecomp.com>


> diff --git a/MAINTAINERS b/MAINTAINERS
> index 007f89f126..4e396cbe71 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -835,6 +835,8 @@ M: Hervé Poussineau <hpoussin@reactos.org>
>   R: Stefan Markovic <smarkovic@wavecomp.com>
>   S: Maintained
>   F: hw/mips/mips_jazz.c
> +F: hw/display/jazz_led.c
> +F: hw/dma/rc4030.c
>   
>   Malta
>   M: Aurelien Jarno <aurelien@aurel32.net>

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 05/25] MAINTAINERS: Add missing entries for the Jazz machine

[Laurent Vivier]

On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 007f89f126..4e396cbe71 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -835,6 +835,8 @@ M: Hervé Poussineau <hpoussin@reactos.org>
>  R: Stefan Markovic <smarkovic@wavecomp.com>
>  S: Maintained
>  F: hw/mips/mips_jazz.c
> +F: hw/display/jazz_led.c
> +F: hw/dma/rc4030.c
>  
>  Malta
>  M: Aurelien Jarno <aurelien@aurel32.net>
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

[Qemu-devel] [PATCH for-3.1 06/25] MAINTAINERS: Add a missing entry for the Xilinx S3A-DSP 1800 machine

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 4e396cbe71..aa17e9bbd3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -822,6 +822,7 @@ petalogix_s3adsp1800
 M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
 S: Maintained
 F: hw/microblaze/petalogix_s3adsp1800_mmu.c
+include/hw/char/xilinx_uartlite.h
 
 petalogix_ml605
 M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 06/25] MAINTAINERS: Add a missing entry for the Xilinx S3A-DSP 1800 machine

[Peter Maydell]

On Sun, 25 Nov 2018 at 20:51, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4e396cbe71..aa17e9bbd3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -822,6 +822,7 @@ petalogix_s3adsp1800
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>  S: Maintained
>  F: hw/microblaze/petalogix_s3adsp1800_mmu.c
> +include/hw/char/xilinx_uartlite.h

Missing the leading "F: " ?

>  petalogix_ml605
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>

thanks
-- PMM

Re: [Qemu-devel] [PATCH for-3.1 06/25] MAINTAINERS: Add a missing entry for the Xilinx S3A-DSP 1800 machine

[Philippe Mathieu-Daudé]

On 25/11/18 23:50, Peter Maydell wrote:
> On Sun, 25 Nov 2018 at 20:51, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 4e396cbe71..aa17e9bbd3 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -822,6 +822,7 @@ petalogix_s3adsp1800
>>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>>  S: Maintained
>>  F: hw/microblaze/petalogix_s3adsp1800_mmu.c
>> +include/hw/char/xilinx_uartlite.h
> 
> Missing the leading "F: " ?

Argh... If there is no need to respin, maybe the maintainer taking those
patches is willing to fix this mistake... :)

Thanks btw!

> 
>>  petalogix_ml605
>>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> 
> thanks
> -- PMM
> 

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 06/25] MAINTAINERS: Add a missing entry for the Xilinx S3A-DSP 1800 machine

[Laurent Vivier]

On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4e396cbe71..aa17e9bbd3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -822,6 +822,7 @@ petalogix_s3adsp1800
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>  S: Maintained
>  F: hw/microblaze/petalogix_s3adsp1800_mmu.c
> +include/hw/char/xilinx_uartlite.h
>  
>  petalogix_ml605
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> 

I've added the missing 'F:' field.

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 06/25] MAINTAINERS: Add a missing entry for the Xilinx S3A-DSP 1800 machine

[Philippe Mathieu-Daudé]

On 27/11/18 12:37, Laurent Vivier wrote:
> On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 4e396cbe71..aa17e9bbd3 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -822,6 +822,7 @@ petalogix_s3adsp1800
>>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>>  S: Maintained
>>  F: hw/microblaze/petalogix_s3adsp1800_mmu.c
>> +include/hw/char/xilinx_uartlite.h
>>  
>>  petalogix_ml605
>>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>>
> 
> I've added the missing 'F:' field.
> 
> Applied to my trivial-patches branch.

Thanks Laurent!

[Qemu-devel] [PATCH for-3.1 07/25] MAINTAINERS: Add a missing entry for the Fulong 2E machine

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index aa17e9bbd3..81a22b2ccf 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -864,6 +864,7 @@ R: Stefan Markovic <smarkovic@wavecomp.com>
 S: Odd Fixes
 F: hw/mips/mips_fulong2e.c
 F: hw/isa/vt82c686.c
+F: hw/pci-host/bonito.c
 
 F: include/hw/isa/vt82c686.h
 
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 07/25] MAINTAINERS: Add a missing entry for the Fulong 2E machine

[Stefan Markovic]

On 25.11.18. 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)


Reviewed-by: Stefan Markovic <smarkovic@wavecomp.com>


> diff --git a/MAINTAINERS b/MAINTAINERS
> index aa17e9bbd3..81a22b2ccf 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -864,6 +864,7 @@ R: Stefan Markovic <smarkovic@wavecomp.com>
>   S: Odd Fixes
>   F: hw/mips/mips_fulong2e.c
>   F: hw/isa/vt82c686.c
> +F: hw/pci-host/bonito.c
>   
>   F: include/hw/isa/vt82c686.h
>   

Re: [Qemu-devel] [PATCH for-3.1 07/25] MAINTAINERS: Add a missing entry for the Fulong 2E machine

[Thomas Huth]

On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index aa17e9bbd3..81a22b2ccf 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -864,6 +864,7 @@ R: Stefan Markovic <smarkovic@wavecomp.com>
>  S: Odd Fixes
>  F: hw/mips/mips_fulong2e.c
>  F: hw/isa/vt82c686.c
> +F: hw/pci-host/bonito.c
>  
>  F: include/hw/isa/vt82c686.h

Please remove the empty line between bonito.c and vt82c686.h - or we
could use my patch here from last Thursday instead:

 https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04526.html

 Thomas

Re: [Qemu-devel] [PATCH for-3.1 07/25] MAINTAINERS: Add a missing entry for the Fulong 2E machine

[Aleksandar Markovic]

I like better the patch that Thomas linked to. I think Philippe should have included Thomas' patch, rather than creating new, overlapping, patches. Confusion about straitforward things! Aleksandar

________________________________________
From: Thomas Huth <thuth@redhat.com>
Sent: Tuesday, November 27, 2018 10:49:27 AM
To: Philippe Mathieu-Daudé; Aleksandar Markovic; Stefan Markovic
Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org
Subject: Re: [PATCH for-3.1 07/25] MAINTAINERS: Add a missing entry for the Fulong 2E machine

On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index aa17e9bbd3..81a22b2ccf 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -864,6 +864,7 @@ R: Stefan Markovic <smarkovic@wavecomp.com>
>  S: Odd Fixes
>  F: hw/mips/mips_fulong2e.c
>  F: hw/isa/vt82c686.c
> +F: hw/pci-host/bonito.c
>
>  F: include/hw/isa/vt82c686.h

Please remove the empty line between bonito.c and vt82c686.h - or we
could use my patch here from last Thursday instead:

 https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04526.html

 Thomas

Re: [Qemu-devel] [PATCH for-3.1 07/25] MAINTAINERS: Add a missing entry for the Fulong 2E machine

[Philippe Mathieu-Daudé]

On 27/11/18 10:58, Aleksandar Markovic wrote:

[moving Aleksandar reply down to avoid top-posting on technical list]

> From: Thomas Huth <thuth@redhat.com>
> On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index aa17e9bbd3..81a22b2ccf 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -864,6 +864,7 @@ R: Stefan Markovic <smarkovic@wavecomp.com>
>>  S: Odd Fixes
>>  F: hw/mips/mips_fulong2e.c
>>  F: hw/isa/vt82c686.c
>> +F: hw/pci-host/bonito.c
>>
>>  F: include/hw/isa/vt82c686.h
> 
> Please remove the empty line between bonito.c and vt82c686.h - or we
> could use my patch here from last Thursday instead:
> 
>  https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04526.html

> I like better the patch that Thomas linked to. I think Philippe should
have included Thomas' patch, rather than creating new, overlapping,
patches. Confusion about straitforward things! Aleksandar

Yes you are right, I missed Thomas's patch, so please disregard mine.

Thanks!

Phil.

> 
>  Thomas
> 
> 

[Qemu-devel] [PATCH for-3.1 08/25] MAINTAINERS: Add a missing entry for the Old World machines

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 81a22b2ccf..aa51ae813b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -936,6 +936,7 @@ F: hw/ppc/mac_oldworld.c
 F: hw/pci-host/grackle.c
 F: hw/misc/macio/
 F: hw/intc/heathrow_pic.c
+F: include/hw/intc/heathrow_pic.h
 
 PReP
 M: Hervé Poussineau <hpoussin@reactos.org>
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 08/25] MAINTAINERS: Add a missing entry for the Old World machines

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

On Sun, Nov 25, 2018 at 09:49:43PM +0100, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Acked-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 81a22b2ccf..aa51ae813b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -936,6 +936,7 @@ F: hw/ppc/mac_oldworld.c
>  F: hw/pci-host/grackle.c
>  F: hw/misc/macio/
>  F: hw/intc/heathrow_pic.c
> +F: include/hw/intc/heathrow_pic.h
>  
>  PReP
>  M: Hervé Poussineau <hpoussin@reactos.org>

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [Qemu-devel] [PATCH for-3.1 08/25] MAINTAINERS: Add a missing entry for the Old World machines

[Mark Cave-Ayland]

On 25/11/2018 20:49, Philippe Mathieu-Daudé wrote:

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 81a22b2ccf..aa51ae813b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -936,6 +936,7 @@ F: hw/ppc/mac_oldworld.c
>  F: hw/pci-host/grackle.c
>  F: hw/misc/macio/
>  F: hw/intc/heathrow_pic.c
> +F: include/hw/intc/heathrow_pic.h
>  
>  PReP
>  M: Hervé Poussineau <hpoussin@reactos.org>

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 08/25] MAINTAINERS: Add a missing entry for the Old World machines

[Laurent Vivier]

On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 81a22b2ccf..aa51ae813b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -936,6 +936,7 @@ F: hw/ppc/mac_oldworld.c
>  F: hw/pci-host/grackle.c
>  F: hw/misc/macio/
>  F: hw/intc/heathrow_pic.c
> +F: include/hw/intc/heathrow_pic.h
>  
>  PReP
>  M: Hervé Poussineau <hpoussin@reactos.org>
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

[Qemu-devel] [PATCH for-3.1 09/25] MAINTAINERS: Add a missing entry for the sun4m machines

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index aa51ae813b..ba9cd9ac2b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1013,6 +1013,7 @@ F: hw/misc/eccmemctl.c
 F: hw/misc/slavio_misc.c
 F: include/hw/sparc/sparc32_dma.h
 F: pc-bios/openbios-sparc32
+F: include/hw/sparc/sun4m_iommu.h
 
 Sun4u
 M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 09/25] MAINTAINERS: Add a missing entry for the sun4m machines

[Mark Cave-Ayland]

On 25/11/2018 20:49, Philippe Mathieu-Daudé wrote:

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index aa51ae813b..ba9cd9ac2b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1013,6 +1013,7 @@ F: hw/misc/eccmemctl.c
>  F: hw/misc/slavio_misc.c
>  F: include/hw/sparc/sparc32_dma.h
>  F: pc-bios/openbios-sparc32
> +F: include/hw/sparc/sun4m_iommu.h
>  
>  Sun4u
>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.

[Qemu-devel] [PATCH for-3.1 10/25] MAINTAINERS: Add missing entries for the sun4u machines

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ba9cd9ac2b..d9cddb0cc8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1019,6 +1019,10 @@ Sun4u
 M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
 S: Maintained
 F: hw/sparc64/sun4u.c
+F: hw/sparc64/sun4u_iommu.c
+F: include/hw/sparc/sun4u_iommu.h
+F: hw/pci-host/sabre.c
+F: include/hw/pci-host/sabre.h
 F: pc-bios/openbios-sparc64
 
 Sun4v
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 10/25] MAINTAINERS: Add missing entries for the sun4u machines

[Mark Cave-Ayland]

On 25/11/2018 20:49, Philippe Mathieu-Daudé wrote:

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ba9cd9ac2b..d9cddb0cc8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1019,6 +1019,10 @@ Sun4u
>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>  S: Maintained
>  F: hw/sparc64/sun4u.c
> +F: hw/sparc64/sun4u_iommu.c
> +F: include/hw/sparc/sun4u_iommu.h
> +F: hw/pci-host/sabre.c
> +F: include/hw/pci-host/sabre.h
>  F: pc-bios/openbios-sparc64

These are correct, however you also want to add the simba PCI bridges i.e.

F: hw/pci-bridge/simba.c
F: include/hw/pci-bridge/simba.h

So with that:

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.

Re: [Qemu-devel] [PATCH for-3.1 10/25] MAINTAINERS: Add missing entries for the sun4u machines

[Philippe Mathieu-Daudé]

On 26/11/18 18:05, Mark Cave-Ayland wrote:
> On 25/11/2018 20:49, Philippe Mathieu-Daudé wrote:
> 
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index ba9cd9ac2b..d9cddb0cc8 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1019,6 +1019,10 @@ Sun4u
>>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>  S: Maintained
>>  F: hw/sparc64/sun4u.c
>> +F: hw/sparc64/sun4u_iommu.c
>> +F: include/hw/sparc/sun4u_iommu.h
>> +F: hw/pci-host/sabre.c
>> +F: include/hw/pci-host/sabre.h
>>  F: pc-bios/openbios-sparc64
> 
> These are correct, however you also want to add the simba PCI bridges i.e.
> 
> F: hw/pci-bridge/simba.c
> F: include/hw/pci-bridge/simba.h

OK, will update.

> 
> So with that:
> 
> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Thanks!

Phil.

[Qemu-devel] [PATCH for-3.1 11/25] MAINTAINERS: Add missing entries for the PC machines

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index d9cddb0cc8..9f89e37a1e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1101,6 +1101,10 @@ F: hw/acpi/ich9.c
 F: include/hw/acpi/ich9.h
 F: include/hw/acpi/piix4.h
 F: hw/misc/sga.c
+F: hw/isa/apm.c
+F: include/hw/isa/apm.h
+F: tests/test-x86-cpuid.c
+F: tests/test-x86-cpuid-compat.c
 
 PC Chipset
 M: Michael S. Tsirkin <mst@redhat.com>
-- 
2.17.2

[Qemu-devel] [PATCH for-3.1 12/25] MAINTAINERS: Add missing entries to the PC Chipset section

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9f89e37a1e..bfe71f2555 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1126,11 +1126,13 @@ F: hw/timer/hpet*
 F: hw/timer/i8254*
 F: hw/timer/mc146818rtc*
 F: hw/watchdog/wdt_ib700.c
+F: hw/watchdog/wdt_i6300esb.c
 F: include/hw/display/vga.h
 F: include/hw/char/parallel.h
 F: include/hw/dma/i8257.h
 F: include/hw/i2c/pm_smbus.h
 F: include/hw/input/i8042.h
+F: include/hw/isa/i8259_internal.h
 F: include/hw/isa/superio.h
 F: include/hw/timer/hpet.h
 F: include/hw/timer/i8254*
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 12/25] MAINTAINERS: Add missing entries to the PC Chipset section

[Thomas Huth]

On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9f89e37a1e..bfe71f2555 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1126,11 +1126,13 @@ F: hw/timer/hpet*
>  F: hw/timer/i8254*
>  F: hw/timer/mc146818rtc*
>  F: hw/watchdog/wdt_ib700.c
> +F: hw/watchdog/wdt_i6300esb.c
>  F: include/hw/display/vga.h
>  F: include/hw/char/parallel.h
>  F: include/hw/dma/i8257.h
>  F: include/hw/i2c/pm_smbus.h
>  F: include/hw/input/i8042.h
> +F: include/hw/isa/i8259_internal.h
>  F: include/hw/isa/superio.h
>  F: include/hw/timer/hpet.h
>  F: include/hw/timer/i8254*

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 12/25] MAINTAINERS: Add missing entries to the PC Chipset section

[Laurent Vivier]

On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9f89e37a1e..bfe71f2555 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1126,11 +1126,13 @@ F: hw/timer/hpet*
>  F: hw/timer/i8254*
>  F: hw/timer/mc146818rtc*
>  F: hw/watchdog/wdt_ib700.c
> +F: hw/watchdog/wdt_i6300esb.c
>  F: include/hw/display/vga.h
>  F: include/hw/char/parallel.h
>  F: include/hw/dma/i8257.h
>  F: include/hw/i2c/pm_smbus.h
>  F: include/hw/input/i8042.h
> +F: include/hw/isa/i8259_internal.h
>  F: include/hw/isa/superio.h
>  F: include/hw/timer/hpet.h
>  F: include/hw/timer/i8254*
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

[Qemu-devel] [PATCH for-3.1 13/25] MAINTAINERS: Add missing entries to VFIO

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index bfe71f2555..e124792557 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1326,6 +1326,8 @@ M: Alex Williamson <alex.williamson@redhat.com>
 S: Supported
 F: hw/vfio/*
 F: include/hw/vfio/
+F: include/qemu/vfio-helpers.h
+F: docs/igd-assign.txt
 
 vfio-ccw
 M: Cornelia Huck <cohuck@redhat.com>
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 13/25] MAINTAINERS: Add missing entries to VFIO

[Thomas Huth]

On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bfe71f2555..e124792557 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1326,6 +1326,8 @@ M: Alex Williamson <alex.williamson@redhat.com>
>  S: Supported
>  F: hw/vfio/*
>  F: include/hw/vfio/
> +F: include/qemu/vfio-helpers.h
> +F: docs/igd-assign.txt

Sounds reasonable to me.

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 13/25] MAINTAINERS: Add missing entries to VFIO

[Laurent Vivier]

On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bfe71f2555..e124792557 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1326,6 +1326,8 @@ M: Alex Williamson <alex.williamson@redhat.com>
>  S: Supported
>  F: hw/vfio/*
>  F: include/hw/vfio/
> +F: include/qemu/vfio-helpers.h
> +F: docs/igd-assign.txt
>  
>  vfio-ccw
>  M: Cornelia Huck <cohuck@redhat.com>
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [Qemu-devel] [PATCH for-3.1 13/25] MAINTAINERS: Add missing entries to VFIO

[Alex Williamson]

On Sun, 25 Nov 2018 21:49:48 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bfe71f2555..e124792557 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1326,6 +1326,8 @@ M: Alex Williamson <alex.williamson@redhat.com>
>  S: Supported
>  F: hw/vfio/*
>  F: include/hw/vfio/
> +F: include/qemu/vfio-helpers.h

This misses util/vfio-helpers.c, both of which are contributed by Fam
and currently only used by nvme.  I really haven't done anything with
them, so they should probably be under the NVMe block driver, but if it
makes more sense for me to look after them, I can start paying more
attention to them.  I'm not sure signing someone up for new files
they've never touched counts as trivial ;)  Thanks,

Alex

> +F: docs/igd-assign.txt
>  
>  vfio-ccw
>  M: Cornelia Huck <cohuck@redhat.com>

Re: [Qemu-devel] [PATCH for-3.1 13/25] MAINTAINERS: Add missing entries to VFIO

[Laurent Vivier]

On 27/11/2018 17:35, Alex Williamson wrote:
> On Sun, 25 Nov 2018 21:49:48 +0100
> Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> 
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index bfe71f2555..e124792557 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1326,6 +1326,8 @@ M: Alex Williamson <alex.williamson@redhat.com>
>>  S: Supported
>>  F: hw/vfio/*
>>  F: include/hw/vfio/
>> +F: include/qemu/vfio-helpers.h
> 
> This misses util/vfio-helpers.c, both of which are contributed by Fam
> and currently only used by nvme.  I really haven't done anything with
> them, so they should probably be under the NVMe block driver, but if it
> makes more sense for me to look after them, I can start paying more
> attention to them.  I'm not sure signing someone up for new files
> they've never touched counts as trivial ;)  Thanks,

Un-applied to my trivial-patches branch...

Thanks,
Laurent

Re: [Qemu-devel] [PATCH for-3.1 13/25] MAINTAINERS: Add missing entries to VFIO

[Philippe Mathieu-Daudé]

On 27/11/18 17:35, Alex Williamson wrote:
> On Sun, 25 Nov 2018 21:49:48 +0100
> Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> 
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index bfe71f2555..e124792557 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1326,6 +1326,8 @@ M: Alex Williamson <alex.williamson@redhat.com>
>>  S: Supported
>>  F: hw/vfio/*
>>  F: include/hw/vfio/
>> +F: include/qemu/vfio-helpers.h
> 
> This misses util/vfio-helpers.c, both of which are contributed by Fam
> and currently only used by nvme.  I really haven't done anything with
> them, so they should probably be under the NVMe block driver, but if it
> makes more sense for me to look after them, I can start paying more
> attention to them.  I'm not sure signing someone up for new files
> they've never touched counts as trivial ;)  Thanks,

OK (Cc'ed Fam).

Laurent, can you unqueue this patch? (sorry).

Thanks,

Phil.

> 
> Alex
> 
>> +F: docs/igd-assign.txt
>>  
>>  vfio-ccw
>>  M: Cornelia Huck <cohuck@redhat.com>
> 

[Qemu-devel] [PATCH for-3.1 14/25] MAINTAINERS: Add missing entries to the vhost section

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e124792557..eab0fb9742 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1359,6 +1359,7 @@ M: Michael S. Tsirkin <mst@redhat.com>
 S: Supported
 F: hw/*/*vhost*
 F: docs/interop/vhost-user.txt
+F: contrib/vhost-user-*/
 
 virtio
 M: Michael S. Tsirkin <mst@redhat.com>
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 14/25] MAINTAINERS: Add missing entries to the vhost section

[Thomas Huth]

On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e124792557..eab0fb9742 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1359,6 +1359,7 @@ M: Michael S. Tsirkin <mst@redhat.com>
>  S: Supported
>  F: hw/*/*vhost*
>  F: docs/interop/vhost-user.txt
> +F: contrib/vhost-user-*/
>  
>  virtio
>  M: Michael S. Tsirkin <mst@redhat.com>
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 14/25] MAINTAINERS: Add missing entries to the vhost section

[Laurent Vivier]

On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e124792557..eab0fb9742 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1359,6 +1359,7 @@ M: Michael S. Tsirkin <mst@redhat.com>
>  S: Supported
>  F: hw/*/*vhost*
>  F: docs/interop/vhost-user.txt
> +F: contrib/vhost-user-*/
>  
>  virtio
>  M: Michael S. Tsirkin <mst@redhat.com>
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

[Qemu-devel] [PATCH for-3.1 15/25] MAINTAINERS: Add missing entries for the Canon DIGIC machine

[Philippe Mathieu-Daudé]

This pattern now also matches:
- include/hw/timer/digic-timer.h
- include/hw/char/digic-uart.h

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index eab0fb9742..e04f2f1a44 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -527,6 +527,7 @@ L: qemu-arm@nongnu.org
 S: Odd Fixes
 F: include/hw/arm/digic.h
 F: hw/*/digic*
+F: include/hw/*/digic*
 
 Gumstix
 M: Peter Maydell <peter.maydell@linaro.org>
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 15/25] MAINTAINERS: Add missing entries for the Canon DIGIC machine

[Peter Maydell]

On Sun, 25 Nov 2018 at 20:52, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> This pattern now also matches:
> - include/hw/timer/digic-timer.h
> - include/hw/char/digic-uart.h
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index eab0fb9742..e04f2f1a44 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -527,6 +527,7 @@ L: qemu-arm@nongnu.org
>  S: Odd Fixes
>  F: include/hw/arm/digic.h
>  F: hw/*/digic*
> +F: include/hw/*/digic*
>
>  Gumstix
>  M: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 15/25] MAINTAINERS: Add missing entries for the Canon DIGIC machine

[Laurent Vivier]

On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> This pattern now also matches:
> - include/hw/timer/digic-timer.h
> - include/hw/char/digic-uart.h
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index eab0fb9742..e04f2f1a44 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -527,6 +527,7 @@ L: qemu-arm@nongnu.org
>  S: Odd Fixes
>  F: include/hw/arm/digic.h
>  F: hw/*/digic*
> +F: include/hw/*/digic*
>  
>  Gumstix
>  M: Peter Maydell <peter.maydell@linaro.org>
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

[Qemu-devel] [PATCH for-3.1 16/25] MAINTAINERS: Add missing entries for the MPS2 machine

[Philippe Mathieu-Daudé]

Missed in de343bb632a.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e04f2f1a44..2795135a09 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -587,6 +587,8 @@ F: hw/misc/mps2-*.c
 F: include/hw/misc/mps2-*.h
 F: hw/arm/iotkit.c
 F: include/hw/arm/iotkit.h
+F: hw/misc/iotkit-secctl.c
+F: include/hw/misc/iotkit-secctl.h
 F: hw/misc/iotkit-sysctl.c
 F: include/hw/misc/iotkit-sysctl.h
 F: hw/misc/iotkit-sysinfo.c
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 16/25] MAINTAINERS: Add missing entries for the MPS2 machine

[Peter Maydell]

On Sun, 25 Nov 2018 at 20:52, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> Missed in de343bb632a.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e04f2f1a44..2795135a09 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -587,6 +587,8 @@ F: hw/misc/mps2-*.c
>  F: include/hw/misc/mps2-*.h
>  F: hw/arm/iotkit.c
>  F: include/hw/arm/iotkit.h
> +F: hw/misc/iotkit-secctl.c
> +F: include/hw/misc/iotkit-secctl.h
>  F: hw/misc/iotkit-sysctl.c
>  F: include/hw/misc/iotkit-sysctl.h
>  F: hw/misc/iotkit-sysinfo.c
> --

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 16/25] MAINTAINERS: Add missing entries for the MPS2 machine

[Laurent Vivier]

On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> Missed in de343bb632a.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e04f2f1a44..2795135a09 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -587,6 +587,8 @@ F: hw/misc/mps2-*.c
>  F: include/hw/misc/mps2-*.h
>  F: hw/arm/iotkit.c
>  F: include/hw/arm/iotkit.h
> +F: hw/misc/iotkit-secctl.c
> +F: include/hw/misc/iotkit-secctl.h
>  F: hw/misc/iotkit-sysctl.c
>  F: include/hw/misc/iotkit-sysctl.h
>  F: hw/misc/iotkit-sysinfo.c
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

[Qemu-devel] [PATCH for-3.1 17/25] MAINTAINERS: Add a missing entry to SPICE

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2795135a09..28e5038c73 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1736,6 +1736,7 @@ F: ui/spice-*.c
 F: audio/spiceaudio.c
 F: hw/display/qxl*
 F: qapi/ui.json
+F: docs/spice-port-fqdn.txt
 
 Graphics
 M: Gerd Hoffmann <kraxel@redhat.com>
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 17/25] MAINTAINERS: Add a missing entry to SPICE

[Gerd Hoffmann]

On Sun, Nov 25, 2018 at 09:49:52PM +0100, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2795135a09..28e5038c73 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1736,6 +1736,7 @@ F: ui/spice-*.c
>  F: audio/spiceaudio.c
>  F: hw/display/qxl*
>  F: qapi/ui.json
> +F: docs/spice-port-fqdn.txt

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

[Qemu-devel] [PATCH for-3.1 18/25] MAINTAINERS: Add missing entries for the QObject section

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 28e5038c73..ac5d25491f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1846,12 +1846,18 @@ S: Supported
 F: qobject/
 F: include/qapi/qmp/
 X: include/qapi/qmp/dispatch.h
+F: include/qemu/qdist.h
 F: scripts/coccinelle/qobject.cocci
 F: tests/check-qdict.c
-F: tests/check-qnum.c
 F: tests/check-qjson.c
 F: tests/check-qlist.c
+F: tests/check-qlit.c
+F: tests/check-qnull.c
+F: tests/check-qnum.c
+F: tests/check-qobject.c
 F: tests/check-qstring.c
+F: tests/test-qdist.c
+F: qdict-test-data.txt
 T: git https://repo.or.cz/qemu/armbru.git qapi-next
 
 QEMU Guest Agent
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 18/25] MAINTAINERS: Add missing entries for the QObject section

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 28e5038c73..ac5d25491f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1846,12 +1846,18 @@ S: Supported
>  F: qobject/
>  F: include/qapi/qmp/
>  X: include/qapi/qmp/dispatch.h
> +F: include/qemu/qdist.h

This isn't part of QObject.

>  F: scripts/coccinelle/qobject.cocci
>  F: tests/check-qdict.c
> -F: tests/check-qnum.c
>  F: tests/check-qjson.c
>  F: tests/check-qlist.c
> +F: tests/check-qlit.c
> +F: tests/check-qnull.c
> +F: tests/check-qnum.c
> +F: tests/check-qobject.c

There are good.

>  F: tests/check-qstring.c
> +F: tests/test-qdist.c

Not part of QObject.

> +F: qdict-test-data.txt

Good.  Should be moved to tests/, but not in this series.

>  T: git https://repo.or.cz/qemu/armbru.git qapi-next
>  
>  QEMU Guest Agent

[Qemu-devel] [PATCH for-3.1 19/25] MAINTAINERS: Add a missing entry to the QMP section

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ac5d25491f..c73dde10a5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1887,6 +1887,7 @@ S: Supported
 F: qmp.c
 F: monitor.c
 F: docs/devel/*qmp-*
+F: docs/interop/*qmp-*
 F: scripts/qmp/
 F: tests/qmp-test.c
 F: tests/qmp-cmd-test.c
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 19/25] MAINTAINERS: Add a missing entry to the QMP section

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ac5d25491f..c73dde10a5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1887,6 +1887,7 @@ S: Supported
>  F: qmp.c
>  F: monitor.c
>  F: docs/devel/*qmp-*
> +F: docs/interop/*qmp-*
>  F: scripts/qmp/
>  F: tests/qmp-test.c
>  F: tests/qmp-cmd-test.c

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 19/25] MAINTAINERS: Add a missing entry to the QMP section

[Laurent Vivier]

On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ac5d25491f..c73dde10a5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1887,6 +1887,7 @@ S: Supported
>  F: qmp.c
>  F: monitor.c
>  F: docs/devel/*qmp-*
> +F: docs/interop/*qmp-*
>  F: scripts/qmp/
>  F: tests/qmp-test.c
>  F: tests/qmp-cmd-test.c
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

[Qemu-devel] [PATCH for-3.1 20/25] MAINTAINERS: Add missing test entries to the Cryptography section

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index c73dde10a5..26727c1561 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1978,6 +1978,8 @@ F: crypto/
 F: include/crypto/
 F: tests/test-crypto-*
 F: tests/benchmark-crypto-*
+F: tests/crypto-tls-*
+F: tests/pkix_asn1_tab.c
 F: qemu.sasl
 
 Coroutines
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 20/25] MAINTAINERS: Add missing test entries to the Cryptography section

[Daniel P. Berrangé]

On Sun, Nov 25, 2018 at 09:49:55PM +0100, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)

Acked-by: Daniel P. Berrangé <berrange@redhat.com>

> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c73dde10a5..26727c1561 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1978,6 +1978,8 @@ F: crypto/
>  F: include/crypto/
>  F: tests/test-crypto-*
>  F: tests/benchmark-crypto-*
> +F: tests/crypto-tls-*
> +F: tests/pkix_asn1_tab.c
>  F: qemu.sasl

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

[Qemu-devel] [PATCH for-3.1 21/25] MAINTAINERS: Add a missing entry for the NVDIMM device

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 26727c1561..92691589b1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1475,6 +1475,7 @@ S: Maintained
 F: hw/acpi/nvdimm.c
 F: hw/mem/nvdimm.c
 F: include/hw/mem/nvdimm.h
+F: docs/nvdimm.txt
 
 e1000x
 M: Dmitry Fleytman <dmitry.fleytman@gmail.com>
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 21/25] MAINTAINERS: Add a missing entry for the NVDIMM device

[Thomas Huth]

On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 26727c1561..92691589b1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1475,6 +1475,7 @@ S: Maintained
>  F: hw/acpi/nvdimm.c
>  F: hw/mem/nvdimm.c
>  F: include/hw/mem/nvdimm.h
> +F: docs/nvdimm.txt
>  
>  e1000x
>  M: Dmitry Fleytman <dmitry.fleytman@gmail.com>
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 21/25] MAINTAINERS: Add a missing entry for the NVDIMM device

[Laurent Vivier]

On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 26727c1561..92691589b1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1475,6 +1475,7 @@ S: Maintained
>  F: hw/acpi/nvdimm.c
>  F: hw/mem/nvdimm.c
>  F: include/hw/mem/nvdimm.h
> +F: docs/nvdimm.txt
>  
>  e1000x
>  M: Dmitry Fleytman <dmitry.fleytman@gmail.com>
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

[Qemu-devel] [PATCH for-3.1 22/25] MAINTAINERS: Add a missing entry to the New World machines

[Philippe Mathieu-Daudé]

The CHRP NVRAM has his own section, but since the New World
section contains the mac_nvram.c, it makes sens to also monitor
the corresponding header.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 92691589b1..a248c8c564 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -930,6 +930,7 @@ F: hw/nvram/mac_nvram.c
 F: include/hw/misc/macio/
 F: include/hw/misc/mos6522.h
 F: include/hw/ppc/mac_dbdma.h
+F: include/hw/nvram/chrp_nvram.h
 
 Old World
 M: David Gibson <david@gibson.dropbear.id.au>
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 22/25] MAINTAINERS: Add a missing entry to the New World machines

[Thomas Huth]

On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
> The CHRP NVRAM has his own section, but since the New World
> section contains the mac_nvram.c, it makes sens to also monitor
> the corresponding header.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 92691589b1..a248c8c564 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -930,6 +930,7 @@ F: hw/nvram/mac_nvram.c
>  F: include/hw/misc/macio/
>  F: include/hw/misc/mos6522.h
>  F: include/hw/ppc/mac_dbdma.h
> +F: include/hw/nvram/chrp_nvram.h

I don't see the point why we should add duplicated entries here? The
header is also used by the Sparc machines, so why should this be added
additionally to the Mac machines only here, too? I suggest to drop this
patch.

 Thomas

Re: [Qemu-devel] [PATCH for-3.1 22/25] MAINTAINERS: Add a missing entry to the New World machines

[Philippe Mathieu-Daudé]

On 27/11/18 8:22, Thomas Huth wrote:
> On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
>> The CHRP NVRAM has his own section, but since the New World
>> section contains the mac_nvram.c, it makes sens to also monitor
>> the corresponding header.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 92691589b1..a248c8c564 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -930,6 +930,7 @@ F: hw/nvram/mac_nvram.c
>>  F: include/hw/misc/macio/
>>  F: include/hw/misc/mos6522.h
>>  F: include/hw/ppc/mac_dbdma.h
>> +F: include/hw/nvram/chrp_nvram.h
> 
> I don't see the point why we should add duplicated entries here? The
> header is also used by the Sparc machines, so why should this be added
> additionally to the Mac machines only here, too? I suggest to drop this
> patch.

OK, will drop.

[Qemu-devel] [PATCH for-3.1 23/25] MAINTAINERS: Add an entry for the Dino machine

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index a248c8c564..ad82c0377c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -879,6 +879,15 @@ F: hw/core/loader-fit.c
 F: hw/mips/boston.c
 F: hw/pci-host/xilinx-pcie.c
 
+HP-PARISC Machines
+------------------
+
+Dino
+M: Richard Henderson <rth@twiddle.net>
+S: Maintained
+F: hw/hppa/
+F: pc-bios/hppa-firmware.img
+
 OpenRISC Machines
 -----------------
 or1k-sim
-- 
2.17.2

[Qemu-devel] [PATCH for-3.1 24/25] MAINTAINERS: Use my work email to review Build and test automation patches

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index ad82c0377c..c616861ca3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2388,7 +2388,7 @@ Build and test automation
 Build and test automation
 M: Alex Bennée <alex.bennee@linaro.org>
 M: Fam Zheng <famz@redhat.com>
-R: Philippe Mathieu-Daudé <f4bug@amsat.org>
+R: Philippe Mathieu-Daudé <philmd@redhat.com>
 L: qemu-devel@nongnu.org
 S: Maintained
 F: .travis.yml
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 24/25] MAINTAINERS: Use my work email to review Build and test automation patches

[Thomas Huth]

On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ad82c0377c..c616861ca3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2388,7 +2388,7 @@ Build and test automation
>  Build and test automation
>  M: Alex Bennée <alex.bennee@linaro.org>
>  M: Fam Zheng <famz@redhat.com>
> -R: Philippe Mathieu-Daudé <f4bug@amsat.org>
> +R: Philippe Mathieu-Daudé <philmd@redhat.com>
>  L: qemu-devel@nongnu.org
>  S: Maintained
>  F: .travis.yml
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 24/25] MAINTAINERS: Use my work email to review Build and test automation patches

[Laurent Vivier]

On 25/11/2018 21:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ad82c0377c..c616861ca3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2388,7 +2388,7 @@ Build and test automation
>  Build and test automation
>  M: Alex Bennée <alex.bennee@linaro.org>
>  M: Fam Zheng <famz@redhat.com>
> -R: Philippe Mathieu-Daudé <f4bug@amsat.org>
> +R: Philippe Mathieu-Daudé <philmd@redhat.com>
>  L: qemu-devel@nongnu.org
>  S: Maintained
>  F: .travis.yml
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

[Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org

[Philippe Mathieu-Daudé]

The list is always selected by the 'All patches CC here' section.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index c616861ca3..9d6dae71ff 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -109,7 +109,6 @@ L: qemu-s390x@nongnu.org
 Guest CPU cores (TCG):
 ----------------------
 Overall
-L: qemu-devel@nongnu.org
 M: Peter Crosthwaite <crosthwaite.peter@gmail.com>
 M: Richard Henderson <rth@twiddle.net>
 R: Paolo Bonzini <pbonzini@redhat.com>
@@ -403,30 +402,25 @@ Hosts:
 ------
 
 LINUX
-L: qemu-devel@nongnu.org
 S: Maintained
 F: linux-*
 F: linux-headers/
 
 POSIX
-L: qemu-devel@nongnu.org
 S: Maintained
 F: *posix*
 
 NETBSD
-L: qemu-devel@nongnu.org
 M: Kamil Rytarowski <kamil@netbsd.org>
 S: Maintained
 K: ^Subject:.*(?i)NetBSD
 
 OPENBSD
-L: qemu-devel@nongnu.org
 M: Brad Smith <brad@comstyle.com>
 S: Maintained
 K: ^Subject:.*(?i)OpenBSD
 
 W32, W64
-L: qemu-devel@nongnu.org
 M: Stefan Weil <sw@weilnetz.de>
 S: Maintained
 F: *win32*
@@ -532,7 +526,6 @@ F: include/hw/*/digic*
 Gumstix
 M: Peter Maydell <peter.maydell@linaro.org>
 R: Philippe Mathieu-Daudé <f4bug@amsat.org>
-L: qemu-devel@nongnu.org
 L: qemu-arm@nongnu.org
 S: Odd Fixes
 F: hw/arm/gumstix.c
@@ -953,7 +946,6 @@ F: include/hw/intc/heathrow_pic.h
 
 PReP
 M: Hervé Poussineau <hpoussin@reactos.org>
-L: qemu-devel@nongnu.org
 L: qemu-ppc@nongnu.org
 S: Maintained
 F: hw/ppc/prep.c
@@ -1690,7 +1682,6 @@ S: Supported
 F: scripts/coverity-model.c
 
 CPU
-L: qemu-devel@nongnu.org
 S: Supported
 F: qom/cpu.c
 F: include/qom/cpu.h
@@ -1722,7 +1713,6 @@ F: util/error.c
 F: util/qemu-error.c
 
 GDB stub
-L: qemu-devel@nongnu.org
 S: Odd Fixes
 F: gdbstub*
 F: gdb-xml/
@@ -2124,7 +2114,6 @@ F: tcg/arm/
 F: disas/arm.c
 
 i386 target
-L: qemu-devel@nongnu.org
 S: Maintained
 F: tcg/i386/
 F: disas/i386.c
@@ -2389,7 +2378,6 @@ Build and test automation
 M: Alex Bennée <alex.bennee@linaro.org>
 M: Fam Zheng <famz@redhat.com>
 R: Philippe Mathieu-Daudé <philmd@redhat.com>
-L: qemu-devel@nongnu.org
 S: Maintained
 F: .travis.yml
 F: scripts/travis/
@@ -2405,7 +2393,6 @@ M: Alex Bennée <alex.bennee@linaro.org>
 R: Philippe Mathieu-Daudé <f4bug@amsat.org>
 F: tests/tcg/Makefile
 F: tests/tcg/Makefile.include
-L: qemu-devel@nongnu.org
 
 Documentation
 -------------
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org

[Thomas Huth]

On 2018-11-25 21:50, Philippe Mathieu-Daudé wrote:
> The list is always selected by the 'All patches CC here' section.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c616861ca3..9d6dae71ff 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -109,7 +109,6 @@ L: qemu-s390x@nongnu.org
>  Guest CPU cores (TCG):
>  ----------------------
>  Overall
> -L: qemu-devel@nongnu.org
>  M: Peter Crosthwaite <crosthwaite.peter@gmail.com>
>  M: Richard Henderson <rth@twiddle.net>
>  R: Paolo Bonzini <pbonzini@redhat.com>
> @@ -403,30 +402,25 @@ Hosts:
>  ------
>  
>  LINUX
> -L: qemu-devel@nongnu.org
>  S: Maintained
>  F: linux-*
>  F: linux-headers/
>  
>  POSIX
> -L: qemu-devel@nongnu.org
>  S: Maintained
>  F: *posix*

I agree that we can remove the "L: qemu-devel" entries everywhere, but
for these subsystems that have no "M:" entry, but "S: Maintained", this
now looks somewhat strange - the subsystem is "Maintained" but has no
maintainer? I think we need somebody who feels responsible to pick up
patches here...?

 Thomas

Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org

[Markus Armbruster]

Thomas Huth <thuth@redhat.com> writes:

> On 2018-11-25 21:50, Philippe Mathieu-Daudé wrote:
>> The list is always selected by the 'All patches CC here' section.
>> 
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS | 13 -------------
>>  1 file changed, 13 deletions(-)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index c616861ca3..9d6dae71ff 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -109,7 +109,6 @@ L: qemu-s390x@nongnu.org
>>  Guest CPU cores (TCG):
>>  ----------------------
>>  Overall
>> -L: qemu-devel@nongnu.org
>>  M: Peter Crosthwaite <crosthwaite.peter@gmail.com>
>>  M: Richard Henderson <rth@twiddle.net>
>>  R: Paolo Bonzini <pbonzini@redhat.com>
>> @@ -403,30 +402,25 @@ Hosts:
>>  ------
>>  
>>  LINUX
>> -L: qemu-devel@nongnu.org
>>  S: Maintained
>>  F: linux-*
>>  F: linux-headers/
>>  
>>  POSIX
>> -L: qemu-devel@nongnu.org
>>  S: Maintained
>>  F: *posix*
>
> I agree that we can remove the "L: qemu-devel" entries everywhere, but
> for these subsystems that have no "M:" entry, but "S: Maintained", this
> now looks somewhat strange - the subsystem is "Maintained" but has no
> maintainer? I think we need somebody who feels responsible to pick up
> patches here...?

It looks strange because it *is* strange.  If we take the definition of
S: in MAINTAINERS seriously, we need to appoint a maintainer (a person,
not a mailing list), or downgrade to S: Orphan.

Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org

[Paolo Bonzini]

On 27/11/18 09:59, Markus Armbruster wrote:
>>>  LINUX
>>> -L: qemu-devel@nongnu.org
>>>  S: Maintained
>>>  F: linux-*

This pattern only matches

./block/linux-aio.c
./stubs/linux-aio.c

so it can be removed

>>>  F: linux-headers/

For this I propose mst, Conny and myself.

>>>  POSIX
>>> -L: qemu-devel@nongnu.org
>>>  S: Maintained
>>>  F: *posix*
>>
>> I agree that we can remove the "L: qemu-devel" entries everywhere, but
>> for these subsystems that have no "M:" entry, but "S: Maintained", this
>> now looks somewhat strange - the subsystem is "Maintained" but has no
>> maintainer? I think we need somebody who feels responsible to pick up
>> patches here...?
> 
> It looks strange because it *is* strange.  If we take the definition of
> S: in MAINTAINERS seriously, we need to appoint a maintainer (a person,
> not a mailing list), or downgrade to S: Orphan.

I can volunteer for this one too, but please change the F: patterns to

F: os-posix.c
F: include/sysemu/os-posix.h
F: util/*posix*.c
F: include/qemu/*posix*.h

Thanks,

Paolo

Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org

[Philippe Mathieu-Daudé]

On 27/11/18 10:18, Paolo Bonzini wrote:
> On 27/11/18 09:59, Markus Armbruster wrote:
>>>>  LINUX
>>>> -L: qemu-devel@nongnu.org
>>>>  S: Maintained
>>>>  F: linux-*
> 
> This pattern only matches
> 
> ./block/linux-aio.c
> ./stubs/linux-aio.c
> 
> so it can be removed
> 

OK

>>>>  F: linux-headers/
> 
> For this I propose mst, Conny and myself.

Or remove... I'll let them opinate.

> 
>>>>  POSIX
>>>> -L: qemu-devel@nongnu.org
>>>>  S: Maintained
>>>>  F: *posix*
>>>
>>> I agree that we can remove the "L: qemu-devel" entries everywhere, but
>>> for these subsystems that have no "M:" entry, but "S: Maintained", this
>>> now looks somewhat strange - the subsystem is "Maintained" but has no
>>> maintainer? I think we need somebody who feels responsible to pick up
>>> patches here...?
>>
>> It looks strange because it *is* strange.  If we take the definition of
>> S: in MAINTAINERS seriously, we need to appoint a maintainer (a person,
>> not a mailing list), or downgrade to S: Orphan.
> 
> I can volunteer for this one too, but please change the F: patterns to
> 
> F: os-posix.c
> F: include/sysemu/os-posix.h
> F: util/*posix*.c
> F: include/qemu/*posix*.h

OK, will do.

Thanks Paolo,

Phil.

> 
> Thanks,
> 
> Paolo
> 

Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org

[Cornelia Huck]

On Tue, 27 Nov 2018 10:18:04 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 27/11/18 09:59, Markus Armbruster wrote:

> >>>  F: linux-headers/  
> 
> For this I propose mst, Conny and myself.

Fine with me.