Re: [Qemu-devel] [PATCH v5 05/14] target/mips: Add bit encoding for MXU add/subtract patterns 'aptn2'

[Aleksandar Markovic <amarkovic@wavecomp.com>]

> From: Aleksandar Markovic <> aleksandar.markovic@rt-rk.com>
> Sent: Friday, October 19, 2018 6:33 PM
> Subject: [PATCH v5 05/14] target/mips: > Add bit encoding for MXU add/subtract > patterns 'aptn2'
> 
> From: Craig Janeczek <> jancraig@amazon.com>
> 
> Add bit encoding for MXU add/subtract patterns 'aptn2'.
> 

'eptn2' is very similar to 'aptn2', but we need a similar patch for 'eptn2' too.

This is needed so that we are as close to the documentation as possible.

'aptn1' and 'strd2', in my opinion, do not need any preprocessor definition, since they can be only 0 and 1, and 0, 1, 2 respectively... What do you think, Craig?

Thanks,
Aleksandar

> Signed-off-by: Craig Janeczek <> jancraig@amazon.com>
> Signed-off-by: Aleksandar Markovic <> amarkovic@wavecomp.com>
> ---
>  target/mips/translate.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/target/mips/translate.c b/> target/mips/translate.c
> index 5f8dcc9..f465635 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -23311,6 +23311,13 @@ static void > decode_opc_special(CPUMIPSState *env, > DisasContext *ctx)
>      }
>  }
> 
> +/* MXU add/subtract patterns 'aptn2' */
> +#define MXU_APTN2_AA    0
> +#define MXU_APTN2_AS    1
> +#define MXU_APTN2_SA    2
> +#define MXU_APTN2_SS    3
> +
> +
>  /*
>   *
>   * Decode MXU pool00
> --
> 2.7.4
>