[PATCH BlueZ 2/2] Update the Adapter1 API to match the change to ConnectDevice

[PATCH BlueZ 2/2] Update the Adapter1 API to match the change to ConnectDevice

[Karabin, Josh]

---
 doc/adapter-api.txt | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
index 2afd61bc3..918153f68 100644
--- a/doc/adapter-api.txt
+++ b/doc/adapter-api.txt
@@ -158,11 +158,11 @@ Methods		void StartDiscovery()
 			similar to Connect method from Device1 interface with
 			exception that this method returns success when physical
 			connection is established. After this method returns,
-			services discovery will continue and any supported
-			profile will be connected. There is no need for calling
-			Connect on Device1 after this call. If connection was
-			successful this method returns object path to created
-			device object.
+			services discovery will continue.
+
+			There is no need for calling Connect on Device1 after
+			this call. If connection was successful this method
+			returns object path to created device object.
=20
 			Parameters that may be set in the filter dictionary
 			include the following:
@@ -189,6 +189,11 @@ Methods		void StartDiscovery()
 					 org.bluez.Error.NotReady
 					 org.bluez.Error.Failed
=20
+		boolean ConnectAllProfiles
+
+			If set to true, any supported profile will be
+			connected. This parameter is optional.
+
 Properties	string Address [readonly]
=20
 			The Bluetooth device address.
--=20
2.17.1

Re: [PATCH BlueZ 2/2] Update the Adapter1 API to match the change to ConnectDevice

[Luiz Augusto von Dentz]

Hi Josh,

On Thu, Aug 16, 2018 at 11:29 PM, Karabin, Josh
<George.Karabin@honeywell.com> wrote:
> ---
>  doc/adapter-api.txt | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> index 2afd61bc3..918153f68 100644
> --- a/doc/adapter-api.txt
> +++ b/doc/adapter-api.txt
> @@ -158,11 +158,11 @@ Methods           void StartDiscovery()
>                         similar to Connect method from Device1 interface with
>                         exception that this method returns success when physical
>                         connection is established. After this method returns,
> -                       services discovery will continue and any supported
> -                       profile will be connected. There is no need for calling
> -                       Connect on Device1 after this call. If connection was
> -                       successful this method returns object path to created
> -                       device object.
> +                       services discovery will continue.
> +
> +                       There is no need for calling Connect on Device1 after
> +                       this call. If connection was successful this method
> +                       returns object path to created device object.
>
>                         Parameters that may be set in the filter dictionary
>                         include the following:
> @@ -189,6 +189,11 @@ Methods            void StartDiscovery()
>                                          org.bluez.Error.NotReady
>                                          org.bluez.Error.Failed
>
> +               boolean ConnectAllProfiles
> +
> +                       If set to true, any supported profile will be
> +                       connected. This parameter is optional.

Id keep the original behaviour and just disable with AutoConnect which
by default, actually since this is an option usually we don't use
camelcase so instead it should be auto-connect.

> +
>  Properties     string Address [readonly]
>
>                         The Bluetooth device address.
> --
> 2.17.1
>



-- 
Luiz Augusto von Dentz

RE: [External] Re: [PATCH BlueZ 2/2] Update the Adapter1 API to match the change to ConnectDevice

[Karabin, Josh]

PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBMdWl6IEF1Z3VzdG8gdm9uIERl
bnR6IFttYWlsdG86bHVpei5kZW50ekBnbWFpbC5jb21dDQo+IFNlbnQ6IEZyaWRheSwgQXVndXN0
IDE3LCAyMDE4IDI6MTIgQU0NCg0KVGhhbmtzIGZvciB0aGUgcmV2aWV3LCBMdWlzLg0KDQo+IE9u
IFRodSwgQXVnIDE2LCAyMDE4IGF0IDExOjI5IFBNLCBLYXJhYmluLCBKb3NoDQo+IElkIGtlZXAg
dGhlIG9yaWdpbmFsIGJlaGF2aW91ciBhbmQganVzdCBkaXNhYmxlIHdpdGggQXV0b0Nvbm5lY3Qg
d2hpY2gNCg0KSSB3aWxsIGRvIHRoYXQuIEkgZmlndXJlZCB0aGUgb2RkcyB3ZXJlIHRoYXQgcGVv
cGxlIHdvdWxkIHdhbnQNCnRvIGtlZXAgdGhlIGJlaGF2aW9yIGFsb25lLCBidXQgd2Fzbid0IHN1
cmUuDQoNCj4gYnkgZGVmYXVsdCwgYWN0dWFsbHkgc2luY2UgdGhpcyBpcyBhbiBvcHRpb24gdXN1
YWxseSB3ZSBkb24ndCB1c2UNCj4gY2FtZWxjYXNlIHNvIGluc3RlYWQgaXQgc2hvdWxkIGJlIGF1
dG8tY29ubmVjdC4NCg0KVGhhbmtzIC0gSSBtaXN1bmRlcnN0b29kLCBoYXZpbmcgbG9va2VkIGF0
IGNhbWVsIGNhc2UgcHJvcGVydGllcywNCnJhdGhlciB0aGFuIGtleSBuYW1lcy4gSSB3aWxsIGZp
eCB0aGF0Lg0K

RE: [External] Re: [PATCH BlueZ 2/2] Update the Adapter1 API to match the change to ConnectDevice

[Karabin, Josh]

SGkgTHVpcywNCg0KPiBGcm9tOiBMdWl6IEF1Z3VzdG8gdm9uIERlbnR6IFttYWlsdG86bHVpei5k
ZW50ekBnbWFpbC5jb21dDQo+IA0KPiBIaSBKb3NoLA0KPiANCj4gT24gVGh1LCBBdWcgMTYsIDIw
MTggYXQgMTE6MjkgUE0sIEthcmFiaW4sIEpvc2gNCj4gPEdlb3JnZS5LYXJhYmluQGhvbmV5d2Vs
bC5jb20+IHdyb3RlOg0KPiA+ICsgICAgICAgICAgICAgICBib29sZWFuIENvbm5lY3RBbGxQcm9m
aWxlcw0KLi4uDQogDQo+IElkIGtlZXAgdGhlIG9yaWdpbmFsIGJlaGF2aW91ciBhbmQganVzdCBk
aXNhYmxlIHdpdGggQXV0b0Nvbm5lY3Qgd2hpY2gNCj4gYnkgZGVmYXVsdCwgYWN0dWFsbHkgc2lu
Y2UgdGhpcyBpcyBhbiBvcHRpb24gdXN1YWxseSB3ZSBkb24ndCB1c2UNCj4gY2FtZWxjYXNlIHNv
IGluc3RlYWQgaXQgc2hvdWxkIGJlIGF1dG8tY29ubmVjdC4NCg0KSW4gdGhlIHYyIHZlcnNpb24g
b2YgdGhlIHBhdGNoLCBJIG1hZGUgdGhlIG5ldyBVVUlEcyBrZXkgb2YgdGhlDQpDb25uZWN0RGV2
aWNlIG1ldGhvZCdzIGRpY3Rpb25hcnkgYXJndW1lbnQgdXNlIHRoZSBleGlzdGluZyBjYXNlIA0K
Q29udmVudGlvbiBvZiBVVUlEcywgcmF0aGVyIHRoYW4sIHNheSwgInV1aWRzIi4gSSBub3RpY2Vk
IHRoYXQNCk90aGVyIGtleXMgaW4gdGhhdCBkaWN0aW9uYXJ5IGFyZSBjYW1lbC1jYXNlZCwgbGlr
ZSAiQWRkcmVzcyINCmFuZCAiQWRkcmVzc1R5cGUiLCBzbyBJIHRoaW5rIHRoYXQncyB0aGUgY29y
cmVjdCBjb252ZW50aW9uLg0KDQpJIGp1c3Qgd2FudGVkIHRvIHBvaW50IHRoaXMgb3V0LCBzaW5j
ZSB5b3UgYWxyZWFkeSBtYWRlIHRoZQ0KY29tbWVudC4NCg0KVGhhbmtzLA0KDQotIEpvc2gNCg==