All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aleksandar Markovic <amarkovic@wavecomp.com>
To: Fredrik Noring <noring@nocrew.org>
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	"Petar Jovanovic" <pjovanovic@wavecomp.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Jürgen Urban" <JuergenUrban@gmx.de>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3] target/mips: Support R5900 GCC programs in user mode
Date: Tue, 11 Sep 2018 09:46:20 +0000	[thread overview]
Message-ID: <BN7PR08MB48683CDC7E04D4696EB66AA0C6040@BN7PR08MB4868.namprd08.prod.outlook.com> (raw)
In-Reply-To: <20180908142741.GA11984@r52>

> > - organize the changes in the form of patch series
> 
> What kind of granularity do you have in mind? The patch is quite small with
> 79 insertions and 1 deletion in total.

For patch organization, you may find these links useful:

https://wiki.qemu.org/Contribute/SubmitAPatch

and 

https://wiki.openstack.org/wiki/GitCommitMessages

Patch size is not the best criterium while organizing patches.

One good organization of your changes would be:

Patch 1: Add preprocessor constants INSN_R5900 and CPU_R5900
Patch 2: Amend OPC_MULT/OPC_MULTU handling for R5900
Patch 3: Update cpu_get_model() for R5900 case
Patch 4: Add defintion of R5900 CPU

This will allow us to discuss individual changes separately.

Thanks,
Aleksandar

  reply	other threads:[~2018-09-11  9:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-07 19:41 [Qemu-devel] [RFC] target/mips: Initial support for MIPS R5900 Fredrik Noring
2018-07-08 12:10 ` Fredrik Noring
2018-07-08 21:07 ` "Jürgen Urban"
2018-08-01  1:33 ` Maciej W. Rozycki
2018-08-01 13:39   ` Fredrik Noring
2018-08-01 13:54     ` Richard Henderson
2018-09-07 19:16       ` [Qemu-devel] [PATCH v2] " Fredrik Noring
2018-09-08  9:20         ` Aleksandar Markovic
2018-09-08 14:27           ` [Qemu-devel] [PATCH v3] target/mips: Support R5900 GCC programs in user mode Fredrik Noring
2018-09-11  9:46             ` Aleksandar Markovic [this message]
2018-09-08 11:31         ` [Qemu-devel] [PATCH v2] target/mips: Initial support for MIPS R5900 Maciej W. Rozycki
2018-09-12 20:23         ` Maciej W. Rozycki
2018-09-16 16:19           ` [Qemu-devel] [PATCH v3] target/mips: Support R5900 GCC programs in user mode Fredrik Noring
2018-09-08  0:03 ` [Qemu-devel] [RFC] target/mips: Initial support for MIPS R5900 Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN7PR08MB48683CDC7E04D4696EB66AA0C6040@BN7PR08MB4868.namprd08.prod.outlook.com \
    --to=amarkovic@wavecomp.com \
    --cc=JuergenUrban@gmx.de \
    --cc=aurelien@aurel32.net \
    --cc=macro@linux-mips.org \
    --cc=noring@nocrew.org \
    --cc=peter.maydell@linaro.org \
    --cc=pjovanovic@wavecomp.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.