From: "Wang, Chao-kai (Stylon)" <Stylon.Wang@amd.com>
To: "Chen, Guchun" <Guchun.Chen@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"Wentland, Harry" <Harry.Wentland@amd.com>,
"Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>,
"Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
"Yin, Tianci (Rico)" <Tianci.Yin@amd.com>,
"Chen, Jiansong (Simon)" <Jiansong.Chen@amd.com>
Subject: Re: [PATCH] drm/amd/display: avoid printing ERROR for unknown CEA parse(v2)
Date: Wed, 14 Jul 2021 13:29:22 +0000 [thread overview]
Message-ID: <BN9PR12MB5145B11D6ABBB6FA1BA28F3EFF139@BN9PR12MB5145.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210714083901.9312-1-guchun.chen@amd.com>
[-- Attachment #1.1: Type: text/plain, Size: 2424 bytes --]
[AMD Official Use Only]
Hi Guchun,
This patch looks good to me.
Regards
Stylon Wang
MTS Software Development Eng. | AMD
Display Solution Team
O +(886) 2-3789-3667 ext. 23667 C +(886) 921-897-142
----------------------------------------------------------------------------------------------------------------------------------
6F, 3, YuanCyu St (NanKang Software Park) Taipei, Taiwan
Facebook<https://www.facebook.com/AMD> | Twitter<https://twitter.com/AMD> | amd.com<http://www.amd.com/>
________________________________
From: Chen, Guchun <Guchun.Chen@amd.com>
Sent: July 14, 2021 4:39 PM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Wentland, Harry <Harry.Wentland@amd.com>; Wang, Chao-kai (Stylon) <Stylon.Wang@amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Yin, Tianci (Rico) <Tianci.Yin@amd.com>; Chen, Jiansong (Simon) <Jiansong.Chen@amd.com>
Cc: Chen, Guchun <Guchun.Chen@amd.com>
Subject: [PATCH] drm/amd/display: avoid printing ERROR for unknown CEA parse(v2)
For the unknown CEA parse case on DMUB-enabled ASICs, dmesg will
print an error message like below, this will be captured by
automation tools as it has the word like ERROR during boot up
and treated as a false error, as it does not break bootup process.
So use DRM_WARN printing for this.
[drm:amdgpu_dm_update_freesync_caps [amdgpu]] *ERROR* Unknown EDID CEA parser results
v2: Use DRM_WARN to print such info.
Signed-off-by: Guchun Chen <guchun.chen@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 03db86bfaec8..f7ed4d20d168 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -10700,7 +10700,7 @@ static bool dm_edid_parser_send_cea(struct amdgpu_display_manager *dm,
vsdb->min_refresh_rate_hz = output->amd_vsdb.min_frame_rate;
vsdb->max_refresh_rate_hz = output->amd_vsdb.max_frame_rate;
} else {
- DRM_ERROR("Unknown EDID CEA parser results\n");
+ DRM_WARN("Unknown EDID CEA parser results\n");
return false;
}
--
2.17.1
[-- Attachment #1.2: Type: text/html, Size: 7643 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-07-14 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 8:39 [PATCH] drm/amd/display: avoid printing ERROR for unknown CEA parse(v2) Guchun Chen
2021-07-14 13:29 ` Wang, Chao-kai (Stylon) [this message]
2021-07-14 15:13 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR12MB5145B11D6ABBB6FA1BA28F3EFF139@BN9PR12MB5145.namprd12.prod.outlook.com \
--to=stylon.wang@amd.com \
--cc=Guchun.Chen@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=Jiansong.Chen@amd.com \
--cc=Nicholas.Kazlauskas@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Tianci.Yin@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.