* Re: [PATCH] drm/amd/display: avoid printing ERROR for unknown CEA parse(v2)
2021-07-14 8:39 [PATCH] drm/amd/display: avoid printing ERROR for unknown CEA parse(v2) Guchun Chen
@ 2021-07-14 13:29 ` Wang, Chao-kai (Stylon)
2021-07-14 15:13 ` Harry Wentland
1 sibling, 0 replies; 3+ messages in thread
From: Wang, Chao-kai (Stylon) @ 2021-07-14 13:29 UTC (permalink / raw)
To: Chen, Guchun, amd-gfx, Wentland, Harry, Kazlauskas, Nicholas,
Siqueira, Rodrigo, Yin, Tianci (Rico), Chen, Jiansong (Simon)
[-- Attachment #1.1: Type: text/plain, Size: 2424 bytes --]
[AMD Official Use Only]
Hi Guchun,
This patch looks good to me.
Regards
Stylon Wang
MTS Software Development Eng. | AMD
Display Solution Team
O +(886) 2-3789-3667 ext. 23667 C +(886) 921-897-142
----------------------------------------------------------------------------------------------------------------------------------
6F, 3, YuanCyu St (NanKang Software Park) Taipei, Taiwan
Facebook<https://www.facebook.com/AMD> | Twitter<https://twitter.com/AMD> | amd.com<http://www.amd.com/>
________________________________
From: Chen, Guchun <Guchun.Chen@amd.com>
Sent: July 14, 2021 4:39 PM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Wentland, Harry <Harry.Wentland@amd.com>; Wang, Chao-kai (Stylon) <Stylon.Wang@amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Yin, Tianci (Rico) <Tianci.Yin@amd.com>; Chen, Jiansong (Simon) <Jiansong.Chen@amd.com>
Cc: Chen, Guchun <Guchun.Chen@amd.com>
Subject: [PATCH] drm/amd/display: avoid printing ERROR for unknown CEA parse(v2)
For the unknown CEA parse case on DMUB-enabled ASICs, dmesg will
print an error message like below, this will be captured by
automation tools as it has the word like ERROR during boot up
and treated as a false error, as it does not break bootup process.
So use DRM_WARN printing for this.
[drm:amdgpu_dm_update_freesync_caps [amdgpu]] *ERROR* Unknown EDID CEA parser results
v2: Use DRM_WARN to print such info.
Signed-off-by: Guchun Chen <guchun.chen@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 03db86bfaec8..f7ed4d20d168 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -10700,7 +10700,7 @@ static bool dm_edid_parser_send_cea(struct amdgpu_display_manager *dm,
vsdb->min_refresh_rate_hz = output->amd_vsdb.min_frame_rate;
vsdb->max_refresh_rate_hz = output->amd_vsdb.max_frame_rate;
} else {
- DRM_ERROR("Unknown EDID CEA parser results\n");
+ DRM_WARN("Unknown EDID CEA parser results\n");
return false;
}
--
2.17.1
[-- Attachment #1.2: Type: text/html, Size: 7643 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amd/display: avoid printing ERROR for unknown CEA parse(v2)
2021-07-14 8:39 [PATCH] drm/amd/display: avoid printing ERROR for unknown CEA parse(v2) Guchun Chen
2021-07-14 13:29 ` Wang, Chao-kai (Stylon)
@ 2021-07-14 15:13 ` Harry Wentland
1 sibling, 0 replies; 3+ messages in thread
From: Harry Wentland @ 2021-07-14 15:13 UTC (permalink / raw)
To: Guchun Chen, amd-gfx, stylon.wang, Nicholas.Kazlauskas,
Rodrigo.Siqueira, tianci.yin, jiansong.chen
On 2021-07-14 4:39 a.m., Guchun Chen wrote:
> For the unknown CEA parse case on DMUB-enabled ASICs, dmesg will
> print an error message like below, this will be captured by
> automation tools as it has the word like ERROR during boot up
> and treated as a false error, as it does not break bootup process.
> So use DRM_WARN printing for this.
>
> [drm:amdgpu_dm_update_freesync_caps [amdgpu]] *ERROR* Unknown EDID CEA parser results
>
> v2: Use DRM_WARN to print such info.
>
> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 03db86bfaec8..f7ed4d20d168 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -10700,7 +10700,7 @@ static bool dm_edid_parser_send_cea(struct amdgpu_display_manager *dm,
> vsdb->min_refresh_rate_hz = output->amd_vsdb.min_frame_rate;
> vsdb->max_refresh_rate_hz = output->amd_vsdb.max_frame_rate;
> } else {
> - DRM_ERROR("Unknown EDID CEA parser results\n");
> + DRM_WARN("Unknown EDID CEA parser results\n");
> return false;
> }
>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread