FAILED: patch "[PATCH] Drivers: hv: vmbus: Don't wait after requesting offers" failed to apply to 4.0-stable tree

FAILED: patch "[PATCH] Drivers: hv: vmbus: Don't wait after requesting offers" failed to apply to 4.0-stable tree

[gregkh]

The patch below does not apply to the 4.0-stable tree.
If someone wants it applied there, or to any other stable or longterm
tree, then please email the backport, including the original git commit
id to <stable@vger.kernel.org>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

>From 73cffdb65e679b98893f484063462c045adcf212 Mon Sep 17 00:00:00 2001
From: "K. Y. Srinivasan" <kys@microsoft.com>
Date: Thu, 19 Mar 2015 08:11:34 -0700
Subject: [PATCH] Drivers: hv: vmbus: Don't wait after requesting offers

Don't wait after sending request for offers to the host. This wait is
unnecessary and simply adds 5 seconds to the boot time.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index 25dbbaf42266..bb39705a89d9 100644
--- a/drivers/hv/channel_mgmt.c
+++ b/drivers/hv/channel_mgmt.c
@@ -884,7 +884,6 @@ int vmbus_request_offers(void)
 	struct vmbus_channel_message_header *msg;
 	struct vmbus_channel_msginfo *msginfo;
 	int ret;
-	unsigned long t;
 
 	msginfo = kmalloc(sizeof(*msginfo) +
 			  sizeof(struct vmbus_channel_message_header),
@@ -892,8 +891,6 @@ int vmbus_request_offers(void)
 	if (!msginfo)
 		return -ENOMEM;
 
-	init_completion(&msginfo->waitevent);
-
 	msg = (struct vmbus_channel_message_header *)msginfo->msg;
 
 	msg->msgtype = CHANNELMSG_REQUESTOFFERS;
@@ -907,14 +904,6 @@ int vmbus_request_offers(void)
 		goto cleanup;
 	}
 
-	t = wait_for_completion_timeout(&msginfo->waitevent, 5*HZ);
-	if (t == 0) {
-		ret = -ETIMEDOUT;
-		goto cleanup;
-	}
-
-
-
 cleanup:
 	kfree(msginfo);
 

RE: FAILED: patch "[PATCH] Drivers: hv: vmbus: Don't wait after requesting offers" failed to apply to 4.0-stable tree

[KY Srinivasan]

> -----Original Message-----
> From: gregkh@linuxfoundation.org [mailto:gregkh@linuxfoundation.org]
> Sent: Saturday, May 2, 2015 10:06 AM
> To: KY Srinivasan; gregkh@linuxfoundation.org; stable@vger.kernel.org
> Cc: stable@vger.kernel.org
> Subject: FAILED: patch "[PATCH] Drivers: hv: vmbus: Don't wait after
> requesting offers" failed to apply to 4.0-stable tree
> 
> 
> The patch below does not apply to the 4.0-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git commit
> id to <stable@vger.kernel.org>.

Greg,

I have resent the patch with the fix to apply against the 4.0 tree.

Thanks,

K. Y
> 
> thanks,
> 
> greg k-h
> 
> ------------------ original commit in Linus's tree ------------------
> 
> From 73cffdb65e679b98893f484063462c045adcf212 Mon Sep 17 00:00:00 2001
> From: "K. Y. Srinivasan" <kys@microsoft.com>
> Date: Thu, 19 Mar 2015 08:11:34 -0700
> Subject: [PATCH] Drivers: hv: vmbus: Don't wait after requesting offers
> 
> Don't wait after sending request for offers to the host. This wait is
> unnecessary and simply adds 5 seconds to the boot time.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
> index 25dbbaf42266..bb39705a89d9 100644
> --- a/drivers/hv/channel_mgmt.c
> +++ b/drivers/hv/channel_mgmt.c
> @@ -884,7 +884,6 @@ int vmbus_request_offers(void)
>  	struct vmbus_channel_message_header *msg;
>  	struct vmbus_channel_msginfo *msginfo;
>  	int ret;
> -	unsigned long t;
> 
>  	msginfo = kmalloc(sizeof(*msginfo) +
>  			  sizeof(struct vmbus_channel_message_header),
> @@ -892,8 +891,6 @@ int vmbus_request_offers(void)
>  	if (!msginfo)
>  		return -ENOMEM;
> 
> -	init_completion(&msginfo->waitevent);
> -
>  	msg = (struct vmbus_channel_message_header *)msginfo->msg;
> 
>  	msg->msgtype = CHANNELMSG_REQUESTOFFERS;
> @@ -907,14 +904,6 @@ int vmbus_request_offers(void)
>  		goto cleanup;
>  	}
> 
> -	t = wait_for_completion_timeout(&msginfo->waitevent, 5*HZ);
> -	if (t == 0) {
> -		ret = -ETIMEDOUT;
> -		goto cleanup;
> -	}
> -
> -
> -
>  cleanup:
>  	kfree(msginfo);
>