From: Manoil Claudiu <claudiu.manoil@freescale.com> To: Arnd Bergmann <arnd@arndb.de>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Scott Wood <scottwood@freescale.com> Subject: RE: [PATCH] gianfar: Fix warnings when built on 64-bit Date: Wed, 29 Jul 2015 08:41:29 +0000 [thread overview] Message-ID: <BY2PR0301MB072721F7AD52766A864FC79E9C8C0@BY2PR0301MB0727.namprd03.prod.outlook.com> (raw) In-Reply-To: <4498062.4y369pLSmO@wuerfel> > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Wednesday, July 29, 2015 11:02 AM > To: linuxppc-dev@lists.ozlabs.org; netdev@vger.kernel.org; Manoil Claudiu- > B08782; Wood Scott-B07421 > Subject: Re: [PATCH] gianfar: Fix warnings when built on 64-bit > > On Wednesday 29 July 2015 00:24:37 Scott Wood wrote: > > > Alternatively, if there's a desire to not mess with this code (I don't > > know how to trigger this code path to test it), this driver should be > > given dependencies that ensure that it only builds on 32-bit. > > These are obvious fixes, they should definitely go in. This patch conflicts with the rx s/g patch series: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=9061cb023567abf081569d6851b0815dd18437e6 So if applied as it is on top of net.git it will give a headache when net-next.git will be merged into net.git (or vice versa). Since there are no 64-bit systems with gianfar/ eTSEC, I think that this patch should target net-next.git (reworked to be applicable on net-next.git) to avoid the conflict. I could do this rework and resend it on top of net-next.git > > > drivers/net/ethernet/freescale/gianfar.c | 22 ++++++++++++++++++---- > > 1 file changed, 18 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/ethernet/freescale/gianfar.c > b/drivers/net/ethernet/freescale/gianfar.c > > index ff87502..7c682ac 100644 > > --- a/drivers/net/ethernet/freescale/gianfar.c > > +++ b/drivers/net/ethernet/freescale/gianfar.c > > @@ -565,6 +565,7 @@ static void gfar_ints_enable(struct gfar_private > *priv) > > } > > } > > > > +#ifdef CONFIG_PM > > static void lock_tx_qs(struct gfar_private *priv) > > { > > int i; > > @@ -580,6 +581,7 @@ static void unlock_tx_qs(struct gfar_private *priv) > > for (i = 0; i < priv->num_tx_queues; i++) > > spin_unlock(&priv->tx_queue[i]->txlock); > > } > > +#endif > > > > This seems unrelated and should probably be a separate fix. > I'm working at a patch set to revive/ cleanup the power management code, and lock_tx_qs() is planned to be removed (it can be shown that it's not needed). So this change can be remove from this patch. Thanks, Claudiu [...]
WARNING: multiple messages have this Message-ID (diff)
From: Manoil Claudiu <claudiu.manoil@freescale.com> To: Arnd Bergmann <arnd@arndb.de>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Scott Wood <scottwood@freescale.com> Subject: RE: [PATCH] gianfar: Fix warnings when built on 64-bit Date: Wed, 29 Jul 2015 08:41:29 +0000 [thread overview] Message-ID: <BY2PR0301MB072721F7AD52766A864FC79E9C8C0@BY2PR0301MB0727.namprd03.prod.outlook.com> (raw) In-Reply-To: <4498062.4y369pLSmO@wuerfel> > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Wednesday, July 29, 2015 11:02 AM > To: linuxppc-dev@lists.ozlabs.org; netdev@vger.kernel.org; Manoil Claudiu= - > B08782; Wood Scott-B07421 > Subject: Re: [PATCH] gianfar: Fix warnings when built on 64-bit >=20 > On Wednesday 29 July 2015 00:24:37 Scott Wood wrote: >=20 > > Alternatively, if there's a desire to not mess with this code (I don't > > know how to trigger this code path to test it), this driver should be > > given dependencies that ensure that it only builds on 32-bit. >=20 > These are obvious fixes, they should definitely go in. This patch conflicts with the rx s/g patch series: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id= =3D9061cb023567abf081569d6851b0815dd18437e6 So if applied as it is on top of net.git it will give a headache when net-n= ext.git will be merged into net.git (or vice versa). Since there are no 64-bit systems with gianfar/ eTSEC, I think that this pa= tch should target net-next.git (reworked to be applicable on net-next.git) to a= void the conflict. I could do this rework and resend it on top of net-next.git >=20 > > drivers/net/ethernet/freescale/gianfar.c | 22 ++++++++++++++++++---- > > 1 file changed, 18 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/ethernet/freescale/gianfar.c > b/drivers/net/ethernet/freescale/gianfar.c > > index ff87502..7c682ac 100644 > > --- a/drivers/net/ethernet/freescale/gianfar.c > > +++ b/drivers/net/ethernet/freescale/gianfar.c > > @@ -565,6 +565,7 @@ static void gfar_ints_enable(struct gfar_private > *priv) > > } > > } > > > > +#ifdef CONFIG_PM > > static void lock_tx_qs(struct gfar_private *priv) > > { > > int i; > > @@ -580,6 +581,7 @@ static void unlock_tx_qs(struct gfar_private *priv) > > for (i =3D 0; i < priv->num_tx_queues; i++) > > spin_unlock(&priv->tx_queue[i]->txlock); > > } > > +#endif > > >=20 > This seems unrelated and should probably be a separate fix. >=20 I'm working at a patch set to revive/ cleanup the power management code, and lock_tx_qs() is planned to be removed (it can be shown that it's not ne= eded). So this change can be remove from this patch. Thanks, Claudiu [...]
next prev parent reply other threads:[~2015-07-29 8:41 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-29 5:24 [PATCH] gianfar: Fix warnings when built on 64-bit Scott Wood 2015-07-29 8:02 ` Arnd Bergmann 2015-07-29 8:41 ` Manoil Claudiu [this message] 2015-07-29 8:41 ` Manoil Claudiu 2015-07-29 11:03 ` Manoil Claudiu 2015-07-29 11:03 ` Manoil Claudiu 2015-07-29 16:02 ` Scott Wood 2015-07-29 16:02 ` Scott Wood 2015-07-29 21:04 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BY2PR0301MB072721F7AD52766A864FC79E9C8C0@BY2PR0301MB0727.namprd03.prod.outlook.com \ --to=claudiu.manoil@freescale.com \ --cc=arnd@arndb.de \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=netdev@vger.kernel.org \ --cc=scottwood@freescale.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.