From: "Igal.Liberman-KZfg59tc24xl57MIdRCFDg@public.gmane.org" <Igal.Liberman-KZfg59tc24xl57MIdRCFDg@public.gmane.org> To: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>, Yuantian Tang <Yuantian.Tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Subject: RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux Date: Tue, 5 May 2015 21:02:27 +0000 [thread overview] Message-ID: <BY2PR03MB3794413FB3FF795DF520D23E6D10@BY2PR03MB379.namprd03.prod.outlook.com> (raw) In-Reply-To: <1430523775.16357.177.camel-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Regards, Igal Liberman. > -----Original Message----- > From: Wood Scott-B07421 > Sent: Saturday, May 02, 2015 2:43 AM > To: Liberman Igal-B31950 > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Tang > Yuantian-B29983 > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux > > On Thu, 2015-04-30 at 09:28 -0500, Liberman Igal-B31950 wrote: > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Thursday, April 30, 2015 3:31 AM > > > To: Liberman Igal-B31950 > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Tang > > > Yuantian-B29983 > > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan > > > clock mux > > > > > > On Wed, 2015-04-22 at 05:47 -0500, Liberman Igal-B31950 wrote: > > > > We have 2 cases: > > > > - Devices (T2/T4/B4) with CLKCG1HWACSR register. > > > > - Devices (Pxxxx, T1) without CLKCG1HWACSR register (Pxxxx > > > devices > > > > have many options, T1 has only one option) > > > > > > > > For the first group, we can have " qoriq-hwacsr" property in the clock > node. > > > > > > No, we're not going to describe every register with its own property. > > > Describe the chip and let the driver be the place with the knowledge > > > of what each chip is like. > > > > > > > I think that FMan clock mux (as we defined it) is similar to other muxes > available in our SoC. > > I realize that. I'm saying the way we described existing muxes seems to be a > mistake. We're putting too much complexity in the device tree. > Better to put the complexity in a place that isn't stable ABI. > > > If we take T4 as example, it has 3 muxes defined in the device tree (mux0, > mux1 and mux2). > > Each mux has its own reg property (and clock providers). > > mux2: mux2@40 { > > #clock-cells = <0>; > > reg = <0x40 0x4>; > > compatible = "fsl,qoriq-core-mux-2.0"; > > clocks = <&pll3 0>, <&pll3 1>, <&pll3 2>, > > <&pll4 0>, <&pll4 1>, <&pll4 2>; > > clock-names = "pll3", "pll3-div2", "pll3-div4", > > "pll4", "pll4-div2", "pll4-div4"; > > clock-output-names = "cmux2"; > > }; > > > > I agree that "fm1-clk-mux" need to be moved from the "guts" node to > "clockgen" node. > > That's not what I was saying. I'm saying get rid of the node entirely, in favor > of having the clockgen node itself be a clock source with multiple post-mux > outputs. > Scott, Currently the clockgen node has a number of sub nodes (platform clock, sysclock, PLLs and muxes, the number of muxes/PLLs is SoC dependent). The clockgen node has reg property, however, all other nodes have reg property too (The clockgen points to the clocking block address and the sub nodes point to the specific register in the clock block). Do you want to change this structure completely? I'm not sure I understand the exact way you want see those nodes (in the final state). > > However, I'm not sure which changes you want to perform in the node > (beside adding reg property for SoC which has it for FMan clock). > > Again, the clockgen node already has a reg property. > > -Scott >
WARNING: multiple messages have this Message-ID (diff)
From: "Igal.Liberman@freescale.com" <Igal.Liberman@freescale.com> To: Scott Wood <scottwood@freescale.com> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, Yuantian Tang <Yuantian.Tang@freescale.com> Subject: RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux Date: Tue, 5 May 2015 21:02:27 +0000 [thread overview] Message-ID: <BY2PR03MB3794413FB3FF795DF520D23E6D10@BY2PR03MB379.namprd03.prod.outlook.com> (raw) In-Reply-To: <1430523775.16357.177.camel@freescale.com> DQoNClJlZ2FyZHMsDQpJZ2FsIExpYmVybWFuLg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t LS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+IFNlbnQ6IFNhdHVyZGF5LCBNYXkgMDIs IDIwMTUgMjo0MyBBTQ0KPiBUbzogTGliZXJtYW4gSWdhbC1CMzE5NTANCj4gQ2M6IGRldmljZXRy ZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsgVGFuZw0K PiBZdWFudGlhbi1CMjk5ODMNCj4gU3ViamVjdDogUmU6IFt2M10gZHQvYmluZGluZ3M6IHFvcmlx LWNsb2NrOiBBZGQgYmluZGluZyBmb3IgRk1hbiBjbG9jayBtdXgNCj4gDQo+IE9uIFRodSwgMjAx NS0wNC0zMCBhdCAwOToyOCAtMDUwMCwgTGliZXJtYW4gSWdhbC1CMzE5NTAgd3JvdGU6DQo+ID4g PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTogV29vZCBTY290dC1CMDc0 MjENCj4gPiA+IFNlbnQ6IFRodXJzZGF5LCBBcHJpbCAzMCwgMjAxNSAzOjMxIEFNDQo+ID4gPiBU bzogTGliZXJtYW4gSWdhbC1CMzE5NTANCj4gPiA+IENjOiBkZXZpY2V0cmVlQHZnZXIua2VybmVs Lm9yZzsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IFRhbmcNCj4gPiA+IFl1YW50aWFu LUIyOTk4Mw0KPiA+ID4gU3ViamVjdDogUmU6IFt2M10gZHQvYmluZGluZ3M6IHFvcmlxLWNsb2Nr OiBBZGQgYmluZGluZyBmb3IgRk1hbg0KPiA+ID4gY2xvY2sgbXV4DQo+ID4gPg0KPiA+ID4gT24g V2VkLCAyMDE1LTA0LTIyIGF0IDA1OjQ3IC0wNTAwLCBMaWJlcm1hbiBJZ2FsLUIzMTk1MCB3cm90 ZToNCj4gPiA+ID4gV2UgaGF2ZSAyIGNhc2VzOg0KPiA+ID4gPiAJLSBEZXZpY2VzIChUMi9UNC9C NCkgd2l0aCBDTEtDRzFIV0FDU1IgcmVnaXN0ZXIuDQo+ID4gPiA+IAktIERldmljZXMgKFB4eHh4 LCBUMSkgd2l0aG91dCBDTEtDRzFIV0FDU1IgcmVnaXN0ZXIgKFB4eHh4DQo+ID4gPiBkZXZpY2Vz DQo+ID4gPiA+IGhhdmUgbWFueSBvcHRpb25zLCBUMSBoYXMgb25seSBvbmUgb3B0aW9uKQ0KPiA+ ID4gPg0KPiA+ID4gPiBGb3IgdGhlIGZpcnN0IGdyb3VwLCB3ZSBjYW4gaGF2ZSAiIHFvcmlxLWh3 YWNzciIgcHJvcGVydHkgaW4gdGhlIGNsb2NrDQo+IG5vZGUuDQo+ID4gPg0KPiA+ID4gTm8sIHdl J3JlIG5vdCBnb2luZyB0byBkZXNjcmliZSBldmVyeSByZWdpc3RlciB3aXRoIGl0cyBvd24gcHJv cGVydHkuDQo+ID4gPiBEZXNjcmliZSB0aGUgY2hpcCBhbmQgbGV0IHRoZSBkcml2ZXIgYmUgdGhl IHBsYWNlIHdpdGggdGhlIGtub3dsZWRnZQ0KPiA+ID4gb2Ygd2hhdCBlYWNoIGNoaXAgaXMgbGlr ZS4NCj4gPiA+DQo+ID4NCj4gPiBJIHRoaW5rIHRoYXQgRk1hbiBjbG9jayBtdXggKGFzIHdlIGRl ZmluZWQgaXQpIGlzIHNpbWlsYXIgdG8gb3RoZXIgbXV4ZXMNCj4gYXZhaWxhYmxlIGluIG91ciBT b0MuDQo+IA0KPiBJIHJlYWxpemUgdGhhdC4gIEknbSBzYXlpbmcgdGhlIHdheSB3ZSBkZXNjcmli ZWQgZXhpc3RpbmcgbXV4ZXMgc2VlbXMgdG8gYmUgYQ0KPiBtaXN0YWtlLiAgV2UncmUgcHV0dGlu ZyB0b28gbXVjaCBjb21wbGV4aXR5IGluIHRoZSBkZXZpY2UgdHJlZS4NCj4gQmV0dGVyIHRvIHB1 dCB0aGUgY29tcGxleGl0eSBpbiBhIHBsYWNlIHRoYXQgaXNuJ3Qgc3RhYmxlIEFCSS4NCj4gDQo+ ID4gSWYgd2UgdGFrZSBUNCBhcyBleGFtcGxlLCBpdCBoYXMgMyBtdXhlcyBkZWZpbmVkIGluIHRo ZSBkZXZpY2UgdHJlZSAobXV4MCwNCj4gbXV4MSBhbmQgbXV4MikuDQo+ID4gRWFjaCBtdXggaGFz IGl0cyBvd24gcmVnIHByb3BlcnR5IChhbmQgY2xvY2sgcHJvdmlkZXJzKS4NCj4gPiAJbXV4Mjog bXV4MkA0MCB7DQo+ID4gCQkjY2xvY2stY2VsbHMgPSA8MD47DQo+ID4gCQlyZWcgPSA8MHg0MCAw eDQ+Ow0KPiA+IAkJY29tcGF0aWJsZSA9ICJmc2wscW9yaXEtY29yZS1tdXgtMi4wIjsNCj4gPiAJ CWNsb2NrcyA9IDwmcGxsMyAwPiwgPCZwbGwzIDE+LCA8JnBsbDMgMj4sDQo+ID4gCQkJPCZwbGw0 IDA+LCA8JnBsbDQgMT4sIDwmcGxsNCAyPjsNCj4gPiAJCWNsb2NrLW5hbWVzID0gInBsbDMiLCAi cGxsMy1kaXYyIiwgInBsbDMtZGl2NCIsDQo+ID4gCQkJInBsbDQiLCAicGxsNC1kaXYyIiwgInBs bDQtZGl2NCI7DQo+ID4gCQljbG9jay1vdXRwdXQtbmFtZXMgPSAiY211eDIiOw0KPiA+IAl9Ow0K PiA+DQo+ID4gSSBhZ3JlZSB0aGF0ICJmbTEtY2xrLW11eCIgbmVlZCB0byBiZSBtb3ZlZCBmcm9t IHRoZSAiZ3V0cyIgbm9kZSB0bw0KPiAiY2xvY2tnZW4iIG5vZGUuDQo+IA0KPiBUaGF0J3Mgbm90 IHdoYXQgSSB3YXMgc2F5aW5nLiAgSSdtIHNheWluZyBnZXQgcmlkIG9mIHRoZSBub2RlIGVudGly ZWx5LCBpbiBmYXZvcg0KPiBvZiBoYXZpbmcgdGhlIGNsb2NrZ2VuIG5vZGUgaXRzZWxmIGJlIGEg Y2xvY2sgc291cmNlIHdpdGggbXVsdGlwbGUgcG9zdC1tdXgNCj4gb3V0cHV0cy4NCj4gDQoNClNj b3R0LA0KQ3VycmVudGx5IHRoZSBjbG9ja2dlbiBub2RlIGhhcyBhIG51bWJlciBvZiBzdWIgbm9k ZXMgKHBsYXRmb3JtIGNsb2NrLCBzeXNjbG9jaywgUExMcyBhbmQgbXV4ZXMsIHRoZSBudW1iZXIg b2YgbXV4ZXMvUExMcyBpcyBTb0MgZGVwZW5kZW50KS4NClRoZSBjbG9ja2dlbiBub2RlIGhhcyBy ZWcgcHJvcGVydHksIGhvd2V2ZXIsIGFsbCBvdGhlciBub2RlcyBoYXZlIHJlZyBwcm9wZXJ0eSB0 b28gKFRoZSBjbG9ja2dlbiBwb2ludHMgdG8gdGhlIGNsb2NraW5nIGJsb2NrIGFkZHJlc3MgYW5k IHRoZSBzdWIgbm9kZXMgcG9pbnQgdG8gdGhlIHNwZWNpZmljIHJlZ2lzdGVyIGluIHRoZSBjbG9j ayBibG9jaykuDQpEbyB5b3Ugd2FudCB0byBjaGFuZ2UgdGhpcyBzdHJ1Y3R1cmUgY29tcGxldGVs eT8NCkknbSBub3Qgc3VyZSBJIHVuZGVyc3RhbmQgdGhlIGV4YWN0IHdheSB5b3Ugd2FudCBzZWUg dGhvc2Ugbm9kZXMgKGluIHRoZSBmaW5hbCBzdGF0ZSkuDQoNCj4gPiBIb3dldmVyLCBJJ20gbm90 IHN1cmUgd2hpY2ggY2hhbmdlcyB5b3Ugd2FudCB0byBwZXJmb3JtIGluIHRoZSBub2RlDQo+IChi ZXNpZGUgYWRkaW5nIHJlZyBwcm9wZXJ0eSBmb3IgU29DIHdoaWNoIGhhcyBpdCBmb3IgRk1hbiBj bG9jaykuDQo+IA0KPiBBZ2FpbiwgdGhlIGNsb2NrZ2VuIG5vZGUgYWxyZWFkeSBoYXMgYSByZWcg cHJvcGVydHkuDQo+IA0KPiAtU2NvdHQNCj4gDQoNCg==
next prev parent reply other threads:[~2015-05-05 21:02 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-14 10:56 [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux Igal.Liberman 2015-04-14 10:56 ` Igal.Liberman 2015-04-15 17:35 ` Scott Wood 2015-04-15 17:35 ` Scott Wood [not found] ` <1429119357.22867.724.camel-KZfg59tc24xl57MIdRCFDg@public.gmane.org> 2015-04-16 6:11 ` Igal.Liberman-KZfg59tc24xl57MIdRCFDg 2015-04-16 6:11 ` Igal.Liberman [not found] ` <DM2PR03MB38330DBBFFD1BC45D58F447E6E40-ufbTtyGzTTRJonC5hhDUuuO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org> 2015-04-17 5:41 ` Scott Wood 2015-04-17 5:41 ` Scott Wood [not found] ` <1429249281.32545.52.camel-KZfg59tc24xl57MIdRCFDg@public.gmane.org> 2015-04-20 11:07 ` Igal.Liberman-KZfg59tc24xl57MIdRCFDg 2015-04-20 11:07 ` Igal.Liberman 2015-04-20 11:40 ` Igal.Liberman-KZfg59tc24xl57MIdRCFDg 2015-04-20 11:40 ` Igal.Liberman [not found] ` <DM2PR03MB383E5F67C358CCE2E38EA71E6E00-ufbTtyGzTTRJonC5hhDUuuO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org> 2015-04-21 0:51 ` Scott Wood 2015-04-21 0:51 ` Scott Wood [not found] ` <1429577504.4352.67.camel-KZfg59tc24xl57MIdRCFDg@public.gmane.org> 2015-04-22 10:47 ` Igal.Liberman-KZfg59tc24xl57MIdRCFDg 2015-04-22 10:47 ` Igal.Liberman [not found] ` <DM2PR03MB383C35FA5959662DD48D00BE6EE0-ufbTtyGzTTRJonC5hhDUuuO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org> 2015-04-30 0:30 ` Scott Wood 2015-04-30 0:30 ` Scott Wood [not found] ` <1430353832.16357.138.camel-KZfg59tc24xl57MIdRCFDg@public.gmane.org> 2015-04-30 14:28 ` Igal.Liberman-KZfg59tc24xl57MIdRCFDg 2015-04-30 14:28 ` Igal.Liberman [not found] ` <DM2PR03MB3839C9D3FDFD7978C1A3497E6D60-ufbTtyGzTTRJonC5hhDUuuO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org> 2015-05-01 23:42 ` Scott Wood 2015-05-01 23:42 ` Scott Wood [not found] ` <1430523775.16357.177.camel-KZfg59tc24xl57MIdRCFDg@public.gmane.org> 2015-05-05 21:02 ` Igal.Liberman-KZfg59tc24xl57MIdRCFDg [this message] 2015-05-05 21:02 ` Igal.Liberman [not found] ` <BY2PR03MB3794413FB3FF795DF520D23E6D10-+7O3WWA3DPtn35zppGJRk+O6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org> 2015-05-05 21:16 ` Scott Wood 2015-05-05 21:16 ` Scott Wood
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BY2PR03MB3794413FB3FF795DF520D23E6D10@BY2PR03MB379.namprd03.prod.outlook.com \ --to=igal.liberman-kzfg59tc24xl57midrcfdg@public.gmane.org \ --cc=Yuantian.Tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \ --cc=scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.