* [PATCH libdrm] amdgpu: amdgpu_bo_inc_ref don't return dummy int
@ 2018-09-03 10:06 Qiang Yu
[not found] ` <1535969162-28716-1-git-send-email-Qiang.Yu-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Qiang Yu @ 2018-09-03 10:06 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Jerry Zhang, Qiang Yu, Michel Dänzer, Christian König,
Hui Deng
Signed-off-by: Qiang Yu <Qiang.Yu@amd.com>
---
amdgpu/amdgpu-symbol-check | 2 +-
amdgpu/amdgpu.h | 5 +----
amdgpu/amdgpu_bo.c | 3 +--
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/amdgpu/amdgpu-symbol-check b/amdgpu/amdgpu-symbol-check
index 487610e..58646e8 100755
--- a/amdgpu/amdgpu-symbol-check
+++ b/amdgpu/amdgpu-symbol-check
@@ -15,8 +15,8 @@ amdgpu_bo_cpu_map
amdgpu_bo_cpu_unmap
amdgpu_bo_export
amdgpu_bo_free
-amdgpu_bo_inc_ref
amdgpu_bo_import
+amdgpu_bo_inc_ref
amdgpu_bo_list_create
amdgpu_bo_list_destroy
amdgpu_bo_list_update
diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h
index e1f93f8..dc51659 100644
--- a/amdgpu/amdgpu.h
+++ b/amdgpu/amdgpu.h
@@ -725,13 +725,10 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle);
*
* \param bo - \c [in] Buffer object handle to increase the reference count
*
- * \return 0 on success\n
- * <0 - Negative POSIX Error code
- *
* \sa amdgpu_bo_alloc(), amdgpu_bo_free()
*
*/
-int amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
+void amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
/**
* Request CPU access to GPU accessable memory
diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
index dceab01..6a95929 100644
--- a/amdgpu/amdgpu_bo.c
+++ b/amdgpu/amdgpu_bo.c
@@ -438,10 +438,9 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle)
return 0;
}
-int amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
+void amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
{
atomic_inc(&bo->refcount);
- return 0;
}
int amdgpu_bo_cpu_map(amdgpu_bo_handle bo, void **cpu)
--
1.9.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH libdrm] amdgpu: amdgpu_bo_inc_ref don't return dummy int
[not found] ` <1535969162-28716-1-git-send-email-Qiang.Yu-5C7GfCeVMHo@public.gmane.org>
@ 2018-09-03 10:13 ` Michel Dänzer
[not found] ` <387fe239-c0d6-b2c1-5f95-b49877e38852-otUistvHUpPR7s880joybQ@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Michel Dänzer @ 2018-09-03 10:13 UTC (permalink / raw)
To: Qiang Yu
Cc: Jerry Zhang, Christian König,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Hui Deng
On 2018-09-03 12:06 p.m., Qiang Yu wrote:
> Signed-off-by: Qiang Yu <Qiang.Yu@amd.com>
> ---
> amdgpu/amdgpu-symbol-check | 2 +-
> amdgpu/amdgpu.h | 5 +----
> amdgpu/amdgpu_bo.c | 3 +--
> 3 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/amdgpu/amdgpu-symbol-check b/amdgpu/amdgpu-symbol-check
> index 487610e..58646e8 100755
> --- a/amdgpu/amdgpu-symbol-check
> +++ b/amdgpu/amdgpu-symbol-check
> @@ -15,8 +15,8 @@ amdgpu_bo_cpu_map
> amdgpu_bo_cpu_unmap
> amdgpu_bo_export
> amdgpu_bo_free
> -amdgpu_bo_inc_ref
> amdgpu_bo_import
> +amdgpu_bo_inc_ref
> amdgpu_bo_list_create
> amdgpu_bo_list_destroy
> amdgpu_bo_list_update
> diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h
> index e1f93f8..dc51659 100644
> --- a/amdgpu/amdgpu.h
> +++ b/amdgpu/amdgpu.h
> @@ -725,13 +725,10 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle);
> *
> * \param bo - \c [in] Buffer object handle to increase the reference count
> *
> - * \return 0 on success\n
> - * <0 - Negative POSIX Error code
> - *
> * \sa amdgpu_bo_alloc(), amdgpu_bo_free()
> *
> */
> -int amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
> +void amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
>
> /**
> * Request CPU access to GPU accessable memory
> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
> index dceab01..6a95929 100644
> --- a/amdgpu/amdgpu_bo.c
> +++ b/amdgpu/amdgpu_bo.c
> @@ -438,10 +438,9 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle)
> return 0;
> }
>
> -int amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
> +void amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
> {
> atomic_inc(&bo->refcount);
> - return 0;
> }
>
> int amdgpu_bo_cpu_map(amdgpu_bo_handle bo, void **cpu)
>
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH libdrm] amdgpu: amdgpu_bo_inc_ref don't return dummy int
[not found] ` <387fe239-c0d6-b2c1-5f95-b49877e38852-otUistvHUpPR7s880joybQ@public.gmane.org>
@ 2018-09-03 10:40 ` Christian König
[not found] ` <4b37db56-172c-87e0-29f7-3e3f4dd04252-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Christian König @ 2018-09-03 10:40 UTC (permalink / raw)
To: Michel Dänzer, Qiang Yu
Cc: Jerry Zhang, Christian König,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Hui Deng
Am 03.09.2018 um 12:13 schrieb Michel Dänzer:
> On 2018-09-03 12:06 p.m., Qiang Yu wrote:
>> Signed-off-by: Qiang Yu <Qiang.Yu@amd.com>
>> ---
>> amdgpu/amdgpu-symbol-check | 2 +-
>> amdgpu/amdgpu.h | 5 +----
>> amdgpu/amdgpu_bo.c | 3 +--
>> 3 files changed, 3 insertions(+), 7 deletions(-)
>>
>> diff --git a/amdgpu/amdgpu-symbol-check b/amdgpu/amdgpu-symbol-check
>> index 487610e..58646e8 100755
>> --- a/amdgpu/amdgpu-symbol-check
>> +++ b/amdgpu/amdgpu-symbol-check
>> @@ -15,8 +15,8 @@ amdgpu_bo_cpu_map
>> amdgpu_bo_cpu_unmap
>> amdgpu_bo_export
>> amdgpu_bo_free
>> -amdgpu_bo_inc_ref
>> amdgpu_bo_import
>> +amdgpu_bo_inc_ref
>> amdgpu_bo_list_create
>> amdgpu_bo_list_destroy
>> amdgpu_bo_list_update
>> diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h
>> index e1f93f8..dc51659 100644
>> --- a/amdgpu/amdgpu.h
>> +++ b/amdgpu/amdgpu.h
>> @@ -725,13 +725,10 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle);
>> *
>> * \param bo - \c [in] Buffer object handle to increase the reference count
>> *
>> - * \return 0 on success\n
>> - * <0 - Negative POSIX Error code
>> - *
>> * \sa amdgpu_bo_alloc(), amdgpu_bo_free()
>> *
>> */
>> -int amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
>> +void amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
>>
>> /**
>> * Request CPU access to GPU accessable memory
>> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
>> index dceab01..6a95929 100644
>> --- a/amdgpu/amdgpu_bo.c
>> +++ b/amdgpu/amdgpu_bo.c
>> @@ -438,10 +438,9 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle)
>> return 0;
>> }
>>
>> -int amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
>> +void amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
>> {
>> atomic_inc(&bo->refcount);
>> - return 0;
>> }
>>
>> int amdgpu_bo_cpu_map(amdgpu_bo_handle bo, void **cpu)
>>
> Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Added this and my rb as well and pushed it to master repository.
BTW: In the original patch there seems to be an unrelated change:
> - * Request CPU access to GPU accessible memory
...
> + * Request CPU access to GPU accessable memory
That doesn't looks correct to me and we should probably revert that.
Christian.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH libdrm] amdgpu: amdgpu_bo_inc_ref don't return dummy int
[not found] ` <4b37db56-172c-87e0-29f7-3e3f4dd04252-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-09-03 10:50 ` Yu, Qiang
0 siblings, 0 replies; 4+ messages in thread
From: Yu, Qiang @ 2018-09-03 10:50 UTC (permalink / raw)
To: Michel Dänzer, Koenig, Christian
Cc: Zhang, Jerry, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Deng, Hui
Sorry for not check this patch carefully, indeed a typo, will revert it.
Regards,
Qiang
________________________________________
From: Christian König <ckoenig.leichtzumerken@gmail.com>
Sent: Monday, September 3, 2018 6:40:33 PM
To: Michel Dänzer; Yu, Qiang
Cc: Zhang, Jerry; Koenig, Christian; amd-gfx@lists.freedesktop.org; Deng, Hui
Subject: Re: [PATCH libdrm] amdgpu: amdgpu_bo_inc_ref don't return dummy int
Am 03.09.2018 um 12:13 schrieb Michel Dänzer:
> On 2018-09-03 12:06 p.m., Qiang Yu wrote:
>> Signed-off-by: Qiang Yu <Qiang.Yu@amd.com>
>> ---
>> amdgpu/amdgpu-symbol-check | 2 +-
>> amdgpu/amdgpu.h | 5 +----
>> amdgpu/amdgpu_bo.c | 3 +--
>> 3 files changed, 3 insertions(+), 7 deletions(-)
>>
>> diff --git a/amdgpu/amdgpu-symbol-check b/amdgpu/amdgpu-symbol-check
>> index 487610e..58646e8 100755
>> --- a/amdgpu/amdgpu-symbol-check
>> +++ b/amdgpu/amdgpu-symbol-check
>> @@ -15,8 +15,8 @@ amdgpu_bo_cpu_map
>> amdgpu_bo_cpu_unmap
>> amdgpu_bo_export
>> amdgpu_bo_free
>> -amdgpu_bo_inc_ref
>> amdgpu_bo_import
>> +amdgpu_bo_inc_ref
>> amdgpu_bo_list_create
>> amdgpu_bo_list_destroy
>> amdgpu_bo_list_update
>> diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h
>> index e1f93f8..dc51659 100644
>> --- a/amdgpu/amdgpu.h
>> +++ b/amdgpu/amdgpu.h
>> @@ -725,13 +725,10 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle);
>> *
>> * \param bo - \c [in] Buffer object handle to increase the reference count
>> *
>> - * \return 0 on success\n
>> - * <0 - Negative POSIX Error code
>> - *
>> * \sa amdgpu_bo_alloc(), amdgpu_bo_free()
>> *
>> */
>> -int amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
>> +void amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
>>
>> /**
>> * Request CPU access to GPU accessable memory
>> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
>> index dceab01..6a95929 100644
>> --- a/amdgpu/amdgpu_bo.c
>> +++ b/amdgpu/amdgpu_bo.c
>> @@ -438,10 +438,9 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle)
>> return 0;
>> }
>>
>> -int amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
>> +void amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
>> {
>> atomic_inc(&bo->refcount);
>> - return 0;
>> }
>>
>> int amdgpu_bo_cpu_map(amdgpu_bo_handle bo, void **cpu)
>>
> Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Added this and my rb as well and pushed it to master repository.
BTW: In the original patch there seems to be an unrelated change:
> - * Request CPU access to GPU accessible memory
...
> + * Request CPU access to GPU accessable memory
That doesn't looks correct to me and we should probably revert that.
Christian.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-03 10:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-03 10:06 [PATCH libdrm] amdgpu: amdgpu_bo_inc_ref don't return dummy int Qiang Yu
[not found] ` <1535969162-28716-1-git-send-email-Qiang.Yu-5C7GfCeVMHo@public.gmane.org>
2018-09-03 10:13 ` Michel Dänzer
[not found] ` <387fe239-c0d6-b2c1-5f95-b49877e38852-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-09-03 10:40 ` Christian König
[not found] ` <4b37db56-172c-87e0-29f7-3e3f4dd04252-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-03 10:50 ` Yu, Qiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.