From: Avri Altman <Avri.Altman@wdc.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Subject: RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature
Date: Sun, 4 Oct 2020 07:20:57 +0000 [thread overview]
Message-ID: <BY5PR04MB67053A1985F6FD419214C6B9FC0F0@BY5PR04MB6705.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20201002124043.25394-2-adrian.hunter@intel.com>
> + /*
> + * DeepSleep requires the Immediate flag. DeepSleep state is actually
> + * entered when the link state goes to Hibern8.
> + */
> + if (pwr_mode == UFS_DEEPSLEEP_PWR_MODE)
> + cmd[1] = 1;
Shouldn't it be bit1, i.e. cmd[1] = 2 ?
> cmd[4] = pwr_mode << 4;
>
next prev parent reply other threads:[~2020-10-04 7:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 12:40 [PATCH 0/2] scsi: ufs: Add DeepSleep feature Adrian Hunter
2020-10-02 12:40 ` [PATCH 1/2] " Adrian Hunter
2020-10-04 7:20 ` Avri Altman [this message]
2020-10-04 14:24 ` Avri Altman
2020-10-05 8:02 ` Avri Altman
2020-10-05 8:43 ` Adrian Hunter
2020-10-05 9:51 ` Avri Altman
2020-10-05 11:06 ` Adrian Hunter
2020-10-05 11:14 ` Avri Altman
2020-10-02 12:40 ` [PATCH 2/2] scsi: ufs: Workaround UFS devices that object to DeepSleep IMMED Adrian Hunter
2020-10-05 8:10 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR04MB67053A1985F6FD419214C6B9FC0F0@BY5PR04MB6705.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.