All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avri Altman <Avri.Altman@wdc.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.ibm.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>
Subject: RE: [PATCH 2/2] scsi: ufs: Workaround UFS devices that object to DeepSleep IMMED
Date: Mon, 5 Oct 2020 08:10:26 +0000	[thread overview]
Message-ID: <BY5PR04MB67055FE554CAA5C5F5673FDDFC0C0@BY5PR04MB6705.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20201002124043.25394-3-adrian.hunter@intel.com>

 
> 
> The UFS specification says to set the IMMED (immediate) flag for the
> Start/Stop Unit command when entering DeepSleep. However some UFS
> devices object to that. Workaround that by retrying without IMMED.
> Whichever possibility works, the result is recorded for the next
> time.

As aforesaid, this patch might not be needed once IMMED is set to 0.
However, Any spec violation should come in a form of a quirk.
The driver is not supposed to figure out the peculiarities of each vendor.

Thanks
Avri

      reply	other threads:[~2020-10-05  8:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02 12:40 [PATCH 0/2] scsi: ufs: Add DeepSleep feature Adrian Hunter
2020-10-02 12:40 ` [PATCH 1/2] " Adrian Hunter
2020-10-04  7:20   ` Avri Altman
2020-10-04 14:24   ` Avri Altman
2020-10-05  8:02   ` Avri Altman
2020-10-05  8:43     ` Adrian Hunter
2020-10-05  9:51       ` Avri Altman
2020-10-05 11:06         ` Adrian Hunter
2020-10-05 11:14           ` Avri Altman
2020-10-02 12:40 ` [PATCH 2/2] scsi: ufs: Workaround UFS devices that object to DeepSleep IMMED Adrian Hunter
2020-10-05  8:10   ` Avri Altman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR04MB67055FE554CAA5C5F5673FDDFC0C0@BY5PR04MB6705.namprd04.prod.outlook.com \
    --to=avri.altman@wdc.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.