From: Damien Le Moal <Damien.LeMoal@wdc.com> To: Bart Van Assche <bvanassche@acm.org>, "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>, Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, Jens Axboe <axboe@kernel.dk> Subject: Re: [PATCH] nvme: Fix io_opt limit setting Date: Thu, 14 May 2020 04:49:46 +0000 [thread overview] Message-ID: <BY5PR04MB6900CCC90163A2E0DFE3CC9BE7BC0@BY5PR04MB6900.namprd04.prod.outlook.com> (raw) In-Reply-To: fed0df8c-3005-fbdd-c413-06fd7d174dee@acm.org On 2020/05/14 13:47, Bart Van Assche wrote: > On 2020-05-13 18:54, Damien Le Moal wrote: >> @@ -1848,7 +1847,8 @@ static void nvme_update_disk_info(struct gendisk *disk, >> */ >> blk_queue_physical_block_size(disk->queue, min(phys_bs, atomic_bs)); >> blk_queue_io_min(disk->queue, phys_bs); >> - blk_queue_io_opt(disk->queue, io_opt); >> + if (io_opt) >> + blk_queue_io_opt(disk->queue, io_opt); > > The above change looks confusing to me. We want the NVMe driver to set > io_opt, so why only call blk_queue_io_opt() if io_opt != 0? That means > that the io_opt value will be left to any value set by the block layer > core if io_opt == 0 instead of properly being set to zero. OK. I will remove the "if". > > Thanks, > > Bart. > -- Damien Le Moal Western Digital Research
WARNING: multiple messages have this Message-ID (diff)
From: Damien Le Moal <Damien.LeMoal@wdc.com> To: Bart Van Assche <bvanassche@acm.org>, "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>, Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, Jens Axboe <axboe@kernel.dk> Subject: Re: [PATCH] nvme: Fix io_opt limit setting Date: Thu, 14 May 2020 04:49:46 +0000 [thread overview] Message-ID: <BY5PR04MB6900CCC90163A2E0DFE3CC9BE7BC0@BY5PR04MB6900.namprd04.prod.outlook.com> (raw) In-Reply-To: fed0df8c-3005-fbdd-c413-06fd7d174dee@acm.org On 2020/05/14 13:47, Bart Van Assche wrote: > On 2020-05-13 18:54, Damien Le Moal wrote: >> @@ -1848,7 +1847,8 @@ static void nvme_update_disk_info(struct gendisk *disk, >> */ >> blk_queue_physical_block_size(disk->queue, min(phys_bs, atomic_bs)); >> blk_queue_io_min(disk->queue, phys_bs); >> - blk_queue_io_opt(disk->queue, io_opt); >> + if (io_opt) >> + blk_queue_io_opt(disk->queue, io_opt); > > The above change looks confusing to me. We want the NVMe driver to set > io_opt, so why only call blk_queue_io_opt() if io_opt != 0? That means > that the io_opt value will be left to any value set by the block layer > core if io_opt == 0 instead of properly being set to zero. OK. I will remove the "if". > > Thanks, > > Bart. > -- Damien Le Moal Western Digital Research _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-05-14 4:49 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-14 1:54 [PATCH] nvme: Fix io_opt limit setting Damien Le Moal 2020-05-14 1:54 ` Damien Le Moal 2020-05-14 3:29 ` Martin K. Petersen 2020-05-14 3:29 ` Martin K. Petersen 2020-05-14 3:40 ` Keith Busch 2020-05-14 3:40 ` Keith Busch 2020-05-14 3:47 ` Damien Le Moal 2020-05-14 3:47 ` Damien Le Moal 2020-05-14 4:12 ` Keith Busch 2020-05-14 4:12 ` Keith Busch 2020-05-14 4:13 ` Damien Le Moal 2020-05-14 4:13 ` Damien Le Moal 2020-05-14 4:47 ` Bart Van Assche 2020-05-14 4:47 ` Bart Van Assche 2020-05-14 4:49 ` Damien Le Moal [this message] 2020-05-14 4:49 ` Damien Le Moal 2020-05-14 22:19 ` Martin K. Petersen 2020-05-14 22:19 ` Martin K. Petersen 2020-05-14 6:11 ` Hannes Reinecke 2020-05-14 6:11 ` Hannes Reinecke
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BY5PR04MB6900CCC90163A2E0DFE3CC9BE7BC0@BY5PR04MB6900.namprd04.prod.outlook.com \ --to=damien.lemoal@wdc.com \ --cc=axboe@kernel.dk \ --cc=bvanassche@acm.org \ --cc=hch@lst.de \ --cc=kbusch@kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.