* [PATCH] dm-zoned: remove leftover hunk for switching to sequential zones
@ 2020-05-22 7:32 Hannes Reinecke
2020-05-22 7:45 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Reinecke @ 2020-05-22 7:32 UTC (permalink / raw)
To: Mike Snitzer; +Cc: Hannes, Damien LeMoal, dm-devel
Remove a leftover hunk to switch from sequential zones to random
zones when selecting a reclaim zone; the logic has moved into the
caller and this patch is now pointless.
Fixes: 34f5affd04c4 ("dm zoned: separate random and cache zones")
Signed-off-by: Hannes Reinecke <hare@suse.de.
---
drivers/md/dm-zoned-metadata.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
index db0dc2b5d44d..4a2e351365c5 100644
--- a/drivers/md/dm-zoned-metadata.c
+++ b/drivers/md/dm-zoned-metadata.c
@@ -2111,14 +2111,6 @@ struct dm_zone *dmz_alloc_zone(struct dmz_metadata *zmd, unsigned long flags)
*/
if (!(flags & DMZ_ALLOC_RECLAIM))
return NULL;
- /*
- * Use sequential write zones if we started off with random
- * zones and the list is empty
- */
- if (list == &zmd->unmap_rnd_list) {
- list = &zmd->unmap_seq_list;
- goto again;
- }
/*
* Fallback to the reserved sequential zones
*/
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dm-zoned: remove leftover hunk for switching to sequential zones
2020-05-22 7:32 [PATCH] dm-zoned: remove leftover hunk for switching to sequential zones Hannes Reinecke
@ 2020-05-22 7:45 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2020-05-22 7:45 UTC (permalink / raw)
To: Hannes Reinecke, Mike Snitzer; +Cc: Hannes, dm-devel
On 2020/05/22 16:32, Hannes Reinecke wrote:
> Remove a leftover hunk to switch from sequential zones to random
...from random zones to sequential zones...
> zones when selecting a reclaim zone; the logic has moved into the
> caller and this patch is now pointless.
s/this patch/this hunk/ ?
>
> Fixes: 34f5affd04c4 ("dm zoned: separate random and cache zones")
> Signed-off-by: Hannes Reinecke <hare@suse.de.
> ---
> drivers/md/dm-zoned-metadata.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
> index db0dc2b5d44d..4a2e351365c5 100644
> --- a/drivers/md/dm-zoned-metadata.c
> +++ b/drivers/md/dm-zoned-metadata.c
> @@ -2111,14 +2111,6 @@ struct dm_zone *dmz_alloc_zone(struct dmz_metadata *zmd, unsigned long flags)
> */
> if (!(flags & DMZ_ALLOC_RECLAIM))
> return NULL;
> - /*
> - * Use sequential write zones if we started off with random
> - * zones and the list is empty
> - */
> - if (list == &zmd->unmap_rnd_list) {
> - list = &zmd->unmap_seq_list;
> - goto again;
> - }
> /*
> * Fallback to the reserved sequential zones
> */
Apart from the commit message nits, looks good.
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-22 7:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22 7:32 [PATCH] dm-zoned: remove leftover hunk for switching to sequential zones Hannes Reinecke
2020-05-22 7:45 ` Damien Le Moal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.