RE: [Toaster] [PATCH] toaster: handle changes to "ImagePkgList" event

From: "Reyna, David" <david.reyna@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	"toaster@lists.yoctoproject.org" <toaster@lists.yoctoproject.org>
Subject: RE: [Toaster] [PATCH] toaster: handle changes to "ImagePkgList" event
Date: Fri, 18 Mar 2022 19:26:32 +0000	[thread overview]
Message-ID: <BY5PR11MB416775A0BD6F53F6D3084377EA139@BY5PR11MB4167.namprd11.prod.outlook.com> (raw)
In-Reply-To: <5add1e9d2e60b63604014c0db6b7ecf64d9b1d69.camel@linuxfoundation.org>

> I think the fact that some values are "disappearing" is a sign the overrides
change has some impact here which needs to be fixed and this patch is just
partially working around it.

Yes, this patch is specifically to work around the problems in the event data encountered. Fortunately these were the only events thus affected.

If the original data and formatting does get restored, you will observe that the patch is written to use that original formatting.

After the core problems are fixed, then this patch (or parts) can be dropped.

As a result of these discoveries, I filed Bug 14764 directly against Bitbake since there was obvious missing formatting with 'PKGSIZE'. As for the other problems, I could not tell if they were intentional changes or not.  I will update Bug 14764 so that it is one stop shopping.

David

-----Original Message-----
From: toaster@lists.yoctoproject.org <toaster@lists.yoctoproject.org> On Behalf Of Richard Purdie
Sent: Friday, March 18, 2022 3:50 AM
To: Reyna, David <david.reyna@windriver.com>; toaster@lists.yoctoproject.org
Subject: Re: [Toaster] [PATCH] toaster: handle changes to "ImagePkgList" event

On Fri, 2022-03-18 at 03:43 -0700, Reyna, David wrote:
> From: David Reyna <David.Reyna@windriver.com>
> 
> There are several changes to the "ImagePkgList" content to work around:
> 1) The key field for the package size ('PKGSIZE') is currently an empty string
> 2) The list of files changed from 'FILES_INFO' to 'FILES'
> 3) The 'FILES' is now a dictionary in string form
> 4) Not all fields are always present for all packages, for example 'LICENSE' and 'SUMMARY'
> 
> [YOCTO #14763]
> 
> Signed-off-by: David Reyna <David.Reyna@windriver.com>

I'm not sure this looks entirely correct to me. FILES is the pre expanded
version of the files list so it could contain wildcards and FILES_INFO was meant
to be the version where the list of files was expanded out (and may have also
been tweaked by other package processing, e.g. creation of debug files).

I think the fact that some values are "disappearing" is a sign the overrides
change has some impact here which needs to be fixed and this patch is just
partially working around it.

Cheers,

Richard