RE: [Toaster] [PATCH] toaster: handle changes to "ImagePkgList" event

["Reyna, David" <david.reyna@windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 1857 bytes --]

> I'm seeing builds reach 100% and then just hang in the toaster UI never completing.

See my recent patch for 14765 (attached).

I discovered that new race condition with long builds where the end-of-build event has the build record success outcome properly set, but that commit never makes it in time to the physical database before the build tear-down. It may be related to the upgrade to Django 3 (and if so it is the only oddity with Tim's Django 3 I have encountered).

David

-----Original Message-----
From: toaster@lists.yoctoproject.org <toaster@lists.yoctoproject.org> On Behalf Of Richard Purdie
Sent: Sunday, March 20, 2022 3:44 PM
To: Reyna, David <david.reyna@windriver.com>; toaster@lists.yoctoproject.org
Subject: Re: [Toaster] [PATCH] toaster: handle changes to "ImagePkgList" event

Hi David,

On Sun, 2022-03-20 at 22:37 +0000, Reyna, David wrote:
> Hi Richard,
> 
> Your proposed patch works perfectly. All the anomalies disappeared. I will drop my workaround patch and submit your patch instead.
> 
> I do have a limitation in that I am only setup to submit patches to bitbake, and not to oe-core. Could someone point me to those instructions, or could you pass that patch to them directly?

Thanks for testing, I'm glad it works and sorted the anomalies. I've sent it to
the OE-Core list and queued it for testing:

https://git.yoctoproject.org/poky/commit/?h=master-next&id=c94d49a769244e72df6631fdd4078cd1ad317e04

I did try and do some testing myself however I'm seeing builds reach 100% and
then just hang in the toaster UI never completing. It didn't matter if I ran
them from the UI or the commandline.

Have you seen anything like that before? It could be some issue with my local
setup or corruption from something previous, I'll try and dig a little more
tomorrow.

Cheers,

Richard


[-- Attachment #2: Type: message/rfc822, Size: 12380 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 1115 bytes --]

From: David Reyna <David.Reyna@windriver.com>

Force a sync point for end-of build event handler force
the build's outcome status commit, to resolve a race
condition with the build completion takedown.

[YOCTO #14765]

Signed-off-by: David Reyna <David.Reyna@windriver.com>
---
 bitbake/lib/bb/ui/buildinfohelper.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/bitbake/lib/bb/ui/buildinfohelper.py b/bitbake/lib/bb/ui/buildinfohelper.py
index 5559387d8e..ec036e3b14 100644
--- a/bitbake/lib/bb/ui/buildinfohelper.py
+++ b/bitbake/lib/bb/ui/buildinfohelper.py
@@ -228,6 +228,12 @@ class ORMWrapper(object):
         build.completed_on = timezone.now()
         build.outcome = outcome
         build.save()
+
+        # We force a sync point here to force the outcome status commit,
+        # which resolves a race condition with the build completion takedown
+        transaction.set_autocommit(True)
+        transaction.set_autocommit(False)
+
         signal_runbuilds()

     def update_target_set_license_manifest(self, target, license_manifest_path):
--
2.17.1


[-- Attachment #2.1.2: ATT00001.txt --]
[-- Type: text/plain, Size: 398 bytes --]


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5783): https://lists.yoctoproject.org/g/toaster/message/5783
Mute This Topic: https://lists.yoctoproject.org/mt/89883147/3616810
Group Owner: toaster+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/toaster/unsub [david.reyna@windriver.com]
-=-=-=-=-=-=-=-=-=-=-=-