[Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests

[Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests

[Vidya Srinivas]

Few Gen11 systems show CRC mismatch. Make coverage-vs-premult-vs-constant
code similar to constant_alpha_min or basic_alpha

Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..224d79bd1749 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_display_t *display = &data->display;
 	igt_crc_t ref_crc = {}, crc = {};
 
-	/* Set a background color on the primary fb for testing */
-	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
-		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
-
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests

[Vidya Srinivas]

Few Gen11 systems show CRC mismatch. Make coverage-vs-premult-vs-constant
code similar to constant_alpha_min or basic_alpha

Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..224d79bd1749 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_display_t *display = &data->display;
 	igt_crc_t ref_crc = {}, crc = {};
 
-	/* Set a background color on the primary fb for testing */
-	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
-		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
-
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests

[Petri Latvala]

On Tue, Jun 01, 2021 at 05:15:39PM +0530, Vidya Srinivas wrote:
> tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests
>
> Few Gen11 systems show CRC mismatch. Make coverage-vs-premult-vs-constant
> code similar to constant_alpha_min or basic_alpha
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>


Please make the first line of the commit message a statement that
tells what change you're making, and in the full text block state why
that's done. "Fix a-b-c tests" is useless later when browsing oneliner
git logs. It doesn't even tell which problem is fixed.

Meaning, something like:


==
tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Similar change has already been done in tests xxx and yyy.
This fixes CRC mismatches seen with some Gen11 systems.

Signed-off-by etc
==


-- 
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests

[Petri Latvala]

On Tue, Jun 01, 2021 at 05:15:39PM +0530, Vidya Srinivas wrote:
> tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests
>
> Few Gen11 systems show CRC mismatch. Make coverage-vs-premult-vs-constant
> code similar to constant_alpha_min or basic_alpha
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>


Please make the first line of the commit message a statement that
tells what change you're making, and in the full text block state why
that's done. "Fix a-b-c tests" is useless later when browsing oneliner
git logs. It doesn't even tell which problem is fixed.

Meaning, something like:


==
tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Similar change has already been done in tests xxx and yyy.
This fixes CRC mismatches seen with some Gen11 systems.

Signed-off-by etc
==


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

[Vidya Srinivas]

Patch removes setting primary fb color in coverage-vs-premult-vs-constant
as this is causing CRC mismatch on few Gen11 systems.
Similar change has already been done in tests constant_alpha_min and basic_alpha
where the test runs on all planes but dont set the primary fb color.

Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..224d79bd1749 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_display_t *display = &data->display;
 	igt_crc_t ref_crc = {}, crc = {};
 
-	/* Set a background color on the primary fb for testing */
-	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
-		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
-
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests

[Srinivas, Vidya]

Thank you so much Petri. Apologies for the incorrect commit message.
I will submit the patch with the clear commit message.

Regards
Vidya

-----Original Message-----
From: Latvala, Petri <petri.latvala@intel.com> 
Sent: Tuesday, June 1, 2021 7:11 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>
Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests

On Tue, Jun 01, 2021 at 05:15:39PM +0530, Vidya Srinivas wrote:
> tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests
>
> Few Gen11 systems show CRC mismatch. Make 
> coverage-vs-premult-vs-constant code similar to constant_alpha_min or 
> basic_alpha
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>


Please make the first line of the commit message a statement that tells what change you're making, and in the full text block state why that's done. "Fix a-b-c tests" is useless later when browsing oneliner git logs. It doesn't even tell which problem is fixed.

Meaning, something like:


==
tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Similar change has already been done in tests xxx and yyy.
This fixes CRC mismatches seen with some Gen11 systems.

Signed-off-by etc
==


--
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev2)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 3168 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev2)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from IGT_6098 -> IGTPW_5871
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/index.html

Known issues
------------

  Here are the changes found in IGTPW_5871 that come from known issues:

### IGT changes ###

#### Warnings ####

  * igt@i915_selftest@live@execlists:
    - fi-tgl-u2:          [DMESG-FAIL][1] ([i915#3462]) -> [INCOMPLETE][2] ([i915#3462])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/fi-tgl-u2/igt@i915_selftest@live@execlists.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/fi-tgl-u2/igt@i915_selftest@live@execlists.html

  * igt@runner@aborted:
    - fi-skl-6600u:       [FAIL][3] ([i915#1436] / [i915#3363]) -> [FAIL][4] ([i915#1436] / [i915#2426] / [i915#3363])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/fi-skl-6600u/igt@runner@aborted.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/fi-skl-6600u/igt@runner@aborted.html
    - fi-glk-dsi:         [FAIL][5] ([i915#2426] / [i915#3363] / [k.org#202321]) -> [FAIL][6] ([i915#3363] / [k.org#202321])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/fi-glk-dsi/igt@runner@aborted.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/fi-glk-dsi/igt@runner@aborted.html
    - fi-kbl-7500u:       [FAIL][7] ([i915#1436] / [i915#3363]) -> [FAIL][8] ([i915#1436] / [i915#2426] / [i915#3363])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/fi-kbl-7500u/igt@runner@aborted.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/fi-kbl-7500u/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
  [i915#2932]: https://gitlab.freedesktop.org/drm/intel/issues/2932
  [i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966
  [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
  [i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
  [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321


Participating hosts (47 -> 41)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-dg1-1 fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6098 -> IGTPW_5871

  CI-20190529: 20190529
  CI_DRM_10154: 810010ed3d29e0500d452a90010a88a0879f2b45 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_5871: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/index.html
  IGT_6098: 1fbc1e7d602f96a7f4e2b95057eef994656b8e74 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/index.html

[-- Attachment #1.2: Type: text/html, Size: 4473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev2)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 30295 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev2)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from IGT_6098_full -> IGTPW_5871_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/index.html

Known issues
------------

  Here are the changes found in IGTPW_5871_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@feature_discovery@display-3x:
    - shard-glk:          NOTRUN -> [SKIP][1] ([fdo#109271]) +83 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-glk9/igt@feature_discovery@display-3x.html
    - shard-iclb:         NOTRUN -> [SKIP][2] ([i915#1839]) +1 similar issue
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb5/igt@feature_discovery@display-3x.html

  * igt@gem_ctx_isolation@preservation-s3@rcs0:
    - shard-kbl:          [PASS][3] -> [DMESG-WARN][4] ([i915#180])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@rcs0.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl2/igt@gem_ctx_isolation@preservation-s3@rcs0.html

  * igt@gem_ctx_persistence@idempotent:
    - shard-snb:          NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) +5 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-snb2/igt@gem_ctx_persistence@idempotent.html

  * igt@gem_ctx_sseu@invalid-sseu:
    - shard-tglb:         NOTRUN -> [SKIP][6] ([i915#280])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb5/igt@gem_ctx_sseu@invalid-sseu.html

  * igt@gem_exec_fair@basic-none-vip@rcs0:
    - shard-tglb:         NOTRUN -> [FAIL][7] ([i915#2842])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb2/igt@gem_exec_fair@basic-none-vip@rcs0.html
    - shard-iclb:         NOTRUN -> [FAIL][8] ([i915#2842])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb1/igt@gem_exec_fair@basic-none-vip@rcs0.html

  * igt@gem_exec_fair@basic-none@vcs1:
    - shard-kbl:          [PASS][9] -> [FAIL][10] ([i915#2842])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-kbl3/igt@gem_exec_fair@basic-none@vcs1.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl1/igt@gem_exec_fair@basic-none@vcs1.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-glk:          [PASS][11] -> [FAIL][12] ([i915#2842]) +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_flush@basic-batch-kernel-default-cmd:
    - shard-iclb:         NOTRUN -> [SKIP][13] ([fdo#109313])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb1/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
    - shard-tglb:         NOTRUN -> [SKIP][14] ([fdo#109313])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb1/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html

  * igt@gem_exec_params@rsvd2-dirt:
    - shard-tglb:         NOTRUN -> [SKIP][15] ([fdo#109283])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb2/igt@gem_exec_params@rsvd2-dirt.html
    - shard-iclb:         NOTRUN -> [SKIP][16] ([fdo#109283])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb5/igt@gem_exec_params@rsvd2-dirt.html

  * igt@gem_exec_reloc@basic-wide-active@bcs0:
    - shard-apl:          NOTRUN -> [FAIL][17] ([i915#2389]) +3 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl6/igt@gem_exec_reloc@basic-wide-active@bcs0.html
    - shard-glk:          NOTRUN -> [FAIL][18] ([i915#2389]) +3 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-glk8/igt@gem_exec_reloc@basic-wide-active@bcs0.html

  * igt@gem_exec_reloc@basic-wide-active@rcs0:
    - shard-iclb:         NOTRUN -> [FAIL][19] ([i915#2389]) +4 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb1/igt@gem_exec_reloc@basic-wide-active@rcs0.html

  * igt@gem_mmap_gtt@cpuset-basic-small-copy:
    - shard-apl:          NOTRUN -> [INCOMPLETE][20] ([i915#3468])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl1/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
    - shard-tglb:         [PASS][21] -> [INCOMPLETE][22] ([i915#3468])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-tglb6/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb8/igt@gem_mmap_gtt@cpuset-basic-small-copy.html

  * igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
    - shard-glk:          [PASS][23] -> [INCOMPLETE][24] ([i915#2055] / [i915#3468])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-glk5/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-glk8/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html

  * igt@gem_mmap_gtt@medium-copy-xy:
    - shard-glk:          [PASS][25] -> [INCOMPLETE][26] ([i915#2055] / [i915#2502] / [i915#3468])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-glk9/igt@gem_mmap_gtt@medium-copy-xy.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-glk4/igt@gem_mmap_gtt@medium-copy-xy.html

  * igt@gem_pread@exhaustion:
    - shard-apl:          NOTRUN -> [WARN][27] ([i915#2658])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl7/igt@gem_pread@exhaustion.html

  * igt@gem_render_copy@y-tiled-to-vebox-linear:
    - shard-iclb:         NOTRUN -> [SKIP][28] ([i915#768]) +2 similar issues
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb6/igt@gem_render_copy@y-tiled-to-vebox-linear.html

  * igt@gem_softpin@noreloc-s3:
    - shard-apl:          NOTRUN -> [DMESG-WARN][29] ([i915#180]) +1 similar issue
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl6/igt@gem_softpin@noreloc-s3.html

  * igt@gem_userptr_blits@coherency-sync:
    - shard-tglb:         NOTRUN -> [SKIP][30] ([fdo#110542])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb2/igt@gem_userptr_blits@coherency-sync.html
    - shard-iclb:         NOTRUN -> [SKIP][31] ([fdo#109290])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb1/igt@gem_userptr_blits@coherency-sync.html

  * igt@gem_userptr_blits@dmabuf-unsync:
    - shard-tglb:         NOTRUN -> [SKIP][32] ([i915#3297]) +1 similar issue
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb7/igt@gem_userptr_blits@dmabuf-unsync.html
    - shard-iclb:         NOTRUN -> [SKIP][33] ([i915#3297]) +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb8/igt@gem_userptr_blits@dmabuf-unsync.html

  * igt@gem_userptr_blits@input-checking:
    - shard-snb:          NOTRUN -> [DMESG-WARN][34] ([i915#3002])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-snb5/igt@gem_userptr_blits@input-checking.html

  * igt@gem_userptr_blits@vma-merge:
    - shard-kbl:          NOTRUN -> [FAIL][35] ([i915#3318])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl3/igt@gem_userptr_blits@vma-merge.html

  * igt@gen7_exec_parse@cmd-crossing-page:
    - shard-tglb:         NOTRUN -> [SKIP][36] ([fdo#109289]) +2 similar issues
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb7/igt@gen7_exec_parse@cmd-crossing-page.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-tglb:         NOTRUN -> [SKIP][37] ([fdo#112306]) +1 similar issue
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb2/igt@gen9_exec_parse@allowed-single.html

  * igt@gen9_exec_parse@bb-large:
    - shard-apl:          NOTRUN -> [FAIL][38] ([i915#3296])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl7/igt@gen9_exec_parse@bb-large.html

  * igt@gen9_exec_parse@secure-batches:
    - shard-iclb:         NOTRUN -> [SKIP][39] ([fdo#112306]) +1 similar issue
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb7/igt@gen9_exec_parse@secure-batches.html

  * igt@i915_module_load@reload-with-fault-injection:
    - shard-snb:          NOTRUN -> [DMESG-WARN][40] ([i915#3389])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-snb2/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-apl:          [PASS][41] -> [SKIP][42] ([fdo#109271])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-apl7/igt@i915_pm_dc@dc9-dpms.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl1/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
    - shard-kbl:          NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#1937])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html

  * igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
    - shard-tglb:         NOTRUN -> [SKIP][44] ([fdo#111644] / [i915#1397] / [i915#2411]) +1 similar issue
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb6/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
    - shard-iclb:         NOTRUN -> [SKIP][45] ([fdo#110892]) +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb1/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html

  * igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
    - shard-iclb:         NOTRUN -> [SKIP][46] ([i915#1769])
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb1/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html
    - shard-tglb:         NOTRUN -> [SKIP][47] ([i915#1769])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb6/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html

  * igt@kms_big_fb@linear-8bpp-rotate-270:
    - shard-iclb:         NOTRUN -> [SKIP][48] ([fdo#110725] / [fdo#111614]) +1 similar issue
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb8/igt@kms_big_fb@linear-8bpp-rotate-270.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-90:
    - shard-tglb:         NOTRUN -> [SKIP][49] ([fdo#111614])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb5/igt@kms_big_fb@x-tiled-32bpp-rotate-90.html

  * igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
    - shard-tglb:         NOTRUN -> [SKIP][50] ([fdo#111615])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb2/igt@kms_big_fb@yf-tiled-64bpp-rotate-0.html
    - shard-iclb:         NOTRUN -> [SKIP][51] ([fdo#110723])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb5/igt@kms_big_fb@yf-tiled-64bpp-rotate-0.html

  * igt@kms_big_joiner@invalid-modeset:
    - shard-iclb:         NOTRUN -> [SKIP][52] ([i915#2705])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb6/igt@kms_big_joiner@invalid-modeset.html
    - shard-apl:          NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#2705])
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl3/igt@kms_big_joiner@invalid-modeset.html
    - shard-glk:          NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#2705])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-glk2/igt@kms_big_joiner@invalid-modeset.html

  * igt@kms_chamelium@dp-crc-multiple:
    - shard-tglb:         NOTRUN -> [SKIP][55] ([fdo#109284] / [fdo#111827]) +3 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb3/igt@kms_chamelium@dp-crc-multiple.html

  * igt@kms_chamelium@hdmi-crc-fast:
    - shard-iclb:         NOTRUN -> [SKIP][56] ([fdo#109284] / [fdo#111827]) +5 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb6/igt@kms_chamelium@hdmi-crc-fast.html

  * igt@kms_chamelium@hdmi-hpd:
    - shard-glk:          NOTRUN -> [SKIP][57] ([fdo#109271] / [fdo#111827]) +6 similar issues
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-glk2/igt@kms_chamelium@hdmi-hpd.html

  * igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
    - shard-snb:          NOTRUN -> [SKIP][58] ([fdo#109271] / [fdo#111827]) +18 similar issues
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-snb6/igt@kms_chamelium@hdmi-hpd-enable-disable-mode.html

  * igt@kms_chamelium@hdmi-hpd-storm:
    - shard-kbl:          NOTRUN -> [SKIP][59] ([fdo#109271] / [fdo#111827]) +19 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl7/igt@kms_chamelium@hdmi-hpd-storm.html

  * igt@kms_color@pipe-a-degamma:
    - shard-tglb:         NOTRUN -> [FAIL][60] ([i915#1149])
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb2/igt@kms_color@pipe-a-degamma.html
    - shard-iclb:         NOTRUN -> [FAIL][61] ([i915#1149])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb2/igt@kms_color@pipe-a-degamma.html

  * igt@kms_color@pipe-d-ctm-0-5:
    - shard-iclb:         NOTRUN -> [SKIP][62] ([fdo#109278] / [i915#1149])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb2/igt@kms_color@pipe-d-ctm-0-5.html

  * igt@kms_color_chamelium@pipe-c-ctm-0-25:
    - shard-apl:          NOTRUN -> [SKIP][63] ([fdo#109271] / [fdo#111827]) +18 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl1/igt@kms_color_chamelium@pipe-c-ctm-0-25.html

  * igt@kms_color_chamelium@pipe-d-ctm-0-75:
    - shard-iclb:         NOTRUN -> [SKIP][64] ([fdo#109278] / [fdo#109284] / [fdo#111827])
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb2/igt@kms_color_chamelium@pipe-d-ctm-0-75.html

  * igt@kms_content_protection@dp-mst-type-0:
    - shard-tglb:         NOTRUN -> [SKIP][65] ([i915#3116])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb7/igt@kms_content_protection@dp-mst-type-0.html
    - shard-iclb:         NOTRUN -> [SKIP][66] ([i915#3116])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb8/igt@kms_content_protection@dp-mst-type-0.html

  * igt@kms_content_protection@legacy:
    - shard-iclb:         NOTRUN -> [SKIP][67] ([fdo#109300] / [fdo#111066]) +1 similar issue
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb6/igt@kms_content_protection@legacy.html
    - shard-kbl:          NOTRUN -> [TIMEOUT][68] ([i915#1319]) +1 similar issue
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl3/igt@kms_content_protection@legacy.html
    - shard-tglb:         NOTRUN -> [SKIP][69] ([fdo#111828]) +1 similar issue
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb3/igt@kms_content_protection@legacy.html

  * igt@kms_content_protection@lic:
    - shard-apl:          NOTRUN -> [TIMEOUT][70] ([i915#1319])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl3/igt@kms_content_protection@lic.html

  * igt@kms_content_protection@uevent:
    - shard-apl:          NOTRUN -> [FAIL][71] ([i915#2105])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl1/igt@kms_content_protection@uevent.html

  * igt@kms_cursor_crc@pipe-b-cursor-32x10-onscreen:
    - shard-iclb:         NOTRUN -> [SKIP][72] ([fdo#109278]) +16 similar issues
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb7/igt@kms_cursor_crc@pipe-b-cursor-32x10-onscreen.html
    - shard-tglb:         NOTRUN -> [SKIP][73] ([i915#3359]) +2 similar issues
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb8/igt@kms_cursor_crc@pipe-b-cursor-32x10-onscreen.html

  * igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen:
    - shard-iclb:         NOTRUN -> [SKIP][74] ([fdo#109278] / [fdo#109279]) +2 similar issues
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb2/igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen.html

  * igt@kms_cursor_crc@pipe-b-cursor-512x170-random:
    - shard-tglb:         NOTRUN -> [SKIP][75] ([fdo#109279] / [i915#3359]) +1 similar issue
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb3/igt@kms_cursor_crc@pipe-b-cursor-512x170-random.html

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
    - shard-iclb:         NOTRUN -> [SKIP][76] ([fdo#109274] / [fdo#109278]) +1 similar issue
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html

  * igt@kms_cursor_legacy@pipe-d-single-bo:
    - shard-kbl:          NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#533]) +1 similar issue
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl4/igt@kms_cursor_legacy@pipe-d-single-bo.html

  * igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium:
    - shard-tglb:         NOTRUN -> [SKIP][78] ([i915#3528])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb3/igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium.html
    - shard-iclb:         NOTRUN -> [SKIP][79] ([i915#3528])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb2/igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium.html

  * igt@kms_flip@2x-flip-vs-rmfb-interruptible:
    - shard-iclb:         NOTRUN -> [SKIP][80] ([fdo#109274]) +4 similar issues
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb7/igt@kms_flip@2x-flip-vs-rmfb-interruptible.html

  * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
    - shard-kbl:          NOTRUN -> [DMESG-WARN][81] ([i915#180]) +5 similar issues
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
    - shard-tglb:         NOTRUN -> [SKIP][82] ([i915#2587])
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
    - shard-kbl:          NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#2672])
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl4/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
    - shard-apl:          NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2672])
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
    - shard-snb:          NOTRUN -> [SKIP][85] ([fdo#109271]) +407 similar issues
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-snb7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
    - shard-kbl:          NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#2642])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt:
    - shard-iclb:         NOTRUN -> [SKIP][87] ([fdo#109280]) +34 similar issues
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-pgflip-blt:
    - shard-tglb:         NOTRUN -> [SKIP][88] ([fdo#111825]) +37 similar issues
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
    - shard-kbl:          NOTRUN -> [SKIP][89] ([fdo#109271]) +247 similar issues
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl1/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html

  * igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
    - shard-tglb:         NOTRUN -> [SKIP][90] ([i915#1839]) +1 similar issue
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb2/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
    - shard-apl:          NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#533])
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl7/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
    - shard-apl:          NOTRUN -> [FAIL][92] ([fdo#108145] / [i915#265]) +4 similar issues
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl3/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html

  * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
    - shard-glk:          NOTRUN -> [FAIL][93] ([fdo#108145] / [i915#265])
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-glk5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html

  * igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
    - shard-kbl:          NOTRUN -> [FAIL][94] ([fdo#108145] / [i915#265]) +5 similar issues
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl2/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html

  * igt@kms_plane_lowres@pipe-b-tiling-y:
    - shard-tglb:         NOTRUN -> [SKIP][95] ([i915#3536])
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb2/igt@kms_plane_lowres@pipe-b-tiling-y.html
    - shard-iclb:         NOTRUN -> [SKIP][96] ([i915#3536])
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb1/igt@kms_plane_lowres@pipe-b-tiling-y.html

  * igt@kms_plane_lowres@pipe-d-tiling-yf:
    - shard-tglb:         NOTRUN -> [SKIP][97] ([fdo#112054])
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb7/igt@kms_plane_lowres@pipe-d-tiling-yf.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
    - shard-tglb:         NOTRUN -> [SKIP][98] ([i915#2920]) +2 similar issues
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb8/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
    - shard-iclb:         NOTRUN -> [SKIP][99] ([i915#658]) +1 similar issue
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
    - shard-glk:          NOTRUN -> [SKIP][100] ([fdo#109271] / [i915#658]) +1 similar issue
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-glk9/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
    - shard-apl:          NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#658]) +5 similar issues
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html

  * igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
    - shard-iclb:         NOTRUN -> [SKIP][102] ([i915#2920])
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html
    - shard-kbl:          NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#658]) +6 similar issues
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl7/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][104] -> [SKIP][105] ([fdo#109642] / [fdo#111068] / [i915#658])
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb5/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         NOTRUN -> [SKIP][106] ([fdo#109441]) +1 similar issue
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html
    - shard-tglb:         NOTRUN -> [FAIL][107] ([i915#132] / [i915#3467]) +1 similar issue
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb5/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_psr@psr2_sprite_render:
    - shard-iclb:         [PASS][108] -> [SKIP][109] ([fdo#109441]) +1 similar issue
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb1/igt@kms_psr@psr2_sprite_render.html

  * igt@kms_vblank@pipe-d-ts-continuation-idle:
    - shard-apl:          NOTRUN -> [SKIP][110] ([fdo#109271]) +259 similar issues
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl7/igt@kms_vblank@pipe-d-ts-continuation-idle.html

  * igt@kms_vrr@flip-suspend:
    - shard-iclb:         NOTRUN -> [SKIP][111] ([fdo#109502])
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb5/igt@kms_vrr@flip-suspend.html
    - shard-tglb:         NOTRUN -> [SKIP][112] ([fdo#109502])
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb5/igt@kms_vrr@flip-suspend.html

  * igt@kms_writeback@writeback-pixel-formats:
    - shard-kbl:          NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#2437])
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl4/igt@kms_writeback@writeback-pixel-formats.html

  * igt@nouveau_crc@pipe-b-source-outp-inactive:
    - shard-iclb:         NOTRUN -> [SKIP][114] ([i915#2530])
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb2/igt@nouveau_crc@pipe-b-source-outp-inactive.html

  * igt@nouveau_crc@pipe-d-ctx-flip-skip-current-frame:
    - shard-iclb:         NOTRUN -> [SKIP][115] ([fdo#109278] / [i915#2530])
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb8/igt@nouveau_crc@pipe-d-ctx-flip-skip-current-frame.html
    - shard-tglb:         NOTRUN -> [SKIP][116] ([i915#2530])
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb7/igt@nouveau_crc@pipe-d-ctx-flip-skip-current-frame.html

  * igt@perf@unprivileged-single-ctx-counters:
    - shard-iclb:         NOTRUN -> [SKIP][117] ([fdo#109289]) +4 similar issues
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb7/igt@perf@unprivileged-single-ctx-counters.html

  * igt@prime_nv_api@nv_self_import_to_different_fd:
    - shard-tglb:         NOTRUN -> [SKIP][118] ([fdo#109291]) +2 similar issues
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb7/igt@prime_nv_api@nv_self_import_to_different_fd.html

  * igt@prime_nv_test@i915_nv_sharing:
    - shard-iclb:         NOTRUN -> [SKIP][119] ([fdo#109291]) +3 similar issues
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb2/igt@prime_nv_test@i915_nv_sharing.html

  * igt@sysfs_clients@fair-7:
    - shard-apl:          NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#2994]) +2 similar issues
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl2/igt@sysfs_clients@fair-7.html

  * igt@sysfs_clients@recycle:
    - shard-iclb:         NOTRUN -> [SKIP][121] ([i915#2994])
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb6/igt@sysfs_clients@recycle.html
    - shard-glk:          NOTRUN -> [SKIP][122] ([fdo#109271] / [i915#2994])
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-glk6/igt@sysfs_clients@recycle.html
    - shard-tglb:         NOTRUN -> [SKIP][123] ([i915#2994])
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb3/igt@sysfs_clients@recycle.html

  * igt@sysfs_clients@sema-50:
    - shard-kbl:          NOTRUN -> [SKIP][124] ([fdo#109271] / [i915#2994]) +3 similar issues
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl1/igt@sysfs_clients@sema-50.html

  
#### Possible fixes ####

  * igt@gem_ctx_persistence@many-contexts:
    - shard-tglb:         [FAIL][125] ([i915#2410]) -> [PASS][126]
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-tglb5/igt@gem_ctx_persistence@many-contexts.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-tglb1/igt@gem_ctx_persistence@many-contexts.html

  * igt@gem_exec_fair@basic-none@vcs0:
    - shard-kbl:          [FAIL][127] ([i915#2842]) -> [PASS][128]
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-kbl1/igt@gem_exec_fair@basic-none@vcs0.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-glk:          [FAIL][129] ([i915#2842]) -> [PASS][130]
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-glk1/igt@gem_exec_fair@basic-throttle@rcs0.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-glk1/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:
    - shard-iclb:         [INCOMPLETE][131] ([i915#2910] / [i915#3468]) -> [PASS][132]
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-iclb6/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb1/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html

  * igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
    - shard-apl:          [INCOMPLETE][133] ([i915#3468]) -> [PASS][134]
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-apl7/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-apl6/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
    - shard-iclb:         [INCOMPLETE][135] ([i915#3468]) -> [PASS][136]
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6098/shard-iclb7/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/shard-iclb8/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html

  * igt@gem_ppgtt@flink-and-close-vma-leak:
    - shard-glk:          [FAIL][137] ([i915#644]) -> [PASS][138]
   [137]: https://intel-gfx-ci.01.org/

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5871/index.html

[-- Attachment #1.2: Type: text/html, Size: 34088 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests

[Mark Yacoub]

On Tue, Jun 1, 2021 at 7:54 AM Vidya Srinivas <vidya.srinivas@intel.com> wrote:
>
> Few Gen11 systems show CRC mismatch. Make coverage-vs-premult-vs-constant
> code similar to constant_alpha_min or basic_alpha
>
Tested on ChromeOS on JSL (Drawlat)
Tested-by: Mark Yacoub <markyacoub@chromium.org>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
> index a37cb27c7d62..224d79bd1749 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>         igt_display_t *display = &data->display;
>         igt_crc_t ref_crc = {}, crc = {};
>
> -       /* Set a background color on the primary fb for testing */
> -       if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -               igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> -
>         igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>         igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>         igt_display_commit2(display, COMMIT_ATOMIC);
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests

[Mark Yacoub]

On Tue, Jun 1, 2021 at 7:54 AM Vidya Srinivas <vidya.srinivas@intel.com> wrote:
>
> Few Gen11 systems show CRC mismatch. Make coverage-vs-premult-vs-constant
> code similar to constant_alpha_min or basic_alpha
>
Tested on ChromeOS on JSL (Drawlat)
Tested-by: Mark Yacoub <markyacoub@chromium.org>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
> index a37cb27c7d62..224d79bd1749 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>         igt_display_t *display = &data->display;
>         igt_crc_t ref_crc = {}, crc = {};
>
> -       /* Set a background color on the primary fb for testing */
> -       if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -               igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> -
>         igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>         igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>         igt_display_commit2(display, COMMIT_ATOMIC);
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests

[Srinivas, Vidya]

Thank you very much Mark, for testing the patch and providing the "Tested-by" tag.

Regards
Vidya

-----Original Message-----
From: Mark Yacoub <markyacoub@chromium.org> 
Sent: Saturday, June 5, 2021 12:12 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>
Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests

On Tue, Jun 1, 2021 at 7:54 AM Vidya Srinivas <vidya.srinivas@intel.com> wrote:
>
> Few Gen11 systems show CRC mismatch. Make 
> coverage-vs-premult-vs-constant code similar to constant_alpha_min or 
> basic_alpha
>
Tested on ChromeOS on JSL (Drawlat)
Tested-by: Mark Yacoub <markyacoub@chromium.org>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..224d79bd1749 
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>         igt_display_t *display = &data->display;
>         igt_crc_t ref_crc = {}, crc = {};
>
> -       /* Set a background color on the primary fb for testing */
> -       if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -               igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> -
>         igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>         igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>         igt_display_commit2(display, COMMIT_ATOMIC);
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests

[Srinivas, Vidya]

Thank you very much Mark, for testing the patch and providing the "Tested-by" tag.

Regards
Vidya

-----Original Message-----
From: Mark Yacoub <markyacoub@chromium.org> 
Sent: Saturday, June 5, 2021 12:12 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>
Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests

On Tue, Jun 1, 2021 at 7:54 AM Vidya Srinivas <vidya.srinivas@intel.com> wrote:
>
> Few Gen11 systems show CRC mismatch. Make 
> coverage-vs-premult-vs-constant code similar to constant_alpha_min or 
> basic_alpha
>
Tested on ChromeOS on JSL (Drawlat)
Tested-by: Mark Yacoub <markyacoub@chromium.org>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..224d79bd1749 
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>         igt_display_t *display = &data->display;
>         igt_crc_t ref_crc = {}, crc = {};
>
> -       /* Set a background color on the primary fb for testing */
> -       if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -               igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> -
>         igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>         igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>         igt_display_commit2(display, COMMIT_ATOMIC);
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

[Modem, Bhanuprakash]

> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Vidya
> Srinivas
> Sent: Tuesday, June 1, 2021 7:38 PM
> To: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't
> set primary fb color in coverage-vs-premult-vs-constant
> 
> Patch removes setting primary fb color in coverage-vs-premult-vs-constant
> as this is causing CRC mismatch on few Gen11 systems.

I am not sure how Primary plane's bg color causing CRC mismatch.
Also, as this test runs on all planes (those are having the props "alpha" and
"pixel blend mode"), is this test failing on a particular plane?

- Bhanu

> Similar change has already been done in tests constant_alpha_min and
> basic_alpha
> where the test runs on all planes but dont set the primary fb color.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
> index a37cb27c7d62..224d79bd1749 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t *data, enum
> pipe pipe, igt_plane_t
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> 
> -	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> -
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
> --
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

[Modem, Bhanuprakash]

> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Vidya
> Srinivas
> Sent: Tuesday, June 1, 2021 7:38 PM
> To: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't
> set primary fb color in coverage-vs-premult-vs-constant
> 
> Patch removes setting primary fb color in coverage-vs-premult-vs-constant
> as this is causing CRC mismatch on few Gen11 systems.

I am not sure how Primary plane's bg color causing CRC mismatch.
Also, as this test runs on all planes (those are having the props "alpha" and
"pixel blend mode"), is this test failing on a particular plane?

- Bhanu

> Similar change has already been done in tests constant_alpha_min and
> basic_alpha
> where the test runs on all planes but dont set the primary fb color.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
> index a37cb27c7d62..224d79bd1749 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t *data, enum
> pipe pipe, igt_plane_t
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> 
> -	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> -
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
> --
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Thank you Bhanu. This test is failing on all planes > 0. Only plane 0 passes.
If I skip plane 1, it fails on 2 and so on.
Changing the way CRC is being collected also is not helping. Adding vblank is also not helping.

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com> 
Sent: Friday, June 11, 2021 9:11 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of 
> Vidya Srinivas
> Sent: Tuesday, June 1, 2021 7:38 PM
> To: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: 
> Don't set primary fb color in coverage-vs-premult-vs-constant
> 
> Patch removes setting primary fb color in 
> coverage-vs-premult-vs-constant as this is causing CRC mismatch on few Gen11 systems.

I am not sure how Primary plane's bg color causing CRC mismatch.
Also, as this test runs on all planes (those are having the props "alpha" and "pixel blend mode"), is this test failing on a particular plane?

- Bhanu

> Similar change has already been done in tests constant_alpha_min and 
> basic_alpha where the test runs on all planes but dont set the primary 
> fb color.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..224d79bd1749 
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t 
> *data, enum pipe pipe, igt_plane_t
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> 
> -	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> -
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
> --
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Thank you Bhanu. This test is failing on all planes > 0. Only plane 0 passes.
If I skip plane 1, it fails on 2 and so on.
Changing the way CRC is being collected also is not helping. Adding vblank is also not helping.

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com> 
Sent: Friday, June 11, 2021 9:11 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of 
> Vidya Srinivas
> Sent: Tuesday, June 1, 2021 7:38 PM
> To: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: 
> Don't set primary fb color in coverage-vs-premult-vs-constant
> 
> Patch removes setting primary fb color in 
> coverage-vs-premult-vs-constant as this is causing CRC mismatch on few Gen11 systems.

I am not sure how Primary plane's bg color causing CRC mismatch.
Also, as this test runs on all planes (those are having the props "alpha" and "pixel blend mode"), is this test failing on a particular plane?

- Bhanu

> Similar change has already been done in tests constant_alpha_min and 
> basic_alpha where the test runs on all planes but dont set the primary 
> fb color.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..224d79bd1749 
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t 
> *data, enum pipe pipe, igt_plane_t
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> 
> -	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> -
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
> --
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Vidya Srinivas]

Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant as
per the buffer being created initially in prepare_crtc. Patch also
add commit after setting fb on primary plane. Without this change
CRC mismatch is seen on few Gen11 systems.

Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..d3a73cf43fcd 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_crc_t ref_crc = {}, crc = {};
 
 	/* Set a background color on the primary fb for testing */
-	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
+	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
 		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
+		igt_display_commit2(display, COMMIT_ATOMIC);
+	}
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
+	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_start(data->pipe_crc);
 	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Pre-multiplied");
+	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
 	igt_plane_set_fb(plane, &data->argb_fb_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
 	igt_assert_crc_equal(&ref_crc, &crc);
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
-	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
+	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
 	igt_assert_crc_equal(&ref_crc, &crc);
 
 	igt_pipe_crc_stop(data->pipe_crc);
+
 }
 
 static void run_test_on_pipe_planes(data_t *data, enum pipe pipe, bool blend,
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Hello Bhanu,

I have uploaded version 3 where I have not removed primary plane.
Instead I have added a commit of the primary plane and I have changed alpha.
This passes on Gen11 systems.

Kindly check https://patchwork.freedesktop.org/patch/438831/?series=90828&rev=3 and suggest.

Thank you so much.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Friday, June 11, 2021 1:00 PM
To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Thank you Bhanu. This test is failing on all planes > 0. Only plane 0 passes.
If I skip plane 1, it fails on 2 and so on.
Changing the way CRC is being collected also is not helping. Adding vblank is also not helping.

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
Sent: Friday, June 11, 2021 9:11 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of 
> Vidya Srinivas
> Sent: Tuesday, June 1, 2021 7:38 PM
> To: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: 
> Don't set primary fb color in coverage-vs-premult-vs-constant
> 
> Patch removes setting primary fb color in 
> coverage-vs-premult-vs-constant as this is causing CRC mismatch on few Gen11 systems.

I am not sure how Primary plane's bg color causing CRC mismatch.
Also, as this test runs on all planes (those are having the props "alpha" and "pixel blend mode"), is this test failing on a particular plane?

- Bhanu

> Similar change has already been done in tests constant_alpha_min and 
> basic_alpha where the test runs on all planes but dont set the primary 
> fb color.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..224d79bd1749
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t 
> *data, enum pipe pipe, igt_plane_t
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> 
> -	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> -
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
> --
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Hello Bhanu,

I have uploaded version 3 where I have not removed primary plane.
Instead I have added a commit of the primary plane and I have changed alpha.
This passes on Gen11 systems.

Kindly check https://patchwork.freedesktop.org/patch/438831/?series=90828&rev=3 and suggest.

Thank you so much.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Friday, June 11, 2021 1:00 PM
To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Thank you Bhanu. This test is failing on all planes > 0. Only plane 0 passes.
If I skip plane 1, it fails on 2 and so on.
Changing the way CRC is being collected also is not helping. Adding vblank is also not helping.

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
Sent: Friday, June 11, 2021 9:11 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of 
> Vidya Srinivas
> Sent: Tuesday, June 1, 2021 7:38 PM
> To: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: 
> Don't set primary fb color in coverage-vs-premult-vs-constant
> 
> Patch removes setting primary fb color in 
> coverage-vs-premult-vs-constant as this is causing CRC mismatch on few Gen11 systems.

I am not sure how Primary plane's bg color causing CRC mismatch.
Also, as this test runs on all planes (those are having the props "alpha" and "pixel blend mode"), is this test failing on a particular plane?

- Bhanu

> Similar change has already been done in tests constant_alpha_min and 
> basic_alpha where the test runs on all planes but dont set the primary 
> fb color.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..224d79bd1749
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t 
> *data, enum pipe pipe, igt_plane_t
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> 
> -	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> -
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
> --
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev3)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 7117 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev3)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10212 -> IGTPW_5913
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_5913:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@runner@aborted:
    - {fi-jsl-1}:         NOTRUN -> [FAIL][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/fi-jsl-1/igt@runner@aborted.html

  
Known issues
------------

  Here are the changes found in IGTPW_5913 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@core_hotunplug@unbind-rebind:
    - fi-bdw-5557u:       NOTRUN -> [WARN][2] ([i915#2283])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html

  * igt@i915_selftest@live@execlists:
    - fi-bdw-5557u:       NOTRUN -> [DMESG-FAIL][3] ([i915#3462])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/fi-bdw-5557u/igt@i915_selftest@live@execlists.html

  * igt@kms_psr@cursor_plane_move:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][4] ([fdo#109271]) +5 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/fi-bdw-5557u/igt@kms_psr@cursor_plane_move.html

  
#### Warnings ####

  * igt@i915_selftest@live@execlists:
    - fi-bsw-nick:        [DMESG-FAIL][5] ([i915#3462]) -> [INCOMPLETE][6] ([i915#2782] / [i915#2940] / [i915#3462])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/fi-bsw-nick/igt@i915_selftest@live@execlists.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/fi-bsw-nick/igt@i915_selftest@live@execlists.html
    - fi-cml-s:           [DMESG-FAIL][7] ([i915#3462]) -> [INCOMPLETE][8] ([i915#3462])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/fi-cml-s/igt@i915_selftest@live@execlists.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/fi-cml-s/igt@i915_selftest@live@execlists.html

  * igt@runner@aborted:
    - fi-skl-6600u:       [FAIL][9] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][10] ([i915#1436] / [i915#3363])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/fi-skl-6600u/igt@runner@aborted.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/fi-skl-6600u/igt@runner@aborted.html
    - fi-glk-dsi:         [FAIL][11] ([i915#2426] / [i915#3363] / [k.org#202321]) -> [FAIL][12] ([i915#3363] / [k.org#202321])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/fi-glk-dsi/igt@runner@aborted.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/fi-glk-dsi/igt@runner@aborted.html
    - fi-bdw-5557u:       [FAIL][13] ([i915#1602] / [i915#2029]) -> [FAIL][14] ([i915#3462])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/fi-bdw-5557u/igt@runner@aborted.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/fi-bdw-5557u/igt@runner@aborted.html
    - fi-kbl-soraka:      [FAIL][15] ([i915#1436] / [i915#3363]) -> [FAIL][16] ([i915#1436] / [i915#2426] / [i915#3363])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/fi-kbl-soraka/igt@runner@aborted.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/fi-kbl-soraka/igt@runner@aborted.html
    - fi-kbl-guc:         [FAIL][17] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][18] ([i915#1436] / [i915#3363])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/fi-kbl-guc/igt@runner@aborted.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/fi-kbl-guc/igt@runner@aborted.html
    - fi-cml-u2:          [FAIL][19] ([i915#3363] / [i915#3462]) -> [FAIL][20] ([i915#2082] / [i915#2426] / [i915#3363] / [i915#3462])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/fi-cml-u2/igt@runner@aborted.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/fi-cml-u2/igt@runner@aborted.html
    - fi-cfl-guc:         [FAIL][21] ([i915#2426] / [i915#3363]) -> [FAIL][22] ([i915#3363])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/fi-cfl-guc/igt@runner@aborted.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/fi-cfl-guc/igt@runner@aborted.html
    - fi-skl-guc:         [FAIL][23] ([i915#1436] / [i915#3363]) -> [FAIL][24] ([i915#1436] / [i915#2426] / [i915#3363])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/fi-skl-guc/igt@runner@aborted.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/fi-skl-guc/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
  [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
  [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
  [i915#2082]: https://gitlab.freedesktop.org/drm/intel/issues/2082
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
  [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
  [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
  [i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
  [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
  [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
  [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
  [i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321


Participating hosts (46 -> 39)
------------------------------

  Additional (1): fi-jsl-1 
  Missing    (8): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan bat-adlp-4 bat-adls-4 fi-dg1-1 fi-bdw-samus bat-jsl-1 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6104 -> IGTPW_5913

  CI-20190529: 20190529
  CI_DRM_10212: d6a4e59ffc78a058586d57930708ba706d765be4 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_5913: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/index.html
  IGT_6104: f8f81bd3752f3126a47d9dbba2d0ab29f7c17a19 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/index.html

[-- Attachment #1.2: Type: text/html, Size: 9640 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev3)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 30295 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev3)
URL   : https://patchwork.freedesktop.org/series/90828/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10212_full -> IGTPW_5913_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_5913_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_5913_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_5913_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_ccs@pipe-b-crc-primary-rotation-180:
    - shard-glk:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-glk8/igt@kms_ccs@pipe-b-crc-primary-rotation-180.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-glk4/igt@kms_ccs@pipe-b-crc-primary-rotation-180.html

  
Known issues
------------

  Here are the changes found in IGTPW_5913_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@feature_discovery@chamelium:
    - shard-iclb:         NOTRUN -> [SKIP][3] ([fdo#111827])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb8/igt@feature_discovery@chamelium.html

  * igt@gem_ctx_persistence@legacy-engines-mixed-process:
    - shard-snb:          NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +5 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-snb5/igt@gem_ctx_persistence@legacy-engines-mixed-process.html

  * igt@gem_ctx_persistence@many-contexts:
    - shard-tglb:         [PASS][5] -> [FAIL][6] ([i915#2410])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-tglb7/igt@gem_ctx_persistence@many-contexts.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb5/igt@gem_ctx_persistence@many-contexts.html

  * igt@gem_eio@in-flight-contexts-10ms:
    - shard-tglb:         [PASS][7] -> [TIMEOUT][8] ([i915#3063])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-tglb5/igt@gem_eio@in-flight-contexts-10ms.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb5/igt@gem_eio@in-flight-contexts-10ms.html

  * igt@gem_eio@in-flight-external:
    - shard-glk:          [PASS][9] -> [DMESG-WARN][10] ([i915#118] / [i915#95]) +2 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-glk5/igt@gem_eio@in-flight-external.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-glk4/igt@gem_eio@in-flight-external.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-apl:          NOTRUN -> [FAIL][11] ([i915#2846])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl3/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-iclb:         [PASS][12] -> [FAIL][13] ([i915#2842])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb4/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-none@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][14] ([i915#2842]) +4 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb1/igt@gem_exec_fair@basic-none@vcs1.html

  * igt@gem_exec_fair@basic-pace@bcs0:
    - shard-tglb:         NOTRUN -> [FAIL][15] ([i915#2842]) +3 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb5/igt@gem_exec_fair@basic-pace@bcs0.html

  * igt@gem_exec_fair@basic-pace@rcs0:
    - shard-kbl:          NOTRUN -> [FAIL][16] ([i915#2842]) +1 similar issue
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl3/igt@gem_exec_fair@basic-pace@rcs0.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-iclb:         [PASS][17] -> [FAIL][18] ([i915#2849])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_exec_reloc@basic-wide-active@rcs0:
    - shard-snb:          NOTRUN -> [FAIL][19] ([i915#2389]) +2 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-snb2/igt@gem_exec_reloc@basic-wide-active@rcs0.html

  * igt@gem_exec_reloc@basic-wide-active@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][20] ([i915#2389])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb4/igt@gem_exec_reloc@basic-wide-active@vcs1.html

  * igt@gem_huc_copy@huc-copy:
    - shard-tglb:         [PASS][21] -> [SKIP][22] ([i915#2190])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-tglb2/igt@gem_huc_copy@huc-copy.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb6/igt@gem_huc_copy@huc-copy.html
    - shard-iclb:         NOTRUN -> [SKIP][23] ([i915#2190])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb1/igt@gem_huc_copy@huc-copy.html

  * igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled:
    - shard-iclb:         NOTRUN -> [SKIP][24] ([i915#768])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb2/igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled.html

  * igt@gem_userptr_blits@coherency-sync:
    - shard-iclb:         NOTRUN -> [SKIP][25] ([fdo#109290])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb5/igt@gem_userptr_blits@coherency-sync.html

  * igt@gen7_exec_parse@chained-batch:
    - shard-iclb:         NOTRUN -> [SKIP][26] ([fdo#109289])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb4/igt@gen7_exec_parse@chained-batch.html

  * igt@gen9_exec_parse@batch-invalid-length:
    - shard-snb:          NOTRUN -> [SKIP][27] ([fdo#109271]) +443 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-snb6/igt@gen9_exec_parse@batch-invalid-length.html

  * igt@gen9_exec_parse@cmd-crossing-page:
    - shard-tglb:         NOTRUN -> [SKIP][28] ([fdo#112306])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb2/igt@gen9_exec_parse@cmd-crossing-page.html
    - shard-iclb:         NOTRUN -> [SKIP][29] ([fdo#112306])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb4/igt@gen9_exec_parse@cmd-crossing-page.html

  * igt@i915_pm_dc@dc6-psr:
    - shard-iclb:         [PASS][30] -> [FAIL][31] ([i915#454])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-iclb5/igt@i915_pm_dc@dc6-psr.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb6/igt@i915_pm_dc@dc6-psr.html

  * igt@i915_selftest@live@execlists:
    - shard-apl:          NOTRUN -> [DMESG-FAIL][32] ([i915#3462])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl8/igt@i915_selftest@live@execlists.html

  * igt@kms_big_fb@linear-32bpp-rotate-270:
    - shard-iclb:         NOTRUN -> [SKIP][33] ([fdo#110725] / [fdo#111614])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb2/igt@kms_big_fb@linear-32bpp-rotate-270.html

  * igt@kms_big_joiner@basic:
    - shard-tglb:         NOTRUN -> [SKIP][34] ([i915#2705])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb2/igt@kms_big_joiner@basic.html
    - shard-iclb:         NOTRUN -> [SKIP][35] ([i915#2705])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb4/igt@kms_big_joiner@basic.html

  * igt@kms_chamelium@common-hpd-after-suspend:
    - shard-glk:          NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +3 similar issues
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-glk6/igt@kms_chamelium@common-hpd-after-suspend.html

  * igt@kms_chamelium@dp-mode-timings:
    - shard-apl:          NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +19 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl6/igt@kms_chamelium@dp-mode-timings.html

  * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
    - shard-snb:          NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +24 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-snb6/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
    - shard-kbl:          NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +7 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl7/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
    - shard-iclb:         NOTRUN -> [SKIP][40] ([fdo#109284] / [fdo#111827]) +5 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb5/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html

  * igt@kms_color_chamelium@pipe-d-ctm-max:
    - shard-tglb:         NOTRUN -> [SKIP][41] ([fdo#109284] / [fdo#111827]) +3 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb2/igt@kms_color_chamelium@pipe-d-ctm-max.html
    - shard-iclb:         NOTRUN -> [SKIP][42] ([fdo#109278] / [fdo#109284] / [fdo#111827])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb6/igt@kms_color_chamelium@pipe-d-ctm-max.html

  * igt@kms_content_protection@dp-mst-lic-type-0:
    - shard-iclb:         NOTRUN -> [SKIP][43] ([i915#3116])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb8/igt@kms_content_protection@dp-mst-lic-type-0.html
    - shard-tglb:         NOTRUN -> [SKIP][44] ([i915#3116])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb1/igt@kms_content_protection@dp-mst-lic-type-0.html

  * igt@kms_content_protection@legacy:
    - shard-iclb:         NOTRUN -> [SKIP][45] ([fdo#109300] / [fdo#111066]) +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb3/igt@kms_content_protection@legacy.html
    - shard-kbl:          NOTRUN -> [TIMEOUT][46] ([i915#1319]) +1 similar issue
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl2/igt@kms_content_protection@legacy.html
    - shard-apl:          NOTRUN -> [TIMEOUT][47] ([i915#1319])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl6/igt@kms_content_protection@legacy.html

  * igt@kms_content_protection@srm:
    - shard-tglb:         NOTRUN -> [SKIP][48] ([fdo#111828]) +1 similar issue
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb1/igt@kms_content_protection@srm.html

  * igt@kms_content_protection@uevent:
    - shard-apl:          NOTRUN -> [FAIL][49] ([i915#2105])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl1/igt@kms_content_protection@uevent.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][50] -> [DMESG-WARN][51] ([i915#180]) +1 similar issue
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-b-cursor-32x10-random:
    - shard-kbl:          NOTRUN -> [SKIP][52] ([fdo#109271]) +38 similar issues
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl7/igt@kms_cursor_crc@pipe-b-cursor-32x10-random.html
    - shard-tglb:         NOTRUN -> [SKIP][53] ([i915#3359]) +2 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb1/igt@kms_cursor_crc@pipe-b-cursor-32x10-random.html

  * igt@kms_cursor_crc@pipe-b-cursor-512x512-rapid-movement:
    - shard-iclb:         NOTRUN -> [SKIP][54] ([fdo#109278] / [fdo#109279])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb4/igt@kms_cursor_crc@pipe-b-cursor-512x512-rapid-movement.html

  * igt@kms_cursor_crc@pipe-c-cursor-32x32-rapid-movement:
    - shard-tglb:         NOTRUN -> [SKIP][55] ([i915#3319])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb8/igt@kms_cursor_crc@pipe-c-cursor-32x32-rapid-movement.html

  * igt@kms_cursor_crc@pipe-d-cursor-32x10-offscreen:
    - shard-iclb:         NOTRUN -> [SKIP][56] ([fdo#109278]) +12 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb7/igt@kms_cursor_crc@pipe-d-cursor-32x10-offscreen.html

  * igt@kms_cursor_crc@pipe-d-cursor-512x512-onscreen:
    - shard-tglb:         NOTRUN -> [SKIP][57] ([fdo#109279] / [i915#3359])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb8/igt@kms_cursor_crc@pipe-d-cursor-512x512-onscreen.html

  * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
    - shard-glk:          NOTRUN -> [FAIL][58] ([i915#72])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html

  * igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size:
    - shard-iclb:         NOTRUN -> [SKIP][59] ([fdo#109274] / [fdo#109278]) +1 similar issue
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb1/igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-kbl:          [PASS][60] -> [INCOMPLETE][61] ([i915#155] / [i915#180] / [i915#636])
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
    - shard-iclb:         NOTRUN -> [SKIP][62] ([fdo#109274]) +2 similar issues
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb3/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible.html

  * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
    - shard-kbl:          NOTRUN -> [DMESG-WARN][63] ([i915#180]) +2 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt:
    - shard-iclb:         NOTRUN -> [SKIP][64] ([fdo#109280]) +9 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-mmap-gtt:
    - shard-tglb:         NOTRUN -> [SKIP][65] ([fdo#111825]) +8 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-mmap-gtt.html

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render:
    - shard-glk:          NOTRUN -> [SKIP][66] ([fdo#109271]) +21 similar issues
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-glk3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render.html

  * igt@kms_hdr@static-toggle-suspend:
    - shard-tglb:         NOTRUN -> [SKIP][67] ([i915#1187])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb1/igt@kms_hdr@static-toggle-suspend.html
    - shard-iclb:         NOTRUN -> [SKIP][68] ([i915#1187]) +1 similar issue
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb2/igt@kms_hdr@static-toggle-suspend.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - shard-apl:          NOTRUN -> [DMESG-WARN][69] ([i915#180])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
    - shard-apl:          NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#533]) +1 similar issue
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
    - shard-apl:          NOTRUN -> [FAIL][71] ([fdo#108145] / [i915#265]) +4 similar issues
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
    - shard-glk:          NOTRUN -> [FAIL][72] ([i915#265])
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-glk1/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
    - shard-kbl:          NOTRUN -> [FAIL][73] ([i915#265])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl7/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
    - shard-tglb:         NOTRUN -> [SKIP][74] ([fdo#111615]) +1 similar issue
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb6/igt@kms_plane_multiple@atomic-pipe-b-tiling-yf.html

  * igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
    - shard-apl:          NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#658]) +5 similar issues
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl1/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html

  * igt@kms_psr@psr2_dpms:
    - shard-iclb:         [PASS][76] -> [SKIP][77] ([fdo#109441]) +1 similar issue
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-iclb2/igt@kms_psr@psr2_dpms.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb5/igt@kms_psr@psr2_dpms.html

  * igt@kms_psr@psr2_primary_render:
    - shard-iclb:         NOTRUN -> [SKIP][78] ([fdo#109441])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb7/igt@kms_psr@psr2_primary_render.html

  * igt@kms_vblank@pipe-d-ts-continuation-idle:
    - shard-apl:          NOTRUN -> [SKIP][79] ([fdo#109271]) +262 similar issues
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl6/igt@kms_vblank@pipe-d-ts-continuation-idle.html

  * igt@kms_writeback@writeback-invalid-parameters:
    - shard-iclb:         NOTRUN -> [SKIP][80] ([i915#2437])
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb1/igt@kms_writeback@writeback-invalid-parameters.html

  * igt@nouveau_crc@pipe-a-source-rg:
    - shard-iclb:         NOTRUN -> [SKIP][81] ([i915#2530]) +1 similar issue
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb3/igt@nouveau_crc@pipe-a-source-rg.html
    - shard-tglb:         NOTRUN -> [SKIP][82] ([i915#2530]) +1 similar issue
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb8/igt@nouveau_crc@pipe-a-source-rg.html

  * igt@perf@polling-parameterized:
    - shard-apl:          NOTRUN -> [FAIL][83] ([i915#1542])
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl6/igt@perf@polling-parameterized.html

  * igt@prime_nv_api@i915_nv_import_twice:
    - shard-iclb:         NOTRUN -> [SKIP][84] ([fdo#109291])
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb2/igt@prime_nv_api@i915_nv_import_twice.html

  * igt@prime_vgem@fence-flip-hang:
    - shard-iclb:         NOTRUN -> [SKIP][85] ([fdo#109295])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb8/igt@prime_vgem@fence-flip-hang.html
    - shard-tglb:         NOTRUN -> [SKIP][86] ([fdo#109295])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb1/igt@prime_vgem@fence-flip-hang.html

  * igt@sysfs_clients@create:
    - shard-apl:          NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#2994]) +2 similar issues
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl2/igt@sysfs_clients@create.html

  * igt@sysfs_clients@pidname:
    - shard-iclb:         NOTRUN -> [SKIP][88] ([i915#2994])
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb6/igt@sysfs_clients@pidname.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@preservation-s3@rcs0:
    - shard-kbl:          [DMESG-WARN][89] ([i915#180]) -> [PASS][90]
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@rcs0.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl2/igt@gem_ctx_isolation@preservation-s3@rcs0.html

  * igt@gem_eio@suspend:
    - shard-iclb:         [INCOMPLETE][91] ([i915#1185]) -> [PASS][92]
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-iclb3/igt@gem_eio@suspend.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb1/igt@gem_eio@suspend.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-apl:          [SKIP][93] ([fdo#109271]) -> [PASS][94]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-apl1/igt@gem_exec_fair@basic-none-share@rcs0.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl7/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-none-vip@rcs0:
    - shard-glk:          [FAIL][95] ([i915#2842]) -> [PASS][96]
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-glk3/igt@gem_exec_fair@basic-none-vip@rcs0.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-glk7/igt@gem_exec_fair@basic-none-vip@rcs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-tglb:         [FAIL][97] ([i915#2842]) -> [PASS][98]
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_mmap_gtt@cpuset-big-copy-xy:
    - shard-iclb:         [FAIL][99] ([i915#2428]) -> [PASS][100]
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-iclb1/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb7/igt@gem_mmap_gtt@cpuset-big-copy-xy.html

  * igt@i915_selftest@live@hangcheck:
    - shard-snb:          [INCOMPLETE][101] ([i915#2782]) -> [PASS][102]
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-snb5/igt@i915_selftest@live@hangcheck.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-snb7/igt@i915_selftest@live@hangcheck.html

  * igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled:
    - shard-glk:          [FAIL][103] -> [PASS][104] +1 similar issue
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-glk8/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-glk7/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-apl:          [INCOMPLETE][105] ([i915#180]) -> [PASS][106]
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
    - shard-glk:          [FAIL][107] ([i915#79]) -> [PASS][108]
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html

  * igt@kms_flip@plain-flip-ts-check@a-hdmi-a2:
    - shard-glk:          [FAIL][109] ([i915#2122]) -> [PASS][110]
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-glk6/igt@kms_flip@plain-flip-ts-check@a-hdmi-a2.html
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-glk6/igt@kms_flip@plain-flip-ts-check@a-hdmi-a2.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [SKIP][111] ([fdo#109441]) -> [PASS][112] +3 similar issues
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-iclb3/igt@kms_psr@psr2_cursor_render.html
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

  * igt@perf@polling-parameterized:
    - shard-iclb:         [FAIL][113] ([i915#1542]) -> [PASS][114]
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-iclb7/igt@perf@polling-parameterized.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb3/igt@perf@polling-parameterized.html

  * igt@perf_pmu@rc6-suspend:
    - shard-apl:          [DMESG-WARN][115] ([i915#180]) -> [PASS][116]
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-apl7/igt@perf_pmu@rc6-suspend.html
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl3/igt@perf_pmu@rc6-suspend.html

  
#### Warnings ####

  * igt@i915_pm_dc@dc3co-vpb-simulation:
    - shard-iclb:         [SKIP][117] ([i915#588]) -> [SKIP][118] ([i915#658])
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb8/igt@i915_pm_dc@dc3co-vpb-simulation.html

  * igt@i915_pm_rc6_residency@rc6-fence:
    - shard-iclb:         [WARN][119] ([i915#1804] / [i915#2684]) -> [WARN][120] ([i915#2684])
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html

  * igt@i915_selftest@live@execlists:
    - shard-tglb:         [DMESG-FAIL][121] ([i915#3462]) -> [INCOMPLETE][122] ([i915#3462])
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-tglb1/igt@i915_selftest@live@execlists.html
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb3/igt@i915_selftest@live@execlists.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
    - shard-iclb:         [SKIP][123] ([i915#2920]) -> [SKIP][124] ([i915#658]) +2 similar issues
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
    - shard-iclb:         [SKIP][125] ([i915#658]) -> [SKIP][126] ([i915#2920])
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-iclb5/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html

  * igt@runner@aborted:
    - shard-kbl:          ([FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131]) ([i915#1436] / [i915#180] / [i915#3002] / [i915#3363]) -> ([FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363] / [i915#92])
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-kbl1/igt@runner@aborted.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-kbl1/igt@runner@aborted.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-kbl1/igt@runner@aborted.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-kbl7/igt@runner@aborted.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-kbl7/igt@runner@aborted.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl6/igt@runner@aborted.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl1/igt@runner@aborted.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl7/igt@runner@aborted.html
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl6/igt@runner@aborted.html
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl1/igt@runner@aborted.html
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl1/igt@runner@aborted.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-kbl1/igt@runner@aborted.html
    - shard-apl:          ([FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143]) ([fdo#109271] / [i915#1610] / [i915#180] / [i915#1814] / [i915#2292] / [i915#3363]) -> ([FAIL][144], [FAIL][145]) ([fdo#109271] / [i915#1814] / [i915#3363])
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-apl6/igt@runner@aborted.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-apl6/igt@runner@aborted.html
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-apl7/igt@runner@aborted.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-apl6/igt@runner@aborted.html
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-apl7/igt@runner@aborted.html
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl8/igt@runner@aborted.html
   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-apl7/igt@runner@aborted.html
    - shard-tglb:         ([FAIL][146], [FAIL][147], [FAIL][148]) ([i915#1436] / [i915#2426] / [i915#2966] / [i915#3002]) -> ([FAIL][149], [FAIL][150]) ([i915#1436] / [i915#2966] / [i915#3002])
   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-tglb3/igt@runner@aborted.html
   [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-tglb1/igt@runner@aborted.html
   [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10212/shard-tglb8/igt@runner@aborted.html
   [149]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb3/igt@runner@aborted.html
   [150]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/shard-tglb6/igt@runner@aborted.html

  
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109271]: https://bugs.freedesktop.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5913/index.html

[-- Attachment #1.2: Type: text/html, Size: 34617 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Hello Bhanu,

Sorry for the trouble. Kindly can you check if rev 3 is okay? Thanks a lot.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Friday, June 11, 2021 6:28 PM
To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Hello Bhanu,

I have uploaded version 3 where I have not removed primary plane.
Instead I have added a commit of the primary plane and I have changed alpha.
This passes on Gen11 systems.

Kindly check https://patchwork.freedesktop.org/patch/438831/?series=90828&rev=3 and suggest.

Thank you so much.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya
Sent: Friday, June 11, 2021 1:00 PM
To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Thank you Bhanu. This test is failing on all planes > 0. Only plane 0 passes.
If I skip plane 1, it fails on 2 and so on.
Changing the way CRC is being collected also is not helping. Adding vblank is also not helping.

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
Sent: Friday, June 11, 2021 9:11 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of 
> Vidya Srinivas
> Sent: Tuesday, June 1, 2021 7:38 PM
> To: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: 
> Don't set primary fb color in coverage-vs-premult-vs-constant
> 
> Patch removes setting primary fb color in 
> coverage-vs-premult-vs-constant as this is causing CRC mismatch on few Gen11 systems.

I am not sure how Primary plane's bg color causing CRC mismatch.
Also, as this test runs on all planes (those are having the props "alpha" and "pixel blend mode"), is this test failing on a particular plane?

- Bhanu

> Similar change has already been done in tests constant_alpha_min and 
> basic_alpha where the test runs on all planes but dont set the primary 
> fb color.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..224d79bd1749
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t 
> *data, enum pipe pipe, igt_plane_t
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> 
> -	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> -
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
> --
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Hello Bhanu,

Sorry for the trouble. Kindly can you check if rev 3 is okay? Thanks a lot.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Friday, June 11, 2021 6:28 PM
To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Hello Bhanu,

I have uploaded version 3 where I have not removed primary plane.
Instead I have added a commit of the primary plane and I have changed alpha.
This passes on Gen11 systems.

Kindly check https://patchwork.freedesktop.org/patch/438831/?series=90828&rev=3 and suggest.

Thank you so much.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya
Sent: Friday, June 11, 2021 1:00 PM
To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Thank you Bhanu. This test is failing on all planes > 0. Only plane 0 passes.
If I skip plane 1, it fails on 2 and so on.
Changing the way CRC is being collected also is not helping. Adding vblank is also not helping.

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
Sent: Friday, June 11, 2021 9:11 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of 
> Vidya Srinivas
> Sent: Tuesday, June 1, 2021 7:38 PM
> To: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: 
> Don't set primary fb color in coverage-vs-premult-vs-constant
> 
> Patch removes setting primary fb color in 
> coverage-vs-premult-vs-constant as this is causing CRC mismatch on few Gen11 systems.

I am not sure how Primary plane's bg color causing CRC mismatch.
Also, as this test runs on all planes (those are having the props "alpha" and "pixel blend mode"), is this test failing on a particular plane?

- Bhanu

> Similar change has already been done in tests constant_alpha_min and 
> basic_alpha where the test runs on all planes but dont set the primary 
> fb color.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..224d79bd1749
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t 
> *data, enum pipe pipe, igt_plane_t
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> 
> -	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> -
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
> --
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Hello,

Humble request for review of this please https://patchwork.freedesktop.org/series/90828/
Can anyone kindly help review this so we can request for merge?

Thank you so much.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Tuesday, June 15, 2021 1:55 PM
To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Cc: Shankar, Uma <uma.shankar@intel.com>
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Hello Bhanu,

Sorry for the trouble. Kindly can you check if rev 3 is okay? Thanks a lot.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya
Sent: Friday, June 11, 2021 6:28 PM
To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Hello Bhanu,

I have uploaded version 3 where I have not removed primary plane.
Instead I have added a commit of the primary plane and I have changed alpha.
This passes on Gen11 systems.

Kindly check https://patchwork.freedesktop.org/patch/438831/?series=90828&rev=3 and suggest.

Thank you so much.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya
Sent: Friday, June 11, 2021 1:00 PM
To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Thank you Bhanu. This test is failing on all planes > 0. Only plane 0 passes.
If I skip plane 1, it fails on 2 and so on.
Changing the way CRC is being collected also is not helping. Adding vblank is also not helping.

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
Sent: Friday, June 11, 2021 9:11 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of 
> Vidya Srinivas
> Sent: Tuesday, June 1, 2021 7:38 PM
> To: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: 
> Don't set primary fb color in coverage-vs-premult-vs-constant
> 
> Patch removes setting primary fb color in 
> coverage-vs-premult-vs-constant as this is causing CRC mismatch on few Gen11 systems.

I am not sure how Primary plane's bg color causing CRC mismatch.
Also, as this test runs on all planes (those are having the props "alpha" and "pixel blend mode"), is this test failing on a particular plane?

- Bhanu

> Similar change has already been done in tests constant_alpha_min and 
> basic_alpha where the test runs on all planes but dont set the primary 
> fb color.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..224d79bd1749
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t 
> *data, enum pipe pipe, igt_plane_t
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> 
> -	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> -
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
> --
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Hello,

Humble request for review of this please https://patchwork.freedesktop.org/series/90828/
Can anyone kindly help review this so we can request for merge?

Thank you so much.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Tuesday, June 15, 2021 1:55 PM
To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Cc: Shankar, Uma <uma.shankar@intel.com>
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Hello Bhanu,

Sorry for the trouble. Kindly can you check if rev 3 is okay? Thanks a lot.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya
Sent: Friday, June 11, 2021 6:28 PM
To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Hello Bhanu,

I have uploaded version 3 where I have not removed primary plane.
Instead I have added a commit of the primary plane and I have changed alpha.
This passes on Gen11 systems.

Kindly check https://patchwork.freedesktop.org/patch/438831/?series=90828&rev=3 and suggest.

Thank you so much.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya
Sent: Friday, June 11, 2021 1:00 PM
To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

Thank you Bhanu. This test is failing on all planes > 0. Only plane 0 passes.
If I skip plane 1, it fails on 2 and so on.
Changing the way CRC is being collected also is not helping. Adding vblank is also not helping.

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
Sent: Friday, June 11, 2021 9:11 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of 
> Vidya Srinivas
> Sent: Tuesday, June 1, 2021 7:38 PM
> To: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: 
> Don't set primary fb color in coverage-vs-premult-vs-constant
> 
> Patch removes setting primary fb color in 
> coverage-vs-premult-vs-constant as this is causing CRC mismatch on few Gen11 systems.

I am not sure how Primary plane's bg color causing CRC mismatch.
Also, as this test runs on all planes (those are having the props "alpha" and "pixel blend mode"), is this test failing on a particular plane?

- Bhanu

> Similar change has already been done in tests constant_alpha_min and 
> basic_alpha where the test runs on all planes but dont set the primary 
> fb color.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..224d79bd1749
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t 
> *data, enum pipe pipe, igt_plane_t
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> 
> -	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> -
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
> --
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Juha-Pekka Heikkila]

On 11.6.2021 15.44, Vidya Srinivas wrote:
> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant as
> per the buffer being created initially in prepare_crtc. Patch also
> add commit after setting fb on primary plane. Without this change
> CRC mismatch is seen on few Gen11 systems.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>   tests/kms_plane_alpha_blend.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
> index a37cb27c7d62..d3a73cf43fcd 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>   	igt_crc_t ref_crc = {}, crc = {};
>   
>   	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>   		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> +		igt_display_commit2(display, COMMIT_ATOMIC);

Why this extra commit needed? There's just below commit before crc is 
started

> +	}
>   
>   	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);

On this test there's already per pixel alpha, setting plane alpha values 
so low will probably in this case in final rounding make these planes 
completely invisible. I'd suspect you can get any image pass crc doing 
it like this. Likely what you see on screen with these values is just 
pure grey instead of intended test image.


>   	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>   	igt_display_commit2(display, COMMIT_ATOMIC);
>   	igt_pipe_crc_start(data->pipe_crc);
>   	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>   
>   	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Pre-multiplied");
> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>   	igt_plane_set_fb(plane, &data->argb_fb_7e);
>   	igt_display_commit2(display, COMMIT_ATOMIC);
>   	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>   	igt_assert_crc_equal(&ref_crc, &crc);
>   
>   	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>   	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>   	igt_display_commit2(display, COMMIT_ATOMIC);
>   	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>   	igt_assert_crc_equal(&ref_crc, &crc);
>   
>   	igt_pipe_crc_stop(data->pipe_crc);
> +

stray new line

>   }
>   
>   static void run_test_on_pipe_planes(data_t *data, enum pipe pipe, bool blend,
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Thank you so much Juha-Pekka. 

https://patchwork.freedesktop.org/patch/436194/?series=90828&rev=2 just removes the DRM_PLANE_TYPE_PRIMARY fb setting from subtest
That works. Would that be an okay change?

Because without the commit after PRIMARY and alpha value 0x7e, JSL is failing. If we just don’t do the PRIMARY fb setting at start, test works as is.

Kindly suggest. Thank you very much once again.

Regards
Vidya

-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> 
Sent: Friday, June 18, 2021 2:23 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

On 11.6.2021 15.44, Vidya Srinivas wrote:
> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant as 
> per the buffer being created initially in prepare_crtc. Patch also add 
> commit after setting fb on primary plane. Without this change CRC 
> mismatch is seen on few Gen11 systems.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>   tests/kms_plane_alpha_blend.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..d3a73cf43fcd 
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>   	igt_crc_t ref_crc = {}, crc = {};
>   
>   	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>   		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], 
> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> +		igt_display_commit2(display, COMMIT_ATOMIC);

Why this extra commit needed? There's just below commit before crc is started

> +	}
>   
>   	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
> "Coverage");
> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);

On this test there's already per pixel alpha, setting plane alpha values so low will probably in this case in final rounding make these planes completely invisible. I'd suspect you can get any image pass crc doing it like this. Likely what you see on screen with these values is just pure grey instead of intended test image.


>   	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>   	igt_display_commit2(display, COMMIT_ATOMIC);
>   	igt_pipe_crc_start(data->pipe_crc);
>   	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>   
>   	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
> "Pre-multiplied");
> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>   	igt_plane_set_fb(plane, &data->argb_fb_7e);
>   	igt_display_commit2(display, COMMIT_ATOMIC);
>   	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>   	igt_assert_crc_equal(&ref_crc, &crc);
>   
>   	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>   	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>   	igt_display_commit2(display, COMMIT_ATOMIC);
>   	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>   	igt_assert_crc_equal(&ref_crc, &crc);
>   
>   	igt_pipe_crc_stop(data->pipe_crc);
> +

stray new line

>   }
>   
>   static void run_test_on_pipe_planes(data_t *data, enum pipe pipe, 
> bool blend,
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Juha-Pekka Heikkila]

Have you tried looking if on kernel side in intel_display.c 
icl_set_pipe_chicken(..) those icl related WAs have effect on your crc 
problem. Sound like setting PER_PIXEL_ALPHA_BYPASS_EN and 
PIXEL_ROUNDING_TRUNC_FB_PASSTHRU touch exactly the problem you are 
seeing. Maybe different hw revision behave differently? Try see if 
there's on spec some note for your HW revision for these WAs.

/Juha-Pekka

On 18.6.2021 11.58, Srinivas, Vidya wrote:
> Thank you so much Juha-Pekka.
> 
> https://patchwork.freedesktop.org/patch/436194/?series=90828&rev=2 just removes the DRM_PLANE_TYPE_PRIMARY fb setting from subtest
> That works. Would that be an okay change?
> 
> Because without the commit after PRIMARY and alpha value 0x7e, JSL is failing. If we just don’t do the PRIMARY fb setting at start, test works as is.
> 
> Kindly suggest. Thank you very much once again.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Sent: Friday, June 18, 2021 2:23 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant
> 
> On 11.6.2021 15.44, Vidya Srinivas wrote:
>> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant as
>> per the buffer being created initially in prepare_crtc. Patch also add
>> commit after setting fb on primary plane. Without this change CRC
>> mismatch is seen on few Gen11 systems.
>>
>> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>> ---
>>    tests/kms_plane_alpha_blend.c | 9 +++++++--
>>    1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/kms_plane_alpha_blend.c
>> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..d3a73cf43fcd
>> 100644
>> --- a/tests/kms_plane_alpha_blend.c
>> +++ b/tests/kms_plane_alpha_blend.c
>> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>>    	igt_crc_t ref_crc = {}, crc = {};
>>    
>>    	/* Set a background color on the primary fb for testing */
>> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
>> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>>    		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
>> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
>> +		igt_display_commit2(display, COMMIT_ATOMIC);
> 
> Why this extra commit needed? There's just below commit before crc is started
> 
>> +	}
>>    
>>    	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
>> "Coverage");
>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
> 
> On this test there's already per pixel alpha, setting plane alpha values so low will probably in this case in final rounding make these planes completely invisible. I'd suspect you can get any image pass crc doing it like this. Likely what you see on screen with these values is just pure grey instead of intended test image.
> 
> 
>>    	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>    	igt_display_commit2(display, COMMIT_ATOMIC);
>>    	igt_pipe_crc_start(data->pipe_crc);
>>    	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>>    
>>    	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
>> "Pre-multiplied");
>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>    	igt_plane_set_fb(plane, &data->argb_fb_7e);
>>    	igt_display_commit2(display, COMMIT_ATOMIC);
>>    	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>    	igt_assert_crc_equal(&ref_crc, &crc);
>>    
>>    	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>    	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>    	igt_display_commit2(display, COMMIT_ATOMIC);
>>    	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>    	igt_assert_crc_equal(&ref_crc, &crc);
>>    
>>    	igt_pipe_crc_stop(data->pipe_crc);
>> +
> 
> stray new line
> 
>>    }
>>    
>>    static void run_test_on_pipe_planes(data_t *data, enum pipe pipe,
>> bool blend,
>>
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Thank you so much Juha-Pekka. I will check on the same and update.

Regards
Vidya

-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> 
Sent: Friday, June 18, 2021 3:56 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

Have you tried looking if on kernel side in intel_display.c
icl_set_pipe_chicken(..) those icl related WAs have effect on your crc problem. Sound like setting PER_PIXEL_ALPHA_BYPASS_EN and PIXEL_ROUNDING_TRUNC_FB_PASSTHRU touch exactly the problem you are seeing. Maybe different hw revision behave differently? Try see if there's on spec some note for your HW revision for these WAs.

/Juha-Pekka

On 18.6.2021 11.58, Srinivas, Vidya wrote:
> Thank you so much Juha-Pekka.
> 
> https://patchwork.freedesktop.org/patch/436194/?series=90828&rev=2 
> just removes the DRM_PLANE_TYPE_PRIMARY fb setting from subtest That works. Would that be an okay change?
> 
> Because without the commit after PRIMARY and alpha value 0x7e, JSL is failing. If we just don’t do the PRIMARY fb setting at start, test works as is.
> 
> Kindly suggest. Thank you very much once again.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Sent: Friday, June 18, 2021 2:23 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> On 11.6.2021 15.44, Vidya Srinivas wrote:
>> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant as 
>> per the buffer being created initially in prepare_crtc. Patch also 
>> add commit after setting fb on primary plane. Without this change CRC 
>> mismatch is seen on few Gen11 systems.
>>
>> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>> ---
>>    tests/kms_plane_alpha_blend.c | 9 +++++++--
>>    1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/kms_plane_alpha_blend.c 
>> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..d3a73cf43fcd
>> 100644
>> --- a/tests/kms_plane_alpha_blend.c
>> +++ b/tests/kms_plane_alpha_blend.c
>> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>>    	igt_crc_t ref_crc = {}, crc = {};
>>    
>>    	/* Set a background color on the primary fb for testing */
>> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
>> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>>    		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
>> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
>> +		igt_display_commit2(display, COMMIT_ATOMIC);
> 
> Why this extra commit needed? There's just below commit before crc is 
> started
> 
>> +	}
>>    
>>    	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>> "Coverage");
>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
> 
> On this test there's already per pixel alpha, setting plane alpha values so low will probably in this case in final rounding make these planes completely invisible. I'd suspect you can get any image pass crc doing it like this. Likely what you see on screen with these values is just pure grey instead of intended test image.
> 
> 
>>    	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>    	igt_display_commit2(display, COMMIT_ATOMIC);
>>    	igt_pipe_crc_start(data->pipe_crc);
>>    	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>>    
>>    	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>> "Pre-multiplied");
>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>    	igt_plane_set_fb(plane, &data->argb_fb_7e);
>>    	igt_display_commit2(display, COMMIT_ATOMIC);
>>    	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>    	igt_assert_crc_equal(&ref_crc, &crc);
>>    
>>    	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>    	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>    	igt_display_commit2(display, COMMIT_ATOMIC);
>>    	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>    	igt_assert_crc_equal(&ref_crc, &crc);
>>    
>>    	igt_pipe_crc_stop(data->pipe_crc);
>> +
> 
> stray new line
> 
>>    }
>>    
>>    static void run_test_on_pipe_planes(data_t *data, enum pipe pipe, 
>> bool blend,
>>
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Hello Juha-Pekka,

As you said, I guess that might be the problem. But the changes of WA are already present in kernel. I tried reverting them just to check, but did not see any change.
If I change the gray buffer (0.5 to 1,1,1) it works. If I comment first primary commit it works. If I just comment "Pre-multiplied" it works, else lower alpha works.
Couldn’t find any other changes yet in driver. Would it be okay if I can add a patch to disable primary commit if JASPERLAKE?

Thank you so much.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Friday, June 18, 2021 4:01 PM
To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <Charlton.Lin@intel.com>
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

Thank you so much Juha-Pekka. I will check on the same and update.

Regards
Vidya

-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Sent: Friday, June 18, 2021 3:56 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

Have you tried looking if on kernel side in intel_display.c
icl_set_pipe_chicken(..) those icl related WAs have effect on your crc problem. Sound like setting PER_PIXEL_ALPHA_BYPASS_EN and PIXEL_ROUNDING_TRUNC_FB_PASSTHRU touch exactly the problem you are seeing. Maybe different hw revision behave differently? Try see if there's on spec some note for your HW revision for these WAs.

/Juha-Pekka

On 18.6.2021 11.58, Srinivas, Vidya wrote:
> Thank you so much Juha-Pekka.
> 
> https://patchwork.freedesktop.org/patch/436194/?series=90828&rev=2
> just removes the DRM_PLANE_TYPE_PRIMARY fb setting from subtest That works. Would that be an okay change?
> 
> Because without the commit after PRIMARY and alpha value 0x7e, JSL is failing. If we just don’t do the PRIMARY fb setting at start, test works as is.
> 
> Kindly suggest. Thank you very much once again.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Sent: Friday, June 18, 2021 2:23 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> On 11.6.2021 15.44, Vidya Srinivas wrote:
>> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant as 
>> per the buffer being created initially in prepare_crtc. Patch also 
>> add commit after setting fb on primary plane. Without this change CRC 
>> mismatch is seen on few Gen11 systems.
>>
>> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>> ---
>>    tests/kms_plane_alpha_blend.c | 9 +++++++--
>>    1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/kms_plane_alpha_blend.c 
>> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..d3a73cf43fcd
>> 100644
>> --- a/tests/kms_plane_alpha_blend.c
>> +++ b/tests/kms_plane_alpha_blend.c
>> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>>    	igt_crc_t ref_crc = {}, crc = {};
>>    
>>    	/* Set a background color on the primary fb for testing */
>> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
>> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>>    		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
>> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
>> +		igt_display_commit2(display, COMMIT_ATOMIC);
> 
> Why this extra commit needed? There's just below commit before crc is 
> started
> 
>> +	}
>>    
>>    	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>> "Coverage");
>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
> 
> On this test there's already per pixel alpha, setting plane alpha values so low will probably in this case in final rounding make these planes completely invisible. I'd suspect you can get any image pass crc doing it like this. Likely what you see on screen with these values is just pure grey instead of intended test image.
> 
> 
>>    	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>    	igt_display_commit2(display, COMMIT_ATOMIC);
>>    	igt_pipe_crc_start(data->pipe_crc);
>>    	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>>    
>>    	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>> "Pre-multiplied");
>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>    	igt_plane_set_fb(plane, &data->argb_fb_7e);
>>    	igt_display_commit2(display, COMMIT_ATOMIC);
>>    	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>    	igt_assert_crc_equal(&ref_crc, &crc);
>>    
>>    	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>    	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>    	igt_display_commit2(display, COMMIT_ATOMIC);
>>    	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>    	igt_assert_crc_equal(&ref_crc, &crc);
>>    
>>    	igt_pipe_crc_stop(data->pipe_crc);
>> +
> 
> stray new line
> 
>>    }
>>    
>>    static void run_test_on_pipe_planes(data_t *data, enum pipe pipe, 
>> bool blend,
>>
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Juha-Pekka Heikkilä]

Hi Vidya,

I don't now have access to specs so I can't say if there would be 
something special for JSL on this case. OTOH if changing gray buffer to 
solid white fixes that maybe good solution, I'm trying to think how the 
screen will be in this case and I assume test image will remain on 
screen(?). If just changing gray buffer to solid white make test pass 
there maybe also 0.25 gray and 0.75 gray which will work. It wouldn't be 
the first time there is found case with specific color which causes 
rounding error with crc where it's just more convenient to change that 
color.

I don't know can it be used in this case but there might be possibility 
to do gamma table trick if nothing else works. This is used in kms_plane 
and kms_flip_scaled_crc that come to my mind, in 
tests/kms_flip_scaled_crc.c look for set_lut(..) function and how it is 
used.

I'd avoid creating special cases for some hw versions, it will lead to 
big mess in the end.

/Juha-Pekka

Srinivas, Vidya kirjoitti 18.6.2021 klo 21.54:
> Hello Juha-Pekka,
> 
> As you said, I guess that might be the problem. But the changes of WA are already present in kernel. I tried reverting them just to check, but did not see any change.
> If I change the gray buffer (0.5 to 1,1,1) it works. If I comment first primary commit it works. If I just comment "Pre-multiplied" it works, else lower alpha works.
> Couldn’t find any other changes yet in driver. Would it be okay if I can add a patch to disable primary commit if JASPERLAKE?
> 
> Thank you so much.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Friday, June 18, 2021 4:01 PM
> To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <Charlton.Lin@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant
> 
> Thank you so much Juha-Pekka. I will check on the same and update.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Sent: Friday, June 18, 2021 3:56 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant
> 
> Have you tried looking if on kernel side in intel_display.c
> icl_set_pipe_chicken(..) those icl related WAs have effect on your crc problem. Sound like setting PER_PIXEL_ALPHA_BYPASS_EN and PIXEL_ROUNDING_TRUNC_FB_PASSTHRU touch exactly the problem you are seeing. Maybe different hw revision behave differently? Try see if there's on spec some note for your HW revision for these WAs.
> 
> /Juha-Pekka
> 
> On 18.6.2021 11.58, Srinivas, Vidya wrote:
>> Thank you so much Juha-Pekka.
>>
>> https://patchwork.freedesktop.org/patch/436194/?series=90828&rev=2
>> just removes the DRM_PLANE_TYPE_PRIMARY fb setting from subtest That works. Would that be an okay change?
>>
>> Because without the commit after PRIMARY and alpha value 0x7e, JSL is failing. If we just don’t do the PRIMARY fb setting at start, test works as is.
>>
>> Kindly suggest. Thank you very much once again.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> Sent: Friday, June 18, 2021 2:23 PM
>> To: Srinivas, Vidya <vidya.srinivas@intel.com>;
>> igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton
>> <charlton.lin@intel.com>
>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix
>> alpha in coverage-vs-premult-vs-constant
>>
>> On 11.6.2021 15.44, Vidya Srinivas wrote:
>>> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant as
>>> per the buffer being created initially in prepare_crtc. Patch also
>>> add commit after setting fb on primary plane. Without this change CRC
>>> mismatch is seen on few Gen11 systems.
>>>
>>> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>>> ---
>>>     tests/kms_plane_alpha_blend.c | 9 +++++++--
>>>     1 file changed, 7 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tests/kms_plane_alpha_blend.c
>>> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..d3a73cf43fcd
>>> 100644
>>> --- a/tests/kms_plane_alpha_blend.c
>>> +++ b/tests/kms_plane_alpha_blend.c
>>> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>>>     	igt_crc_t ref_crc = {}, crc = {};
>>>     
>>>     	/* Set a background color on the primary fb for testing */
>>> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
>>> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>>>     		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
>>> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
>>> +		igt_display_commit2(display, COMMIT_ATOMIC);
>>
>> Why this extra commit needed? There's just below commit before crc is
>> started
>>
>>> +	}
>>>     
>>>     	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
>>> "Coverage");
>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>
>> On this test there's already per pixel alpha, setting plane alpha values so low will probably in this case in final rounding make these planes completely invisible. I'd suspect you can get any image pass crc doing it like this. Likely what you see on screen with these values is just pure grey instead of intended test image.
>>
>>
>>>     	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>     	igt_display_commit2(display, COMMIT_ATOMIC);
>>>     	igt_pipe_crc_start(data->pipe_crc);
>>>     	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>>>     
>>>     	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
>>> "Pre-multiplied");
>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>     	igt_plane_set_fb(plane, &data->argb_fb_7e);
>>>     	igt_display_commit2(display, COMMIT_ATOMIC);
>>>     	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>     	igt_assert_crc_equal(&ref_crc, &crc);
>>>     
>>>     	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>>> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>     	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>     	igt_display_commit2(display, COMMIT_ATOMIC);
>>>     	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>     	igt_assert_crc_equal(&ref_crc, &crc);
>>>     
>>>     	igt_pipe_crc_stop(data->pipe_crc);
>>> +
>>
>> stray new line
>>
>>>     }
>>>     
>>>     static void run_test_on_pipe_planes(data_t *data, enum pipe pipe,
>>> bool blend,
>>>
>>
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Thank you so much Juha-Pekka. I will try out the gamma thing you mentioned and update further.

Regards
Vidya

-----Original Message-----
From: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com> 
Sent: Saturday, June 19, 2021 1:54 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

Hi Vidya,

I don't now have access to specs so I can't say if there would be something special for JSL on this case. OTOH if changing gray buffer to solid white fixes that maybe good solution, I'm trying to think how the screen will be in this case and I assume test image will remain on screen(?). If just changing gray buffer to solid white make test pass there maybe also 0.25 gray and 0.75 gray which will work. It wouldn't be the first time there is found case with specific color which causes rounding error with crc where it's just more convenient to change that color.

I don't know can it be used in this case but there might be possibility to do gamma table trick if nothing else works. This is used in kms_plane and kms_flip_scaled_crc that come to my mind, in tests/kms_flip_scaled_crc.c look for set_lut(..) function and how it is used.

I'd avoid creating special cases for some hw versions, it will lead to big mess in the end.

/Juha-Pekka

Srinivas, Vidya kirjoitti 18.6.2021 klo 21.54:
> Hello Juha-Pekka,
> 
> As you said, I guess that might be the problem. But the changes of WA are already present in kernel. I tried reverting them just to check, but did not see any change.
> If I change the gray buffer (0.5 to 1,1,1) it works. If I comment first primary commit it works. If I just comment "Pre-multiplied" it works, else lower alpha works.
> Couldn’t find any other changes yet in driver. Would it be okay if I can add a patch to disable primary commit if JASPERLAKE?
> 
> Thank you so much.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Friday, June 18, 2021 4:01 PM
> To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <Charlton.Lin@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> Thank you so much Juha-Pekka. I will check on the same and update.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Sent: Friday, June 18, 2021 3:56 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> Have you tried looking if on kernel side in intel_display.c
> icl_set_pipe_chicken(..) those icl related WAs have effect on your crc problem. Sound like setting PER_PIXEL_ALPHA_BYPASS_EN and PIXEL_ROUNDING_TRUNC_FB_PASSTHRU touch exactly the problem you are seeing. Maybe different hw revision behave differently? Try see if there's on spec some note for your HW revision for these WAs.
> 
> /Juha-Pekka
> 
> On 18.6.2021 11.58, Srinivas, Vidya wrote:
>> Thank you so much Juha-Pekka.
>>
>> https://patchwork.freedesktop.org/patch/436194/?series=90828&rev=2
>> just removes the DRM_PLANE_TYPE_PRIMARY fb setting from subtest That works. Would that be an okay change?
>>
>> Because without the commit after PRIMARY and alpha value 0x7e, JSL is failing. If we just don’t do the PRIMARY fb setting at start, test works as is.
>>
>> Kindly suggest. Thank you very much once again.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> Sent: Friday, June 18, 2021 2:23 PM
>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
>> igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>> <charlton.lin@intel.com>
>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
>> alpha in coverage-vs-premult-vs-constant
>>
>> On 11.6.2021 15.44, Vidya Srinivas wrote:
>>> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant 
>>> as per the buffer being created initially in prepare_crtc. Patch 
>>> also add commit after setting fb on primary plane. Without this 
>>> change CRC mismatch is seen on few Gen11 systems.
>>>
>>> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>>> ---
>>>     tests/kms_plane_alpha_blend.c | 9 +++++++--
>>>     1 file changed, 7 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tests/kms_plane_alpha_blend.c 
>>> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..d3a73cf43fcd
>>> 100644
>>> --- a/tests/kms_plane_alpha_blend.c
>>> +++ b/tests/kms_plane_alpha_blend.c
>>> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>>>     	igt_crc_t ref_crc = {}, crc = {};
>>>     
>>>     	/* Set a background color on the primary fb for testing */
>>> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
>>> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>>>     		
>>> igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
>>> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
>>> +		igt_display_commit2(display, COMMIT_ATOMIC);
>>
>> Why this extra commit needed? There's just below commit before crc is 
>> started
>>
>>> +	}
>>>     
>>>     	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>>> "Coverage");
>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>
>> On this test there's already per pixel alpha, setting plane alpha values so low will probably in this case in final rounding make these planes completely invisible. I'd suspect you can get any image pass crc doing it like this. Likely what you see on screen with these values is just pure grey instead of intended test image.
>>
>>
>>>     	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>     	igt_display_commit2(display, COMMIT_ATOMIC);
>>>     	igt_pipe_crc_start(data->pipe_crc);
>>>     	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>>>     
>>>     	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>>> "Pre-multiplied");
>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>     	igt_plane_set_fb(plane, &data->argb_fb_7e);
>>>     	igt_display_commit2(display, COMMIT_ATOMIC);
>>>     	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>     	igt_assert_crc_equal(&ref_crc, &crc);
>>>     
>>>     	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>>> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>     	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>     	igt_display_commit2(display, COMMIT_ATOMIC);
>>>     	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>     	igt_assert_crc_equal(&ref_crc, &crc);
>>>     
>>>     	igt_pipe_crc_stop(data->pipe_crc);
>>> +
>>
>> stray new line
>>
>>>     }
>>>     
>>>     static void run_test_on_pipe_planes(data_t *data, enum pipe 
>>> pipe, bool blend,
>>>
>>
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Limit pipe output to 8bpc for coverage-vs-premult-vs-constant

[Vidya Srinivas]

Few Gen11 systems report CRC mismatch with higher alpha values if
primary plane is enabled. So in order to get the coverage vs. premult vs. constant
crc to match use legacy LUT to limit pipe output to 8bpc for subtest
coverage-vs-premult-vs-constant. Similar thing is done in kms_flip_scaled_crc.

Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 39 ++++++++++++++++++++++++++++++++++++---
 1 file changed, 36 insertions(+), 3 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..1e20d9b0778c 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -442,20 +442,52 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
 	igt_pipe_crc_stop(data->pipe_crc);
 }
 
+static void set_lut(data_t *data, enum pipe pipe)
+{
+	igt_pipe_t *pipe_obj = &data->display.pipes[pipe];
+	struct drm_color_lut *lut;
+	drmModeCrtc *crtc;
+	int i, lut_size;
+
+	crtc = drmModeGetCrtc(data->gfx_fd, pipe_obj->crtc_id);
+	lut_size = crtc->gamma_size;
+	drmModeFreeCrtc(crtc);
+	lut = malloc(sizeof(lut[0]) * lut_size);
+	for (i = 0; i < lut_size; i++) {
+		uint16_t v  = (i * 0xffff / (lut_size - 1)) & 0xff00;
+		lut[i].red = v;
+		lut[i].green = v;
+		lut[i].blue = v;
+	}
+	igt_pipe_obj_replace_prop_blob(pipe_obj, IGT_CRTC_GAMMA_LUT,
+				       lut, sizeof(lut[0]) * lut_size);
+	free(lut);
+}
+
+static void clear_lut(data_t *data, enum pipe pipe)
+{
+	igt_pipe_t *pipe_obj = &data->display.pipes[pipe];
+
+	igt_pipe_obj_set_prop_value(pipe_obj, IGT_CRTC_GAMMA_LUT, 0);
+}
+
 static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)
 {
 	igt_display_t *display = &data->display;
 	igt_crc_t ref_crc = {}, crc = {};
+	int i;
 
 	/* Set a background color on the primary fb for testing */
-	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
-		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
+	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
+		set_lut(data, pipe);
+		igt_display_commit_atomic(&data->display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+	}
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_start(data->pipe_crc);
-	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
+	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &ref_crc);
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Pre-multiplied");
 	igt_plane_set_fb(plane, &data->argb_fb_7e);
@@ -470,6 +502,7 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
 	igt_assert_crc_equal(&ref_crc, &crc);
 
+	clear_lut(data, pipe);
 	igt_pipe_crc_stop(data->pipe_crc);
 }
 
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Hello Juha-Pekka,

Thank you so much. I tried the LUT table you suggested and it worked https://patchwork.freedesktop.org/patch/440145/?series=90828&rev=4
Could you kindly check if it is right? 0.25 and 0.75 did not work. 1,1,1 too is failing once in a while.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Saturday, June 19, 2021 8:40 AM
To: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>; igt-dev@lists.freedesktop.org
Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <Charlton.Lin@intel.com>
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

Thank you so much Juha-Pekka. I will try out the gamma thing you mentioned and update further.

Regards
Vidya

-----Original Message-----
From: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>
Sent: Saturday, June 19, 2021 1:54 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

Hi Vidya,

I don't now have access to specs so I can't say if there would be something special for JSL on this case. OTOH if changing gray buffer to solid white fixes that maybe good solution, I'm trying to think how the screen will be in this case and I assume test image will remain on screen(?). If just changing gray buffer to solid white make test pass there maybe also 0.25 gray and 0.75 gray which will work. It wouldn't be the first time there is found case with specific color which causes rounding error with crc where it's just more convenient to change that color.

I don't know can it be used in this case but there might be possibility to do gamma table trick if nothing else works. This is used in kms_plane and kms_flip_scaled_crc that come to my mind, in tests/kms_flip_scaled_crc.c look for set_lut(..) function and how it is used.

I'd avoid creating special cases for some hw versions, it will lead to big mess in the end.

/Juha-Pekka

Srinivas, Vidya kirjoitti 18.6.2021 klo 21.54:
> Hello Juha-Pekka,
> 
> As you said, I guess that might be the problem. But the changes of WA are already present in kernel. I tried reverting them just to check, but did not see any change.
> If I change the gray buffer (0.5 to 1,1,1) it works. If I comment first primary commit it works. If I just comment "Pre-multiplied" it works, else lower alpha works.
> Couldn’t find any other changes yet in driver. Would it be okay if I can add a patch to disable primary commit if JASPERLAKE?
> 
> Thank you so much.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Friday, June 18, 2021 4:01 PM
> To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <Charlton.Lin@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> Thank you so much Juha-Pekka. I will check on the same and update.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Sent: Friday, June 18, 2021 3:56 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> Have you tried looking if on kernel side in intel_display.c
> icl_set_pipe_chicken(..) those icl related WAs have effect on your crc problem. Sound like setting PER_PIXEL_ALPHA_BYPASS_EN and PIXEL_ROUNDING_TRUNC_FB_PASSTHRU touch exactly the problem you are seeing. Maybe different hw revision behave differently? Try see if there's on spec some note for your HW revision for these WAs.
> 
> /Juha-Pekka
> 
> On 18.6.2021 11.58, Srinivas, Vidya wrote:
>> Thank you so much Juha-Pekka.
>>
>> https://patchwork.freedesktop.org/patch/436194/?series=90828&rev=2
>> just removes the DRM_PLANE_TYPE_PRIMARY fb setting from subtest That works. Would that be an okay change?
>>
>> Because without the commit after PRIMARY and alpha value 0x7e, JSL is failing. If we just don’t do the PRIMARY fb setting at start, test works as is.
>>
>> Kindly suggest. Thank you very much once again.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> Sent: Friday, June 18, 2021 2:23 PM
>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
>> igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>> <charlton.lin@intel.com>
>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
>> alpha in coverage-vs-premult-vs-constant
>>
>> On 11.6.2021 15.44, Vidya Srinivas wrote:
>>> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant 
>>> as per the buffer being created initially in prepare_crtc. Patch 
>>> also add commit after setting fb on primary plane. Without this 
>>> change CRC mismatch is seen on few Gen11 systems.
>>>
>>> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>>> ---
>>>     tests/kms_plane_alpha_blend.c | 9 +++++++--
>>>     1 file changed, 7 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tests/kms_plane_alpha_blend.c 
>>> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..d3a73cf43fcd
>>> 100644
>>> --- a/tests/kms_plane_alpha_blend.c
>>> +++ b/tests/kms_plane_alpha_blend.c
>>> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>>>     	igt_crc_t ref_crc = {}, crc = {};
>>>     
>>>     	/* Set a background color on the primary fb for testing */
>>> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
>>> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>>>     		
>>> igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
>>> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
>>> +		igt_display_commit2(display, COMMIT_ATOMIC);
>>
>> Why this extra commit needed? There's just below commit before crc is 
>> started
>>
>>> +	}
>>>     
>>>     	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>>> "Coverage");
>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>
>> On this test there's already per pixel alpha, setting plane alpha values so low will probably in this case in final rounding make these planes completely invisible. I'd suspect you can get any image pass crc doing it like this. Likely what you see on screen with these values is just pure grey instead of intended test image.
>>
>>
>>>     	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>     	igt_display_commit2(display, COMMIT_ATOMIC);
>>>     	igt_pipe_crc_start(data->pipe_crc);
>>>     	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>>>     
>>>     	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>>> "Pre-multiplied");
>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>     	igt_plane_set_fb(plane, &data->argb_fb_7e);
>>>     	igt_display_commit2(display, COMMIT_ATOMIC);
>>>     	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>     	igt_assert_crc_equal(&ref_crc, &crc);
>>>     
>>>     	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>>> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>     	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>     	igt_display_commit2(display, COMMIT_ATOMIC);
>>>     	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>     	igt_assert_crc_equal(&ref_crc, &crc);
>>>     
>>>     	igt_pipe_crc_stop(data->pipe_crc);
>>> +
>>
>> stray new line
>>
>>>     }
>>>     
>>>     static void run_test_on_pipe_planes(data_t *data, enum pipe 
>>> pipe, bool blend,
>>>
>>
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev4)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 4030 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev4)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10246 -> IGTPW_5943
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/index.html

Known issues
------------

  Here are the changes found in IGTPW_5943 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@semaphore:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][1] ([fdo#109271]) +27 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html
    - fi-kbl-soraka:      NOTRUN -> [SKIP][2] ([fdo#109271]) +1 similar issue
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/fi-kbl-soraka/igt@amdgpu/amd_basic@semaphore.html

  * igt@core_hotunplug@unbind-rebind:
    - fi-bdw-5557u:       NOTRUN -> [WARN][3] ([i915#2283])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html

  * igt@gem_exec_parallel@engines@userptr:
    - fi-pnv-d510:        [PASS][4] -> [INCOMPLETE][5] ([i915#299])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/fi-pnv-d510/igt@gem_exec_parallel@engines@userptr.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/fi-pnv-d510/igt@gem_exec_parallel@engines@userptr.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html

  * igt@runner@aborted:
    - fi-pnv-d510:        NOTRUN -> [FAIL][7] ([i915#2403] / [i915#2505] / [i915#2722])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/fi-pnv-d510/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-cml-s:           [DMESG-FAIL][8] ([i915#2291] / [i915#541]) -> [PASS][9]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/fi-cml-s/igt@i915_selftest@live@gt_heartbeat.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/fi-cml-s/igt@i915_selftest@live@gt_heartbeat.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       [FAIL][10] ([i915#1372]) -> [PASS][11]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
  [i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
  [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
  [i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
  [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
  [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
  [i915#299]: https://gitlab.freedesktop.org/drm/intel/issues/299
  [i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541


Participating hosts (42 -> 36)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-dg1-1 fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6113 -> IGTPW_5943

  CI-20190529: 20190529
  CI_DRM_10246: 3c00434f0d7ff138a7b56d5a901586d4473e10a7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_5943: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/index.html
  IGT_6113: 138a29e30277b1039e9934fca5c782dc1e7a9f99 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/index.html

[-- Attachment #1.2: Type: text/html, Size: 4939 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Limit pipe output to 8bpc for coverage-vs-premult-vs-constant

[Juha-Pekka Heikkilä]

Hi Vidya

Vidya Srinivas kirjoitti 19.6.2021 klo 11.08:
> Few Gen11 systems report CRC mismatch with higher alpha values if
> primary plane is enabled. So in order to get the coverage vs. premult vs. constant
> crc to match use legacy LUT to limit pipe output to 8bpc for subtest
> coverage-vs-premult-vs-constant. Similar thing is done in kms_flip_scaled_crc.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>   tests/kms_plane_alpha_blend.c | 39 ++++++++++++++++++++++++++++++++++++---
>   1 file changed, 36 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
> index a37cb27c7d62..1e20d9b0778c 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -442,20 +442,52 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
>   	igt_pipe_crc_stop(data->pipe_crc);
>   }
>   
> +static void set_lut(data_t *data, enum pipe pipe)
> +{
> +	igt_pipe_t *pipe_obj = &data->display.pipes[pipe];
> +	struct drm_color_lut *lut;
> +	drmModeCrtc *crtc;
> +	int i, lut_size;
> +
> +	crtc = drmModeGetCrtc(data->gfx_fd, pipe_obj->crtc_id);
> +	lut_size = crtc->gamma_size;
> +	drmModeFreeCrtc(crtc);
> +	lut = malloc(sizeof(lut[0]) * lut_size);
> +	for (i = 0; i < lut_size; i++) {
> +		uint16_t v  = (i * 0xffff / (lut_size - 1)) & 0xff00;
> +		lut[i].red = v;
> +		lut[i].green = v;
> +		lut[i].blue = v;
> +	}
> +	igt_pipe_obj_replace_prop_blob(pipe_obj, IGT_CRTC_GAMMA_LUT,
> +				       lut, sizeof(lut[0]) * lut_size);
> +	free(lut);
> +}
> +
> +static void clear_lut(data_t *data, enum pipe pipe)
> +{
> +	igt_pipe_t *pipe_obj = &data->display.pipes[pipe];
> +
> +	igt_pipe_obj_set_prop_value(pipe_obj, IGT_CRTC_GAMMA_LUT, 0);
> +}
> +
>   static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)
>   {
>   	igt_display_t *display = &data->display;
>   	igt_crc_t ref_crc = {}, crc = {};
> +	int i;

I didn't notice i variable being used

>   
>   	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
^^
now gray fb background is missing from the test.

> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
> +		set_lut(data, pipe); > +		igt_display_commit_atomic(&data->display, 
DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> +	}
>   
>   	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>   	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>   	igt_display_commit2(display, COMMIT_ATOMIC);
>   	igt_pipe_crc_start(data->pipe_crc);
> -	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
> +	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &ref_crc);
>   
>   	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Pre-multiplied");
>   	igt_plane_set_fb(plane, &data->argb_fb_7e);
> @@ -470,6 +502,7 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>   	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>   	igt_assert_crc_equal(&ref_crc, &crc);
>   
> +	clear_lut(data, pipe);

You'll need to do commit clearing gamma lut.

>   	igt_pipe_crc_stop(data->pipe_crc);
>   }
>   
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev4)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 30295 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev4)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10246_full -> IGTPW_5943_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/index.html

Known issues
------------

  Here are the changes found in IGTPW_5943_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_create@create-clear:
    - shard-glk:          [PASS][1] -> [FAIL][2] ([i915#3160])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk1/igt@gem_create@create-clear.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk5/igt@gem_create@create-clear.html

  * igt@gem_ctx_persistence@smoketest:
    - shard-snb:          NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +3 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-snb5/igt@gem_ctx_persistence@smoketest.html

  * igt@gem_eio@in-flight-contexts-1us:
    - shard-tglb:         [PASS][4] -> [TIMEOUT][5] ([i915#3063])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-tglb6/igt@gem_eio@in-flight-contexts-1us.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb8/igt@gem_eio@in-flight-contexts-1us.html

  * igt@gem_exec_fair@basic-none@vecs0:
    - shard-iclb:         NOTRUN -> [FAIL][6] ([i915#2842]) +3 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb6/igt@gem_exec_fair@basic-none@vecs0.html

  * igt@gem_exec_fair@basic-pace@rcs0:
    - shard-tglb:         [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-tglb7/igt@gem_exec_fair@basic-pace@rcs0.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb7/igt@gem_exec_fair@basic-pace@rcs0.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-glk:          [PASS][9] -> [FAIL][10] ([i915#2842]) +5 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk7/igt@gem_exec_fair@basic-throttle@rcs0.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_exec_params@secure-non-root:
    - shard-iclb:         NOTRUN -> [SKIP][11] ([fdo#112283])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb1/igt@gem_exec_params@secure-non-root.html

  * igt@gem_exec_reloc@basic-wide-active@bcs0:
    - shard-glk:          NOTRUN -> [FAIL][12] ([i915#3633]) +3 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk6/igt@gem_exec_reloc@basic-wide-active@bcs0.html

  * igt@gem_exec_reloc@basic-wide-active@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][13] ([i915#3633])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb4/igt@gem_exec_reloc@basic-wide-active@vcs1.html

  * igt@gem_huc_copy@huc-copy:
    - shard-tglb:         [PASS][14] -> [SKIP][15] ([i915#2190])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-tglb7/igt@gem_huc_copy@huc-copy.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb6/igt@gem_huc_copy@huc-copy.html

  * igt@gem_userptr_blits@dmabuf-sync:
    - shard-kbl:          NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#3323])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-kbl2/igt@gem_userptr_blits@dmabuf-sync.html
    - shard-iclb:         NOTRUN -> [SKIP][17] ([i915#3323])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb7/igt@gem_userptr_blits@dmabuf-sync.html
    - shard-apl:          NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#3323])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl3/igt@gem_userptr_blits@dmabuf-sync.html
    - shard-glk:          NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#3323])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk8/igt@gem_userptr_blits@dmabuf-sync.html
    - shard-tglb:         NOTRUN -> [SKIP][20] ([i915#3323])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb7/igt@gem_userptr_blits@dmabuf-sync.html

  * igt@gen9_exec_parse@basic-rejected-ctx-param:
    - shard-iclb:         NOTRUN -> [SKIP][21] ([fdo#112306])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb5/igt@gen9_exec_parse@basic-rejected-ctx-param.html

  * igt@i915_pm_backlight@bad-brightness:
    - shard-glk:          NOTRUN -> [SKIP][22] ([fdo#109271]) +61 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk7/igt@i915_pm_backlight@bad-brightness.html

  * igt@kms_big_fb@linear-16bpp-rotate-270:
    - shard-tglb:         NOTRUN -> [SKIP][23] ([fdo#111614])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb5/igt@kms_big_fb@linear-16bpp-rotate-270.html

  * igt@kms_big_fb@linear-32bpp-rotate-0:
    - shard-glk:          [PASS][24] -> [DMESG-WARN][25] ([i915#118] / [i915#95]) +1 similar issue
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk7/igt@kms_big_fb@linear-32bpp-rotate-0.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk9/igt@kms_big_fb@linear-32bpp-rotate-0.html

  * igt@kms_big_fb@linear-32bpp-rotate-180:
    - shard-glk:          NOTRUN -> [DMESG-WARN][26] ([i915#118] / [i915#95])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk7/igt@kms_big_fb@linear-32bpp-rotate-180.html

  * igt@kms_big_fb@y-tiled-64bpp-rotate-90:
    - shard-iclb:         NOTRUN -> [SKIP][27] ([fdo#110725] / [fdo#111614]) +1 similar issue
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb7/igt@kms_big_fb@y-tiled-64bpp-rotate-90.html

  * igt@kms_big_joiner@2x-modeset:
    - shard-iclb:         NOTRUN -> [SKIP][28] ([i915#2705])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb1/igt@kms_big_joiner@2x-modeset.html
    - shard-tglb:         NOTRUN -> [SKIP][29] ([i915#2705])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb5/igt@kms_big_joiner@2x-modeset.html

  * igt@kms_chamelium@hdmi-audio:
    - shard-iclb:         NOTRUN -> [SKIP][30] ([fdo#109284] / [fdo#111827]) +4 similar issues
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb1/igt@kms_chamelium@hdmi-audio.html
    - shard-tglb:         NOTRUN -> [SKIP][31] ([fdo#109284] / [fdo#111827]) +1 similar issue
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb5/igt@kms_chamelium@hdmi-audio.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - shard-snb:          NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827]) +22 similar issues
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-snb5/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_color@pipe-d-ctm-0-25:
    - shard-iclb:         NOTRUN -> [SKIP][33] ([fdo#109278] / [i915#1149])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb3/igt@kms_color@pipe-d-ctm-0-25.html

  * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
    - shard-glk:          NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +4 similar issues
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk3/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html

  * igt@kms_color_chamelium@pipe-a-ctm-negative:
    - shard-kbl:          NOTRUN -> [SKIP][35] ([fdo#109271] / [fdo#111827]) +2 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-kbl4/igt@kms_color_chamelium@pipe-a-ctm-negative.html

  * igt@kms_color_chamelium@pipe-c-ctm-0-25:
    - shard-apl:          NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +27 similar issues
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl3/igt@kms_color_chamelium@pipe-c-ctm-0-25.html

  * igt@kms_content_protection@atomic-dpms:
    - shard-apl:          NOTRUN -> [TIMEOUT][37] ([i915#1319])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl7/igt@kms_content_protection@atomic-dpms.html

  * igt@kms_content_protection@lic:
    - shard-iclb:         NOTRUN -> [SKIP][38] ([fdo#109300] / [fdo#111066])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb3/igt@kms_content_protection@lic.html

  * igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement:
    - shard-iclb:         NOTRUN -> [SKIP][39] ([fdo#109278] / [fdo#109279]) +1 similar issue
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb5/igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement.html

  * igt@kms_cursor_crc@pipe-b-cursor-32x10-onscreen:
    - shard-tglb:         NOTRUN -> [SKIP][40] ([i915#3359]) +1 similar issue
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb6/igt@kms_cursor_crc@pipe-b-cursor-32x10-onscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-512x512-random:
    - shard-tglb:         NOTRUN -> [SKIP][41] ([fdo#109279] / [i915#3359]) +1 similar issue
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb2/igt@kms_cursor_crc@pipe-c-cursor-512x512-random.html

  * igt@kms_cursor_crc@pipe-d-cursor-32x32-offscreen:
    - shard-tglb:         NOTRUN -> [SKIP][42] ([i915#3319])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb2/igt@kms_cursor_crc@pipe-d-cursor-32x32-offscreen.html

  * igt@kms_cursor_crc@pipe-d-cursor-32x32-rapid-movement:
    - shard-iclb:         NOTRUN -> [SKIP][43] ([fdo#109278]) +14 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb1/igt@kms_cursor_crc@pipe-d-cursor-32x32-rapid-movement.html

  * igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size:
    - shard-iclb:         NOTRUN -> [SKIP][44] ([fdo#109274] / [fdo#109278])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb2/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
    - shard-glk:          [PASS][45] -> [FAIL][46] ([i915#79])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html

  * igt@kms_flip@2x-flip-vs-rmfb:
    - shard-tglb:         NOTRUN -> [SKIP][47] ([fdo#111825]) +10 similar issues
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb1/igt@kms_flip@2x-flip-vs-rmfb.html
    - shard-iclb:         NOTRUN -> [SKIP][48] ([fdo#109274]) +2 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb5/igt@kms_flip@2x-flip-vs-rmfb.html

  * igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2:
    - shard-glk:          [PASS][49] -> [FAIL][50] ([i915#2122])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk2/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk7/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html

  * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
    - shard-apl:          [PASS][51] -> [DMESG-WARN][52] ([i915#180])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
    - shard-apl:          NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#2672]) +1 similar issue
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
    - shard-snb:          NOTRUN -> [SKIP][54] ([fdo#109271]) +315 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-snb7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-render:
    - shard-iclb:         NOTRUN -> [SKIP][55] ([fdo#109280]) +12 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu:
    - shard-kbl:          NOTRUN -> [SKIP][56] ([fdo#109271]) +55 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-kbl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu.html

  * igt@kms_invalid_dotclock:
    - shard-tglb:         NOTRUN -> [SKIP][57] ([fdo#110577])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb5/igt@kms_invalid_dotclock.html
    - shard-iclb:         NOTRUN -> [SKIP][58] ([fdo#109310])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb4/igt@kms_invalid_dotclock.html

  * igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes:
    - shard-iclb:         NOTRUN -> [SKIP][59] ([fdo#109289])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb7/igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
    - shard-apl:          NOTRUN -> [FAIL][60] ([i915#265])
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl1/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html

  * igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
    - shard-apl:          NOTRUN -> [FAIL][61] ([fdo#108145] / [i915#265]) +1 similar issue
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
    - shard-tglb:         NOTRUN -> [SKIP][62] ([fdo#111615])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb1/igt@kms_plane_multiple@atomic-pipe-b-tiling-yf.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
    - shard-apl:          NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#658]) +5 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
    - shard-glk:          NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#658])
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk5/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         NOTRUN -> [SKIP][65] ([fdo#109441])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_psr@psr2_cursor_plane_move:
    - shard-iclb:         [PASS][66] -> [SKIP][67] ([fdo#109441]) +1 similar issue
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb4/igt@kms_psr@psr2_cursor_plane_move.html

  * igt@kms_sysfs_edid_timing:
    - shard-apl:          NOTRUN -> [FAIL][68] ([IGT#2])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl7/igt@kms_sysfs_edid_timing.html

  * igt@kms_vblank@pipe-d-wait-idle:
    - shard-apl:          NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#533]) +2 similar issues
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl6/igt@kms_vblank@pipe-d-wait-idle.html

  * igt@nouveau_crc@pipe-a-source-outp-complete:
    - shard-tglb:         NOTRUN -> [SKIP][70] ([i915#2530])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb1/igt@nouveau_crc@pipe-a-source-outp-complete.html
    - shard-iclb:         NOTRUN -> [SKIP][71] ([i915#2530])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb3/igt@nouveau_crc@pipe-a-source-outp-complete.html

  * igt@nouveau_crc@pipe-d-source-outp-complete:
    - shard-iclb:         NOTRUN -> [SKIP][72] ([fdo#109278] / [i915#2530])
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb7/igt@nouveau_crc@pipe-d-source-outp-complete.html

  * igt@prime_nv_api@i915_nv_import_vs_close:
    - shard-iclb:         NOTRUN -> [SKIP][73] ([fdo#109291])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb1/igt@prime_nv_api@i915_nv_import_vs_close.html

  * igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
    - shard-apl:          NOTRUN -> [SKIP][74] ([fdo#109271]) +300 similar issues
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl1/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html

  * igt@sysfs_clients@fair-0:
    - shard-glk:          NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#2994])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk2/igt@sysfs_clients@fair-0.html

  * igt@sysfs_clients@fair-1:
    - shard-apl:          NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#2994]) +4 similar issues
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl3/igt@sysfs_clients@fair-1.html

  * igt@sysfs_clients@fair-3:
    - shard-iclb:         NOTRUN -> [SKIP][77] ([i915#2994])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb1/igt@sysfs_clients@fair-3.html

  * igt@sysfs_clients@fair-7:
    - shard-kbl:          NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#2994])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-kbl4/igt@sysfs_clients@fair-7.html

  
#### Possible fixes ####

  * igt@gem_eio@unwedge-stress:
    - shard-tglb:         [TIMEOUT][79] ([i915#2369] / [i915#3063]) -> [PASS][80]
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-tglb3/igt@gem_eio@unwedge-stress.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb3/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-apl:          [SKIP][81] ([fdo#109271]) -> [PASS][82]
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl6/igt@gem_exec_fair@basic-none-share@rcs0.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl7/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-none-vip@rcs0:
    - shard-glk:          [FAIL][83] ([i915#2842]) -> [PASS][84]
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk4/igt@gem_exec_fair@basic-none-vip@rcs0.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk5/igt@gem_exec_fair@basic-none-vip@rcs0.html

  * igt@gem_exec_fair@basic-pace-solo@rcs0:
    - shard-iclb:         [FAIL][85] ([i915#2842]) -> [PASS][86] +1 similar issue
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb8/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * igt@gem_exec_fair@basic-pace@bcs0:
    - shard-tglb:         [FAIL][87] ([i915#2842]) -> [PASS][88] +1 similar issue
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-tglb7/igt@gem_exec_fair@basic-pace@bcs0.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb7/igt@gem_exec_fair@basic-pace@bcs0.html

  * igt@gem_exec_fair@basic-pace@vcs1:
    - shard-kbl:          [SKIP][89] ([fdo#109271]) -> [PASS][90]
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-kbl2/igt@gem_exec_fair@basic-pace@vcs1.html

  * igt@gem_exec_fair@basic-pace@vecs0:
    - shard-kbl:          [FAIL][91] ([i915#2842]) -> [PASS][92]
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl4/igt@gem_exec_fair@basic-pace@vecs0.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-kbl2/igt@gem_exec_fair@basic-pace@vecs0.html

  * igt@gem_mmap_gtt@cpuset-medium-copy-odd:
    - shard-iclb:         [FAIL][93] ([i915#307]) -> [PASS][94] +1 similar issue
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb8/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb7/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html

  * igt@kms_big_fb@y-tiled-32bpp-rotate-0:
    - shard-glk:          [DMESG-WARN][95] ([i915#118] / [i915#95]) -> [PASS][96] +1 similar issue
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk2/igt@kms_big_fb@y-tiled-32bpp-rotate-0.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk6/igt@kms_big_fb@y-tiled-32bpp-rotate-0.html

  * igt@kms_cursor_crc@pipe-c-cursor-128x128-random:
    - shard-kbl:          [FAIL][97] ([i915#3444]) -> [PASS][98]
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-kbl:          [DMESG-WARN][99] ([i915#180]) -> [PASS][100]
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_flip@flip-vs-suspend@a-dp1:
    - shard-apl:          [DMESG-WARN][101] ([i915#180]) -> [PASS][102] +1 similar issue
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl1/igt@kms_flip@flip-vs-suspend@a-dp1.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl7/igt@kms_flip@flip-vs-suspend@a-dp1.html

  * igt@kms_flip@plain-flip-fb-recreate-interruptible@a-hdmi-a1:
    - shard-glk:          [FAIL][103] ([i915#2122]) -> [PASS][104]
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk6/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-hdmi-a1.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk1/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-hdmi-a1.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
    - shard-snb:          [SKIP][105] ([fdo#109271]) -> [PASS][106]
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-snb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-snb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen.html

  * igt@kms_hdmi_inject@inject-audio:
    - shard-tglb:         [SKIP][107] ([i915#433]) -> [PASS][108]
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-tglb2/igt@kms_hdmi_inject@inject-audio.html
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-tglb5/igt@kms_hdmi_inject@inject-audio.html

  * igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
    - shard-iclb:         [INCOMPLETE][109] ([i915#3622]) -> [PASS][110]
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb5/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html

  * igt@kms_plane@plane-position-hole-dpms@pipe-b-planes:
    - shard-glk:          [FAIL][111] ([i915#2472]) -> [PASS][112]
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk3/igt@kms_plane@plane-position-hole-dpms@pipe-b-planes.html
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-glk8/igt@kms_plane@plane-position-hole-dpms@pipe-b-planes.html

  * igt@kms_psr@psr2_sprite_mmap_gtt:
    - shard-iclb:         [SKIP][113] ([fdo#109441]) -> [PASS][114]
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb7/igt@kms_psr@psr2_sprite_mmap_gtt.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html

  
#### Warnings ####

  * igt@i915_pm_rc6_residency@rc6-fence:
    - shard-iclb:         [WARN][115] ([i915#1804] / [i915#2684]) -> [WARN][116] ([i915#2684])
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
    - shard-iclb:         [SKIP][117] ([i915#658]) -> [SKIP][118] ([i915#2920]) +2 similar issues
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
    - shard-iclb:         [SKIP][119] ([i915#2920]) -> [SKIP][120] ([i915#658])
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-iclb8/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html

  * igt@runner@aborted:
    - shard-kbl:          ([FAIL][121], [FAIL][122], [FAIL][123]) ([i915#1436] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363]) -> [FAIL][124] ([i915#3002] / [i915#3363])
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl2/igt@runner@aborted.html
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl6/igt@runner@aborted.html
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl3/igt@runner@aborted.html
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-kbl7/igt@runner@aborted.html
    - shard-apl:          ([FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][131], [FAIL][132], [FAIL][133]) ([i915#180] / [i915#3002] / [i915#3363])
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl3/igt@runner@aborted.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl1/igt@runner@aborted.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl3/igt@runner@aborted.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl1/igt@runner@aborted.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl6/igt@runner@aborted.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl6/igt@runner@aborted.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl7/igt@runner@aborted.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl8/igt@runner@aborted.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/shard-apl3/igt@runner@aborted.html

  
  [IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
  [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
  [fdo#109310]: https://bugs.freedesktop.org/show_bug.cgi?id=109310
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110577]: https://bugs.freedesktop.org/show_bug.cgi?id=110577
  [fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
  [fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
  [fdo#112306]: https://bugs.freedesktop.org/show_bug.cgi?id=112306
  [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
  [i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
  [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
  [i915#2472]: https://gitlab.freedesktop.org/drm/intel/issues/2472
  [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
  [i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
  [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2920]: https://gitlab.freede

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5943/index.html

[-- Attachment #1.2: Type: text/html, Size: 37371 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Limit pipe output to 8bpc for coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Thank you so much Juha-Pekka. The moment I add back gray fb, CRC again fails :(

Regards
Vidya

-----Original Message-----
From: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com> 
Sent: Saturday, June 19, 2021 2:51 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: Shankar, Uma <uma.shankar@intel.com>
Subject: Re: [PATCH i-g-t] tests/kms_plane_alpha_blend: Limit pipe output to 8bpc for coverage-vs-premult-vs-constant

Hi Vidya

Vidya Srinivas kirjoitti 19.6.2021 klo 11.08:
> Few Gen11 systems report CRC mismatch with higher alpha values if 
> primary plane is enabled. So in order to get the coverage vs. premult 
> vs. constant crc to match use legacy LUT to limit pipe output to 8bpc 
> for subtest coverage-vs-premult-vs-constant. Similar thing is done in kms_flip_scaled_crc.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>   tests/kms_plane_alpha_blend.c | 39 ++++++++++++++++++++++++++++++++++++---
>   1 file changed, 36 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..1e20d9b0778c 
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -442,20 +442,52 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
>   	igt_pipe_crc_stop(data->pipe_crc);
>   }
>   
> +static void set_lut(data_t *data, enum pipe pipe) {
> +	igt_pipe_t *pipe_obj = &data->display.pipes[pipe];
> +	struct drm_color_lut *lut;
> +	drmModeCrtc *crtc;
> +	int i, lut_size;
> +
> +	crtc = drmModeGetCrtc(data->gfx_fd, pipe_obj->crtc_id);
> +	lut_size = crtc->gamma_size;
> +	drmModeFreeCrtc(crtc);
> +	lut = malloc(sizeof(lut[0]) * lut_size);
> +	for (i = 0; i < lut_size; i++) {
> +		uint16_t v  = (i * 0xffff / (lut_size - 1)) & 0xff00;
> +		lut[i].red = v;
> +		lut[i].green = v;
> +		lut[i].blue = v;
> +	}
> +	igt_pipe_obj_replace_prop_blob(pipe_obj, IGT_CRTC_GAMMA_LUT,
> +				       lut, sizeof(lut[0]) * lut_size);
> +	free(lut);
> +}
> +
> +static void clear_lut(data_t *data, enum pipe pipe) {
> +	igt_pipe_t *pipe_obj = &data->display.pipes[pipe];
> +
> +	igt_pipe_obj_set_prop_value(pipe_obj, IGT_CRTC_GAMMA_LUT, 0); }
> +
>   static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)
>   {
>   	igt_display_t *display = &data->display;
>   	igt_crc_t ref_crc = {}, crc = {};
> +	int i;

I didn't notice i variable being used

>   
>   	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
^^
now gray fb background is missing from the test.

> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
> +		set_lut(data, pipe); > +		igt_display_commit_atomic(&data->display, 
DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> +	}
>   
>   	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>   	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>   	igt_display_commit2(display, COMMIT_ATOMIC);
>   	igt_pipe_crc_start(data->pipe_crc);
> -	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
> +	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &ref_crc);
>   
>   	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Pre-multiplied");
>   	igt_plane_set_fb(plane, &data->argb_fb_7e); @@ -470,6 +502,7 @@ 
> static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>   	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>   	igt_assert_crc_equal(&ref_crc, &crc);
>   
> +	clear_lut(data, pipe);

You'll need to do commit clearing gamma lut.

>   	igt_pipe_crc_stop(data->pipe_crc);
>   }
>   
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Use alpha for primary plane for coverage-vs-premult-vs-constant

[Vidya Srinivas]

Few Gen11 systems report CRC mismatch with higher alpha values if
primary plane with gray is enabled. So in order to get the coverage vs. premult vs. constant
crc to match use alpha buffer for primary plane as well in coverage-vs-premult-vs-constant.

Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..52c273c71dad 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -449,7 +449,7 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 
 	/* Set a background color on the primary fb for testing */
 	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
-		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
+		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->argb_fb_cov_7e);
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Limit pipe output to 8bpc for coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Hello Juha-Pekka,

Even if I use set_lut, with gray it gives CRC mismatch for pre-multiplied.

If I use same alpha buffer (argb_fb_cov_7e) in primary, it works.
I have uploaded https://patchwork.freedesktop.org/patch/440157/?series=90828&rev=5
Kindly have a check. Thank you so much.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Saturday, June 19, 2021 5:11 PM
To: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>; igt-dev@lists.freedesktop.org
Cc: Shankar, Uma <uma.shankar@intel.com>
Subject: RE: [PATCH i-g-t] tests/kms_plane_alpha_blend: Limit pipe output to 8bpc for coverage-vs-premult-vs-constant

Thank you so much Juha-Pekka. The moment I add back gray fb, CRC again fails :(

Regards
Vidya

-----Original Message-----
From: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>
Sent: Saturday, June 19, 2021 2:51 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: Shankar, Uma <uma.shankar@intel.com>
Subject: Re: [PATCH i-g-t] tests/kms_plane_alpha_blend: Limit pipe output to 8bpc for coverage-vs-premult-vs-constant

Hi Vidya

Vidya Srinivas kirjoitti 19.6.2021 klo 11.08:
> Few Gen11 systems report CRC mismatch with higher alpha values if 
> primary plane is enabled. So in order to get the coverage vs. premult 
> vs. constant crc to match use legacy LUT to limit pipe output to 8bpc 
> for subtest coverage-vs-premult-vs-constant. Similar thing is done in kms_flip_scaled_crc.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>   tests/kms_plane_alpha_blend.c | 39 ++++++++++++++++++++++++++++++++++++---
>   1 file changed, 36 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..1e20d9b0778c
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -442,20 +442,52 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
>   	igt_pipe_crc_stop(data->pipe_crc);
>   }
>   
> +static void set_lut(data_t *data, enum pipe pipe) {
> +	igt_pipe_t *pipe_obj = &data->display.pipes[pipe];
> +	struct drm_color_lut *lut;
> +	drmModeCrtc *crtc;
> +	int i, lut_size;
> +
> +	crtc = drmModeGetCrtc(data->gfx_fd, pipe_obj->crtc_id);
> +	lut_size = crtc->gamma_size;
> +	drmModeFreeCrtc(crtc);
> +	lut = malloc(sizeof(lut[0]) * lut_size);
> +	for (i = 0; i < lut_size; i++) {
> +		uint16_t v  = (i * 0xffff / (lut_size - 1)) & 0xff00;
> +		lut[i].red = v;
> +		lut[i].green = v;
> +		lut[i].blue = v;
> +	}
> +	igt_pipe_obj_replace_prop_blob(pipe_obj, IGT_CRTC_GAMMA_LUT,
> +				       lut, sizeof(lut[0]) * lut_size);
> +	free(lut);
> +}
> +
> +static void clear_lut(data_t *data, enum pipe pipe) {
> +	igt_pipe_t *pipe_obj = &data->display.pipes[pipe];
> +
> +	igt_pipe_obj_set_prop_value(pipe_obj, IGT_CRTC_GAMMA_LUT, 0); }
> +
>   static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)
>   {
>   	igt_display_t *display = &data->display;
>   	igt_crc_t ref_crc = {}, crc = {};
> +	int i;

I didn't notice i variable being used

>   
>   	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
^^
now gray fb background is missing from the test.

> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
> +		set_lut(data, pipe); > +		igt_display_commit_atomic(&data->display, 
DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> +	}
>   
>   	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>   	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>   	igt_display_commit2(display, COMMIT_ATOMIC);
>   	igt_pipe_crc_start(data->pipe_crc);
> -	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
> +	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &ref_crc);
>   
>   	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Pre-multiplied");
>   	igt_plane_set_fb(plane, &data->argb_fb_7e); @@ -470,6 +502,7 @@ 
> static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>   	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>   	igt_assert_crc_equal(&ref_crc, &crc);
>   
> +	clear_lut(data, pipe);

You'll need to do commit clearing gamma lut.

>   	igt_pipe_crc_stop(data->pipe_crc);
>   }
>   
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev5)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 5026 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev5)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10246 -> IGTPW_5944
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_5944:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_selftest@live@execlists:
    - {fi-tgl-1115g4}:    [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/fi-tgl-1115g4/igt@i915_selftest@live@execlists.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/fi-tgl-1115g4/igt@i915_selftest@live@execlists.html

  
Known issues
------------

  Here are the changes found in IGTPW_5944 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@semaphore:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][3] ([fdo#109271]) +27 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html

  * igt@amdgpu/amd_cs_nop@sync-fork-compute0:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][4] ([fdo#109271]) +8 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/fi-kbl-soraka/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html

  * igt@core_hotunplug@unbind-rebind:
    - fi-bdw-5557u:       NOTRUN -> [WARN][5] ([i915#2283])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html

  * igt@debugfs_test@read_all_entries:
    - fi-cfl-8109u:       [PASS][6] -> [DMESG-WARN][7] ([i915#203] / [i915#262])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/fi-cfl-8109u/igt@debugfs_test@read_all_entries.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/fi-cfl-8109u/igt@debugfs_test@read_all_entries.html

  * igt@gem_exec_suspend@basic-s0:
    - fi-cfl-8109u:       [PASS][8] -> [DMESG-WARN][9] ([i915#262])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-cml-s:           [DMESG-FAIL][11] ([i915#2291] / [i915#541]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/fi-cml-s/igt@i915_selftest@live@gt_heartbeat.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/fi-cml-s/igt@i915_selftest@live@gt_heartbeat.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       [FAIL][13] ([i915#1372]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
  [i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
  [i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
  [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
  [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
  [i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966
  [i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541


Participating hosts (42 -> 36)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-dg1-1 fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6113 -> IGTPW_5944

  CI-20190529: 20190529
  CI_DRM_10246: 3c00434f0d7ff138a7b56d5a901586d4473e10a7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_5944: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/index.html
  IGT_6113: 138a29e30277b1039e9934fca5c782dc1e7a9f99 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/index.html

[-- Attachment #1.2: Type: text/html, Size: 5844 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev5)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 30295 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev5)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10246_full -> IGTPW_5944_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/index.html

Known issues
------------

  Here are the changes found in IGTPW_5944_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_create@create-massive:
    - shard-snb:          NOTRUN -> [DMESG-WARN][1] ([i915#3002])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-snb2/igt@gem_create@create-massive.html

  * igt@gem_ctx_persistence@smoketest:
    - shard-snb:          NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +2 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-snb6/igt@gem_ctx_persistence@smoketest.html

  * igt@gem_eio@unwedge-stress:
    - shard-iclb:         [PASS][3] -> [TIMEOUT][4] ([i915#2369] / [i915#2481] / [i915#3070])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb6/igt@gem_eio@unwedge-stress.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb5/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-kbl:          [PASS][5] -> [FAIL][6] ([i915#2846])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl7/igt@gem_exec_fair@basic-deadline.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl2/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-kbl:          [PASS][7] -> [SKIP][8] ([fdo#109271])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl6/igt@gem_exec_fair@basic-none-share@rcs0.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl6/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-none@vcs0:
    - shard-kbl:          [PASS][9] -> [FAIL][10] ([i915#2842]) +2 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl1/igt@gem_exec_fair@basic-none@vcs0.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl6/igt@gem_exec_fair@basic-none@vcs0.html

  * igt@gem_exec_fair@basic-none@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][11] ([i915#2842]) +4 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb2/igt@gem_exec_fair@basic-none@vcs1.html

  * igt@gem_exec_fair@basic-pace@vcs0:
    - shard-tglb:         [PASS][12] -> [FAIL][13] ([i915#2842])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-tglb7/igt@gem_exec_fair@basic-pace@vcs0.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-tglb1/igt@gem_exec_fair@basic-pace@vcs0.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-glk:          [PASS][14] -> [FAIL][15] ([i915#2842]) +3 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk7/igt@gem_exec_fair@basic-throttle@rcs0.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-glk1/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_exec_params@secure-non-root:
    - shard-iclb:         NOTRUN -> [SKIP][16] ([fdo#112283])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb2/igt@gem_exec_params@secure-non-root.html

  * igt@gem_exec_reloc@basic-wide-active@bcs0:
    - shard-glk:          NOTRUN -> [FAIL][17] ([i915#3633]) +3 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-glk3/igt@gem_exec_reloc@basic-wide-active@bcs0.html

  * igt@gem_exec_reloc@basic-wide-active@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][18] ([i915#3633])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb1/igt@gem_exec_reloc@basic-wide-active@vcs1.html

  * igt@gem_exec_whisper@basic-fds-forked:
    - shard-glk:          [PASS][19] -> [DMESG-WARN][20] ([i915#118] / [i915#95]) +2 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk4/igt@gem_exec_whisper@basic-fds-forked.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-glk8/igt@gem_exec_whisper@basic-fds-forked.html

  * igt@gem_userptr_blits@dmabuf-sync:
    - shard-kbl:          NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#3323])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl1/igt@gem_userptr_blits@dmabuf-sync.html
    - shard-iclb:         NOTRUN -> [SKIP][22] ([i915#3323])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb5/igt@gem_userptr_blits@dmabuf-sync.html
    - shard-apl:          NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#3323])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl3/igt@gem_userptr_blits@dmabuf-sync.html
    - shard-glk:          NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3323])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-glk8/igt@gem_userptr_blits@dmabuf-sync.html
    - shard-tglb:         NOTRUN -> [SKIP][25] ([i915#3323])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-tglb6/igt@gem_userptr_blits@dmabuf-sync.html

  * igt@gen9_exec_parse@basic-rejected-ctx-param:
    - shard-iclb:         NOTRUN -> [SKIP][26] ([fdo#112306])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb8/igt@gen9_exec_parse@basic-rejected-ctx-param.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
    - shard-apl:          NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#1937])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl6/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html

  * igt@kms_big_fb@linear-16bpp-rotate-270:
    - shard-tglb:         NOTRUN -> [SKIP][28] ([fdo#111614])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-tglb3/igt@kms_big_fb@linear-16bpp-rotate-270.html

  * igt@kms_big_fb@x-tiled-64bpp-rotate-0:
    - shard-iclb:         [PASS][29] -> [DMESG-WARN][30] ([i915#3621])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb7/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb1/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html

  * igt@kms_big_fb@y-tiled-64bpp-rotate-90:
    - shard-iclb:         NOTRUN -> [SKIP][31] ([fdo#110725] / [fdo#111614]) +1 similar issue
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb1/igt@kms_big_fb@y-tiled-64bpp-rotate-90.html

  * igt@kms_chamelium@hdmi-audio:
    - shard-tglb:         NOTRUN -> [SKIP][32] ([fdo#109284] / [fdo#111827]) +1 similar issue
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-tglb5/igt@kms_chamelium@hdmi-audio.html

  * igt@kms_chamelium@hdmi-cmp-planar-formats:
    - shard-iclb:         NOTRUN -> [SKIP][33] ([fdo#109284] / [fdo#111827]) +3 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb2/igt@kms_chamelium@hdmi-cmp-planar-formats.html

  * igt@kms_chamelium@vga-hpd:
    - shard-apl:          NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +20 similar issues
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl7/igt@kms_chamelium@vga-hpd.html

  * igt@kms_color@pipe-d-ctm-0-25:
    - shard-iclb:         NOTRUN -> [SKIP][35] ([fdo#109278] / [i915#1149])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb3/igt@kms_color@pipe-d-ctm-0-25.html

  * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
    - shard-glk:          NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +4 similar issues
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-glk3/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html

  * igt@kms_color_chamelium@pipe-a-ctm-negative:
    - shard-kbl:          NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +2 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl3/igt@kms_color_chamelium@pipe-a-ctm-negative.html

  * igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
    - shard-snb:          NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +21 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-snb7/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html

  * igt@kms_content_protection@lic:
    - shard-apl:          NOTRUN -> [TIMEOUT][39] ([i915#1319]) +1 similar issue
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl6/igt@kms_content_protection@lic.html
    - shard-iclb:         NOTRUN -> [SKIP][40] ([fdo#109300] / [fdo#111066])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb7/igt@kms_content_protection@lic.html

  * igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement:
    - shard-iclb:         NOTRUN -> [SKIP][41] ([fdo#109278] / [fdo#109279]) +1 similar issue
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb7/igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement.html

  * igt@kms_cursor_crc@pipe-b-cursor-128x42-random:
    - shard-kbl:          [PASS][42] -> [FAIL][43] ([i915#3444])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl1/igt@kms_cursor_crc@pipe-b-cursor-128x42-random.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-128x42-random.html
    - shard-glk:          [PASS][44] -> [FAIL][45] ([i915#3444])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk1/igt@kms_cursor_crc@pipe-b-cursor-128x42-random.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-glk3/igt@kms_cursor_crc@pipe-b-cursor-128x42-random.html

  * igt@kms_cursor_crc@pipe-b-cursor-32x10-onscreen:
    - shard-tglb:         NOTRUN -> [SKIP][46] ([i915#3359]) +1 similar issue
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-tglb3/igt@kms_cursor_crc@pipe-b-cursor-32x10-onscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-512x512-random:
    - shard-tglb:         NOTRUN -> [SKIP][47] ([fdo#109279] / [i915#3359]) +1 similar issue
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-tglb1/igt@kms_cursor_crc@pipe-c-cursor-512x512-random.html

  * igt@kms_cursor_crc@pipe-d-cursor-32x32-offscreen:
    - shard-tglb:         NOTRUN -> [SKIP][48] ([i915#3319])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-tglb8/igt@kms_cursor_crc@pipe-d-cursor-32x32-offscreen.html

  * igt@kms_cursor_crc@pipe-d-cursor-32x32-rapid-movement:
    - shard-iclb:         NOTRUN -> [SKIP][49] ([fdo#109278]) +14 similar issues
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb1/igt@kms_cursor_crc@pipe-d-cursor-32x32-rapid-movement.html

  * igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size:
    - shard-iclb:         NOTRUN -> [SKIP][50] ([fdo#109274] / [fdo#109278])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb5/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html

  * igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
    - shard-glk:          [PASS][51] -> [FAIL][52] ([i915#79])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html

  * igt@kms_flip@2x-flip-vs-rmfb:
    - shard-tglb:         NOTRUN -> [SKIP][53] ([fdo#111825]) +10 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-tglb5/igt@kms_flip@2x-flip-vs-rmfb.html

  * igt@kms_flip@2x-flip-vs-suspend:
    - shard-iclb:         NOTRUN -> [SKIP][54] ([fdo#109274])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb1/igt@kms_flip@2x-flip-vs-suspend.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
    - shard-apl:          NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#2672]) +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
    - shard-snb:          NOTRUN -> [SKIP][56] ([fdo#109271]) +307 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-snb5/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html

  * igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack-mmap-gtt:
    - shard-glk:          [PASS][57] -> [FAIL][58] ([i915#2546])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk2/igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack-mmap-gtt.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-glk1/igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack-mmap-gtt.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-render:
    - shard-iclb:         NOTRUN -> [SKIP][59] ([fdo#109280]) +12 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-pgflip-blt:
    - shard-glk:          NOTRUN -> [SKIP][60] ([fdo#109271]) +58 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-glk9/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu:
    - shard-kbl:          NOTRUN -> [SKIP][61] ([fdo#109271]) +52 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu.html

  * igt@kms_invalid_dotclock:
    - shard-tglb:         NOTRUN -> [SKIP][62] ([fdo#110577])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-tglb5/igt@kms_invalid_dotclock.html
    - shard-iclb:         NOTRUN -> [SKIP][63] ([fdo#109310])
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb8/igt@kms_invalid_dotclock.html

  * igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes:
    - shard-iclb:         NOTRUN -> [SKIP][64] ([fdo#109289])
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb2/igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes.html

  * igt@kms_plane@plane-position-hole@pipe-a-planes:
    - shard-kbl:          [PASS][65] -> [FAIL][66] ([i915#2472])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl3/igt@kms_plane@plane-position-hole@pipe-a-planes.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl7/igt@kms_plane@plane-position-hole@pipe-a-planes.html
    - shard-apl:          [PASS][67] -> [FAIL][68] ([i915#2472])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl7/igt@kms_plane@plane-position-hole@pipe-a-planes.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl8/igt@kms_plane@plane-position-hole@pipe-a-planes.html

  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
    - shard-apl:          NOTRUN -> [FAIL][69] ([fdo#108145] / [i915#265]) +2 similar issues
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl7/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
    - shard-tglb:         NOTRUN -> [SKIP][70] ([fdo#111615])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-tglb8/igt@kms_plane_multiple@atomic-pipe-b-tiling-yf.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
    - shard-apl:          NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#658]) +4 similar issues
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
    - shard-glk:          NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#658])
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-glk1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html

  * igt@kms_psr@psr2_cursor_plane_move:
    - shard-iclb:         [PASS][73] -> [SKIP][74] ([fdo#109441]) +1 similar issue
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb7/igt@kms_psr@psr2_cursor_plane_move.html

  * igt@kms_sysfs_edid_timing:
    - shard-apl:          NOTRUN -> [FAIL][75] ([IGT#2])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl7/igt@kms_sysfs_edid_timing.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          [PASS][76] -> [INCOMPLETE][77] ([i915#155])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@kms_vblank@pipe-c-ts-continuation-suspend:
    - shard-apl:          [PASS][78] -> [DMESG-WARN][79] ([i915#180]) +2 similar issues
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl1/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl1/igt@kms_vblank@pipe-c-ts-continuation-suspend.html

  * igt@kms_vblank@pipe-d-wait-idle:
    - shard-apl:          NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#533]) +2 similar issues
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl1/igt@kms_vblank@pipe-d-wait-idle.html

  * igt@nouveau_crc@pipe-a-source-outp-complete:
    - shard-tglb:         NOTRUN -> [SKIP][81] ([i915#2530])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-tglb1/igt@nouveau_crc@pipe-a-source-outp-complete.html
    - shard-iclb:         NOTRUN -> [SKIP][82] ([i915#2530])
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb5/igt@nouveau_crc@pipe-a-source-outp-complete.html

  * igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
    - shard-apl:          NOTRUN -> [SKIP][83] ([fdo#109271]) +267 similar issues
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl8/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html

  * igt@nouveau_crc@pipe-d-source-outp-complete:
    - shard-iclb:         NOTRUN -> [SKIP][84] ([fdo#109278] / [i915#2530])
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb3/igt@nouveau_crc@pipe-d-source-outp-complete.html

  * igt@prime_nv_api@i915_nv_import_vs_close:
    - shard-iclb:         NOTRUN -> [SKIP][85] ([fdo#109291])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb6/igt@prime_nv_api@i915_nv_import_vs_close.html

  * igt@sysfs_clients@fair-0:
    - shard-glk:          NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#2994])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-glk3/igt@sysfs_clients@fair-0.html

  * igt@sysfs_clients@fair-7:
    - shard-kbl:          NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#2994])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl6/igt@sysfs_clients@fair-7.html

  * igt@sysfs_clients@recycle-many:
    - shard-apl:          NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#2994]) +1 similar issue
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl1/igt@sysfs_clients@recycle-many.html

  
#### Possible fixes ####

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-apl:          [SKIP][89] ([fdo#109271]) -> [PASS][90]
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl6/igt@gem_exec_fair@basic-none-share@rcs0.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl7/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-tglb:         [FAIL][91] ([i915#2842]) -> [PASS][92] +2 similar issues
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_fair@basic-pace@vcs1:
    - shard-kbl:          [SKIP][93] ([fdo#109271]) -> [PASS][94]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs1.html

  * igt@gem_exec_fair@basic-pace@vecs0:
    - shard-kbl:          [FAIL][95] ([i915#2842]) -> [PASS][96]
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl4/igt@gem_exec_fair@basic-pace@vecs0.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl7/igt@gem_exec_fair@basic-pace@vecs0.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-iclb:         [FAIL][97] ([i915#2849]) -> [PASS][98]
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb4/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_mmap_gtt@cpuset-big-copy:
    - shard-iclb:         [FAIL][99] ([i915#307]) -> [PASS][100]
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb7/igt@gem_mmap_gtt@cpuset-big-copy.html
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb6/igt@gem_mmap_gtt@cpuset-big-copy.html

  * igt@kms_big_fb@y-tiled-32bpp-rotate-0:
    - shard-glk:          [DMESG-WARN][101] ([i915#118] / [i915#95]) -> [PASS][102]
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk2/igt@kms_big_fb@y-tiled-32bpp-rotate-0.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-glk5/igt@kms_big_fb@y-tiled-32bpp-rotate-0.html

  * igt@kms_cursor_crc@pipe-c-cursor-128x128-random:
    - shard-kbl:          [FAIL][103] ([i915#3444]) -> [PASS][104]
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-kbl:          [DMESG-WARN][105] ([i915#180]) -> [PASS][106]
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_flip@plain-flip-fb-recreate-interruptible@a-hdmi-a1:
    - shard-glk:          [FAIL][107] ([i915#2122]) -> [PASS][108]
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk6/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-hdmi-a1.html
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-glk7/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-hdmi-a1.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
    - shard-snb:          [SKIP][109] ([fdo#109271]) -> [PASS][110]
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-snb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen.html
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-snb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen.html

  * igt@kms_hdr@bpc-switch-suspend:
    - shard-apl:          [DMESG-WARN][111] ([i915#180]) -> [PASS][112] +3 similar issues
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl3/igt@kms_hdr@bpc-switch-suspend.html
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl2/igt@kms_hdr@bpc-switch-suspend.html

  * igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
    - shard-iclb:         [INCOMPLETE][113] ([i915#3622]) -> [PASS][114]
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb2/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html

  * igt@kms_plane@plane-position-hole-dpms@pipe-b-planes:
    - shard-glk:          [FAIL][115] ([i915#2472]) -> [PASS][116]
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-glk3/igt@kms_plane@plane-position-hole-dpms@pipe-b-planes.html
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-glk5/igt@kms_plane@plane-position-hole-dpms@pipe-b-planes.html

  * igt@kms_psr@psr2_sprite_blt:
    - shard-iclb:         [SKIP][117] ([fdo#109441]) -> [PASS][118] +2 similar issues
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb5/igt@kms_psr@psr2_sprite_blt.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html

  
#### Warnings ####

  * igt@i915_pm_rc6_residency@rc6-fence:
    - shard-iclb:         [WARN][119] ([i915#1804] / [i915#2684]) -> [WARN][120] ([i915#2684])
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb8/igt@i915_pm_rc6_residency@rc6-fence.html

  * igt@kms_psr2_sf@cursor-plane-update-sf:
    - shard-iclb:         [SKIP][121] ([i915#2920]) -> [SKIP][122] ([i915#658])
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb5/igt@kms_psr2_sf@cursor-plane-update-sf.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
    - shard-iclb:         [SKIP][123] ([i915#658]) -> [SKIP][124] ([i915#2920]) +1 similar issue
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb5/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html

  * igt@runner@aborted:
    - shard-kbl:          ([FAIL][125], [FAIL][126], [FAIL][127]) ([i915#1436] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363]) -> ([FAIL][128], [FAIL][129]) ([i915#3002] / [i915#3363])
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl3/igt@runner@aborted.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl6/igt@runner@aborted.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-kbl2/igt@runner@aborted.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl4/igt@runner@aborted.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-kbl1/igt@runner@aborted.html
    - shard-iclb:         ([FAIL][130], [FAIL][131]) ([i915#3002]) -> ([FAIL][132], [FAIL][133], [FAIL][134]) ([i915#1814] / [i915#3002])
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb4/igt@runner@aborted.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-iclb4/igt@runner@aborted.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb5/igt@runner@aborted.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb7/igt@runner@aborted.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-iclb1/igt@runner@aborted.html
    - shard-apl:          ([FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363])
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl3/igt@runner@aborted.html
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl1/igt@runner@aborted.html
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl6/igt@runner@aborted.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl1/igt@runner@aborted.html
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl6/igt@runner@aborted.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10246/shard-apl3/igt@runner@aborted.html
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl8/igt@runner@aborted.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl8/igt@runner@aborted.html
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl6/igt@runner@aborted.html
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl3/igt@runner@aborted.html
   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl1/igt@runner@aborted.html
   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/shard-apl2/igt@runner@aborted.html

  
  [IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
  [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
  [fdo#109310]: https://bugs.freedesktop.org/show_bug.cgi?id=109310
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110577]: https://bugs.freedesktop.org/show_bug.cgi?id=110577
  [fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
  [fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5944/index.html

[-- Attachment #1.2: Type: text/html, Size: 35849 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Juha-Pekka Heikkila]

That issue where solid white is also failing *sometimes* sound like 
there maybe two separate issues.

I'd suggest for experimenting try using solid white, move starting of 
crc counting at the very beginning of the test function and place wait 
for vblank always before reading crcs. If this will help then the same 
crc issue which was earlier on kms_big_fb test is also causing problem here.

/Juha-Pekka

On 19.6.2021 11.24, Srinivas, Vidya wrote:
> Hello Juha-Pekka,
> 
> Thank you so much. I tried the LUT table you suggested and it worked https://patchwork.freedesktop.org/patch/440145/?series=90828&rev=4
> Could you kindly check if it is right? 0.25 and 0.75 did not work. 1,1,1 too is failing once in a while.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Saturday, June 19, 2021 8:40 AM
> To: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>; igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <Charlton.Lin@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant
> 
> Thank you so much Juha-Pekka. I will try out the gamma thing you mentioned and update further.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>
> Sent: Saturday, June 19, 2021 1:54 AM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant
> 
> Hi Vidya,
> 
> I don't now have access to specs so I can't say if there would be something special for JSL on this case. OTOH if changing gray buffer to solid white fixes that maybe good solution, I'm trying to think how the screen will be in this case and I assume test image will remain on screen(?). If just changing gray buffer to solid white make test pass there maybe also 0.25 gray and 0.75 gray which will work. It wouldn't be the first time there is found case with specific color which causes rounding error with crc where it's just more convenient to change that color.
> 
> I don't know can it be used in this case but there might be possibility to do gamma table trick if nothing else works. This is used in kms_plane and kms_flip_scaled_crc that come to my mind, in tests/kms_flip_scaled_crc.c look for set_lut(..) function and how it is used.
> 
> I'd avoid creating special cases for some hw versions, it will lead to big mess in the end.
> 
> /Juha-Pekka
> 
> Srinivas, Vidya kirjoitti 18.6.2021 klo 21.54:
>> Hello Juha-Pekka,
>>
>> As you said, I guess that might be the problem. But the changes of WA are already present in kernel. I tried reverting them just to check, but did not see any change.
>> If I change the gray buffer (0.5 to 1,1,1) it works. If I comment first primary commit it works. If I just comment "Pre-multiplied" it works, else lower alpha works.
>> Couldn’t find any other changes yet in driver. Would it be okay if I can add a patch to disable primary commit if JASPERLAKE?
>>
>> Thank you so much.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Srinivas, Vidya
>> Sent: Friday, June 18, 2021 4:01 PM
>> To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton
>> <Charlton.Lin@intel.com>
>> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix
>> alpha in coverage-vs-premult-vs-constant
>>
>> Thank you so much Juha-Pekka. I will check on the same and update.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> Sent: Friday, June 18, 2021 3:56 PM
>> To: Srinivas, Vidya <vidya.srinivas@intel.com>;
>> igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton
>> <charlton.lin@intel.com>
>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix
>> alpha in coverage-vs-premult-vs-constant
>>
>> Have you tried looking if on kernel side in intel_display.c
>> icl_set_pipe_chicken(..) those icl related WAs have effect on your crc problem. Sound like setting PER_PIXEL_ALPHA_BYPASS_EN and PIXEL_ROUNDING_TRUNC_FB_PASSTHRU touch exactly the problem you are seeing. Maybe different hw revision behave differently? Try see if there's on spec some note for your HW revision for these WAs.
>>
>> /Juha-Pekka
>>
>> On 18.6.2021 11.58, Srinivas, Vidya wrote:
>>> Thank you so much Juha-Pekka.
>>>
>>> https://patchwork.freedesktop.org/patch/436194/?series=90828&rev=2
>>> just removes the DRM_PLANE_TYPE_PRIMARY fb setting from subtest That works. Would that be an okay change?
>>>
>>> Because without the commit after PRIMARY and alpha value 0x7e, JSL is failing. If we just don’t do the PRIMARY fb setting at start, test works as is.
>>>
>>> Kindly suggest. Thank you very much once again.
>>>
>>> Regards
>>> Vidya
>>>
>>> -----Original Message-----
>>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>>> Sent: Friday, June 18, 2021 2:23 PM
>>> To: Srinivas, Vidya <vidya.srinivas@intel.com>;
>>> igt-dev@lists.freedesktop.org
>>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton
>>> <charlton.lin@intel.com>
>>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix
>>> alpha in coverage-vs-premult-vs-constant
>>>
>>> On 11.6.2021 15.44, Vidya Srinivas wrote:
>>>> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant
>>>> as per the buffer being created initially in prepare_crtc. Patch
>>>> also add commit after setting fb on primary plane. Without this
>>>> change CRC mismatch is seen on few Gen11 systems.
>>>>
>>>> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>>>> ---
>>>>      tests/kms_plane_alpha_blend.c | 9 +++++++--
>>>>      1 file changed, 7 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/tests/kms_plane_alpha_blend.c
>>>> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..d3a73cf43fcd
>>>> 100644
>>>> --- a/tests/kms_plane_alpha_blend.c
>>>> +++ b/tests/kms_plane_alpha_blend.c
>>>> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>>>>      	igt_crc_t ref_crc = {}, crc = {};
>>>>      
>>>>      	/* Set a background color on the primary fb for testing */
>>>> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
>>>> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>>>>      		
>>>> igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
>>>> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
>>>> +		igt_display_commit2(display, COMMIT_ATOMIC);
>>>
>>> Why this extra commit needed? There's just below commit before crc is
>>> started
>>>
>>>> +	}
>>>>      
>>>>      	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
>>>> "Coverage");
>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>
>>> On this test there's already per pixel alpha, setting plane alpha values so low will probably in this case in final rounding make these planes completely invisible. I'd suspect you can get any image pass crc doing it like this. Likely what you see on screen with these values is just pure grey instead of intended test image.
>>>
>>>
>>>>      	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>>      	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>      	igt_pipe_crc_start(data->pipe_crc);
>>>>      	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>>>>      
>>>>      	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
>>>> "Pre-multiplied");
>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>      	igt_plane_set_fb(plane, &data->argb_fb_7e);
>>>>      	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>      	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>>      	igt_assert_crc_equal(&ref_crc, &crc);
>>>>      
>>>>      	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>>>> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>      	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>>      	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>      	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>>      	igt_assert_crc_equal(&ref_crc, &crc);
>>>>      
>>>>      	igt_pipe_crc_stop(data->pipe_crc);
>>>> +
>>>
>>> stray new line
>>>
>>>>      }
>>>>      
>>>>      static void run_test_on_pipe_planes(data_t *data, enum pipe
>>>> pipe, bool blend,
>>>>
>>>
>>

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Thank you so much Juha-Pekka. I will try the same and update.

Regards
Vidya

-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> 
Sent: Monday, June 21, 2021 1:35 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

That issue where solid white is also failing *sometimes* sound like there maybe two separate issues.

I'd suggest for experimenting try using solid white, move starting of crc counting at the very beginning of the test function and place wait for vblank always before reading crcs. If this will help then the same crc issue which was earlier on kms_big_fb test is also causing problem here.

/Juha-Pekka

On 19.6.2021 11.24, Srinivas, Vidya wrote:
> Hello Juha-Pekka,
> 
> Thank you so much. I tried the LUT table you suggested and it worked 
> https://patchwork.freedesktop.org/patch/440145/?series=90828&rev=4
> Could you kindly check if it is right? 0.25 and 0.75 did not work. 1,1,1 too is failing once in a while.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Saturday, June 19, 2021 8:40 AM
> To: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>; 
> igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <Charlton.Lin@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> Thank you so much Juha-Pekka. I will try out the gamma thing you mentioned and update further.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>
> Sent: Saturday, June 19, 2021 1:54 AM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> Hi Vidya,
> 
> I don't now have access to specs so I can't say if there would be something special for JSL on this case. OTOH if changing gray buffer to solid white fixes that maybe good solution, I'm trying to think how the screen will be in this case and I assume test image will remain on screen(?). If just changing gray buffer to solid white make test pass there maybe also 0.25 gray and 0.75 gray which will work. It wouldn't be the first time there is found case with specific color which causes rounding error with crc where it's just more convenient to change that color.
> 
> I don't know can it be used in this case but there might be possibility to do gamma table trick if nothing else works. This is used in kms_plane and kms_flip_scaled_crc that come to my mind, in tests/kms_flip_scaled_crc.c look for set_lut(..) function and how it is used.
> 
> I'd avoid creating special cases for some hw versions, it will lead to big mess in the end.
> 
> /Juha-Pekka
> 
> Srinivas, Vidya kirjoitti 18.6.2021 klo 21.54:
>> Hello Juha-Pekka,
>>
>> As you said, I guess that might be the problem. But the changes of WA are already present in kernel. I tried reverting them just to check, but did not see any change.
>> If I change the gray buffer (0.5 to 1,1,1) it works. If I comment first primary commit it works. If I just comment "Pre-multiplied" it works, else lower alpha works.
>> Couldn’t find any other changes yet in driver. Would it be okay if I can add a patch to disable primary commit if JASPERLAKE?
>>
>> Thank you so much.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Srinivas, Vidya
>> Sent: Friday, June 18, 2021 4:01 PM
>> To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>> <Charlton.Lin@intel.com>
>> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
>> alpha in coverage-vs-premult-vs-constant
>>
>> Thank you so much Juha-Pekka. I will check on the same and update.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> Sent: Friday, June 18, 2021 3:56 PM
>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
>> igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>> <charlton.lin@intel.com>
>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
>> alpha in coverage-vs-premult-vs-constant
>>
>> Have you tried looking if on kernel side in intel_display.c
>> icl_set_pipe_chicken(..) those icl related WAs have effect on your crc problem. Sound like setting PER_PIXEL_ALPHA_BYPASS_EN and PIXEL_ROUNDING_TRUNC_FB_PASSTHRU touch exactly the problem you are seeing. Maybe different hw revision behave differently? Try see if there's on spec some note for your HW revision for these WAs.
>>
>> /Juha-Pekka
>>
>> On 18.6.2021 11.58, Srinivas, Vidya wrote:
>>> Thank you so much Juha-Pekka.
>>>
>>> https://patchwork.freedesktop.org/patch/436194/?series=90828&rev=2
>>> just removes the DRM_PLANE_TYPE_PRIMARY fb setting from subtest That works. Would that be an okay change?
>>>
>>> Because without the commit after PRIMARY and alpha value 0x7e, JSL is failing. If we just don’t do the PRIMARY fb setting at start, test works as is.
>>>
>>> Kindly suggest. Thank you very much once again.
>>>
>>> Regards
>>> Vidya
>>>
>>> -----Original Message-----
>>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>>> Sent: Friday, June 18, 2021 2:23 PM
>>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
>>> igt-dev@lists.freedesktop.org
>>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>>> <charlton.lin@intel.com>
>>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
>>> Fix alpha in coverage-vs-premult-vs-constant
>>>
>>> On 11.6.2021 15.44, Vidya Srinivas wrote:
>>>> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant 
>>>> as per the buffer being created initially in prepare_crtc. Patch 
>>>> also add commit after setting fb on primary plane. Without this 
>>>> change CRC mismatch is seen on few Gen11 systems.
>>>>
>>>> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>>>> ---
>>>>      tests/kms_plane_alpha_blend.c | 9 +++++++--
>>>>      1 file changed, 7 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/tests/kms_plane_alpha_blend.c 
>>>> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..d3a73cf43fcd
>>>> 100644
>>>> --- a/tests/kms_plane_alpha_blend.c
>>>> +++ b/tests/kms_plane_alpha_blend.c
>>>> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>>>>      	igt_crc_t ref_crc = {}, crc = {};
>>>>      
>>>>      	/* Set a background color on the primary fb for testing */
>>>> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
>>>> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>>>>      		
>>>> igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
>>>> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
>>>> +		igt_display_commit2(display, COMMIT_ATOMIC);
>>>
>>> Why this extra commit needed? There's just below commit before crc 
>>> is started
>>>
>>>> +	}
>>>>      
>>>>      	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>>>> "Coverage");
>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>
>>> On this test there's already per pixel alpha, setting plane alpha values so low will probably in this case in final rounding make these planes completely invisible. I'd suspect you can get any image pass crc doing it like this. Likely what you see on screen with these values is just pure grey instead of intended test image.
>>>
>>>
>>>>      	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>>      	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>      	igt_pipe_crc_start(data->pipe_crc);
>>>>      	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>>>>      
>>>>      	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>>>> "Pre-multiplied");
>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>      	igt_plane_set_fb(plane, &data->argb_fb_7e);
>>>>      	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>      	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>>      	igt_assert_crc_equal(&ref_crc, &crc);
>>>>      
>>>>      	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>>>> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>      	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>>      	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>      	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>>      	igt_assert_crc_equal(&ref_crc, &crc);
>>>>      
>>>>      	igt_pipe_crc_stop(data->pipe_crc);
>>>> +
>>>
>>> stray new line
>>>
>>>>      }
>>>>      
>>>>      static void run_test_on_pipe_planes(data_t *data, enum pipe 
>>>> pipe, bool blend,
>>>>
>>>
>>

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Use alpha for primary plane for coverage-vs-premult-vs-constant

[Vidya Srinivas]

Few Gen11 systems report CRC mismatch with higher alpha values if
primary plane with gray without alpha is enabled. So in order to get
the coverage vs. premult vs. constant crc to match use alpha gray buffer
for primary plane as well in coverage-vs-premult-vs-constant.

Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..ca9e1c3829ba 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -31,7 +31,7 @@ IGT_TEST_DESCRIPTION("Test plane alpha and blending mode properties");
 typedef struct {
 	int gfx_fd;
 	igt_display_t display;
-	struct igt_fb xrgb_fb, argb_fb_0, argb_fb_cov_0, argb_fb_7e, argb_fb_cov_7e, argb_fb_fc, argb_fb_cov_fc, argb_fb_100, black_fb, gray_fb;
+	struct igt_fb xrgb_fb, argb_fb_0, argb_fb_cov_0, argb_fb_7e, argb_fb_cov_7e, argb_fb_fc, argb_fb_cov_fc, argb_fb_100, black_fb, gray_fb, argb_gray_fb;
 	igt_crc_t ref_crc;
 	igt_pipe_crc_t *pipe_crc;
 } data_t;
@@ -182,6 +182,7 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe)
 		igt_remove_fb(data->gfx_fd, &data->argb_fb_100);
 		igt_remove_fb(data->gfx_fd, &data->black_fb);
 		igt_remove_fb(data->gfx_fd, &data->gray_fb);
+		igt_remove_fb(data->gfx_fd, &data->argb_gray_fb);
 
 		igt_create_fb(data->gfx_fd, w, h,
 			      DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE,
@@ -204,6 +205,15 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe)
 
 		igt_create_fb(data->gfx_fd, w, h,
 			      DRM_FORMAT_ARGB8888, LOCAL_DRM_FORMAT_MOD_NONE,
+			      &data->argb_gray_fb);
+
+		cr = igt_get_cairo_ctx(data->gfx_fd, &data->argb_gray_fb);
+		cairo_set_operator(cr, CAIRO_OPERATOR_SOURCE);
+		igt_paint_color_alpha(cr, 0, 0, w, h, .5, .5, .5, 0.0);
+		igt_put_cairo_ctx(cr);
+
+		igt_create_fb(data->gfx_fd, w, h,
+			      DRM_FORMAT_ARGB8888, LOCAL_DRM_FORMAT_MOD_NONE,
 			      &data->argb_fb_7e);
 		draw_squares(&data->argb_fb_7e, w, h, 126. / 255.);
 
@@ -449,7 +459,7 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 
 	/* Set a background color on the primary fb for testing */
 	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
-		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
+		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->argb_gray_fb);
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
@@ -471,6 +481,10 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_assert_crc_equal(&ref_crc, &crc);
 
 	igt_pipe_crc_stop(data->pipe_crc);
+
+	igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), NULL);
+	igt_plane_set_fb(plane, NULL);
+	igt_display_commit2(display, COMMIT_ATOMIC);
 }
 
 static void run_test_on_pipe_planes(data_t *data, enum pipe pipe, bool blend,
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Hello Juha-Pekka,

Thank you so much. I tried pulling the crc start to the beginning and used current crc same way as kms_big_fb. Whatever I do, with regular white fb, I couldn’t get it working even once (it had worked the other day). I tried normal ARGB white fb too instead of XRGB but that too wont work. I created another gray fb with alpha like the other argb buffers and this seems to work. Both gray and white work. I have kept it gray for now.

Apologies for bothering you. Kindly have a check of this version and suggest please https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6

Regards
Vidya

-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> 
Sent: Monday, June 21, 2021 1:35 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

That issue where solid white is also failing *sometimes* sound like there maybe two separate issues.

I'd suggest for experimenting try using solid white, move starting of crc counting at the very beginning of the test function and place wait for vblank always before reading crcs. If this will help then the same crc issue which was earlier on kms_big_fb test is also causing problem here.

/Juha-Pekka

On 19.6.2021 11.24, Srinivas, Vidya wrote:
> Hello Juha-Pekka,
> 
> Thank you so much. I tried the LUT table you suggested and it worked 
> https://patchwork.freedesktop.org/patch/440145/?series=90828&rev=4
> Could you kindly check if it is right? 0.25 and 0.75 did not work. 1,1,1 too is failing once in a while.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Saturday, June 19, 2021 8:40 AM
> To: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>; 
> igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <Charlton.Lin@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> Thank you so much Juha-Pekka. I will try out the gamma thing you mentioned and update further.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>
> Sent: Saturday, June 19, 2021 1:54 AM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> Hi Vidya,
> 
> I don't now have access to specs so I can't say if there would be something special for JSL on this case. OTOH if changing gray buffer to solid white fixes that maybe good solution, I'm trying to think how the screen will be in this case and I assume test image will remain on screen(?). If just changing gray buffer to solid white make test pass there maybe also 0.25 gray and 0.75 gray which will work. It wouldn't be the first time there is found case with specific color which causes rounding error with crc where it's just more convenient to change that color.
> 
> I don't know can it be used in this case but there might be possibility to do gamma table trick if nothing else works. This is used in kms_plane and kms_flip_scaled_crc that come to my mind, in tests/kms_flip_scaled_crc.c look for set_lut(..) function and how it is used.
> 
> I'd avoid creating special cases for some hw versions, it will lead to big mess in the end.
> 
> /Juha-Pekka
> 
> Srinivas, Vidya kirjoitti 18.6.2021 klo 21.54:
>> Hello Juha-Pekka,
>>
>> As you said, I guess that might be the problem. But the changes of WA are already present in kernel. I tried reverting them just to check, but did not see any change.
>> If I change the gray buffer (0.5 to 1,1,1) it works. If I comment first primary commit it works. If I just comment "Pre-multiplied" it works, else lower alpha works.
>> Couldn’t find any other changes yet in driver. Would it be okay if I can add a patch to disable primary commit if JASPERLAKE?
>>
>> Thank you so much.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Srinivas, Vidya
>> Sent: Friday, June 18, 2021 4:01 PM
>> To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>> <Charlton.Lin@intel.com>
>> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
>> alpha in coverage-vs-premult-vs-constant
>>
>> Thank you so much Juha-Pekka. I will check on the same and update.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> Sent: Friday, June 18, 2021 3:56 PM
>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
>> igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>> <charlton.lin@intel.com>
>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
>> alpha in coverage-vs-premult-vs-constant
>>
>> Have you tried looking if on kernel side in intel_display.c
>> icl_set_pipe_chicken(..) those icl related WAs have effect on your crc problem. Sound like setting PER_PIXEL_ALPHA_BYPASS_EN and PIXEL_ROUNDING_TRUNC_FB_PASSTHRU touch exactly the problem you are seeing. Maybe different hw revision behave differently? Try see if there's on spec some note for your HW revision for these WAs.
>>
>> /Juha-Pekka
>>
>> On 18.6.2021 11.58, Srinivas, Vidya wrote:
>>> Thank you so much Juha-Pekka.
>>>
>>> https://patchwork.freedesktop.org/patch/436194/?series=90828&rev=2
>>> just removes the DRM_PLANE_TYPE_PRIMARY fb setting from subtest That works. Would that be an okay change?
>>>
>>> Because without the commit after PRIMARY and alpha value 0x7e, JSL is failing. If we just don’t do the PRIMARY fb setting at start, test works as is.
>>>
>>> Kindly suggest. Thank you very much once again.
>>>
>>> Regards
>>> Vidya
>>>
>>> -----Original Message-----
>>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>>> Sent: Friday, June 18, 2021 2:23 PM
>>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
>>> igt-dev@lists.freedesktop.org
>>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>>> <charlton.lin@intel.com>
>>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
>>> Fix alpha in coverage-vs-premult-vs-constant
>>>
>>> On 11.6.2021 15.44, Vidya Srinivas wrote:
>>>> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant 
>>>> as per the buffer being created initially in prepare_crtc. Patch 
>>>> also add commit after setting fb on primary plane. Without this 
>>>> change CRC mismatch is seen on few Gen11 systems.
>>>>
>>>> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>>>> ---
>>>>      tests/kms_plane_alpha_blend.c | 9 +++++++--
>>>>      1 file changed, 7 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/tests/kms_plane_alpha_blend.c 
>>>> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..d3a73cf43fcd
>>>> 100644
>>>> --- a/tests/kms_plane_alpha_blend.c
>>>> +++ b/tests/kms_plane_alpha_blend.c
>>>> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>>>>      	igt_crc_t ref_crc = {}, crc = {};
>>>>      
>>>>      	/* Set a background color on the primary fb for testing */
>>>> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
>>>> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>>>>      		
>>>> igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
>>>> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
>>>> +		igt_display_commit2(display, COMMIT_ATOMIC);
>>>
>>> Why this extra commit needed? There's just below commit before crc 
>>> is started
>>>
>>>> +	}
>>>>      
>>>>      	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>>>> "Coverage");
>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>
>>> On this test there's already per pixel alpha, setting plane alpha values so low will probably in this case in final rounding make these planes completely invisible. I'd suspect you can get any image pass crc doing it like this. Likely what you see on screen with these values is just pure grey instead of intended test image.
>>>
>>>
>>>>      	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>>      	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>      	igt_pipe_crc_start(data->pipe_crc);
>>>>      	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>>>>      
>>>>      	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>>>> "Pre-multiplied");
>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>      	igt_plane_set_fb(plane, &data->argb_fb_7e);
>>>>      	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>      	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>>      	igt_assert_crc_equal(&ref_crc, &crc);
>>>>      
>>>>      	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>>>> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>      	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>>      	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>      	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>>      	igt_assert_crc_equal(&ref_crc, &crc);
>>>>      
>>>>      	igt_pipe_crc_stop(data->pipe_crc);
>>>> +
>>>
>>> stray new line
>>>
>>>>      }
>>>>      
>>>>      static void run_test_on_pipe_planes(data_t *data, enum pipe 
>>>> pipe, bool blend,
>>>>
>>>
>>

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev6)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 5594 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev6)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10253 -> IGTPW_5948
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_5948:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_selftest@live@migrate:
    - {fi-tgl-dsi}:       [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/fi-tgl-dsi/igt@i915_selftest@live@migrate.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/fi-tgl-dsi/igt@i915_selftest@live@migrate.html

  
Known issues
------------

  Here are the changes found in IGTPW_5948 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@debugfs_test@read_all_entries:
    - fi-cfl-8109u:       [PASS][3] -> [DMESG-WARN][4] ([i915#203] / [i915#262])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/fi-cfl-8109u/igt@debugfs_test@read_all_entries.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/fi-cfl-8109u/igt@debugfs_test@read_all_entries.html

  * igt@gem_exec_gttfill@basic:
    - fi-bsw-n3050:       NOTRUN -> [SKIP][5] ([fdo#109271])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/fi-bsw-n3050/igt@gem_exec_gttfill@basic.html

  * igt@gem_exec_suspend@basic-s0:
    - fi-cfl-8109u:       [PASS][6] -> [DMESG-WARN][7] ([i915#262])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html

  * igt@gem_exec_suspend@basic-s3:
    - fi-bsw-n3050:       NOTRUN -> [INCOMPLETE][8] ([i915#3159])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/fi-bsw-n3050/igt@gem_exec_suspend@basic-s3.html

  * igt@i915_selftest@live@hangcheck:
    - fi-icl-y:           [PASS][9] -> [INCOMPLETE][10] ([i915#2782])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/fi-icl-y/igt@i915_selftest@live@hangcheck.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/fi-icl-y/igt@i915_selftest@live@hangcheck.html

  * igt@runner@aborted:
    - fi-icl-y:           NOTRUN -> [FAIL][11] ([i915#2782])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/fi-icl-y/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@execlists:
    - fi-cfl-8109u:       [DMESG-WARN][12] ([i915#203]) -> [PASS][13] +3 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/fi-cfl-8109u/igt@i915_selftest@live@execlists.html

  * igt@i915_selftest@live@hangcheck:
    - {fi-hsw-gt1}:       [DMESG-WARN][14] ([i915#3303]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-kbl-7500u:       [DMESG-FAIL][16] ([i915#165]) -> [PASS][17]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       [FAIL][18] ([i915#1372]) -> [PASS][19]
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
  [i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
  [i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
  [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
  [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
  [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
  [i915#3159]: https://gitlab.freedesktop.org/drm/intel/issues/3159
  [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303


Participating hosts (44 -> 40)
------------------------------

  Additional (1): fi-bsw-n3050 
  Missing    (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6115 -> IGTPW_5948

  CI-20190529: 20190529
  CI_DRM_10253: 9e675b3a06dd8f510d3f22073a925c69f28a75db @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_5948: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/index.html
  IGT_6115: 4ef420186b82f1a6d9c9b69d2f8de4fd100a2af3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/index.html

[-- Attachment #1.2: Type: text/html, Size: 6611 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev6)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 30295 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev6)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10253_full -> IGTPW_5948_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/index.html

Known issues
------------

  Here are the changes found in IGTPW_5948_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@feature_discovery@display-3x:
    - shard-glk:          NOTRUN -> [SKIP][1] ([fdo#109271]) +98 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-glk7/igt@feature_discovery@display-3x.html

  * igt@gem_ctx_persistence@legacy-engines-mixed-process:
    - shard-snb:          NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +7 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-snb5/igt@gem_ctx_persistence@legacy-engines-mixed-process.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-tglb:         [PASS][3] -> [FAIL][4] ([i915#2846])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-tglb2/igt@gem_exec_fair@basic-deadline.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb7/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none@vecs0:
    - shard-kbl:          [PASS][5] -> [FAIL][6] ([i915#2842]) +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl1/igt@gem_exec_fair@basic-none@vecs0.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl4/igt@gem_exec_fair@basic-none@vecs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-tglb:         [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_fair@basic-pace@vcs0:
    - shard-kbl:          [PASS][9] -> [SKIP][10] ([fdo#109271])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs0.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs0.html

  * igt@gem_exec_fair@basic-pace@vecs0:
    - shard-glk:          [PASS][11] -> [FAIL][12] ([i915#2842])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-glk1/igt@gem_exec_fair@basic-pace@vecs0.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-glk7/igt@gem_exec_fair@basic-pace@vecs0.html

  * igt@gem_exec_flush@basic-batch-kernel-default-cmd:
    - shard-snb:          NOTRUN -> [SKIP][13] ([fdo#109271]) +417 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-snb5/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html

  * igt@gem_exec_whisper@basic-forked:
    - shard-glk:          [PASS][14] -> [DMESG-WARN][15] ([i915#118] / [i915#95]) +2 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-glk2/igt@gem_exec_whisper@basic-forked.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-glk6/igt@gem_exec_whisper@basic-forked.html

  * igt@gem_mmap_offset@clear:
    - shard-iclb:         [PASS][16] -> [FAIL][17] ([i915#3160])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-iclb8/igt@gem_mmap_offset@clear.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb6/igt@gem_mmap_offset@clear.html

  * igt@gem_pread@exhaustion:
    - shard-apl:          NOTRUN -> [WARN][18] ([i915#2658]) +1 similar issue
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl7/igt@gem_pread@exhaustion.html
    - shard-kbl:          NOTRUN -> [WARN][19] ([i915#2658])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl3/igt@gem_pread@exhaustion.html

  * igt@gem_render_copy@y-tiled-ccs-to-yf-tiled-mc-ccs:
    - shard-iclb:         NOTRUN -> [SKIP][20] ([i915#768])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb4/igt@gem_render_copy@y-tiled-ccs-to-yf-tiled-mc-ccs.html

  * igt@gem_userptr_blits@dmabuf-sync:
    - shard-apl:          NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#3323])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl8/igt@gem_userptr_blits@dmabuf-sync.html

  * igt@gem_userptr_blits@vma-merge:
    - shard-snb:          NOTRUN -> [FAIL][22] ([i915#2724])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-snb2/igt@gem_userptr_blits@vma-merge.html

  * igt@gen7_exec_parse@cmd-crossing-page:
    - shard-tglb:         NOTRUN -> [SKIP][23] ([fdo#109289]) +1 similar issue
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb8/igt@gen7_exec_parse@cmd-crossing-page.html
    - shard-iclb:         NOTRUN -> [SKIP][24] ([fdo#109289]) +1 similar issue
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb7/igt@gen7_exec_parse@cmd-crossing-page.html

  * igt@gen9_exec_parse@cmd-crossing-page:
    - shard-tglb:         NOTRUN -> [SKIP][25] ([fdo#112306])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb8/igt@gen9_exec_parse@cmd-crossing-page.html
    - shard-iclb:         NOTRUN -> [SKIP][26] ([fdo#112306])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb5/igt@gen9_exec_parse@cmd-crossing-page.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-kbl:          NOTRUN -> [FAIL][27] ([i915#454])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl2/igt@i915_pm_dc@dc6-dpms.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
    - shard-apl:          NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#1937])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html

  * igt@i915_pm_rpm@modeset-lpsp-stress:
    - shard-apl:          NOTRUN -> [SKIP][29] ([fdo#109271]) +243 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl2/igt@i915_pm_rpm@modeset-lpsp-stress.html

  * igt@i915_suspend@forcewake:
    - shard-apl:          [PASS][30] -> [DMESG-WARN][31] ([i915#180])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-apl8/igt@i915_suspend@forcewake.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl6/igt@i915_suspend@forcewake.html

  * igt@kms_big_fb@linear-32bpp-rotate-180:
    - shard-glk:          NOTRUN -> [DMESG-WARN][32] ([i915#118] / [i915#95])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-glk2/igt@kms_big_fb@linear-32bpp-rotate-180.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-270:
    - shard-iclb:         NOTRUN -> [SKIP][33] ([fdo#110725] / [fdo#111614])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb3/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html
    - shard-tglb:         NOTRUN -> [SKIP][34] ([fdo#111614])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb6/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html

  * igt@kms_big_fb@yf-tiled-8bpp-rotate-270:
    - shard-iclb:         NOTRUN -> [SKIP][35] ([fdo#110723])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb2/igt@kms_big_fb@yf-tiled-8bpp-rotate-270.html
    - shard-tglb:         NOTRUN -> [SKIP][36] ([fdo#111615]) +1 similar issue
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb1/igt@kms_big_fb@yf-tiled-8bpp-rotate-270.html

  * igt@kms_chamelium@dp-mode-timings:
    - shard-apl:          NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +26 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl1/igt@kms_chamelium@dp-mode-timings.html

  * igt@kms_chamelium@hdmi-mode-timings:
    - shard-kbl:          NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +14 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl1/igt@kms_chamelium@hdmi-mode-timings.html
    - shard-iclb:         NOTRUN -> [SKIP][39] ([fdo#109284] / [fdo#111827]) +4 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb7/igt@kms_chamelium@hdmi-mode-timings.html

  * igt@kms_chamelium@vga-hpd-enable-disable-mode:
    - shard-glk:          NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +12 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-glk4/igt@kms_chamelium@vga-hpd-enable-disable-mode.html

  * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
    - shard-snb:          NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +27 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-snb2/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html

  * igt@kms_color_chamelium@pipe-d-ctm-limited-range:
    - shard-tglb:         NOTRUN -> [SKIP][42] ([fdo#109284] / [fdo#111827]) +5 similar issues
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb3/igt@kms_color_chamelium@pipe-d-ctm-limited-range.html
    - shard-iclb:         NOTRUN -> [SKIP][43] ([fdo#109278] / [fdo#109284] / [fdo#111827])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb6/igt@kms_color_chamelium@pipe-d-ctm-limited-range.html

  * igt@kms_content_protection@atomic-dpms:
    - shard-tglb:         NOTRUN -> [SKIP][44] ([fdo#111828])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb1/igt@kms_content_protection@atomic-dpms.html
    - shard-iclb:         NOTRUN -> [SKIP][45] ([fdo#109300] / [fdo#111066])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb2/igt@kms_content_protection@atomic-dpms.html

  * igt@kms_content_protection@dp-mst-lic-type-0:
    - shard-iclb:         NOTRUN -> [SKIP][46] ([i915#3116])
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb7/igt@kms_content_protection@dp-mst-lic-type-0.html
    - shard-tglb:         NOTRUN -> [SKIP][47] ([i915#3116])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb8/igt@kms_content_protection@dp-mst-lic-type-0.html

  * igt@kms_cursor_crc@pipe-c-cursor-max-size-sliding:
    - shard-iclb:         NOTRUN -> [SKIP][48] ([fdo#109278]) +10 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb2/igt@kms_cursor_crc@pipe-c-cursor-max-size-sliding.html

  * igt@kms_cursor_crc@pipe-d-cursor-32x32-sliding:
    - shard-tglb:         NOTRUN -> [SKIP][49] ([i915#3319])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb8/igt@kms_cursor_crc@pipe-d-cursor-32x32-sliding.html

  * igt@kms_cursor_crc@pipe-d-cursor-max-size-rapid-movement:
    - shard-tglb:         NOTRUN -> [SKIP][50] ([i915#3359]) +2 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-max-size-rapid-movement.html

  * igt@kms_cursor_legacy@cursorb-vs-flipb-legacy:
    - shard-iclb:         NOTRUN -> [SKIP][51] ([fdo#109274] / [fdo#109278]) +1 similar issue
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb2/igt@kms_cursor_legacy@cursorb-vs-flipb-legacy.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-kbl:          [PASS][52] -> [INCOMPLETE][53] ([i915#155] / [i915#180] / [i915#636])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@2x-flip-vs-suspend:
    - shard-iclb:         NOTRUN -> [SKIP][54] ([fdo#109274]) +1 similar issue
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb7/igt@kms_flip@2x-flip-vs-suspend.html

  * igt@kms_flip@flip-vs-suspend@c-dp1:
    - shard-kbl:          NOTRUN -> [DMESG-WARN][55] ([i915#180]) +4 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl4/igt@kms_flip@flip-vs-suspend@c-dp1.html
    - shard-apl:          NOTRUN -> [DMESG-WARN][56] ([i915#180]) +2 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl2/igt@kms_flip@flip-vs-suspend@c-dp1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
    - shard-kbl:          NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#2642])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
    - shard-apl:          NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2642])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl6/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff:
    - shard-tglb:         NOTRUN -> [SKIP][59] ([fdo#111825]) +15 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
    - shard-iclb:         [PASS][60] -> [FAIL][61] ([i915#2546] / [i915#49])
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt:
    - shard-iclb:         NOTRUN -> [SKIP][62] ([fdo#109280]) +11 similar issues
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt.html

  * igt@kms_panel_fitting@legacy:
    - shard-kbl:          NOTRUN -> [SKIP][63] ([fdo#109271]) +157 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl2/igt@kms_panel_fitting@legacy.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
    - shard-apl:          NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#533]) +4 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl7/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html

  * igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
    - shard-kbl:          NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#533])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl3/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
    - shard-glk:          NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#533])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-glk5/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - shard-kbl:          [PASS][67] -> [DMESG-WARN][68] ([i915#180]) +2 similar issues
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
    - shard-apl:          NOTRUN -> [FAIL][69] ([fdo#108145] / [i915#265]) +2 similar issues
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl2/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-vs-premult-vs-constant:
    - shard-apl:          [PASS][70] -> [FAIL][71] ([fdo#108145] / [i915#265]) +1 similar issue
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-coverage-vs-premult-vs-constant.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-coverage-vs-premult-vs-constant.html
    - shard-kbl:          [PASS][72] -> [FAIL][73] ([fdo#108145] / [i915#265])
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl2/igt@kms_plane_alpha_blend@pipe-b-coverage-vs-premult-vs-constant.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl1/igt@kms_plane_alpha_blend@pipe-b-coverage-vs-premult-vs-constant.html

  * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
    - shard-glk:          NOTRUN -> [FAIL][74] ([fdo#108145] / [i915#265]) +1 similar issue
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-glk6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant:
    - shard-kbl:          NOTRUN -> [FAIL][75] ([fdo#108145] / [i915#265]) +3 similar issues
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl2/igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant.html

  * igt@kms_plane_cursor@pipe-b-overlay-size-256:
    - shard-iclb:         [PASS][76] -> [FAIL][77] ([i915#2657])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-iclb4/igt@kms_plane_cursor@pipe-b-overlay-size-256.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb8/igt@kms_plane_cursor@pipe-b-overlay-size-256.html
    - shard-glk:          [PASS][78] -> [FAIL][79] ([i915#2657])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-glk3/igt@kms_plane_cursor@pipe-b-overlay-size-256.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-glk9/igt@kms_plane_cursor@pipe-b-overlay-size-256.html

  * igt@kms_plane_lowres@pipe-b-tiling-x:
    - shard-iclb:         NOTRUN -> [SKIP][80] ([i915#3536]) +1 similar issue
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb1/igt@kms_plane_lowres@pipe-b-tiling-x.html
    - shard-tglb:         NOTRUN -> [SKIP][81] ([i915#3536])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb3/igt@kms_plane_lowres@pipe-b-tiling-x.html

  * igt@kms_plane_multiple@atomic-pipe-d-tiling-yf:
    - shard-tglb:         NOTRUN -> [SKIP][82] ([fdo#112054])
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb7/igt@kms_plane_multiple@atomic-pipe-d-tiling-yf.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
    - shard-apl:          NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#658]) +3 similar issues
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5:
    - shard-glk:          NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#658]) +2 similar issues
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-glk6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html
    - shard-tglb:         NOTRUN -> [SKIP][85] ([i915#2920])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html
    - shard-iclb:         NOTRUN -> [SKIP][86] ([i915#658])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
    - shard-kbl:          NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#658]) +1 similar issue
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         NOTRUN -> [SKIP][88] ([fdo#109441])
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html
    - shard-tglb:         NOTRUN -> [FAIL][89] ([i915#132] / [i915#3467])
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb8/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_psr@psr2_sprite_mmap_gtt:
    - shard-iclb:         [PASS][90] -> [SKIP][91] ([fdo#109441]) +1 similar issue
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          [PASS][92] -> [DMESG-WARN][93] ([i915#180] / [i915#295])
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@kms_writeback@writeback-check-output:
    - shard-apl:          NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#2437])
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl8/igt@kms_writeback@writeback-check-output.html

  * igt@nouveau_crc@pipe-d-source-outp-inactive:
    - shard-tglb:         NOTRUN -> [SKIP][95] ([i915#2530])
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb7/igt@nouveau_crc@pipe-d-source-outp-inactive.html
    - shard-iclb:         NOTRUN -> [SKIP][96] ([fdo#109278] / [i915#2530])
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb4/igt@nouveau_crc@pipe-d-source-outp-inactive.html

  * igt@prime_nv_pcopy@test1_macro:
    - shard-tglb:         NOTRUN -> [SKIP][97] ([fdo#109291])
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb5/igt@prime_nv_pcopy@test1_macro.html
    - shard-iclb:         NOTRUN -> [SKIP][98] ([fdo#109291])
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb3/igt@prime_nv_pcopy@test1_macro.html

  * igt@prime_vgem@fence-flip-hang:
    - shard-iclb:         NOTRUN -> [SKIP][99] ([fdo#109295])
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb8/igt@prime_vgem@fence-flip-hang.html
    - shard-tglb:         NOTRUN -> [SKIP][100] ([fdo#109295])
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb5/igt@prime_vgem@fence-flip-hang.html

  * igt@sysfs_clients@fair-3:
    - shard-kbl:          NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#2994]) +1 similar issue
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl4/igt@sysfs_clients@fair-3.html

  * igt@sysfs_clients@sema-10:
    - shard-tglb:         NOTRUN -> [SKIP][102] ([i915#2994])
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb2/igt@sysfs_clients@sema-10.html
    - shard-apl:          NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#2994]) +3 similar issues
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl6/igt@sysfs_clients@sema-10.html
    - shard-iclb:         NOTRUN -> [SKIP][104] ([i915#2994])
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb4/igt@sysfs_clients@sema-10.html

  * igt@sysfs_clients@sema-50:
    - shard-glk:          NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#2994]) +2 similar issues
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-glk8/igt@sysfs_clients@sema-50.html

  
#### Possible fixes ####

  * igt@gem_ctx_persistence@many-contexts:
    - shard-tglb:         [FAIL][106] ([i915#2410]) -> [PASS][107]
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-tglb6/igt@gem_ctx_persistence@many-contexts.html
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-tglb7/igt@gem_ctx_persistence@many-contexts.html

  * igt@gem_eio@unwedge-stress:
    - shard-iclb:         [TIMEOUT][108] ([i915#2369] / [i915#2481] / [i915#3070]) -> [PASS][109]
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-iclb3/igt@gem_eio@unwedge-stress.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb5/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-kbl:          [FAIL][110] ([i915#2846]) -> [PASS][111]
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl3/igt@gem_exec_fair@basic-deadline.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl6/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none-vip@rcs0:
    - shard-kbl:          [FAIL][112] ([i915#2842]) -> [PASS][113] +1 similar issue
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl7/igt@gem_exec_fair@basic-none-vip@rcs0.html
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl1/igt@gem_exec_fair@basic-none-vip@rcs0.html

  * igt@gem_exec_fair@basic-none@rcs0:
    - shard-glk:          [FAIL][114] ([i915#2842]) -> [PASS][115]
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-glk2/igt@gem_exec_fair@basic-none@rcs0.html
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-glk8/igt@gem_exec_fair@basic-none@rcs0.html

  * igt@gem_mmap_gtt@big-copy-xy:
    - shard-glk:          [FAIL][116] ([i915#307]) -> [PASS][117]
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-glk8/igt@gem_mmap_gtt@big-copy-xy.html
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-glk5/igt@gem_mmap_gtt@big-copy-xy.html

  * igt@gem_mmap_gtt@cpuset-medium-copy:
    - shard-iclb:         [FAIL][118] ([i915#307]) -> [PASS][119]
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-iclb6/igt@gem_mmap_gtt@cpuset-medium-copy.html
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb1/igt@gem_mmap_gtt@cpuset-medium-copy.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [DMESG-WARN][120] ([i915#180]) -> [PASS][121] +2 similar issues
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
    - shard-apl:          [DMESG-WARN][122] ([i915#180]) -> [PASS][123]
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-apl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-apl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html

  * igt@kms_psr@psr2_suspend:
    - shard-iclb:         [SKIP][124] ([fdo#109441]) -> [PASS][125] +2 similar issues
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-iclb6/igt@kms_psr@psr2_suspend.html
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb2/igt@kms_psr@psr2_suspend.html

  
#### Warnings ####

  * igt@i915_pm_dc@dc3co-vpb-simulation:
    - shard-iclb:         [SKIP][126] ([i915#658]) -> [SKIP][127] ([i915#588])
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-iclb8/igt@i915_pm_dc@dc3co-vpb-simulation.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html

  * igt@i915_pm_rc6_residency@rc6-fence:
    - shard-iclb:         [WARN][128] ([i915#1804] / [i915#2684]) -> [WARN][129] ([i915#2684])
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-iclb:         [WARN][130] ([i915#2684]) -> [WARN][131] ([i915#1804] / [i915#2684])
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb4/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
    - shard-iclb:         [SKIP][132] ([i915#658]) -> [SKIP][133] ([i915#2920]) +1 similar issue
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-iclb8/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
    - shard-iclb:         [SKIP][134] ([i915#2920]) -> [SKIP][135] ([i915#658]) +1 similar issue
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-iclb4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html

  * igt@runner@aborted:
    - shard-kbl:          ([FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142]) ([i915#180] / [i915#1814] / [i915#2292] / [i915#2505] / [i915#3002] / [i915#3363]) -> ([FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363] / [i915#602] / [i915#92])
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl7/igt@runner@aborted.html
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl7/igt@runner@aborted.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl6/igt@runner@aborted.html
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl6/igt@runner@aborted.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl2/igt@runner@aborted.html
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl2/igt@runner@aborted.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10253/shard-kbl3/igt@runner@aborted.html
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl7/igt@runner@aborted.html
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl7/igt@runner@aborted.html
   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl6/igt@runner@aborted.html
   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl6/igt@runner@aborted.html
   [147]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl6/igt@runner@aborted.html
   [148]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shard-kbl7/ig

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/index.html

[-- Attachment #1.2: Type: text/html, Size: 34235 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Hello Juha-Pekka,

Really sorry to bother you again. Kindly check this version please https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6

I tried pulling the crc start to the beginning and used current crc same way as kms_big_fb. Whatever I do, with regular white fb, I couldn’t get it working even once. I tried normal ARGB white fb too instead of XRGB but that too wont work. I created another gray fb with alpha like the other argb buffers and this seems to work. Both gray and white work. I have kept it gray for now.

Thank you so much.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Monday, June 21, 2021 7:03 PM
To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <Charlton.Lin@intel.com>
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

Hello Juha-Pekka,

Thank you so much. I tried pulling the crc start to the beginning and used current crc same way as kms_big_fb. Whatever I do, with regular white fb, I couldn’t get it working even once (it had worked the other day). I tried normal ARGB white fb too instead of XRGB but that too wont work. I created another gray fb with alpha like the other argb buffers and this seems to work. Both gray and white work. I have kept it gray for now.

Apologies for bothering you. Kindly have a check of this version and suggest please https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6

Regards
Vidya

-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Sent: Monday, June 21, 2021 1:35 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

That issue where solid white is also failing *sometimes* sound like there maybe two separate issues.

I'd suggest for experimenting try using solid white, move starting of crc counting at the very beginning of the test function and place wait for vblank always before reading crcs. If this will help then the same crc issue which was earlier on kms_big_fb test is also causing problem here.

/Juha-Pekka

On 19.6.2021 11.24, Srinivas, Vidya wrote:
> Hello Juha-Pekka,
> 
> Thank you so much. I tried the LUT table you suggested and it worked
> https://patchwork.freedesktop.org/patch/440145/?series=90828&rev=4
> Could you kindly check if it is right? 0.25 and 0.75 did not work. 1,1,1 too is failing once in a while.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Saturday, June 19, 2021 8:40 AM
> To: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>; 
> igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <Charlton.Lin@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> Thank you so much Juha-Pekka. I will try out the gamma thing you mentioned and update further.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>
> Sent: Saturday, June 19, 2021 1:54 AM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> Hi Vidya,
> 
> I don't now have access to specs so I can't say if there would be something special for JSL on this case. OTOH if changing gray buffer to solid white fixes that maybe good solution, I'm trying to think how the screen will be in this case and I assume test image will remain on screen(?). If just changing gray buffer to solid white make test pass there maybe also 0.25 gray and 0.75 gray which will work. It wouldn't be the first time there is found case with specific color which causes rounding error with crc where it's just more convenient to change that color.
> 
> I don't know can it be used in this case but there might be possibility to do gamma table trick if nothing else works. This is used in kms_plane and kms_flip_scaled_crc that come to my mind, in tests/kms_flip_scaled_crc.c look for set_lut(..) function and how it is used.
> 
> I'd avoid creating special cases for some hw versions, it will lead to big mess in the end.
> 
> /Juha-Pekka
> 
> Srinivas, Vidya kirjoitti 18.6.2021 klo 21.54:
>> Hello Juha-Pekka,
>>
>> As you said, I guess that might be the problem. But the changes of WA are already present in kernel. I tried reverting them just to check, but did not see any change.
>> If I change the gray buffer (0.5 to 1,1,1) it works. If I comment first primary commit it works. If I just comment "Pre-multiplied" it works, else lower alpha works.
>> Couldn’t find any other changes yet in driver. Would it be okay if I can add a patch to disable primary commit if JASPERLAKE?
>>
>> Thank you so much.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Srinivas, Vidya
>> Sent: Friday, June 18, 2021 4:01 PM
>> To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>> <Charlton.Lin@intel.com>
>> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
>> alpha in coverage-vs-premult-vs-constant
>>
>> Thank you so much Juha-Pekka. I will check on the same and update.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> Sent: Friday, June 18, 2021 3:56 PM
>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
>> igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>> <charlton.lin@intel.com>
>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
>> alpha in coverage-vs-premult-vs-constant
>>
>> Have you tried looking if on kernel side in intel_display.c
>> icl_set_pipe_chicken(..) those icl related WAs have effect on your crc problem. Sound like setting PER_PIXEL_ALPHA_BYPASS_EN and PIXEL_ROUNDING_TRUNC_FB_PASSTHRU touch exactly the problem you are seeing. Maybe different hw revision behave differently? Try see if there's on spec some note for your HW revision for these WAs.
>>
>> /Juha-Pekka
>>
>> On 18.6.2021 11.58, Srinivas, Vidya wrote:
>>> Thank you so much Juha-Pekka.
>>>
>>> https://patchwork.freedesktop.org/patch/436194/?series=90828&rev=2
>>> just removes the DRM_PLANE_TYPE_PRIMARY fb setting from subtest That works. Would that be an okay change?
>>>
>>> Because without the commit after PRIMARY and alpha value 0x7e, JSL is failing. If we just don’t do the PRIMARY fb setting at start, test works as is.
>>>
>>> Kindly suggest. Thank you very much once again.
>>>
>>> Regards
>>> Vidya
>>>
>>> -----Original Message-----
>>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>>> Sent: Friday, June 18, 2021 2:23 PM
>>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
>>> igt-dev@lists.freedesktop.org
>>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>>> <charlton.lin@intel.com>
>>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
>>> Fix alpha in coverage-vs-premult-vs-constant
>>>
>>> On 11.6.2021 15.44, Vidya Srinivas wrote:
>>>> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant 
>>>> as per the buffer being created initially in prepare_crtc. Patch 
>>>> also add commit after setting fb on primary plane. Without this 
>>>> change CRC mismatch is seen on few Gen11 systems.
>>>>
>>>> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>>>> ---
>>>>      tests/kms_plane_alpha_blend.c | 9 +++++++--
>>>>      1 file changed, 7 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/tests/kms_plane_alpha_blend.c 
>>>> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..d3a73cf43fcd
>>>> 100644
>>>> --- a/tests/kms_plane_alpha_blend.c
>>>> +++ b/tests/kms_plane_alpha_blend.c
>>>> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>>>>      	igt_crc_t ref_crc = {}, crc = {};
>>>>      
>>>>      	/* Set a background color on the primary fb for testing */
>>>> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
>>>> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>>>>      		
>>>> igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
>>>> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
>>>> +		igt_display_commit2(display, COMMIT_ATOMIC);
>>>
>>> Why this extra commit needed? There's just below commit before crc 
>>> is started
>>>
>>>> +	}
>>>>      
>>>>      	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>>>> "Coverage");
>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>
>>> On this test there's already per pixel alpha, setting plane alpha values so low will probably in this case in final rounding make these planes completely invisible. I'd suspect you can get any image pass crc doing it like this. Likely what you see on screen with these values is just pure grey instead of intended test image.
>>>
>>>
>>>>      	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>>      	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>      	igt_pipe_crc_start(data->pipe_crc);
>>>>      	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>>>>      
>>>>      	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>>>> "Pre-multiplied");
>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>      	igt_plane_set_fb(plane, &data->argb_fb_7e);
>>>>      	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>      	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>>      	igt_assert_crc_equal(&ref_crc, &crc);
>>>>      
>>>>      	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>>>> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>      	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>>      	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>      	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>>      	igt_assert_crc_equal(&ref_crc, &crc);
>>>>      
>>>>      	igt_pipe_crc_stop(data->pipe_crc);
>>>> +
>>>
>>> stray new line
>>>
>>>>      }
>>>>      
>>>>      static void run_test_on_pipe_planes(data_t *data, enum pipe 
>>>> pipe, bool blend,
>>>>
>>>
>>

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Juha-Pekka Heikkila]

Hei Vidya,

your overall test result did look green but it is because of some filter 
in ci which masked out new failures.

If you look at this you see the change did introduce new failures on 
test you're changing:

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shards-all.html?testfilter=kms_plane_alpha_blend@pipe-*.-coverage-vs-premult-vs-constant

Then I think there's problem on this (from 
https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6):

+		cr = igt_get_cairo_ctx(data->gfx_fd, &data->argb_gray_fb);
+		cairo_set_operator(cr, CAIRO_OPERATOR_SOURCE);
+		igt_paint_color_alpha(cr, 0, 0, w, h, .5, .5, .5, 0.0);
+		igt_put_cairo_ctx(cr);

you see on igt_paint_color_alpha(..), alpha value is zero. Is that meant 
to be? I think gray and white with this alpha will look the same as black.

Though, I'm still wondering why didn't masking bits away with gamma fix 
this. Did you see the screen it was looking ok when you tried using 
gamma table?

/Juha-Pekka

On 23.6.2021 8.21, Srinivas, Vidya wrote:
> Hello Juha-Pekka,
> 
> Really sorry to bother you again. Kindly check this version please https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6
> 
> I tried pulling the crc start to the beginning and used current crc same way as kms_big_fb. Whatever I do, with regular white fb, I couldn’t get it working even once. I tried normal ARGB white fb too instead of XRGB but that too wont work. I created another gray fb with alpha like the other argb buffers and this seems to work. Both gray and white work. I have kept it gray for now.
> 
> Thank you so much.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Monday, June 21, 2021 7:03 PM
> To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <Charlton.Lin@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant
> 
> Hello Juha-Pekka,
> 
> Thank you so much. I tried pulling the crc start to the beginning and used current crc same way as kms_big_fb. Whatever I do, with regular white fb, I couldn’t get it working even once (it had worked the other day). I tried normal ARGB white fb too instead of XRGB but that too wont work. I created another gray fb with alpha like the other argb buffers and this seems to work. Both gray and white work. I have kept it gray for now.
> 
> Apologies for bothering you. Kindly have a check of this version and suggest please https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Sent: Monday, June 21, 2021 1:35 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant
> 
> That issue where solid white is also failing *sometimes* sound like there maybe two separate issues.
> 
> I'd suggest for experimenting try using solid white, move starting of crc counting at the very beginning of the test function and place wait for vblank always before reading crcs. If this will help then the same crc issue which was earlier on kms_big_fb test is also causing problem here.
> 
> /Juha-Pekka
> 
> On 19.6.2021 11.24, Srinivas, Vidya wrote:
>> Hello Juha-Pekka,
>>
>> Thank you so much. I tried the LUT table you suggested and it worked
>> https://patchwork.freedesktop.org/patch/440145/?series=90828&rev=4
>> Could you kindly check if it is right? 0.25 and 0.75 did not work. 1,1,1 too is failing once in a while.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Srinivas, Vidya
>> Sent: Saturday, June 19, 2021 8:40 AM
>> To: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>;
>> igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton
>> <Charlton.Lin@intel.com>
>> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix
>> alpha in coverage-vs-premult-vs-constant
>>
>> Thank you so much Juha-Pekka. I will try out the gamma thing you mentioned and update further.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>
>> Sent: Saturday, June 19, 2021 1:54 AM
>> To: Srinivas, Vidya <vidya.srinivas@intel.com>;
>> igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton
>> <charlton.lin@intel.com>
>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix
>> alpha in coverage-vs-premult-vs-constant
>>
>> Hi Vidya,
>>
>> I don't now have access to specs so I can't say if there would be something special for JSL on this case. OTOH if changing gray buffer to solid white fixes that maybe good solution, I'm trying to think how the screen will be in this case and I assume test image will remain on screen(?). If just changing gray buffer to solid white make test pass there maybe also 0.25 gray and 0.75 gray which will work. It wouldn't be the first time there is found case with specific color which causes rounding error with crc where it's just more convenient to change that color.
>>
>> I don't know can it be used in this case but there might be possibility to do gamma table trick if nothing else works. This is used in kms_plane and kms_flip_scaled_crc that come to my mind, in tests/kms_flip_scaled_crc.c look for set_lut(..) function and how it is used.
>>
>> I'd avoid creating special cases for some hw versions, it will lead to big mess in the end.
>>
>> /Juha-Pekka
>>
>> Srinivas, Vidya kirjoitti 18.6.2021 klo 21.54:
>>> Hello Juha-Pekka,
>>>
>>> As you said, I guess that might be the problem. But the changes of WA are already present in kernel. I tried reverting them just to check, but did not see any change.
>>> If I change the gray buffer (0.5 to 1,1,1) it works. If I comment first primary commit it works. If I just comment "Pre-multiplied" it works, else lower alpha works.
>>> Couldn’t find any other changes yet in driver. Would it be okay if I can add a patch to disable primary commit if JASPERLAKE?
>>>
>>> Thank you so much.
>>>
>>> Regards
>>> Vidya
>>>
>>> -----Original Message-----
>>> From: Srinivas, Vidya
>>> Sent: Friday, June 18, 2021 4:01 PM
>>> To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
>>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton
>>> <Charlton.Lin@intel.com>
>>> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix
>>> alpha in coverage-vs-premult-vs-constant
>>>
>>> Thank you so much Juha-Pekka. I will check on the same and update.
>>>
>>> Regards
>>> Vidya
>>>
>>> -----Original Message-----
>>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>>> Sent: Friday, June 18, 2021 3:56 PM
>>> To: Srinivas, Vidya <vidya.srinivas@intel.com>;
>>> igt-dev@lists.freedesktop.org
>>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton
>>> <charlton.lin@intel.com>
>>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix
>>> alpha in coverage-vs-premult-vs-constant
>>>
>>> Have you tried looking if on kernel side in intel_display.c
>>> icl_set_pipe_chicken(..) those icl related WAs have effect on your crc problem. Sound like setting PER_PIXEL_ALPHA_BYPASS_EN and PIXEL_ROUNDING_TRUNC_FB_PASSTHRU touch exactly the problem you are seeing. Maybe different hw revision behave differently? Try see if there's on spec some note for your HW revision for these WAs.
>>>
>>> /Juha-Pekka
>>>
>>> On 18.6.2021 11.58, Srinivas, Vidya wrote:
>>>> Thank you so much Juha-Pekka.
>>>>
>>>> https://patchwork.freedesktop.org/patch/436194/?series=90828&rev=2
>>>> just removes the DRM_PLANE_TYPE_PRIMARY fb setting from subtest That works. Would that be an okay change?
>>>>
>>>> Because without the commit after PRIMARY and alpha value 0x7e, JSL is failing. If we just don’t do the PRIMARY fb setting at start, test works as is.
>>>>
>>>> Kindly suggest. Thank you very much once again.
>>>>
>>>> Regards
>>>> Vidya
>>>>
>>>> -----Original Message-----
>>>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>>>> Sent: Friday, June 18, 2021 2:23 PM
>>>> To: Srinivas, Vidya <vidya.srinivas@intel.com>;
>>>> igt-dev@lists.freedesktop.org
>>>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton
>>>> <charlton.lin@intel.com>
>>>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
>>>> Fix alpha in coverage-vs-premult-vs-constant
>>>>
>>>> On 11.6.2021 15.44, Vidya Srinivas wrote:
>>>>> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant
>>>>> as per the buffer being created initially in prepare_crtc. Patch
>>>>> also add commit after setting fb on primary plane. Without this
>>>>> change CRC mismatch is seen on few Gen11 systems.
>>>>>
>>>>> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>>>>> ---
>>>>>       tests/kms_plane_alpha_blend.c | 9 +++++++--
>>>>>       1 file changed, 7 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/tests/kms_plane_alpha_blend.c
>>>>> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..d3a73cf43fcd
>>>>> 100644
>>>>> --- a/tests/kms_plane_alpha_blend.c
>>>>> +++ b/tests/kms_plane_alpha_blend.c
>>>>> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>>>>>       	igt_crc_t ref_crc = {}, crc = {};
>>>>>       
>>>>>       	/* Set a background color on the primary fb for testing */
>>>>> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
>>>>> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>>>>>       		
>>>>> igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
>>>>> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
>>>>> +		igt_display_commit2(display, COMMIT_ATOMIC);
>>>>
>>>> Why this extra commit needed? There's just below commit before crc
>>>> is started
>>>>
>>>>> +	}
>>>>>       
>>>>>       	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
>>>>> "Coverage");
>>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>
>>>> On this test there's already per pixel alpha, setting plane alpha values so low will probably in this case in final rounding make these planes completely invisible. I'd suspect you can get any image pass crc doing it like this. Likely what you see on screen with these values is just pure grey instead of intended test image.
>>>>
>>>>
>>>>>       	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>>>       	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>>       	igt_pipe_crc_start(data->pipe_crc);
>>>>>       	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>>>>>       
>>>>>       	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
>>>>> "Pre-multiplied");
>>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>>       	igt_plane_set_fb(plane, &data->argb_fb_7e);
>>>>>       	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>>       	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>>>       	igt_assert_crc_equal(&ref_crc, &crc);
>>>>>       
>>>>>       	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>>>>> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>>       	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>>>       	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>>       	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>>>       	igt_assert_crc_equal(&ref_crc, &crc);
>>>>>       
>>>>>       	igt_pipe_crc_stop(data->pipe_crc);
>>>>> +
>>>>
>>>> stray new line
>>>>
>>>>>       }
>>>>>       
>>>>>       static void run_test_on_pipe_planes(data_t *data, enum pipe
>>>>> pipe, bool blend,
>>>>>
>>>>
>>>
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Hello Juha-Pekka,

Thank you so much.

Yeah, only alpha value 0 is working in the alpha_gray_fb. But screen is showing for other plane tests also.

If I use black_fb itself instead of gray_fb directly in coverage-vs-premult-vs-constant, it works. But due to black, screen doesn’t show for other planes. It shows black after Testing plane 0. CRC passes.

If I use set_lut, screen looks fine (I commented crc assertion to see). But CRC mismatch shows up.
In the same LUT table, again lut[i].red =0, lut[i].green = 0 and lut[i].blue=0 also CRC passes. Again, for other planes screen shows black.

Regards
Vidya

-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> 
Sent: Wednesday, June 23, 2021 1:12 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

Hei Vidya,

your overall test result did look green but it is because of some filter in ci which masked out new failures.

If you look at this you see the change did introduce new failures on test you're changing:

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shards-all.html?testfilter=kms_plane_alpha_blend@pipe-*.-coverage-vs-premult-vs-constant

Then I think there's problem on this (from
https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6):

+		cr = igt_get_cairo_ctx(data->gfx_fd, &data->argb_gray_fb);
+		cairo_set_operator(cr, CAIRO_OPERATOR_SOURCE);
+		igt_paint_color_alpha(cr, 0, 0, w, h, .5, .5, .5, 0.0);
+		igt_put_cairo_ctx(cr);

you see on igt_paint_color_alpha(..), alpha value is zero. Is that meant to be? I think gray and white with this alpha will look the same as black.

Though, I'm still wondering why didn't masking bits away with gamma fix this. Did you see the screen it was looking ok when you tried using gamma table?

/Juha-Pekka

On 23.6.2021 8.21, Srinivas, Vidya wrote:
> Hello Juha-Pekka,
> 
> Really sorry to bother you again. Kindly check this version please 
> https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6
> 
> I tried pulling the crc start to the beginning and used current crc same way as kms_big_fb. Whatever I do, with regular white fb, I couldn’t get it working even once. I tried normal ARGB white fb too instead of XRGB but that too wont work. I created another gray fb with alpha like the other argb buffers and this seems to work. Both gray and white work. I have kept it gray for now.
> 
> Thank you so much.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Monday, June 21, 2021 7:03 PM
> To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <Charlton.Lin@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> Hello Juha-Pekka,
> 
> Thank you so much. I tried pulling the crc start to the beginning and used current crc same way as kms_big_fb. Whatever I do, with regular white fb, I couldn’t get it working even once (it had worked the other day). I tried normal ARGB white fb too instead of XRGB but that too wont work. I created another gray fb with alpha like the other argb buffers and this seems to work. Both gray and white work. I have kept it gray for now.
> 
> Apologies for bothering you. Kindly have a check of this version and 
> suggest please 
> https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Sent: Monday, June 21, 2021 1:35 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> That issue where solid white is also failing *sometimes* sound like there maybe two separate issues.
> 
> I'd suggest for experimenting try using solid white, move starting of crc counting at the very beginning of the test function and place wait for vblank always before reading crcs. If this will help then the same crc issue which was earlier on kms_big_fb test is also causing problem here.
> 
> /Juha-Pekka
> 
> On 19.6.2021 11.24, Srinivas, Vidya wrote:
>> Hello Juha-Pekka,
>>
>> Thank you so much. I tried the LUT table you suggested and it worked
>> https://patchwork.freedesktop.org/patch/440145/?series=90828&rev=4
>> Could you kindly check if it is right? 0.25 and 0.75 did not work. 1,1,1 too is failing once in a while.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Srinivas, Vidya
>> Sent: Saturday, June 19, 2021 8:40 AM
>> To: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>; 
>> igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>> <Charlton.Lin@intel.com>
>> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
>> alpha in coverage-vs-premult-vs-constant
>>
>> Thank you so much Juha-Pekka. I will try out the gamma thing you mentioned and update further.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>
>> Sent: Saturday, June 19, 2021 1:54 AM
>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
>> igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>> <charlton.lin@intel.com>
>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
>> alpha in coverage-vs-premult-vs-constant
>>
>> Hi Vidya,
>>
>> I don't now have access to specs so I can't say if there would be something special for JSL on this case. OTOH if changing gray buffer to solid white fixes that maybe good solution, I'm trying to think how the screen will be in this case and I assume test image will remain on screen(?). If just changing gray buffer to solid white make test pass there maybe also 0.25 gray and 0.75 gray which will work. It wouldn't be the first time there is found case with specific color which causes rounding error with crc where it's just more convenient to change that color.
>>
>> I don't know can it be used in this case but there might be possibility to do gamma table trick if nothing else works. This is used in kms_plane and kms_flip_scaled_crc that come to my mind, in tests/kms_flip_scaled_crc.c look for set_lut(..) function and how it is used.
>>
>> I'd avoid creating special cases for some hw versions, it will lead to big mess in the end.
>>
>> /Juha-Pekka
>>
>> Srinivas, Vidya kirjoitti 18.6.2021 klo 21.54:
>>> Hello Juha-Pekka,
>>>
>>> As you said, I guess that might be the problem. But the changes of WA are already present in kernel. I tried reverting them just to check, but did not see any change.
>>> If I change the gray buffer (0.5 to 1,1,1) it works. If I comment first primary commit it works. If I just comment "Pre-multiplied" it works, else lower alpha works.
>>> Couldn’t find any other changes yet in driver. Would it be okay if I can add a patch to disable primary commit if JASPERLAKE?
>>>
>>> Thank you so much.
>>>
>>> Regards
>>> Vidya
>>>
>>> -----Original Message-----
>>> From: Srinivas, Vidya
>>> Sent: Friday, June 18, 2021 4:01 PM
>>> To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
>>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>>> <Charlton.Lin@intel.com>
>>> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
>>> Fix alpha in coverage-vs-premult-vs-constant
>>>
>>> Thank you so much Juha-Pekka. I will check on the same and update.
>>>
>>> Regards
>>> Vidya
>>>
>>> -----Original Message-----
>>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>>> Sent: Friday, June 18, 2021 3:56 PM
>>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
>>> igt-dev@lists.freedesktop.org
>>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>>> <charlton.lin@intel.com>
>>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
>>> Fix alpha in coverage-vs-premult-vs-constant
>>>
>>> Have you tried looking if on kernel side in intel_display.c
>>> icl_set_pipe_chicken(..) those icl related WAs have effect on your crc problem. Sound like setting PER_PIXEL_ALPHA_BYPASS_EN and PIXEL_ROUNDING_TRUNC_FB_PASSTHRU touch exactly the problem you are seeing. Maybe different hw revision behave differently? Try see if there's on spec some note for your HW revision for these WAs.
>>>
>>> /Juha-Pekka
>>>
>>> On 18.6.2021 11.58, Srinivas, Vidya wrote:
>>>> Thank you so much Juha-Pekka.
>>>>
>>>> https://patchwork.freedesktop.org/patch/436194/?series=90828&rev=2
>>>> just removes the DRM_PLANE_TYPE_PRIMARY fb setting from subtest That works. Would that be an okay change?
>>>>
>>>> Because without the commit after PRIMARY and alpha value 0x7e, JSL is failing. If we just don’t do the PRIMARY fb setting at start, test works as is.
>>>>
>>>> Kindly suggest. Thank you very much once again.
>>>>
>>>> Regards
>>>> Vidya
>>>>
>>>> -----Original Message-----
>>>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>>>> Sent: Friday, June 18, 2021 2:23 PM
>>>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
>>>> igt-dev@lists.freedesktop.org
>>>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>>>> <charlton.lin@intel.com>
>>>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
>>>> Fix alpha in coverage-vs-premult-vs-constant
>>>>
>>>> On 11.6.2021 15.44, Vidya Srinivas wrote:
>>>>> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant 
>>>>> as per the buffer being created initially in prepare_crtc. Patch 
>>>>> also add commit after setting fb on primary plane. Without this 
>>>>> change CRC mismatch is seen on few Gen11 systems.
>>>>>
>>>>> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>>>>> ---
>>>>>       tests/kms_plane_alpha_blend.c | 9 +++++++--
>>>>>       1 file changed, 7 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/tests/kms_plane_alpha_blend.c 
>>>>> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..d3a73cf43fcd
>>>>> 100644
>>>>> --- a/tests/kms_plane_alpha_blend.c
>>>>> +++ b/tests/kms_plane_alpha_blend.c
>>>>> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>>>>>       	igt_crc_t ref_crc = {}, crc = {};
>>>>>       
>>>>>       	/* Set a background color on the primary fb for testing */
>>>>> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
>>>>> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>>>>>       		
>>>>> igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
>>>>> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
>>>>> +		igt_display_commit2(display, COMMIT_ATOMIC);
>>>>
>>>> Why this extra commit needed? There's just below commit before crc 
>>>> is started
>>>>
>>>>> +	}
>>>>>       
>>>>>       	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>>>>> "Coverage");
>>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>
>>>> On this test there's already per pixel alpha, setting plane alpha values so low will probably in this case in final rounding make these planes completely invisible. I'd suspect you can get any image pass crc doing it like this. Likely what you see on screen with these values is just pure grey instead of intended test image.
>>>>
>>>>
>>>>>       	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>>>       	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>>       	igt_pipe_crc_start(data->pipe_crc);
>>>>>       	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>>>>>       
>>>>>       	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>>>>> "Pre-multiplied");
>>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>>       	igt_plane_set_fb(plane, &data->argb_fb_7e);
>>>>>       	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>>       	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>>>       	igt_assert_crc_equal(&ref_crc, &crc);
>>>>>       
>>>>>       	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>>>>> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>>       	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>>>       	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>>       	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>>>       	igt_assert_crc_equal(&ref_crc, &crc);
>>>>>       
>>>>>       	igt_pipe_crc_stop(data->pipe_crc);
>>>>> +
>>>>
>>>> stray new line
>>>>
>>>>>       }
>>>>>       
>>>>>       static void run_test_on_pipe_planes(data_t *data, enum pipe 
>>>>> pipe, bool blend,
>>>>>
>>>>
>>>
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

[Srinivas, Vidya]

Hello Juha-Pekka,

Once again, sorry for bothering you.
Should I re-run the test again on CI? Is this solution okay? https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6

Or should we simply skip this test for JSL? For that, one patch I need to create.

But positive hope is to get the test PASS than skipping. Kindly suggest. Thank you so much.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Wednesday, June 23, 2021 3:51 PM
To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <Charlton.Lin@intel.com>
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

Hello Juha-Pekka,

Thank you so much.

Yeah, only alpha value 0 is working in the alpha_gray_fb. But screen is showing for other plane tests also.

If I use black_fb itself instead of gray_fb directly in coverage-vs-premult-vs-constant, it works. But due to black, screen doesn’t show for other planes. It shows black after Testing plane 0. CRC passes.

If I use set_lut, screen looks fine (I commented crc assertion to see). But CRC mismatch shows up.
In the same LUT table, again lut[i].red =0, lut[i].green = 0 and lut[i].blue=0 also CRC passes. Again, for other planes screen shows black.

Regards
Vidya

-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Sent: Wednesday, June 23, 2021 1:12 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix alpha in coverage-vs-premult-vs-constant

Hei Vidya,

your overall test result did look green but it is because of some filter in ci which masked out new failures.

If you look at this you see the change did introduce new failures on test you're changing:

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5948/shards-all.html?testfilter=kms_plane_alpha_blend@pipe-*.-coverage-vs-premult-vs-constant

Then I think there's problem on this (from
https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6):

+		cr = igt_get_cairo_ctx(data->gfx_fd, &data->argb_gray_fb);
+		cairo_set_operator(cr, CAIRO_OPERATOR_SOURCE);
+		igt_paint_color_alpha(cr, 0, 0, w, h, .5, .5, .5, 0.0);
+		igt_put_cairo_ctx(cr);

you see on igt_paint_color_alpha(..), alpha value is zero. Is that meant to be? I think gray and white with this alpha will look the same as black.

Though, I'm still wondering why didn't masking bits away with gamma fix this. Did you see the screen it was looking ok when you tried using gamma table?

/Juha-Pekka

On 23.6.2021 8.21, Srinivas, Vidya wrote:
> Hello Juha-Pekka,
> 
> Really sorry to bother you again. Kindly check this version please
> https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6
> 
> I tried pulling the crc start to the beginning and used current crc same way as kms_big_fb. Whatever I do, with regular white fb, I couldn’t get it working even once. I tried normal ARGB white fb too instead of XRGB but that too wont work. I created another gray fb with alpha like the other argb buffers and this seems to work. Both gray and white work. I have kept it gray for now.
> 
> Thank you so much.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Monday, June 21, 2021 7:03 PM
> To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <Charlton.Lin@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> Hello Juha-Pekka,
> 
> Thank you so much. I tried pulling the crc start to the beginning and used current crc same way as kms_big_fb. Whatever I do, with regular white fb, I couldn’t get it working even once (it had worked the other day). I tried normal ARGB white fb too instead of XRGB but that too wont work. I created another gray fb with alpha like the other argb buffers and this seems to work. Both gray and white work. I have kept it gray for now.
> 
> Apologies for bothering you. Kindly have a check of this version and 
> suggest please
> https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Sent: Monday, June 21, 2021 1:35 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> igt-dev@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
> <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
> alpha in coverage-vs-premult-vs-constant
> 
> That issue where solid white is also failing *sometimes* sound like there maybe two separate issues.
> 
> I'd suggest for experimenting try using solid white, move starting of crc counting at the very beginning of the test function and place wait for vblank always before reading crcs. If this will help then the same crc issue which was earlier on kms_big_fb test is also causing problem here.
> 
> /Juha-Pekka
> 
> On 19.6.2021 11.24, Srinivas, Vidya wrote:
>> Hello Juha-Pekka,
>>
>> Thank you so much. I tried the LUT table you suggested and it worked
>> https://patchwork.freedesktop.org/patch/440145/?series=90828&rev=4
>> Could you kindly check if it is right? 0.25 and 0.75 did not work. 1,1,1 too is failing once in a while.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Srinivas, Vidya
>> Sent: Saturday, June 19, 2021 8:40 AM
>> To: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>; 
>> igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>> <Charlton.Lin@intel.com>
>> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
>> alpha in coverage-vs-premult-vs-constant
>>
>> Thank you so much Juha-Pekka. I will try out the gamma thing you mentioned and update further.
>>
>> Regards
>> Vidya
>>
>> -----Original Message-----
>> From: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>
>> Sent: Saturday, June 19, 2021 1:54 AM
>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
>> igt-dev@lists.freedesktop.org
>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>> <charlton.lin@intel.com>
>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix 
>> alpha in coverage-vs-premult-vs-constant
>>
>> Hi Vidya,
>>
>> I don't now have access to specs so I can't say if there would be something special for JSL on this case. OTOH if changing gray buffer to solid white fixes that maybe good solution, I'm trying to think how the screen will be in this case and I assume test image will remain on screen(?). If just changing gray buffer to solid white make test pass there maybe also 0.25 gray and 0.75 gray which will work. It wouldn't be the first time there is found case with specific color which causes rounding error with crc where it's just more convenient to change that color.
>>
>> I don't know can it be used in this case but there might be possibility to do gamma table trick if nothing else works. This is used in kms_plane and kms_flip_scaled_crc that come to my mind, in tests/kms_flip_scaled_crc.c look for set_lut(..) function and how it is used.
>>
>> I'd avoid creating special cases for some hw versions, it will lead to big mess in the end.
>>
>> /Juha-Pekka
>>
>> Srinivas, Vidya kirjoitti 18.6.2021 klo 21.54:
>>> Hello Juha-Pekka,
>>>
>>> As you said, I guess that might be the problem. But the changes of WA are already present in kernel. I tried reverting them just to check, but did not see any change.
>>> If I change the gray buffer (0.5 to 1,1,1) it works. If I comment first primary commit it works. If I just comment "Pre-multiplied" it works, else lower alpha works.
>>> Couldn’t find any other changes yet in driver. Would it be okay if I can add a patch to disable primary commit if JASPERLAKE?
>>>
>>> Thank you so much.
>>>
>>> Regards
>>> Vidya
>>>
>>> -----Original Message-----
>>> From: Srinivas, Vidya
>>> Sent: Friday, June 18, 2021 4:01 PM
>>> To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
>>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>>> <Charlton.Lin@intel.com>
>>> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
>>> Fix alpha in coverage-vs-premult-vs-constant
>>>
>>> Thank you so much Juha-Pekka. I will check on the same and update.
>>>
>>> Regards
>>> Vidya
>>>
>>> -----Original Message-----
>>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>>> Sent: Friday, June 18, 2021 3:56 PM
>>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
>>> igt-dev@lists.freedesktop.org
>>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>>> <charlton.lin@intel.com>
>>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
>>> Fix alpha in coverage-vs-premult-vs-constant
>>>
>>> Have you tried looking if on kernel side in intel_display.c
>>> icl_set_pipe_chicken(..) those icl related WAs have effect on your crc problem. Sound like setting PER_PIXEL_ALPHA_BYPASS_EN and PIXEL_ROUNDING_TRUNC_FB_PASSTHRU touch exactly the problem you are seeing. Maybe different hw revision behave differently? Try see if there's on spec some note for your HW revision for these WAs.
>>>
>>> /Juha-Pekka
>>>
>>> On 18.6.2021 11.58, Srinivas, Vidya wrote:
>>>> Thank you so much Juha-Pekka.
>>>>
>>>> https://patchwork.freedesktop.org/patch/436194/?series=90828&rev=2
>>>> just removes the DRM_PLANE_TYPE_PRIMARY fb setting from subtest That works. Would that be an okay change?
>>>>
>>>> Because without the commit after PRIMARY and alpha value 0x7e, JSL is failing. If we just don’t do the PRIMARY fb setting at start, test works as is.
>>>>
>>>> Kindly suggest. Thank you very much once again.
>>>>
>>>> Regards
>>>> Vidya
>>>>
>>>> -----Original Message-----
>>>> From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>>>> Sent: Friday, June 18, 2021 2:23 PM
>>>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
>>>> igt-dev@lists.freedesktop.org
>>>> Cc: Latvala, Petri <petri.latvala@intel.com>; Lin, Charlton 
>>>> <charlton.lin@intel.com>
>>>> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
>>>> Fix alpha in coverage-vs-premult-vs-constant
>>>>
>>>> On 11.6.2021 15.44, Vidya Srinivas wrote:
>>>>> Patch sets alpha to 0x7e for coverage, Pre-multiplied and constant 
>>>>> as per the buffer being created initially in prepare_crtc. Patch 
>>>>> also add commit after setting fb on primary plane. Without this 
>>>>> change CRC mismatch is seen on few Gen11 systems.
>>>>>
>>>>> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>>>>> ---
>>>>>       tests/kms_plane_alpha_blend.c | 9 +++++++--
>>>>>       1 file changed, 7 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/tests/kms_plane_alpha_blend.c 
>>>>> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..d3a73cf43fcd
>>>>> 100644
>>>>> --- a/tests/kms_plane_alpha_blend.c
>>>>> +++ b/tests/kms_plane_alpha_blend.c
>>>>> @@ -448,29 +448,34 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>>>>>       	igt_crc_t ref_crc = {}, crc = {};
>>>>>       
>>>>>       	/* Set a background color on the primary fb for testing */
>>>>> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
>>>>> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>>>>>       		
>>>>> igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
>>>>> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
>>>>> +		igt_display_commit2(display, COMMIT_ATOMIC);
>>>>
>>>> Why this extra commit needed? There's just below commit before crc 
>>>> is started
>>>>
>>>>> +	}
>>>>>       
>>>>>       	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>>>>> "Coverage");
>>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>
>>>> On this test there's already per pixel alpha, setting plane alpha values so low will probably in this case in final rounding make these planes completely invisible. I'd suspect you can get any image pass crc doing it like this. Likely what you see on screen with these values is just pure grey instead of intended test image.
>>>>
>>>>
>>>>>       	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>>>       	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>>       	igt_pipe_crc_start(data->pipe_crc);
>>>>>       	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
>>>>>       
>>>>>       	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
>>>>> "Pre-multiplied");
>>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>>       	igt_plane_set_fb(plane, &data->argb_fb_7e);
>>>>>       	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>>       	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>>>       	igt_assert_crc_equal(&ref_crc, &crc);
>>>>>       
>>>>>       	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>>>>> -	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>>>>> +	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e);
>>>>>       	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>>>>>       	igt_display_commit2(display, COMMIT_ATOMIC);
>>>>>       	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
>>>>>       	igt_assert_crc_equal(&ref_crc, &crc);
>>>>>       
>>>>>       	igt_pipe_crc_stop(data->pipe_crc);
>>>>> +
>>>>
>>>> stray new line
>>>>
>>>>>       }
>>>>>       
>>>>>       static void run_test_on_pipe_planes(data_t *data, enum pipe 
>>>>> pipe, bool blend,
>>>>>
>>>>
>>>
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Use black for primary plane for coverage-vs-premult-vs-constant

[Vidya Srinivas]

Few Gen11 systems report CRC mismatch with primaryy gray fb.
Use black for primary plane in coverage-vs-premult-vs-constant
to get the CRC pass.

Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..f02e50157873 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -449,7 +449,7 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 
 	/* Set a background color on the primary fb for testing */
 	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
-		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
+		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->black_fb);
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev7)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 3481 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev7)
URL   : https://patchwork.freedesktop.org/series/90828/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10285 -> IGTPW_5965
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_5965 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_5965, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5965/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_5965:

### IGT changes ###

#### Possible regressions ####

  * igt@dmabuf@all@dma_fence:
    - fi-hsw-4770:        [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/fi-hsw-4770/igt@dmabuf@all@dma_fence.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5965/fi-hsw-4770/igt@dmabuf@all@dma_fence.html

  
Known issues
------------

  Here are the changes found in IGTPW_5965 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_cs_nop@sync-fork-compute0:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][3] ([fdo#109271]) +6 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5965/fi-kbl-soraka/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html

  * igt@i915_pm_rpm@module-reload:
    - fi-kbl-guc:         [PASS][4] -> [FAIL][5] ([i915#2203] / [i915#579])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5965/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html

  * igt@i915_selftest@live@execlists:
    - fi-bsw-kefka:       [PASS][6] -> [INCOMPLETE][7] ([i915#2782] / [i915#2940])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10285/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5965/fi-bsw-kefka/igt@i915_selftest@live@execlists.html

  * igt@runner@aborted:
    - fi-bsw-kefka:       NOTRUN -> [FAIL][8] ([fdo#109271] / [i915#1436])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5965/fi-bsw-kefka/igt@runner@aborted.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
  [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
  [i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
  [i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579


Participating hosts (40 -> 37)
------------------------------

  Missing    (3): fi-bsw-cyan fi-bdw-samus fi-hsw-4200u 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6121 -> IGTPW_5965

  CI-20190529: 20190529
  CI_DRM_10285: e65a658751fc5d3be5b0f4bcc4731e66ca1a537a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_5965: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5965/index.html
  IGT_6121: a63ceb48e6c3e733d04156b32fba3b4f4d5ad794 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5965/index.html

[-- Attachment #1.2: Type: text/html, Size: 4258 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Dont commit primary for 6bpc display in coverage-vs-premult-vs-none

[Vidya Srinivas]

Intel Gen11 6bpc panels are giving CRC mismatch in coverage-vs-premult-vs-none
if primary gray fb is commited before starting alpha tests. Patch removes primar plane
commit if device is intel and 6bpc.

Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 36 ++++++++++++++++++++++++++++++++++--
 1 file changed, 34 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..5f0a8cb070dd 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -25,6 +25,7 @@
  */
 
 #include "igt.h"
+#include <string.h>
 
 IGT_TEST_DESCRIPTION("Test plane alpha and blending mode properties");
 
@@ -442,14 +443,45 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
 	igt_pipe_crc_stop(data->pipe_crc);
 }
 
+static bool is_6bpc(igt_display_t *display)
+{
+	char buf[4096];
+	char *str;
+	bool ret;
+	int debugfs_fd;
+
+	if (!is_i915_device(display->drm_fd))
+		return false;
+
+	debugfs_fd = igt_debugfs_dir(display->drm_fd);
+
+	if (debugfs_fd < 0)
+		return false;
+
+	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf, sizeof(buf));
+
+	str = strstr(buf, "bpp=");
+	if (strncmp(str, "bpp=18", 6) == 0)
+		ret = true;
+	else
+		ret = false;
+
+	close(debugfs_fd);
+	return ret;
+}
+
 static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)
 {
 	igt_display_t *display = &data->display;
 	igt_crc_t ref_crc = {}, crc = {};
 
+
 	/* Set a background color on the primary fb for testing */
-	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
-		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
+	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
+		if (!is_6bpc(display))
+			igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
+						DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
+	}
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev8)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 2974 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev8)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10304 -> IGTPW_5978
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/index.html

Known issues
------------

  Here are the changes found in IGTPW_5978 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@execlists:
    - fi-bsw-kefka:       [PASS][1] -> [INCOMPLETE][2] ([i915#2782] / [i915#2940])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/fi-bsw-kefka/igt@i915_selftest@live@execlists.html

  * igt@runner@aborted:
    - fi-bsw-kefka:       NOTRUN -> [FAIL][3] ([fdo#109271] / [i915#1436])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/fi-bsw-kefka/igt@runner@aborted.html
    - fi-bdw-5557u:       NOTRUN -> [FAIL][4] ([i915#1602] / [i915#2029])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/fi-bdw-5557u/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-kbl-7500u:       [FAIL][5] ([i915#3449]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
  [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
  [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
  [i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
  [i915#3449]: https://gitlab.freedesktop.org/drm/intel/issues/3449
  [i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541


Participating hosts (36 -> 35)
------------------------------

  Missing    (1): fi-bsw-cyan 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6128 -> IGTPW_5978

  CI-20190529: 20190529
  CI_DRM_10304: 3d3b5479895dd6dd133571ded4318adf595708ba @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_5978: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/index.html
  IGT_6128: b24e5949af7e51f0af484d2ce4cb4c5a41ac5358 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/index.html

[-- Attachment #1.2: Type: text/html, Size: 3577 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev8)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 30295 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev8)
URL   : https://patchwork.freedesktop.org/series/90828/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10304_full -> IGTPW_5978_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_5978_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_5978_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_5978_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_plane_alpha_blend@pipe-d-coverage-vs-premult-vs-constant:
    - shard-tglb:         [PASS][1] -> [CRASH][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-tglb5/igt@kms_plane_alpha_blend@pipe-d-coverage-vs-premult-vs-constant.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb6/igt@kms_plane_alpha_blend@pipe-d-coverage-vs-premult-vs-constant.html

  
Known issues
------------

  Here are the changes found in IGTPW_5978_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_create@create-clear:
    - shard-glk:          [PASS][3] -> [FAIL][4] ([i915#1888] / [i915#3160])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-glk5/igt@gem_create@create-clear.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-glk5/igt@gem_create@create-clear.html

  * igt@gem_ctx_persistence@engines-persistence:
    - shard-snb:          NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-snb7/igt@gem_ctx_persistence@engines-persistence.html

  * igt@gem_eio@unwedge-stress:
    - shard-iclb:         [PASS][6] -> [TIMEOUT][7] ([i915#2369] / [i915#2481] / [i915#3070])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-iclb7/igt@gem_eio@unwedge-stress.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb1/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-kbl:          NOTRUN -> [FAIL][8] ([i915#2846])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl1/igt@gem_exec_fair@basic-deadline.html
    - shard-apl:          NOTRUN -> [FAIL][9] ([i915#2846])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl1/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-flow@rcs0:
    - shard-tglb:         [PASS][10] -> [FAIL][11] ([i915#2842]) +2 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html

  * igt@gem_exec_fair@basic-none-rrul@rcs0:
    - shard-glk:          [PASS][12] -> [FAIL][13] ([i915#2842]) +1 similar issue
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-glk5/igt@gem_exec_fair@basic-none-rrul@rcs0.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-glk6/igt@gem_exec_fair@basic-none-rrul@rcs0.html
    - shard-kbl:          [PASS][14] -> [FAIL][15] ([i915#2842])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-kbl1/igt@gem_exec_fair@basic-none-rrul@rcs0.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl6/igt@gem_exec_fair@basic-none-rrul@rcs0.html

  * igt@gem_exec_fair@basic-none@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][16] ([i915#2842])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb2/igt@gem_exec_fair@basic-none@vcs1.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-glk:          NOTRUN -> [FAIL][17] ([i915#2842])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_fair@basic-pace@vcs1:
    - shard-kbl:          [PASS][18] -> [SKIP][19] ([fdo#109271]) +1 similar issue
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-kbl2/igt@gem_exec_fair@basic-pace@vcs1.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html

  * igt@gem_exec_params@secure-non-master:
    - shard-tglb:         NOTRUN -> [SKIP][20] ([fdo#112283])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb7/igt@gem_exec_params@secure-non-master.html
    - shard-iclb:         NOTRUN -> [SKIP][21] ([fdo#112283])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb1/igt@gem_exec_params@secure-non-master.html

  * igt@gem_mmap_gtt@cpuset-big-copy:
    - shard-iclb:         [PASS][22] -> [FAIL][23] ([i915#307])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-iclb3/igt@gem_mmap_gtt@cpuset-big-copy.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb7/igt@gem_mmap_gtt@cpuset-big-copy.html

  * igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-yf-tiled:
    - shard-iclb:         NOTRUN -> [SKIP][24] ([i915#768])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb2/igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-yf-tiled.html

  * igt@gem_vm_create@destroy-race:
    - shard-tglb:         [PASS][25] -> [INCOMPLETE][26] ([i915#3325])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-tglb1/igt@gem_vm_create@destroy-race.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb5/igt@gem_vm_create@destroy-race.html

  * igt@gen3_render_linear_blits:
    - shard-tglb:         NOTRUN -> [SKIP][27] ([fdo#109289])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb6/igt@gen3_render_linear_blits.html
    - shard-iclb:         NOTRUN -> [SKIP][28] ([fdo#109289])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb5/igt@gen3_render_linear_blits.html

  * igt@i915_pm_dc@dc6-psr:
    - shard-iclb:         [PASS][29] -> [DMESG-WARN][30] ([i915#3698])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb4/igt@i915_pm_dc@dc6-psr.html

  * igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
    - shard-tglb:         NOTRUN -> [SKIP][31] ([fdo#111644] / [i915#1397] / [i915#2411])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb6/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
    - shard-iclb:         NOTRUN -> [SKIP][32] ([fdo#110892])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb7/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html

  * igt@kms_big_fb@x-tiled-16bpp-rotate-270:
    - shard-iclb:         NOTRUN -> [SKIP][33] ([fdo#110725] / [fdo#111614])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb3/igt@kms_big_fb@x-tiled-16bpp-rotate-270.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-180:
    - shard-glk:          [PASS][34] -> [DMESG-WARN][35] ([i915#118] / [i915#95])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-glk9/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-glk1/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0:
    - shard-tglb:         NOTRUN -> [SKIP][36] ([fdo#111615])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb7/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0.html

  * igt@kms_ccs@pipe-b-bad-rotation-90-yf_tiled_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][37] ([i915#3689]) +2 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb7/igt@kms_ccs@pipe-b-bad-rotation-90-yf_tiled_ccs.html

  * igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
    - shard-glk:          NOTRUN -> [SKIP][38] ([fdo#109271]) +52 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-glk6/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_chamelium@dp-crc-single:
    - shard-snb:          NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +3 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-snb5/igt@kms_chamelium@dp-crc-single.html

  * igt@kms_chamelium@dp-mode-timings:
    - shard-apl:          NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +32 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl6/igt@kms_chamelium@dp-mode-timings.html

  * igt@kms_chamelium@hdmi-cmp-planar-formats:
    - shard-iclb:         NOTRUN -> [SKIP][41] ([fdo#109284] / [fdo#111827]) +3 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb2/igt@kms_chamelium@hdmi-cmp-planar-formats.html

  * igt@kms_color_chamelium@pipe-a-ctm-0-75:
    - shard-kbl:          NOTRUN -> [SKIP][42] ([fdo#109271] / [fdo#111827]) +13 similar issues
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl3/igt@kms_color_chamelium@pipe-a-ctm-0-75.html

  * igt@kms_color_chamelium@pipe-c-ctm-blue-to-red:
    - shard-glk:          NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +6 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-glk2/igt@kms_color_chamelium@pipe-c-ctm-blue-to-red.html
    - shard-tglb:         NOTRUN -> [SKIP][44] ([fdo#109284] / [fdo#111827]) +3 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb7/igt@kms_color_chamelium@pipe-c-ctm-blue-to-red.html

  * igt@kms_content_protection@lic:
    - shard-apl:          NOTRUN -> [TIMEOUT][45] ([i915#1319])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl8/igt@kms_content_protection@lic.html

  * igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding:
    - shard-tglb:         NOTRUN -> [SKIP][46] ([fdo#109279] / [i915#3359])
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb3/igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][47] -> [DMESG-WARN][48] ([i915#180]) +7 similar issues
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
    - shard-apl:          NOTRUN -> [DMESG-WARN][49] ([i915#180])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_legacy@pipe-d-torture-bo:
    - shard-apl:          NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#533]) +3 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl3/igt@kms_cursor_legacy@pipe-d-torture-bo.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-apl:          [PASS][51] -> [INCOMPLETE][52] ([i915#180])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-apl3/igt@kms_fbcon_fbt@fbc-suspend.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@2x-blocking-wf_vblank:
    - shard-iclb:         NOTRUN -> [SKIP][53] ([fdo#109274]) +1 similar issue
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb2/igt@kms_flip@2x-blocking-wf_vblank.html

  * igt@kms_flip@2x-plain-flip-ts-check:
    - shard-tglb:         NOTRUN -> [SKIP][54] ([fdo#111825]) +7 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb6/igt@kms_flip@2x-plain-flip-ts-check.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
    - shard-glk:          NOTRUN -> [FAIL][55] ([i915#79])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
    - shard-apl:          NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#2672])
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
    - shard-kbl:          [PASS][57] -> [FAIL][58] ([i915#2546] / [i915#49])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html
    - shard-apl:          [PASS][59] -> [FAIL][60] ([i915#49])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-apl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt:
    - shard-glk:          [PASS][61] -> [FAIL][62] ([i915#2546] / [i915#49])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff:
    - shard-iclb:         NOTRUN -> [SKIP][63] ([fdo#109280]) +6 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu:
    - shard-iclb:         [PASS][64] -> [FAIL][65] ([i915#2546] / [i915#49])
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
    - shard-apl:          NOTRUN -> [FAIL][66] ([fdo#108145] / [i915#265]) +6 similar issues
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html

  * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
    - shard-kbl:          NOTRUN -> [FAIL][67] ([fdo#108145] / [i915#265]) +1 similar issue
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
    - shard-apl:          NOTRUN -> [FAIL][68] ([i915#265])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl7/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-none:
    - shard-glk:          [PASS][69] -> [FAIL][70] ([i915#1779])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-glk7/igt@kms_plane_multiple@atomic-pipe-c-tiling-none.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-glk9/igt@kms_plane_multiple@atomic-pipe-c-tiling-none.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
    - shard-tglb:         NOTRUN -> [SKIP][71] ([i915#2920]) +1 similar issue
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
    - shard-glk:          NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#658]) +1 similar issue
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-glk2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
    - shard-iclb:         NOTRUN -> [SKIP][73] ([i915#658])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb4/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
    - shard-apl:          NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#658]) +5 similar issues
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
    - shard-kbl:          NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#658]) +3 similar issues
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
    - shard-iclb:         NOTRUN -> [SKIP][76] ([i915#2920])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         [PASS][77] -> [SKIP][78] ([fdo#109441]) +1 similar issue
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_sysfs_edid_timing:
    - shard-apl:          NOTRUN -> [FAIL][79] ([IGT#2])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl7/igt@kms_sysfs_edid_timing.html
    - shard-kbl:          NOTRUN -> [FAIL][80] ([IGT#2])
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl3/igt@kms_sysfs_edid_timing.html

  * igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
    - shard-kbl:          NOTRUN -> [SKIP][81] ([fdo#109271]) +143 similar issues
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl1/igt@kms_universal_plane@disable-primary-vs-flip-pipe-d.html
    - shard-snb:          NOTRUN -> [SKIP][82] ([fdo#109271]) +39 similar issues
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-snb6/igt@kms_universal_plane@disable-primary-vs-flip-pipe-d.html
    - shard-iclb:         NOTRUN -> [SKIP][83] ([fdo#109278]) +3 similar issues
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb4/igt@kms_universal_plane@disable-primary-vs-flip-pipe-d.html

  * igt@kms_vblank@pipe-d-ts-continuation-idle:
    - shard-apl:          NOTRUN -> [SKIP][84] ([fdo#109271]) +353 similar issues
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl8/igt@kms_vblank@pipe-d-ts-continuation-idle.html

  * igt@kms_writeback@writeback-check-output:
    - shard-apl:          NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#2437]) +1 similar issue
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl7/igt@kms_writeback@writeback-check-output.html

  * igt@nouveau_crc@pipe-b-source-outp-inactive:
    - shard-iclb:         NOTRUN -> [SKIP][86] ([i915#2530])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb5/igt@nouveau_crc@pipe-b-source-outp-inactive.html
    - shard-tglb:         NOTRUN -> [SKIP][87] ([i915#2530]) +1 similar issue
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb5/igt@nouveau_crc@pipe-b-source-outp-inactive.html

  * igt@nouveau_crc@pipe-d-source-outp-complete:
    - shard-iclb:         NOTRUN -> [SKIP][88] ([fdo#109278] / [i915#2530])
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb6/igt@nouveau_crc@pipe-d-source-outp-complete.html

  * igt@prime_vgem@coherency-gtt:
    - shard-tglb:         NOTRUN -> [SKIP][89] ([fdo#111656])
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb6/igt@prime_vgem@coherency-gtt.html
    - shard-iclb:         NOTRUN -> [SKIP][90] ([fdo#109292])
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb1/igt@prime_vgem@coherency-gtt.html

  * igt@sysfs_clients@create:
    - shard-glk:          NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#2994]) +1 similar issue
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-glk9/igt@sysfs_clients@create.html
    - shard-tglb:         NOTRUN -> [SKIP][92] ([i915#2994])
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb3/igt@sysfs_clients@create.html
    - shard-iclb:         NOTRUN -> [SKIP][93] ([i915#2994])
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb2/igt@sysfs_clients@create.html

  * igt@sysfs_clients@fair-1:
    - shard-apl:          NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#2994]) +4 similar issues
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl6/igt@sysfs_clients@fair-1.html

  * igt@sysfs_clients@sema-25:
    - shard-kbl:          NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#2994]) +3 similar issues
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl7/igt@sysfs_clients@sema-25.html

  
#### Possible fixes ####

  * igt@gem_ctx_persistence@many-contexts:
    - shard-tglb:         [FAIL][96] ([i915#2410]) -> [PASS][97]
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-tglb6/igt@gem_ctx_persistence@many-contexts.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb5/igt@gem_ctx_persistence@many-contexts.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-apl:          [SKIP][98] ([fdo#109271]) -> [PASS][99]
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-apl1/igt@gem_exec_fair@basic-none-share@rcs0.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl1/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-none@vcs0:
    - shard-kbl:          [FAIL][100] ([i915#2842]) -> [PASS][101] +1 similar issue
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl6/igt@gem_exec_fair@basic-none@vcs0.html

  * igt@gem_exec_fair@basic-pace-solo@rcs0:
    - shard-glk:          [FAIL][102] ([i915#2842]) -> [PASS][103] +3 similar issues
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-glk7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-glk2/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * igt@gem_mmap_gtt@cpuset-big-copy-xy:
    - shard-iclb:         [FAIL][104] ([i915#2428]) -> [PASS][105]
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-iclb1/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb4/igt@gem_mmap_gtt@cpuset-big-copy-xy.html

  * igt@kms_big_fb@linear-32bpp-rotate-0:
    - shard-glk:          [DMESG-WARN][106] ([i915#118] / [i915#95]) -> [PASS][107]
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-glk1/igt@kms_big_fb@linear-32bpp-rotate-0.html
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-glk3/igt@kms_big_fb@linear-32bpp-rotate-0.html

  * igt@kms_flip@flip-vs-expired-vblank@c-dp1:
    - shard-apl:          [FAIL][108] ([i915#79]) -> [PASS][109]
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-apl7/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl2/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html

  * igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1:
    - shard-glk:          [FAIL][110] ([i915#79]) -> [PASS][111]
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-glk7/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-glk4/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1.html

  * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
    - shard-kbl:          [DMESG-WARN][112] ([i915#180]) -> [PASS][113] +2 similar issues
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html

  * igt@kms_hdr@bpc-switch-suspend:
    - shard-apl:          [DMESG-WARN][114] ([i915#180]) -> [PASS][115] +2 similar issues
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-apl1/igt@kms_hdr@bpc-switch-suspend.html
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-apl1/igt@kms_hdr@bpc-switch-suspend.html

  * igt@kms_psr@psr2_sprite_mmap_gtt:
    - shard-iclb:         [SKIP][116] ([fdo#109441]) -> [PASS][117] +2 similar issues
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-iclb7/igt@kms_psr@psr2_sprite_mmap_gtt.html
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html

  
#### Warnings ####

  * igt@i915_pm_dc@dc9-dpms:
    - shard-iclb:         [FAIL][118] ([i915#3343]) -> [INCOMPLETE][119] ([i915#3698])
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-iclb6/igt@i915_pm_dc@dc9-dpms.html
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_pm_rc6_residency@rc6-fence:
    - shard-iclb:         [WARN][120] ([i915#1804] / [i915#2684]) -> [WARN][121] ([i915#2684])
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html

  * igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
    - shard-iclb:         [SKIP][122] ([i915#2920]) -> [SKIP][123] ([i915#658]) +3 similar issues
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb7/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
    - shard-iclb:         [SKIP][124] ([i915#658]) -> [SKIP][125] ([i915#2920])
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-iclb3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html

  * igt@runner@aborted:
    - shard-kbl:          ([FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131]) ([i915#180] / [i915#3002] / [i915#3363]) -> ([FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363])
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-kbl4/igt@runner@aborted.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-kbl4/igt@runner@aborted.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-kbl4/igt@runner@aborted.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-kbl4/igt@runner@aborted.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-kbl3/igt@runner@aborted.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-kbl1/igt@runner@aborted.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl4/igt@runner@aborted.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl3/igt@runner@aborted.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl4/igt@runner@aborted.html
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl7/igt@runner@aborted.html
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl4/igt@runner@aborted.html
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl3/igt@runner@aborted.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-kbl3/igt@runner@aborted.html
    - shard-tglb:         ([FAIL][139], [FAIL][140]) ([i915#3002]) -> ([FAIL][141], [FAIL][142], [FAIL][143]) ([i915#1887] / [i915#3002] / [i915#3516])
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-tglb3/igt@runner@aborted.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10304/shard-tglb1/igt@runner@aborted.html
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb1/igt@runner@aborted.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb6/igt@runner@aborted.html
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/shard-tglb5/igt@runner@aborted.html

  
  [IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109292]: https://bugs.freedesktop.org/show_bug.cgi?id=109292
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
  [fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
  [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
  [i915#1099]: https://gitl

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5978/index.html

[-- Attachment #1.2: Type: text/html, Size: 35789 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Dont commit primary for 6bpc display in coverage-vs-premult-vs-none

[Srinivas, Vidya]

Hello,

We checked that the same test works on a different Jasperlake system which has 8bpc. Our device has 6bpc panel and dithering is ON.
Can we use this patch as solution? If any one has a 6bpc panel, can you kindly let us know if its working for you? Thank you so much.

The same test works on HDMI connected to the system, just fails on the eDP which is 6bpc.

https://patchwork.freedesktop.org/patch/442435/?series=90828&rev=8

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya <vidya.srinivas@intel.com> 
Sent: Saturday, July 3, 2021 9:23 PM
To: igt-dev@lists.freedesktop.org
Cc: Srinivas, Vidya <vidya.srinivas@intel.com>
Subject: [PATCH i-g-t] tests/kms_plane_alpha_blend: Dont commit primary for 6bpc display in coverage-vs-premult-vs-none

Intel Gen11 6bpc panels are giving CRC mismatch in coverage-vs-premult-vs-none if primary gray fb is commited before starting alpha tests. Patch removes primar plane commit if device is intel and 6bpc.

Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 36 ++++++++++++++++++++++++++++++++++--
 1 file changed, 34 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..5f0a8cb070dd 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -25,6 +25,7 @@
  */
 
 #include "igt.h"
+#include <string.h>
 
 IGT_TEST_DESCRIPTION("Test plane alpha and blending mode properties");
 
@@ -442,14 +443,45 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
 	igt_pipe_crc_stop(data->pipe_crc);
 }
 
+static bool is_6bpc(igt_display_t *display) {
+	char buf[4096];
+	char *str;
+	bool ret;
+	int debugfs_fd;
+
+	if (!is_i915_device(display->drm_fd))
+		return false;
+
+	debugfs_fd = igt_debugfs_dir(display->drm_fd);
+
+	if (debugfs_fd < 0)
+		return false;
+
+	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf, 
+sizeof(buf));
+
+	str = strstr(buf, "bpp=");
+	if (strncmp(str, "bpp=18", 6) == 0)
+		ret = true;
+	else
+		ret = false;
+
+	close(debugfs_fd);
+	return ret;
+}
+
 static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)  {
 	igt_display_t *display = &data->display;
 	igt_crc_t ref_crc = {}, crc = {};
 
+
 	/* Set a background color on the primary fb for testing */
-	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
-		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
+	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
+		if (!is_6bpc(display))
+			igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
+						DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
+	}
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
--
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev9)

[Patchwork]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev9)
URL   : https://patchwork.freedesktop.org/series/90828/
State : failure

== Summary ==

Applying: tests/kms_plane_alpha_blend: Dont commit primary for 6bpc display in coverage-vs-premult-vs-none
Patch failed at 0001 tests/kms_plane_alpha_blend: Dont commit primary for 6bpc display in coverage-vs-premult-vs-none
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Dont commit primary for 6bpc display in coverage-vs-premult-vs-none

[Shankar, Uma]

> -----Original Message-----
> From: Srinivas, Vidya <vidya.srinivas@intel.com>
> Sent: Monday, July 5, 2021 8:08 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Shankar, Uma <uma.shankar@intel.com>; Heikkila, Juha-pekka <juha-
> pekka.heikkila@intel.com>; markyacoub@chromium.org; Latvala, Petri
> <petri.latvala@intel.com>; Almahallawy, Khaled <khaled.almahallawy@intel.com>;
> Lin, Charlton <charlton.lin@intel.com>
> Subject: RE: [PATCH i-g-t] tests/kms_plane_alpha_blend: Dont commit primary for
> 6bpc display in coverage-vs-premult-vs-none
> 
> Hello,
> 
> We checked that the same test works on a different Jasperlake system which has
> 8bpc. Our device has 6bpc panel and dithering is ON.
> Can we use this patch as solution? If any one has a 6bpc panel, can you kindly let us
> know if its working for you? Thank you so much.
> 
> The same test works on HDMI connected to the system, just fails on the eDP which is
> 6bpc.

Hi Vidya,
Doing a crc based test with dithering is not a great idea as pixels will change due to the
8bit to 6bits truncation with dithering. So let's have this test skip on 6bpc panels instead of
relying on this empirical result.

Just have a test condition igt_require in the beginning (see reference usage of that in IGT).

Regards,
Uma Shankar

> https://patchwork.freedesktop.org/patch/442435/?series=90828&rev=8
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya <vidya.srinivas@intel.com>
> Sent: Saturday, July 3, 2021 9:23 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Srinivas, Vidya <vidya.srinivas@intel.com>
> Subject: [PATCH i-g-t] tests/kms_plane_alpha_blend: Dont commit primary for 6bpc
> display in coverage-vs-premult-vs-none
> 
> Intel Gen11 6bpc panels are giving CRC mismatch in coverage-vs-premult-vs-none if
> primary gray fb is commited before starting alpha tests. Patch removes primar plane
> commit if device is intel and 6bpc.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 36 ++++++++++++++++++++++++++++++++++--
>  1 file changed, 34 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c index
> a37cb27c7d62..5f0a8cb070dd 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -25,6 +25,7 @@
>   */
> 
>  #include "igt.h"
> +#include <string.h>
> 
>  IGT_TEST_DESCRIPTION("Test plane alpha and blending mode properties");
> 
> @@ -442,14 +443,45 @@ static void coverage_7efc(data_t *data, enum pipe pipe,
> igt_plane_t *plane)
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> 
> +static bool is_6bpc(igt_display_t *display) {
> +	char buf[4096];
> +	char *str;
> +	bool ret;
> +	int debugfs_fd;
> +
> +	if (!is_i915_device(display->drm_fd))
> +		return false;
> +
> +	debugfs_fd = igt_debugfs_dir(display->drm_fd);
> +
> +	if (debugfs_fd < 0)
> +		return false;
> +
> +	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> +sizeof(buf));
> +
> +	str = strstr(buf, "bpp=");
> +	if (strncmp(str, "bpp=18", 6) == 0)
> +		ret = true;
> +	else
> +		ret = false;
> +
> +	close(debugfs_fd);
> +	return ret;
> +}
> +
>  static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
> *plane)  {
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> 
> +
>  	/* Set a background color on the primary fb for testing */
> -	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> -		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> +	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
> +		if (!is_6bpc(display))
> +			igt_plane_set_fb(igt_pipe_get_plane_type(&display-
> >pipes[pipe],
> +						DRM_PLANE_TYPE_PRIMARY),
> &data->gray_fb);
> +	}
> 
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
> "Coverage");
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
> --
> 2.7.4
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Dont commit primary for 6bpc display in coverage-vs-premult-vs-none

[Srinivas, Vidya]

Thank you so much Uma. This was very helpful. I shall do the same.

Regards
Vidya

-----Original Message-----
From: Shankar, Uma <uma.shankar@intel.com> 
Sent: Tuesday, July 6, 2021 12:37 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>; markyacoub@chromium.org; Latvala, Petri <petri.latvala@intel.com>; Almahallawy, Khaled <khaled.almahallawy@intel.com>; Lin, Charlton <charlton.lin@intel.com>
Subject: RE: [PATCH i-g-t] tests/kms_plane_alpha_blend: Dont commit primary for 6bpc display in coverage-vs-premult-vs-none



> -----Original Message-----
> From: Srinivas, Vidya <vidya.srinivas@intel.com>
> Sent: Monday, July 5, 2021 8:08 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Shankar, Uma <uma.shankar@intel.com>; Heikkila, Juha-pekka <juha- 
> pekka.heikkila@intel.com>; markyacoub@chromium.org; Latvala, Petri 
> <petri.latvala@intel.com>; Almahallawy, Khaled 
> <khaled.almahallawy@intel.com>; Lin, Charlton <charlton.lin@intel.com>
> Subject: RE: [PATCH i-g-t] tests/kms_plane_alpha_blend: Dont commit 
> primary for 6bpc display in coverage-vs-premult-vs-none
> 
> Hello,
> 
> We checked that the same test works on a different Jasperlake system 
> which has 8bpc. Our device has 6bpc panel and dithering is ON.
> Can we use this patch as solution? If any one has a 6bpc panel, can 
> you kindly let us know if its working for you? Thank you so much.
> 
> The same test works on HDMI connected to the system, just fails on the 
> eDP which is 6bpc.

Hi Vidya,
Doing a crc based test with dithering is not a great idea as pixels will change due to the 8bit to 6bits truncation with dithering. So let's have this test skip on 6bpc panels instead of relying on this empirical result.

Just have a test condition igt_require in the beginning (see reference usage of that in IGT).

Regards,
Uma Shankar

> https://patchwork.freedesktop.org/patch/442435/?series=90828&rev=8
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya <vidya.srinivas@intel.com>
> Sent: Saturday, July 3, 2021 9:23 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Srinivas, Vidya <vidya.srinivas@intel.com>
> Subject: [PATCH i-g-t] tests/kms_plane_alpha_blend: Dont commit 
> primary for 6bpc display in coverage-vs-premult-vs-none
> 
> Intel Gen11 6bpc panels are giving CRC mismatch in 
> coverage-vs-premult-vs-none if primary gray fb is commited before 
> starting alpha tests. Patch removes primar plane commit if device is intel and 6bpc.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 36 
> ++++++++++++++++++++++++++++++++++--
>  1 file changed, 34 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..5f0a8cb070dd 
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -25,6 +25,7 @@
>   */
> 
>  #include "igt.h"
> +#include <string.h>
> 
>  IGT_TEST_DESCRIPTION("Test plane alpha and blending mode 
> properties");
> 
> @@ -442,14 +443,45 @@ static void coverage_7efc(data_t *data, enum 
> pipe pipe, igt_plane_t *plane)  igt_pipe_crc_stop(data->pipe_crc);
>  }
> 
> +static bool is_6bpc(igt_display_t *display) { char buf[4096]; char 
> +*str; bool ret; int debugfs_fd;
> +
> +if (!is_i915_device(display->drm_fd))
> +return false;
> +
> +debugfs_fd = igt_debugfs_dir(display->drm_fd);
> +
> +if (debugfs_fd < 0)
> +return false;
> +
> +igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf, 
> +sizeof(buf));
> +
> +str = strstr(buf, "bpp=");
> +if (strncmp(str, "bpp=18", 6) == 0)
> +ret = true;
> +else
> +ret = false;
> +
> +close(debugfs_fd);
> +return ret;
> +}
> +
>  static void coverage_premult_constant(data_t *data, enum pipe pipe, 
> igt_plane_t
> *plane)  {
>  igt_display_t *display = &data->display;  igt_crc_t ref_crc = {}, crc 
> = {};
> 
> +
>  /* Set a background color on the primary fb for testing */ -if 
> (plane->type != DRM_PLANE_TYPE_PRIMARY) 
> -igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> +if (plane->type != DRM_PLANE_TYPE_PRIMARY) { if (!is_6bpc(display))
> +igt_plane_set_fb(igt_pipe_get_plane_type(&display-
> >pipes[pipe],
> +DRM_PLANE_TYPE_PRIMARY),
> &data->gray_fb);
> +}
> 
>  igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
> "Coverage");  igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
> --
> 2.7.4
> 


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

[Vidya Srinivas]

Intel Gen11 6bpc panels are giving CRC mismatch in coverage-vs-premult-vs-none
6bpc panel has dithering ON and CRC test with dithering ON might result in
mismatch. Hence, skipping this subtest for 6bpc panels.

Credits-to: Uma Shankar <uma.shankar@intel.com>
Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..7f9738545f0a 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -25,6 +25,7 @@
  */
 
 #include "igt.h"
+#include "igt_edid.h"
 
 IGT_TEST_DESCRIPTION("Test plane alpha and blending mode properties");
 
@@ -442,10 +443,38 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
 	igt_pipe_crc_stop(data->pipe_crc);
 }
 
+uint8_t get_edid_bpc(data_t *data, igt_output_t *output)
+{
+	bool ok;
+	uint64_t edid_blob_id;
+	drmModePropertyBlobRes *edid_blob;
+	const struct edid *edid;
+
+	ok = kmstest_get_property(data->gfx_fd, output->id,
+			DRM_MODE_OBJECT_CONNECTOR, "EDID",
+			NULL, &edid_blob_id, NULL);
+
+	if (!ok || !edid_blob_id)
+		return 0;
+
+	edid_blob = drmModeGetPropertyBlob(data->gfx_fd, edid_blob_id);
+	igt_assert(edid_blob);
+
+	edid = (const struct edid *) edid_blob->data;
+	igt_assert(edid);
+
+	drmModeFreePropertyBlob(edid_blob);
+	return ((edid->input & 0x70) >> 3) + 4;
+}
+
 static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)
 {
 	igt_display_t *display = &data->display;
 	igt_crc_t ref_crc = {}, crc = {};
+	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
+	uint8_t current_bpc = get_edid_bpc(data, output);
+
+	igt_require(current_bpc >= 8);
 
 	/* Set a background color on the primary fb for testing */
 	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Dont commit primary for 6bpc display in coverage-vs-premult-vs-none

[Srinivas, Vidya]

Hello Uma,

I have submitted this patch https://patchwork.freedesktop.org/patch/442724/?series=90828&rev=10
I read the EDID and get bpc and skip if < 8. I have used igt_require.

I tried using existing MAX_BPC get property but that did not get current bpc from kernel.

I have tested this patch on eDP which skipped and HDMI which PASSED. Kindly have a check of this patch and suggest.
Thanks a lot.

Regards
Vidya

-----Original Message-----
From: Shankar, Uma <uma.shankar@intel.com> 
Sent: Tuesday, July 6, 2021 12:37 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>; markyacoub@chromium.org; Latvala, Petri <petri.latvala@intel.com>; Almahallawy, Khaled <khaled.almahallawy@intel.com>; Lin, Charlton <charlton.lin@intel.com>
Subject: RE: [PATCH i-g-t] tests/kms_plane_alpha_blend: Dont commit primary for 6bpc display in coverage-vs-premult-vs-none



> -----Original Message-----
> From: Srinivas, Vidya <vidya.srinivas@intel.com>
> Sent: Monday, July 5, 2021 8:08 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Shankar, Uma <uma.shankar@intel.com>; Heikkila, Juha-pekka <juha- 
> pekka.heikkila@intel.com>; markyacoub@chromium.org; Latvala, Petri 
> <petri.latvala@intel.com>; Almahallawy, Khaled 
> <khaled.almahallawy@intel.com>; Lin, Charlton <charlton.lin@intel.com>
> Subject: RE: [PATCH i-g-t] tests/kms_plane_alpha_blend: Dont commit 
> primary for 6bpc display in coverage-vs-premult-vs-none
> 
> Hello,
> 
> We checked that the same test works on a different Jasperlake system 
> which has 8bpc. Our device has 6bpc panel and dithering is ON.
> Can we use this patch as solution? If any one has a 6bpc panel, can 
> you kindly let us know if its working for you? Thank you so much.
> 
> The same test works on HDMI connected to the system, just fails on the 
> eDP which is 6bpc.

Hi Vidya,
Doing a crc based test with dithering is not a great idea as pixels will change due to the 8bit to 6bits truncation with dithering. So let's have this test skip on 6bpc panels instead of relying on this empirical result.

Just have a test condition igt_require in the beginning (see reference usage of that in IGT).

Regards,
Uma Shankar

> https://patchwork.freedesktop.org/patch/442435/?series=90828&rev=8
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya <vidya.srinivas@intel.com>
> Sent: Saturday, July 3, 2021 9:23 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Srinivas, Vidya <vidya.srinivas@intel.com>
> Subject: [PATCH i-g-t] tests/kms_plane_alpha_blend: Dont commit 
> primary for 6bpc display in coverage-vs-premult-vs-none
> 
> Intel Gen11 6bpc panels are giving CRC mismatch in 
> coverage-vs-premult-vs-none if primary gray fb is commited before 
> starting alpha tests. Patch removes primar plane commit if device is intel and 6bpc.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 36 
> ++++++++++++++++++++++++++++++++++--
>  1 file changed, 34 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..5f0a8cb070dd 
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -25,6 +25,7 @@
>   */
> 
>  #include "igt.h"
> +#include <string.h>
> 
>  IGT_TEST_DESCRIPTION("Test plane alpha and blending mode 
> properties");
> 
> @@ -442,14 +443,45 @@ static void coverage_7efc(data_t *data, enum 
> pipe pipe, igt_plane_t *plane)  igt_pipe_crc_stop(data->pipe_crc);
>  }
> 
> +static bool is_6bpc(igt_display_t *display) { char buf[4096]; char 
> +*str; bool ret; int debugfs_fd;
> +
> +if (!is_i915_device(display->drm_fd))
> +return false;
> +
> +debugfs_fd = igt_debugfs_dir(display->drm_fd);
> +
> +if (debugfs_fd < 0)
> +return false;
> +
> +igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf, 
> +sizeof(buf));
> +
> +str = strstr(buf, "bpp=");
> +if (strncmp(str, "bpp=18", 6) == 0)
> +ret = true;
> +else
> +ret = false;
> +
> +close(debugfs_fd);
> +return ret;
> +}
> +
>  static void coverage_premult_constant(data_t *data, enum pipe pipe, 
> igt_plane_t
> *plane)  {
>  igt_display_t *display = &data->display;  igt_crc_t ref_crc = {}, crc 
> = {};
> 
> +
>  /* Set a background color on the primary fb for testing */ -if 
> (plane->type != DRM_PLANE_TYPE_PRIMARY) 
> -igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe],
> DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
> +if (plane->type != DRM_PLANE_TYPE_PRIMARY) { if (!is_6bpc(display))
> +igt_plane_set_fb(igt_pipe_get_plane_type(&display-
> >pipes[pipe],
> +DRM_PLANE_TYPE_PRIMARY),
> &data->gray_fb);
> +}
> 
>  igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, 
> "Coverage");  igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
> --
> 2.7.4
> 


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev10)

[Patchwork]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev10)
URL   : https://patchwork.freedesktop.org/series/90828/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/354277 for the overview.

test:ninja-test-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/11551156):
  [9089008.151372] Test exited with IGT_EXIT_ABORT, aborting.
  [9089009.762349] Test exited with IGT_EXIT_ABORT, aborting.
  -------
  
  Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
  FAILED: meson-test 
  /usr/bin/meson test --no-rebuild --print-errorlogs
  ninja: build stopped: subcommand failed.
  section_end:1625586499:step_script
  section_start:1625586499:upload_artifacts_on_failure
  Uploading artifacts for failed job
  Uploading artifacts...
  build: found 1623 matching files and directories   
  Uploading artifacts as "archive" to coordinator... ok  id=11551156 responseStatus=201 Created token=isexsqQ_
  section_end:1625586513:upload_artifacts_on_failure
  section_start:1625586513:cleanup_file_variables
  Cleaning up file based variables
  section_end:1625586515:cleanup_file_variables
  ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/354277
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev10)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 1610 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev10)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10306 -> IGTPW_5985
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/index.html

Known issues
------------

  Here are the changes found in IGTPW_5985 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-cfl-8109u:       [PASS][1] -> [INCOMPLETE][2] ([i915#155])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html

  
  [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155


Participating hosts (41 -> 37)
------------------------------

  Missing    (4): fi-ctg-p8600 fi-ilk-m540 fi-bsw-cyan fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6129 -> IGTPW_5985

  CI-20190529: 20190529
  CI_DRM_10306: 134ea1b1bddc580a8a246b05299291c9a7b0c7f5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_5985: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/index.html
  IGT_6129: 687589e76f787d26ee2b539e551a9be06bd41ce3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/index.html

[-- Attachment #1.2: Type: text/html, Size: 2195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev10)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 30296 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev10)
URL   : https://patchwork.freedesktop.org/series/90828/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10306_full -> IGTPW_5985_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_5985_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_5985_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_5985_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
    - shard-apl:          NOTRUN -> [FAIL][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl8/igt@kms_addfb_basic@invalid-smem-bo-on-discrete.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-vs-premult-vs-constant:
    - shard-tglb:         NOTRUN -> [SKIP][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb6/igt@kms_plane_alpha_blend@pipe-b-coverage-vs-premult-vs-constant.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant:
    - shard-tglb:         [PASS][3] -> [SKIP][4] +2 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-tglb3/igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb7/igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant.html

  
Known issues
------------

  Here are the changes found in IGTPW_5985_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_persistence@smoketest:
    - shard-snb:          NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-snb6/igt@gem_ctx_persistence@smoketest.html

  * igt@gem_eio@unwedge-stress:
    - shard-tglb:         [PASS][6] -> [TIMEOUT][7] ([i915#2369] / [i915#3063] / [i915#3648])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-tglb7/igt@gem_eio@unwedge-stress.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb1/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-none-vip@rcs0:
    - shard-glk:          [PASS][8] -> [FAIL][9] ([i915#2842])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-glk4/igt@gem_exec_fair@basic-none-vip@rcs0.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk3/igt@gem_exec_fair@basic-none-vip@rcs0.html

  * igt@gem_exec_fair@basic-pace@rcs0:
    - shard-kbl:          [PASS][10] -> [FAIL][11] ([i915#2842])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl3/igt@gem_exec_fair@basic-pace@rcs0.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html
    - shard-tglb:         [PASS][12] -> [FAIL][13] ([i915#2842])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-tglb3/igt@gem_exec_fair@basic-pace@rcs0.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb1/igt@gem_exec_fair@basic-pace@rcs0.html

  * igt@gem_exec_fair@basic-pace@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][14] ([i915#2842])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html

  * igt@gem_exec_params@no-bsd:
    - shard-tglb:         NOTRUN -> [SKIP][15] ([fdo#109283])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb1/igt@gem_exec_params@no-bsd.html
    - shard-iclb:         NOTRUN -> [SKIP][16] ([fdo#109283])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb3/igt@gem_exec_params@no-bsd.html

  * igt@gem_exec_reloc@basic-wide-active@bcs0:
    - shard-apl:          NOTRUN -> [FAIL][17] ([i915#3633]) +3 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl6/igt@gem_exec_reloc@basic-wide-active@bcs0.html

  * igt@gem_exec_reloc@basic-wide-active@rcs0:
    - shard-snb:          NOTRUN -> [FAIL][18] ([i915#3633]) +2 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-snb6/igt@gem_exec_reloc@basic-wide-active@rcs0.html

  * igt@gem_exec_reloc@basic-wide-active@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][19] ([i915#3633])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb2/igt@gem_exec_reloc@basic-wide-active@vcs1.html

  * igt@gem_exec_whisper@basic-contexts:
    - shard-glk:          [PASS][20] -> [DMESG-WARN][21] ([i915#118] / [i915#95]) +1 similar issue
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-glk6/igt@gem_exec_whisper@basic-contexts.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk9/igt@gem_exec_whisper@basic-contexts.html

  * igt@gem_mmap_gtt@big-copy-odd:
    - shard-glk:          [PASS][22] -> [FAIL][23] ([i915#307]) +2 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-glk8/igt@gem_mmap_gtt@big-copy-odd.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk1/igt@gem_mmap_gtt@big-copy-odd.html

  * igt@gem_render_copy@y-tiled-to-vebox-linear:
    - shard-iclb:         NOTRUN -> [SKIP][24] ([i915#768]) +1 similar issue
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb7/igt@gem_render_copy@y-tiled-to-vebox-linear.html

  * igt@gem_softpin@evict-snoop-interruptible:
    - shard-tglb:         NOTRUN -> [SKIP][25] ([fdo#109312])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb3/igt@gem_softpin@evict-snoop-interruptible.html
    - shard-iclb:         NOTRUN -> [SKIP][26] ([fdo#109312])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb8/igt@gem_softpin@evict-snoop-interruptible.html

  * igt@gem_userptr_blits@access-control:
    - shard-tglb:         NOTRUN -> [SKIP][27] ([i915#3297])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb6/igt@gem_userptr_blits@access-control.html
    - shard-iclb:         NOTRUN -> [SKIP][28] ([i915#3297])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb5/igt@gem_userptr_blits@access-control.html

  * igt@gem_userptr_blits@vma-merge:
    - shard-apl:          NOTRUN -> [FAIL][29] ([i915#3318])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl8/igt@gem_userptr_blits@vma-merge.html
    - shard-iclb:         NOTRUN -> [FAIL][30] ([i915#3318])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb6/igt@gem_userptr_blits@vma-merge.html
    - shard-glk:          NOTRUN -> [FAIL][31] ([i915#3318])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk6/igt@gem_userptr_blits@vma-merge.html
    - shard-kbl:          NOTRUN -> [FAIL][32] ([i915#3318])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-kbl6/igt@gem_userptr_blits@vma-merge.html
    - shard-tglb:         NOTRUN -> [FAIL][33] ([i915#3318])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb7/igt@gem_userptr_blits@vma-merge.html

  * igt@gen9_exec_parse@batch-zero-length:
    - shard-iclb:         NOTRUN -> [SKIP][34] ([fdo#112306])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb5/igt@gen9_exec_parse@batch-zero-length.html
    - shard-tglb:         NOTRUN -> [SKIP][35] ([fdo#112306])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb5/igt@gen9_exec_parse@batch-zero-length.html

  * igt@gen9_exec_parse@bb-large:
    - shard-tglb:         NOTRUN -> [SKIP][36] ([i915#2527])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb1/igt@gen9_exec_parse@bb-large.html
    - shard-apl:          NOTRUN -> [FAIL][37] ([i915#3296])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl6/igt@gen9_exec_parse@bb-large.html
    - shard-iclb:         NOTRUN -> [SKIP][38] ([i915#2527])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb7/igt@gen9_exec_parse@bb-large.html

  * igt@i915_pm_dc@dc5-psr:
    - shard-iclb:         [PASS][39] -> [DMESG-WARN][40] ([i915#3698])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb5/igt@i915_pm_dc@dc5-psr.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb4/igt@i915_pm_dc@dc5-psr.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
    - shard-apl:          NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#1937])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl3/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html

  * igt@i915_pm_rc6_residency@media-rc6-accuracy:
    - shard-tglb:         NOTRUN -> [SKIP][42] ([fdo#109289] / [fdo#111719])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb6/igt@i915_pm_rc6_residency@media-rc6-accuracy.html

  * igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
    - shard-tglb:         NOTRUN -> [SKIP][43] ([fdo#111644] / [i915#1397] / [i915#2411])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb1/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
    - shard-iclb:         NOTRUN -> [SKIP][44] ([fdo#110892])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb3/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html

  * igt@i915_pm_sseu@full-enable:
    - shard-tglb:         NOTRUN -> [SKIP][45] ([fdo#109288])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb7/igt@i915_pm_sseu@full-enable.html
    - shard-iclb:         NOTRUN -> [SKIP][46] ([fdo#109288])
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb6/igt@i915_pm_sseu@full-enable.html

  * igt@i915_selftest@live@hangcheck:
    - shard-snb:          [PASS][47] -> [INCOMPLETE][48] ([i915#2782])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-snb7/igt@i915_selftest@live@hangcheck.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-snb7/igt@i915_selftest@live@hangcheck.html

  * igt@kms_atomic_transition@plane-all-modeset-transition:
    - shard-iclb:         NOTRUN -> [SKIP][49] ([i915#1769])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb3/igt@kms_atomic_transition@plane-all-modeset-transition.html
    - shard-tglb:         NOTRUN -> [SKIP][50] ([i915#1769])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb7/igt@kms_atomic_transition@plane-all-modeset-transition.html

  * igt@kms_big_fb@linear-32bpp-rotate-180:
    - shard-glk:          NOTRUN -> [DMESG-WARN][51] ([i915#118] / [i915#95])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk1/igt@kms_big_fb@linear-32bpp-rotate-180.html

  * igt@kms_big_fb@linear-8bpp-rotate-270:
    - shard-tglb:         NOTRUN -> [SKIP][52] ([fdo#111614]) +4 similar issues
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb3/igt@kms_big_fb@linear-8bpp-rotate-270.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-270:
    - shard-iclb:         NOTRUN -> [SKIP][53] ([fdo#110725] / [fdo#111614]) +4 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb7/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html

  * igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
    - shard-tglb:         NOTRUN -> [SKIP][54] ([fdo#111615]) +1 similar issue
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb6/igt@kms_big_fb@yf-tiled-32bpp-rotate-270.html

  * igt@kms_big_joiner@invalid-modeset:
    - shard-iclb:         NOTRUN -> [SKIP][55] ([i915#2705])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb5/igt@kms_big_joiner@invalid-modeset.html
    - shard-tglb:         NOTRUN -> [SKIP][56] ([i915#2705])
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb6/igt@kms_big_joiner@invalid-modeset.html

  * igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][57] ([i915#3689]) +6 similar issues
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb7/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_ccs.html

  * igt@kms_cdclk@mode-transition:
    - shard-apl:          NOTRUN -> [SKIP][58] ([fdo#109271]) +199 similar issues
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl8/igt@kms_cdclk@mode-transition.html

  * igt@kms_chamelium@dp-mode-timings:
    - shard-apl:          NOTRUN -> [SKIP][59] ([fdo#109271] / [fdo#111827]) +19 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl6/igt@kms_chamelium@dp-mode-timings.html

  * igt@kms_chamelium@vga-edid-read:
    - shard-iclb:         NOTRUN -> [SKIP][60] ([fdo#109284] / [fdo#111827]) +7 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb1/igt@kms_chamelium@vga-edid-read.html

  * igt@kms_chamelium@vga-hpd-without-ddc:
    - shard-kbl:          NOTRUN -> [SKIP][61] ([fdo#109271] / [fdo#111827]) +12 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-kbl1/igt@kms_chamelium@vga-hpd-without-ddc.html

  * igt@kms_color@pipe-d-degamma:
    - shard-iclb:         NOTRUN -> [SKIP][62] ([fdo#109278] / [i915#1149])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb4/igt@kms_color@pipe-d-degamma.html

  * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
    - shard-snb:          NOTRUN -> [SKIP][63] ([fdo#109271] / [fdo#111827]) +15 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-snb7/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html

  * igt@kms_color_chamelium@pipe-d-ctm-0-25:
    - shard-glk:          NOTRUN -> [SKIP][64] ([fdo#109271] / [fdo#111827]) +9 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk4/igt@kms_color_chamelium@pipe-d-ctm-0-25.html
    - shard-tglb:         NOTRUN -> [SKIP][65] ([fdo#109284] / [fdo#111827]) +8 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb6/igt@kms_color_chamelium@pipe-d-ctm-0-25.html

  * igt@kms_content_protection@atomic-dpms:
    - shard-kbl:          NOTRUN -> [TIMEOUT][66] ([i915#1319])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-kbl7/igt@kms_content_protection@atomic-dpms.html

  * igt@kms_content_protection@legacy:
    - shard-apl:          NOTRUN -> [TIMEOUT][67] ([i915#1319])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl2/igt@kms_content_protection@legacy.html

  * igt@kms_cursor_crc@pipe-c-cursor-32x32-sliding:
    - shard-tglb:         NOTRUN -> [SKIP][68] ([i915#3319])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb6/igt@kms_cursor_crc@pipe-c-cursor-32x32-sliding.html

  * igt@kms_cursor_crc@pipe-c-cursor-512x170-onscreen:
    - shard-tglb:         NOTRUN -> [SKIP][69] ([fdo#109279] / [i915#3359])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-512x170-onscreen.html
    - shard-iclb:         NOTRUN -> [SKIP][70] ([fdo#109278] / [fdo#109279])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb2/igt@kms_cursor_crc@pipe-c-cursor-512x170-onscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-max-size-rapid-movement:
    - shard-tglb:         NOTRUN -> [SKIP][71] ([i915#3359]) +1 similar issue
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-max-size-rapid-movement.html

  * igt@kms_cursor_crc@pipe-d-cursor-64x21-sliding:
    - shard-iclb:         NOTRUN -> [SKIP][72] ([fdo#109278]) +20 similar issues
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb3/igt@kms_cursor_crc@pipe-d-cursor-64x21-sliding.html

  * igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
    - shard-iclb:         NOTRUN -> [SKIP][73] ([fdo#109274] / [fdo#109278])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb3/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html

  * igt@kms_cursor_legacy@pipe-d-single-bo:
    - shard-glk:          NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#533])
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk7/igt@kms_cursor_legacy@pipe-d-single-bo.html

  * igt@kms_flip@2x-flip-vs-wf_vblank-interruptible:
    - shard-iclb:         NOTRUN -> [SKIP][75] ([fdo#109274]) +1 similar issue
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb5/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html

  * igt@kms_flip@flip-vs-suspend@a-dp1:
    - shard-apl:          [PASS][76] -> [DMESG-WARN][77] ([i915#180])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-apl7/igt@kms_flip@flip-vs-suspend@a-dp1.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl6/igt@kms_flip@flip-vs-suspend@a-dp1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
    - shard-snb:          NOTRUN -> [SKIP][78] ([fdo#109271]) +295 similar issues
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-snb6/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt:
    - shard-tglb:         NOTRUN -> [SKIP][79] ([fdo#111825]) +14 similar issues
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-kbl:          [PASS][80] -> [DMESG-WARN][81] ([i915#180]) +4 similar issues
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc:
    - shard-glk:          NOTRUN -> [SKIP][82] ([fdo#109271]) +91 similar issues
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk4/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         NOTRUN -> [SKIP][83] ([fdo#109280]) +9 similar issues
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt:
    - shard-kbl:          NOTRUN -> [SKIP][84] ([fdo#109271]) +132 similar issues
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-kbl1/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt.html

  * igt@kms_hdr@bpc-switch-suspend:
    - shard-kbl:          [PASS][85] -> [FAIL][86] ([i915#1188])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl4/igt@kms_hdr@bpc-switch-suspend.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-kbl6/igt@kms_hdr@bpc-switch-suspend.html

  * igt@kms_hdr@static-toggle-suspend:
    - shard-tglb:         NOTRUN -> [SKIP][87] ([i915#1187])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb3/igt@kms_hdr@static-toggle-suspend.html
    - shard-iclb:         NOTRUN -> [SKIP][88] ([i915#1187])
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb1/igt@kms_hdr@static-toggle-suspend.html

  * igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c:
    - shard-tglb:         NOTRUN -> [SKIP][89] ([fdo#109289])
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb3/igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c.html
    - shard-iclb:         NOTRUN -> [SKIP][90] ([fdo#109289]) +1 similar issue
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb4/igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c.html

  * igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
    - shard-apl:          NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#533]) +1 similar issue
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl3/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html

  * igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant:
    - shard-kbl:          [PASS][92] -> [SKIP][93] ([fdo#109271]) +1 similar issue
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl7/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-kbl2/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
    - shard-apl:          [PASS][94] -> [SKIP][95] ([fdo#109271])
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-apl1/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
    - shard-iclb:         [PASS][96] -> [SKIP][97] ([fdo#109278])
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb3/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb2/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
    - shard-glk:          NOTRUN -> [FAIL][98] ([fdo#108145] / [i915#265])
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk5/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
    - shard-kbl:          NOTRUN -> [FAIL][99] ([fdo#108145] / [i915#265])
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-kbl7/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html

  * igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
    - shard-apl:          NOTRUN -> [FAIL][100] ([fdo#108145] / [i915#265]) +1 similar issue
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl3/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant:
    - shard-glk:          [PASS][101] -> [SKIP][102] ([fdo#109271]) +1 similar issue
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-glk2/igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk4/igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
    - shard-kbl:          NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#658]) +3 similar issues
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-kbl6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
    - shard-tglb:         NOTRUN -> [SKIP][104] ([i915#2920])
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
    - shard-apl:          NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#658]) +4 similar issues
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
    - shard-glk:          NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#658]) +1 similar issue
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
    - shard-iclb:         NOTRUN -> [SKIP][107] ([i915#658])
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb1/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html

  * igt@kms_psr2_su@page_flip:
    - shard-tglb:         NOTRUN -> [SKIP][108] ([i915#1911])
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb7/igt@kms_psr2_su@page_flip.html

  * igt@kms_psr@psr2_dpms:
    - shard-tglb:         NOTRUN -> [FAIL][109] ([i915#132] / [i915#3467]) +1 similar issue
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb7/igt@kms_psr@psr2_dpms.html

  * igt@kms_psr@psr2_no_drrs:
    - shard-iclb:         [PASS][110] -> [SKIP][111] ([fdo#109441]) +3 similar issues
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb4/igt@kms_psr@psr2_no_drrs.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         NOTRUN -> [SKIP][112] ([fdo#109441])
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@kms_sysfs_edid_timing:
    - shard-apl:          NOTRUN -> [FAIL][113] ([IGT#2])
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl2/igt@kms_sysfs_edid_timing.html

  * igt@kms_vblank@pipe-d-wait-idle:
    - shard-kbl:          NOTRUN -> [SKIP][114] ([fdo#109271] / [i915#533]) +2 similar issues
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-kbl7/igt@kms_vblank@pipe-d-wait-idle.html

  * igt@kms_writeback@writeback-check-output:
    - shard-apl:          NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#2437])
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl6/igt@kms_writeback@writeback-check-output.html

  * igt@kms_writeback@writeback-fb-id:
    - shard-glk:          NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#2437])
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk2/igt@kms_writeback@writeback-fb-id.html

  * igt@perf@polling-parameterized:
    - shard-glk:          [PASS][117] -> [FAIL][118] ([i915#1542])
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-glk6/igt@perf@polling-parameterized.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk3/igt@perf@polling-parameterized.html

  * igt@prime_nv_api@i915_nv_import_twice:
    - shard-iclb:         NOTRUN -> [SKIP][119] ([fdo#109291])
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb7/igt@prime_nv_api@i915_nv_import_twice.html
    - shard-tglb:         NOTRUN -> [SKIP][120] ([fdo#109291])
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb1/igt@prime_nv_api@i915_nv_import_twice.html

  * igt@sysfs_clients@busy:
    - shard-tglb:         NOTRUN -> [SKIP][121] ([i915#2994]) +1 similar issue
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb7/igt@sysfs_clients@busy.html
    - shard-glk:          NOTRUN -> [SKIP][122] ([fdo#109271] / [i915#2994]) +1 similar issue
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk6/igt@sysfs_clients@busy.html
    - shard-kbl:          NOTRUN -> [SKIP][123] ([fdo#109271] / [i915#2994])
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-kbl2/igt@sysfs_clients@busy.html

  * igt@sysfs_clients@fair-7:
    - shard-apl:          NOTRUN -> [SKIP][124] ([fdo#109271] / [i915#2994]) +3 similar issues
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-apl2/igt@sysfs_clients@fair-7.html
    - shard-iclb:         NOTRUN -> [SKIP][125] ([i915#2994]) +1 similar issue
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb4/igt@sysfs_clients@fair-7.html

  
#### Possible fixes ####

  * igt@gem_exec_fair@basic-deadline:
    - shard-glk:          [FAIL][126] ([i915#2846]) -> [PASS][127]
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-glk4/igt@gem_exec_fair@basic-deadline.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk2/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-flow@rcs0:
    - shard-tglb:         [FAIL][128] ([i915#2842]) -> [PASS][129]
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-tglb1/igt@gem_exec_fair@basic-flow@rcs0.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html

  * igt@gem_exec_fair@basic-pace@vecs0:
    - shard-kbl:          [SKIP][130] ([fdo#109271]) -> [PASS][131] +1 similar issue
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-kbl3/igt@gem_exec_fair@basic-pace@vecs0.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-iclb:         [FAIL][132] ([i915#2849]) -> [PASS][133]
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_exec_reloc@basic-parallel:
    - shard-tglb:         [TIMEOUT][134] ([i915#3737]) -> [PASS][135]
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-tglb7/igt@gem_exec_reloc@basic-parallel.html
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-tglb5/igt@gem_exec_reloc@basic-parallel.html

  * igt@gem_exec_whisper@basic-queues:
    - shard-glk:          [DMESG-WARN][136] ([i915#118] / [i915#95]) -> [PASS][137]
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-glk3/igt@gem_exec_whisper@basic-queues.html
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-glk9/igt@gem_exec_whisper@basic-queues.html

  * igt@gem_mmap_gtt@cpuset-big-copy-odd:
    - shard-iclb:         [FAIL][138] ([i915#2428]) -> [PASS][139]
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-iclb6/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/shard-iclb4/igt@gem_mmap_gtt@cpuset-big-copy-odd.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-apl:          [SKIP][140] ([fdo#109271]) -> [PASS][141]
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10306/shard-ap

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5985/index.html

[-- Attachment #1.2: Type: text/html, Size: 33864 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc in coverage-vs-premult-vs-none for 6bpc panels

[Vidya Srinivas]

Intel Gen11 6bpc panels are giving CRC mismatch in coverage-vs-premult-vs-none
6bpc panel has dithering ON and CRC test with dithering ON might result in
mismatch. Hence, skipping CRC assertion for 6bpc panels.

Credits-to: Uma Shankar <uma.shankar@intel.com>
Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 39 +++++++++++++++++++++++++++++++++--
 1 file changed, 37 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..536d96546608 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -25,6 +25,7 @@
  */
 
 #include "igt.h"
+#include <string.h>
 
 IGT_TEST_DESCRIPTION("Test plane alpha and blending mode properties");
 
@@ -442,10 +443,41 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
 	igt_pipe_crc_stop(data->pipe_crc);
 }
 
+static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
+	char buf[4096];
+	char *str;
+	bool ret;
+	int debugfs_fd;
+	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
+
+	if (!is_i915_device(display->drm_fd))
+		return false;
+
+	drmModeConnector *c = output->config.connector;
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
+		return false;
+
+	debugfs_fd = igt_debugfs_dir(display->drm_fd);
+	if (debugfs_fd < 0)
+		return false;
+
+	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf, sizeof(buf));
+
+	str = strstr(buf, "bpp=");
+	if (str && (strncmp(str, "bpp=18", 6) == 0))
+		ret = true;
+	else
+		ret = false;
+
+	close(debugfs_fd);
+	return ret;
+}
+
 static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)
 {
 	igt_display_t *display = &data->display;
 	igt_crc_t ref_crc = {}, crc = {};
+	bool is6bpc;
 
 	/* Set a background color on the primary fb for testing */
 	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
@@ -461,14 +493,17 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_plane_set_fb(plane, &data->argb_fb_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
-	igt_assert_crc_equal(&ref_crc, &crc);
+
+	if (is_6bpc(display, pipe) == false)
+		igt_assert_crc_equal(&ref_crc, &crc);
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
 	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
-	igt_assert_crc_equal(&ref_crc, &crc);
+	if (is_6bpc(display, pipe) == false)
+		igt_assert_crc_equal(&ref_crc, &crc);
 
 	igt_pipe_crc_stop(data->pipe_crc);
 }
-- 
2.32.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev11)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 3830 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev11)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10309 -> IGTPW_5991
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/index.html

Known issues
------------

  Here are the changes found in IGTPW_5991 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_huc_copy@huc-copy:
    - fi-cfl-8109u:       NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/fi-cfl-8109u/igt@gem_huc_copy@huc-copy.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-cfl-8109u:       NOTRUN -> [SKIP][2] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/fi-cfl-8109u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
    - fi-cfl-8109u:       NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#533])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html

  * igt@kms_psr@primary_mmap_gtt:
    - fi-cfl-8109u:       NOTRUN -> [SKIP][4] ([fdo#109271]) +6 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/fi-cfl-8109u/igt@kms_psr@primary_mmap_gtt.html

  * igt@runner@aborted:
    - fi-cfl-8109u:       NOTRUN -> [FAIL][5] ([i915#2722] / [i915#3363])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/fi-cfl-8109u/igt@runner@aborted.html

  * igt@vgem_basic@unload:
    - fi-cfl-8109u:       NOTRUN -> [INCOMPLETE][6] ([i915#3744])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/fi-cfl-8109u/igt@vgem_basic@unload.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-cfl-8109u:       [INCOMPLETE][7] ([i915#155]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       [FAIL][9] ([i915#1372]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
  [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
  [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
  [i915#3744]: https://gitlab.freedesktop.org/drm/intel/issues/3744
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533


Participating hosts (44 -> 40)
------------------------------

  Missing    (4): fi-ctg-p8600 fi-ilk-m540 fi-bsw-cyan fi-hsw-4200u 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6130 -> IGTPW_5991

  CI-20190529: 20190529
  CI_DRM_10309: 6a5db0d08c45a29cebcfd39b53a15be664b9369c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_5991: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/index.html
  IGT_6130: 390edfb703c346f06b0850db71bd3cc1342a3c02 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/index.html

[-- Attachment #1.2: Type: text/html, Size: 4813 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev11)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 30296 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev11)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10309_full -> IGTPW_5991_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/index.html

Known issues
------------

  Here are the changes found in IGTPW_5991_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@feature_discovery@display-3x:
    - shard-iclb:         NOTRUN -> [SKIP][1] ([i915#1839])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb4/igt@feature_discovery@display-3x.html

  * igt@gem_ctx_persistence@legacy-engines-mixed:
    - shard-snb:          NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +4 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-snb5/igt@gem_ctx_persistence@legacy-engines-mixed.html

  * igt@gem_eio@in-flight-suspend:
    - shard-apl:          NOTRUN -> [DMESG-WARN][3] ([i915#180])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl1/igt@gem_eio@in-flight-suspend.html

  * igt@gem_eio@kms:
    - shard-glk:          [PASS][4] -> [FAIL][5] ([i915#3115])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-glk1/igt@gem_eio@kms.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk4/igt@gem_eio@kms.html

  * igt@gem_exec_fair@basic-none-solo@rcs0:
    - shard-kbl:          NOTRUN -> [FAIL][6] ([i915#2842])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl2/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * igt@gem_exec_fair@basic-none@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][7] ([i915#2842])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb1/igt@gem_exec_fair@basic-none@vcs1.html

  * igt@gem_exec_fair@basic-pace@vcs1:
    - shard-kbl:          [PASS][8] -> [FAIL][9] ([i915#2842]) +1 similar issue
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-kbl6/igt@gem_exec_fair@basic-pace@vcs1.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl6/igt@gem_exec_fair@basic-pace@vcs1.html

  * igt@gem_exec_params@no-blt:
    - shard-iclb:         NOTRUN -> [SKIP][10] ([fdo#109283])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb8/igt@gem_exec_params@no-blt.html

  * igt@gem_exec_reloc@basic-wide-active@rcs0:
    - shard-snb:          NOTRUN -> [FAIL][11] ([i915#3633]) +2 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-snb6/igt@gem_exec_reloc@basic-wide-active@rcs0.html

  * igt@gem_huc_copy@huc-copy:
    - shard-apl:          NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#2190])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl7/igt@gem_huc_copy@huc-copy.html

  * igt@gem_ppgtt@flink-and-close-vma-leak:
    - shard-glk:          [PASS][13] -> [FAIL][14] ([i915#644])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-glk8/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk8/igt@gem_ppgtt@flink-and-close-vma-leak.html

  * igt@gem_pwrite@basic-exhaustion:
    - shard-snb:          NOTRUN -> [WARN][15] ([i915#2658])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-snb5/igt@gem_pwrite@basic-exhaustion.html

  * igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
    - shard-kbl:          NOTRUN -> [SKIP][16] ([fdo#109271]) +139 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl2/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html

  * igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-y-tiled:
    - shard-iclb:         NOTRUN -> [SKIP][17] ([i915#768]) +1 similar issue
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb8/igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-y-tiled.html

  * igt@gem_userptr_blits@unsync-unmap-cycles:
    - shard-iclb:         NOTRUN -> [SKIP][18] ([i915#3297])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb5/igt@gem_userptr_blits@unsync-unmap-cycles.html

  * igt@gen7_exec_parse@chained-batch:
    - shard-iclb:         NOTRUN -> [SKIP][19] ([fdo#109289]) +2 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb6/igt@gen7_exec_parse@chained-batch.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-iclb:         NOTRUN -> [SKIP][20] ([fdo#112306])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb1/igt@gen9_exec_parse@allowed-single.html

  * igt@i915_pm_dc@dc6-psr:
    - shard-iclb:         [PASS][21] -> [DMESG-WARN][22] ([i915#3698])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb2/igt@i915_pm_dc@dc6-psr.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-iclb:         NOTRUN -> [FAIL][23] ([i915#3343])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb5/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
    - shard-glk:          NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#1937])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk1/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-iclb:         NOTRUN -> [WARN][25] ([i915#2684])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@i915_selftest@live@hangcheck:
    - shard-snb:          [PASS][26] -> [INCOMPLETE][27] ([i915#2782])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-snb7/igt@i915_selftest@live@hangcheck.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-snb7/igt@i915_selftest@live@hangcheck.html

  * igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
    - shard-apl:          NOTRUN -> [FAIL][28] ([i915#3745])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl1/igt@kms_addfb_basic@invalid-smem-bo-on-discrete.html

  * igt@kms_big_fb@linear-32bpp-rotate-90:
    - shard-iclb:         NOTRUN -> [SKIP][29] ([fdo#110725] / [fdo#111614]) +1 similar issue
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb2/igt@kms_big_fb@linear-32bpp-rotate-90.html

  * igt@kms_big_fb@yf-tiled-8bpp-rotate-0:
    - shard-iclb:         NOTRUN -> [SKIP][30] ([fdo#110723])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb5/igt@kms_big_fb@yf-tiled-8bpp-rotate-0.html

  * igt@kms_big_joiner@basic:
    - shard-iclb:         NOTRUN -> [SKIP][31] ([i915#2705])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb5/igt@kms_big_joiner@basic.html

  * igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][32] ([i915#3689]) +1 similar issue
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-tglb5/igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_ccs.html

  * igt@kms_cdclk@plane-scaling:
    - shard-iclb:         NOTRUN -> [SKIP][33] ([i915#3742])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb5/igt@kms_cdclk@plane-scaling.html

  * igt@kms_chamelium@hdmi-mode-timings:
    - shard-snb:          NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +16 similar issues
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-snb7/igt@kms_chamelium@hdmi-mode-timings.html

  * igt@kms_color@pipe-d-degamma:
    - shard-iclb:         NOTRUN -> [SKIP][35] ([fdo#109278] / [i915#1149])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb7/igt@kms_color@pipe-d-degamma.html

  * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
    - shard-kbl:          NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +13 similar issues
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl6/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html

  * igt@kms_color_chamelium@pipe-c-ctm-0-25:
    - shard-apl:          NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +21 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl2/igt@kms_color_chamelium@pipe-c-ctm-0-25.html

  * igt@kms_color_chamelium@pipe-c-gamma:
    - shard-iclb:         NOTRUN -> [SKIP][38] ([fdo#109284] / [fdo#111827]) +5 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb5/igt@kms_color_chamelium@pipe-c-gamma.html

  * igt@kms_color_chamelium@pipe-d-ctm-max:
    - shard-tglb:         NOTRUN -> [SKIP][39] ([fdo#109284] / [fdo#111827]) +1 similar issue
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-tglb3/igt@kms_color_chamelium@pipe-d-ctm-max.html
    - shard-glk:          NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +2 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk7/igt@kms_color_chamelium@pipe-d-ctm-max.html
    - shard-iclb:         NOTRUN -> [SKIP][41] ([fdo#109278] / [fdo#109284] / [fdo#111827])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb8/igt@kms_color_chamelium@pipe-d-ctm-max.html

  * igt@kms_content_protection@atomic:
    - shard-kbl:          NOTRUN -> [TIMEOUT][42] ([i915#1319])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl1/igt@kms_content_protection@atomic.html

  * igt@kms_content_protection@content_type_change:
    - shard-iclb:         NOTRUN -> [SKIP][43] ([fdo#109300] / [fdo#111066])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb7/igt@kms_content_protection@content_type_change.html

  * igt@kms_content_protection@dp-mst-lic-type-0:
    - shard-iclb:         NOTRUN -> [SKIP][44] ([i915#3116])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb4/igt@kms_content_protection@dp-mst-lic-type-0.html

  * igt@kms_content_protection@lic:
    - shard-apl:          NOTRUN -> [TIMEOUT][45] ([i915#1319]) +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl1/igt@kms_content_protection@lic.html

  * igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen:
    - shard-iclb:         NOTRUN -> [SKIP][46] ([fdo#109278] / [fdo#109279]) +2 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb3/igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][47] -> [DMESG-WARN][48] ([i915#180]) +6 similar issues
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-c-cursor-512x512-sliding:
    - shard-tglb:         NOTRUN -> [SKIP][49] ([fdo#109279] / [i915#3359])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-tglb5/igt@kms_cursor_crc@pipe-c-cursor-512x512-sliding.html

  * igt@kms_cursor_crc@pipe-d-cursor-64x21-sliding:
    - shard-iclb:         NOTRUN -> [SKIP][50] ([fdo#109278]) +28 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb2/igt@kms_cursor_crc@pipe-d-cursor-64x21-sliding.html

  * igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
    - shard-iclb:         NOTRUN -> [SKIP][51] ([fdo#109274] / [fdo#109278]) +1 similar issue
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb2/igt@kms_cursor_legacy@cursorb-vs-flipb-toggle.html

  * igt@kms_cursor_legacy@pipe-d-single-bo:
    - shard-apl:          NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#533])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl6/igt@kms_cursor_legacy@pipe-d-single-bo.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-apl:          NOTRUN -> [INCOMPLETE][53] ([i915#180] / [i915#1982])
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@2x-plain-flip-ts-check-interruptible:
    - shard-tglb:         NOTRUN -> [SKIP][54] ([fdo#111825]) +7 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-tglb2/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html

  * igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2:
    - shard-glk:          [PASS][55] -> [FAIL][56] ([i915#79]) +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-glk6/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
    - shard-apl:          NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#2672]) +1 similar issue
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

  * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
    - shard-iclb:         NOTRUN -> [SKIP][58] ([i915#2587])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb4/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html

  * igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
    - shard-kbl:          [PASS][59] -> [FAIL][60] ([i915#2546] / [i915#49])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
    - shard-apl:          NOTRUN -> [FAIL][61] ([i915#49])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl6/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
    - shard-glk:          [PASS][62] -> [FAIL][63] ([i915#2546] / [i915#49])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-glk6/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk6/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt:
    - shard-iclb:         NOTRUN -> [SKIP][64] ([fdo#109280]) +23 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb4/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render:
    - shard-glk:          NOTRUN -> [SKIP][65] ([fdo#109271]) +34 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render.html

  * igt@kms_hdr@static-toggle:
    - shard-iclb:         NOTRUN -> [SKIP][66] ([i915#1187]) +1 similar issue
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb4/igt@kms_hdr@static-toggle.html
    - shard-tglb:         NOTRUN -> [SKIP][67] ([i915#1187])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-tglb5/igt@kms_hdr@static-toggle.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
    - shard-kbl:          NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#533]) +1 similar issue
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl7/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
    - shard-glk:          NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#533])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk5/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html

  * igt@kms_plane@plane-position-hole@pipe-a-planes:
    - shard-iclb:         [PASS][70] -> [FAIL][71] ([i915#2472])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-iclb6/igt@kms_plane@plane-position-hole@pipe-a-planes.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb1/igt@kms_plane@plane-position-hole@pipe-a-planes.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
    - shard-apl:          NOTRUN -> [FAIL][72] ([fdo#108145] / [i915#265]) +4 similar issues
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html

  * igt@kms_plane_lowres@pipe-c-tiling-x:
    - shard-iclb:         NOTRUN -> [SKIP][73] ([i915#3536])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb5/igt@kms_plane_lowres@pipe-c-tiling-x.html

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
    - shard-tglb:         NOTRUN -> [SKIP][74] ([fdo#112054])
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-tglb2/igt@kms_plane_multiple@atomic-pipe-c-tiling-yf.html

  * igt@kms_plane_scaling@2x-scaler-multi-pipe:
    - shard-iclb:         NOTRUN -> [SKIP][75] ([fdo#109274]) +6 similar issues
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb3/igt@kms_plane_scaling@2x-scaler-multi-pipe.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
    - shard-iclb:         NOTRUN -> [SKIP][76] ([i915#2920])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
    - shard-kbl:          NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#658]) +1 similar issue
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
    - shard-glk:          NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#658])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk4/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
    - shard-apl:          NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#658]) +4 similar issues
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
    - shard-iclb:         NOTRUN -> [SKIP][80] ([i915#658]) +1 similar issue
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         [PASS][81] -> [SKIP][82] ([fdo#109441]) +1 similar issue
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         NOTRUN -> [SKIP][83] ([fdo#109441]) +2 similar issues
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@kms_sysfs_edid_timing:
    - shard-apl:          NOTRUN -> [FAIL][84] ([IGT#2])
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl7/igt@kms_sysfs_edid_timing.html

  * igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
    - shard-snb:          NOTRUN -> [SKIP][85] ([fdo#109271]) +336 similar issues
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-snb5/igt@kms_universal_plane@disable-primary-vs-flip-pipe-d.html

  * igt@kms_vrr@flipline:
    - shard-iclb:         NOTRUN -> [SKIP][86] ([fdo#109502])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb7/igt@kms_vrr@flipline.html

  * igt@kms_writeback@writeback-check-output:
    - shard-apl:          NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#2437])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl7/igt@kms_writeback@writeback-check-output.html
    - shard-kbl:          NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#2437])
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl1/igt@kms_writeback@writeback-check-output.html

  * igt@kms_writeback@writeback-fb-id:
    - shard-iclb:         NOTRUN -> [SKIP][89] ([i915#2437])
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb8/igt@kms_writeback@writeback-fb-id.html

  * igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame:
    - shard-tglb:         NOTRUN -> [SKIP][90] ([i915#2530])
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-tglb5/igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame.html

  * igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
    - shard-apl:          NOTRUN -> [SKIP][91] ([fdo#109271]) +294 similar issues
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl1/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html

  * igt@nouveau_crc@pipe-c-source-outp-complete:
    - shard-iclb:         NOTRUN -> [SKIP][92] ([i915#2530]) +2 similar issues
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb2/igt@nouveau_crc@pipe-c-source-outp-complete.html

  * igt@perf@buffer-fill:
    - shard-glk:          [PASS][93] -> [DMESG-WARN][94] ([i915#118] / [i915#95]) +2 similar issues
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-glk4/igt@perf@buffer-fill.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk6/igt@perf@buffer-fill.html

  * igt@perf@per-context-mode-unprivileged:
    - shard-tglb:         NOTRUN -> [SKIP][95] ([fdo#109289])
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-tglb2/igt@perf@per-context-mode-unprivileged.html

  * igt@perf@polling-parameterized:
    - shard-glk:          [PASS][96] -> [FAIL][97] ([i915#1542])
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-glk5/igt@perf@polling-parameterized.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk8/igt@perf@polling-parameterized.html

  * igt@prime_nv_pcopy@test3_5:
    - shard-iclb:         NOTRUN -> [SKIP][98] ([fdo#109291]) +1 similar issue
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb2/igt@prime_nv_pcopy@test3_5.html
    - shard-tglb:         NOTRUN -> [SKIP][99] ([fdo#109291])
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-tglb5/igt@prime_nv_pcopy@test3_5.html

  * igt@sysfs_clients@busy:
    - shard-kbl:          NOTRUN -> [SKIP][100] ([fdo#109271] / [i915#2994])
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl6/igt@sysfs_clients@busy.html

  * igt@sysfs_clients@fair-1:
    - shard-apl:          NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#2994]) +2 similar issues
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl6/igt@sysfs_clients@fair-1.html

  * igt@sysfs_clients@pidname:
    - shard-iclb:         NOTRUN -> [SKIP][102] ([i915#2994])
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb8/igt@sysfs_clients@pidname.html

  * igt@vgem_basic@unload:
    - shard-kbl:          NOTRUN -> [INCOMPLETE][103] ([i915#3744])
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl3/igt@vgem_basic@unload.html
    - shard-apl:          NOTRUN -> [INCOMPLETE][104] ([i915#3744])
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl2/igt@vgem_basic@unload.html

  
#### Possible fixes ####

  * igt@core_hotunplug@unbind-rebind:
    - shard-apl:          [DMESG-WARN][105] ([i915#2283]) -> [PASS][106]
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-apl1/igt@core_hotunplug@unbind-rebind.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl7/igt@core_hotunplug@unbind-rebind.html
    - shard-glk:          [DMESG-WARN][107] ([i915#2283]) -> [PASS][108]
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-glk3/igt@core_hotunplug@unbind-rebind.html
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk6/igt@core_hotunplug@unbind-rebind.html
    - shard-kbl:          [DMESG-WARN][109] ([i915#2283]) -> [PASS][110]
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-kbl2/igt@core_hotunplug@unbind-rebind.html
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl4/igt@core_hotunplug@unbind-rebind.html
    - shard-iclb:         [DMESG-WARN][111] ([i915#1602] / [i915#2283]) -> [PASS][112]
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-iclb5/igt@core_hotunplug@unbind-rebind.html
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb1/igt@core_hotunplug@unbind-rebind.html

  * igt@gem_ctx_isolation@preservation-s3@bcs0:
    - shard-kbl:          [DMESG-WARN][113] ([i915#180]) -> [PASS][114] +3 similar issues
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl2/igt@gem_ctx_isolation@preservation-s3@bcs0.html
    - shard-apl:          [DMESG-WARN][115] ([i915#180]) -> [PASS][116] +1 similar issue
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-apl8/igt@gem_ctx_isolation@preservation-s3@bcs0.html
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-apl3/igt@gem_ctx_isolation@preservation-s3@bcs0.html

  * igt@gem_eio@unwedge-stress:
    - shard-tglb:         [TIMEOUT][117] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][118]
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-tglb2/igt@gem_eio@unwedge-stress.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-tglb6/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-glk:          [FAIL][119] ([i915#2846]) -> [PASS][120]
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-glk2/igt@gem_exec_fair@basic-deadline.html
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk1/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none-rrul@rcs0:
    - shard-glk:          [FAIL][121] ([i915#2842]) -> [PASS][122] +1 similar issue
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-glk1/igt@gem_exec_fair@basic-none-rrul@rcs0.html
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk5/igt@gem_exec_fair@basic-none-rrul@rcs0.html

  * igt@gem_exec_fair@basic-pace@vcs0:
    - shard-kbl:          [SKIP][123] ([fdo#109271]) -> [PASS][124]
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-kbl6/igt@gem_exec_fair@basic-pace@vcs0.html
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl6/igt@gem_exec_fair@basic-pace@vcs0.html

  * igt@gem_exec_fair@basic-pace@vcs1:
    - shard-tglb:         [FAIL][125] ([i915#2842]) -> [PASS][126]
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-tglb5/igt@gem_exec_fair@basic-pace@vcs1.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-tglb7/igt@gem_exec_fair@basic-pace@vcs1.html

  * igt@gem_exec_fair@basic-pace@vecs0:
    - shard-iclb:         [FAIL][127] ([i915#2842]) -> [PASS][128]
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-iclb6/igt@gem_exec_fair@basic-pace@vecs0.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb7/igt@gem_exec_fair@basic-pace@vecs0.html

  * igt@i915_pm_dc@dc5-psr:
    - shard-iclb:         [DMESG-WARN][129] ([i915#3698]) -> [PASS][130]
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-iclb5/igt@i915_pm_dc@dc5-psr.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb4/igt@i915_pm_dc@dc5-psr.html

  * igt@kms_big_fb@linear-32bpp-rotate-180:
    - shard-tglb:         [DMESG-WARN][131] ([i915#402]) -> [PASS][132]
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-tglb7/igt@kms_big_fb@linear-32bpp-rotate-180.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-tglb2/igt@kms_big_fb@linear-32bpp-rotate-180.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
    - shard-glk:          [FAIL][133] ([i915#79]) -> [PASS][134]
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html

  * igt@kms_flip@flip-vs-expired-vblank@a-dp1:
    - shard-kbl:          [FAIL][135] ([i915#79]) -> [PASS][136]
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-kbl6/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-kbl2/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [SKIP][137] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][138] +1 similar issue
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-iclb1/igt@kms_psr2_su@frontbuffer.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb2/igt@kms_psr2_su@frontbuffer.html

  
#### Warnings ####

  * igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
    - shard-iclb:         [SKIP][139] ([i915#658]) -> [SKIP][140] ([i915#2920]) +1 similar issue
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-iclb4/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
    - shard-iclb:         [SKIP][141] ([i915#2920]) -> [SKIP][142] ([i915#658]) +1 similar issue
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10309/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/shard-iclb4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html

  * igt@runner@aborted:
    - shard-kbl:          ([FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2283] / [i915#2505] / [i915#3002] / [i915#3363]) -> ([FAI

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5991/index.html

[-- Attachment #1.2: Type: text/html, Size: 33837 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc in coverage-vs-premult-vs-none for 6bpc panels

[Shankar, Uma]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Vidya Srinivas
> Sent: Wednesday, July 7, 2021 9:53 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc in coverage-
> vs-premult-vs-none for 6bpc panels
> 
> Intel Gen11 6bpc panels are giving CRC mismatch in coverage-vs-premult-vs-none
> 6bpc panel has dithering ON and CRC test with dithering ON might result in
> mismatch. Hence, skipping CRC assertion for 6bpc panels.
> 
> Credits-to: Uma Shankar <uma.shankar@intel.com>
> Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 39 +++++++++++++++++++++++++++++++++--
>  1 file changed, 37 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c index
> a37cb27c7d62..536d96546608 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -25,6 +25,7 @@
>   */
> 
>  #include "igt.h"
> +#include <string.h>
> 
>  IGT_TEST_DESCRIPTION("Test plane alpha and blending mode properties");
> 
> @@ -442,10 +443,41 @@ static void coverage_7efc(data_t *data, enum pipe pipe,
> igt_plane_t *plane)
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> 
> +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> +	char buf[4096];
> +	char *str;
> +	bool ret;
> +	int debugfs_fd;
> +	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
> +
> +	if (!is_i915_device(display->drm_fd))
> +		return false;
> +
> +	drmModeConnector *c = output->config.connector;
> +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
> +		return false;
> +
> +	debugfs_fd = igt_debugfs_dir(display->drm_fd);
> +	if (debugfs_fd < 0)
> +		return false;
> +
> +	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> +sizeof(buf));
> +
> +	str = strstr(buf, "bpp=");
> +	if (str && (strncmp(str, "bpp=18", 6) == 0))
> +		ret = true;
> +	else
> +		ret = false;
> +
> +	close(debugfs_fd);
> +	return ret;
> +}
> +
>  static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
> *plane)  {
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> +	bool is6bpc;
> 
>  	/* Set a background color on the primary fb for testing */
>  	if (plane->type != DRM_PLANE_TYPE_PRIMARY) @@ -461,14 +493,17 @@
> static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
>  	igt_plane_set_fb(plane, &data->argb_fb_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
>  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> -	igt_assert_crc_equal(&ref_crc, &crc);
> +

Add a comment here as well explaining the reasoning.

With this added, till we get a better way of reporting current bpc, this looks ok to me in the interim.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>


> +	if (is_6bpc(display, pipe) == false)
> +		igt_assert_crc_equal(&ref_crc, &crc);
> 
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
> "None");
>  	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
>  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> -	igt_assert_crc_equal(&ref_crc, &crc);
> +	if (is_6bpc(display, pipe) == false)
> +		igt_assert_crc_equal(&ref_crc, &crc);
> 
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> --
> 2.32.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Vidya Srinivas]

Intel Gen11 platforms using 6bpc panels have dithering ON
and show CRC mismatch in coverage-vs-premult-vs-none
Doing a crc based test with dithering is not a great idea as pixels
will change due to the 8bit to 6bits truncation with dithering.

This patch skips the CRC assertion for 6bpc panels. Currently, there is no better
way of fetching the bpc info other than EDID or display_info. Currently using
i915_display_info for the same. Hence restricting the check to i915 devices only.

Credits-to: Uma Shankar <uma.shankar@intel.com>
Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 43 +++++++++++++++++++++++++++++++++--
 1 file changed, 41 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..8f5016b83632 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -25,6 +25,7 @@
  */
 
 #include "igt.h"
+#include <string.h>
 
 IGT_TEST_DESCRIPTION("Test plane alpha and blending mode properties");
 
@@ -442,10 +443,41 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
 	igt_pipe_crc_stop(data->pipe_crc);
 }
 
+static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
+	char buf[4096];
+	char *str;
+	bool ret;
+	int debugfs_fd;
+	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
+
+	if (!is_i915_device(display->drm_fd))
+		return false;
+
+	drmModeConnector *c = output->config.connector;
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
+		return false;
+
+	debugfs_fd = igt_debugfs_dir(display->drm_fd);
+	if (debugfs_fd < 0)
+		return false;
+
+	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf, sizeof(buf));
+
+	str = strstr(buf, "bpp=");
+	if (str && (strncmp(str, "bpp=18", 6) == 0))
+		ret = true;
+	else
+		ret = false;
+
+	close(debugfs_fd);
+	return ret;
+}
+
 static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)
 {
 	igt_display_t *display = &data->display;
 	igt_crc_t ref_crc = {}, crc = {};
+	bool is6bpc = false;
 
 	/* Set a background color on the primary fb for testing */
 	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
@@ -461,14 +493,21 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_plane_set_fb(plane, &data->argb_fb_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
-	igt_assert_crc_equal(&ref_crc, &crc);
+
+	/* 6bpc panels have dithering ON and CRC might fail, hence skip crc check */
+	is6bpc = is_6bpc(display, pipe);
+	if (is6bpc == false)
+		igt_assert_crc_equal(&ref_crc, &crc);
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
 	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
-	igt_assert_crc_equal(&ref_crc, &crc);
+
+	/* 6bpc panels have dithering ON and CRC might fail, hence skip crc check */
+	if (is6bpc == false)
+		igt_assert_crc_equal(&ref_crc, &crc);
 
 	igt_pipe_crc_stop(data->pipe_crc);
 }
-- 
2.32.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc in coverage-vs-premult-vs-none for 6bpc panels

[Modem, Bhanuprakash]

> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Vidya
> Srinivas
> Sent: Wednesday, July 7, 2021 9:53 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc in
> coverage-vs-premult-vs-none for 6bpc panels
> 
> Intel Gen11 6bpc panels are giving CRC mismatch in coverage-vs-premult-vs-none
> 6bpc panel has dithering ON and CRC test with dithering ON might result in
> mismatch. Hence, skipping CRC assertion for 6bpc panels.
> 
> Credits-to: Uma Shankar <uma.shankar@intel.com>
> Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 39 +++++++++++++++++++++++++++++++++--
>  1 file changed, 37 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
> index a37cb27c7d62..536d96546608 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -25,6 +25,7 @@
>   */
> 
>  #include "igt.h"
> +#include <string.h>

No need to include string.h

> 
>  IGT_TEST_DESCRIPTION("Test plane alpha and blending mode properties");
> 
> @@ -442,10 +443,41 @@ static void coverage_7efc(data_t *data, enum pipe pipe,
> igt_plane_t *plane)
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> 
> +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> +	char buf[4096];
> +	char *str;
> +	bool ret;
> +	int debugfs_fd;
> +	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
> +
> +	if (!is_i915_device(display->drm_fd))
> +		return false;
> +
> +	drmModeConnector *c = output->config.connector;

This will throw the warning Mixed declarations
 
> +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
> +		return false;
> +
> +	debugfs_fd = igt_debugfs_dir(display->drm_fd);
> +	if (debugfs_fd < 0)
> +		return false;
> +
> +	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> sizeof(buf));
> +
> +	str = strstr(buf, "bpp=");

I think, this approach won't work for all pipes except pipe-A,
i915_display_info looks like below:

[CRTC:80:pipe A]:
	pipe src size=1920x1080, dither=no, bpp=18
[CRTC:131:pipe B]:
	pipe src size=1920x1080, dither=no, bpp=24
[CRTC:182:pipe C]:
	pipe src size=1920x1080, dither=no, bpp=30
[CRTC:233:pipe D]:

We might end-up by reading the pipe-A bpp everytime, even though we
are running test on pipe-B.

And yeah, bpp won't present if pipe is not enabled. I would suggest
to run the test in interactive mode & check the i915_display_info to
make sure at an instance only one pipe is enabled (means only one bpp
available in entire debugfs), otherwise we need to modify the logic to
read the bpp of particular pipe.

./kms_plane_alpha_blend --r coverage-vs-premult-vs-none --interactive

> +	if (str && (strncmp(str, "bpp=18", 6) == 0))
> +		ret = true;
> +	else
> +		ret = false;
> +
> +	close(debugfs_fd);
> +	return ret;
> +}
> +
>  static void coverage_premult_constant(data_t *data, enum pipe pipe,
> igt_plane_t *plane)
>  {
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> +	bool is6bpc;

Unused variable,

> 
>  	/* Set a background color on the primary fb for testing */
>  	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> @@ -461,14 +493,17 @@ static void coverage_premult_constant(data_t *data, enum
> pipe pipe, igt_plane_t
>  	igt_plane_set_fb(plane, &data->argb_fb_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
>  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> -	igt_assert_crc_equal(&ref_crc, &crc);
> +
> +	if (is_6bpc(display, pipe) == false)
> +		igt_assert_crc_equal(&ref_crc, &crc);
> 
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>  	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
>  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> -	igt_assert_crc_equal(&ref_crc, &crc);
> +	if (is_6bpc(display, pipe) == false)
> +		igt_assert_crc_equal(&ref_crc, &crc);

Still, do we need to execute all above stuff? Instead, how about checking
at the beginning of this function & skip?

> 
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> --
> 2.32.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc in coverage-vs-premult-vs-none for 6bpc panels

[Srinivas, Vidya]

Hello Bhanu,

Thank you so much.
I have added a check for eDP only.

As you said, only one pipe at a time which belongs to eDP needs to be enabled. And that is happening.
I have tested with only eDP connected and eDP + DP connected.

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com> 
Sent: Thursday, July 8, 2021 2:45 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc in coverage-vs-premult-vs-none for 6bpc panels

> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of 
> Vidya Srinivas
> Sent: Wednesday, July 7, 2021 9:53 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc 
> in coverage-vs-premult-vs-none for 6bpc panels
> 
> Intel Gen11 6bpc panels are giving CRC mismatch in 
> coverage-vs-premult-vs-none 6bpc panel has dithering ON and CRC test 
> with dithering ON might result in mismatch. Hence, skipping CRC assertion for 6bpc panels.
> 
> Credits-to: Uma Shankar <uma.shankar@intel.com>
> Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 39 
> +++++++++++++++++++++++++++++++++--
>  1 file changed, 37 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..536d96546608 
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -25,6 +25,7 @@
>   */
> 
>  #include "igt.h"
> +#include <string.h>

No need to include string.h

> 
>  IGT_TEST_DESCRIPTION("Test plane alpha and blending mode 
> properties");
> 
> @@ -442,10 +443,41 @@ static void coverage_7efc(data_t *data, enum 
> pipe pipe, igt_plane_t *plane)
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> 
> +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> +	char buf[4096];
> +	char *str;
> +	bool ret;
> +	int debugfs_fd;
> +	igt_output_t *output = igt_get_single_output_for_pipe(display, 
> +pipe);
> +
> +	if (!is_i915_device(display->drm_fd))
> +		return false;
> +
> +	drmModeConnector *c = output->config.connector;

This will throw the warning Mixed declarations
 
> +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
> +		return false;
> +
> +	debugfs_fd = igt_debugfs_dir(display->drm_fd);
> +	if (debugfs_fd < 0)
> +		return false;
> +
> +	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> sizeof(buf));
> +
> +	str = strstr(buf, "bpp=");

I think, this approach won't work for all pipes except pipe-A, i915_display_info looks like below:

[CRTC:80:pipe A]:
	pipe src size=1920x1080, dither=no, bpp=18 [CRTC:131:pipe B]:
	pipe src size=1920x1080, dither=no, bpp=24 [CRTC:182:pipe C]:
	pipe src size=1920x1080, dither=no, bpp=30 [CRTC:233:pipe D]:

We might end-up by reading the pipe-A bpp everytime, even though we are running test on pipe-B.

And yeah, bpp won't present if pipe is not enabled. I would suggest to run the test in interactive mode & check the i915_display_info to make sure at an instance only one pipe is enabled (means only one bpp available in entire debugfs), otherwise we need to modify the logic to read the bpp of particular pipe.

./kms_plane_alpha_blend --r coverage-vs-premult-vs-none --interactive

> +	if (str && (strncmp(str, "bpp=18", 6) == 0))
> +		ret = true;
> +	else
> +		ret = false;
> +
> +	close(debugfs_fd);
> +	return ret;
> +}
> +
>  static void coverage_premult_constant(data_t *data, enum pipe pipe, 
> igt_plane_t *plane)  {
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> +	bool is6bpc;

Unused variable,

> 
>  	/* Set a background color on the primary fb for testing */
>  	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> @@ -461,14 +493,17 @@ static void coverage_premult_constant(data_t *data, enum
> pipe pipe, igt_plane_t
>  	igt_plane_set_fb(plane, &data->argb_fb_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
>  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> -	igt_assert_crc_equal(&ref_crc, &crc);
> +
> +	if (is_6bpc(display, pipe) == false)
> +		igt_assert_crc_equal(&ref_crc, &crc);
> 
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>  	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
>  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> -	igt_assert_crc_equal(&ref_crc, &crc);
> +	if (is_6bpc(display, pipe) == false)
> +		igt_assert_crc_equal(&ref_crc, &crc);

Still, do we need to execute all above stuff? Instead, how about checking
at the beginning of this function & skip?

> 
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> --
> 2.32.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Vidya Srinivas]

Intel Gen11 platforms using 6bpc panels have dithering ON
and show CRC mismatch in coverage-vs-premult-vs-none
Doing a crc based test with dithering is not a great idea as pixels
will change due to the 8bit to 6bits truncation with dithering.

This patch skips the CRC assertion for 6bpc panels. Currently, there is no better
way of fetching the bpc info other than EDID or display_info. Currently using
i915_display_info for the same. Hence restricting the check to i915 devices only.

Credits-to: Uma Shankar <uma.shankar@intel.com>
Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 43 +++++++++++++++++++++++++++++++++--
 1 file changed, 41 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..e450e64cb105 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
 	igt_pipe_crc_stop(data->pipe_crc);
 }
 
+static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
+	char buf[4096];
+	char *str;
+	bool ret;
+	int debugfs_fd;
+	drmModeConnector *c;
+	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
+
+	if (!is_i915_device(display->drm_fd))
+		return false;
+
+	c = output->config.connector;
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
+		return false;
+
+	debugfs_fd = igt_debugfs_dir(display->drm_fd);
+	if (debugfs_fd < 0)
+		return false;
+
+	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf, sizeof(buf));
+
+	str = strstr(buf, "bpp=");
+	if (str && (strncmp(str, "bpp=18", 6) == 0))
+		ret = true;
+	else
+		ret = false;
+
+	close(debugfs_fd);
+	return ret;
+}
+
 static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)
 {
 	igt_display_t *display = &data->display;
 	igt_crc_t ref_crc = {}, crc = {};
+	bool is6bpc = false;
 
 	/* Set a background color on the primary fb for testing */
 	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
@@ -461,14 +493,21 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_plane_set_fb(plane, &data->argb_fb_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
-	igt_assert_crc_equal(&ref_crc, &crc);
+
+	/* 6bpc panels have dithering ON and CRC might fail, hence skip crc check */
+	is6bpc = is_6bpc(display, pipe);
+	if (is6bpc == false)
+		igt_assert_crc_equal(&ref_crc, &crc);
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
 	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
-	igt_assert_crc_equal(&ref_crc, &crc);
+
+	/* 6bpc panels have dithering ON and CRC might fail, hence skip crc check */
+	if (is6bpc == false)
+		igt_assert_crc_equal(&ref_crc, &crc);
 
 	igt_pipe_crc_stop(data->pipe_crc);
 }
-- 
2.32.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Modem, Bhanuprakash]

> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Vidya
> Srinivas
> Sent: Thursday, July 8, 2021 3:01 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc
> assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Intel Gen11 platforms using 6bpc panels have dithering ON
> and show CRC mismatch in coverage-vs-premult-vs-none
> Doing a crc based test with dithering is not a great idea as pixels
> will change due to the 8bit to 6bits truncation with dithering.
> 
> This patch skips the CRC assertion for 6bpc panels. Currently, there is no
> better
> way of fetching the bpc info other than EDID or display_info. Currently using
> i915_display_info for the same. Hence restricting the check to i915 devices
> only.
> 
> Credits-to: Uma Shankar <uma.shankar@intel.com>
> Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 43 +++++++++++++++++++++++++++++++++--
>  1 file changed, 41 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
> index a37cb27c7d62..e450e64cb105 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, enum pipe pipe,
> igt_plane_t *plane)
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> 
> +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> +	char buf[4096];
> +	char *str;
> +	bool ret;
> +	int debugfs_fd;
> +	drmModeConnector *c;
> +	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
> +
> +	if (!is_i915_device(display->drm_fd))
> +		return false;
> +
> +	c = output->config.connector;
> +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
> +		return false;
> +
> +	debugfs_fd = igt_debugfs_dir(display->drm_fd);
> +	if (debugfs_fd < 0)
> +		return false;
> +
> +	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> sizeof(buf));
> +
> +	str = strstr(buf, "bpp=");
> +	if (str && (strncmp(str, "bpp=18", 6) == 0))
> +		ret = true;
> +	else
> +		ret = false;
> +
> +	close(debugfs_fd);
> +	return ret;
> +}
> +
>  static void coverage_premult_constant(data_t *data, enum pipe pipe,
> igt_plane_t *plane)
>  {
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> +	bool is6bpc = false;
> 
>  	/* Set a background color on the primary fb for testing */
>  	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> @@ -461,14 +493,21 @@ static void coverage_premult_constant(data_t *data, enum
> pipe pipe, igt_plane_t
>  	igt_plane_set_fb(plane, &data->argb_fb_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
>  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> -	igt_assert_crc_equal(&ref_crc, &crc);
> +
> +	/* 6bpc panels have dithering ON and CRC might fail, hence skip crc
> check */
> +	is6bpc = is_6bpc(display, pipe);
> +	if (is6bpc == false)
> +		igt_assert_crc_equal(&ref_crc, &crc);

We can SKIP here, right? Also no need to run on remaining planes. Otherwise
IGT will report this test result as PASS instead of reporting as SKIP. 

igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc panels\n");


Also, are we going to skip this test on only gen 11? Then we need a check to
perform such.

if (is_i915_device(fd) && intel_gen(intel_get_drm_devid(fd)) == 11)
	igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc panels\n");

> 
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>  	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
>  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> -	igt_assert_crc_equal(&ref_crc, &crc);
> +
> +	/* 6bpc panels have dithering ON and CRC might fail, hence skip crc
> check */
> +	if (is6bpc == false)
> +		igt_assert_crc_equal(&ref_crc, &crc);
> 
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> --
> 2.32.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev13)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 6412 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev13)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10312 -> IGTPW_5993
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_5993:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@runner@aborted:
    - {fi-tgl-1115g4}:    [FAIL][1] ([i915#2722]) -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/fi-tgl-1115g4/igt@runner@aborted.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-tgl-1115g4/igt@runner@aborted.html

  
Known issues
------------

  Here are the changes found in IGTPW_5993 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@core_hotunplug@unbind-rebind:
    - fi-bdw-5557u:       NOTRUN -> [WARN][3] ([i915#3718])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html

  * igt@gem_exec_suspend@basic-s0:
    - fi-cfl-8109u:       [PASS][4] -> [INCOMPLETE][5] ([i915#155])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html

  * igt@gem_huc_copy@huc-copy:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html

  * igt@gem_tiled_blits@basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][7] ([fdo#109271]) +3 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-kbl-soraka/igt@gem_tiled_blits@basic.html

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#533])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html

  * igt@kms_psr@cursor_plane_move:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][11] ([fdo#109271]) +9 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-bdw-5557u/igt@kms_psr@cursor_plane_move.html

  * igt@runner@aborted:
    - fi-kbl-soraka:      NOTRUN -> [FAIL][12] ([i915#2722] / [i915#3363])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-kbl-soraka/igt@runner@aborted.html

  * igt@vgem_basic@unload:
    - fi-kbl-soraka:      NOTRUN -> [INCOMPLETE][13] ([i915#3744])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-kbl-soraka/igt@vgem_basic@unload.html
    - fi-bdw-5557u:       NOTRUN -> [INCOMPLETE][14] ([i915#3744])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-bdw-5557u/igt@vgem_basic@unload.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-kbl-soraka:      [INCOMPLETE][15] ([i915#155]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       [FAIL][17] ([i915#1372]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

  
#### Warnings ####

  * igt@runner@aborted:
    - fi-bdw-5557u:       [FAIL][19] ([i915#1602] / [i915#2029]) -> [FAIL][20] ([i915#2722])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/fi-bdw-5557u/igt@runner@aborted.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/fi-bdw-5557u/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
  [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
  [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
  [i915#1887]: https://gitlab.freedesktop.org/drm/intel/issues/1887
  [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
  [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
  [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
  [i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718
  [i915#3744]: https://gitlab.freedesktop.org/drm/intel/issues/3744
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533


Participating hosts (41 -> 38)
------------------------------

  Missing    (3): fi-bsw-cyan fi-bdw-samus fi-bsw-n3050 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6130 -> IGTPW_5993

  CI-20190529: 20190529
  CI_DRM_10312: 3fc600de716e7addf36b2cd87416395e5dcf4575 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_5993: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/index.html
  IGT_6130: 390edfb703c346f06b0850db71bd3cc1342a3c02 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/index.html

[-- Attachment #1.2: Type: text/html, Size: 7901 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Srinivas, Vidya]

Hello Bhanu,

No we skip it for all 6bpc. We can skip the test, but as discussed with Uma, I just skip crc check, not the test.
Kindly suggest further.

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com> 
Sent: Thursday, July 8, 2021 4:15 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of 
> Vidya Srinivas
> Sent: Thursday, July 8, 2021 3:01 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc 
> assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Intel Gen11 platforms using 6bpc panels have dithering ON and show CRC 
> mismatch in coverage-vs-premult-vs-none Doing a crc based test with 
> dithering is not a great idea as pixels will change due to the 8bit to 
> 6bits truncation with dithering.
> 
> This patch skips the CRC assertion for 6bpc panels. Currently, there 
> is no better way of fetching the bpc info other than EDID or 
> display_info. Currently using i915_display_info for the same. Hence 
> restricting the check to i915 devices only.
> 
> Credits-to: Uma Shankar <uma.shankar@intel.com>
> Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 43 
> +++++++++++++++++++++++++++++++++--
>  1 file changed, 41 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..e450e64cb105 
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, enum 
> pipe pipe, igt_plane_t *plane)
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> 
> +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> +	char buf[4096];
> +	char *str;
> +	bool ret;
> +	int debugfs_fd;
> +	drmModeConnector *c;
> +	igt_output_t *output = igt_get_single_output_for_pipe(display, 
> +pipe);
> +
> +	if (!is_i915_device(display->drm_fd))
> +		return false;
> +
> +	c = output->config.connector;
> +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
> +		return false;
> +
> +	debugfs_fd = igt_debugfs_dir(display->drm_fd);
> +	if (debugfs_fd < 0)
> +		return false;
> +
> +	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> sizeof(buf));
> +
> +	str = strstr(buf, "bpp=");
> +	if (str && (strncmp(str, "bpp=18", 6) == 0))
> +		ret = true;
> +	else
> +		ret = false;
> +
> +	close(debugfs_fd);
> +	return ret;
> +}
> +
>  static void coverage_premult_constant(data_t *data, enum pipe pipe, 
> igt_plane_t *plane)  {
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> +	bool is6bpc = false;
> 
>  	/* Set a background color on the primary fb for testing */
>  	if (plane->type != DRM_PLANE_TYPE_PRIMARY) @@ -461,14 +493,21 @@ 
> static void coverage_premult_constant(data_t *data, enum pipe pipe, 
> igt_plane_t
>  	igt_plane_set_fb(plane, &data->argb_fb_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
>  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> -	igt_assert_crc_equal(&ref_crc, &crc);
> +
> +	/* 6bpc panels have dithering ON and CRC might fail, hence skip crc
> check */
> +	is6bpc = is_6bpc(display, pipe);
> +	if (is6bpc == false)
> +		igt_assert_crc_equal(&ref_crc, &crc);

We can SKIP here, right? Also no need to run on remaining planes. Otherwise IGT will report this test result as PASS instead of reporting as SKIP. 

igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc panels\n");


Also, are we going to skip this test on only gen 11? Then we need a check to perform such.

if (is_i915_device(fd) && intel_gen(intel_get_drm_devid(fd)) == 11)
	igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc panels\n");

> 
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>  	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
>  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> -	igt_assert_crc_equal(&ref_crc, &crc);
> +
> +	/* 6bpc panels have dithering ON and CRC might fail, hence skip crc
> check */
> +	if (is6bpc == false)
> +		igt_assert_crc_equal(&ref_crc, &crc);
> 
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> --
> 2.32.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Modem, Bhanuprakash]

> From: Srinivas, Vidya <vidya.srinivas@intel.com>
> Sent: Thursday, July 8, 2021 5:03 PM
> To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; igt-
> dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc
> assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Hello Bhanu,
> 
> No we skip it for all 6bpc. We can skip the test, but as discussed with Uma, I
> just skip crc check, not the test.
> Kindly suggest further.

If we remove/skip the crc check, I think there is no point in doing further
commits unless we have kernel checkers.

Uma?

> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> Sent: Thursday, July 8, 2021 4:15 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc
> assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> > Vidya Srinivas
> > Sent: Thursday, July 8, 2021 3:01 PM
> > To: igt-dev@lists.freedesktop.org
> > Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc
> > assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > Intel Gen11 platforms using 6bpc panels have dithering ON and show CRC
> > mismatch in coverage-vs-premult-vs-none Doing a crc based test with
> > dithering is not a great idea as pixels will change due to the 8bit to
> > 6bits truncation with dithering.
> >
> > This patch skips the CRC assertion for 6bpc panels. Currently, there
> > is no better way of fetching the bpc info other than EDID or
> > display_info. Currently using i915_display_info for the same. Hence
> > restricting the check to i915 devices only.
> >
> > Credits-to: Uma Shankar <uma.shankar@intel.com>
> > Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> > Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> > Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> >  tests/kms_plane_alpha_blend.c | 43
> > +++++++++++++++++++++++++++++++++--
> >  1 file changed, 41 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/kms_plane_alpha_blend.c
> > b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..e450e64cb105
> > 100644
> > --- a/tests/kms_plane_alpha_blend.c
> > +++ b/tests/kms_plane_alpha_blend.c
> > @@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, enum
> > pipe pipe, igt_plane_t *plane)
> >  	igt_pipe_crc_stop(data->pipe_crc);
> >  }
> >
> > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> > +	char buf[4096];
> > +	char *str;
> > +	bool ret;
> > +	int debugfs_fd;
> > +	drmModeConnector *c;
> > +	igt_output_t *output = igt_get_single_output_for_pipe(display,
> > +pipe);
> > +
> > +	if (!is_i915_device(display->drm_fd))
> > +		return false;
> > +
> > +	c = output->config.connector;
> > +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
> > +		return false;
> > +
> > +	debugfs_fd = igt_debugfs_dir(display->drm_fd);
> > +	if (debugfs_fd < 0)
> > +		return false;
> > +
> > +	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> > sizeof(buf));
> > +
> > +	str = strstr(buf, "bpp=");
> > +	if (str && (strncmp(str, "bpp=18", 6) == 0))
> > +		ret = true;
> > +	else
> > +		ret = false;
> > +
> > +	close(debugfs_fd);
> > +	return ret;
> > +}
> > +
> >  static void coverage_premult_constant(data_t *data, enum pipe pipe,
> > igt_plane_t *plane)  {
> >  	igt_display_t *display = &data->display;
> >  	igt_crc_t ref_crc = {}, crc = {};
> > +	bool is6bpc = false;
> >
> >  	/* Set a background color on the primary fb for testing */
> >  	if (plane->type != DRM_PLANE_TYPE_PRIMARY) @@ -461,14 +493,21 @@
> > static void coverage_premult_constant(data_t *data, enum pipe pipe,
> > igt_plane_t
> >  	igt_plane_set_fb(plane, &data->argb_fb_7e);
> >  	igt_display_commit2(display, COMMIT_ATOMIC);
> >  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> > -	igt_assert_crc_equal(&ref_crc, &crc);
> > +
> > +	/* 6bpc panels have dithering ON and CRC might fail, hence skip crc
> > check */
> > +	is6bpc = is_6bpc(display, pipe);
> > +	if (is6bpc == false)
> > +		igt_assert_crc_equal(&ref_crc, &crc);
> 
> We can SKIP here, right? Also no need to run on remaining planes. Otherwise
> IGT will report this test result as PASS instead of reporting as SKIP.
> 
> igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc panels\n");
> 
> 
> Also, are we going to skip this test on only gen 11? Then we need a check to
> perform such.
> 
> if (is_i915_device(fd) && intel_gen(intel_get_drm_devid(fd)) == 11)
> 	igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc panels\n");
> 
> >
> >  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
> >  	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
> >  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
> >  	igt_display_commit2(display, COMMIT_ATOMIC);
> >  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> > -	igt_assert_crc_equal(&ref_crc, &crc);
> > +
> > +	/* 6bpc panels have dithering ON and CRC might fail, hence skip crc
> > check */
> > +	if (is6bpc == false)
> > +		igt_assert_crc_equal(&ref_crc, &crc);
> >
> >  	igt_pipe_crc_stop(data->pipe_crc);
> >  }
> > --
> > 2.32.0
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Srinivas, Vidya]

Hi Bhanu,

Sure, I can skip the test as well. Whichever way is okay. The only requirement is atleast one commit has to be done, so that bpp shows up.
Kindly suggest.

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com> 
Sent: Thursday, July 8, 2021 5:51 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org; Shankar, Uma <uma.shankar@intel.com>
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

> From: Srinivas, Vidya <vidya.srinivas@intel.com>
> Sent: Thursday, July 8, 2021 5:03 PM
> To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; igt- 
> dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Hello Bhanu,
> 
> No we skip it for all 6bpc. We can skip the test, but as discussed 
> with Uma, I just skip crc check, not the test.
> Kindly suggest further.

If we remove/skip the crc check, I think there is no point in doing further commits unless we have kernel checkers.

Uma?

> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> Sent: Thursday, July 8, 2021 4:15 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of 
> > Vidya Srinivas
> > Sent: Thursday, July 8, 2021 3:01 PM
> > To: igt-dev@lists.freedesktop.org
> > Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> > crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > Intel Gen11 platforms using 6bpc panels have dithering ON and show 
> > CRC mismatch in coverage-vs-premult-vs-none Doing a crc based test 
> > with dithering is not a great idea as pixels will change due to the 
> > 8bit to 6bits truncation with dithering.
> >
> > This patch skips the CRC assertion for 6bpc panels. Currently, there 
> > is no better way of fetching the bpc info other than EDID or 
> > display_info. Currently using i915_display_info for the same. Hence 
> > restricting the check to i915 devices only.
> >
> > Credits-to: Uma Shankar <uma.shankar@intel.com>
> > Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> > Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> > Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> >  tests/kms_plane_alpha_blend.c | 43
> > +++++++++++++++++++++++++++++++++--
> >  1 file changed, 41 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/kms_plane_alpha_blend.c 
> > b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..e450e64cb105
> > 100644
> > --- a/tests/kms_plane_alpha_blend.c
> > +++ b/tests/kms_plane_alpha_blend.c
> > @@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, enum 
> > pipe pipe, igt_plane_t *plane)
> >  	igt_pipe_crc_stop(data->pipe_crc);
> >  }
> >
> > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> > +	char buf[4096];
> > +	char *str;
> > +	bool ret;
> > +	int debugfs_fd;
> > +	drmModeConnector *c;
> > +	igt_output_t *output = igt_get_single_output_for_pipe(display,
> > +pipe);
> > +
> > +	if (!is_i915_device(display->drm_fd))
> > +		return false;
> > +
> > +	c = output->config.connector;
> > +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
> > +		return false;
> > +
> > +	debugfs_fd = igt_debugfs_dir(display->drm_fd);
> > +	if (debugfs_fd < 0)
> > +		return false;
> > +
> > +	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> > sizeof(buf));
> > +
> > +	str = strstr(buf, "bpp=");
> > +	if (str && (strncmp(str, "bpp=18", 6) == 0))
> > +		ret = true;
> > +	else
> > +		ret = false;
> > +
> > +	close(debugfs_fd);
> > +	return ret;
> > +}
> > +
> >  static void coverage_premult_constant(data_t *data, enum pipe pipe, 
> > igt_plane_t *plane)  {
> >  	igt_display_t *display = &data->display;
> >  	igt_crc_t ref_crc = {}, crc = {};
> > +	bool is6bpc = false;
> >
> >  	/* Set a background color on the primary fb for testing */
> >  	if (plane->type != DRM_PLANE_TYPE_PRIMARY) @@ -461,14 +493,21 @@ 
> > static void coverage_premult_constant(data_t *data, enum pipe pipe, 
> > igt_plane_t
> >  	igt_plane_set_fb(plane, &data->argb_fb_7e);
> >  	igt_display_commit2(display, COMMIT_ATOMIC);
> >  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> > -	igt_assert_crc_equal(&ref_crc, &crc);
> > +
> > +	/* 6bpc panels have dithering ON and CRC might fail, hence skip 
> > +crc
> > check */
> > +	is6bpc = is_6bpc(display, pipe);
> > +	if (is6bpc == false)
> > +		igt_assert_crc_equal(&ref_crc, &crc);
> 
> We can SKIP here, right? Also no need to run on remaining planes. 
> Otherwise IGT will report this test result as PASS instead of reporting as SKIP.
> 
> igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc panels\n");
> 
> 
> Also, are we going to skip this test on only gen 11? Then we need a 
> check to perform such.
> 
> if (is_i915_device(fd) && intel_gen(intel_get_drm_devid(fd)) == 11)
> 	igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc 
> panels\n");
> 
> >
> >  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
> >  	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
> >  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
> >  	igt_display_commit2(display, COMMIT_ATOMIC);
> >  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> > -	igt_assert_crc_equal(&ref_crc, &crc);
> > +
> > +	/* 6bpc panels have dithering ON and CRC might fail, hence skip 
> > +crc
> > check */
> > +	if (is6bpc == false)
> > +		igt_assert_crc_equal(&ref_crc, &crc);
> >
> >  	igt_pipe_crc_stop(data->pipe_crc);
> >  }
> > --
> > 2.32.0
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

[Vidya Srinivas]

Intel platforms using 6bpc panels have dithering ON
and show CRC mismatch in coverage-vs-premult-vs-none
Doing a crc based test with dithering is not a great idea as pixels
will change due to the 8bit to 6bits truncation with dithering.

This patch skips the subtest for 6bpc panels. Currently, there is no better
way of fetching the bpc info other than EDID or display_info. Currently using
i915_display_info for the same. Hence restricting the check to i915 devices only.

Credits-to: Uma Shankar <uma.shankar@intel.com>
Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 39 +++++++++++++++++++++++++++++++++--
 1 file changed, 37 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..6560b37981b6 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
 	igt_pipe_crc_stop(data->pipe_crc);
 }
 
+static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
+	char buf[4096];
+	char *str;
+	bool ret;
+	int debugfs_fd;
+	drmModeConnector *c;
+	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
+
+	if (!is_i915_device(display->drm_fd))
+		return false;
+
+	c = output->config.connector;
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
+		return false;
+
+	debugfs_fd = igt_debugfs_dir(display->drm_fd);
+	if (debugfs_fd < 0)
+		return false;
+
+	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf, sizeof(buf));
+
+	str = strstr(buf, "bpp=");
+	if (str && (strncmp(str, "bpp=18", 6) == 0))
+		ret = true;
+	else
+		ret = false;
+
+	close(debugfs_fd);
+	return ret;
+}
+
 static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)
 {
 	igt_display_t *display = &data->display;
 	igt_crc_t ref_crc = {}, crc = {};
+	bool is6bpc = false;
 
 	/* Set a background color on the primary fb for testing */
 	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
@@ -454,6 +486,11 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
+
+	/* 6bpc panels have dithering ON and CRC might fail, hence skip test */
+	is6bpc = is_6bpc(display, pipe);
+	igt_require(is6bpc == false);
+
 	igt_pipe_crc_start(data->pipe_crc);
 	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
 
@@ -461,14 +498,12 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_plane_set_fb(plane, &data->argb_fb_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
-	igt_assert_crc_equal(&ref_crc, &crc);
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
 	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
-	igt_assert_crc_equal(&ref_crc, &crc);
 
 	igt_pipe_crc_stop(data->pipe_crc);
 }
-- 
2.32.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Srinivas, Vidya]

Hello Bhanu,

I have submitted the patch with skipping test also.
Kindly check, which ever version is okay for merge is fine.
Thank you so much.

https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Thursday, July 8, 2021 6:14 PM
To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; igt-dev@lists.freedesktop.org; Shankar, Uma <uma.shankar@intel.com>
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

Hi Bhanu,

Sure, I can skip the test as well. Whichever way is okay. The only requirement is atleast one commit has to be done, so that bpp shows up.
Kindly suggest.

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
Sent: Thursday, July 8, 2021 5:51 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org; Shankar, Uma <uma.shankar@intel.com>
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

> From: Srinivas, Vidya <vidya.srinivas@intel.com>
> Sent: Thursday, July 8, 2021 5:03 PM
> To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; igt- 
> dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Hello Bhanu,
> 
> No we skip it for all 6bpc. We can skip the test, but as discussed 
> with Uma, I just skip crc check, not the test.
> Kindly suggest further.

If we remove/skip the crc check, I think there is no point in doing further commits unless we have kernel checkers.

Uma?

> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> Sent: Thursday, July 8, 2021 4:15 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of 
> > Vidya Srinivas
> > Sent: Thursday, July 8, 2021 3:01 PM
> > To: igt-dev@lists.freedesktop.org
> > Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> > crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > Intel Gen11 platforms using 6bpc panels have dithering ON and show 
> > CRC mismatch in coverage-vs-premult-vs-none Doing a crc based test 
> > with dithering is not a great idea as pixels will change due to the 
> > 8bit to 6bits truncation with dithering.
> >
> > This patch skips the CRC assertion for 6bpc panels. Currently, there 
> > is no better way of fetching the bpc info other than EDID or 
> > display_info. Currently using i915_display_info for the same. Hence 
> > restricting the check to i915 devices only.
> >
> > Credits-to: Uma Shankar <uma.shankar@intel.com>
> > Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> > Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> > Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> >  tests/kms_plane_alpha_blend.c | 43
> > +++++++++++++++++++++++++++++++++--
> >  1 file changed, 41 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/kms_plane_alpha_blend.c 
> > b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..e450e64cb105
> > 100644
> > --- a/tests/kms_plane_alpha_blend.c
> > +++ b/tests/kms_plane_alpha_blend.c
> > @@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, enum 
> > pipe pipe, igt_plane_t *plane)
> >  	igt_pipe_crc_stop(data->pipe_crc);
> >  }
> >
> > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> > +	char buf[4096];
> > +	char *str;
> > +	bool ret;
> > +	int debugfs_fd;
> > +	drmModeConnector *c;
> > +	igt_output_t *output = igt_get_single_output_for_pipe(display,
> > +pipe);
> > +
> > +	if (!is_i915_device(display->drm_fd))
> > +		return false;
> > +
> > +	c = output->config.connector;
> > +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
> > +		return false;
> > +
> > +	debugfs_fd = igt_debugfs_dir(display->drm_fd);
> > +	if (debugfs_fd < 0)
> > +		return false;
> > +
> > +	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> > sizeof(buf));
> > +
> > +	str = strstr(buf, "bpp=");
> > +	if (str && (strncmp(str, "bpp=18", 6) == 0))
> > +		ret = true;
> > +	else
> > +		ret = false;
> > +
> > +	close(debugfs_fd);
> > +	return ret;
> > +}
> > +
> >  static void coverage_premult_constant(data_t *data, enum pipe pipe, 
> > igt_plane_t *plane)  {
> >  	igt_display_t *display = &data->display;
> >  	igt_crc_t ref_crc = {}, crc = {};
> > +	bool is6bpc = false;
> >
> >  	/* Set a background color on the primary fb for testing */
> >  	if (plane->type != DRM_PLANE_TYPE_PRIMARY) @@ -461,14 +493,21 @@ 
> > static void coverage_premult_constant(data_t *data, enum pipe pipe, 
> > igt_plane_t
> >  	igt_plane_set_fb(plane, &data->argb_fb_7e);
> >  	igt_display_commit2(display, COMMIT_ATOMIC);
> >  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> > -	igt_assert_crc_equal(&ref_crc, &crc);
> > +
> > +	/* 6bpc panels have dithering ON and CRC might fail, hence skip 
> > +crc
> > check */
> > +	is6bpc = is_6bpc(display, pipe);
> > +	if (is6bpc == false)
> > +		igt_assert_crc_equal(&ref_crc, &crc);
> 
> We can SKIP here, right? Also no need to run on remaining planes. 
> Otherwise IGT will report this test result as PASS instead of reporting as SKIP.
> 
> igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc panels\n");
> 
> 
> Also, are we going to skip this test on only gen 11? Then we need a 
> check to perform such.
> 
> if (is_i915_device(fd) && intel_gen(intel_get_drm_devid(fd)) == 11)
> 	igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc 
> panels\n");
> 
> >
> >  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
> >  	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
> >  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
> >  	igt_display_commit2(display, COMMIT_ATOMIC);
> >  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> > -	igt_assert_crc_equal(&ref_crc, &crc);
> > +
> > +	/* 6bpc panels have dithering ON and CRC might fail, hence skip 
> > +crc
> > check */
> > +	if (is6bpc == false)
> > +		igt_assert_crc_equal(&ref_crc, &crc);
> >
> >  	igt_pipe_crc_stop(data->pipe_crc);
> >  }
> > --
> > 2.32.0
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

[Modem, Bhanuprakash]

> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Vidya
> Srinivas
> Sent: Thursday, July 8, 2021 6:16 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-
> vs-premult-vs-none for 6bpc panels
> 
> Intel platforms using 6bpc panels have dithering ON
> and show CRC mismatch in coverage-vs-premult-vs-none
> Doing a crc based test with dithering is not a great idea as pixels
> will change due to the 8bit to 6bits truncation with dithering.
> 
> This patch skips the subtest for 6bpc panels. Currently, there is no better
> way of fetching the bpc info other than EDID or display_info. Currently using
> i915_display_info for the same. Hence restricting the check to i915 devices
> only.
> 
> Credits-to: Uma Shankar <uma.shankar@intel.com>
> Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 39 +++++++++++++++++++++++++++++++++--
>  1 file changed, 37 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
> index a37cb27c7d62..6560b37981b6 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, enum pipe pipe,
> igt_plane_t *plane)
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> 
> +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> +	char buf[4096];

Is this size enough? There is a lot of data available in i915_display_info
and consider the worst case pipe-D

> +	char *str;
> +	bool ret;
> +	int debugfs_fd;
> +	drmModeConnector *c;
> +	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
> +
> +	if (!is_i915_device(display->drm_fd))
> +		return false;
> +
> +	c = output->config.connector;
> +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
> +		return false;
> +
> +	debugfs_fd = igt_debugfs_dir(display->drm_fd);
> +	if (debugfs_fd < 0)
> +		return false;
> +
> +	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> sizeof(buf));
> +
> +	str = strstr(buf, "bpp=");
> +	if (str && (strncmp(str, "bpp=18", 6) == 0))
> +		ret = true;
> +	else
> +		ret = false;
> +
> +	close(debugfs_fd);
> +	return ret;
> +}
> +
>  static void coverage_premult_constant(data_t *data, enum pipe pipe,
> igt_plane_t *plane)
>  {
>  	igt_display_t *display = &data->display;
>  	igt_crc_t ref_crc = {}, crc = {};
> +	bool is6bpc = false;

This local variable is not required

> 
>  	/* Set a background color on the primary fb for testing */
>  	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> @@ -454,6 +486,11 @@ static void coverage_premult_constant(data_t *data, enum
> pipe pipe, igt_plane_t
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
> +
> +	/* 6bpc panels have dithering ON and CRC might fail, hence skip test */
> +	is6bpc = is_6bpc(display, pipe);
> +	igt_require(is6bpc == false);
 
Local variable is not required, you can directly use as below:

igt_require_f(!is_6bpc(display, pipe), "<Some useful message on skip>\n");

> +
>  	igt_pipe_crc_start(data->pipe_crc);
>  	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
> 
> @@ -461,14 +498,12 @@ static void coverage_premult_constant(data_t *data, enum
> pipe pipe, igt_plane_t
>  	igt_plane_set_fb(plane, &data->argb_fb_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
>  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> -	igt_assert_crc_equal(&ref_crc, &crc);

Don't remove crc checks, these are needed for > 6-bpc panels.
For panels with 6-bpc, control will ever reach here.

> 
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
>  	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
>  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> -	igt_assert_crc_equal(&ref_crc, &crc);
 
Same here

> 
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> --
> 2.32.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Shankar, Uma]

> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> Sent: Thursday, July 8, 2021 5:51 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org;
> Shankar, Uma <uma.shankar@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion
> in coverage-vs-premult-vs-none for 6bpc panels
> 
> > From: Srinivas, Vidya <vidya.srinivas@intel.com>
> > Sent: Thursday, July 8, 2021 5:03 PM
> > To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; igt-
> > dev@lists.freedesktop.org
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip
> > crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > Hello Bhanu,
> >
> > No we skip it for all 6bpc. We can skip the test, but as discussed
> > with Uma, I just skip crc check, not the test.
> > Kindly suggest further.
> 
> If we remove/skip the crc check, I think there is no point in doing further commits
> unless we have kernel checkers.
> 
> Uma?

I think it's a compromise here,  skip on 6bpc would be ideal here or we need to have some
passing criterion in order to declare this as pass.

We can do the bpc check after the first commit and skip there itself if we detect 6bpc.This should
be better given the constraints. Also Vidya its good to add MIPI_DSI along with eDP as well since
we have some 6bpc MIPI DSI panels as well. 

> >
> > Regards
> > Vidya
> >
> > -----Original Message-----
> > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > Sent: Thursday, July 8, 2021 4:15 PM
> > To: Srinivas, Vidya <vidya.srinivas@intel.com>;
> > igt-dev@lists.freedesktop.org
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip
> > crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> > > Vidya Srinivas
> > > Sent: Thursday, July 8, 2021 3:01 PM
> > > To: igt-dev@lists.freedesktop.org
> > > Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip
> > > crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> > >
> > > Intel Gen11 platforms using 6bpc panels have dithering ON and show
> > > CRC mismatch in coverage-vs-premult-vs-none Doing a crc based test
> > > with dithering is not a great idea as pixels will change due to the
> > > 8bit to 6bits truncation with dithering.
> > >
> > > This patch skips the CRC assertion for 6bpc panels. Currently, there
> > > is no better way of fetching the bpc info other than EDID or
> > > display_info. Currently using i915_display_info for the same. Hence
> > > restricting the check to i915 devices only.
> > >
> > > Credits-to: Uma Shankar <uma.shankar@intel.com>
> > > Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> > > Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> > > Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > ---
> > >  tests/kms_plane_alpha_blend.c | 43
> > > +++++++++++++++++++++++++++++++++--
> > >  1 file changed, 41 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/tests/kms_plane_alpha_blend.c
> > > b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..e450e64cb105
> > > 100644
> > > --- a/tests/kms_plane_alpha_blend.c
> > > +++ b/tests/kms_plane_alpha_blend.c
> > > @@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, enum
> > > pipe pipe, igt_plane_t *plane)
> > >  	igt_pipe_crc_stop(data->pipe_crc);
> > >  }
> > >
> > > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> > > +	char buf[4096];
> > > +	char *str;
> > > +	bool ret;
> > > +	int debugfs_fd;
> > > +	drmModeConnector *c;
> > > +	igt_output_t *output = igt_get_single_output_for_pipe(display,
> > > +pipe);
> > > +
> > > +	if (!is_i915_device(display->drm_fd))
> > > +		return false;
> > > +
> > > +	c = output->config.connector;
> > > +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
> > > +		return false;
> > > +
> > > +	debugfs_fd = igt_debugfs_dir(display->drm_fd);
> > > +	if (debugfs_fd < 0)
> > > +		return false;
> > > +
> > > +	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> > > sizeof(buf));
> > > +
> > > +	str = strstr(buf, "bpp=");
> > > +	if (str && (strncmp(str, "bpp=18", 6) == 0))
> > > +		ret = true;
> > > +	else
> > > +		ret = false;
> > > +
> > > +	close(debugfs_fd);
> > > +	return ret;
> > > +}
> > > +
> > >  static void coverage_premult_constant(data_t *data, enum pipe pipe,
> > > igt_plane_t *plane)  {
> > >  	igt_display_t *display = &data->display;
> > >  	igt_crc_t ref_crc = {}, crc = {};
> > > +	bool is6bpc = false;
> > >
> > >  	/* Set a background color on the primary fb for testing */
> > >  	if (plane->type != DRM_PLANE_TYPE_PRIMARY) @@ -461,14 +493,21 @@
> > > static void coverage_premult_constant(data_t *data, enum pipe pipe,
> > > igt_plane_t
> > >  	igt_plane_set_fb(plane, &data->argb_fb_7e);
> > >  	igt_display_commit2(display, COMMIT_ATOMIC);
> > >  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> > > -	igt_assert_crc_equal(&ref_crc, &crc);
> > > +
> > > +	/* 6bpc panels have dithering ON and CRC might fail, hence skip
> > > +crc
> > > check */
> > > +	is6bpc = is_6bpc(display, pipe);
> > > +	if (is6bpc == false)
> > > +		igt_assert_crc_equal(&ref_crc, &crc);
> >
> > We can SKIP here, right? Also no need to run on remaining planes.
> > Otherwise IGT will report this test result as PASS instead of reporting as SKIP.
> >
> > igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc panels\n");
> >
> >
> > Also, are we going to skip this test on only gen 11? Then we need a
> > check to perform such.
> >
> > if (is_i915_device(fd) && intel_gen(intel_get_drm_devid(fd)) == 11)
> > 	igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc
> > panels\n");
> >
> > >
> > >  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
> "None");
> > >  	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
> > >  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
> > >  	igt_display_commit2(display, COMMIT_ATOMIC);
> > >  	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> > > -	igt_assert_crc_equal(&ref_crc, &crc);
> > > +
> > > +	/* 6bpc panels have dithering ON and CRC might fail, hence skip
> > > +crc
> > > check */
> > > +	if (is6bpc == false)
> > > +		igt_assert_crc_equal(&ref_crc, &crc);
> > >
> > >  	igt_pipe_crc_stop(data->pipe_crc);
> > >  }
> > > --
> > > 2.32.0
> > >
> > > _______________________________________________
> > > igt-dev mailing list
> > > igt-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev13)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 30296 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev13)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10312_full -> IGTPW_5993_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/index.html

Known issues
------------

  Here are the changes found in IGTPW_5993_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@feature_discovery@display-3x:
    - shard-iclb:         NOTRUN -> [SKIP][1] ([i915#1839])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb2/igt@feature_discovery@display-3x.html

  * igt@gem_create@create-massive:
    - shard-snb:          NOTRUN -> [DMESG-WARN][2] ([i915#3002])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-snb5/igt@gem_create@create-massive.html

  * igt@gem_ctx_persistence@engines-mixed-process:
    - shard-snb:          NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +5 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-snb5/igt@gem_ctx_persistence@engines-mixed-process.html

  * igt@gem_ctx_persistence@many-contexts:
    - shard-tglb:         [PASS][4] -> [FAIL][5] ([i915#2410])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-tglb6/igt@gem_ctx_persistence@many-contexts.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-tglb1/igt@gem_ctx_persistence@many-contexts.html

  * igt@gem_eio@unwedge-stress:
    - shard-tglb:         [PASS][6] -> [TIMEOUT][7] ([i915#2369] / [i915#3063] / [i915#3648])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-tglb3/igt@gem_eio@unwedge-stress.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-tglb6/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-flow@rcs0:
    - shard-tglb:         [PASS][8] -> [FAIL][9] ([i915#2842]) +1 similar issue
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-tglb5/igt@gem_exec_fair@basic-flow@rcs0.html

  * igt@gem_exec_fair@basic-none-solo@rcs0:
    - shard-kbl:          NOTRUN -> [FAIL][10] ([i915#2842])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl6/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-glk:          [PASS][11] -> [FAIL][12] ([i915#2842]) +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-glk7/igt@gem_exec_fair@basic-throttle@rcs0.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-glk9/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_exec_params@no-blt:
    - shard-iclb:         NOTRUN -> [SKIP][13] ([fdo#109283])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb8/igt@gem_exec_params@no-blt.html

  * igt@gem_exec_reloc@basic-wide-active@bcs0:
    - shard-apl:          NOTRUN -> [FAIL][14] ([i915#3633]) +3 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl8/igt@gem_exec_reloc@basic-wide-active@bcs0.html

  * igt@gem_exec_reloc@basic-wide-active@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][15] ([i915#3633])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb4/igt@gem_exec_reloc@basic-wide-active@vcs1.html

  * igt@gem_huc_copy@huc-copy:
    - shard-apl:          NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#2190])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl8/igt@gem_huc_copy@huc-copy.html

  * igt@gem_mmap_gtt@cpuset-big-copy-xy:
    - shard-iclb:         [PASS][17] -> [FAIL][18] ([i915#307])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-iclb2/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb4/igt@gem_mmap_gtt@cpuset-big-copy-xy.html

  * igt@gem_mmap_gtt@cpuset-medium-copy-odd:
    - shard-glk:          [PASS][19] -> [FAIL][20] ([i915#307])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-glk9/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-glk5/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html

  * igt@gem_pread@exhaustion:
    - shard-apl:          NOTRUN -> [WARN][21] ([i915#2658])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl6/igt@gem_pread@exhaustion.html

  * igt@gem_render_copy@linear-to-vebox-yf-tiled:
    - shard-iclb:         NOTRUN -> [SKIP][22] ([i915#768])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb4/igt@gem_render_copy@linear-to-vebox-yf-tiled.html

  * igt@gem_userptr_blits@unsync-unmap-cycles:
    - shard-iclb:         NOTRUN -> [SKIP][23] ([i915#3297])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb7/igt@gem_userptr_blits@unsync-unmap-cycles.html

  * igt@gen7_exec_parse@chained-batch:
    - shard-iclb:         NOTRUN -> [SKIP][24] ([fdo#109289]) +2 similar issues
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb5/igt@gen7_exec_parse@chained-batch.html

  * igt@gen9_exec_parse@batch-invalid-length:
    - shard-snb:          NOTRUN -> [SKIP][25] ([fdo#109271]) +394 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-snb2/igt@gen9_exec_parse@batch-invalid-length.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-iclb:         NOTRUN -> [FAIL][26] ([i915#3343])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb8/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
    - shard-kbl:          NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#1937])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl6/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
    - shard-apl:          NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#1937])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl1/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
    - shard-glk:          NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#1937])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-glk3/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-iclb:         NOTRUN -> [WARN][30] ([i915#2684])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [PASS][31] -> [DMESG-WARN][32] ([i915#180])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-apl3/igt@i915_suspend@sysfs-reader.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl2/igt@i915_suspend@sysfs-reader.html

  * igt@kms_big_fb@linear-32bpp-rotate-180:
    - shard-glk:          [PASS][33] -> [DMESG-WARN][34] ([i915#118] / [i915#95])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-glk4/igt@kms_big_fb@linear-32bpp-rotate-180.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-glk3/igt@kms_big_fb@linear-32bpp-rotate-180.html

  * igt@kms_big_fb@x-tiled-16bpp-rotate-90:
    - shard-iclb:         NOTRUN -> [SKIP][35] ([fdo#110725] / [fdo#111614])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb2/igt@kms_big_fb@x-tiled-16bpp-rotate-90.html

  * igt@kms_big_fb@y-tiled-64bpp-rotate-180:
    - shard-iclb:         [PASS][36] -> [DMESG-WARN][37] ([i915#3621])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-iclb5/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb1/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html

  * igt@kms_big_fb@yf-tiled-8bpp-rotate-0:
    - shard-iclb:         NOTRUN -> [SKIP][38] ([fdo#110723])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb5/igt@kms_big_fb@yf-tiled-8bpp-rotate-0.html

  * igt@kms_big_joiner@basic:
    - shard-iclb:         NOTRUN -> [SKIP][39] ([i915#2705])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb3/igt@kms_big_joiner@basic.html

  * igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][40] ([i915#3689]) +1 similar issue
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-tglb5/igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_ccs.html

  * igt@kms_cdclk@plane-scaling:
    - shard-iclb:         NOTRUN -> [SKIP][41] ([i915#3742])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb1/igt@kms_cdclk@plane-scaling.html

  * igt@kms_chamelium@vga-hpd:
    - shard-apl:          NOTRUN -> [SKIP][42] ([fdo#109271] / [fdo#111827]) +20 similar issues
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl7/igt@kms_chamelium@vga-hpd.html

  * igt@kms_color@pipe-d-degamma:
    - shard-iclb:         NOTRUN -> [SKIP][43] ([fdo#109278] / [i915#1149])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb3/igt@kms_color@pipe-d-degamma.html

  * igt@kms_color_chamelium@pipe-a-ctm-0-25:
    - shard-snb:          NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +14 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-snb7/igt@kms_color_chamelium@pipe-a-ctm-0-25.html

  * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
    - shard-kbl:          NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +10 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl1/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html

  * igt@kms_color_chamelium@pipe-a-ctm-red-to-blue:
    - shard-iclb:         NOTRUN -> [SKIP][46] ([fdo#109284] / [fdo#111827]) +3 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb3/igt@kms_color_chamelium@pipe-a-ctm-red-to-blue.html

  * igt@kms_color_chamelium@pipe-d-ctm-max:
    - shard-tglb:         NOTRUN -> [SKIP][47] ([fdo#109284] / [fdo#111827]) +1 similar issue
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-tglb5/igt@kms_color_chamelium@pipe-d-ctm-max.html
    - shard-glk:          NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827]) +2 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-glk3/igt@kms_color_chamelium@pipe-d-ctm-max.html
    - shard-iclb:         NOTRUN -> [SKIP][49] ([fdo#109278] / [fdo#109284] / [fdo#111827])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb1/igt@kms_color_chamelium@pipe-d-ctm-max.html

  * igt@kms_content_protection@atomic:
    - shard-kbl:          NOTRUN -> [TIMEOUT][50] ([i915#1319])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl3/igt@kms_content_protection@atomic.html

  * igt@kms_content_protection@dp-mst-lic-type-0:
    - shard-iclb:         NOTRUN -> [SKIP][51] ([i915#3116])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb4/igt@kms_content_protection@dp-mst-lic-type-0.html

  * igt@kms_content_protection@lic:
    - shard-apl:          NOTRUN -> [TIMEOUT][52] ([i915#1319]) +2 similar issues
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl6/igt@kms_content_protection@lic.html

  * igt@kms_content_protection@uevent:
    - shard-kbl:          NOTRUN -> [FAIL][53] ([i915#2105])
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl2/igt@kms_content_protection@uevent.html

  * igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen:
    - shard-iclb:         NOTRUN -> [SKIP][54] ([fdo#109278] / [fdo#109279]) +1 similar issue
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb2/igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-512x512-sliding:
    - shard-tglb:         NOTRUN -> [SKIP][55] ([fdo#109279] / [i915#3359])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-512x512-sliding.html

  * igt@kms_cursor_crc@pipe-d-cursor-64x21-sliding:
    - shard-iclb:         NOTRUN -> [SKIP][56] ([fdo#109278]) +22 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb7/igt@kms_cursor_crc@pipe-d-cursor-64x21-sliding.html

  * igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
    - shard-iclb:         NOTRUN -> [SKIP][57] ([fdo#109274] / [fdo#109278])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb1/igt@kms_cursor_legacy@cursorb-vs-flipb-toggle.html

  * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
    - shard-apl:          NOTRUN -> [DMESG-WARN][58] ([i915#180])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html

  * igt@kms_flip@flip-vs-suspend@a-dp1:
    - shard-kbl:          NOTRUN -> [DMESG-WARN][59] ([i915#180])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl2/igt@kms_flip@flip-vs-suspend@a-dp1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
    - shard-apl:          NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2672])
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

  * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
    - shard-iclb:         NOTRUN -> [SKIP][61] ([i915#2587])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render:
    - shard-glk:          [PASS][62] -> [FAIL][63] ([i915#2546] / [i915#49])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-glk4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-pgflip-blt:
    - shard-tglb:         NOTRUN -> [SKIP][64] ([fdo#111825]) +8 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-kbl:          [PASS][65] -> [DMESG-WARN][66] ([i915#180]) +4 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-cpu:
    - shard-iclb:         NOTRUN -> [SKIP][67] ([fdo#109280]) +15 similar issues
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb8/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-cpu.html

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render:
    - shard-glk:          NOTRUN -> [SKIP][68] ([fdo#109271]) +35 similar issues
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-glk8/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
    - shard-kbl:          NOTRUN -> [SKIP][69] ([fdo#109271]) +120 similar issues
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl3/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html

  * igt@kms_hdr@static-toggle:
    - shard-iclb:         NOTRUN -> [SKIP][70] ([i915#1187])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb5/igt@kms_hdr@static-toggle.html
    - shard-tglb:         NOTRUN -> [SKIP][71] ([i915#1187])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-tglb5/igt@kms_hdr@static-toggle.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
    - shard-apl:          NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#533]) +1 similar issue
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl3/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
    - shard-kbl:          NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#533]) +1 similar issue
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl2/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
    - shard-glk:          NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#533])
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-glk2/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
    - shard-apl:          NOTRUN -> [FAIL][75] ([fdo#108145] / [i915#265]) +1 similar issue
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html

  * igt@kms_plane_lowres@pipe-c-tiling-x:
    - shard-iclb:         NOTRUN -> [SKIP][76] ([i915#3536])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb3/igt@kms_plane_lowres@pipe-c-tiling-x.html

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
    - shard-tglb:         NOTRUN -> [SKIP][77] ([fdo#112054])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-tglb5/igt@kms_plane_multiple@atomic-pipe-c-tiling-yf.html

  * igt@kms_plane_scaling@2x-scaler-multi-pipe:
    - shard-iclb:         NOTRUN -> [SKIP][78] ([fdo#109274]) +6 similar issues
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb3/igt@kms_plane_scaling@2x-scaler-multi-pipe.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
    - shard-iclb:         NOTRUN -> [SKIP][79] ([i915#658]) +1 similar issue
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb8/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
    - shard-glk:          NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#658])
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-glk6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
    - shard-apl:          NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#658]) +4 similar issues
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
    - shard-kbl:          NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#658]) +1 similar issue
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html

  * igt@kms_psr@psr2_primary_render:
    - shard-iclb:         [PASS][83] -> [SKIP][84] ([fdo#109441])
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-iclb2/igt@kms_psr@psr2_primary_render.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb5/igt@kms_psr@psr2_primary_render.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         NOTRUN -> [SKIP][85] ([fdo#109441]) +1 similar issue
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@kms_setmode@basic:
    - shard-snb:          NOTRUN -> [FAIL][86] ([i915#31])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-snb7/igt@kms_setmode@basic.html

  * igt@kms_sysfs_edid_timing:
    - shard-apl:          NOTRUN -> [FAIL][87] ([IGT#2])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl7/igt@kms_sysfs_edid_timing.html

  * igt@kms_writeback@writeback-check-output:
    - shard-apl:          NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#2437]) +2 similar issues
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl8/igt@kms_writeback@writeback-check-output.html

  * igt@kms_writeback@writeback-fb-id:
    - shard-iclb:         NOTRUN -> [SKIP][89] ([i915#2437])
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb4/igt@kms_writeback@writeback-fb-id.html

  * igt@kms_writeback@writeback-pixel-formats:
    - shard-kbl:          NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#2437])
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl7/igt@kms_writeback@writeback-pixel-formats.html

  * igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame:
    - shard-tglb:         NOTRUN -> [SKIP][91] ([i915#2530])
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-tglb3/igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame.html

  * igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
    - shard-apl:          NOTRUN -> [SKIP][92] ([fdo#109271]) +247 similar issues
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl6/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html

  * igt@nouveau_crc@pipe-c-ctx-flip-skip-current-frame:
    - shard-iclb:         NOTRUN -> [SKIP][93] ([i915#2530]) +2 similar issues
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb8/igt@nouveau_crc@pipe-c-ctx-flip-skip-current-frame.html

  * igt@perf@per-context-mode-unprivileged:
    - shard-tglb:         NOTRUN -> [SKIP][94] ([fdo#109289])
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-tglb7/igt@perf@per-context-mode-unprivileged.html

  * igt@prime_nv_pcopy@test3_5:
    - shard-iclb:         NOTRUN -> [SKIP][95] ([fdo#109291]) +1 similar issue
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb4/igt@prime_nv_pcopy@test3_5.html
    - shard-tglb:         NOTRUN -> [SKIP][96] ([fdo#109291])
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-tglb2/igt@prime_nv_pcopy@test3_5.html

  * igt@sysfs_clients@fair-7:
    - shard-apl:          NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#2994]) +3 similar issues
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl3/igt@sysfs_clients@fair-7.html

  * igt@sysfs_clients@sema-25:
    - shard-kbl:          NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#2994]) +1 similar issue
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl4/igt@sysfs_clients@sema-25.html

  * igt@vgem_basic@unload:
    - shard-kbl:          NOTRUN -> [INCOMPLETE][99] ([i915#3744])
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl3/igt@vgem_basic@unload.html

  
#### Possible fixes ####

  * igt@core_hotunplug@unbind-rebind:
    - shard-apl:          [DMESG-WARN][100] ([i915#1982] / [i915#2283]) -> [PASS][101]
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-apl2/igt@core_hotunplug@unbind-rebind.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-apl7/igt@core_hotunplug@unbind-rebind.html
    - shard-glk:          [DMESG-WARN][102] ([i915#2283]) -> [PASS][103]
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-glk7/igt@core_hotunplug@unbind-rebind.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-glk6/igt@core_hotunplug@unbind-rebind.html
    - shard-kbl:          [DMESG-WARN][104] ([i915#2283]) -> [PASS][105]
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-kbl7/igt@core_hotunplug@unbind-rebind.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl4/igt@core_hotunplug@unbind-rebind.html
    - shard-iclb:         [DMESG-WARN][106] ([i915#1602] / [i915#2283]) -> [PASS][107]
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-iclb8/igt@core_hotunplug@unbind-rebind.html
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb7/igt@core_hotunplug@unbind-rebind.html

  * igt@gem_eio@unwedge-stress:
    - shard-iclb:         [TIMEOUT][108] ([i915#2369] / [i915#2481] / [i915#3070]) -> [PASS][109]
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-iclb4/igt@gem_eio@unwedge-stress.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb6/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-glk:          [FAIL][110] ([i915#2846]) -> [PASS][111]
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-glk3/igt@gem_exec_fair@basic-deadline.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-glk1/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none-rrul@rcs0:
    - shard-glk:          [FAIL][112] ([i915#2842]) -> [PASS][113] +2 similar issues
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-glk3/igt@gem_exec_fair@basic-none-rrul@rcs0.html
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-glk7/igt@gem_exec_fair@basic-none-rrul@rcs0.html

  * igt@gem_exec_fair@basic-pace-solo@rcs0:
    - shard-iclb:         [FAIL][114] ([i915#2842]) -> [PASS][115] +1 similar issue
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-iclb8/igt@gem_exec_fair@basic-pace-solo@rcs0.html
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb3/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * igt@gem_exec_fair@basic-pace@vcs1:
    - shard-kbl:          [FAIL][116] ([i915#2842]) -> [PASS][117] +1 similar issue
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-kbl2/igt@gem_exec_fair@basic-pace@vcs1.html
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs1.html

  * igt@i915_pm_dc@dc6-psr:
    - shard-iclb:         [FAIL][118] ([i915#454]) -> [PASS][119]
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb6/igt@i915_pm_dc@dc6-psr.html

  * igt@i915_selftest@live@hangcheck:
    - shard-snb:          [INCOMPLETE][120] ([i915#2782]) -> [PASS][121]
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-snb6/igt@i915_selftest@live@hangcheck.html
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-snb7/igt@i915_selftest@live@hangcheck.html

  * igt@kms_big_fb@linear-32bpp-rotate-180:
    - shard-iclb:         [DMESG-WARN][122] ([i915#1226]) -> [PASS][123]
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-iclb6/igt@kms_big_fb@linear-32bpp-rotate-180.html
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb6/igt@kms_big_fb@linear-32bpp-rotate-180.html
    - shard-tglb:         [DMESG-WARN][124] ([i915#402]) -> [PASS][125]
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-tglb7/igt@kms_big_fb@linear-32bpp-rotate-180.html
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-tglb7/igt@kms_big_fb@linear-32bpp-rotate-180.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [DMESG-WARN][126] ([i915#180]) -> [PASS][127] +3 similar issues
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [SKIP][128] ([fdo#109441]) -> [PASS][129]
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

  
#### Warnings ####

  * igt@i915_pm_rc6_residency@rc6-fence:
    - shard-iclb:         [WARN][130] ([i915#1804] / [i915#2684]) -> [WARN][131] ([i915#2684])
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
    - shard-iclb:         [SKIP][132] ([i915#2920]) -> [SKIP][133] ([i915#658]) +2 similar issues
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html

  * igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
    - shard-iclb:         [SKIP][134] ([i915#658]) -> [SKIP][135] ([i915#2920])
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-iclb6/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html

  * igt@runner@aborted:
    - shard-kbl:          ([FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2283] / [i915#2505] / [i915#3002] / [i915#3363]) -> ([FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155]) ([fdo#109271] / [i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#2722] / [i915#3002] / [i915#3363] / [i915#602])
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-kbl2/igt@runner@aborted.html
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-kbl7/igt@runner@aborted.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-kbl1/igt@runner@aborted.html
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-kbl6/igt@runner@aborted.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-kbl2/igt@runner@aborted.html
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-kbl7/igt@runner@aborted.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-kbl4/igt@runner@aborted.html
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-kbl1/igt@runner@aborted.html
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10312/shard-kbl7/igt@runner@aborted.ht

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5993/index.html

[-- Attachment #1.2: Type: text/html, Size: 34386 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

[Vidya Srinivas]

Intel platforms using 6bpc panels have dithering ON
and show CRC mismatch in coverage-vs-premult-vs-none
Doing a crc based test with dithering is not a great idea as pixels
will change due to the 8bit to 6bits truncation with dithering.

This patch skips the subtest for 6bpc panels. Currently, there is no better
way of fetching the bpc info other than EDID or display_info. Currently using
i915_display_info for the same. Hence restricting the check to i915 devices only.

Credits-to: Uma Shankar <uma.shankar@intel.com>
Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 40 +++++++++++++++++++++++++++++++++--
 1 file changed, 38 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..a2baaa2aacf0 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -442,10 +442,43 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
 	igt_pipe_crc_stop(data->pipe_crc);
 }
 
+static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
+	char buf[4096];
+	char *str;
+	bool ret;
+	int debugfs_fd;
+	drmModeConnector *c;
+	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
+
+	if (!is_i915_device(display->drm_fd))
+		return false;
+
+	c = output->config.connector;
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+		c->connector_type != DRM_MODE_CONNECTOR_DSI)
+		return false;
+
+	debugfs_fd = igt_debugfs_dir(display->drm_fd);
+	if (debugfs_fd < 0)
+		return false;
+
+	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf, sizeof(buf));
+
+	str = strstr(buf, "bpp=");
+	if (str && (strncmp(str, "bpp=18", 6) == 0))
+		ret = true;
+	else
+		ret = false;
+
+	close(debugfs_fd);
+	return ret;
+}
+
 static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)
 {
 	igt_display_t *display = &data->display;
 	igt_crc_t ref_crc = {}, crc = {};
+	bool is6bpc = false;
 
 	/* Set a background color on the primary fb for testing */
 	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
@@ -454,6 +487,11 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
+
+	/* 6bpc panels have dithering ON and CRC might fail, hence skip test */
+	is6bpc = is_6bpc(display, pipe);
+	igt_require(is6bpc == false);
+
 	igt_pipe_crc_start(data->pipe_crc);
 	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
 
@@ -461,14 +499,12 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_plane_set_fb(plane, &data->argb_fb_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
-	igt_assert_crc_equal(&ref_crc, &crc);
 
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
 	igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
-	igt_assert_crc_equal(&ref_crc, &crc);
 
 	igt_pipe_crc_stop(data->pipe_crc);
 }
-- 
2.32.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Srinivas, Vidya]

Hello Uma,

Sure, I have already submitted skipping test itself https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14
I will add DSI also the same and re-submit. Thank you so much.

Regards
Vidya

-----Original Message-----
From: Shankar, Uma <uma.shankar@intel.com> 
Sent: Thursday, July 8, 2021 7:05 PM
To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels



> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> Sent: Thursday, July 8, 2021 5:51 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> igt-dev@lists.freedesktop.org; Shankar, Uma <uma.shankar@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> > From: Srinivas, Vidya <vidya.srinivas@intel.com>
> > Sent: Thursday, July 8, 2021 5:03 PM
> > To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; igt- 
> > dev@lists.freedesktop.org
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
> > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > Hello Bhanu,
> >
> > No we skip it for all 6bpc. We can skip the test, but as discussed 
> > with Uma, I just skip crc check, not the test.
> > Kindly suggest further.
> 
> If we remove/skip the crc check, I think there is no point in doing 
> further commits unless we have kernel checkers.
> 
> Uma?

I think it's a compromise here,  skip on 6bpc would be ideal here or we need to have some passing criterion in order to declare this as pass.

We can do the bpc check after the first commit and skip there itself if we detect 6bpc.This should be better given the constraints. Also Vidya its good to add MIPI_DSI along with eDP as well since we have some 6bpc MIPI DSI panels as well. 

> >
> > Regards
> > Vidya
> >
> > -----Original Message-----
> > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > Sent: Thursday, July 8, 2021 4:15 PM
> > To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> > igt-dev@lists.freedesktop.org
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
> > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of 
> > > Vidya Srinivas
> > > Sent: Thursday, July 8, 2021 3:01 PM
> > > To: igt-dev@lists.freedesktop.org
> > > Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> > > crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> > >
> > > Intel Gen11 platforms using 6bpc panels have dithering ON and show 
> > > CRC mismatch in coverage-vs-premult-vs-none Doing a crc based test 
> > > with dithering is not a great idea as pixels will change due to 
> > > the 8bit to 6bits truncation with dithering.
> > >
> > > This patch skips the CRC assertion for 6bpc panels. Currently, 
> > > there is no better way of fetching the bpc info other than EDID or 
> > > display_info. Currently using i915_display_info for the same. 
> > > Hence restricting the check to i915 devices only.
> > >
> > > Credits-to: Uma Shankar <uma.shankar@intel.com>
> > > Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> > > Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> > > Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > ---
> > >  tests/kms_plane_alpha_blend.c | 43
> > > +++++++++++++++++++++++++++++++++--
> > >  1 file changed, 41 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/tests/kms_plane_alpha_blend.c 
> > > b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..e450e64cb105
> > > 100644
> > > --- a/tests/kms_plane_alpha_blend.c
> > > +++ b/tests/kms_plane_alpha_blend.c
> > > @@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, enum 
> > > pipe pipe, igt_plane_t *plane)  igt_pipe_crc_stop(data->pipe_crc);
> > >  }
> > >
> > > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) { 
> > > +char buf[4096]; char *str; bool ret; int debugfs_fd; 
> > > +drmModeConnector *c; igt_output_t *output = 
> > > +igt_get_single_output_for_pipe(display,
> > > +pipe);
> > > +
> > > +if (!is_i915_device(display->drm_fd))
> > > +return false;
> > > +
> > > +c = output->config.connector;
> > > +if (c->connector_type != DRM_MODE_CONNECTOR_eDP) return false;
> > > +
> > > +debugfs_fd = igt_debugfs_dir(display->drm_fd); if (debugfs_fd < 
> > > +0) return false;
> > > +
> > > +igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> > > sizeof(buf));
> > > +
> > > +str = strstr(buf, "bpp=");
> > > +if (str && (strncmp(str, "bpp=18", 6) == 0)) ret = true; else ret 
> > > += false;
> > > +
> > > +close(debugfs_fd);
> > > +return ret;
> > > +}
> > > +
> > >  static void coverage_premult_constant(data_t *data, enum pipe 
> > > pipe, igt_plane_t *plane)  {  igt_display_t *display = 
> > > &data->display;  igt_crc_t ref_crc = {}, crc = {};
> > > +bool is6bpc = false;
> > >
> > >  /* Set a background color on the primary fb for testing */  if 
> > > (plane->type != DRM_PLANE_TYPE_PRIMARY) @@ -461,14 +493,21 @@ 
> > > static void coverage_premult_constant(data_t *data, enum pipe 
> > > pipe, igt_plane_t  igt_plane_set_fb(plane, &data->argb_fb_7e);  
> > > igt_display_commit2(display, COMMIT_ATOMIC);  
> > > igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc); 
> > > -igt_assert_crc_equal(&ref_crc, &crc);
> > > +
> > > +/* 6bpc panels have dithering ON and CRC might fail, hence skip 
> > > +crc
> > > check */
> > > +is6bpc = is_6bpc(display, pipe);
> > > +if (is6bpc == false)
> > > +igt_assert_crc_equal(&ref_crc, &crc);
> >
> > We can SKIP here, right? Also no need to run on remaining planes.
> > Otherwise IGT will report this test result as PASS instead of reporting as SKIP.
> >
> > igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc 
> > panels\n");
> >
> >
> > Also, are we going to skip this test on only gen 11? Then we need a 
> > check to perform such.
> >
> > if (is_i915_device(fd) && intel_gen(intel_get_drm_devid(fd)) == 11) 
> > igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc 
> > panels\n");
> >
> > >
> > >  igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
> "None");
> > >  igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);  
> > > igt_plane_set_fb(plane, &data->argb_fb_cov_7e);  
> > > igt_display_commit2(display, COMMIT_ATOMIC);  
> > > igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc); 
> > > -igt_assert_crc_equal(&ref_crc, &crc);
> > > +
> > > +/* 6bpc panels have dithering ON and CRC might fail, hence skip 
> > > +crc
> > > check */
> > > +if (is6bpc == false)
> > > +igt_assert_crc_equal(&ref_crc, &crc);
> > >
> > >  igt_pipe_crc_stop(data->pipe_crc);
> > >  }
> > > --
> > > 2.32.0
> > >
> > > _______________________________________________
> > > igt-dev mailing list
> > > igt-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/igt-dev


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

[Vidya Srinivas]

Intel platforms using 6bpc panels have dithering ON
and show CRC mismatch in coverage-vs-premult-vs-none
Doing a crc based test with dithering is not a great idea as pixels
will change due to the 8bit to 6bits truncation with dithering.

This patch skips the subtest for 6bpc panels. Currently, there is no better
way of fetching the bpc info other than EDID or display_info. Currently using
i915_display_info for the same. Hence restricting the check to i915 devices only.

Credits-to: Uma Shankar <uma.shankar@intel.com>
Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 36 +++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..eb45dcc16a6d 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -442,6 +442,38 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
 	igt_pipe_crc_stop(data->pipe_crc);
 }
 
+static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
+	char buf[8192];
+	char *str;
+	bool ret;
+	int debugfs_fd;
+	drmModeConnector *c;
+	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
+
+	if (!is_i915_device(display->drm_fd))
+		return false;
+
+	c = output->config.connector;
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+		c->connector_type != DRM_MODE_CONNECTOR_DSI)
+		return false;
+
+	debugfs_fd = igt_debugfs_dir(display->drm_fd);
+	if (debugfs_fd < 0)
+		return false;
+
+	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf, sizeof(buf));
+
+	str = strstr(buf, "bpp=");
+	if (str && (strncmp(str, "bpp=18", 6) == 0))
+		ret = true;
+	else
+		ret = false;
+
+	close(debugfs_fd);
+	return ret;
+}
+
 static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)
 {
 	igt_display_t *display = &data->display;
@@ -454,6 +486,10 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
+
+	/* 6bpc panels have dithering ON and CRC might fail, hence skip test */
+	igt_require(is_6bpc(display, pipe) == false);
+
 	igt_pipe_crc_start(data->pipe_crc);
 	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
 
-- 
2.32.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Srinivas, Vidya]

Hello Uma/Bhanu,

https://patchwork.freedesktop.org/patch/443212/?series=90828&rev=15 I have submitted the patch with adding DSI and skipping the test.
Kindly check and approve if okay.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Thursday, July 8, 2021 7:44 PM
To: Shankar, Uma <uma.shankar@intel.com>; Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; igt-dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

Hello Uma,

Sure, I have already submitted skipping test itself https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14
I will add DSI also the same and re-submit. Thank you so much.

Regards
Vidya

-----Original Message-----
From: Shankar, Uma <uma.shankar@intel.com> 
Sent: Thursday, July 8, 2021 7:05 PM
To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels



> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> Sent: Thursday, July 8, 2021 5:51 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> igt-dev@lists.freedesktop.org; Shankar, Uma <uma.shankar@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> > From: Srinivas, Vidya <vidya.srinivas@intel.com>
> > Sent: Thursday, July 8, 2021 5:03 PM
> > To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; igt- 
> > dev@lists.freedesktop.org
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
> > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > Hello Bhanu,
> >
> > No we skip it for all 6bpc. We can skip the test, but as discussed 
> > with Uma, I just skip crc check, not the test.
> > Kindly suggest further.
> 
> If we remove/skip the crc check, I think there is no point in doing 
> further commits unless we have kernel checkers.
> 
> Uma?

I think it's a compromise here,  skip on 6bpc would be ideal here or we need to have some passing criterion in order to declare this as pass.

We can do the bpc check after the first commit and skip there itself if we detect 6bpc.This should be better given the constraints. Also Vidya its good to add MIPI_DSI along with eDP as well since we have some 6bpc MIPI DSI panels as well. 

> >
> > Regards
> > Vidya
> >
> > -----Original Message-----
> > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > Sent: Thursday, July 8, 2021 4:15 PM
> > To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> > igt-dev@lists.freedesktop.org
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
> > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of 
> > > Vidya Srinivas
> > > Sent: Thursday, July 8, 2021 3:01 PM
> > > To: igt-dev@lists.freedesktop.org
> > > Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> > > crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> > >
> > > Intel Gen11 platforms using 6bpc panels have dithering ON and show 
> > > CRC mismatch in coverage-vs-premult-vs-none Doing a crc based test 
> > > with dithering is not a great idea as pixels will change due to 
> > > the 8bit to 6bits truncation with dithering.
> > >
> > > This patch skips the CRC assertion for 6bpc panels. Currently, 
> > > there is no better way of fetching the bpc info other than EDID or 
> > > display_info. Currently using i915_display_info for the same. 
> > > Hence restricting the check to i915 devices only.
> > >
> > > Credits-to: Uma Shankar <uma.shankar@intel.com>
> > > Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> > > Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> > > Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > ---
> > >  tests/kms_plane_alpha_blend.c | 43
> > > +++++++++++++++++++++++++++++++++--
> > >  1 file changed, 41 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/tests/kms_plane_alpha_blend.c 
> > > b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..e450e64cb105
> > > 100644
> > > --- a/tests/kms_plane_alpha_blend.c
> > > +++ b/tests/kms_plane_alpha_blend.c
> > > @@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, enum 
> > > pipe pipe, igt_plane_t *plane)  igt_pipe_crc_stop(data->pipe_crc);
> > >  }
> > >
> > > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) { 
> > > +char buf[4096]; char *str; bool ret; int debugfs_fd; 
> > > +drmModeConnector *c; igt_output_t *output = 
> > > +igt_get_single_output_for_pipe(display,
> > > +pipe);
> > > +
> > > +if (!is_i915_device(display->drm_fd))
> > > +return false;
> > > +
> > > +c = output->config.connector;
> > > +if (c->connector_type != DRM_MODE_CONNECTOR_eDP) return false;
> > > +
> > > +debugfs_fd = igt_debugfs_dir(display->drm_fd); if (debugfs_fd < 
> > > +0) return false;
> > > +
> > > +igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> > > sizeof(buf));
> > > +
> > > +str = strstr(buf, "bpp=");
> > > +if (str && (strncmp(str, "bpp=18", 6) == 0)) ret = true; else ret 
> > > += false;
> > > +
> > > +close(debugfs_fd);
> > > +return ret;
> > > +}
> > > +
> > >  static void coverage_premult_constant(data_t *data, enum pipe 
> > > pipe, igt_plane_t *plane)  {  igt_display_t *display = 
> > > &data->display;  igt_crc_t ref_crc = {}, crc = {};
> > > +bool is6bpc = false;
> > >
> > >  /* Set a background color on the primary fb for testing */  if 
> > > (plane->type != DRM_PLANE_TYPE_PRIMARY) @@ -461,14 +493,21 @@ 
> > > static void coverage_premult_constant(data_t *data, enum pipe 
> > > pipe, igt_plane_t  igt_plane_set_fb(plane, &data->argb_fb_7e);  
> > > igt_display_commit2(display, COMMIT_ATOMIC);  
> > > igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc); 
> > > -igt_assert_crc_equal(&ref_crc, &crc);
> > > +
> > > +/* 6bpc panels have dithering ON and CRC might fail, hence skip 
> > > +crc
> > > check */
> > > +is6bpc = is_6bpc(display, pipe);
> > > +if (is6bpc == false)
> > > +igt_assert_crc_equal(&ref_crc, &crc);
> >
> > We can SKIP here, right? Also no need to run on remaining planes.
> > Otherwise IGT will report this test result as PASS instead of reporting as SKIP.
> >
> > igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc 
> > panels\n");
> >
> >
> > Also, are we going to skip this test on only gen 11? Then we need a 
> > check to perform such.
> >
> > if (is_i915_device(fd) && intel_gen(intel_get_drm_devid(fd)) == 11) 
> > igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc 
> > panels\n");
> >
> > >
> > >  igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
> "None");
> > >  igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);  
> > > igt_plane_set_fb(plane, &data->argb_fb_cov_7e);  
> > > igt_display_commit2(display, COMMIT_ATOMIC);  
> > > igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc); 
> > > -igt_assert_crc_equal(&ref_crc, &crc);
> > > +
> > > +/* 6bpc panels have dithering ON and CRC might fail, hence skip 
> > > +crc
> > > check */
> > > +if (is6bpc == false)
> > > +igt_assert_crc_equal(&ref_crc, &crc);
> > >
> > >  igt_pipe_crc_stop(data->pipe_crc);
> > >  }
> > > --
> > > 2.32.0
> > >
> > > _______________________________________________
> > > igt-dev mailing list
> > > igt-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/igt-dev


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Modem, Bhanuprakash]

Hi Vidya,

Can you please address the comments in rev 14: https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14


Thanks,
Bhanu

> -----Original Message-----
> From: Srinivas, Vidya <vidya.srinivas@intel.com>
> Sent: Thursday, July 8, 2021 7:49 PM
> To: Shankar, Uma <uma.shankar@intel.com>; Modem, Bhanuprakash
> <bhanuprakash.modem@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc
> assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Hello Uma/Bhanu,
> 
> https://patchwork.freedesktop.org/patch/443212/?series=90828&rev=15 I have
> submitted the patch with adding DSI and skipping the test.
> Kindly check and approve if okay.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Thursday, July 8, 2021 7:44 PM
> To: Shankar, Uma <uma.shankar@intel.com>; Modem, Bhanuprakash
> <Bhanuprakash.Modem@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc
> assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Hello Uma,
> 
> Sure, I have already submitted skipping test itself
> https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14
> I will add DSI also the same and re-submit. Thank you so much.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Shankar, Uma <uma.shankar@intel.com>
> Sent: Thursday, July 8, 2021 7:05 PM
> To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Srinivas, Vidya
> <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc
> assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> 
> 
> > -----Original Message-----
> > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > Sent: Thursday, July 8, 2021 5:51 PM
> > To: Srinivas, Vidya <vidya.srinivas@intel.com>;
> > igt-dev@lists.freedesktop.org; Shankar, Uma <uma.shankar@intel.com>
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip
> > crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > > From: Srinivas, Vidya <vidya.srinivas@intel.com>
> > > Sent: Thursday, July 8, 2021 5:03 PM
> > > To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; igt-
> > > dev@lists.freedesktop.org
> > > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
> > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> > >
> > > Hello Bhanu,
> > >
> > > No we skip it for all 6bpc. We can skip the test, but as discussed
> > > with Uma, I just skip crc check, not the test.
> > > Kindly suggest further.
> >
> > If we remove/skip the crc check, I think there is no point in doing
> > further commits unless we have kernel checkers.
> >
> > Uma?
> 
> I think it's a compromise here,  skip on 6bpc would be ideal here or we need
> to have some passing criterion in order to declare this as pass.
> 
> We can do the bpc check after the first commit and skip there itself if we
> detect 6bpc.This should be better given the constraints. Also Vidya its good
> to add MIPI_DSI along with eDP as well since we have some 6bpc MIPI DSI panels
> as well.
> 
> > >
> > > Regards
> > > Vidya
> > >
> > > -----Original Message-----
> > > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > > Sent: Thursday, July 8, 2021 4:15 PM
> > > To: Srinivas, Vidya <vidya.srinivas@intel.com>;
> > > igt-dev@lists.freedesktop.org
> > > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
> > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> > >
> > > > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> > > > Vidya Srinivas
> > > > Sent: Thursday, July 8, 2021 3:01 PM
> > > > To: igt-dev@lists.freedesktop.org
> > > > Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip
> > > > crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> > > >
> > > > Intel Gen11 platforms using 6bpc panels have dithering ON and show
> > > > CRC mismatch in coverage-vs-premult-vs-none Doing a crc based test
> > > > with dithering is not a great idea as pixels will change due to
> > > > the 8bit to 6bits truncation with dithering.
> > > >
> > > > This patch skips the CRC assertion for 6bpc panels. Currently,
> > > > there is no better way of fetching the bpc info other than EDID or
> > > > display_info. Currently using i915_display_info for the same.
> > > > Hence restricting the check to i915 devices only.
> > > >
> > > > Credits-to: Uma Shankar <uma.shankar@intel.com>
> > > > Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> > > > Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> > > > Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> > > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > > ---
> > > >  tests/kms_plane_alpha_blend.c | 43
> > > > +++++++++++++++++++++++++++++++++--
> > > >  1 file changed, 41 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/tests/kms_plane_alpha_blend.c
> > > > b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..e450e64cb105
> > > > 100644
> > > > --- a/tests/kms_plane_alpha_blend.c
> > > > +++ b/tests/kms_plane_alpha_blend.c
> > > > @@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, enum
> > > > pipe pipe, igt_plane_t *plane)  igt_pipe_crc_stop(data->pipe_crc);
> > > >  }
> > > >
> > > > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> > > > +char buf[4096]; char *str; bool ret; int debugfs_fd;
> > > > +drmModeConnector *c; igt_output_t *output =
> > > > +igt_get_single_output_for_pipe(display,
> > > > +pipe);
> > > > +
> > > > +if (!is_i915_device(display->drm_fd))
> > > > +return false;
> > > > +
> > > > +c = output->config.connector;
> > > > +if (c->connector_type != DRM_MODE_CONNECTOR_eDP) return false;
> > > > +
> > > > +debugfs_fd = igt_debugfs_dir(display->drm_fd); if (debugfs_fd <
> > > > +0) return false;
> > > > +
> > > > +igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> > > > sizeof(buf));
> > > > +
> > > > +str = strstr(buf, "bpp=");
> > > > +if (str && (strncmp(str, "bpp=18", 6) == 0)) ret = true; else ret
> > > > += false;
> > > > +
> > > > +close(debugfs_fd);
> > > > +return ret;
> > > > +}
> > > > +
> > > >  static void coverage_premult_constant(data_t *data, enum pipe
> > > > pipe, igt_plane_t *plane)  {  igt_display_t *display =
> > > > &data->display;  igt_crc_t ref_crc = {}, crc = {};
> > > > +bool is6bpc = false;
> > > >
> > > >  /* Set a background color on the primary fb for testing */  if
> > > > (plane->type != DRM_PLANE_TYPE_PRIMARY) @@ -461,14 +493,21 @@
> > > > static void coverage_premult_constant(data_t *data, enum pipe
> > > > pipe, igt_plane_t  igt_plane_set_fb(plane, &data->argb_fb_7e);
> > > > igt_display_commit2(display, COMMIT_ATOMIC);
> > > > igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> > > > -igt_assert_crc_equal(&ref_crc, &crc);
> > > > +
> > > > +/* 6bpc panels have dithering ON and CRC might fail, hence skip
> > > > +crc
> > > > check */
> > > > +is6bpc = is_6bpc(display, pipe);
> > > > +if (is6bpc == false)
> > > > +igt_assert_crc_equal(&ref_crc, &crc);
> > >
> > > We can SKIP here, right? Also no need to run on remaining planes.
> > > Otherwise IGT will report this test result as PASS instead of reporting as
> SKIP.
> > >
> > > igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc
> > > panels\n");
> > >
> > >
> > > Also, are we going to skip this test on only gen 11? Then we need a
> > > check to perform such.
> > >
> > > if (is_i915_device(fd) && intel_gen(intel_get_drm_devid(fd)) == 11)
> > > igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc
> > > panels\n");
> > >
> > > >
> > > >  igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
> > "None");
> > > >  igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
> > > > igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
> > > > igt_display_commit2(display, COMMIT_ATOMIC);
> > > > igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> > > > -igt_assert_crc_equal(&ref_crc, &crc);
> > > > +
> > > > +/* 6bpc panels have dithering ON and CRC might fail, hence skip
> > > > +crc
> > > > check */
> > > > +if (is6bpc == false)
> > > > +igt_assert_crc_equal(&ref_crc, &crc);
> > > >
> > > >  igt_pipe_crc_stop(data->pipe_crc);
> > > >  }
> > > > --
> > > > 2.32.0
> > > >
> > > > _______________________________________________
> > > > igt-dev mailing list
> > > > igt-dev@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Srinivas, Vidya]

Very sorry Bhanu, I missed seeing your comments before submitting. Apologies. 
Please find them fixed here.

https://patchwork.freedesktop.org/patch/443213/?series=90828&rev=16

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com> 
Sent: Thursday, July 8, 2021 7:51 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; Shankar, Uma <uma.shankar@intel.com>; igt-dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

Hi Vidya,

Can you please address the comments in rev 14: https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14


Thanks,
Bhanu

> -----Original Message-----
> From: Srinivas, Vidya <vidya.srinivas@intel.com>
> Sent: Thursday, July 8, 2021 7:49 PM
> To: Shankar, Uma <uma.shankar@intel.com>; Modem, Bhanuprakash 
> <bhanuprakash.modem@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Hello Uma/Bhanu,
> 
> https://patchwork.freedesktop.org/patch/443212/?series=90828&rev=15 I 
> have submitted the patch with adding DSI and skipping the test.
> Kindly check and approve if okay.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Thursday, July 8, 2021 7:44 PM
> To: Shankar, Uma <uma.shankar@intel.com>; Modem, Bhanuprakash 
> <Bhanuprakash.Modem@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Hello Uma,
> 
> Sure, I have already submitted skipping test itself
> https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14
> I will add DSI also the same and re-submit. Thank you so much.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Shankar, Uma <uma.shankar@intel.com>
> Sent: Thursday, July 8, 2021 7:05 PM
> To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Srinivas, 
> Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> 
> 
> > -----Original Message-----
> > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > Sent: Thursday, July 8, 2021 5:51 PM
> > To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> > igt-dev@lists.freedesktop.org; Shankar, Uma <uma.shankar@intel.com>
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
> > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > > From: Srinivas, Vidya <vidya.srinivas@intel.com>
> > > Sent: Thursday, July 8, 2021 5:03 PM
> > > To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; igt- 
> > > dev@lists.freedesktop.org
> > > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
> > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> > >
> > > Hello Bhanu,
> > >
> > > No we skip it for all 6bpc. We can skip the test, but as discussed 
> > > with Uma, I just skip crc check, not the test.
> > > Kindly suggest further.
> >
> > If we remove/skip the crc check, I think there is no point in doing 
> > further commits unless we have kernel checkers.
> >
> > Uma?
> 
> I think it's a compromise here,  skip on 6bpc would be ideal here or 
> we need to have some passing criterion in order to declare this as pass.
> 
> We can do the bpc check after the first commit and skip there itself 
> if we detect 6bpc.This should be better given the constraints. Also 
> Vidya its good to add MIPI_DSI along with eDP as well since we have 
> some 6bpc MIPI DSI panels as well.
> 
> > >
> > > Regards
> > > Vidya
> > >
> > > -----Original Message-----
> > > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > > Sent: Thursday, July 8, 2021 4:15 PM
> > > To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> > > igt-dev@lists.freedesktop.org
> > > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
> > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> > >
> > > > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf 
> > > > Of Vidya Srinivas
> > > > Sent: Thursday, July 8, 2021 3:01 PM
> > > > To: igt-dev@lists.freedesktop.org
> > > > Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
> > > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc 
> > > > panels
> > > >
> > > > Intel Gen11 platforms using 6bpc panels have dithering ON and 
> > > > show CRC mismatch in coverage-vs-premult-vs-none Doing a crc 
> > > > based test with dithering is not a great idea as pixels will 
> > > > change due to the 8bit to 6bits truncation with dithering.
> > > >
> > > > This patch skips the CRC assertion for 6bpc panels. Currently, 
> > > > there is no better way of fetching the bpc info other than EDID 
> > > > or display_info. Currently using i915_display_info for the same.
> > > > Hence restricting the check to i915 devices only.
> > > >
> > > > Credits-to: Uma Shankar <uma.shankar@intel.com>
> > > > Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> > > > Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> > > > Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> > > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > > ---
> > > >  tests/kms_plane_alpha_blend.c | 43
> > > > +++++++++++++++++++++++++++++++++--
> > > >  1 file changed, 41 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/tests/kms_plane_alpha_blend.c 
> > > > b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..e450e64cb105
> > > > 100644
> > > > --- a/tests/kms_plane_alpha_blend.c
> > > > +++ b/tests/kms_plane_alpha_blend.c
> > > > @@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, 
> > > > enum pipe pipe, igt_plane_t *plane)  
> > > > igt_pipe_crc_stop(data->pipe_crc);
> > > >  }
> > > >
> > > > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) { 
> > > > +char buf[4096]; char *str; bool ret; int debugfs_fd; 
> > > > +drmModeConnector *c; igt_output_t *output = 
> > > > +igt_get_single_output_for_pipe(display,
> > > > +pipe);
> > > > +
> > > > +if (!is_i915_device(display->drm_fd))
> > > > +return false;
> > > > +
> > > > +c = output->config.connector;
> > > > +if (c->connector_type != DRM_MODE_CONNECTOR_eDP) return false;
> > > > +
> > > > +debugfs_fd = igt_debugfs_dir(display->drm_fd); if (debugfs_fd <
> > > > +0) return false;
> > > > +
> > > > +igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> > > > sizeof(buf));
> > > > +
> > > > +str = strstr(buf, "bpp=");
> > > > +if (str && (strncmp(str, "bpp=18", 6) == 0)) ret = true; else 
> > > > +ret = false;
> > > > +
> > > > +close(debugfs_fd);
> > > > +return ret;
> > > > +}
> > > > +
> > > >  static void coverage_premult_constant(data_t *data, enum pipe 
> > > > pipe, igt_plane_t *plane)  {  igt_display_t *display = 
> > > > &data->display;  igt_crc_t ref_crc = {}, crc = {};
> > > > +bool is6bpc = false;
> > > >
> > > >  /* Set a background color on the primary fb for testing */  if 
> > > > (plane->type != DRM_PLANE_TYPE_PRIMARY) @@ -461,14 +493,21 @@ 
> > > > static void coverage_premult_constant(data_t *data, enum pipe 
> > > > pipe, igt_plane_t  igt_plane_set_fb(plane, &data->argb_fb_7e); 
> > > > igt_display_commit2(display, COMMIT_ATOMIC); 
> > > > igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc); 
> > > > -igt_assert_crc_equal(&ref_crc, &crc);
> > > > +
> > > > +/* 6bpc panels have dithering ON and CRC might fail, hence skip 
> > > > +crc
> > > > check */
> > > > +is6bpc = is_6bpc(display, pipe); if (is6bpc == false) 
> > > > +igt_assert_crc_equal(&ref_crc, &crc);
> > >
> > > We can SKIP here, right? Also no need to run on remaining planes.
> > > Otherwise IGT will report this test result as PASS instead of 
> > > reporting as
> SKIP.
> > >
> > > igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc 
> > > panels\n");
> > >
> > >
> > > Also, are we going to skip this test on only gen 11? Then we need 
> > > a check to perform such.
> > >
> > > if (is_i915_device(fd) && intel_gen(intel_get_drm_devid(fd)) == 
> > > 11) igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc 
> > > panels\n");
> > >
> > > >
> > > >  igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
> > "None");
> > > >  igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e); 
> > > > igt_plane_set_fb(plane, &data->argb_fb_cov_7e); 
> > > > igt_display_commit2(display, COMMIT_ATOMIC); 
> > > > igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc); 
> > > > -igt_assert_crc_equal(&ref_crc, &crc);
> > > > +
> > > > +/* 6bpc panels have dithering ON and CRC might fail, hence skip 
> > > > +crc
> > > > check */
> > > > +if (is6bpc == false)
> > > > +igt_assert_crc_equal(&ref_crc, &crc);
> > > >
> > > >  igt_pipe_crc_stop(data->pipe_crc);
> > > >  }
> > > > --
> > > > 2.32.0
> > > >
> > > > _______________________________________________
> > > > igt-dev mailing list
> > > > igt-dev@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev16)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 4865 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev16)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10317 -> IGTPW_5997
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/index.html

Known issues
------------

  Here are the changes found in IGTPW_5997 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_huc_copy@huc-copy:
    - fi-skl-6700k2:      NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/fi-skl-6700k2/igt@gem_huc_copy@huc-copy.html
    - fi-cfl-8109u:       NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/fi-cfl-8109u/igt@gem_huc_copy@huc-copy.html

  * igt@kms_chamelium@dp-hpd-fast:
    - fi-skl-6700k2:      NOTRUN -> [SKIP][3] ([fdo#109271]) +11 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/fi-skl-6700k2/igt@kms_chamelium@dp-hpd-fast.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-cfl-8109u:       NOTRUN -> [SKIP][4] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/fi-cfl-8109u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
    - fi-skl-6700k2:      NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#533])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/fi-skl-6700k2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
    - fi-cfl-8109u:       NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#533])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html

  * igt@kms_psr@primary_mmap_gtt:
    - fi-cfl-8109u:       NOTRUN -> [SKIP][7] ([fdo#109271]) +6 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/fi-cfl-8109u/igt@kms_psr@primary_mmap_gtt.html

  * igt@runner@aborted:
    - fi-cfl-8109u:       NOTRUN -> [FAIL][8] ([i915#2722] / [i915#3363] / [i915#3744])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/fi-cfl-8109u/igt@runner@aborted.html
    - fi-skl-6700k2:      NOTRUN -> [FAIL][9] ([i915#2722] / [i915#3363] / [i915#3744])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/fi-skl-6700k2/igt@runner@aborted.html

  * igt@vgem_basic@unload:
    - fi-skl-6700k2:      NOTRUN -> [INCOMPLETE][10] ([i915#3744])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/fi-skl-6700k2/igt@vgem_basic@unload.html
    - fi-cfl-8109u:       NOTRUN -> [INCOMPLETE][11] ([i915#3744])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/fi-cfl-8109u/igt@vgem_basic@unload.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-cfl-8109u:       [INCOMPLETE][12] ([i915#155]) -> [PASS][13]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html

  * igt@gem_exec_suspend@basic-s3:
    - fi-skl-6700k2:      [INCOMPLETE][14] ([i915#146] / [i915#198]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/fi-skl-6700k2/igt@gem_exec_suspend@basic-s3.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/fi-skl-6700k2/igt@gem_exec_suspend@basic-s3.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
  [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
  [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
  [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
  [i915#3744]: https://gitlab.freedesktop.org/drm/intel/issues/3744
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533


Participating hosts (40 -> 39)
------------------------------

  Missing    (1): fi-bsw-cyan 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6131 -> IGTPW_5997

  CI-20190529: 20190529
  CI_DRM_10317: 505afbd2be5c7d6490a00a079a1d790921344b7a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_5997: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/index.html
  IGT_6131: ed6bf12d6608af1bc25d1cfdfae09f54e5566284 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/index.html

[-- Attachment #1.2: Type: text/html, Size: 6614 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev16)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 30296 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev16)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10317_full -> IGTPW_5997_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/index.html

Known issues
------------

  Here are the changes found in IGTPW_5997_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_persistence@legacy-engines-mixed:
    - shard-snb:          NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099]) +5 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-snb6/igt@gem_ctx_persistence@legacy-engines-mixed.html

  * igt@gem_ctx_shared@q-in-order:
    - shard-snb:          NOTRUN -> [SKIP][2] ([fdo#109271]) +412 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-snb6/igt@gem_ctx_shared@q-in-order.html

  * igt@gem_eio@in-flight-contexts-1us:
    - shard-iclb:         [PASS][3] -> [TIMEOUT][4] ([i915#3070])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-iclb6/igt@gem_eio@in-flight-contexts-1us.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb1/igt@gem_eio@in-flight-contexts-1us.html

  * igt@gem_exec_fair@basic-none-solo@rcs0:
    - shard-kbl:          NOTRUN -> [FAIL][5] ([i915#2842])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl6/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * igt@gem_exec_fair@basic-pace@rcs0:
    - shard-kbl:          [PASS][6] -> [FAIL][7] ([i915#2851])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-kbl3/igt@gem_exec_fair@basic-pace@rcs0.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html

  * igt@gem_exec_fair@basic-pace@vecs0:
    - shard-glk:          [PASS][8] -> [FAIL][9] ([i915#2842]) +2 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-glk3/igt@gem_exec_fair@basic-pace@vecs0.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-glk2/igt@gem_exec_fair@basic-pace@vecs0.html
    - shard-tglb:         [PASS][10] -> [FAIL][11] ([i915#2842]) +1 similar issue
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-tglb2/igt@gem_exec_fair@basic-pace@vecs0.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb7/igt@gem_exec_fair@basic-pace@vecs0.html

  * igt@gem_exec_params@no-blt:
    - shard-tglb:         NOTRUN -> [SKIP][12] ([fdo#109283])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb5/igt@gem_exec_params@no-blt.html
    - shard-iclb:         NOTRUN -> [SKIP][13] ([fdo#109283])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb6/igt@gem_exec_params@no-blt.html

  * igt@gem_fenced_exec_thrash@2-spare-fences:
    - shard-snb:          NOTRUN -> [INCOMPLETE][14] ([i915#2055])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-snb5/igt@gem_fenced_exec_thrash@2-spare-fences.html

  * igt@gem_mmap_offset@clear:
    - shard-iclb:         [PASS][15] -> [FAIL][16] ([i915#3160])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-iclb1/igt@gem_mmap_offset@clear.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb8/igt@gem_mmap_offset@clear.html

  * igt@gem_pwrite@basic-exhaustion:
    - shard-snb:          NOTRUN -> [WARN][17] ([i915#2658])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-snb6/igt@gem_pwrite@basic-exhaustion.html
    - shard-iclb:         NOTRUN -> [WARN][18] ([i915#2658])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb7/igt@gem_pwrite@basic-exhaustion.html
    - shard-kbl:          NOTRUN -> [WARN][19] ([i915#2658])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl4/igt@gem_pwrite@basic-exhaustion.html
    - shard-tglb:         NOTRUN -> [WARN][20] ([i915#2658])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb3/igt@gem_pwrite@basic-exhaustion.html
    - shard-glk:          NOTRUN -> [WARN][21] ([i915#2658])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-glk1/igt@gem_pwrite@basic-exhaustion.html

  * igt@gem_userptr_blits@vma-merge:
    - shard-kbl:          NOTRUN -> [FAIL][22] ([i915#3318])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl7/igt@gem_userptr_blits@vma-merge.html

  * igt@gem_workarounds@suspend-resume-fd:
    - shard-kbl:          [PASS][23] -> [DMESG-WARN][24] ([i915#180]) +2 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-kbl1/igt@gem_workarounds@suspend-resume-fd.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html

  * igt@gen7_exec_parse@basic-allocation:
    - shard-iclb:         NOTRUN -> [SKIP][25] ([fdo#109289])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb3/igt@gen7_exec_parse@basic-allocation.html

  * igt@gen9_exec_parse@bb-large:
    - shard-tglb:         NOTRUN -> [SKIP][26] ([i915#2527])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb5/igt@gen9_exec_parse@bb-large.html
    - shard-glk:          NOTRUN -> [FAIL][27] ([i915#3296])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-glk9/igt@gen9_exec_parse@bb-large.html
    - shard-apl:          NOTRUN -> [FAIL][28] ([i915#3296])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl7/igt@gen9_exec_parse@bb-large.html
    - shard-iclb:         NOTRUN -> [SKIP][29] ([i915#2527])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb1/igt@gen9_exec_parse@bb-large.html

  * igt@i915_pm_dc@dc5-psr:
    - shard-iclb:         [PASS][30] -> [DMESG-WARN][31] ([i915#3698])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-iclb6/igt@i915_pm_dc@dc5-psr.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb4/igt@i915_pm_dc@dc5-psr.html

  * igt@i915_pm_dc@dc6-psr:
    - shard-tglb:         NOTRUN -> [FAIL][32] ([i915#454])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb6/igt@i915_pm_dc@dc6-psr.html

  * igt@i915_selftest@live@gt_lrc:
    - shard-tglb:         NOTRUN -> [DMESG-FAIL][33] ([i915#2373])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb1/igt@i915_selftest@live@gt_lrc.html

  * igt@i915_selftest@live@gt_pm:
    - shard-tglb:         NOTRUN -> [DMESG-FAIL][34] ([i915#1759] / [i915#2291])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb1/igt@i915_selftest@live@gt_pm.html

  * igt@i915_selftest@live@hangcheck:
    - shard-snb:          NOTRUN -> [INCOMPLETE][35] ([i915#2782])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-snb7/igt@i915_selftest@live@hangcheck.html

  * igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
    - shard-apl:          NOTRUN -> [FAIL][36] ([i915#3745])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl8/igt@kms_addfb_basic@invalid-smem-bo-on-discrete.html

  * igt@kms_big_fb@linear-16bpp-rotate-90:
    - shard-apl:          NOTRUN -> [SKIP][37] ([fdo#109271]) +293 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl8/igt@kms_big_fb@linear-16bpp-rotate-90.html

  * igt@kms_big_fb@y-tiled-8bpp-rotate-90:
    - shard-tglb:         NOTRUN -> [SKIP][38] ([fdo#111614])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb3/igt@kms_big_fb@y-tiled-8bpp-rotate-90.html
    - shard-iclb:         NOTRUN -> [SKIP][39] ([fdo#110725] / [fdo#111614])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb7/igt@kms_big_fb@y-tiled-8bpp-rotate-90.html

  * igt@kms_big_fb@yf-tiled-addfb-size-overflow:
    - shard-tglb:         NOTRUN -> [SKIP][40] ([fdo#111615])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb6/igt@kms_big_fb@yf-tiled-addfb-size-overflow.html

  * igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs:
    - shard-kbl:          NOTRUN -> [SKIP][41] ([fdo#109271]) +102 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl1/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs.html

  * igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][42] ([i915#3689]) +3 similar issues
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb1/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html

  * igt@kms_chamelium@hdmi-edid-change-during-suspend:
    - shard-apl:          NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +19 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl1/igt@kms_chamelium@hdmi-edid-change-during-suspend.html

  * igt@kms_color_chamelium@pipe-a-ctm-0-25:
    - shard-snb:          NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +21 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-snb5/igt@kms_color_chamelium@pipe-a-ctm-0-25.html

  * igt@kms_color_chamelium@pipe-a-degamma:
    - shard-kbl:          NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +5 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl6/igt@kms_color_chamelium@pipe-a-degamma.html
    - shard-iclb:         NOTRUN -> [SKIP][46] ([fdo#109284] / [fdo#111827]) +1 similar issue
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb1/igt@kms_color_chamelium@pipe-a-degamma.html

  * igt@kms_color_chamelium@pipe-b-ctm-max:
    - shard-tglb:         NOTRUN -> [SKIP][47] ([fdo#109284] / [fdo#111827]) +1 similar issue
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb2/igt@kms_color_chamelium@pipe-b-ctm-max.html
    - shard-glk:          NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827]) +1 similar issue
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-glk2/igt@kms_color_chamelium@pipe-b-ctm-max.html

  * igt@kms_content_protection@srm:
    - shard-apl:          NOTRUN -> [TIMEOUT][49] ([i915#1319]) +1 similar issue
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl1/igt@kms_content_protection@srm.html

  * igt@kms_content_protection@type1:
    - shard-iclb:         NOTRUN -> [SKIP][50] ([fdo#109300] / [fdo#111066])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb7/igt@kms_content_protection@type1.html
    - shard-tglb:         NOTRUN -> [SKIP][51] ([fdo#111828])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb3/igt@kms_content_protection@type1.html

  * igt@kms_cursor_crc@pipe-a-cursor-512x170-random:
    - shard-tglb:         NOTRUN -> [SKIP][52] ([fdo#109279] / [i915#3359]) +1 similar issue
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb5/igt@kms_cursor_crc@pipe-a-cursor-512x170-random.html

  * igt@kms_cursor_crc@pipe-c-cursor-512x512-offscreen:
    - shard-iclb:         NOTRUN -> [SKIP][53] ([fdo#109278] / [fdo#109279]) +1 similar issue
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb1/igt@kms_cursor_crc@pipe-c-cursor-512x512-offscreen.html

  * igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement:
    - shard-iclb:         NOTRUN -> [SKIP][54] ([fdo#109278]) +17 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb4/igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement.html

  * igt@kms_cursor_crc@pipe-d-cursor-32x10-onscreen:
    - shard-tglb:         NOTRUN -> [SKIP][55] ([i915#3359]) +4 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb7/igt@kms_cursor_crc@pipe-d-cursor-32x10-onscreen.html

  * igt@kms_cursor_legacy@cursorb-vs-flipa-toggle:
    - shard-iclb:         NOTRUN -> [SKIP][56] ([fdo#109274] / [fdo#109278]) +1 similar issue
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb7/igt@kms_cursor_legacy@cursorb-vs-flipa-toggle.html

  * igt@kms_flip@2x-flip-vs-wf_vblank-interruptible:
    - shard-iclb:         NOTRUN -> [SKIP][57] ([fdo#109274]) +1 similar issue
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb2/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
    - shard-kbl:          NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2672]) +1 similar issue
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-pgflip-blt:
    - shard-tglb:         NOTRUN -> [SKIP][59] ([fdo#111825]) +13 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-suspend:
    - shard-glk:          NOTRUN -> [SKIP][60] ([fdo#109271]) +40 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-glk3/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-render:
    - shard-iclb:         NOTRUN -> [SKIP][61] ([fdo#109280]) +9 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb7/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-render.html

  * igt@kms_hdr@bpc-switch-suspend:
    - shard-apl:          NOTRUN -> [DMESG-WARN][62] ([i915#180]) +1 similar issue
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl6/igt@kms_hdr@bpc-switch-suspend.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
    - shard-kbl:          NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#533])
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl4/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html

  * igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
    - shard-apl:          NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#533]) +2 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl3/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
    - shard-apl:          [PASS][65] -> [DMESG-WARN][66] ([i915#180])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-apl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
    - shard-kbl:          NOTRUN -> [FAIL][67] ([fdo#108145] / [i915#265]) +1 similar issue
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl3/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
    - shard-apl:          NOTRUN -> [FAIL][68] ([i915#265])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html

  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
    - shard-apl:          NOTRUN -> [FAIL][69] ([fdo#108145] / [i915#265]) +3 similar issues
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl7/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
    - shard-apl:          NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#658]) +6 similar issues
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5:
    - shard-glk:          NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#658]) +1 similar issue
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-glk8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html
    - shard-tglb:         NOTRUN -> [SKIP][72] ([i915#2920]) +1 similar issue
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
    - shard-kbl:          NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#658]) +3 similar issues
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl4/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
    - shard-iclb:         NOTRUN -> [SKIP][74] ([i915#658]) +1 similar issue
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb5/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html

  * igt@kms_psr@psr2_dpms:
    - shard-iclb:         [PASS][75] -> [SKIP][76] ([fdo#109441]) +1 similar issue
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-iclb2/igt@kms_psr@psr2_dpms.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb7/igt@kms_psr@psr2_dpms.html

  * igt@kms_setmode@basic:
    - shard-snb:          NOTRUN -> [FAIL][77] ([i915#31])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-snb5/igt@kms_setmode@basic.html

  * igt@kms_writeback@writeback-invalid-parameters:
    - shard-apl:          NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#2437])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl1/igt@kms_writeback@writeback-invalid-parameters.html

  * igt@nouveau_crc@pipe-a-source-outp-complete:
    - shard-tglb:         NOTRUN -> [SKIP][79] ([i915#2530])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb2/igt@nouveau_crc@pipe-a-source-outp-complete.html
    - shard-iclb:         NOTRUN -> [SKIP][80] ([i915#2530])
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb3/igt@nouveau_crc@pipe-a-source-outp-complete.html

  * igt@perf@mi-rpc:
    - shard-tglb:         NOTRUN -> [SKIP][81] ([fdo#109289]) +1 similar issue
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb3/igt@perf@mi-rpc.html

  * igt@perf@rc6-disable:
    - shard-tglb:         [PASS][82] -> [SKIP][83] ([fdo#111719])
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-tglb1/igt@perf@rc6-disable.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb5/igt@perf@rc6-disable.html

  * igt@prime_nv_test@i915_blt_fill_nv_read:
    - shard-tglb:         NOTRUN -> [SKIP][84] ([fdo#109291])
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb3/igt@prime_nv_test@i915_blt_fill_nv_read.html
    - shard-iclb:         NOTRUN -> [SKIP][85] ([fdo#109291])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb7/igt@prime_nv_test@i915_blt_fill_nv_read.html

  * igt@sysfs_clients@recycle-many:
    - shard-apl:          NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#2994]) +3 similar issues
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl3/igt@sysfs_clients@recycle-many.html

  * igt@sysfs_clients@sema-50:
    - shard-kbl:          NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#2994]) +1 similar issue
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl7/igt@sysfs_clients@sema-50.html

  
#### Possible fixes ####

  * igt@gem_eio@unwedge-stress:
    - shard-tglb:         [TIMEOUT][88] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][89]
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-tglb6/igt@gem_eio@unwedge-stress.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb7/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-flow@rcs0:
    - shard-tglb:         [FAIL][90] ([i915#2842]) -> [PASS][91] +1 similar issue
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-tglb2/igt@gem_exec_fair@basic-flow@rcs0.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-glk:          [FAIL][92] ([i915#2842]) -> [PASS][93] +1 similar issue
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-glk8/igt@gem_exec_fair@basic-throttle@rcs0.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-glk1/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_exec_whisper@basic-normal-all:
    - shard-glk:          [DMESG-WARN][94] ([i915#118] / [i915#95]) -> [PASS][95] +1 similar issue
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-glk1/igt@gem_exec_whisper@basic-normal-all.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-glk8/igt@gem_exec_whisper@basic-normal-all.html

  * igt@gem_huc_copy@huc-copy:
    - shard-tglb:         [SKIP][96] ([i915#2190]) -> [PASS][97]
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-tglb6/igt@gem_huc_copy@huc-copy.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb7/igt@gem_huc_copy@huc-copy.html

  * igt@gem_vm_create@destroy-race:
    - shard-tglb:         [FAIL][98] ([i915#2822]) -> [PASS][99]
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-tglb5/igt@gem_vm_create@destroy-race.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb5/igt@gem_vm_create@destroy-race.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-apl:          [SKIP][100] ([fdo#109271]) -> [PASS][101]
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-apl1/igt@i915_pm_dc@dc9-dpms.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl1/igt@i915_pm_dc@dc9-dpms.html

  * igt@kms_big_fb@linear-32bpp-rotate-180:
    - shard-iclb:         [DMESG-WARN][102] ([i915#3621]) -> [PASS][103]
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-iclb1/igt@kms_big_fb@linear-32bpp-rotate-180.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb1/igt@kms_big_fb@linear-32bpp-rotate-180.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-kbl:          [DMESG-WARN][104] ([i915#180]) -> [PASS][105] +2 similar issues
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_cursor_edge_walk@pipe-a-64x64-left-edge:
    - shard-tglb:         [DMESG-WARN][106] ([i915#2868]) -> [PASS][107]
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-tglb5/igt@kms_cursor_edge_walk@pipe-a-64x64-left-edge.html
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-tglb7/igt@kms_cursor_edge_walk@pipe-a-64x64-left-edge.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-blt:
    - shard-glk:          [FAIL][108] ([i915#2546] / [i915#49]) -> [PASS][109]
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-glk9/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-blt.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-blt.html

  * igt@kms_psr2_su@page_flip:
    - shard-iclb:         [SKIP][110] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][111]
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-iclb5/igt@kms_psr2_su@page_flip.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb2/igt@kms_psr2_su@page_flip.html

  * igt@kms_psr@psr2_sprite_plane_onoff:
    - shard-iclb:         [SKIP][112] ([fdo#109441]) -> [PASS][113] +1 similar issue
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-iclb1/igt@kms_psr@psr2_sprite_plane_onoff.html
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html

  * igt@kms_vblank@pipe-c-ts-continuation-suspend:
    - shard-apl:          [DMESG-WARN][114] ([i915#180]) -> [PASS][115]
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-apl1/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl3/igt@kms_vblank@pipe-c-ts-continuation-suspend.html

  
#### Warnings ####

  * igt@gem_exec_fair@basic-pace@vecs0:
    - shard-kbl:          [FAIL][116] ([i915#2842]) -> [SKIP][117] ([fdo#109271])
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-kbl3/igt@gem_exec_fair@basic-pace@vecs0.html
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-iclb:         [WARN][118] ([i915#1804] / [i915#2684]) -> [WARN][119] ([i915#2684])
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [DMESG-WARN][120] ([i915#1226]) -> [SKIP][121] ([fdo#109349])
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb6/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
    - shard-iclb:         [SKIP][122] ([i915#2920]) -> [SKIP][123] ([i915#658]) +1 similar issue
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html

  * igt@runner@aborted:
    - shard-kbl:          ([FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#2722] / [i915#3002] / [i915#3363] / [i915#3744]) -> ([FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134]) ([i915#180] / [i915#2722] / [i915#3002] / [i915#3363] / [i915#3744])
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-kbl3/igt@runner@aborted.html
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-kbl3/igt@runner@aborted.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-kbl3/igt@runner@aborted.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-kbl6/igt@runner@aborted.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-kbl4/igt@runner@aborted.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-kbl2/igt@runner@aborted.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl3/igt@runner@aborted.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl3/igt@runner@aborted.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl1/igt@runner@aborted.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl4/igt@runner@aborted.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-kbl3/igt@runner@aborted.html
    - shard-iclb:         ([FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138]) ([i915#1814] / [i915#2722] / [i915#3002] / [i915#3744]) -> ([FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142]) ([i915#2722] / [i915#3002] / [i915#3702] / [i915#3744])
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-iclb7/igt@runner@aborted.html
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-iclb8/igt@runner@aborted.html
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-iclb6/igt@runner@aborted.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-iclb1/igt@runner@aborted.html
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb2/igt@runner@aborted.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb3/igt@runner@aborted.html
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb8/igt@runner@aborted.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-iclb4/igt@runner@aborted.html
    - shard-apl:          ([FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146]) ([i915#180] / [i915#1814] / [i915#2722] / [i915#3002] / [i915#3363] / [i915#3744]) -> ([FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#2722] / [i915#3002] / [i915#3363] / [i915#3744])
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-apl1/igt@runner@aborted.html
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-apl6/igt@runner@aborted.html
   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-apl2/igt@runner@aborted.html
   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10317/shard-apl7/igt@runner@aborted.html
   [147]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl1/igt@runner@aborted.html
   [148]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl6/igt@runner@aborted.html
   [149]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl6/igt@runner@aborted.html
   [150]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl6/igt@runner@aborted.html
   [151]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/shard-apl3/igt@runner@aborted.html

  
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109289]: https://bugs.freedes

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5997/index.html

[-- Attachment #1.2: Type: text/html, Size: 35716 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Srinivas, Vidya]

Hello Bhanu,

Could you kindly check if rev 16 is okay for merge?
Thank you so much.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Thursday, July 8, 2021 7:56 PM
To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; Shankar, Uma <uma.shankar@intel.com>; igt-dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

Very sorry Bhanu, I missed seeing your comments before submitting. Apologies. 
Please find them fixed here.

https://patchwork.freedesktop.org/patch/443213/?series=90828&rev=16

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
Sent: Thursday, July 8, 2021 7:51 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; Shankar, Uma <uma.shankar@intel.com>; igt-dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

Hi Vidya,

Can you please address the comments in rev 14: https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14


Thanks,
Bhanu

> -----Original Message-----
> From: Srinivas, Vidya <vidya.srinivas@intel.com>
> Sent: Thursday, July 8, 2021 7:49 PM
> To: Shankar, Uma <uma.shankar@intel.com>; Modem, Bhanuprakash 
> <bhanuprakash.modem@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Hello Uma/Bhanu,
> 
> https://patchwork.freedesktop.org/patch/443212/?series=90828&rev=15 I 
> have submitted the patch with adding DSI and skipping the test.
> Kindly check and approve if okay.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Thursday, July 8, 2021 7:44 PM
> To: Shankar, Uma <uma.shankar@intel.com>; Modem, Bhanuprakash 
> <Bhanuprakash.Modem@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Hello Uma,
> 
> Sure, I have already submitted skipping test itself
> https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14
> I will add DSI also the same and re-submit. Thank you so much.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Shankar, Uma <uma.shankar@intel.com>
> Sent: Thursday, July 8, 2021 7:05 PM
> To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Srinivas, 
> Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> 
> 
> > -----Original Message-----
> > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > Sent: Thursday, July 8, 2021 5:51 PM
> > To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> > igt-dev@lists.freedesktop.org; Shankar, Uma <uma.shankar@intel.com>
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
> > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > > From: Srinivas, Vidya <vidya.srinivas@intel.com>
> > > Sent: Thursday, July 8, 2021 5:03 PM
> > > To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; igt- 
> > > dev@lists.freedesktop.org
> > > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
> > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> > >
> > > Hello Bhanu,
> > >
> > > No we skip it for all 6bpc. We can skip the test, but as discussed 
> > > with Uma, I just skip crc check, not the test.
> > > Kindly suggest further.
> >
> > If we remove/skip the crc check, I think there is no point in doing 
> > further commits unless we have kernel checkers.
> >
> > Uma?
> 
> I think it's a compromise here,  skip on 6bpc would be ideal here or 
> we need to have some passing criterion in order to declare this as pass.
> 
> We can do the bpc check after the first commit and skip there itself 
> if we detect 6bpc.This should be better given the constraints. Also 
> Vidya its good to add MIPI_DSI along with eDP as well since we have 
> some 6bpc MIPI DSI panels as well.
> 
> > >
> > > Regards
> > > Vidya
> > >
> > > -----Original Message-----
> > > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > > Sent: Thursday, July 8, 2021 4:15 PM
> > > To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> > > igt-dev@lists.freedesktop.org
> > > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
> > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> > >
> > > > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf 
> > > > Of Vidya Srinivas
> > > > Sent: Thursday, July 8, 2021 3:01 PM
> > > > To: igt-dev@lists.freedesktop.org
> > > > Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
> > > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc 
> > > > panels
> > > >
> > > > Intel Gen11 platforms using 6bpc panels have dithering ON and 
> > > > show CRC mismatch in coverage-vs-premult-vs-none Doing a crc 
> > > > based test with dithering is not a great idea as pixels will 
> > > > change due to the 8bit to 6bits truncation with dithering.
> > > >
> > > > This patch skips the CRC assertion for 6bpc panels. Currently, 
> > > > there is no better way of fetching the bpc info other than EDID 
> > > > or display_info. Currently using i915_display_info for the same.
> > > > Hence restricting the check to i915 devices only.
> > > >
> > > > Credits-to: Uma Shankar <uma.shankar@intel.com>
> > > > Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> > > > Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> > > > Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> > > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > > ---
> > > >  tests/kms_plane_alpha_blend.c | 43
> > > > +++++++++++++++++++++++++++++++++--
> > > >  1 file changed, 41 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/tests/kms_plane_alpha_blend.c 
> > > > b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..e450e64cb105
> > > > 100644
> > > > --- a/tests/kms_plane_alpha_blend.c
> > > > +++ b/tests/kms_plane_alpha_blend.c
> > > > @@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, 
> > > > enum pipe pipe, igt_plane_t *plane) 
> > > > igt_pipe_crc_stop(data->pipe_crc);
> > > >  }
> > > >
> > > > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) { 
> > > > +char buf[4096]; char *str; bool ret; int debugfs_fd; 
> > > > +drmModeConnector *c; igt_output_t *output = 
> > > > +igt_get_single_output_for_pipe(display,
> > > > +pipe);
> > > > +
> > > > +if (!is_i915_device(display->drm_fd))
> > > > +return false;
> > > > +
> > > > +c = output->config.connector;
> > > > +if (c->connector_type != DRM_MODE_CONNECTOR_eDP) return false;
> > > > +
> > > > +debugfs_fd = igt_debugfs_dir(display->drm_fd); if (debugfs_fd <
> > > > +0) return false;
> > > > +
> > > > +igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> > > > sizeof(buf));
> > > > +
> > > > +str = strstr(buf, "bpp=");
> > > > +if (str && (strncmp(str, "bpp=18", 6) == 0)) ret = true; else 
> > > > +ret = false;
> > > > +
> > > > +close(debugfs_fd);
> > > > +return ret;
> > > > +}
> > > > +
> > > >  static void coverage_premult_constant(data_t *data, enum pipe 
> > > > pipe, igt_plane_t *plane)  {  igt_display_t *display = 
> > > > &data->display;  igt_crc_t ref_crc = {}, crc = {};
> > > > +bool is6bpc = false;
> > > >
> > > >  /* Set a background color on the primary fb for testing */  if 
> > > > (plane->type != DRM_PLANE_TYPE_PRIMARY) @@ -461,14 +493,21 @@ 
> > > > static void coverage_premult_constant(data_t *data, enum pipe 
> > > > pipe, igt_plane_t  igt_plane_set_fb(plane, &data->argb_fb_7e); 
> > > > igt_display_commit2(display, COMMIT_ATOMIC); 
> > > > igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc); 
> > > > -igt_assert_crc_equal(&ref_crc, &crc);
> > > > +
> > > > +/* 6bpc panels have dithering ON and CRC might fail, hence skip 
> > > > +crc
> > > > check */
> > > > +is6bpc = is_6bpc(display, pipe); if (is6bpc == false) 
> > > > +igt_assert_crc_equal(&ref_crc, &crc);
> > >
> > > We can SKIP here, right? Also no need to run on remaining planes.
> > > Otherwise IGT will report this test result as PASS instead of 
> > > reporting as
> SKIP.
> > >
> > > igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc 
> > > panels\n");
> > >
> > >
> > > Also, are we going to skip this test on only gen 11? Then we need 
> > > a check to perform such.
> > >
> > > if (is_i915_device(fd) && intel_gen(intel_get_drm_devid(fd)) ==
> > > 11) igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc 
> > > panels\n");
> > >
> > > >
> > > >  igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
> > "None");
> > > >  igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e); 
> > > > igt_plane_set_fb(plane, &data->argb_fb_cov_7e); 
> > > > igt_display_commit2(display, COMMIT_ATOMIC); 
> > > > igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc); 
> > > > -igt_assert_crc_equal(&ref_crc, &crc);
> > > > +
> > > > +/* 6bpc panels have dithering ON and CRC might fail, hence skip 
> > > > +crc
> > > > check */
> > > > +if (is6bpc == false)
> > > > +igt_assert_crc_equal(&ref_crc, &crc);
> > > >
> > > >  igt_pipe_crc_stop(data->pipe_crc);
> > > >  }
> > > > --
> > > > 2.32.0
> > > >
> > > > _______________________________________________
> > > > igt-dev mailing list
> > > > igt-dev@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Modem, Bhanuprakash]

Hi Vidya,

Overall it looks good, but I have one minor suggestion. Otherwise we are good to go.

+	/* 6bpc panels have dithering ON and CRC might fail, hence skip test */
+	igt_require(is_6bpc(display, pipe) == false);

It would be good if we print some useful message on skipping the test, so that user can aware of that skip.

Please try with below snippet:
igt_require_f(!is_6bpc(display, pipe), "Your message\n");


Thanks,
Bhanu

> -----Original Message-----
> From: Srinivas, Vidya <vidya.srinivas@intel.com>
> Sent: Friday, July 9, 2021 11:52 AM
> To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Shankar, Uma
> <uma.shankar@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc
> assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Hello Bhanu,
> 
> Could you kindly check if rev 16 is okay for merge?
> Thank you so much.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Thursday, July 8, 2021 7:56 PM
> To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; Shankar, Uma
> <uma.shankar@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc
> assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Very sorry Bhanu, I missed seeing your comments before submitting. Apologies.
> Please find them fixed here.
> 
> https://patchwork.freedesktop.org/patch/443213/?series=90828&rev=16
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> Sent: Thursday, July 8, 2021 7:51 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; Shankar, Uma
> <uma.shankar@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc
> assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Hi Vidya,
> 
> Can you please address the comments in rev 14:
> https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14
> 
> 
> Thanks,
> Bhanu
> 
> > -----Original Message-----
> > From: Srinivas, Vidya <vidya.srinivas@intel.com>
> > Sent: Thursday, July 8, 2021 7:49 PM
> > To: Shankar, Uma <uma.shankar@intel.com>; Modem, Bhanuprakash
> > <bhanuprakash.modem@intel.com>; igt-dev@lists.freedesktop.org
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip
> > crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > Hello Uma/Bhanu,
> >
> > https://patchwork.freedesktop.org/patch/443212/?series=90828&rev=15 I
> > have submitted the patch with adding DSI and skipping the test.
> > Kindly check and approve if okay.
> >
> > Regards
> > Vidya
> >
> > -----Original Message-----
> > From: Srinivas, Vidya
> > Sent: Thursday, July 8, 2021 7:44 PM
> > To: Shankar, Uma <uma.shankar@intel.com>; Modem, Bhanuprakash
> > <Bhanuprakash.Modem@intel.com>; igt-dev@lists.freedesktop.org
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip
> > crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > Hello Uma,
> >
> > Sure, I have already submitted skipping test itself
> > https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14
> > I will add DSI also the same and re-submit. Thank you so much.
> >
> > Regards
> > Vidya
> >
> > -----Original Message-----
> > From: Shankar, Uma <uma.shankar@intel.com>
> > Sent: Thursday, July 8, 2021 7:05 PM
> > To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Srinivas,
> > Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip
> > crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> >
> >
> > > -----Original Message-----
> > > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > > Sent: Thursday, July 8, 2021 5:51 PM
> > > To: Srinivas, Vidya <vidya.srinivas@intel.com>;
> > > igt-dev@lists.freedesktop.org; Shankar, Uma <uma.shankar@intel.com>
> > > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
> > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> > >
> > > > From: Srinivas, Vidya <vidya.srinivas@intel.com>
> > > > Sent: Thursday, July 8, 2021 5:03 PM
> > > > To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; igt-
> > > > dev@lists.freedesktop.org
> > > > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
> > > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> > > >
> > > > Hello Bhanu,
> > > >
> > > > No we skip it for all 6bpc. We can skip the test, but as discussed
> > > > with Uma, I just skip crc check, not the test.
> > > > Kindly suggest further.
> > >
> > > If we remove/skip the crc check, I think there is no point in doing
> > > further commits unless we have kernel checkers.
> > >
> > > Uma?
> >
> > I think it's a compromise here,  skip on 6bpc would be ideal here or
> > we need to have some passing criterion in order to declare this as pass.
> >
> > We can do the bpc check after the first commit and skip there itself
> > if we detect 6bpc.This should be better given the constraints. Also
> > Vidya its good to add MIPI_DSI along with eDP as well since we have
> > some 6bpc MIPI DSI panels as well.
> >
> > > >
> > > > Regards
> > > > Vidya
> > > >
> > > > -----Original Message-----
> > > > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > > > Sent: Thursday, July 8, 2021 4:15 PM
> > > > To: Srinivas, Vidya <vidya.srinivas@intel.com>;
> > > > igt-dev@lists.freedesktop.org
> > > > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
> > > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> > > >
> > > > > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf
> > > > > Of Vidya Srinivas
> > > > > Sent: Thursday, July 8, 2021 3:01 PM
> > > > > To: igt-dev@lists.freedesktop.org
> > > > > Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
> > > > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc
> > > > > panels
> > > > >
> > > > > Intel Gen11 platforms using 6bpc panels have dithering ON and
> > > > > show CRC mismatch in coverage-vs-premult-vs-none Doing a crc
> > > > > based test with dithering is not a great idea as pixels will
> > > > > change due to the 8bit to 6bits truncation with dithering.
> > > > >
> > > > > This patch skips the CRC assertion for 6bpc panels. Currently,
> > > > > there is no better way of fetching the bpc info other than EDID
> > > > > or display_info. Currently using i915_display_info for the same.
> > > > > Hence restricting the check to i915 devices only.
> > > > >
> > > > > Credits-to: Uma Shankar <uma.shankar@intel.com>
> > > > > Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> > > > > Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> > > > > Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> > > > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > > > ---
> > > > >  tests/kms_plane_alpha_blend.c | 43
> > > > > +++++++++++++++++++++++++++++++++--
> > > > >  1 file changed, 41 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/tests/kms_plane_alpha_blend.c
> > > > > b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..e450e64cb105
> > > > > 100644
> > > > > --- a/tests/kms_plane_alpha_blend.c
> > > > > +++ b/tests/kms_plane_alpha_blend.c
> > > > > @@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data,
> > > > > enum pipe pipe, igt_plane_t *plane)
> > > > > igt_pipe_crc_stop(data->pipe_crc);
> > > > >  }
> > > > >
> > > > > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> > > > > +char buf[4096]; char *str; bool ret; int debugfs_fd;
> > > > > +drmModeConnector *c; igt_output_t *output =
> > > > > +igt_get_single_output_for_pipe(display,
> > > > > +pipe);
> > > > > +
> > > > > +if (!is_i915_device(display->drm_fd))
> > > > > +return false;
> > > > > +
> > > > > +c = output->config.connector;
> > > > > +if (c->connector_type != DRM_MODE_CONNECTOR_eDP) return false;
> > > > > +
> > > > > +debugfs_fd = igt_debugfs_dir(display->drm_fd); if (debugfs_fd <
> > > > > +0) return false;
> > > > > +
> > > > > +igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> > > > > sizeof(buf));
> > > > > +
> > > > > +str = strstr(buf, "bpp=");
> > > > > +if (str && (strncmp(str, "bpp=18", 6) == 0)) ret = true; else
> > > > > +ret = false;
> > > > > +
> > > > > +close(debugfs_fd);
> > > > > +return ret;
> > > > > +}
> > > > > +
> > > > >  static void coverage_premult_constant(data_t *data, enum pipe
> > > > > pipe, igt_plane_t *plane)  {  igt_display_t *display =
> > > > > &data->display;  igt_crc_t ref_crc = {}, crc = {};
> > > > > +bool is6bpc = false;
> > > > >
> > > > >  /* Set a background color on the primary fb for testing */  if
> > > > > (plane->type != DRM_PLANE_TYPE_PRIMARY) @@ -461,14 +493,21 @@
> > > > > static void coverage_premult_constant(data_t *data, enum pipe
> > > > > pipe, igt_plane_t  igt_plane_set_fb(plane, &data->argb_fb_7e);
> > > > > igt_display_commit2(display, COMMIT_ATOMIC);
> > > > > igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> > > > > -igt_assert_crc_equal(&ref_crc, &crc);
> > > > > +
> > > > > +/* 6bpc panels have dithering ON and CRC might fail, hence skip
> > > > > +crc
> > > > > check */
> > > > > +is6bpc = is_6bpc(display, pipe); if (is6bpc == false)
> > > > > +igt_assert_crc_equal(&ref_crc, &crc);
> > > >
> > > > We can SKIP here, right? Also no need to run on remaining planes.
> > > > Otherwise IGT will report this test result as PASS instead of
> > > > reporting as
> > SKIP.
> > > >
> > > > igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc
> > > > panels\n");
> > > >
> > > >
> > > > Also, are we going to skip this test on only gen 11? Then we need
> > > > a check to perform such.
> > > >
> > > > if (is_i915_device(fd) && intel_gen(intel_get_drm_devid(fd)) ==
> > > > 11) igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc
> > > > panels\n");
> > > >
> > > > >
> > > > >  igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
> > > "None");
> > > > >  igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
> > > > > igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
> > > > > igt_display_commit2(display, COMMIT_ATOMIC);
> > > > > igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
> > > > > -igt_assert_crc_equal(&ref_crc, &crc);
> > > > > +
> > > > > +/* 6bpc panels have dithering ON and CRC might fail, hence skip
> > > > > +crc
> > > > > check */
> > > > > +if (is6bpc == false)
> > > > > +igt_assert_crc_equal(&ref_crc, &crc);
> > > > >
> > > > >  igt_pipe_crc_stop(data->pipe_crc);
> > > > >  }
> > > > > --
> > > > > 2.32.0
> > > > >
> > > > > _______________________________________________
> > > > > igt-dev mailing list
> > > > > igt-dev@lists.freedesktop.org
> > > > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> >

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

[Vidya Srinivas]

Intel platforms using 6bpc panels have dithering ON
and show CRC mismatch in coverage-vs-premult-vs-none
Doing a crc based test with dithering is not a great idea as pixels
will change due to the 8bit to 6bits truncation with dithering.

This patch skips the subtest for 6bpc panels. Currently, there is no better
way of fetching the bpc info other than EDID or display_info. Currently using
i915_display_info for the same. Hence restricting the check to i915 devices only.

Credits-to: Uma Shankar <uma.shankar@intel.com>
Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 37 +++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..6fccb50758dc 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -442,6 +442,38 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
 	igt_pipe_crc_stop(data->pipe_crc);
 }
 
+static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
+	char buf[8192];
+	char *str;
+	bool ret;
+	int debugfs_fd;
+	drmModeConnector *c;
+	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
+
+	if (!is_i915_device(display->drm_fd))
+		return false;
+
+	c = output->config.connector;
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+		c->connector_type != DRM_MODE_CONNECTOR_DSI)
+		return false;
+
+	debugfs_fd = igt_debugfs_dir(display->drm_fd);
+	if (debugfs_fd < 0)
+		return false;
+
+	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf, sizeof(buf));
+
+	str = strstr(buf, "bpp=");
+	if (str && (strncmp(str, "bpp=18", 6) == 0))
+		ret = true;
+	else
+		ret = false;
+
+	close(debugfs_fd);
+	return ret;
+}
+
 static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)
 {
 	igt_display_t *display = &data->display;
@@ -454,6 +486,11 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
+
+	/* 6bpc panels have dithering ON and CRC might fail, hence skip test */
+	igt_require(is_6bpc(display, pipe) == false);
+	igt_require_f(!is_6bpc(display, pipe), "Test skipped for 6bpc panels\n");
+
 	igt_pipe_crc_start(data->pipe_crc);
 	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
 
-- 
2.32.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

[Vidya Srinivas]

Intel platforms using 6bpc panels have dithering ON
and show CRC mismatch in coverage-vs-premult-vs-none
Doing a crc based test with dithering is not a great idea as pixels
will change due to the 8bit to 6bits truncation with dithering.

This patch skips the subtest for 6bpc panels. Currently, there is no better
way of fetching the bpc info other than EDID or display_info. Currently using
i915_display_info for the same. Hence restricting the check to i915 devices only.

Credits-to: Uma Shankar <uma.shankar@intel.com>
Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 36 +++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a37cb27c7d62..a3529dc2190f 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -442,6 +442,38 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
 	igt_pipe_crc_stop(data->pipe_crc);
 }
 
+static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
+	char buf[8192];
+	char *str;
+	bool ret;
+	int debugfs_fd;
+	drmModeConnector *c;
+	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
+
+	if (!is_i915_device(display->drm_fd))
+		return false;
+
+	c = output->config.connector;
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+		c->connector_type != DRM_MODE_CONNECTOR_DSI)
+		return false;
+
+	debugfs_fd = igt_debugfs_dir(display->drm_fd);
+	if (debugfs_fd < 0)
+		return false;
+
+	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf, sizeof(buf));
+
+	str = strstr(buf, "bpp=");
+	if (str && (strncmp(str, "bpp=18", 6) == 0))
+		ret = true;
+	else
+		ret = false;
+
+	close(debugfs_fd);
+	return ret;
+}
+
 static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t *plane)
 {
 	igt_display_t *display = &data->display;
@@ -454,6 +486,10 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
+
+	/* 6bpc panels have dithering ON and CRC might fail, hence skip test */
+	igt_require_f(!is_6bpc(display, pipe), "Test skipped for 6bpc panels\n");
+
 	igt_pipe_crc_start(data->pipe_crc);
 	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
 
-- 
2.32.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

[Srinivas, Vidya]

Hello Bhanu,

Thank you so much.
I have changed the message as suggested and tested it. https://patchwork.freedesktop.org/patch/443390/?series=90828&rev=18
Kindly check Rev 18.

Now I get this:
Test skipped for 6bpc panels
Subtest pipe-A-coverage-vs-premult-vs-constant: SKIP (0.058s)

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com> 
Sent: Friday, July 9, 2021 12:17 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; Shankar, Uma <uma.shankar@intel.com>; igt-dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

Hi Vidya,

Overall it looks good, but I have one minor suggestion. Otherwise we are good to go.

+	/* 6bpc panels have dithering ON and CRC might fail, hence skip test */
+	igt_require(is_6bpc(display, pipe) == false);

It would be good if we print some useful message on skipping the test, so that user can aware of that skip.

Please try with below snippet:
igt_require_f(!is_6bpc(display, pipe), "Your message\n");


Thanks,
Bhanu

> -----Original Message-----
> From: Srinivas, Vidya <vidya.srinivas@intel.com>
> Sent: Friday, July 9, 2021 11:52 AM
> To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Shankar, Uma 
> <uma.shankar@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Hello Bhanu,
> 
> Could you kindly check if rev 16 is okay for merge?
> Thank you so much.
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Srinivas, Vidya
> Sent: Thursday, July 8, 2021 7:56 PM
> To: Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; Shankar, Uma 
> <uma.shankar@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Very sorry Bhanu, I missed seeing your comments before submitting. Apologies.
> Please find them fixed here.
> 
> https://patchwork.freedesktop.org/patch/443213/?series=90828&rev=16
> 
> Regards
> Vidya
> 
> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> Sent: Thursday, July 8, 2021 7:51 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; Shankar, Uma 
> <uma.shankar@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> 
> Hi Vidya,
> 
> Can you please address the comments in rev 14:
> https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14
> 
> 
> Thanks,
> Bhanu
> 
> > -----Original Message-----
> > From: Srinivas, Vidya <vidya.srinivas@intel.com>
> > Sent: Thursday, July 8, 2021 7:49 PM
> > To: Shankar, Uma <uma.shankar@intel.com>; Modem, Bhanuprakash 
> > <bhanuprakash.modem@intel.com>; igt-dev@lists.freedesktop.org
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
> > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > Hello Uma/Bhanu,
> >
> > https://patchwork.freedesktop.org/patch/443212/?series=90828&rev=15 
> > I have submitted the patch with adding DSI and skipping the test.
> > Kindly check and approve if okay.
> >
> > Regards
> > Vidya
> >
> > -----Original Message-----
> > From: Srinivas, Vidya
> > Sent: Thursday, July 8, 2021 7:44 PM
> > To: Shankar, Uma <uma.shankar@intel.com>; Modem, Bhanuprakash 
> > <Bhanuprakash.Modem@intel.com>; igt-dev@lists.freedesktop.org
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
> > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> > Hello Uma,
> >
> > Sure, I have already submitted skipping test itself
> > https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14
> > I will add DSI also the same and re-submit. Thank you so much.
> >
> > Regards
> > Vidya
> >
> > -----Original Message-----
> > From: Shankar, Uma <uma.shankar@intel.com>
> > Sent: Thursday, July 8, 2021 7:05 PM
> > To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Srinivas, 
> > Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: 
> > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> >
> >
> >
> > > -----Original Message-----
> > > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > > Sent: Thursday, July 8, 2021 5:51 PM
> > > To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> > > igt-dev@lists.freedesktop.org; Shankar, Uma 
> > > <uma.shankar@intel.com>
> > > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
> > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels
> > >
> > > > From: Srinivas, Vidya <vidya.srinivas@intel.com>
> > > > Sent: Thursday, July 8, 2021 5:03 PM
> > > > To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; igt- 
> > > > dev@lists.freedesktop.org
> > > > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
> > > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc 
> > > > panels
> > > >
> > > > Hello Bhanu,
> > > >
> > > > No we skip it for all 6bpc. We can skip the test, but as 
> > > > discussed with Uma, I just skip crc check, not the test.
> > > > Kindly suggest further.
> > >
> > > If we remove/skip the crc check, I think there is no point in 
> > > doing further commits unless we have kernel checkers.
> > >
> > > Uma?
> >
> > I think it's a compromise here,  skip on 6bpc would be ideal here or 
> > we need to have some passing criterion in order to declare this as pass.
> >
> > We can do the bpc check after the first commit and skip there itself 
> > if we detect 6bpc.This should be better given the constraints. Also 
> > Vidya its good to add MIPI_DSI along with eDP as well since we have 
> > some 6bpc MIPI DSI panels as well.
> >
> > > >
> > > > Regards
> > > > Vidya
> > > >
> > > > -----Original Message-----
> > > > From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> > > > Sent: Thursday, July 8, 2021 4:15 PM
> > > > To: Srinivas, Vidya <vidya.srinivas@intel.com>; 
> > > > igt-dev@lists.freedesktop.org
> > > > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
> > > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc 
> > > > panels
> > > >
> > > > > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On 
> > > > > Behalf Of Vidya Srinivas
> > > > > Sent: Thursday, July 8, 2021 3:01 PM
> > > > > To: igt-dev@lists.freedesktop.org
> > > > > Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
> > > > > Skip crc assertion in coverage-vs-premult-vs-none for 6bpc 
> > > > > panels
> > > > >
> > > > > Intel Gen11 platforms using 6bpc panels have dithering ON and 
> > > > > show CRC mismatch in coverage-vs-premult-vs-none Doing a crc 
> > > > > based test with dithering is not a great idea as pixels will 
> > > > > change due to the 8bit to 6bits truncation with dithering.
> > > > >
> > > > > This patch skips the CRC assertion for 6bpc panels. Currently, 
> > > > > there is no better way of fetching the bpc info other than 
> > > > > EDID or display_info. Currently using i915_display_info for the same.
> > > > > Hence restricting the check to i915 devices only.
> > > > >
> > > > > Credits-to: Uma Shankar <uma.shankar@intel.com>
> > > > > Credits-to: Juha-pekka Heikkila 
> > > > > <juha-pekka.heikkila@intel.com>
> > > > > Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> > > > > Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> > > > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > > > ---
> > > > >  tests/kms_plane_alpha_blend.c | 43
> > > > > +++++++++++++++++++++++++++++++++--
> > > > >  1 file changed, 41 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/tests/kms_plane_alpha_blend.c 
> > > > > b/tests/kms_plane_alpha_blend.c index 
> > > > > a37cb27c7d62..e450e64cb105
> > > > > 100644
> > > > > --- a/tests/kms_plane_alpha_blend.c
> > > > > +++ b/tests/kms_plane_alpha_blend.c
> > > > > @@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, 
> > > > > enum pipe pipe, igt_plane_t *plane) 
> > > > > igt_pipe_crc_stop(data->pipe_crc);
> > > > >  }
> > > > >
> > > > > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) { 
> > > > > +char buf[4096]; char *str; bool ret; int debugfs_fd; 
> > > > > +drmModeConnector *c; igt_output_t *output = 
> > > > > +igt_get_single_output_for_pipe(display,
> > > > > +pipe);
> > > > > +
> > > > > +if (!is_i915_device(display->drm_fd))
> > > > > +return false;
> > > > > +
> > > > > +c = output->config.connector; if (c->connector_type != 
> > > > > +DRM_MODE_CONNECTOR_eDP) return false;
> > > > > +
> > > > > +debugfs_fd = igt_debugfs_dir(display->drm_fd); if (debugfs_fd 
> > > > > +<
> > > > > +0) return false;
> > > > > +
> > > > > +igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> > > > > sizeof(buf));
> > > > > +
> > > > > +str = strstr(buf, "bpp=");
> > > > > +if (str && (strncmp(str, "bpp=18", 6) == 0)) ret = true; else 
> > > > > +ret = false;
> > > > > +
> > > > > +close(debugfs_fd);
> > > > > +return ret;
> > > > > +}
> > > > > +
> > > > >  static void coverage_premult_constant(data_t *data, enum pipe 
> > > > > pipe, igt_plane_t *plane)  {  igt_display_t *display = 
> > > > > &data->display;  igt_crc_t ref_crc = {}, crc = {};
> > > > > +bool is6bpc = false;
> > > > >
> > > > >  /* Set a background color on the primary fb for testing */  
> > > > > if (plane->type != DRM_PLANE_TYPE_PRIMARY) @@ -461,14 +493,21 
> > > > > @@ static void coverage_premult_constant(data_t *data, enum 
> > > > > pipe pipe, igt_plane_t  igt_plane_set_fb(plane, 
> > > > > &data->argb_fb_7e); igt_display_commit2(display, 
> > > > > COMMIT_ATOMIC); igt_pipe_crc_get_current(display->drm_fd, 
> > > > > data->pipe_crc, &crc); -igt_assert_crc_equal(&ref_crc, &crc);
> > > > > +
> > > > > +/* 6bpc panels have dithering ON and CRC might fail, hence 
> > > > > +skip crc
> > > > > check */
> > > > > +is6bpc = is_6bpc(display, pipe); if (is6bpc == false) 
> > > > > +igt_assert_crc_equal(&ref_crc, &crc);
> > > >
> > > > We can SKIP here, right? Also no need to run on remaining planes.
> > > > Otherwise IGT will report this test result as PASS instead of 
> > > > reporting as
> > SKIP.
> > > >
> > > > igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc 
> > > > panels\n");
> > > >
> > > >
> > > > Also, are we going to skip this test on only gen 11? Then we 
> > > > need a check to perform such.
> > > >
> > > > if (is_i915_device(fd) && intel_gen(intel_get_drm_devid(fd)) ==
> > > > 11) igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc 
> > > > panels\n");
> > > >
> > > > >
> > > > >  igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,
> > > "None");
> > > > >  igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e); 
> > > > > igt_plane_set_fb(plane, &data->argb_fb_cov_7e); 
> > > > > igt_display_commit2(display, COMMIT_ATOMIC); 
> > > > > igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, 
> > > > > &crc); -igt_assert_crc_equal(&ref_crc, &crc);
> > > > > +
> > > > > +/* 6bpc panels have dithering ON and CRC might fail, hence 
> > > > > +skip crc
> > > > > check */
> > > > > +if (is6bpc == false)
> > > > > +igt_assert_crc_equal(&ref_crc, &crc);
> > > > >
> > > > >  igt_pipe_crc_stop(data->pipe_crc);
> > > > >  }
> > > > > --
> > > > > 2.32.0
> > > > >
> > > > > _______________________________________________
> > > > > igt-dev mailing list
> > > > > igt-dev@lists.freedesktop.org
> > > > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> >

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev18)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 2610 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev18)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10321 -> IGTPW_6003
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/index.html

Known issues
------------

  Here are the changes found in IGTPW_6003 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_gttfill@basic:
    - fi-bsw-n3050:       NOTRUN -> [SKIP][1] ([fdo#109271])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/fi-bsw-n3050/igt@gem_exec_gttfill@basic.html

  * igt@gem_exec_suspend@basic-s3:
    - fi-bsw-n3050:       NOTRUN -> [INCOMPLETE][2] ([i915#3159])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/fi-bsw-n3050/igt@gem_exec_suspend@basic-s3.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-cml-s:           [PASS][3] -> [FAIL][4] ([fdo#103375])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/fi-cml-s/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/fi-cml-s/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  
#### Warnings ####

  * igt@i915_pm_rpm@basic-rte:
    - fi-kbl-guc:         [FAIL][5] ([i915#3049]) -> [SKIP][6] ([fdo#109271])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html

  
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#3049]: https://gitlab.freedesktop.org/drm/intel/issues/3049
  [i915#3159]: https://gitlab.freedesktop.org/drm/intel/issues/3159


Participating hosts (39 -> 38)
------------------------------

  Additional (1): fi-bsw-n3050 
  Missing    (2): fi-kbl-x1275 fi-bsw-cyan 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6132 -> IGTPW_6003

  CI-20190529: 20190529
  CI_DRM_10321: 8fa1181d949800a966c0f05a0a2b2699f3d4e95b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_6003: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/index.html
  IGT_6132: 61fb9cdf2a9132e3618c8b08b9d20fec0c347831 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/index.html

[-- Attachment #1.2: Type: text/html, Size: 3353 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

[Modem, Bhanuprakash]

> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Vidya
> Srinivas
> Sent: Friday, July 9, 2021 12:28 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-
> vs-premult-vs-none for 6bpc panels
> 
> Intel platforms using 6bpc panels have dithering ON
> and show CRC mismatch in coverage-vs-premult-vs-none
> Doing a crc based test with dithering is not a great idea as pixels
> will change due to the 8bit to 6bits truncation with dithering.
> 
> This patch skips the subtest for 6bpc panels. Currently, there is no better
> way of fetching the bpc info other than EDID or display_info. Currently using
> i915_display_info for the same. Hence restricting the check to i915 devices
> only.
> 
> Credits-to: Uma Shankar <uma.shankar@intel.com>
> Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 36 +++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
> index a37cb27c7d62..a3529dc2190f 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -442,6 +442,38 @@ static void coverage_7efc(data_t *data, enum pipe pipe,
> igt_plane_t *plane)
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> 
> +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> +	char buf[8192];
> +	char *str;
> +	bool ret;
> +	int debugfs_fd;
> +	drmModeConnector *c;
> +	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
> +
> +	if (!is_i915_device(display->drm_fd))
> +		return false;
> +
> +	c = output->config.connector;
> +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
> +		c->connector_type != DRM_MODE_CONNECTOR_DSI)
> +		return false;
> +
> +	debugfs_fd = igt_debugfs_dir(display->drm_fd);
> +	if (debugfs_fd < 0)
> +		return false;
> +
> +	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> sizeof(buf));
> +
> +	str = strstr(buf, "bpp=");
> +	if (str && (strncmp(str, "bpp=18", 6) == 0))
> +		ret = true;
> +	else
> +		ret = false;
> +
> +	close(debugfs_fd);
> +	return ret;
> +}
> +
>  static void coverage_premult_constant(data_t *data, enum pipe pipe,
> igt_plane_t *plane)
>  {
>  	igt_display_t *display = &data->display;
> @@ -454,6 +486,10 @@ static void coverage_premult_constant(data_t *data, enum
> pipe pipe, igt_plane_t
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
> +
> +	/* 6bpc panels have dithering ON and CRC might fail, hence skip test */
> +	igt_require_f(!is_6bpc(display, pipe), "Test skipped for 6bpc
> panels\n");

LGTM: Acked-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

> +
>  	igt_pipe_crc_start(data->pipe_crc);
>  	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
> 
> --
> 2.32.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

[Srinivas, Vidya]

Hello Bhanu/Uma/Juha-Pekka,

Thank you so much.

Petri, could you kindly help merge this? Thank you so much.

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com> 
Sent: Friday, July 9, 2021 4:18 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of 
> Vidya Srinivas
> Sent: Friday, July 9, 2021 12:28 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip 
> coverage- vs-premult-vs-none for 6bpc panels
> 
> Intel platforms using 6bpc panels have dithering ON and show CRC 
> mismatch in coverage-vs-premult-vs-none Doing a crc based test with 
> dithering is not a great idea as pixels will change due to the 8bit to 
> 6bits truncation with dithering.
> 
> This patch skips the subtest for 6bpc panels. Currently, there is no 
> better way of fetching the bpc info other than EDID or display_info. 
> Currently using i915_display_info for the same. Hence restricting the 
> check to i915 devices only.
> 
> Credits-to: Uma Shankar <uma.shankar@intel.com>
> Credits-to: Juha-pekka Heikkila <juha-pekka.heikkila@intel.com>
> Credits-to: Modem Bhanuprakash <Bhanuprakash.Modem@intel.com>
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_alpha_blend.c | 36 
> +++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/tests/kms_plane_alpha_blend.c 
> b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..a3529dc2190f 
> 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -442,6 +442,38 @@ static void coverage_7efc(data_t *data, enum pipe 
> pipe, igt_plane_t *plane)
>  	igt_pipe_crc_stop(data->pipe_crc);
>  }
> 
> +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> +	char buf[8192];
> +	char *str;
> +	bool ret;
> +	int debugfs_fd;
> +	drmModeConnector *c;
> +	igt_output_t *output = igt_get_single_output_for_pipe(display, 
> +pipe);
> +
> +	if (!is_i915_device(display->drm_fd))
> +		return false;
> +
> +	c = output->config.connector;
> +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
> +		c->connector_type != DRM_MODE_CONNECTOR_DSI)
> +		return false;
> +
> +	debugfs_fd = igt_debugfs_dir(display->drm_fd);
> +	if (debugfs_fd < 0)
> +		return false;
> +
> +	igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
> sizeof(buf));
> +
> +	str = strstr(buf, "bpp=");
> +	if (str && (strncmp(str, "bpp=18", 6) == 0))
> +		ret = true;
> +	else
> +		ret = false;
> +
> +	close(debugfs_fd);
> +	return ret;
> +}
> +
>  static void coverage_premult_constant(data_t *data, enum pipe pipe, 
> igt_plane_t *plane)  {
>  	igt_display_t *display = &data->display; @@ -454,6 +486,10 @@ static 
> void coverage_premult_constant(data_t *data, enum pipe pipe, 
> igt_plane_t
>  	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
>  	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
>  	igt_display_commit2(display, COMMIT_ATOMIC);
> +
> +	/* 6bpc panels have dithering ON and CRC might fail, hence skip test */
> +	igt_require_f(!is_6bpc(display, pipe), "Test skipped for 6bpc
> panels\n");

LGTM: Acked-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

> +
>  	igt_pipe_crc_start(data->pipe_crc);
>  	igt_pipe_crc_get_single(data->pipe_crc, &ref_crc);
> 
> --
> 2.32.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev18)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 30296 bytes --]

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests (rev18)
URL   : https://patchwork.freedesktop.org/series/90828/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10321_full -> IGTPW_6003_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/index.html

Known issues
------------

  Here are the changes found in IGTPW_6003_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@core_hotunplug@unbind-rebind:
    - shard-apl:          [PASS][1] -> [DMESG-WARN][2] ([i915#2283])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-apl2/igt@core_hotunplug@unbind-rebind.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl7/igt@core_hotunplug@unbind-rebind.html
    - shard-glk:          [PASS][3] -> [DMESG-WARN][4] ([i915#2283])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-glk3/igt@core_hotunplug@unbind-rebind.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-glk6/igt@core_hotunplug@unbind-rebind.html
    - shard-kbl:          NOTRUN -> [DMESG-WARN][5] ([i915#2283])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl7/igt@core_hotunplug@unbind-rebind.html

  * igt@feature_discovery@display-4x:
    - shard-iclb:         NOTRUN -> [SKIP][6] ([i915#1839])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb1/igt@feature_discovery@display-4x.html

  * igt@gem_ctx_isolation@preservation-s3@rcs0:
    - shard-apl:          [PASS][7] -> [DMESG-WARN][8] ([i915#180])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-apl2/igt@gem_ctx_isolation@preservation-s3@rcs0.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl8/igt@gem_ctx_isolation@preservation-s3@rcs0.html

  * igt@gem_ctx_persistence@legacy-engines-hostile-preempt:
    - shard-snb:          NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#1099]) +4 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-snb2/igt@gem_ctx_persistence@legacy-engines-hostile-preempt.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-kbl:          NOTRUN -> [FAIL][10] ([i915#2846])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl4/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-flow@rcs0:
    - shard-tglb:         [PASS][11] -> [FAIL][12] ([i915#2842])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-tglb3/igt@gem_exec_fair@basic-flow@rcs0.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html

  * igt@gem_exec_fair@basic-pace@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][13] ([i915#2842]) +1 similar issue
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-glk:          [PASS][14] -> [FAIL][15] ([i915#2842])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-glk1/igt@gem_exec_fair@basic-throttle@rcs0.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-glk4/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_exec_whisper@basic-contexts-priority-all:
    - shard-iclb:         [PASS][16] -> [INCOMPLETE][17] ([i915#1895])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-iclb1/igt@gem_exec_whisper@basic-contexts-priority-all.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb7/igt@gem_exec_whisper@basic-contexts-priority-all.html

  * igt@gem_huc_copy@huc-copy:
    - shard-apl:          NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#2190])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl2/igt@gem_huc_copy@huc-copy.html
    - shard-glk:          NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#2190])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-glk4/igt@gem_huc_copy@huc-copy.html
    - shard-iclb:         NOTRUN -> [SKIP][20] ([i915#2190])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb4/igt@gem_huc_copy@huc-copy.html
    - shard-kbl:          NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#2190])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl6/igt@gem_huc_copy@huc-copy.html

  * igt@gem_pwrite@basic-exhaustion:
    - shard-snb:          NOTRUN -> [WARN][22] ([i915#2658]) +1 similar issue
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-snb6/igt@gem_pwrite@basic-exhaustion.html

  * igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
    - shard-kbl:          NOTRUN -> [SKIP][23] ([fdo#109271]) +197 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl6/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html

  * igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled:
    - shard-iclb:         NOTRUN -> [SKIP][24] ([i915#768]) +1 similar issue
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb2/igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled.html

  * igt@gem_userptr_blits@input-checking:
    - shard-apl:          NOTRUN -> [DMESG-WARN][25] ([i915#3002])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl2/igt@gem_userptr_blits@input-checking.html
    - shard-snb:          NOTRUN -> [DMESG-WARN][26] ([i915#3002])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-snb6/igt@gem_userptr_blits@input-checking.html

  * igt@gem_userptr_blits@vma-merge:
    - shard-kbl:          NOTRUN -> [FAIL][27] ([i915#3318])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl6/igt@gem_userptr_blits@vma-merge.html

  * igt@gen3_render_tiledy_blits:
    - shard-tglb:         NOTRUN -> [SKIP][28] ([fdo#109289])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb1/igt@gen3_render_tiledy_blits.html

  * igt@gen9_exec_parse@bb-start-out:
    - shard-tglb:         NOTRUN -> [SKIP][29] ([fdo#112306])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb2/igt@gen9_exec_parse@bb-start-out.html

  * igt@gen9_exec_parse@unaligned-jump:
    - shard-iclb:         NOTRUN -> [SKIP][30] ([fdo#112306]) +1 similar issue
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb8/igt@gen9_exec_parse@unaligned-jump.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
    - shard-apl:          NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#1937])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html

  * igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
    - shard-iclb:         NOTRUN -> [SKIP][32] ([i915#1769])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb6/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html

  * igt@kms_big_fb@linear-32bpp-rotate-0:
    - shard-glk:          [PASS][33] -> [DMESG-WARN][34] ([i915#118] / [i915#95]) +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-glk5/igt@kms_big_fb@linear-32bpp-rotate-0.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-glk2/igt@kms_big_fb@linear-32bpp-rotate-0.html

  * igt@kms_big_fb@yf-tiled-addfb:
    - shard-tglb:         NOTRUN -> [SKIP][35] ([fdo#111615]) +1 similar issue
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb2/igt@kms_big_fb@yf-tiled-addfb.html

  * igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][36] ([i915#3689]) +6 similar issues
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb5/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_ccs.html

  * igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
    - shard-iclb:         NOTRUN -> [SKIP][37] ([fdo#109278]) +20 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb6/igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_chamelium@dp-hpd-for-each-pipe:
    - shard-iclb:         NOTRUN -> [SKIP][38] ([fdo#109284] / [fdo#111827]) +5 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb1/igt@kms_chamelium@dp-hpd-for-each-pipe.html

  * igt@kms_chamelium@vga-edid-read:
    - shard-apl:          NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +15 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl2/igt@kms_chamelium@vga-edid-read.html

  * igt@kms_chamelium@vga-hpd:
    - shard-tglb:         NOTRUN -> [SKIP][40] ([fdo#109284] / [fdo#111827]) +3 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb7/igt@kms_chamelium@vga-hpd.html

  * igt@kms_color_chamelium@pipe-a-degamma:
    - shard-kbl:          NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +15 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl2/igt@kms_color_chamelium@pipe-a-degamma.html

  * igt@kms_color_chamelium@pipe-d-degamma:
    - shard-glk:          NOTRUN -> [SKIP][42] ([fdo#109271] / [fdo#111827]) +3 similar issues
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-glk6/igt@kms_color_chamelium@pipe-d-degamma.html

  * igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
    - shard-snb:          NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +20 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-snb2/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html

  * igt@kms_content_protection@legacy:
    - shard-iclb:         NOTRUN -> [SKIP][44] ([fdo#109300] / [fdo#111066])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb5/igt@kms_content_protection@legacy.html

  * igt@kms_content_protection@lic:
    - shard-apl:          NOTRUN -> [TIMEOUT][45] ([i915#1319])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl6/igt@kms_content_protection@lic.html

  * igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen:
    - shard-iclb:         NOTRUN -> [SKIP][46] ([fdo#109278] / [fdo#109279]) +3 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb2/igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen.html

  * igt@kms_cursor_crc@pipe-b-cursor-suspend:
    - shard-apl:          NOTRUN -> [DMESG-WARN][47] ([i915#180]) +1 similar issue
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl8/igt@kms_cursor_crc@pipe-b-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-d-cursor-32x10-sliding:
    - shard-tglb:         NOTRUN -> [SKIP][48] ([i915#3359])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb2/igt@kms_cursor_crc@pipe-d-cursor-32x10-sliding.html

  * igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
    - shard-iclb:         NOTRUN -> [SKIP][49] ([fdo#109274] / [fdo#109278]) +1 similar issue
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb5/igt@kms_cursor_legacy@cursorb-vs-flipb-toggle.html

  * igt@kms_flip@2x-plain-flip-ts-check:
    - shard-tglb:         NOTRUN -> [SKIP][50] ([fdo#111825]) +17 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb1/igt@kms_flip@2x-plain-flip-ts-check.html
    - shard-iclb:         NOTRUN -> [SKIP][51] ([fdo#109274]) +2 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb8/igt@kms_flip@2x-plain-flip-ts-check.html

  * igt@kms_flip@2x-plain-flip-ts-check@ac-hdmi-a1-hdmi-a2:
    - shard-glk:          NOTRUN -> [FAIL][52] ([i915#2122])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-glk3/igt@kms_flip@2x-plain-flip-ts-check@ac-hdmi-a1-hdmi-a2.html

  * igt@kms_flip@flip-vs-suspend@c-dp1:
    - shard-kbl:          NOTRUN -> [DMESG-WARN][53] ([i915#180]) +2 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl6/igt@kms_flip@flip-vs-suspend@c-dp1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
    - shard-apl:          NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#2672])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

  * igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu:
    - shard-glk:          NOTRUN -> [SKIP][55] ([fdo#109271]) +38 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-glk2/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu.html

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-render:
    - shard-iclb:         NOTRUN -> [SKIP][56] ([fdo#109280]) +19 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb7/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-render.html

  * igt@kms_hdr@bpc-switch-suspend:
    - shard-kbl:          [PASS][57] -> [DMESG-WARN][58] ([i915#180])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-kbl2/igt@kms_hdr@bpc-switch-suspend.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl6/igt@kms_hdr@bpc-switch-suspend.html

  * igt@kms_hdr@static-swap:
    - shard-iclb:         NOTRUN -> [SKIP][59] ([i915#1187])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb8/igt@kms_hdr@static-swap.html

  * igt@kms_hdr@static-toggle-dpms:
    - shard-tglb:         NOTRUN -> [SKIP][60] ([i915#1187])
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb5/igt@kms_hdr@static-toggle-dpms.html

  * igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
    - shard-kbl:          NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#533])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl2/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
    - shard-apl:          NOTRUN -> [FAIL][62] ([fdo#108145] / [i915#265]) +1 similar issue
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
    - shard-kbl:          NOTRUN -> [FAIL][63] ([i915#265]) +1 similar issue
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl4/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html

  * igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
    - shard-kbl:          NOTRUN -> [FAIL][64] ([fdo#108145] / [i915#265]) +3 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl6/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html

  * igt@kms_plane_lowres@pipe-d-tiling-x:
    - shard-tglb:         NOTRUN -> [SKIP][65] ([i915#3536])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb5/igt@kms_plane_lowres@pipe-d-tiling-x.html

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
    - shard-apl:          NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#2733])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl2/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
    - shard-apl:          NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#658]) +5 similar issues
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
    - shard-kbl:          NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#658]) +2 similar issues
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
    - shard-iclb:         NOTRUN -> [SKIP][69] ([i915#658])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb8/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
    - shard-tglb:         NOTRUN -> [SKIP][70] ([i915#2920])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
    - shard-iclb:         NOTRUN -> [SKIP][71] ([i915#2920])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][72] -> [SKIP][73] ([fdo#109642] / [fdo#111068] / [i915#658])
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb4/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr2_su@page_flip:
    - shard-glk:          NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#658]) +1 similar issue
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-glk9/igt@kms_psr2_su@page_flip.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         NOTRUN -> [SKIP][75] ([fdo#109441]) +1 similar issue
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb8/igt@kms_psr@psr2_cursor_render.html
    - shard-tglb:         NOTRUN -> [FAIL][76] ([i915#132] / [i915#3467]) +2 similar issues
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb1/igt@kms_psr@psr2_cursor_render.html

  * igt@kms_psr@psr2_suspend:
    - shard-iclb:         [PASS][77] -> [SKIP][78] ([fdo#109441]) +1 similar issue
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-iclb2/igt@kms_psr@psr2_suspend.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb7/igt@kms_psr@psr2_suspend.html

  * igt@kms_vblank@pipe-d-query-forked-hang:
    - shard-snb:          NOTRUN -> [SKIP][79] ([fdo#109271]) +427 similar issues
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-snb2/igt@kms_vblank@pipe-d-query-forked-hang.html

  * igt@kms_vblank@pipe-d-ts-continuation-idle:
    - shard-apl:          NOTRUN -> [SKIP][80] ([fdo#109271]) +229 similar issues
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl3/igt@kms_vblank@pipe-d-ts-continuation-idle.html

  * igt@kms_vblank@pipe-d-wait-idle:
    - shard-apl:          NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#533]) +1 similar issue
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl6/igt@kms_vblank@pipe-d-wait-idle.html

  * igt@kms_writeback@writeback-invalid-parameters:
    - shard-tglb:         NOTRUN -> [SKIP][82] ([i915#2437])
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb6/igt@kms_writeback@writeback-invalid-parameters.html
    - shard-kbl:          NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#2437])
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl1/igt@kms_writeback@writeback-invalid-parameters.html
    - shard-apl:          NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2437]) +1 similar issue
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl7/igt@kms_writeback@writeback-invalid-parameters.html
    - shard-glk:          NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#2437])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-glk6/igt@kms_writeback@writeback-invalid-parameters.html
    - shard-iclb:         NOTRUN -> [SKIP][86] ([i915#2437])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb2/igt@kms_writeback@writeback-invalid-parameters.html

  * igt@nouveau_crc@ctx-flip-threshold-reset-after-capture:
    - shard-iclb:         NOTRUN -> [SKIP][87] ([i915#2530]) +1 similar issue
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb2/igt@nouveau_crc@ctx-flip-threshold-reset-after-capture.html

  * igt@nouveau_crc@pipe-c-source-outp-inactive:
    - shard-tglb:         NOTRUN -> [SKIP][88] ([i915#2530])
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb3/igt@nouveau_crc@pipe-c-source-outp-inactive.html

  * igt@prime_nv_pcopy@test2:
    - shard-iclb:         NOTRUN -> [SKIP][89] ([fdo#109291]) +2 similar issues
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb2/igt@prime_nv_pcopy@test2.html

  * igt@prime_nv_test@i915_blt_fill_nv_read:
    - shard-tglb:         NOTRUN -> [SKIP][90] ([fdo#109291]) +2 similar issues
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb7/igt@prime_nv_test@i915_blt_fill_nv_read.html

  * igt@sysfs_clients@pidname:
    - shard-apl:          NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#2994]) +4 similar issues
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl7/igt@sysfs_clients@pidname.html
    - shard-glk:          NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2994]) +1 similar issue
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-glk6/igt@sysfs_clients@pidname.html
    - shard-tglb:         NOTRUN -> [SKIP][93] ([i915#2994])
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb1/igt@sysfs_clients@pidname.html

  * igt@sysfs_clients@recycle-many:
    - shard-iclb:         NOTRUN -> [SKIP][94] ([i915#2994]) +2 similar issues
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb8/igt@sysfs_clients@recycle-many.html

  * igt@sysfs_clients@split-50:
    - shard-kbl:          NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#2994]) +4 similar issues
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl2/igt@sysfs_clients@split-50.html

  
#### Possible fixes ####

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-apl:          [SKIP][96] ([fdo#109271]) -> [PASS][97]
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-apl2/igt@gem_exec_fair@basic-none-share@rcs0.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-apl3/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-tglb:         [FAIL][98] ([i915#2842]) -> [PASS][99]
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html
    - shard-glk:          [FAIL][100] ([i915#2842]) -> [PASS][101]
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_fair@basic-pace@vecs0:
    - shard-kbl:          [FAIL][102] ([i915#2842]) -> [PASS][103] +4 similar issues
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-kbl7/igt@gem_exec_fair@basic-pace@vecs0.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl6/igt@gem_exec_fair@basic-pace@vecs0.html

  * igt@gem_fenced_exec_thrash@2-spare-fences:
    - shard-snb:          [INCOMPLETE][104] ([i915#2055]) -> [PASS][105]
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-snb6/igt@gem_fenced_exec_thrash@2-spare-fences.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-snb7/igt@gem_fenced_exec_thrash@2-spare-fences.html

  * igt@gen9_exec_parse@allowed-all:
    - shard-glk:          [DMESG-WARN][106] ([i915#1436] / [i915#716]) -> [PASS][107]
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-glk4/igt@gen9_exec_parse@allowed-all.html
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-glk4/igt@gen9_exec_parse@allowed-all.html

  * igt@i915_module_load@reload-with-fault-injection:
    - shard-snb:          [INCOMPLETE][108] ([i915#2880]) -> [PASS][109]
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-snb5/igt@i915_module_load@reload-with-fault-injection.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-snb6/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_selftest@live@hangcheck:
    - shard-iclb:         [INCOMPLETE][110] ([i915#2782]) -> [PASS][111]
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-iclb5/igt@i915_selftest@live@hangcheck.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb7/igt@i915_selftest@live@hangcheck.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-0:
    - shard-glk:          [DMESG-WARN][112] ([i915#118] / [i915#95]) -> [PASS][113]
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-glk9/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-glk7/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html

  * igt@kms_big_fb@yf-tiled-32bpp-rotate-180:
    - shard-glk:          [FAIL][114] -> [PASS][115]
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-glk8/igt@kms_big_fb@yf-tiled-32bpp-rotate-180.html
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-glk8/igt@kms_big_fb@yf-tiled-32bpp-rotate-180.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [DMESG-WARN][116] ([i915#180]) -> [PASS][117] +5 similar issues
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_psr@psr2_sprite_blt:
    - shard-iclb:         [SKIP][118] ([fdo#109441]) -> [PASS][119]
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-iclb4/igt@kms_psr@psr2_sprite_blt.html
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html

  
#### Warnings ####

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-iclb:         [FAIL][120] ([i915#2849]) -> [FAIL][121] ([i915#2842])
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@i915_pm_dc@dc3co-vpb-simulation:
    - shard-iclb:         [SKIP][122] ([i915#588]) -> [SKIP][123] ([i915#658])
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb8/igt@i915_pm_dc@dc3co-vpb-simulation.html

  * igt@i915_pm_dc@dc6-psr:
    - shard-iclb:         [INCOMPLETE][124] ([i915#1982] / [i915#3698]) -> [FAIL][125] ([i915#454])
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-iclb5/igt@i915_pm_dc@dc6-psr.html
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb8/igt@i915_pm_dc@dc6-psr.html

  * igt@i915_pm_rc6_residency@rc6-fence:
    - shard-iclb:         [WARN][126] ([i915#2684]) -> [WARN][127] ([i915#1804] / [i915#2684])
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb4/igt@i915_pm_rc6_residency@rc6-fence.html

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-iclb:         [WARN][128] ([i915#1804] / [i915#2684]) -> [WARN][129] ([i915#2684])
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-iclb3/igt@i915_pm_rc6_residency@rc6-idle.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
    - shard-iclb:         [SKIP][130] ([i915#2920]) -> [SKIP][131] ([i915#658]) +1 similar issue
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb8/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3:
    - shard-iclb:         [SKIP][132] ([i915#658]) -> [SKIP][133] ([i915#2920])
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-iclb8/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html

  * igt@runner@aborted:
    - shard-kbl:          ([FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#2722] / [i915#3002] / [i915#3363] / [i915#3744] / [i915#602]) -> ([FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149]) ([i915#180] / [i915#1814] / [i915#2283] / [i915#2505] / [i915#3002] / [i915#3363] / [i915#602])
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-kbl2/igt@runner@aborted.html
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-kbl3/igt@runner@aborted.html
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-kbl2/igt@runner@aborted.html
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-kbl6/igt@runner@aborted.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-kbl7/igt@runner@aborted.html
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-kbl7/igt@runner@aborted.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-kbl2/igt@runner@aborted.html
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-kbl2/igt@runner@aborted.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-kbl1/igt@runner@aborted.html
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-kbl6/igt@runner@aborted.html
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10321/shard-kbl7/igt@runner@aborted.html
   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl7/igt@runner@aborted.html
   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/shard-kbl2/igt@runner@aborted.html
   [147]: https://intel-gfx-ci.01.org/tree/drm

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6003/index.html

[-- Attachment #1.2: Type: text/html, Size: 34255 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

[Dixit, Ashutosh]

On Thu, 08 Jul 2021 23:57:41 -0700, Vidya Srinivas wrote:
>
> +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> +	char buf[8192];
> +	char *str;
> +	bool ret;
> +	int debugfs_fd;
> +	drmModeConnector *c;
> +	igt_output_t *output = igt_get_single_output_for_pipe(display, pipe);
> +
> +	if (!is_i915_device(display->drm_fd))
> +		return false;
> +
> +	c = output->config.connector;
> +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
> +		c->connector_type != DRM_MODE_CONNECTOR_DSI)
> +		return false;

Isn't this an && rather than an || ?

[298/1063] Compiling C object 'tests/59830eb@@kms_plane_alpha_blend@exe/kms_plane_alpha_blend.c.o'.
../tests/kms_plane_alpha_blend.c: In function ‘is_6bpc’:
../tests/kms_plane_alpha_blend.c:457:50: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op]
  if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
                                                  ^~
You cannot merge code with compile warnings.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

[Srinivas, Vidya]

Hi Ashutosh,

Apologies, yes it should be &&. You are right. How do I fix it, revert and resubmit?
Patch is merged. Should I submit another patch saying fixes this?
Immediately it might not be breaking anything huge but I need to fix it.

Regards
Vidya

-----Original Message-----
From: Dixit, Ashutosh <ashutosh.dixit@intel.com> 
Sent: Wednesday, July 14, 2021 7:36 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

On Thu, 08 Jul 2021 23:57:41 -0700, Vidya Srinivas wrote:
>
> +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> +	char buf[8192];
> +	char *str;
> +	bool ret;
> +	int debugfs_fd;
> +	drmModeConnector *c;
> +	igt_output_t *output = igt_get_single_output_for_pipe(display, 
> +pipe);
> +
> +	if (!is_i915_device(display->drm_fd))
> +		return false;
> +
> +	c = output->config.connector;
> +	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
> +		c->connector_type != DRM_MODE_CONNECTOR_DSI)
> +		return false;

Isn't this an && rather than an || ?

[298/1063] Compiling C object 'tests/59830eb@@kms_plane_alpha_blend@exe/kms_plane_alpha_blend.c.o'.
../tests/kms_plane_alpha_blend.c: In function ‘is_6bpc’:
../tests/kms_plane_alpha_blend.c:457:50: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op]
  if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
                                                  ^~ You cannot merge code with compile warnings.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

[Dixit, Ashutosh]

On Tue, 13 Jul 2021 19:56:16 -0700, Srinivas, Vidya wrote:
>
> Hi Ashutosh,
>
> Apologies, yes it should be &&. You are right. How do I fix it, revert and resubmit?
> Patch is merged. Should I submit another patch saying fixes this?
> Immediately it might not be breaking anything huge but I need to fix it.

No need to revert, just send another patch to fix it.

>
> Regards
> Vidya
>
> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
> Sent: Wednesday, July 14, 2021 7:36 AM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels
>
> On Thu, 08 Jul 2021 23:57:41 -0700, Vidya Srinivas wrote:
> >
> > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> > +     char buf[8192];
> > +     char *str;
> > +     bool ret;
> > +     int debugfs_fd;
> > +     drmModeConnector *c;
> > +     igt_output_t *output = igt_get_single_output_for_pipe(display,
> > +pipe);
> > +
> > +     if (!is_i915_device(display->drm_fd))
> > +             return false;
> > +
> > +     c = output->config.connector;
> > +     if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
> > +             c->connector_type != DRM_MODE_CONNECTOR_DSI)
> > +             return false;
>
> Isn't this an && rather than an || ?
>
> [298/1063] Compiling C object 'tests/59830eb@@kms_plane_alpha_blend@exe/kms_plane_alpha_blend.c.o'.
> ../tests/kms_plane_alpha_blend.c: In function ‘is_6bpc’:
> ../tests/kms_plane_alpha_blend.c:457:50: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op]
>   if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
>                                                   ^~ You cannot merge code with compile warnings.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

[Srinivas, Vidya]

Sure, thank you so much Ashutosh.

Regards
Vidya

-----Original Message-----
From: Dixit, Ashutosh <ashutosh.dixit@intel.com> 
Sent: Wednesday, July 14, 2021 8:49 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>
Cc: igt-dev@lists.freedesktop.org; Shankar, Uma <uma.shankar@intel.com>; Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

On Tue, 13 Jul 2021 19:56:16 -0700, Srinivas, Vidya wrote:
>
> Hi Ashutosh,
>
> Apologies, yes it should be &&. You are right. How do I fix it, revert and resubmit?
> Patch is merged. Should I submit another patch saying fixes this?
> Immediately it might not be breaking anything huge but I need to fix it.

No need to revert, just send another patch to fix it.

>
> Regards
> Vidya
>
> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
> Sent: Wednesday, July 14, 2021 7:36 AM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels
>
> On Thu, 08 Jul 2021 23:57:41 -0700, Vidya Srinivas wrote:
> >
> > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> > +     char buf[8192];
> > +     char *str;
> > +     bool ret;
> > +     int debugfs_fd;
> > +     drmModeConnector *c;
> > +     igt_output_t *output = igt_get_single_output_for_pipe(display,
> > +pipe);
> > +
> > +     if (!is_i915_device(display->drm_fd))
> > +             return false;
> > +
> > +     c = output->config.connector;
> > +     if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
> > +             c->connector_type != DRM_MODE_CONNECTOR_DSI)
> > +             return false;
>
> Isn't this an && rather than an || ?
>
> [298/1063] Compiling C object 'tests/59830eb@@kms_plane_alpha_blend@exe/kms_plane_alpha_blend.c.o'.
> ../tests/kms_plane_alpha_blend.c: In function ‘is_6bpc’:
> ../tests/kms_plane_alpha_blend.c:457:50: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op]
>   if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
>                                                   ^~ You cannot merge code with compile warnings.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

[Srinivas, Vidya]

Hello Ashutosh,

Thanks much for pointing the issue.
https://patchwork.freedesktop.org/patch/443926/ have submitted this.

Apologies Uma/Bhanu/Kunal, can we merge this patch as well ☹?

Regards
Vidya

-----Original Message-----
From: Dixit, Ashutosh <ashutosh.dixit@intel.com> 
Sent: Wednesday, July 14, 2021 8:49 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>
Cc: igt-dev@lists.freedesktop.org; Shankar, Uma <uma.shankar@intel.com>; Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels

On Tue, 13 Jul 2021 19:56:16 -0700, Srinivas, Vidya wrote:
>
> Hi Ashutosh,
>
> Apologies, yes it should be &&. You are right. How do I fix it, revert and resubmit?
> Patch is merged. Should I submit another patch saying fixes this?
> Immediately it might not be breaking anything huge but I need to fix it.

No need to revert, just send another patch to fix it.

>
> Regards
> Vidya
>
> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
> Sent: Wednesday, July 14, 2021 7:36 AM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip coverage-vs-premult-vs-none for 6bpc panels
>
> On Thu, 08 Jul 2021 23:57:41 -0700, Vidya Srinivas wrote:
> >
> > +static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> > +     char buf[8192];
> > +     char *str;
> > +     bool ret;
> > +     int debugfs_fd;
> > +     drmModeConnector *c;
> > +     igt_output_t *output = igt_get_single_output_for_pipe(display,
> > +pipe);
> > +
> > +     if (!is_i915_device(display->drm_fd))
> > +             return false;
> > +
> > +     c = output->config.connector;
> > +     if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
> > +             c->connector_type != DRM_MODE_CONNECTOR_DSI)
> > +             return false;
>
> Isn't this an && rather than an || ?
>
> [298/1063] Compiling C object 'tests/59830eb@@kms_plane_alpha_blend@exe/kms_plane_alpha_blend.c.o'.
> ../tests/kms_plane_alpha_blend.c: In function ʽis_6bpcʼ:
> ../tests/kms_plane_alpha_blend.c:457:50: warning: logical ʽorʼ of collectively exhaustive tests is always true [-Wlogical-op]
>   if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
>                                                   ^~ You cannot merge code with compile warnings.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev