From: Krishna Reddy <vdumpa@nvidia.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Will Deacon <will@kernel.org>
Cc: Amey Narkhede <ameynarkhede03@gmail.com>,
Rob Clark <robdclark@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Barry Song <song.bao.hua@hisilicon.com>,
Zenghui Yu <yuzenghui@huawei.com>
Subject: RE: [PATCH] iommu/arm: Cleanup resources in case of probe error path
Date: Thu, 1 Jul 2021 00:13:04 +0000 [thread overview]
Message-ID: <BY5PR12MB37645C97C01B1088122B5C7BB3009@BY5PR12MB3764.namprd12.prod.outlook.com> (raw)
In-Reply-To: <4e3b1685-323e-2a7e-3aae-7c21b28fc65f@samsung.com>
> +
> +err_pm_disable:
> + pm_runtime_disable(dev);
> return ret;
> }
Should it be pm_runtime_force_suspend()? qcom_iommu_device_remove() doesn't use pm_runtime_disable(dev).
875 static int qcom_iommu_device_remove(struct platform_device *pdev)
876 {
...
881 >-------pm_runtime_force_suspend(&pdev->dev);
882 >-------platform_set_drvdata(pdev, NULL);
883 >-------iommu_device_sysfs_remove(&qcom_iommu->iommu);
884 >-------iommu_device_unregister(&qcom_iommu->iommu);
...
887 }
-KR
WARNING: multiple messages have this Message-ID (diff)
From: Krishna Reddy <vdumpa@nvidia.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Will Deacon <will@kernel.org>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Amey Narkhede <ameynarkhede03@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Robin Murphy <robin.murphy@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH] iommu/arm: Cleanup resources in case of probe error path
Date: Thu, 1 Jul 2021 00:13:04 +0000 [thread overview]
Message-ID: <BY5PR12MB37645C97C01B1088122B5C7BB3009@BY5PR12MB3764.namprd12.prod.outlook.com> (raw)
In-Reply-To: <4e3b1685-323e-2a7e-3aae-7c21b28fc65f@samsung.com>
> +
> +err_pm_disable:
> + pm_runtime_disable(dev);
> return ret;
> }
Should it be pm_runtime_force_suspend()? qcom_iommu_device_remove() doesn't use pm_runtime_disable(dev).
875 static int qcom_iommu_device_remove(struct platform_device *pdev)
876 {
...
881 >-------pm_runtime_force_suspend(&pdev->dev);
882 >-------platform_set_drvdata(pdev, NULL);
883 >-------iommu_device_sysfs_remove(&qcom_iommu->iommu);
884 >-------iommu_device_unregister(&qcom_iommu->iommu);
...
887 }
-KR
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Krishna Reddy <vdumpa@nvidia.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Will Deacon <will@kernel.org>
Cc: Amey Narkhede <ameynarkhede03@gmail.com>,
Rob Clark <robdclark@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Barry Song <song.bao.hua@hisilicon.com>,
Zenghui Yu <yuzenghui@huawei.com>
Subject: RE: [PATCH] iommu/arm: Cleanup resources in case of probe error path
Date: Thu, 1 Jul 2021 00:13:04 +0000 [thread overview]
Message-ID: <BY5PR12MB37645C97C01B1088122B5C7BB3009@BY5PR12MB3764.namprd12.prod.outlook.com> (raw)
In-Reply-To: <4e3b1685-323e-2a7e-3aae-7c21b28fc65f@samsung.com>
> +
> +err_pm_disable:
> + pm_runtime_disable(dev);
> return ret;
> }
Should it be pm_runtime_force_suspend()? qcom_iommu_device_remove() doesn't use pm_runtime_disable(dev).
875 static int qcom_iommu_device_remove(struct platform_device *pdev)
876 {
...
881 >-------pm_runtime_force_suspend(&pdev->dev);
882 >-------platform_set_drvdata(pdev, NULL);
883 >-------iommu_device_sysfs_remove(&qcom_iommu->iommu);
884 >-------iommu_device_unregister(&qcom_iommu->iommu);
...
887 }
-KR
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-01 0:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 16:45 [PATCH] iommu/arm: Cleanup resources in case of probe error path Amey Narkhede
2021-06-08 16:45 ` Amey Narkhede
2021-06-08 16:45 ` Amey Narkhede
2021-06-08 17:16 ` Will Deacon
2021-06-08 17:16 ` Will Deacon
2021-06-08 17:16 ` Will Deacon
[not found] ` <CGME20210630124816eucas1p27563f0a456c0196e20937619aa2f8d26@eucas1p2.samsung.com>
2021-06-30 12:48 ` Marek Szyprowski
2021-06-30 12:48 ` Marek Szyprowski
2021-06-30 12:48 ` Marek Szyprowski
2021-06-30 12:59 ` Will Deacon
2021-06-30 12:59 ` Will Deacon
2021-06-30 12:59 ` Will Deacon
2021-06-30 13:48 ` Marek Szyprowski
2021-06-30 13:48 ` Marek Szyprowski
2021-06-30 13:48 ` Marek Szyprowski
2021-06-30 14:01 ` Robin Murphy
2021-06-30 14:01 ` Robin Murphy
2021-06-30 14:01 ` Robin Murphy
2021-07-01 8:29 ` Marek Szyprowski
2021-07-01 8:29 ` Marek Szyprowski
2021-07-01 8:29 ` Marek Szyprowski
2021-07-01 9:01 ` Will Deacon
2021-07-01 9:01 ` Will Deacon
2021-07-01 9:01 ` Will Deacon
2021-07-01 9:11 ` Robin Murphy
2021-07-01 9:11 ` Robin Murphy
2021-07-01 9:11 ` Robin Murphy
2021-07-01 9:26 ` Marek Szyprowski
2021-07-01 9:26 ` Marek Szyprowski
2021-07-01 9:26 ` Marek Szyprowski
2021-07-01 0:13 ` Krishna Reddy [this message]
2021-07-01 0:13 ` Krishna Reddy
2021-07-01 0:13 ` Krishna Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB37645C97C01B1088122B5C7BB3009@BY5PR12MB3764.namprd12.prod.outlook.com \
--to=vdumpa@nvidia.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=ameynarkhede03@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=song.bao.hua@hisilicon.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.