RE: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support

From: Tom Warren <TWarren@nvidia.com>
To: "Svyatoslav Ryhel" <clamor95@gmail.com>,
	"Marek Vasut" <marex@denx.de>,
	"Philippe Reynes" <philippe.reynes@softathome.com>,
	"Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
	"Fabio Estevam" <festevam@denx.de>,
	"Simon Glass" <sjg@chromium.org>,
	"Jonas Schwöbel" <jonasschwoebel@yahoo.de>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>
Subject: RE: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support
Date: Wed, 12 Apr 2023 23:07:01 +0000	[thread overview]
Message-ID: <BY5PR12MB3828B947E75302932C3CF3B0C19B9@BY5PR12MB3828.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230412194947.11578-1-clamor95@gmail.com>

Svyatoslav,

This series (patches 3 & 4, in particular) fails when applied to u-boot-tegra/master TOT. Error snippet is below (from make p2771-0000-500_defconfig && make):

CC      arch/arm/mach-tegra/fuse.o
arch/arm/mach-tegra/fuse.c:14:10: fatal error: asm/arch/clock.h: No such file or directory
 #include <asm/arch/clock.h>
          ^~~~~~~~~~~~~~~~~~
compilation terminated.
scripts/Makefile.build:256: recipe for target 'arch/arm/mach-tegra/fuse.o' failed
make[1]: *** [arch/arm/mach-tegra/fuse.o] Error 1
Makefile:1845: recipe for target 'arch/arm/mach-tegra' failed
make: *** [arch/arm/mach-tegra] Error 2

buildman/tegra also fails for that board, and 2 others.  Removing those two patches (3 & 4 in your Nexus7 patchset) gets make & buildman working again.
Buildman/tegra worked fine on the base u-boot-tegra/master repo (before I applied your patchset w/git am).

PTAL,

Tom

-----Original Message-----
From: Svyatoslav Ryhel <clamor95@gmail.com> 
Sent: Wednesday, April 12, 2023 12:50 PM
To: Tom Warren <twarren@nvidia.com>; Svyatoslav Ryhel <clamor95@gmail.com>; Marek Vasut <marex@denx.de>; Philippe Reynes <philippe.reynes@softathome.com>; Marcel Ziswiler <marcel.ziswiler@toradex.com>; Fabio Estevam <festevam@denx.de>; Simon Glass <sjg@chromium.org>; Jonas Schwöbel <jonasschwoebel@yahoo.de>
Cc: u-boot@lists.denx.de
Subject: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support

External email: Use caution opening links or attachments

This patchset adds support for native use of U-Boot on ASUS/Google Nexus 7 (2012), aka grouper/tilapia as a replacement of vendor bootloader. Alongside device bringup tegra requires few small patches:
 - add gpio keyboard as stdin device
 - make networking boot options optional
 - add a small tool to generate SoC UID

Jonas Schwöbel (1):
  configs: tegra-common-post: make PXE and DHCP boot targets optional

Svyatoslav Ryhel (3):
  configs: tegra-common-post: add GPIO keyboard as STDIN device
  ARM: tegra: add SoC UID calculation function
  board: asus: grouper: add Google Nexus 7 (2012) support

 arch/arm/dts/Makefile                         |   3 +
 arch/arm/dts/tegra30-asus-grouper-common.dtsi | 125 ++++++  .../dts/tegra30-asus-nexus7-grouper-E1565.dts |  40 ++  .../dts/tegra30-asus-nexus7-grouper-PM269.dts |  65 ++++  .../dts/tegra30-asus-nexus7-tilapia-E1565.dts |  40 ++
 arch/arm/include/asm/arch-tegra/fuse.h        |   7 +
 arch/arm/mach-tegra/Makefile                  |   2 +-
 arch/arm/mach-tegra/fuse.c                    | 151 ++++++++
 arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
 board/asus/grouper/Kconfig                    |  20 +
 board/asus/grouper/MAINTAINERS                |   6 +
 board/asus/grouper/Makefile                   |  14 +
 board/asus/grouper/grouper-spl-max.c          |  46 +++
 board/asus/grouper/grouper-spl-ti.c           |  42 ++
 board/asus/grouper/grouper.c                  | 209 ++++++++++
 board/asus/grouper/pinmux-config-grouper.h    | 362 ++++++++++++++++++
 configs/grouper_E1565.config                  |   2 +
 configs/grouper_PM269.config                  |   2 +
 configs/grouper_common_defconfig              |  85 ++++
 configs/tilapia.config                        |   3 +
 include/configs/grouper.h                     |  68 ++++
 include/configs/tegra-common-post.h           |  28 +-
 22 files changed, 1319 insertions(+), 6 deletions(-)  create mode 100644 arch/arm/dts/tegra30-asus-grouper-common.dtsi
 create mode 100644 arch/arm/dts/tegra30-asus-nexus7-grouper-E1565.dts
 create mode 100644 arch/arm/dts/tegra30-asus-nexus7-grouper-PM269.dts
 create mode 100644 arch/arm/dts/tegra30-asus-nexus7-tilapia-E1565.dts
 create mode 100644 arch/arm/mach-tegra/fuse.c  create mode 100644 board/asus/grouper/Kconfig  create mode 100644 board/asus/grouper/MAINTAINERS  create mode 100644 board/asus/grouper/Makefile  create mode 100644 board/asus/grouper/grouper-spl-max.c
 create mode 100644 board/asus/grouper/grouper-spl-ti.c
 create mode 100644 board/asus/grouper/grouper.c  create mode 100644 board/asus/grouper/pinmux-config-grouper.h
 create mode 100644 configs/grouper_E1565.config  create mode 100644 configs/grouper_PM269.config  create mode 100644 configs/grouper_common_defconfig  create mode 100644 configs/tilapia.config  create mode 100644 include/configs/grouper.h

--
2.37.2