RE: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support

[Svyatoslav Ryhel <clamor95@gmail.com>]

Only last commit (actual Nexus 7 bring up) is 
specific to Nexus 7, 3 commits before it are
common for all devices in interest. I assume
they all can be set in one patchset.

Though, I have some concerns about if I am
able to get perfect timing of merge. You see,
HTC One X and LG P895/P880 require some
additional drivers for their panels. I was
thinking about getting all these devices into
state ready to merge in this sequence and
then hold it till I will merge panel and bridge
drivers. U-Boot maintainers are a bit worried
if there are drivers merged and none of
supported devices uses it. Having merge-ready
devices should help with passing those drivers.

Another solution may be to merge devices as
they are and just pray that there will be no
defconfig re-sync which will remove all yet
non existing configs (like configs for panel
drivers). Maybe you can advice something?

About buildman. I am building on top of
U-Boot master. I will look into this deeper
and let you know. Sorry for disturbance and
thank you for your help and patience.

Best regards,
Svyatoslav R.

17 квітня 2023 р. 18:08:02 GMT+03:00, Tom Warren <TWarren@nvidia.com> написав(-ла):
>This patchset is specific to the Nexus 7, IIUC.  If the new devices also fall under that umbrella, then I see no problem with adding them here. But if they don't, maybe an ancillary patchset on top of this one would be better. 
>
>Note that I still can't build with your latest (v3) patchset - grouper fails buildman and make. And I don't know where you are getting the '-Pr' argument w/buildman, my version doesn't support a -r option AFAICT.
>
>tom@tom-ThinkPad-T580:~/denx/uboot-tegra$ buildman tegra30
>Building current source for 6 boards (6 threads, 2 jobs per thread)
>       arm:  +   grouper_common             
>+drivers/video/tegra.c:24:30: fatal error: asm/arch/display.h: No such file or directory
>+ #include <asm/arch/display.h>
>+                              ^
>+compilation terminated.
>+make[3]: *** [drivers/video/tegra.o] Error 1
>+make[2]: *** [drivers/video] Error 2
>+make[1]: *** [drivers] Error 2
>+make: *** [sub-make] Error 2
>    5    0    1 /6              0:00:14  : beaver          
>Completed: 6 total built, 6 newly), duration 0:01:26, rate 0.07
>
>Tom
>
>-----Original Message-----
>From: Svyatoslav Ryhel <clamor95@gmail.com> 
>Sent: Sunday, April 16, 2023 4:56 AM
>To: Tom Warren <TWarren@nvidia.com>
>Cc: Jonas Schwöbel <jonasschwoebel@yahoo.de>; u-boot@lists.denx.de
>Subject: RE: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support
>
>External email: Use caution opening links or attachments
>
>
>Mailing list reduction.
>
>Tom,
>
>May I extend this patchset with adding commits for other t20/t30 devices bringup. They are all typical and look like grouper bringup. This should decrease quantity of separate patches sent involving your assist. Devices in interest are Asus Transformers, LG P880/P895 and Htc One X.
>
>Best regards,
>Svyatoslav R.
>
>13 квітня 2023 р. 20:13:25 GMT+03:00, Tom Warren <TWarren@nvidia.com> написав(-ла):
>>Svyatoslav,
>>
>>I tried to build w/V2 of your Nexus patches applied to TOT u-boot-tegra/master, and I get these errors from 'buildman tegra':
>>
>>   aarch64:  +   p2771-0000-000
>>+In file included from arch/arm/mach-tegra/fuse.c:16:0:
>>+arch/arm/include/asm/arch-tegra/clock.h:42:10: fatal error: 
>>+asm/arch/clock-tables.h: No such file or directory  #include <asm/arch/clock-tables.h>
>>+          ^~~~~~~~~~~~~~~~~~~~~~~~~
>>+compilation terminated.
>>+make[2]: *** [arch/arm/mach-tegra/fuse.o] Error 1
>>+make[1]: *** [arch/arm/mach-tegra] Error 2
>>+make: *** [sub-make] Error 2
>>   aarch64:  +   p2771-0000-500
>>+In file included from arch/arm/mach-tegra/fuse.c:16:0:
>>+arch/arm/include/asm/arch-tegra/clock.h:42:10: fatal error: 
>>+asm/arch/clock-tables.h: No such file or directory  #include <asm/arch/clock-tables.h>
>>+          ^~~~~~~~~~~~~~~~~~~~~~~~~
>>+compilation terminated.
>>+make[2]: *** [arch/arm/mach-tegra/fuse.o] Error 1
>>+make[1]: *** [arch/arm/mach-tegra] Error 2
>>+make: *** [sub-make] Error 2
>>
>>These are the two T186 builds, they don't have or use a clock-tables.h .
>>
>>Please test building your patchset on TOT u-boot-tegra/master _before_ posting. Use buildman (preferred) or 'make xxx_defconfig && make' for each Tegra board (cumbersome).
>>
>>I won't take any future patches from you unless they're marked w/'passes buildman' or 'each Tegra board builds OK w/make', etc.  I certainly can't push a PR to TomR if it fails to build.
>>
>>Tom
>>
>>-----Original Message-----
>>From: Svyatoslav Ryhel <clamor95@gmail.com>
>>Sent: Wednesday, April 12, 2023 11:05 PM
>>To: Tom Warren <TWarren@nvidia.com>
>>Cc: Marek Vasut <marex@denx.de>; Philippe Reynes 
>><philippe.reynes@softathome.com>; Marcel Ziswiler 
>><marcel.ziswiler@toradex.com>; Fabio Estevam <festevam@denx.de>; Simon 
>>Glass <sjg@chromium.org>; Jonas Schwöbel <jonasschwoebel@yahoo.de>; 
>>u-boot@lists.denx.de
>>Subject: Re: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) 
>>support
>>
>>External email: Use caution opening links or attachments
>>
>>
>>чт, 13 квіт. 2023 р. о 02:07 Tom Warren <TWarren@nvidia.com> пише:
>>>
>>> Svyatoslav,
>>>
>>> This series (patches 3 & 4, in particular) fails when applied to u-boot-tegra/master TOT. Error snippet is below (from make p2771-0000-500_defconfig && make):
>>>
>>> CC      arch/arm/mach-tegra/fuse.o
>>> arch/arm/mach-tegra/fuse.c:14:10: fatal error: asm/arch/clock.h: No 
>>> such file or directory  #include <asm/arch/clock.h>
>>>           ^~~~~~~~~~~~~~~~~~
>>> compilation terminated.
>>> scripts/Makefile.build:256: recipe for target 
>>> 'arch/arm/mach-tegra/fuse.o' failed
>>> make[1]: *** [arch/arm/mach-tegra/fuse.o] Error 1
>>> Makefile:1845: recipe for target 'arch/arm/mach-tegra' failed
>>> make: *** [arch/arm/mach-tegra] Error 2
>>
>>Hello Tom.
>>
>>Thanks for your check. Issue was caused by non exposed headers for T186.
>>I have fixed that in v2, I hope buildman will pass. Additionally I have modified grouper defconfig in such a way that it should pass even without device fragment.
>>
>>Best regards,
>>Svyatoslav R.
>>
>>>
>>> buildman/tegra also fails for that board, and 2 others.  Removing those two patches (3 & 4 in your Nexus7 patchset) gets make & buildman working again.
>>> Buildman/tegra worked fine on the base u-boot-tegra/master repo (before I applied your patchset w/git am).
>>>
>>> PTAL,
>>>
>>> Tom
>>>
>>> -----Original Message-----
>>> From: Svyatoslav Ryhel <clamor95@gmail.com>
>>> Sent: Wednesday, April 12, 2023 12:50 PM
>>> To: Tom Warren <twarren@nvidia.com>; Svyatoslav Ryhel 
>>> <clamor95@gmail.com>; Marek Vasut <marex@denx.de>; Philippe Reynes 
>>> <philippe.reynes@softathome.com>; Marcel Ziswiler 
>>> <marcel.ziswiler@toradex.com>; Fabio Estevam <festevam@denx.de>; 
>>> Simon Glass <sjg@chromium.org>; Jonas Schwöbel 
>>> <jonasschwoebel@yahoo.de>
>>> Cc: u-boot@lists.denx.de
>>> Subject: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support
>>>
>>> External email: Use caution opening links or attachments
>>>
>>>
>>> This patchset adds support for native use of U-Boot on ASUS/Google Nexus 7 (2012), aka grouper/tilapia as a replacement of vendor bootloader. Alongside device bringup tegra requires few small patches:
>>>  - add gpio keyboard as stdin device
>>>  - make networking boot options optional
>>>  - add a small tool to generate SoC UID
>>>
>>> Jonas Schwöbel (1):
>>>   configs: tegra-common-post: make PXE and DHCP boot targets optional
>>>
>>> Svyatoslav Ryhel (3):
>>>   configs: tegra-common-post: add GPIO keyboard as STDIN device
>>>   ARM: tegra: add SoC UID calculation function
>>>   board: asus: grouper: add Google Nexus 7 (2012) support
>>>
>>>  arch/arm/dts/Makefile                         |   3 +
>>>  arch/arm/dts/tegra30-asus-grouper-common.dtsi | 125 ++++++  .../dts/tegra30-asus-nexus7-grouper-E1565.dts |  40 ++  .../dts/tegra30-asus-nexus7-grouper-PM269.dts |  65 ++++  .../dts/tegra30-asus-nexus7-tilapia-E1565.dts |  40 ++
>>>  arch/arm/include/asm/arch-tegra/fuse.h        |   7 +
>>>  arch/arm/mach-tegra/Makefile                  |   2 +-
>>>  arch/arm/mach-tegra/fuse.c                    | 151 ++++++++
>>>  arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
>>>  board/asus/grouper/Kconfig                    |  20 +
>>>  board/asus/grouper/MAINTAINERS                |   6 +
>>>  board/asus/grouper/Makefile                   |  14 +
>>>  board/asus/grouper/grouper-spl-max.c          |  46 +++
>>>  board/asus/grouper/grouper-spl-ti.c           |  42 ++
>>>  board/asus/grouper/grouper.c                  | 209 ++++++++++
>>>  board/asus/grouper/pinmux-config-grouper.h    | 362 ++++++++++++++++++
>>>  configs/grouper_E1565.config                  |   2 +
>>>  configs/grouper_PM269.config                  |   2 +
>>>  configs/grouper_common_defconfig              |  85 ++++
>>>  configs/tilapia.config                        |   3 +
>>>  include/configs/grouper.h                     |  68 ++++
>>>  include/configs/tegra-common-post.h           |  28 +-
>>>  22 files changed, 1319 insertions(+), 6 deletions(-)  create mode
>>> 100644 arch/arm/dts/tegra30-asus-grouper-common.dtsi
>>>  create mode 100644 
>>> arch/arm/dts/tegra30-asus-nexus7-grouper-E1565.dts
>>>  create mode 100644 
>>> arch/arm/dts/tegra30-asus-nexus7-grouper-PM269.dts
>>>  create mode 100644 
>>> arch/arm/dts/tegra30-asus-nexus7-tilapia-E1565.dts
>>>  create mode 100644 arch/arm/mach-tegra/fuse.c  create mode 100644 
>>> board/asus/grouper/Kconfig  create mode 100644 
>>> board/asus/grouper/MAINTAINERS  create mode 100644 
>>> board/asus/grouper/Makefile  create mode 100644 
>>> board/asus/grouper/grouper-spl-max.c
>>>  create mode 100644 board/asus/grouper/grouper-spl-ti.c
>>>  create mode 100644 board/asus/grouper/grouper.c  create mode 100644 
>>> board/asus/grouper/pinmux-config-grouper.h
>>>  create mode 100644 configs/grouper_E1565.config  create mode 100644 
>>> configs/grouper_PM269.config  create mode 100644 
>>> configs/grouper_common_defconfig  create mode 100644 
>>> configs/tilapia.config  create mode 100644 include/configs/grouper.h
>>>
>>> --
>>> 2.37.2
>>>