* [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
@ 2022-09-01 7:29 Yifan Zhang
2022-09-01 22:43 ` Huang, Tim
0 siblings, 1 reply; 7+ messages in thread
From: Yifan Zhang @ 2022-09-01 7:29 UTC (permalink / raw)
To: amd-gfx; +Cc: Alexander.Deucher, Tim.Huang, Xiaojian.Du, Yifan Zhang
Current discovery table doesn't have cache info for GC 11.0.1, thus
can't be parsed like other GC 11, this patch to match GC 11.0.1
cache info to yellow carp
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
index 24b414cff3ec..1c500bfb0b28 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
@@ -1516,11 +1516,11 @@ static int kfd_fill_gpu_cache_info(struct kfd_dev *kdev,
case IP_VERSION(10, 3, 3):
case IP_VERSION(10, 3, 6): /* TODO: Double check these on production silicon */
case IP_VERSION(10, 3, 7): /* TODO: Double check these on production silicon */
+ case IP_VERSION(11, 0, 1): /* TODO: Double check these on production silicon */
pcache_info = yellow_carp_cache_info;
num_of_cache_types = ARRAY_SIZE(yellow_carp_cache_info);
break;
case IP_VERSION(11, 0, 0):
- case IP_VERSION(11, 0, 1):
case IP_VERSION(11, 0, 2):
case IP_VERSION(11, 0, 3):
pcache_info = cache_info;
--
2.37.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
2022-09-01 7:29 [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp Yifan Zhang
@ 2022-09-01 22:43 ` Huang, Tim
2022-09-02 1:44 ` Liu, Aaron
0 siblings, 1 reply; 7+ messages in thread
From: Huang, Tim @ 2022-09-01 22:43 UTC (permalink / raw)
To: Zhang, Yifan, amd-gfx; +Cc: Deucher, Alexander, Du, Xiaojian
[Public]
Reviewed-by: Tim Huang <Tim.Huang@amd.com>
Best Regards,
Tim Huang
-----Original Message-----
From: Zhang, Yifan <Yifan1.Zhang@amd.com>
Sent: Thursday, September 1, 2022 3:30 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Tim <Tim.Huang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>
Subject: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
Current discovery table doesn't have cache info for GC 11.0.1, thus can't be parsed like other GC 11, this patch to match GC 11.0.1 cache info to yellow carp
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
index 24b414cff3ec..1c500bfb0b28 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
@@ -1516,11 +1516,11 @@ static int kfd_fill_gpu_cache_info(struct kfd_dev *kdev,
case IP_VERSION(10, 3, 3):
case IP_VERSION(10, 3, 6): /* TODO: Double check these on production silicon */
case IP_VERSION(10, 3, 7): /* TODO: Double check these on production silicon */
+ case IP_VERSION(11, 0, 1): /* TODO: Double check these on production
+silicon */
pcache_info = yellow_carp_cache_info;
num_of_cache_types = ARRAY_SIZE(yellow_carp_cache_info);
break;
case IP_VERSION(11, 0, 0):
- case IP_VERSION(11, 0, 1):
case IP_VERSION(11, 0, 2):
case IP_VERSION(11, 0, 3):
pcache_info = cache_info;
--
2.37.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
2022-09-01 22:43 ` Huang, Tim
@ 2022-09-02 1:44 ` Liu, Aaron
2022-09-02 2:27 ` Zhang, Yifan
0 siblings, 1 reply; 7+ messages in thread
From: Liu, Aaron @ 2022-09-02 1:44 UTC (permalink / raw)
To: Huang, Tim, Zhang, Yifan, amd-gfx; +Cc: Deucher, Alexander, Du, Xiaojian
[Public]
Hi Yifan,
Yellow carp's cache info cannot be duplicated to GC_11_0_1.
Different point to GC_11_0_1:
TCP L1 Cache size is 32
GL1 Data Cache size per SA is 256
Others looks good to me
--
Best Regards
Aaron Liu
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Huang, Tim
> Sent: Friday, September 2, 2022 6:44 AM
> To: Zhang, Yifan <Yifan1.Zhang@amd.com>; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian
> <Xiaojian.Du@amd.com>
> Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
>
> [Public]
>
> [Public]
>
> Reviewed-by: Tim Huang <Tim.Huang@amd.com>
>
> Best Regards,
> Tim Huang
>
>
>
> -----Original Message-----
> From: Zhang, Yifan <Yifan1.Zhang@amd.com>
> Sent: Thursday, September 1, 2022 3:30 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Tim
> <Tim.Huang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Zhang,
> Yifan <Yifan1.Zhang@amd.com>
> Subject: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
>
> Current discovery table doesn't have cache info for GC 11.0.1, thus can't be
> parsed like other GC 11, this patch to match GC 11.0.1 cache info to yellow
> carp
>
> Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index 24b414cff3ec..1c500bfb0b28 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -1516,11 +1516,11 @@ static int kfd_fill_gpu_cache_info(struct kfd_dev
> *kdev,
> case IP_VERSION(10, 3, 3):
> case IP_VERSION(10, 3, 6): /* TODO: Double check these on
> production silicon */
> case IP_VERSION(10, 3, 7): /* TODO: Double check these on
> production silicon */
> + case IP_VERSION(11, 0, 1): /* TODO: Double check these
> +on production silicon */
> pcache_info = yellow_carp_cache_info;
> num_of_cache_types = ARRAY_SIZE(yellow_carp_cache_info);
> break;
> case IP_VERSION(11, 0, 0):
> - case IP_VERSION(11, 0, 1):
> case IP_VERSION(11, 0, 2):
> case IP_VERSION(11, 0, 3):
> pcache_info = cache_info;
> --
> 2.37.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
2022-09-02 1:44 ` Liu, Aaron
@ 2022-09-02 2:27 ` Zhang, Yifan
2022-09-05 1:23 ` Liang, Prike
0 siblings, 1 reply; 7+ messages in thread
From: Zhang, Yifan @ 2022-09-02 2:27 UTC (permalink / raw)
To: Liu, Aaron, Huang, Tim, amd-gfx; +Cc: Deucher, Alexander, Du, Xiaojian
[Public]
Hi Aaron,
Yes, the cache info are different. But this diff is intentional to workaround the discovery table lacks cache info in GC 11.0.1 issue. The workaround will be removed after discovery table finishes integrating cache info. Given they already have a test version, we can pend this patch until they finish integration.
Best Regards,
Yifan
-----Original Message-----
From: Liu, Aaron <Aaron.Liu@amd.com>
Sent: Friday, September 2, 2022 9:44 AM
To: Huang, Tim <Tim.Huang@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>
Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
[Public]
Hi Yifan,
Yellow carp's cache info cannot be duplicated to GC_11_0_1.
Different point to GC_11_0_1:
TCP L1 Cache size is 32
GL1 Data Cache size per SA is 256
Others looks good to me
--
Best Regards
Aaron Liu
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Huang, Tim
> Sent: Friday, September 2, 2022 6:44 AM
> To: Zhang, Yifan <Yifan1.Zhang@amd.com>; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian
> <Xiaojian.Du@amd.com>
> Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow
> carp
>
> [Public]
>
> [Public]
>
> Reviewed-by: Tim Huang <Tim.Huang@amd.com>
>
> Best Regards,
> Tim Huang
>
>
>
> -----Original Message-----
> From: Zhang, Yifan <Yifan1.Zhang@amd.com>
> Sent: Thursday, September 1, 2022 3:30 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Tim
> <Tim.Huang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Zhang, Yifan
> <Yifan1.Zhang@amd.com>
> Subject: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
>
> Current discovery table doesn't have cache info for GC 11.0.1, thus
> can't be parsed like other GC 11, this patch to match GC 11.0.1 cache
> info to yellow carp
>
> Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index 24b414cff3ec..1c500bfb0b28 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -1516,11 +1516,11 @@ static int kfd_fill_gpu_cache_info(struct
> kfd_dev *kdev,
> case IP_VERSION(10, 3, 3):
> case IP_VERSION(10, 3, 6): /* TODO: Double check these
> on production silicon */
> case IP_VERSION(10, 3, 7): /* TODO: Double check these
> on production silicon */
> + case IP_VERSION(11, 0, 1): /* TODO: Double check these
> +on production silicon */
> pcache_info = yellow_carp_cache_info;
> num_of_cache_types = ARRAY_SIZE(yellow_carp_cache_info);
> break;
> case IP_VERSION(11, 0, 0):
> - case IP_VERSION(11, 0, 1):
> case IP_VERSION(11, 0, 2):
> case IP_VERSION(11, 0, 3):
> pcache_info = cache_info;
> --
> 2.37.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
2022-09-02 2:27 ` Zhang, Yifan
@ 2022-09-05 1:23 ` Liang, Prike
2022-09-05 1:46 ` Zhang, Yifan
0 siblings, 1 reply; 7+ messages in thread
From: Liang, Prike @ 2022-09-05 1:23 UTC (permalink / raw)
To: Zhang, Yifan, Liu, Aaron, Huang, Tim, amd-gfx
Cc: Deucher, Alexander, Kuehling, Felix, Huang, Ray, Du, Xiaojian
How about add a dummy cache info for the NPI product in the default case and notify user that's using the dummy cache configuration to make sure not miss correcting the HW info in the future?
Regards,
--Prike
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Zhang, Yifan
Sent: Friday, September 2, 2022 10:28 AM
To: Liu, Aaron <Aaron.Liu@amd.com>; Huang, Tim <Tim.Huang@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>
Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
[Public]
Hi Aaron,
Yes, the cache info are different. But this diff is intentional to workaround the discovery table lacks cache info in GC 11.0.1 issue. The workaround will be removed after discovery table finishes integrating cache info. Given they already have a test version, we can pend this patch until they finish integration.
Best Regards,
Yifan
-----Original Message-----
From: Liu, Aaron <Aaron.Liu@amd.com>
Sent: Friday, September 2, 2022 9:44 AM
To: Huang, Tim <Tim.Huang@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>
Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
[Public]
Hi Yifan,
Yellow carp's cache info cannot be duplicated to GC_11_0_1.
Different point to GC_11_0_1:
TCP L1 Cache size is 32
GL1 Data Cache size per SA is 256
Others looks good to me
--
Best Regards
Aaron Liu
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Huang, Tim
> Sent: Friday, September 2, 2022 6:44 AM
> To: Zhang, Yifan <Yifan1.Zhang@amd.com>; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian
> <Xiaojian.Du@amd.com>
> Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow
> carp
>
> [Public]
>
> [Public]
>
> Reviewed-by: Tim Huang <Tim.Huang@amd.com>
>
> Best Regards,
> Tim Huang
>
>
>
> -----Original Message-----
> From: Zhang, Yifan <Yifan1.Zhang@amd.com>
> Sent: Thursday, September 1, 2022 3:30 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Tim
> <Tim.Huang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Zhang, Yifan
> <Yifan1.Zhang@amd.com>
> Subject: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
>
> Current discovery table doesn't have cache info for GC 11.0.1, thus
> can't be parsed like other GC 11, this patch to match GC 11.0.1 cache
> info to yellow carp
>
> Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index 24b414cff3ec..1c500bfb0b28 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -1516,11 +1516,11 @@ static int kfd_fill_gpu_cache_info(struct
> kfd_dev *kdev,
> case IP_VERSION(10, 3, 3):
> case IP_VERSION(10, 3, 6): /* TODO: Double check these
> on production silicon */
> case IP_VERSION(10, 3, 7): /* TODO: Double check these
> on production silicon */
> + case IP_VERSION(11, 0, 1): /* TODO: Double check these
> +on production silicon */
> pcache_info = yellow_carp_cache_info;
> num_of_cache_types = ARRAY_SIZE(yellow_carp_cache_info);
> break;
> case IP_VERSION(11, 0, 0):
> - case IP_VERSION(11, 0, 1):
> case IP_VERSION(11, 0, 2):
> case IP_VERSION(11, 0, 3):
> pcache_info = cache_info;
> --
> 2.37.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
2022-09-05 1:23 ` Liang, Prike
@ 2022-09-05 1:46 ` Zhang, Yifan
2022-09-05 2:19 ` Liang, Prike
0 siblings, 1 reply; 7+ messages in thread
From: Zhang, Yifan @ 2022-09-05 1:46 UTC (permalink / raw)
To: Liang, Prike, Liu, Aaron, Huang, Tim, amd-gfx
Cc: Deucher, Alexander, Kuehling, Felix, Huang, Ray, Du, Xiaojian
[Public]
It is actually a bug of discovery table which needs to be identified in NPI phase. Hopefully we don't need neither dummy nor yellow carp cache info in the future.
Best Regards,
Yifan
-----Original Message-----
From: Liang, Prike <Prike.Liang@amd.com>
Sent: Monday, September 5, 2022 9:24 AM
To: Zhang, Yifan <Yifan1.Zhang@amd.com>; Liu, Aaron <Aaron.Liu@amd.com>; Huang, Tim <Tim.Huang@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Huang, Ray <Ray.Huang@amd.com>; Kuehling, Felix <Felix.Kuehling@amd.com>
Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
How about add a dummy cache info for the NPI product in the default case and notify user that's using the dummy cache configuration to make sure not miss correcting the HW info in the future?
Regards,
--Prike
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Zhang, Yifan
Sent: Friday, September 2, 2022 10:28 AM
To: Liu, Aaron <Aaron.Liu@amd.com>; Huang, Tim <Tim.Huang@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>
Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
[Public]
Hi Aaron,
Yes, the cache info are different. But this diff is intentional to workaround the discovery table lacks cache info in GC 11.0.1 issue. The workaround will be removed after discovery table finishes integrating cache info. Given they already have a test version, we can pend this patch until they finish integration.
Best Regards,
Yifan
-----Original Message-----
From: Liu, Aaron <Aaron.Liu@amd.com>
Sent: Friday, September 2, 2022 9:44 AM
To: Huang, Tim <Tim.Huang@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>
Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
[Public]
Hi Yifan,
Yellow carp's cache info cannot be duplicated to GC_11_0_1.
Different point to GC_11_0_1:
TCP L1 Cache size is 32
GL1 Data Cache size per SA is 256
Others looks good to me
--
Best Regards
Aaron Liu
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Huang, Tim
> Sent: Friday, September 2, 2022 6:44 AM
> To: Zhang, Yifan <Yifan1.Zhang@amd.com>; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian
> <Xiaojian.Du@amd.com>
> Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow
> carp
>
> [Public]
>
> [Public]
>
> Reviewed-by: Tim Huang <Tim.Huang@amd.com>
>
> Best Regards,
> Tim Huang
>
>
>
> -----Original Message-----
> From: Zhang, Yifan <Yifan1.Zhang@amd.com>
> Sent: Thursday, September 1, 2022 3:30 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Tim
> <Tim.Huang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Zhang, Yifan
> <Yifan1.Zhang@amd.com>
> Subject: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
>
> Current discovery table doesn't have cache info for GC 11.0.1, thus
> can't be parsed like other GC 11, this patch to match GC 11.0.1 cache
> info to yellow carp
>
> Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index 24b414cff3ec..1c500bfb0b28 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -1516,11 +1516,11 @@ static int kfd_fill_gpu_cache_info(struct
> kfd_dev *kdev,
> case IP_VERSION(10, 3, 3):
> case IP_VERSION(10, 3, 6): /* TODO: Double check these
> on production silicon */
> case IP_VERSION(10, 3, 7): /* TODO: Double check these
> on production silicon */
> + case IP_VERSION(11, 0, 1): /* TODO: Double check these
> +on production silicon */
> pcache_info = yellow_carp_cache_info;
> num_of_cache_types = ARRAY_SIZE(yellow_carp_cache_info);
> break;
> case IP_VERSION(11, 0, 0):
> - case IP_VERSION(11, 0, 1):
> case IP_VERSION(11, 0, 2):
> case IP_VERSION(11, 0, 3):
> pcache_info = cache_info;
> --
> 2.37.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
2022-09-05 1:46 ` Zhang, Yifan
@ 2022-09-05 2:19 ` Liang, Prike
0 siblings, 0 replies; 7+ messages in thread
From: Liang, Prike @ 2022-09-05 2:19 UTC (permalink / raw)
To: Zhang, Yifan, Liu, Aaron, Huang, Tim, amd-gfx
Cc: Deucher, Alexander, Kuehling, Felix, Huang, Ray, Du, Xiaojian
If not sure whether the discovery table can be fulfilled the cache info in the upcoming NPI ASICs, maybe need the dummy cache info in the default clause case rather than add more and more faking some specific HW configuration and sometimes that may give misleading HW info.
Regards,
--Prike
-----Original Message-----
From: Zhang, Yifan <Yifan1.Zhang@amd.com>
Sent: Monday, September 5, 2022 9:47 AM
To: Liang, Prike <Prike.Liang@amd.com>; Liu, Aaron <Aaron.Liu@amd.com>; Huang, Tim <Tim.Huang@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Huang, Ray <Ray.Huang@amd.com>; Kuehling, Felix <Felix.Kuehling@amd.com>
Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
[Public]
It is actually a bug of discovery table which needs to be identified in NPI phase. Hopefully we don't need neither dummy nor yellow carp cache info in the future.
Best Regards,
Yifan
-----Original Message-----
From: Liang, Prike <Prike.Liang@amd.com>
Sent: Monday, September 5, 2022 9:24 AM
To: Zhang, Yifan <Yifan1.Zhang@amd.com>; Liu, Aaron <Aaron.Liu@amd.com>; Huang, Tim <Tim.Huang@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Huang, Ray <Ray.Huang@amd.com>; Kuehling, Felix <Felix.Kuehling@amd.com>
Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
How about add a dummy cache info for the NPI product in the default case and notify user that's using the dummy cache configuration to make sure not miss correcting the HW info in the future?
Regards,
--Prike
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Zhang, Yifan
Sent: Friday, September 2, 2022 10:28 AM
To: Liu, Aaron <Aaron.Liu@amd.com>; Huang, Tim <Tim.Huang@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>
Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
[Public]
Hi Aaron,
Yes, the cache info are different. But this diff is intentional to workaround the discovery table lacks cache info in GC 11.0.1 issue. The workaround will be removed after discovery table finishes integrating cache info. Given they already have a test version, we can pend this patch until they finish integration.
Best Regards,
Yifan
-----Original Message-----
From: Liu, Aaron <Aaron.Liu@amd.com>
Sent: Friday, September 2, 2022 9:44 AM
To: Huang, Tim <Tim.Huang@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>
Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
[Public]
Hi Yifan,
Yellow carp's cache info cannot be duplicated to GC_11_0_1.
Different point to GC_11_0_1:
TCP L1 Cache size is 32
GL1 Data Cache size per SA is 256
Others looks good to me
--
Best Regards
Aaron Liu
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Huang, Tim
> Sent: Friday, September 2, 2022 6:44 AM
> To: Zhang, Yifan <Yifan1.Zhang@amd.com>; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Du, Xiaojian
> <Xiaojian.Du@amd.com>
> Subject: RE: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow
> carp
>
> [Public]
>
> [Public]
>
> Reviewed-by: Tim Huang <Tim.Huang@amd.com>
>
> Best Regards,
> Tim Huang
>
>
>
> -----Original Message-----
> From: Zhang, Yifan <Yifan1.Zhang@amd.com>
> Sent: Thursday, September 1, 2022 3:30 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Tim
> <Tim.Huang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Zhang, Yifan
> <Yifan1.Zhang@amd.com>
> Subject: [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp
>
> Current discovery table doesn't have cache info for GC 11.0.1, thus
> can't be parsed like other GC 11, this patch to match GC 11.0.1 cache
> info to yellow carp
>
> Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index 24b414cff3ec..1c500bfb0b28 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -1516,11 +1516,11 @@ static int kfd_fill_gpu_cache_info(struct
> kfd_dev *kdev,
> case IP_VERSION(10, 3, 3):
> case IP_VERSION(10, 3, 6): /* TODO: Double check these
> on production silicon */
> case IP_VERSION(10, 3, 7): /* TODO: Double check these
> on production silicon */
> + case IP_VERSION(11, 0, 1): /* TODO: Double check these
> +on production silicon */
> pcache_info = yellow_carp_cache_info;
> num_of_cache_types = ARRAY_SIZE(yellow_carp_cache_info);
> break;
> case IP_VERSION(11, 0, 0):
> - case IP_VERSION(11, 0, 1):
> case IP_VERSION(11, 0, 2):
> case IP_VERSION(11, 0, 3):
> pcache_info = cache_info;
> --
> 2.37.1
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-05 2:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01 7:29 [PATCH] drm/amdkfd: Match GC 11.0.1 cache info to yellow carp Yifan Zhang
2022-09-01 22:43 ` Huang, Tim
2022-09-02 1:44 ` Liu, Aaron
2022-09-02 2:27 ` Zhang, Yifan
2022-09-05 1:23 ` Liang, Prike
2022-09-05 1:46 ` Zhang, Yifan
2022-09-05 2:19 ` Liang, Prike
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.