All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] drm/amdgpu: remove unused variable
@ 2020-05-26 13:03 Nirmoy Das
  2020-05-26 13:21 ` Wang, Kevin(Yang)
  0 siblings, 1 reply; 5+ messages in thread
From: Nirmoy Das @ 2020-05-26 13:03 UTC (permalink / raw)
  To: amd-gfx; +Cc: nirmoy.das

Fixes: 1291bd70a2ee4 ("drm/amdgpu/sriov skip the update of SMU_TABLE_ACTIVITY_MONITOR_COEFF")

Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
---
 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
index 7f414034d2ef..67980f50d8ec 100644
--- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
@@ -1335,7 +1335,6 @@ static int arcturus_get_power_limit(struct smu_context *smu,
 static int arcturus_get_power_profile_mode(struct smu_context *smu,
 					   char *buf)
 {
-	struct amdgpu_device *adev = smu->adev;
 	DpmActivityMonitorCoeffInt_t activity_monitor;
 	static const char *profile_name[] = {
 					"BOOTUP_DEFAULT",
-- 
2.26.2

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] drm/amdgpu: remove unused variable
  2020-05-26 13:03 [PATCH 1/1] drm/amdgpu: remove unused variable Nirmoy Das
@ 2020-05-26 13:21 ` Wang, Kevin(Yang)
  0 siblings, 0 replies; 5+ messages in thread
From: Wang, Kevin(Yang) @ 2020-05-26 13:21 UTC (permalink / raw)
  To: Nirmoy Das, amd-gfx; +Cc: Das, Nirmoy


[-- Attachment #1.1: Type: text/plain, Size: 1834 bytes --]

[AMD Official Use Only - Internal Distribution Only]

Reviewed-by: Kevin Wang <kevin1.wang@amd.com>

Best Regards,
Kevin
________________________________
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Nirmoy Das <nirmoy.aiemd@gmail.com>
Sent: Tuesday, May 26, 2020 9:03 PM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Das, Nirmoy <Nirmoy.Das@amd.com>
Subject: [PATCH 1/1] drm/amdgpu: remove unused variable

Fixes: 1291bd70a2ee4 ("drm/amdgpu/sriov skip the update of SMU_TABLE_ACTIVITY_MONITOR_COEFF")

Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
---
 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
index 7f414034d2ef..67980f50d8ec 100644
--- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
@@ -1335,7 +1335,6 @@ static int arcturus_get_power_limit(struct smu_context *smu,
 static int arcturus_get_power_profile_mode(struct smu_context *smu,
                                            char *buf)
 {
-       struct amdgpu_device *adev = smu->adev;
         DpmActivityMonitorCoeffInt_t activity_monitor;
         static const char *profile_name[] = {
                                         "BOOTUP_DEFAULT",
--
2.26.2

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7CKevin1.Wang%40amd.com%7C89d1e7c484d245eb2c3008d801752b56%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637260950051221593&amp;sdata=OaC97%2F%2B9vUXRVY8jTvGQnaMQbMpvlIv1tCR9u9dHlz8%3D&amp;reserved=0

[-- Attachment #1.2: Type: text/html, Size: 4062 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] drm/amdgpu: Remove unused variable
  2021-01-12 21:38 ` Alex Deucher
@ 2021-01-13 14:13   ` Christian König
  0 siblings, 0 replies; 5+ messages in thread
From: Christian König @ 2021-01-13 14:13 UTC (permalink / raw)
  To: Alex Deucher, Nirmoy Das; +Cc: Maling list - DRI developers

Am 12.01.21 um 22:38 schrieb Alex Deucher:
> On Tue, Jan 12, 2021 at 12:46 PM Nirmoy Das <nirmoy.das@amd.com> wrote:
>> Remove unused space_needed variable.
>>
>> Fixes: 453f617a30a ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")
>> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Have you already pushed this to drm-misc-next or should I take care of this?

Christian.

>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> index 348ac678a230..5888367b1000 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> @@ -1106,7 +1106,6 @@ void amdgpu_device_wb_free(struct amdgpu_device *adev, u32 wb)
>>    */
>>   int amdgpu_device_resize_fb_bar(struct amdgpu_device *adev)
>>   {
>> -       u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size);
>>          int rbar_size = pci_rebar_bytes_to_size(adev->gmc.real_vram_size);
>>          struct pci_bus *root;
>>          struct resource *res;
>> --
>> 2.29.2
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=04%7C01%7CChristian.Koenig%40amd.com%7C55c33bd6f6874a973bff08d8b742783e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637460843402778720%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=yizQB3RyltggTngn047YcPSDW3rFOTHffuVtDY3k3mI%3D&amp;reserved=0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] drm/amdgpu: Remove unused variable
  2021-01-12 17:46 [PATCH 1/1] drm/amdgpu: Remove " Nirmoy Das
@ 2021-01-12 21:38 ` Alex Deucher
  2021-01-13 14:13   ` Christian König
  0 siblings, 1 reply; 5+ messages in thread
From: Alex Deucher @ 2021-01-12 21:38 UTC (permalink / raw)
  To: Nirmoy Das; +Cc: Christian Koenig, Maling list - DRI developers

On Tue, Jan 12, 2021 at 12:46 PM Nirmoy Das <nirmoy.das@amd.com> wrote:
>
> Remove unused space_needed variable.
>
> Fixes: 453f617a30a ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 348ac678a230..5888367b1000 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1106,7 +1106,6 @@ void amdgpu_device_wb_free(struct amdgpu_device *adev, u32 wb)
>   */
>  int amdgpu_device_resize_fb_bar(struct amdgpu_device *adev)
>  {
> -       u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size);
>         int rbar_size = pci_rebar_bytes_to_size(adev->gmc.real_vram_size);
>         struct pci_bus *root;
>         struct resource *res;
> --
> 2.29.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH 1/1] drm/amdgpu: Remove unused variable
@ 2021-01-12 17:46 Nirmoy Das
  2021-01-12 21:38 ` Alex Deucher
  0 siblings, 1 reply; 5+ messages in thread
From: Nirmoy Das @ 2021-01-12 17:46 UTC (permalink / raw)
  To: Christian.Koenig; +Cc: Nirmoy Das, dri-devel

Remove unused space_needed variable.

Fixes: 453f617a30a ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")
Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 348ac678a230..5888367b1000 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1106,7 +1106,6 @@ void amdgpu_device_wb_free(struct amdgpu_device *adev, u32 wb)
  */
 int amdgpu_device_resize_fb_bar(struct amdgpu_device *adev)
 {
-	u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size);
 	int rbar_size = pci_rebar_bytes_to_size(adev->gmc.real_vram_size);
 	struct pci_bus *root;
 	struct resource *res;
-- 
2.29.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-13 14:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-26 13:03 [PATCH 1/1] drm/amdgpu: remove unused variable Nirmoy Das
2020-05-26 13:21 ` Wang, Kevin(Yang)
2021-01-12 17:46 [PATCH 1/1] drm/amdgpu: Remove " Nirmoy Das
2021-01-12 21:38 ` Alex Deucher
2021-01-13 14:13   ` Christian König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.