From: "Potthuri, Sai Krishna" <sai.krishna.potthuri@amd.com> To: Borislav Petkov <bp@alien8.de> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Michal Simek <michal.simek@xilinx.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Tony Luck <tony.luck@intel.com>, James Morse <james.morse@arm.com>, Robert Richter <rric@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>, "saikrishna12468@gmail.com" <saikrishna12468@gmail.com>, "git (AMD-Xilinx)" <git@amd.com>, "Datta, Shubhrajyoti" <shubhrajyoti.datta@amd.com> Subject: RE: [PATCH v4 2/2] edac: zynqmp_ocm: Add EDAC support for ZynqMP OCM Date: Thu, 8 Sep 2022 05:39:56 +0000 [thread overview] Message-ID: <BY5PR12MB4258C4746631BBD6A7B388D6DB409@BY5PR12MB4258.namprd12.prod.outlook.com> (raw) In-Reply-To: <YxikJCguJWunfh6x@nazgul.tnic> Hi Boris, > -----Original Message----- > From: Borislav Petkov <bp@alien8.de> > Sent: Wednesday, September 7, 2022 7:31 PM > To: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com> > Cc: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Michal Simek > <michal.simek@xilinx.com>; Mauro Carvalho Chehab > <mchehab@kernel.org>; Tony Luck <tony.luck@intel.com>; James Morse > <james.morse@arm.com>; Robert Richter <rric@kernel.org>; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; linux-edac@vger.kernel.org; > saikrishna12468@gmail.com; git (AMD-Xilinx) <git@amd.com>; Datta, > Shubhrajyoti <shubhrajyoti.datta@amd.com> > Subject: Re: [PATCH v4 2/2] edac: zynqmp_ocm: Add EDAC support for > ZynqMP OCM > > On Wed, Sep 07, 2022 at 04:45:31PM +0530, Sai Krishna Potthuri wrote: > > Add EDAC support for Xilinx ZynqMP OCM Controller, this driver reports > > CE and UE errors based on the interrupts, and also creates ue/ce sysfs > > entries for error injection. > > > > Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com> > > I think you folks need to brush up on > > Documentation/process/submitting-patches.rst > > in order to build your SOB chain properly. Got it, i will add "Co-developed-by" tag and send v5. > > > diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index > > 58ab63642e72..08adedfd42b5 100644 > > --- a/drivers/edac/Kconfig > > +++ b/drivers/edac/Kconfig > > @@ -539,4 +539,13 @@ config EDAC_DMC520 > > Support for error detection and correction on the > > SoCs with ARM DMC-520 DRAM controller. > > > > +config EDAC_ZYNQMP_OCM > > + tristate "Xilinx ZynqMP OCM Controller" > > + depends on ARCH_ZYNQMP || COMPILE_TEST > > We already have an EDAC driver which depends on ARCH_ZYNQMP - the > Synopsys one. Can this one be made part of it? Synopsys EDAC driver is targeted for DDR Memory Controller and this driver is for OCM (On Chip Memory) Controller, both are different hardware controllers. Regards Sai Krishna
WARNING: multiple messages have this Message-ID (diff)
From: "Potthuri, Sai Krishna" <sai.krishna.potthuri@amd.com> To: Borislav Petkov <bp@alien8.de> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Michal Simek <michal.simek@xilinx.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Tony Luck <tony.luck@intel.com>, James Morse <james.morse@arm.com>, Robert Richter <rric@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>, "saikrishna12468@gmail.com" <saikrishna12468@gmail.com>, "git (AMD-Xilinx)" <git@amd.com>, "Datta, Shubhrajyoti" <shubhrajyoti.datta@amd.com> Subject: RE: [PATCH v4 2/2] edac: zynqmp_ocm: Add EDAC support for ZynqMP OCM Date: Thu, 8 Sep 2022 05:39:56 +0000 [thread overview] Message-ID: <BY5PR12MB4258C4746631BBD6A7B388D6DB409@BY5PR12MB4258.namprd12.prod.outlook.com> (raw) In-Reply-To: <YxikJCguJWunfh6x@nazgul.tnic> Hi Boris, > -----Original Message----- > From: Borislav Petkov <bp@alien8.de> > Sent: Wednesday, September 7, 2022 7:31 PM > To: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com> > Cc: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Michal Simek > <michal.simek@xilinx.com>; Mauro Carvalho Chehab > <mchehab@kernel.org>; Tony Luck <tony.luck@intel.com>; James Morse > <james.morse@arm.com>; Robert Richter <rric@kernel.org>; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; linux-edac@vger.kernel.org; > saikrishna12468@gmail.com; git (AMD-Xilinx) <git@amd.com>; Datta, > Shubhrajyoti <shubhrajyoti.datta@amd.com> > Subject: Re: [PATCH v4 2/2] edac: zynqmp_ocm: Add EDAC support for > ZynqMP OCM > > On Wed, Sep 07, 2022 at 04:45:31PM +0530, Sai Krishna Potthuri wrote: > > Add EDAC support for Xilinx ZynqMP OCM Controller, this driver reports > > CE and UE errors based on the interrupts, and also creates ue/ce sysfs > > entries for error injection. > > > > Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com> > > I think you folks need to brush up on > > Documentation/process/submitting-patches.rst > > in order to build your SOB chain properly. Got it, i will add "Co-developed-by" tag and send v5. > > > diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index > > 58ab63642e72..08adedfd42b5 100644 > > --- a/drivers/edac/Kconfig > > +++ b/drivers/edac/Kconfig > > @@ -539,4 +539,13 @@ config EDAC_DMC520 > > Support for error detection and correction on the > > SoCs with ARM DMC-520 DRAM controller. > > > > +config EDAC_ZYNQMP_OCM > > + tristate "Xilinx ZynqMP OCM Controller" > > + depends on ARCH_ZYNQMP || COMPILE_TEST > > We already have an EDAC driver which depends on ARCH_ZYNQMP - the > Synopsys one. Can this one be made part of it? Synopsys EDAC driver is targeted for DDR Memory Controller and this driver is for OCM (On Chip Memory) Controller, both are different hardware controllers. Regards Sai Krishna _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-08 5:40 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-07 11:15 [PATCH v4 0/2] edac: Add support for Xilinx ZynqMP OCM EDAC Sai Krishna Potthuri 2022-09-07 11:15 ` Sai Krishna Potthuri 2022-09-07 11:15 ` [PATCH v4 1/2] dt-bindings: edac: Add bindings for Xilinx ZynqMP OCM Sai Krishna Potthuri 2022-09-07 11:15 ` Sai Krishna Potthuri 2022-09-07 11:15 ` [PATCH v4 2/2] edac: zynqmp_ocm: Add EDAC support for " Sai Krishna Potthuri 2022-09-07 11:15 ` Sai Krishna Potthuri 2022-09-07 14:01 ` Borislav Petkov 2022-09-07 14:01 ` Borislav Petkov 2022-09-08 5:39 ` Potthuri, Sai Krishna [this message] 2022-09-08 5:39 ` Potthuri, Sai Krishna 2022-09-08 8:36 ` Boris Petkov 2022-09-08 8:36 ` Boris Petkov 2022-09-08 8:51 ` Potthuri, Sai Krishna 2022-09-08 8:51 ` Potthuri, Sai Krishna 2022-09-08 4:21 ` kernel test robot 2022-09-08 4:21 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BY5PR12MB4258C4746631BBD6A7B388D6DB409@BY5PR12MB4258.namprd12.prod.outlook.com \ --to=sai.krishna.potthuri@amd.com \ --cc=bp@alien8.de \ --cc=devicetree@vger.kernel.org \ --cc=git@amd.com \ --cc=james.morse@arm.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-edac@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=michal.simek@xilinx.com \ --cc=robh+dt@kernel.org \ --cc=rric@kernel.org \ --cc=saikrishna12468@gmail.com \ --cc=shubhrajyoti.datta@amd.com \ --cc=tony.luck@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.