From: Parav Pandit <parav@nvidia.com>
To: Alexander Duyck <alexander.duyck@gmail.com>,
David Ahern <dsahern@gmail.com>
Cc: Saeed Mahameed <saeed@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Netdev <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
David Ahern <dsahern@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
Sridhar Samudrala <sridhar.samudrala@intel.com>,
"Ertman, David M" <david.m.ertman@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Kiran Patil <kiran.patil@intel.com>,
Greg KH <gregkh@linuxfoundation.org>
Subject: RE: [net-next v4 00/15] Add mlx5 subfunction support
Date: Tue, 15 Dec 2020 16:59:26 +0000 [thread overview]
Message-ID: <BY5PR12MB43226C436EBE8201EB2D529EDCC60@BY5PR12MB4322.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAKgT0UfRWgkvezq2XVYGgxW2d1s+namb2r_e0=m9QN=e2O9WvA@mail.gmail.com>
> From: Alexander Duyck <alexander.duyck@gmail.com>
> Sent: Tuesday, December 15, 2020 9:47 PM
>
> On Mon, Dec 14, 2020 at 6:44 PM David Ahern <dsahern@gmail.com> wrote:
> >
> > On 12/14/20 6:53 PM, Alexander Duyck wrote:
> > >> example subfunction usage sequence:
> > >> -----------------------------------
> > >> Change device to switchdev mode:
> > >> $ devlink dev eswitch set pci/0000:06:00.0 mode switchdev
> > >>
> > >> Add a devlink port of subfunction flaovur:
> > >> $ devlink port add pci/0000:06:00.0 flavour pcisf pfnum 0 sfnum 88
> > >
> > > Typo in your description. Also I don't know if you want to stick
> > > with "flavour" or just shorten it to the U.S. spelling which is "flavor".
> >
> > The term exists in devlink today (since 2018). When support was added
> > to
> > iproute2 I decided there was no reason to require the US spelling over
> > the British spelling, so I accepted the patch.
>
> Okay. The only reason why I noticed is because "flaovur" is definitely a wrong
> spelling. If it is already in the interface then no need to change it.
I am using to write "flavor" and I realized that I should probably say "flavour" because in devlink it is that way.
So I added 'u' and typo added it at wrong location. :-)
Thanks for catching it.
Saeed sent the v5 fixing this along with few more English corrections.
next prev parent reply other threads:[~2020-12-15 17:00 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 21:43 [net-next v4 00/15] Add mlx5 subfunction support Saeed Mahameed
2020-12-14 21:43 ` [net-next v4 01/15] net/mlx5: Fix compilation warning for 32-bit platform Saeed Mahameed
2020-12-14 22:31 ` Alexander Duyck
2020-12-14 22:45 ` Saeed Mahameed
2020-12-15 4:59 ` Leon Romanovsky
2020-12-14 21:43 ` [net-next v4 02/15] devlink: Prepare code to fill multiple port function attributes Saeed Mahameed
2020-12-14 21:43 ` [net-next v4 03/15] devlink: Introduce PCI SF port flavour and port attribute Saeed Mahameed
2020-12-14 21:43 ` [net-next v4 04/15] devlink: Support add and delete devlink port Saeed Mahameed
2020-12-14 21:43 ` [net-next v4 05/15] devlink: Support get and set state of port function Saeed Mahameed
2020-12-14 21:43 ` [net-next v4 06/15] net/mlx5: Introduce vhca state event notifier Saeed Mahameed
2020-12-14 21:43 ` [net-next v4 07/15] net/mlx5: SF, Add auxiliary device support Saeed Mahameed
2020-12-14 21:43 ` [net-next v4 08/15] net/mlx5: SF, Add auxiliary device driver Saeed Mahameed
2020-12-14 21:43 ` [net-next v4 09/15] net/mlx5: E-switch, Prepare eswitch to handle SF vport Saeed Mahameed
2020-12-14 21:43 ` [net-next v4 10/15] net/mlx5: E-switch, Add eswitch helpers for " Saeed Mahameed
2020-12-14 21:43 ` [net-next v4 11/15] net/mlx5: SF, Add port add delete functionality Saeed Mahameed
2020-12-14 21:43 ` [net-next v4 12/15] net/mlx5: SF, Port function state change support Saeed Mahameed
2020-12-14 21:43 ` [net-next v4 13/15] devlink: Add devlink port documentation Saeed Mahameed
2020-12-14 21:43 ` [net-next v4 14/15] devlink: Extend devlink port documentation for subfunctions Saeed Mahameed
2020-12-14 21:43 ` [net-next v4 15/15] net/mlx5: Add devlink subfunction port documentation Saeed Mahameed
2020-12-15 1:53 ` [net-next v4 00/15] Add mlx5 subfunction support Alexander Duyck
2020-12-15 2:44 ` David Ahern
2020-12-15 16:16 ` Alexander Duyck
2020-12-15 16:59 ` Parav Pandit [this message]
2020-12-15 5:48 ` Parav Pandit
2020-12-15 18:47 ` Alexander Duyck
2020-12-15 20:05 ` Saeed Mahameed
2020-12-15 21:03 ` Jason Gunthorpe
2020-12-16 1:12 ` Edwin Peer
2020-12-16 2:39 ` Jason Gunthorpe
2020-12-16 3:12 ` Alexander Duyck
2020-12-15 20:59 ` David Ahern
2020-12-15 6:15 ` Saeed Mahameed
2020-12-15 19:12 ` Alexander Duyck
2020-12-15 20:35 ` Saeed Mahameed
2020-12-15 21:28 ` Jakub Kicinski
2020-12-16 6:50 ` Leon Romanovsky
2020-12-16 17:59 ` Saeed Mahameed
2020-12-15 21:41 ` Alexander Duyck
2020-12-16 0:19 ` Jason Gunthorpe
2020-12-16 2:19 ` Alexander Duyck
2020-12-16 3:03 ` Jason Gunthorpe
2020-12-16 4:13 ` Alexander Duyck
2020-12-16 4:45 ` Parav Pandit
2020-12-16 13:33 ` Jason Gunthorpe
2020-12-16 16:31 ` Alexander Duyck
2020-12-16 17:51 ` Jason Gunthorpe
2020-12-16 19:27 ` Alexander Duyck
2020-12-16 20:35 ` Jason Gunthorpe
2020-12-16 22:53 ` Alexander Duyck
2020-12-17 0:38 ` Jason Gunthorpe
2020-12-17 18:48 ` Alexander Duyck
2020-12-17 19:40 ` Jason Gunthorpe
2020-12-17 21:05 ` Alexander Duyck
2020-12-18 0:08 ` Jason Gunthorpe
2020-12-18 1:30 ` David Ahern
2020-12-18 3:11 ` Alexander Duyck
2020-12-18 3:55 ` David Ahern
2020-12-18 15:54 ` Alexander Duyck
2020-12-18 5:20 ` Parav Pandit
2020-12-18 5:36 ` Parav Pandit
2020-12-18 16:01 ` Alexander Duyck
2020-12-18 18:01 ` Parav Pandit
2020-12-18 19:22 ` Alexander Duyck
2020-12-18 20:18 ` Jason Gunthorpe
2020-12-19 0:03 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB43226C436EBE8201EB2D529EDCC60@BY5PR12MB4322.namprd12.prod.outlook.com \
--to=parav@nvidia.com \
--cc=alexander.duyck@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jacob.e.keller@intel.com \
--cc=jgg@nvidia.com \
--cc=kiran.patil@intel.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.