From: Parav Pandit <parav@nvidia.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, "jasowang@redhat.com" <jasowang@redhat.com>, Eli Cohen <elic@nvidia.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org> Subject: RE: [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user supported devices Date: Tue, 5 Jan 2021 12:02:33 +0000 [thread overview] Message-ID: <BY5PR12MB4322E5E7CA71CB2EE0577706DCD10@BY5PR12MB4322.namprd12.prod.outlook.com> (raw) In-Reply-To: <20210105064707-mutt-send-email-mst@kernel.org> > From: Michael S. Tsirkin <mst@redhat.com> > Sent: Tuesday, January 5, 2021 5:19 PM > > On Tue, Jan 05, 2021 at 12:32:03PM +0200, Parav Pandit wrote: > > Enable user to create vdpasim net simulate devices. > > > > > > $ vdpa dev add mgmtdev vdpasim_net name foo2 > > > > Show the newly created vdpa device by its name: > > $ vdpa dev show foo2 > > foo2: type network mgmtdev vdpasim_net vendor_id 0 max_vqs 2 > > max_vq_size 256 > > > > $ vdpa dev show foo2 -jp > > { > > "dev": { > > "foo2": { > > "type": "network", > > "mgmtdev": "vdpasim_net", > > "vendor_id": 0, > > "max_vqs": 2, > > "max_vq_size": 256 > > } > > } > > } > > > I'd like an example of how do device specific (e.g. net specific) interfaces tie > in to this. Not sure I follow your question. Do you mean how to set mac address or mtu of this vdpa device of type net? If so, dev add command will be extended shortly in subsequent series to set this net specific attributes. (I did mention in the next steps in cover letter). > > +static int __init vdpasim_net_init(void) { > > + int ret; > > + > > + if (macaddr) { > > + mac_pton(macaddr, macaddr_buf); > > + if (!is_valid_ether_addr(macaddr_buf)) > > + return -EADDRNOTAVAIL; > > + } else { > > + eth_random_addr(macaddr_buf); > > } > > Hmm so all devices start out with the same MAC until changed? And how is > the change effected? Post this patchset and post we have iproute2 vdpa in the tree, will add the mac address as the input attribute during "vdpa dev add" command. So that each different vdpa device can have user specified (different) mac address.
WARNING: multiple messages have this Message-ID (diff)
From: Parav Pandit <parav@nvidia.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Eli Cohen <elic@nvidia.com>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org> Subject: RE: [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user supported devices Date: Tue, 5 Jan 2021 12:02:33 +0000 [thread overview] Message-ID: <BY5PR12MB4322E5E7CA71CB2EE0577706DCD10@BY5PR12MB4322.namprd12.prod.outlook.com> (raw) In-Reply-To: <20210105064707-mutt-send-email-mst@kernel.org> > From: Michael S. Tsirkin <mst@redhat.com> > Sent: Tuesday, January 5, 2021 5:19 PM > > On Tue, Jan 05, 2021 at 12:32:03PM +0200, Parav Pandit wrote: > > Enable user to create vdpasim net simulate devices. > > > > > > $ vdpa dev add mgmtdev vdpasim_net name foo2 > > > > Show the newly created vdpa device by its name: > > $ vdpa dev show foo2 > > foo2: type network mgmtdev vdpasim_net vendor_id 0 max_vqs 2 > > max_vq_size 256 > > > > $ vdpa dev show foo2 -jp > > { > > "dev": { > > "foo2": { > > "type": "network", > > "mgmtdev": "vdpasim_net", > > "vendor_id": 0, > > "max_vqs": 2, > > "max_vq_size": 256 > > } > > } > > } > > > I'd like an example of how do device specific (e.g. net specific) interfaces tie > in to this. Not sure I follow your question. Do you mean how to set mac address or mtu of this vdpa device of type net? If so, dev add command will be extended shortly in subsequent series to set this net specific attributes. (I did mention in the next steps in cover letter). > > +static int __init vdpasim_net_init(void) { > > + int ret; > > + > > + if (macaddr) { > > + mac_pton(macaddr, macaddr_buf); > > + if (!is_valid_ether_addr(macaddr_buf)) > > + return -EADDRNOTAVAIL; > > + } else { > > + eth_random_addr(macaddr_buf); > > } > > Hmm so all devices start out with the same MAC until changed? And how is > the change effected? Post this patchset and post we have iproute2 vdpa in the tree, will add the mac address as the input attribute during "vdpa dev add" command. So that each different vdpa device can have user specified (different) mac address. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-01-05 12:03 UTC|newest] Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-12 6:39 [PATCH 0/7] Introduce vdpa management tool Parav Pandit 2020-11-12 6:39 ` Parav Pandit 2020-11-12 6:39 ` [PATCH 1/7] vdpa: Add missing comment for virtqueue count Parav Pandit 2020-11-12 6:39 ` Parav Pandit 2020-11-12 6:40 ` [PATCH 2/7] vdpa: Use simpler version of ida allocation Parav Pandit 2020-11-12 6:40 ` Parav Pandit 2020-11-12 6:40 ` [PATCH 3/7] vdpa: Extend routine to accept vdpa device name Parav Pandit 2020-11-12 6:40 ` Parav Pandit 2020-11-12 6:40 ` [PATCH 4/7] vdpa: Define vdpa parent device, ops and a netlink interface Parav Pandit 2020-11-12 6:40 ` Parav Pandit 2020-11-12 6:40 ` [PATCH 5/7] vdpa: Enable a user to add and delete a vdpa device Parav Pandit 2020-11-12 6:40 ` Parav Pandit 2020-11-12 6:40 ` [PATCH 6/7] vdpa: Enable user to query vdpa device info Parav Pandit 2020-11-12 6:40 ` Parav Pandit 2020-11-12 6:40 ` [PATCH 7/7] vdpa/vdpa_sim: Enable user to create vdpasim net devices Parav Pandit 2020-11-12 6:40 ` Parav Pandit 2020-11-16 9:41 ` [PATCH 0/7] Introduce vdpa management tool Stefan Hajnoczi 2020-11-16 9:41 ` Stefan Hajnoczi 2020-11-17 19:41 ` Parav Pandit 2020-11-17 19:41 ` Parav Pandit 2020-11-16 22:23 ` Jakub Kicinski 2020-11-17 19:51 ` Parav Pandit 2020-11-17 19:51 ` Parav Pandit 2020-12-16 9:13 ` Michael S. Tsirkin 2020-12-16 9:13 ` Michael S. Tsirkin [not found] ` <20201216080610.08541f44@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> 2020-12-16 16:54 ` Parav Pandit 2020-12-16 16:54 ` Parav Pandit 2020-12-16 19:57 ` Michael S. Tsirkin 2020-12-16 19:57 ` Michael S. Tsirkin 2020-12-17 12:13 ` Parav Pandit 2020-12-17 12:13 ` Parav Pandit 2020-11-27 3:53 ` Jason Wang 2020-11-27 3:53 ` Jason Wang [not found] ` <CACycT3sYScObb9nN3g7L3cesjE7sCZWxZ5_5R1usGU9ePZEeqA@mail.gmail.com> 2020-11-30 3:36 ` [External] " Jason Wang 2020-11-30 3:36 ` Jason Wang 2020-11-30 7:07 ` Yongji Xie 2020-12-01 6:25 ` Jason Wang 2020-12-01 6:25 ` Jason Wang 2020-12-01 9:55 ` Yongji Xie 2020-12-01 11:32 ` Parav Pandit 2020-12-01 11:32 ` Parav Pandit 2020-12-01 14:18 ` Yongji Xie 2020-12-01 15:58 ` Parav Pandit 2020-12-01 15:58 ` Parav Pandit 2020-12-02 3:29 ` Yongji Xie 2020-12-02 4:53 ` Parav Pandit 2020-12-02 4:53 ` Parav Pandit 2020-12-02 5:51 ` Jason Wang 2020-12-02 5:51 ` Jason Wang 2020-12-02 6:24 ` Parav Pandit 2020-12-02 6:24 ` Parav Pandit 2020-12-02 7:55 ` Jason Wang 2020-12-02 7:55 ` Jason Wang 2020-12-02 9:27 ` Yongji Xie 2020-12-02 9:21 ` Yongji Xie 2020-12-02 11:13 ` Parav Pandit 2020-12-02 11:13 ` Parav Pandit 2020-12-02 13:18 ` Yongji Xie 2020-12-02 5:48 ` Jason Wang 2020-12-02 5:48 ` Jason Wang 2020-12-08 22:47 ` David Ahern 2020-12-08 22:47 ` David Ahern 2021-01-19 4:21 ` Parav Pandit 2021-01-19 4:21 ` Parav Pandit 2020-12-16 9:16 ` Michael S. Tsirkin 2020-12-16 9:16 ` Michael S. Tsirkin 2021-01-04 3:31 ` [PATCH linux-next v2 " Parav Pandit 2021-01-04 3:31 ` Parav Pandit 2021-01-04 3:31 ` [PATCH linux-next v2 1/7] vdpa_sim_net: Make mac address array static Parav Pandit 2021-01-04 3:31 ` Parav Pandit 2021-01-04 7:00 ` Jason Wang 2021-01-04 7:00 ` Jason Wang 2021-01-04 3:31 ` [PATCH linux-next v2 2/7] vdpa_sim_net: Add module param to disable default vdpa net device Parav Pandit 2021-01-04 3:31 ` Parav Pandit 2021-01-04 3:31 ` [PATCH linux-next v2 3/7] vdpa: Extend routine to accept vdpa device name Parav Pandit 2021-01-04 3:31 ` Parav Pandit 2021-01-04 3:31 ` [PATCH linux-next v2 4/7] vdpa: Define vdpa mgmt device, ops and a netlink interface Parav Pandit 2021-01-04 3:31 ` Parav Pandit 2021-01-04 7:03 ` Jason Wang 2021-01-04 7:03 ` Jason Wang 2021-01-04 7:24 ` Parav Pandit 2021-01-04 7:24 ` Parav Pandit 2021-01-05 4:10 ` Jason Wang 2021-01-05 4:10 ` Jason Wang 2021-01-05 6:33 ` Parav Pandit 2021-01-05 6:33 ` Parav Pandit 2021-01-05 8:36 ` Jason Wang 2021-01-05 8:36 ` Jason Wang 2021-01-04 3:31 ` [PATCH linux-next v2 5/7] vdpa: Enable a user to add and delete a vdpa device Parav Pandit 2021-01-04 3:31 ` Parav Pandit 2021-01-04 3:31 ` [PATCH linux-next v2 6/7] vdpa: Enable user to query vdpa device info Parav Pandit 2021-01-04 3:31 ` Parav Pandit 2021-01-04 3:31 ` [PATCH linux-next v2 7/7] vdpa_sim_net: Add support for user supported devices Parav Pandit 2021-01-04 3:31 ` Parav Pandit 2021-01-04 7:05 ` Jason Wang 2021-01-04 7:05 ` Jason Wang 2021-01-04 7:21 ` Parav Pandit 2021-01-04 7:21 ` Parav Pandit 2021-01-05 4:06 ` Jason Wang 2021-01-05 4:06 ` Jason Wang 2021-01-05 6:22 ` Parav Pandit 2021-01-05 6:22 ` Parav Pandit 2021-01-05 10:31 ` [PATCH linux-next v3 0/6] Introduce vdpa management tool Parav Pandit 2021-01-05 10:31 ` Parav Pandit 2021-01-05 10:31 ` [PATCH linux-next v3 1/6] vdpa_sim_net: Make mac address array static Parav Pandit 2021-01-05 10:31 ` Parav Pandit 2021-01-07 13:45 ` Stefano Garzarella 2021-01-07 13:45 ` Stefano Garzarella 2021-01-05 10:31 ` [PATCH linux-next v3 2/6] vdpa: Extend routine to accept vdpa device name Parav Pandit 2021-01-05 10:31 ` Parav Pandit 2021-01-05 10:32 ` [PATCH linux-next v3 3/6] vdpa: Define vdpa mgmt device, ops and a netlink interface Parav Pandit 2021-01-05 10:32 ` Parav Pandit 2021-01-05 10:32 ` [PATCH linux-next v3 4/6] vdpa: Enable a user to add and delete a vdpa device Parav Pandit 2021-01-05 10:32 ` Parav Pandit 2021-01-05 10:32 ` [PATCH linux-next v3 5/6] vdpa: Enable user to query vdpa device info Parav Pandit 2021-01-05 10:32 ` Parav Pandit 2021-01-05 10:32 ` [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user supported devices Parav Pandit 2021-01-05 10:32 ` Parav Pandit 2021-01-05 11:48 ` Michael S. Tsirkin 2021-01-05 11:48 ` Michael S. Tsirkin 2021-01-05 12:02 ` Parav Pandit [this message] 2021-01-05 12:02 ` Parav Pandit 2021-01-05 12:14 ` Michael S. Tsirkin 2021-01-05 12:14 ` Michael S. Tsirkin 2021-01-05 12:30 ` Parav Pandit 2021-01-05 12:30 ` Parav Pandit 2021-01-05 13:23 ` Michael S. Tsirkin 2021-01-05 13:23 ` Michael S. Tsirkin 2021-01-07 3:48 ` Parav Pandit 2021-01-07 3:48 ` Parav Pandit 2021-01-12 4:14 ` Parav Pandit 2021-01-12 4:14 ` Parav Pandit 2021-01-14 4:17 ` Jason Wang 2021-01-14 4:17 ` Jason Wang 2021-01-14 7:58 ` Parav Pandit 2021-01-14 7:58 ` Parav Pandit 2021-01-15 5:38 ` Jason Wang 2021-01-15 5:38 ` Jason Wang 2021-01-15 6:27 ` Parav Pandit 2021-01-15 6:27 ` Parav Pandit 2021-01-19 11:09 ` Jason Wang 2021-01-19 11:09 ` Jason Wang 2021-01-20 3:21 ` Parav Pandit 2021-01-20 3:21 ` Parav Pandit 2021-01-20 3:46 ` Parav Pandit 2021-01-20 3:46 ` Parav Pandit 2021-01-18 18:03 ` Parav Pandit 2021-01-18 18:03 ` Parav Pandit 2021-01-20 7:53 ` Michael S. Tsirkin 2021-01-20 7:53 ` Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BY5PR12MB4322E5E7CA71CB2EE0577706DCD10@BY5PR12MB4322.namprd12.prod.outlook.com \ --to=parav@nvidia.com \ --cc=elic@nvidia.com \ --cc=jasowang@redhat.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.