* [PATCH] arm64: dts: zynqmp: Add power domain for the DisplayPort DMA controller @ 2021-03-06 23:09 Laurent Pinchart 2021-03-08 10:08 ` Michal Simek 2021-03-08 16:25 ` Michal Simek 0 siblings, 2 replies; 6+ messages in thread From: Laurent Pinchart @ 2021-03-06 23:09 UTC (permalink / raw) To: linux-arm-kernel; +Cc: Michal Simek The DisplayPort DMA controller (DPDMA) is located in the same power domain as the DisplayPort Subsystem (DPSUB). Specify the power domain in the device tree. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- I'm actually not entirely sure about the truthfulness of the commit message, as I haven't been able to located this information in the reference manual. Nonetheless, without this patch, I get a clock enable failure when starting the display: [ 70.517104] zynqmp_pll_enable() clock enable failed for vpll_int, ret = -22 [ 70.527552] zynqmp-dpsub fd4a0000.display: failed to enable a pixel clock I'm thus quite confident the patch is correct. If anyone has more information and would like to reword the commit message, please feel free to do so. arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi index c113c76f360d..dc5c3a09c77e 100644 --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi @@ -749,6 +749,7 @@ zynqmp_dpdma: dma-controller@fd4c0000 { interrupts = <0 122 4>; interrupt-parent = <&gic>; clock-names = "axi_clk"; + power-domains = <&zynqmp_firmware PD_DP>; #dma-cells = <1>; }; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: zynqmp: Add power domain for the DisplayPort DMA controller 2021-03-06 23:09 [PATCH] arm64: dts: zynqmp: Add power domain for the DisplayPort DMA controller Laurent Pinchart @ 2021-03-08 10:08 ` Michal Simek 2021-03-08 10:58 ` Rajan Vaja 2021-03-08 16:25 ` Michal Simek 1 sibling, 1 reply; 6+ messages in thread From: Michal Simek @ 2021-03-08 10:08 UTC (permalink / raw) To: Laurent Pinchart, linux-arm-kernel, Rajan Vaja; +Cc: Michal Simek Hi, On 3/7/21 12:09 AM, Laurent Pinchart wrote: > The DisplayPort DMA controller (DPDMA) is located in the same power > domain as the DisplayPort Subsystem (DPSUB). Specify the power domain in > the device tree. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > > I'm actually not entirely sure about the truthfulness of the commit > message, as I haven't been able to located this information in the > reference manual. Nonetheless, without this patch, I get a clock enable > failure when starting the display: > > [ 70.517104] zynqmp_pll_enable() clock enable failed for vpll_int, ret = -22 > [ 70.527552] zynqmp-dpsub fd4a0000.display: failed to enable a pixel clock > > I'm thus quite confident the patch is correct. If anyone has more > information and would like to reword the commit message, please feel > free to do so. > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > index c113c76f360d..dc5c3a09c77e 100644 > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > @@ -749,6 +749,7 @@ zynqmp_dpdma: dma-controller@fd4c0000 { > interrupts = <0 122 4>; > interrupt-parent = <&gic>; > clock-names = "axi_clk"; > + power-domains = <&zynqmp_firmware PD_DP>; > #dma-cells = <1>; > }; > > Rajan: Can you please comment this? Thanks, Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] arm64: dts: zynqmp: Add power domain for the DisplayPort DMA controller 2021-03-08 10:08 ` Michal Simek @ 2021-03-08 10:58 ` Rajan Vaja 2021-03-08 11:00 ` Michal Simek 0 siblings, 1 reply; 6+ messages in thread From: Rajan Vaja @ 2021-03-08 10:58 UTC (permalink / raw) To: Michal Simek, Laurent Pinchart, linux-arm-kernel; +Cc: Michal Simek Hi, > -----Original Message----- > From: Michal Simek <michal.simek@xilinx.com> > Sent: Monday, March 8, 2021 2:09 AM > To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>; linux-arm- > kernel@lists.infradead.org; Rajan Vaja <RAJANV@xilinx.com> > Cc: Michal Simek <michals@xilinx.com> > Subject: Re: [PATCH] arm64: dts: zynqmp: Add power domain for the DisplayPort > DMA controller > > Hi, > > On 3/7/21 12:09 AM, Laurent Pinchart wrote: > > The DisplayPort DMA controller (DPDMA) is located in the same power > > domain as the DisplayPort Subsystem (DPSUB). Specify the power domain in > > the device tree. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > > > I'm actually not entirely sure about the truthfulness of the commit > > message, as I haven't been able to located this information in the > > reference manual. Nonetheless, without this patch, I get a clock enable > > failure when starting the display: > > > > [ 70.517104] zynqmp_pll_enable() clock enable failed for vpll_int, ret = -22 > > [ 70.527552] zynqmp-dpsub fd4a0000.display: failed to enable a pixel clock > > > > I'm thus quite confident the patch is correct. If anyone has more > > information and would like to reword the commit message, please feel > > free to do so. > > > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > index c113c76f360d..dc5c3a09c77e 100644 > > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > @@ -749,6 +749,7 @@ zynqmp_dpdma: dma-controller@fd4c0000 { > > interrupts = <0 122 4>; > > interrupt-parent = <&gic>; > > clock-names = "axi_clk"; > > + power-domains = <&zynqmp_firmware PD_DP>; > > #dma-cells = <1>; > > }; > > > > > > Rajan: Can you please comment this? [Rajan] Change looks fine to me. If power-domain entry is not present in device tree node, that device would not be requested and hence clock control would fail. > > Thanks, > Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: zynqmp: Add power domain for the DisplayPort DMA controller 2021-03-08 10:58 ` Rajan Vaja @ 2021-03-08 11:00 ` Michal Simek 2021-03-08 12:50 ` Rajan Vaja 0 siblings, 1 reply; 6+ messages in thread From: Michal Simek @ 2021-03-08 11:00 UTC (permalink / raw) To: Rajan Vaja, Laurent Pinchart, linux-arm-kernel Hi, On 3/8/21 11:58 AM, Rajan Vaja wrote: > Hi, > >> -----Original Message----- >> From: Michal Simek <michal.simek@xilinx.com> >> Sent: Monday, March 8, 2021 2:09 AM >> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>; linux-arm- >> kernel@lists.infradead.org; Rajan Vaja <RAJANV@xilinx.com> >> Cc: Michal Simek <michals@xilinx.com> >> Subject: Re: [PATCH] arm64: dts: zynqmp: Add power domain for the DisplayPort >> DMA controller >> >> Hi, >> >> On 3/7/21 12:09 AM, Laurent Pinchart wrote: >>> The DisplayPort DMA controller (DPDMA) is located in the same power >>> domain as the DisplayPort Subsystem (DPSUB). Specify the power domain in >>> the device tree. >>> >>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> --- >>> >>> I'm actually not entirely sure about the truthfulness of the commit >>> message, as I haven't been able to located this information in the >>> reference manual. Nonetheless, without this patch, I get a clock enable >>> failure when starting the display: >>> >>> [ 70.517104] zynqmp_pll_enable() clock enable failed for vpll_int, ret = -22 >>> [ 70.527552] zynqmp-dpsub fd4a0000.display: failed to enable a pixel clock >>> >>> I'm thus quite confident the patch is correct. If anyone has more >>> information and would like to reword the commit message, please feel >>> free to do so. >>> >>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >> b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >>> index c113c76f360d..dc5c3a09c77e 100644 >>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >>> @@ -749,6 +749,7 @@ zynqmp_dpdma: dma-controller@fd4c0000 { >>> interrupts = <0 122 4>; >>> interrupt-parent = <&gic>; >>> clock-names = "axi_clk"; >>> + power-domains = <&zynqmp_firmware PD_DP>; >>> #dma-cells = <1>; >>> }; >>> >>> >> >> Rajan: Can you please comment this? > [Rajan] Change looks fine to me. If power-domain entry is not present in device tree node, that device would not be requested and hence clock control would fail. The key point here is if DPDMA is in also in PD_DP or there is separate one. And can you please send any tag? acked-by, etc? Thanks, Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] arm64: dts: zynqmp: Add power domain for the DisplayPort DMA controller 2021-03-08 11:00 ` Michal Simek @ 2021-03-08 12:50 ` Rajan Vaja 0 siblings, 0 replies; 6+ messages in thread From: Rajan Vaja @ 2021-03-08 12:50 UTC (permalink / raw) To: Michal Simek, Laurent Pinchart, linux-arm-kernel Hi Michal, > -----Original Message----- > From: Michal Simek <michal.simek@xilinx.com> > Sent: Monday, March 8, 2021 3:00 AM > To: Rajan Vaja <RAJANV@xilinx.com>; Laurent Pinchart > <laurent.pinchart@ideasonboard.com>; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH] arm64: dts: zynqmp: Add power domain for the DisplayPort > DMA controller > > Hi, > > On 3/8/21 11:58 AM, Rajan Vaja wrote: > > Hi, > > > >> -----Original Message----- > >> From: Michal Simek <michal.simek@xilinx.com> > >> Sent: Monday, March 8, 2021 2:09 AM > >> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>; linux-arm- > >> kernel@lists.infradead.org; Rajan Vaja <RAJANV@xilinx.com> > >> Cc: Michal Simek <michals@xilinx.com> > >> Subject: Re: [PATCH] arm64: dts: zynqmp: Add power domain for the > DisplayPort > >> DMA controller > >> > >> Hi, > >> > >> On 3/7/21 12:09 AM, Laurent Pinchart wrote: > >>> The DisplayPort DMA controller (DPDMA) is located in the same power > >>> domain as the DisplayPort Subsystem (DPSUB). Specify the power domain in > >>> the device tree. > >>> > >>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >>> --- > >>> > >>> I'm actually not entirely sure about the truthfulness of the commit > >>> message, as I haven't been able to located this information in the > >>> reference manual. Nonetheless, without this patch, I get a clock enable > >>> failure when starting the display: > >>> > >>> [ 70.517104] zynqmp_pll_enable() clock enable failed for vpll_int, ret = -22 > >>> [ 70.527552] zynqmp-dpsub fd4a0000.display: failed to enable a pixel clock > >>> > >>> I'm thus quite confident the patch is correct. If anyone has more > >>> information and would like to reword the commit message, please feel > >>> free to do so. > >>> > >>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > >> b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > >>> index c113c76f360d..dc5c3a09c77e 100644 > >>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > >>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > >>> @@ -749,6 +749,7 @@ zynqmp_dpdma: dma-controller@fd4c0000 { > >>> interrupts = <0 122 4>; > >>> interrupt-parent = <&gic>; > >>> clock-names = "axi_clk"; > >>> + power-domains = <&zynqmp_firmware PD_DP>; > >>> #dma-cells = <1>; > >>> }; > >>> > >>> > >> > >> Rajan: Can you please comment this? > > [Rajan] Change looks fine to me. If power-domain entry is not present in device > tree node, that device would not be requested and hence clock control would > fail. > > The key point here is if DPDMA is in also in PD_DP or there is separate > one. And can you please send any tag? acked-by, etc? [Rajan] There is no separate node for DPDMA. DPDMA clock is bind to DP device in firmware. > > Thanks, > Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: zynqmp: Add power domain for the DisplayPort DMA controller 2021-03-06 23:09 [PATCH] arm64: dts: zynqmp: Add power domain for the DisplayPort DMA controller Laurent Pinchart 2021-03-08 10:08 ` Michal Simek @ 2021-03-08 16:25 ` Michal Simek 1 sibling, 0 replies; 6+ messages in thread From: Michal Simek @ 2021-03-08 16:25 UTC (permalink / raw) To: Laurent Pinchart, linux-arm-kernel; +Cc: Michal Simek On 3/7/21 12:09 AM, Laurent Pinchart wrote: > The DisplayPort DMA controller (DPDMA) is located in the same power > domain as the DisplayPort Subsystem (DPSUB). Specify the power domain in > the device tree. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > > I'm actually not entirely sure about the truthfulness of the commit > message, as I haven't been able to located this information in the > reference manual. Nonetheless, without this patch, I get a clock enable > failure when starting the display: > > [ 70.517104] zynqmp_pll_enable() clock enable failed for vpll_int, ret = -22 > [ 70.527552] zynqmp-dpsub fd4a0000.display: failed to enable a pixel clock > > I'm thus quite confident the patch is correct. If anyone has more > information and would like to reword the commit message, please feel > free to do so. > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > index c113c76f360d..dc5c3a09c77e 100644 > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > @@ -749,6 +749,7 @@ zynqmp_dpdma: dma-controller@fd4c0000 { > interrupts = <0 122 4>; > interrupt-parent = <&gic>; > clock-names = "axi_clk"; > + power-domains = <&zynqmp_firmware PD_DP>; > #dma-cells = <1>; > }; > > Applied. M _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-08 16:27 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-03-06 23:09 [PATCH] arm64: dts: zynqmp: Add power domain for the DisplayPort DMA controller Laurent Pinchart 2021-03-08 10:08 ` Michal Simek 2021-03-08 10:58 ` Rajan Vaja 2021-03-08 11:00 ` Michal Simek 2021-03-08 12:50 ` Rajan Vaja 2021-03-08 16:25 ` Michal Simek
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.